summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2020-05-27sfx2: sidebar: publish created notification on Mobile tooAshod Nakashian1-19/+18
Reviewed-on: https://gerrit.libreoffice.org/85011 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 50af967b731495be6645f065fd11b9ad832a654a) Change-Id: I59e5db039a6c1f29cb13e7c77a782659dbfb6894 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85786 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2020-05-27sfx2: sidebar: notify mobile when the sidebar closesAshod Nakashian1-1/+17
Change-Id: Idb05346a9ccc8690cad566b74ec86d5fdd3bfb35 Reviewed-on: https://gerrit.libreoffice.org/84973 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2020-05-27vcl: sfx2: LOK: Support per-view popup windowsAshod Nakashian35-324/+488
While we do support multiple views, there is only one state for popup/floating windows, that also includes the dialogs open and related windows/data. This adds support to allow each view to have its own popups and state, thus allowing multiple users to interact with the dialogs independently of one another. (cherry picked from commit b50c341a53911f1d725947a4d8d3d2f782c94079) Change-Id: I3786a561ca6ca113ad12425bdb491e5a30bd1a28 Reviewed-on: https://gerrit.libreoffice.org/82440 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/85221 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-05-27sidebar: sensible line and page sizes and invalidateAshod Nakashian1-0/+3
Change-Id: Icf60480a47d7c93bad44f6457bb05af332e63c6d Reviewed-on: https://gerrit.libreoffice.org/84718 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2020-05-27LOK: don't send LOK notifications while switching viewsAshod Nakashian2-24/+55
Changing the active view is done for virtually every LOK API, and in some cases simply changing the view results in a flurry of notifications that themselves caues further API calls that need to change the view. This moves the disabling of callbacks during setView to SfxLokHelper to make sure no view gets any notifications. This is needed because even when we disable notifications for the current view, the _other_ view(s) can still get notified as they lose their frame. Change-Id: Ia88a58d6a1162e48c40f4c4ce73c40ecb2c1fb7e Reviewed-on: https://gerrit.libreoffice.org/84417 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2020-05-27Use INVALID_POOL_ITEM instead of magic numberSzymon Kłos1-1/+1
Change-Id: I44fdc602563164944bee40848b13de0c0c62e4f7 Reviewed-on: https://gerrit.libreoffice.org/85019 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-05-27Avoid crash when no uno name availableSzymon Kłos1-4/+8
Change-Id: I81895e68d6fda46bec0cc3bca2da63901d3fed4c Reviewed-on: https://gerrit.libreoffice.org/84950 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-05-27jsdialogs: make possible to use on multiple mobile devicesSzymon Kłos1-2/+3
Change-Id: I1f7867dfd15e423f10622b3cec17ed8039d23c49 Reviewed-on: https://gerrit.libreoffice.org/84367 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-05-27sidebar: always trigger LOK notifications on resizeAshod Nakashian1-1/+2
This is critical for the Mobile Wizard, which refreshes by pushing, not pulling (following invalidations). Change-Id: Ie75c2f5c07798fa89c21901d6d0233c42768ea8d Reviewed-on: https://gerrit.libreoffice.org/84359 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2020-05-27sidebar: do not emit unnecessary created notificationsAshod Nakashian1-12/+33
This also breaks a potentially recursive cycle where each 'created' notification requests a re-rendering, which triggers view change (when more than one view is open on the doc), which triggers a frame change, which resets the sidebar, causing a 'created' notification, thereby starting the cycle anew. Change-Id: I1aafe7f45871748afb393fa55c357037215e6c33 Reviewed-on: https://gerrit.libreoffice.org/83629 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2020-05-27sidebar: reset the LOKNotifier when the ViewShell changesAshod Nakashian4-45/+28
The ViewShell (which implements the LOKNotifier interface) changes during the lifetime of the SidebarDockingWindow. This is extremely problematic, because we assign the LOKNotifier to a window, and use it to emit notifications to the LOKit clients. When the ViewShell changes, a window (the SidebarDockingWindow in this case) may end up using an old ViewShell instance, which may have just been destroyed. Now we properly reset the LOKNotifier to make sure we are using the current ViewShell at all times. This is still not ideal, since we may use the wrong ViewShell to send out notifications, but we can't control that as we are at the mercy of the mechanism that changes the current ViewShell. This also removes obsolete flags to control which document-types supported sidebar, as well as other misc cleanups. Change-Id: Ic208f64596a39feb7354958cf4d5e1e033d87b5b Reviewed-on: https://gerrit.libreoffice.org/83627 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2020-05-27sidebars: add JSDialog support to sidebarsAshod Nakashian2-6/+57
Currently the JSDialog path is only for mobile and we use the passive notifications for desktop Online. Change-Id: I5d26fee9475ede665f269ca1f7b582455be08e50 Reviewed-on: https://gerrit.libreoffice.org/81754 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2020-05-27oox smartart import, composite alg: implement vertical centeringMiklos Vajna2-0/+31
The bugdoc's case was that the total height would be used by 2 shapes, but then a constraint decreases the height of one shape, so not all vertical space is used. We used to just count from the top, need to center vertically, as PowerPoint does it. (cherry picked from commit acdde3c643fde015214c546b1567727272ea799e) Change-Id: I436019e9e837b73130e387c9bcd309e20045b0f9
2020-05-27oox smartart import: fix aspect ratio of shape with composite algoMiklos Vajna3-20/+109
The layout node has alg=composite, then a parTx and a desTx child layout nodes. No matter what order is used (parent first, child first), the result will be wrong, as the constraints refer to each other. I did not spot any description in ISO 29500-1 that would describe what is the expected behavior. Researching this, found "One other consideration when specifying composite constraints is that the constraints must be specified in the same order as the nested layout nodes." at <http://web.archive.org/web/20111015151600/http://msdn.microsoft.com/en-us/magazine/cc163470.aspx>, which suggests to handle constraints for each shape in a parent -> child order, but keep a shared state when iterating over the children which gives us: - parent node, all direct constraints - for each child node: - child's constraints from parent - child's own constraints This way the desTx top value can depend on the parTx's height, and it's supported to define parTx's height only in the parTx layout node, not in the composite parent. And after all, it matches what PowerPoint does, so the column headings in the bugdoc have a 4:10 height:width aspect ratio. (cherry picked from commit 414586649582e182b2603702f4f586f4beeed8a9) Change-Id: Ideb76c1ddd1ffff8d2a217cddf81106d1bb97eb9
2020-05-27smartart import: handle multiple <a:schemeClr> in <dgm:fillClrLst>Miklos Vajna10-29/+105
The TODO in the ColorFragmentHandler ctor was right: we only handled the last <a:schemeClr> child, but there can be multiple one. Use them based on the index of a shape in a <dgm:forEach> loop. Move the TODO to the only place which still assumes a single color in the color list. (cherry picked from commit 12bea6c897822964ad4705418da54411cb15749e) Conflicts: oox/source/drawingml/colorchoicecontext.cxx oox/source/drawingml/diagram/diagram.cxx sd/qa/unit/import-tests-smartart.cxx Change-Id: I1c5c4f82e621f1110ef06b0490ff79f82f60f214
2020-05-27Fix test UI_chartSzymon Kłos3-8/+16
Sync chart wizard code with master Change-Id: I4ab2cbfa9efd3caca3c7951150b7daa3a133b634
2020-05-27Add an option to create encyrpted PDF files with mailmerge.Gülşah Köse11-18/+235
With that option user can create encyrpted pdf files with a password column in database via mailmerge. Change-Id: I081ef050bc269b1fec24fd01ecc812acd7b857ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94709 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> (cherry picked from commit 983db96a17630be906b868d2be811663f0d846f6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94689 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-05-27tdf#131230: Sidebar: Can't set Automatic colorPranam Lashkari2-4/+3
This also solved the issue in sidebar with some controls when selecting an item it selects the item below Change-Id: I607b8bc44402b57b5c4833f918fb41b23ddf48c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93099 Tested-by: Marco Cecchetti <marco.cecchetti@collabora.com> Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94855 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-05-27resolved: page gradient reset on reopening docPranam Lashkari1-3/+9
in mobile phone Slide background set to gradient becomes black/white after reopening Change-Id: Ib579856c3df8b89c74b381f3d79870c467802848 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92831 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94854 Tested-by: Andras Timar <andras.timar@collabora.com>
2020-05-27use "To Background" and "To Foreground" only in writer sidebarPranam Lashkari3-2/+56
Change-Id: Ib7ccac192721b663c9655417fc3d639766d0424d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91267 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94853 Tested-by: Andras Timar <andras.timar@collabora.com>
2020-05-27Added parameter to FillPageGradient commandPranam Lashkari3-8/+50
Change-Id: Ife435fc25e8e3114e66461af22ac9e0ef8c9d011 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92235 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94852 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-05-27Added parameter to FillPageColor commandPranam Lashkari5-4/+90
Change-Id: I22943815b69eeb7628eb243e0dbc6c8e0ea3487e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94851 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-05-27added clear Direct Formatting button in calc sidebarPranam Lashkari1-1/+10
Change-Id: I7f18c696eb32332d9c65145e7788370304d91ea6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93812 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94850 Tested-by: Andras Timar <andras.timar@collabora.com>
2020-05-27fixed clear Direct Formatting button to sidebar in impressPranam Lashkari3-0/+34
Change-Id: I81cd30b3ce7087122c260dca99e86a3c857447b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93648 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94829 Tested-by: Andras Timar <andras.timar@collabora.com>
2020-05-27Revert "tdf#104017 DOC export: be less aggressive with merging page styles"Justin Luth8-10/+55
This reverts LO 6.3.4 commit 5d1709a7c4184eb31cfc4c2d3acadff3a4a68189, which tdf#133334 shows is wrong. How this made it past QA is a mystery to me. There should be lots of examples. Change-Id: I17be6e4bab44057f4535d4728825e12d068b65d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94782 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 42a37f8ce27ad8fca222f50b712a8fed52dbda95) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94683
2020-05-27Revert "tdf#37268: use also sheet local range in Pivot"Julien Nabet2-52/+6
This reverts commit 73af06a6a7fcb2d92d36a45bbe54395bcba8dfb0. The patch is wrong according to: https://bugs.documentfoundation.org/show_bug.cgi?id=37268#c24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94748 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 818af4717bd7d4fbb6f622128c99259efb0714c9) Change-Id: I63dd69afa3fc324930cd16ccc3458372d7745531 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94684 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-05-27tdf#133348 remove from list before calling SetActiveSidebarWinJulien Nabet1-2/+4
so GetNextPostIt won't deal with mvPostItFields containing empty unique_ptr See bt here: https://bugs.documentfoundation.org/attachment.cgi?id=161242 Change-Id: I7c9a3e91d5186492cb185f799b60d1dcc5edf7af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94766 (cherry picked from commit b0bbfdf89d6496ffda4dc409ec5f2add8c94fe2a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94680 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-27Resolves: tdf#129620 crash because there is no associated windowCaolán McNamara1-4/+9
only an outputdevice in this editeng-in-a-widget case Change-Id: Idf054872a48befba652012cd511e4f9df4437166 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94282 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-27ChartTypePanel: Remove unused varsMuhammet Kara1-6/+0
Change-Id: I6a19fa269efaf008345b48341d1c501e1c7e7d17 Reviewed-on: https://gerrit.libreoffice.org/82244 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82812 Tested-by: Jenkins Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94898 Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-05-27Rename getCurrentParamter() as getCurrentParameter()Muhammet Kara2-6/+6
Change-Id: I0116b4526fea377130b1d1e101d30b3107af3c81 Reviewed-on: https://gerrit.libreoffice.org/82243 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82811 Tested-by: Jenkins Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94897 Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-05-27Remove unused var m_xChartTypeLabelMuhammet Kara2-2/+0
Change-Id: I3de7eb4e438021f9522e581c60a84fb7fcc168c7 Reviewed-on: https://gerrit.libreoffice.org/82242 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82810 Tested-by: Jenkins Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94896 Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-05-27Add SplineResourceGroup to ChartTypePanelMuhammet Kara2-9/+11
Change-Id: I229eb1cc4963c04968ed9ac32b65847dbfd602c3 Reviewed-on: https://gerrit.libreoffice.org/82807 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94895 Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-05-27Add more resource groups to ChartTypePanelMuhammet Kara2-30/+35
Change-Id: I64c1d8b418f9abb537b4f23c3b31aa0e48bd3faa Reviewed-on: https://gerrit.libreoffice.org/82119 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82801 Tested-by: Jenkins Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94894 Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-05-27chart2: Weld ChartTypePanelMuhammet Kara4-288/+277
Change-Id: I8ed178ffe0d880b362f98b9754bce40b20942bd7 Reviewed-on: https://gerrit.libreoffice.org/82768 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94893 Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-05-27vcl: don't use null window in FloatingWindow HitTestAshod Nakashian1-0/+2
Change-Id: I551f31cf30c7a58642becebe0256684055d0703a Reviewed-on: https://gerrit.libreoffice.org/85383 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 65685bac09a4320602f4dda5151d247c5a83a75c)
2020-05-27vcl: avoid accessing null member on unloading viewsAshod Nakashian1-2/+3
Change-Id: If4e416c7257c861b9e13352b3329d9719b159e61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87830 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com> (cherry picked from commit 9ec3d637c1c99c729da67eafc375efce1cc7f026)
2020-05-27lok: send "EMPTY" if the rect is empty for cell selection or fillTomaž Vajngerl1-7/+19
It can happen that the selection or auto-fill rectangles are empty and if that's the case then we need to send "EMPTY" string and not the content of an empty rectangle (0, 0, -32768, -32768). This can happen for CELL_SELECTION_AREA or CELL_AUTO_FILL_AREA in calc. Change-Id: I9a60e3907a2ab8b0e0fd1a2ff81137fba6c8e9a3 Reviewed-on: https://gerrit.libreoffice.org/85437 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit df6871286d7b769bc47554955213a2d727c47875)
2020-05-26lokit: fix edit-text/view-cursor positionDennis Francis7-37/+223
in case of views with heterogeneous zooms. 1. EditText render position fix The EditView has an 'output-area' which is used to clip the rectangle we pass to the Paint() call. It also holds on to the ScGridWindow instance where the edit started. The 'output-area' of the EditView is in the coordinates/units of the MapMode of the ScGridWindow it holds. So we need to temporarily change the MapMode and 'output-area' of the EditView in agreement to the device(with the current view's zoom settings) where we are going to paint to. After we call the Paint(), we rollback the original settings of the EditView. 2. EditViewCursor position fix Before this change the cursor position in twips (calculated based on pixel aligned cell position in the view where editing occurred) is broadcasted to all the client-views. If the clients have different zooms, then simply scaling this common cursor position in the client for its zoom is not going to be accurate enough (due to the non-linear Logic->Pixel->Logic transformation involving pixel rounding). This is very visible if you are editing far away from A1 (like Z50). The fix is to turn off this broadcast for calc-cell editing and send view specific edit-cursor invalidation messages. This is accompanied by a online.git patch that removes unnessecary broadcast of view-cursor invalidation messages which messes up things again. "Do not broadcast view-cursor invalidation messages" Change-Id: Ib2fbbe4b6f93f26fc85d6adaa8684dd4397d886f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92631 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit d58f1e334245f9e136750fbba267c2a941a213cc) Conflicts: editeng/source/editeng/impedit.hxx
2020-05-26mobile: escape JSON for function wizard, and emit only on mobile.Michael Meeks1-5/+16
Otherwise typing "-> wa" into a cell gives JS exceptions. Change-Id: I5303186fe9f84e055d65cf1929ccf5a7a20cae35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86705 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit ff365eb193279bb9866b8fad7378f6068b207051)
2020-05-26lok: calc - update our version of the other view's selections on zoom.Michael Meeks3-2/+40
Change-Id: I4d23bb77045b41d04109e7dd70a1f47bca8aaa56 Reviewed-on: https://gerrit.libreoffice.org/84767 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit ca2fdd792de5d6d208097b3049238865058c7cc1)
2020-05-26lok: calc - update our version of the other view's selections on zoom.Michael Meeks4-26/+60
Change-Id: I8487f28d762c8bf5be4f00a331263218dc71d179 Reviewed-on: https://gerrit.libreoffice.org/84694 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 2986620074d104611a6e78c98ee5a09941866125)
2020-05-26lok: calc - send other views our selection in their co-ordinates.Michael Meeks5-35/+82
Change-Id: If48b5adb9b8b03310d2d2c4e4fefab84ad8bb149 Reviewed-on: https://gerrit.libreoffice.org/84370 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit ab07df7ee12aef8bb3770e69d22ecb272d379ece)
2020-05-26lok: send other views our cursor position in their view co-ordinates.Michael Meeks1-17/+31
Change-Id: If8d84a04e8d7b4863dcb9bc9058939b1eb793266 (cherry picked from commit c6b18508aec0e609b4c3c000faf89c21e93620bd)
2020-05-26lok: avoid crash cleaning up help-windows with multiple views.Michael Meeks1-6/+13
Change-Id: Ic57018396de7730d9fa4fb3b4803a221cb9678da Reviewed-on: https://gerrit.libreoffice.org/84999 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 435659fd7e401353fc114246813b811190362293)
2020-05-26lokit: unify fill transparency itemsDennis Francis2-0/+53
Online just listens to .uno:FillFloatTransparence but the set-item in core it corresponds to, does not represent the fill-transparency types like 'None' and 'Solid'. This is represented by another item called XFillTransparencyItem. As a result the mobile wizard does not show the correct transparency fill type always. To solve this, this patch encodes the constant transparency percentage in case of Solid and None(always 0%) as an intensity and stores this info in the statechange message of .uno:FillFloatTransparence whenever there is no gradient type and corrects the 'style' attribute of the message appropriately. More detailed information is provided as comments at appropriate places in the patch. Change-Id: I443ef4ce349badf28f6c2c702b1014868d9c6ed5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90878 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 8f062cdae1c71c9dd2a1e3f81617b08ac7463c5d)
2020-05-26Remove unused lokit-only selection properties in..Dennis Francis1-11/+0
CID string for charts. This is messing up the parsing of CID string in ObjectIdentifier::getObjectType() and elsewhere where parsing CID is attempted, which inturn causes at least the sidebar's chart line properties listboxes not getting updated. The selection properties insertion in chart CID was introduced in commit 3d705b98ca7f40a44f632f5565407274322ffde3 but these are not even used in online as of present. Change-Id: Ic8040d84e1ad16f182fc7bdc3a9f533ad9664458 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89300 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit eea0bc558fc1ac8d5c1537df2cf95f73720f3620) Conflicts: chart2/source/controller/main/ChartController_Window.cxx
2020-05-26Allow boolean valued statechange messages for...Dennis Francis3-7/+33
object align commands : ObjectAlignLeft [SID_OBJECT_ALIGN_LEFT] ObjectAlignRight [SID_OBJECT_ALIGN_RIGHT] AlignCenter [SID_OBJECT_ALIGN_CENTER] What is pending is to set correct align state items for Impress in DrawViewShell::GetMenuStateSel(). For doing that we need to store the object align state somewhere when we execute SID_OBJECT_ALIGN_* in DrawViewShell::FuTemporary(). For Writer the align state information was already available in frame-format-manager object. Conflicts: desktop/source/lib/init.cxx Change-Id: I86fcf59cfc66af98097611277201ecaa3b8c22cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88077 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 00e1597c9a8a3451ae4d67ac0d1257c5ccac6a16)
2020-05-25lok: MSForms: fix form field related unit tests.Tamás Zolnai1-0/+4
Change-Id: I452175a680fe58cf6f2b0cd801659354fc83ee11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94794 Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-24lok: MSForms: update callback's documentation.Tamás Zolnai1-1/+6
Change-Id: I1bf41986f63a18abada7d268dc610df24b4c1144 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94661 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-24MSForms: fix rendering of form field button.Tamás Zolnai2-9/+5
It's not enough to check the paint area. because it's in logic units, which does not change by zooming. Change-Id: I9ee51c03e7edc2c70d91d6ef6dbaaae8c2c7beff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94400 Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>