summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2023-05-03update creditslibreoffice-7-4Christian Lohmaier1-1764/+1781
Change-Id: I3243e55b996f8a647fbe060f83a76d3ee416e6b9 (cherry picked from commit f1fd3e32508ee3e8aca6f90724e7af8664652e41)
2023-05-03Update git submodulesChristian Lohmaier1-0/+0
* Update translations from branch 'libreoffice-7-4' to 91b3354f452db7b03a84fb9ad22d89ca90851baa - update translations for 7.4.7 rc2 and force-fix errors using pocheck Change-Id: I5489943fe7ad1c7ca848e29853183cc47e64c297
2023-05-02Resolves: tdf#119659 Check found position for result vectorEike Rathke1-1/+8
Change-Id: Idc454462c47b6c7b7b7cb6c86b08650d059221c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151186 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 6b6b83b43fcae13e30a9ca67b421187a5e0d7142) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151191 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-28tdf#152577 sc DBData: fix regression of database rangesTünde Tóth2-2/+27
Regression from commit 0c0444c44107f1a18f23dd0833d462d8dbf56569 "tdf#126926 sc DBData: delete the database range". Change-Id: I04923decdc768770f98763e60cd295400d15c769 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151065 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151121
2023-04-28assume IFrame script/macro support isn't neededCaolán McNamara2-11/+5
seems undocumented at least Change-Id: I316e4f4f25ddb7cf6b7bac4d856a721b987207a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151020 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-27Resolves: tdf#151958 Disable binary search on sorted cache for current releasesEike Rathke1-3/+15
Temporary measure until the actual cause is fixed. The by string query of binary search on sorted cache is broken for mixed types like here the numeric date cells and text cells. Change-Id: Icfe0b0c30987fcefdd6ed11066ea9113f3b4dabe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151074 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 9a555d79b3b00793edf1d51a8a7c76b723cc436d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151024 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-27tdf#154789 EMF+ Performance boost of the EmfPlusRecordTypeDrawBeziersBartosz Kosiorek3-13/+44
There is several benefits of such performance optimization: 1. We are drawing single curve instead of hundreds of small curves. In the loop we are creating single Polygon and outside of the loop we are invoking EMFPPlusDrawPolygon drawing method only once. As https://bugs.documentfoundation.org/attachment.cgi?id=186725 image is using single EmfPlusRecordTypeDrawBeziers EMF+ record with hundreds of curves, with using single EMFPPlusDrawPolygon call, there is no lnger need for individual line creation (e.g. line color, weight, line caps, line joints, line dashes, etc.) - The PDF export performance without optimizations of the https://bugs.documentfoundation.org/attachment.cgi?id=186725: time ./instdir/program/soffice --headless --convert-to "pdf:writer_pdf_Export" --outdir ~ ~/Pobrane/problem.docx real 24m18,471s user 2m56,004s sys 1m37,816 - The PDF export performance with optimizations: real 0m37,527s user 0m37,004s sys 0m0,531s - With Libreoffice 7.5.2 from Ubuntu 22.04, the conversion was crashed. 2. The PDF export for document: https://bugs.documentfoundation.org/attachment.cgi?id=186725 was not working correctly for me. The original image is containing chart. Without optimization, the exported chart was empty. Current export is working correctly, and graph is visible. 3. The standard opening of the document from https://bugs.documentfoundation.org/attachment.cgi?id=186725 is now much faster. The zooming in, move image operations are also noticible faster. 4. Implementation is according to [MS-EMFPLUS] documentation of the EmfPlusDrawBeziers, which states: "The ending coordinate of one Bezier curve is the starting coordinate of the next. The control points are used for producing the Bezier effect." Change-Id: Ic77d4c20a462587bb5da4a4df757e30c5ca04fc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150821 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> (cherry picked from commit ce008fa9d8f2752bdfeaeff763aafc774a4b4fb2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150789 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-26update creditsChristian Lohmaier1-1857/+1896
Change-Id: I934d635e0d241b9884017e4a22ba99e9d1459783 (cherry picked from commit b79a82886dd8431ff79f148bd8bde8b11e04863a)
2023-04-26Fix tdf#155004: ucb: webdav-curl: carry over Class1 bit only if setMichael Stahl1-1/+4
With d6182cb6704c06f33d284874b9fe96c85cce5bf5 there are cases when a webdav server inadvertendly releases the lock. Lets apply the fix only if the Class1 flag is actually set. Change-Id: I85e5253c7df0980f373d2dea788c331b81ed4a82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150552 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: Jenkins (cherry picked from commit 5e8c27e2dbb47a207364f3c44b5ea8e7ec3be73a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150929 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-25put floating frames under managed links controlCaolán McNamara15-86/+331
like we do for sections and ole objects that link to their content individual commits in trunk are: extract a OCommonEmbeddedObject::SetInplaceActiveState for reuse no behaviour change intended Change-Id: Ia1d12aa5c9afdc1347f6d4364bc6a0b7f41ee168 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150341 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 183e34a3f8c429c0698951e24c17844e416a3825) use parent window as dialog parent it makes no odds, but is more convenient for upcoming modification Change-Id: Ibc5333b137d2da089b3b701ff615c6ddf43063d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150342 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit f93edf343658abd489bde3639d2ffaefd50c0f99) adjust IFrameObject so it could reuse mxFrame for a reload of content Change-Id: I7eec3132a23faafd9a2878215a0a117a67bc9bf2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150343 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 3a727d26fd9eb6fa140bc3f5cadf3db079d42206) query getUserAllowsLinkUpdate for the case of content in a floating frame similarly to how it works for the more common "normal" embedded objects Change-Id: I83e38dfa2f84907c2de9680e91f779d34864a9ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149971 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 52aa46468531918eabfa2031dedf50377ae72cf7) add a route to get writer Floating Frame links under 'manage links' Change-Id: If90ff71d6a96342574799312f764badaf97980eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150349 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 8b8a2844addbd262befb1a2d193dfb590dfa20be) allow SvxOle2Shape::resetModifiedState to survive having no SdrObject Change-Id: Iea059262c124e3f44249e49b4189732310d28156 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150538 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 02379929bd0e1d1676635f0ca1920422702ebb7c) create the FloatingFrameShape in a separate step to inserting it this is derived from the path taken by the AddShape(const OUString&) function for this case. No change in behavior is intended. Change-Id: Id09ae0c65a55a37743ad7c184070fb8dd97d8a7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150526 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit bafec47847a0b9697b3bbe9358e53f8118af3024) add a route to get calc Floating Frame links under 'manage links' much harder than writer because the organization and ordering of properties and object activation etc is different. This ended up ugly, but functions. We set FrameURL before AddShape, we have to do it again later because it gets cleared when the SdrOle2Obj is attached to the XShape. But we want FrameURL to exist when AddShape triggers SetPersistName which itself triggers SdrOle2Obj::CheckFileLink_Impl and at that point we want to know what URL will end up being used. So bodge this by setting FrameURL to the temp pre-SdrOle2Obj attached properties and we can smuggle it eventually into SdrOle2Obj::SetPersistName at the right point after PersistName is set but before SdrOle2Obj::CheckFileLink_Impl is called in order to inform the link manager that this is an IFrame that links to a URL Change-Id: I67fc199fef9e67fa12ca7873f0fe12137aa16d8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150539 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 07179a5a5bd00f34acfa8a3f260dd834ae003c63) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150755 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-04-25set Referer on loading IFramesCaolán McNamara1-3/+10
so tools, options, security, options, "block any links from document not..." applies to their contents. Change-Id: I04839aea6b07a4a76ac147a85045939ccd9c3c79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150221 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150751 Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-24sw: fix crash in OutHTML_SwFormatField()Miklos Vajna1-1/+1
Crashreport signature: program/libswlo.so SwDocShell::GetView() sw/inc/docsh.hxx:222 program/libswlo.so OutHTML_SwFormatField(Writer&, SfxPoolItem const&) sw/source/filter/html/htmlfldw.cxx:549 ... program/libswlo.so SwTransferable::WriteObject(tools::SvRef<SotTempStream>&, void*, unsigned int, com::sun::star::datatransfer::DataFlavor const&) sw/source/uibase/dochdl/swdtflvr.cxx:? I.e. clipboard documents don't have a doc shell, handle that. Change-Id: I48b22087f759a11b4aa46b83b310f4a661e1fbc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150897 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 5951e37eb24e09d3c24cb4cab4b0f3da41e3dfff) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150914 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-24tdf#154546 skip dispatch when presenter controller is not setPatrick Luby1-1/+4
mpPresenterController is sometimes unset and this will cause a crash when pressing the presenter console's Exchange button. Change-Id: Ibfc866d573ce0c535df5c8fdbd6d358353784854 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150456 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Patrick Luby <plubius@neooffice.org> (cherry picked from commit 6f4fb52116c08b0c6247dc4828442f4e3644e9eb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150775 (cherry picked from commit 14c4b0d11211cc27fb3a0cae246d8e971d6d8f9a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150793 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-21tdf#154946: Draw/Impress Standard toolbar missing many iconsJulien Nabet4-4/+4
Regression from 4cd7489f5898394730b794bdecbc29800cf23627^!/ "Resolves tdf#143055 - Make Snap-to-grid easier to access Added to page context menu, standard toolbar, and line & filling toolbar" Change-Id: I3d7040f59a3c422e7f596fcd96cde88466bc2a79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150727 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-21tdf#154629 inspector sidebar panel use-after-free on switch to print previewCaolán McNamara2-1/+22
Change-Id: I5489cd18213d82ae4174ca8d9d00f1da5aa1091d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150078 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150691 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-20Resolves: tdf#154912 make double-click to expand rows the same as arrow expandCaolán McNamara2-2/+9
the arrow case does the necessary removal of the "dummy" entry which is necessary to get the treeview to indicate it has children, while the double click case skipped that step, so rearrange so both behave the same. Change-Id: I6161d786cd58b0eea53152074dff2b035c621e7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150622 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 310a23fd4dde657038efb1e3fbb9db9e0cdbca3b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150630 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-20tdf#153190 Compressing tool calculates compression rate wrong on large imagesNoel Grandin1-1/+5
calculation used sal_Int32, which overflowed on large values, rather use floating point to do the calculation Change-Id: I15974c5bf785a800a8f71711acfa9895361bad7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150683 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit b167bc073b6b83110242bfbace107f6978e5bca7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150628 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-20Resolves: tdf#154623 KEY_DECIMAL == GDK_KEY_KP_Decimal or GDK_KEY_KP_SeparatorCaolán McNamara1-2/+3
Change-Id: Iade6d3f93ff7f9dcc35c5a04e21617df06955527 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150623 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins (cherry picked from commit 50253a2cb2e1b604f0d5bfb5be1d6f91eaa0bc8b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150625 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-19bump product version to 7.4.8.0.0+Christian Lohmaier1-1/+1
Change-Id: I62ff4c82032834fc2fdec671c2f057bb5ec1e91e
2023-04-19tdf#153784 account for initial vertical offset when toggled into multilineCaolán McNamara2-33/+33
Initially there is 1 line and the edit is vertically centered in the toolbar Later, if expanded then the vertical position of the edit will remain at that initial position, so when calculating the overall size of the expanded toolbar we have to include that initial offset in order to not make the edit overlap the RESIZE_HOTSPOT_HEIGHT area so that dragging to resize is still possible. also includes: rhbz#2162658 backtrace showing endlessly recursive ScInputWindow::Resize Change-Id: I2d10fd1ebfb1c25cf213ebb68e7d34e39fadde13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145894 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 13b2bd1006182637b189bcfa77acfaf03ae028f0) tdf#151682 Fix gap above input bar Remove vertical offset, looks like it's not needed anymore. Change-Id: If0f7f7dce7a7e4249036930b60fe353890b495fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146179 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> (cherry picked from commit f7544650cc4e31da67873898e2d587afa846b9b4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146199 Reviewed-by: Kohei Yoshida <kohei@libreoffice.org> (cherry picked from commit 9739a874b64e770728d62713b070f37de4ec8328) Change-Id: Ic99e1cf4f3b1ca53c5d6feaa50d8bfac030f8124 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148069 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148075 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-04-19Upgrade Harfbuzz to 7.1.0Taichi Haradaguchi5-48/+3
* Fixes CVE-2022-33068, CVE-2023-25193. * Update URL in README. Change-Id: Id234c2b459c40ddac340731b44889b104e03a1e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148954 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-04-19Update git submodulesChristian Lohmaier1-0/+0
* Update translations from branch 'libreoffice-7-4' to 3a484968d782509bdad7b7c02b4cb000a34c0b81 - update translations for 7.4.7 rc1 and force-fix errorrs using pocheck Change-Id: Ia5e3cceaa9ba0fe6f5f502efdf440ccd3aefa462
2023-04-19sfx2: fix crash in StyleList::CustomRenderHdlXisco Fauli1-10/+13
GetFamilyItem() might return nullptr See https://crashreport.libreoffice.org/stats/signature/StyleList::CustomRenderHdl(std::tuple%3COutputDevice%20&,tools::Rectangle%20const%20&,bool,rtl::OUString%20const%20&%3E) Change-Id: I099f045232aac710c4f26148de5e798d00ecc7ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150602 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150617
2023-04-19libxml2: upgrade to release 2.10.4Michael Stahl2-6/+14
Fixes CVE-2023-29469 and CVE-2023-28484. Also: SAX2: Ignore namespaces in HTML documents which is probably the reason why one test fails, so switch it to parsing XML: HTML parser error : Tag reqif-xhtml:div invalid <reqif-xhtml:div> HTML parser error : Tag reqif-xhtml:table invalid <reqif-xhtml:table cellpadding="2" cellspacing="2"> ... reqif-table.xhtml: C:/cygwin/home/tdf/jenkins/workspace/gerrit_windows/test/source/xmltesttools.cxx:195:testReqIfTable::Import_Export equality assertion failed - Expected: 1 - Actual : 0 - In <file:///C:/cygwin/home/tdf/jenkins/workspace/gerrit_windows/tempdir/lu134607bxu8q.tmp>, XPath '/html/body/div/table/tr/th' number of nodes is incorrect Change-Id: Icc161b39515c996193366bc777a67eca79e4e892 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150544 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit b28fd940ca46828be624679863364b4db89dd38c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150616 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-19backport writer sidebar "check SfxViewFrame::Current()"Caolán McNamara1-23/+19
for crash seen in the wild as: https://crashreport.libreoffice.org/stats/crash_details/0f7afb28-ef99-4182-a260-98d8a5653890 Change-Id: I06dfecc6a072ec1de17d66e7c8fd5a81375b0839 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150573 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-19sw: fix divide by 0 in SwFlyFrame::CalcRelXisco Fauli1-2/+2
https: //crashreport.libreoffice.org/stats/signature/SwFlyFrame::CalcRel(SwFormatFrameSize%20const%20&) Change-Id: If7a1919a2829bbec3292b3aa5f7f719c5ba0beef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150579 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 6f36e44f248c8e3705779d6692daaf79865a1378) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150567 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-04-19sw: fix divide by 0Xisco Fauli1-2/+7
See https://crashreport.libreoffice.org/stats/signature/operator/(Fraction%20const%20&,Fraction%20const%20&) Change-Id: Ia93e2969d6eb0bde71c8419f2aa90bb7aa231f61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150553 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit d01dae0cbabc27f2ff2a242316206067cff73cf8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150563 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-04-19formula: fix crash in FormulaDlg_Impl::UpdateSelectionXisco Fauli1-3/+11
m_pFuncDesc can be nullptr See https://crashreport.libreoffice.org/stats/signature/formula::FormulaDlg_Impl::UpdateSelection() Change-Id: If8a95bef8b0a8a03ffe63041409ee7c1cf322b0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150550 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 2d62a54d151f32007c1cb1c7f729b777dbdb73cc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150560
2023-04-18tdf#154481 sw DOCX import: fix page loss and freezing at ODT exportAttila Bakos (NISZ)3-0/+14
Disable TOC creation in case when field context stack is empty but TOC creation is in progress in textboxes. Before if TOC creation failed because it is already existed, the TOC creation member (mbStartTOC) kept true resulting in broken textbox handling. Textbox and TOC import use the same text append stack but the TOC was not removed from the stack so content have been written into the TOC instead of the textbox, resulting page loss, and because of the broken structure, freezing at further ODT export. Change-Id: If27aa477c49f276d4e538b6e125798d89f0ac423 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150099 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 94de79e7d3c980b576192d2f264bee658716163a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150319 Tested-by: Jenkins
2023-04-18Resolves: tdf#146068 don't crash when MA(central) lacks dataCaolán McNamara1-0/+2
Change-Id: I2c9b78f4d1a963bb71abb21068e61e6983ade777 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150501 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-04-18tdf#150149 sw: fix table header in multi-column sectionsLászló Németh3-2/+98
Disabling long repeating table header on pages resulted lost table header within multi-column sections. To fix this, revert commit f7e071a00542c414a7e9d7bcf4434d908f225e59 for tables in sections. Regression from commit f7e071a00542c414a7e9d7bcf4434d908f225e59 "tdf#88496 DOCX: disable long repeating table header". Change-Id: Idb7b9ea014be5430a185489cf449463f534c1916 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150393 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit a36fda0d7c70ffd344f9636ca436e77e41dc01f1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150325 Tested-by: László Németh <nemeth@numbertext.org>
2023-04-18tdf#154016: use ScopedVclPtrMike Kaganski1-1/+1
A regression crash from commit d79c527c2a599c7821d27cf03b95cb79e2abe685 (Use IconView in SmElementsControl, 2022-06-01). Without disposeAndClear, the VirtualDevices leak; and on Windows this quickly leads to GDI handle 10 000 limit killing the process (which is good, helping to track this kind of issues). Change-Id: I28e1ffbeb425fae3fdbd76b7873fef5c929b8e11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150523 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit c11463cdc5415707d05ab6da08736ff7212db4a0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150511 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-04-17tdf#151560 don't crash on loading dubious fodsCaolán McNamara1-1/+1
Change-Id: Ib41b3a95dd3829e8d3eca61621257fdd416bd8dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150499 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-04-17Resolves: tdf#153958 Hyphenation crashes with -Alte...Caolán McNamara1-1/+1
nPos2 is 0 due to the -, so aLeft is empty, nPos is set to 0 then incremented to 1, aLeft.replaceFirst is run after its end pos so crashes/asserts. Presumably we can do nothing meaningful here so skip if nPos2 is 0 Change-Id: I09754c4b2567fe5c1b4c36de0b36ee99f575244d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150327 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 7584e403d57097ed4cc2d827d68895ec35cf805f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150331 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-04-17tdf#137542 don't crash at leastCaolán McNamara1-2/+2
doesn't address the underlying issue though Change-Id: I7f5a5dba01c399ec78eceaab6ea85fc0b8897927 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150497 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-17Resolves: tdf#152619 crash inspecting uninserted XFieldMasterCaolán McNamara1-0/+2
Change-Id: I765dd5d7e1ed2c1749841491a50216a6afe903c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150351 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 5464a1dad69c52d011b194baf7d543ce8dd27748) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150321 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 71c7c3dddb1291e262b1f8132b75e95fc6f9fa02) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150333 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-17tdf#154501 - Fileopen PPTX: Table with rotated text wrongNoel Grandin1-18/+18
regression from commit eec42f0dbcc79a4c9f456ce97fa1066b8031ea28 Author: Noel Grandin <noelgrandin@gmail.com> Date: Sun Aug 15 17:35:58 2021 +0200 pass OutlinerParaObject around by value where some of code I converted needed to be mutating the OutlinerParaObject that something else held, rather than mutating a local copy. Change-Id: Ib91dddb3fc0d4190868f9fd59becb0d366af5e19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150376 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit ad97694737c99889bc0eb21efccb83768d510361) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150330 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-13tdf#154658: XML Form Document: Fields doesnt calculate any moreJulien Nabet1-0/+33
Regression from 73334560b2dd2d60ac58d2cc2b1a5295490b03e1 author Julien Nabet <serval2412@yahoo.fr> 2021-11-07 15:40:37 +0100 committer Julien Nabet <serval2412@yahoo.fr> 2021-11-07 21:58:53 +0100 commit 73334560b2dd2d60ac58d2cc2b1a5295490b03e1 (patch) tree b5bc4f69dd8ed455c78ea05ab1c5e2f3c25b909e parent 6be03ac71e0d4927612b4a57ead3d0b245c29c77 (diff) Replace some macros in forms part 16 A big thank you to Raal for having spotted this! Change-Id: Ib6f1878897b16b43df287702f82835824c1f766d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150174 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins (cherry picked from commit 26012007e4d20f47697d1336b725e60541df794a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150314 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-04-10tdf#154599 sw: fix crash at drag & drop table columnsLászló Németh2-1/+59
New code path for (tracked) row deletion resulted broken column deletion, by deleting more columns at their drag & drop, than needed. Regression from commit 5e8aa259e48d5602b932353bb146ebb523982cf2 "tdf#146967 sw table: fix freezing in Hide Changes mode". Change-Id: Ib649f5b534a588d192d27757e30c8f81087beb0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150132 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 491e84eb7c6d92c44ab7fa62912452f7789bb8c8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150146 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-09tdf#149064 ensure interaction handler is present when transfering with webDAVJaume Pujantell1-1/+2
Change-Id: I7a31f708e6fe01f07c7187aacd4657b5c6156c82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149722 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 50848b06ea58a147f5b89f057880266518ce79e7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149697 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 439d8466c10473d1f3859ffa6c87fef6209e93eb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150141 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-04-07sd: fix crash in DrawViewShell::ExecCtrlXisco Fauli1-2/+2
See https://crashreport.libreoffice.org/stats/signature/sd::DrawViewShell::ExecCtrl(SfxRequest%20&) I believe this crash is triggered with some basic code while slideshow is running. Anyway, if I delete the previous SlideShow::IsRunning(GetViewShellBase()) check, launch Impress and add a new slide, LibreOfice also crashes. Change-Id: Iba40f37485a4a6815729a1a26c380b6c3fdedfd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150097 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 6a1425c4c9595ed82629d846c9b69ed9942b2c0b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150080
2023-04-07tdf#153887 Fraction number format: avoid 0/0Laurent Balland2-3/+17
If round value is an integer and there is no integer part in the number format, then nDiv was wrongly forced to 0. Add corresponding unit tests. Change-Id: Ib69393eca8f6c2bdda0eacfc83637ab0c971ff2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149118 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit dc9b8c31aaf72812dc205f610638098898a4cde7) (cherry picked from commit 96fb093856dd84fdab6b8989884e5632139dec07) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150093 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-06oox: fix crash in lcl_GetGluePointId by removing unused codeXisco Fauli1-9/+6
See https://crashreport.libreoffice.org/stats/signature/oox::drawingml::lcl_GetGluePointId Change-Id: I7737568b12a18a2195f24f023917d30dd838ea12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150064 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit aa1008e29bcfbee2397f72971d2de745fad8e98a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150077
2023-04-06Fix typos in XML that broke three implementation elementsStephan Bergmann2-9/+5
The typos all originated with d2140a6320cd1cf4dea29b174cdb3bcb5261056b "i18npool: create instances with uno constructors", causing three intended constructor attributes to rather be plain character data. (Which apparently went unnoticed so far, in part because the Parser class in cppuhelper/source/servicemanager.cxx silently ignores any unexpected character data via xmlreader::XmlReader::Text::NONE.) Change-Id: Ia8fdbc09c67d10530b4d86dbbbde2b6b84038e66 (cherry picked from commit e20d25bd6488dd5a6a73f1dd976bddf847dfcf9a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150073 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-06tdf#151971: Fix used implementation names of transliteration servicesStephan Bergmann4-18/+199
...after 04af4e4f55f3ef319a78edd4d0109e2e7eba90b6 "[API CHANGE] Fix all bad UNOIDL identifiers across offapi" had changed the spelling (character case) of some of the css.i18n.TransliterationModules[New] enum values involved here, so that the TmItem1 macro generated broken TMList::implName values now. (Which in turn caused TransliterationImpl::loadBody to throw "unsatisfied query for interface of type com.sun.star.i18n.XExtendedTransliteration!" css::uno::RuntimeExceptions, which remained uncaught.) Also add a test verifying that loading all those transliteration services no longer fails throwing exceptions. Which lead to two open TODOs: For one, the value of maxCascade in i18npool/inc/transliterationImpl.hxx might come from a time when there were fewer TransliterationModules[New] enum values and might no longer be appropriate. This would need some further investigation. But for another, there are two transliteration services that cannot currently be instantiated. That looks like a regression that should be fixed in a follow-up commit. Change-Id: Icfca3e841360d4b471013e2c96d6868a75a21a1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150018 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 456a146b9eb643655ae2bd336740e8c5536913aa) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149982 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-05fix crash seen when experimenting with tdf#129547Caolán McNamara1-1/+4
Change-Id: I0b26a7f683f91d3307856f86c5a437fde1155451 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149331 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 936f2e6924e405433770b98f32a615508fd0670d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149434 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 98465ee3f987c43bdb0a615ca81ffbbac6bf479f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149515
2023-03-31fix poppler buildTaichi Haradaguchi1-6/+6
* Update POPPLER_VERSION in poppler-config.patch.1 Change-Id: Iba770e6a3036a091925997025d4528f1d855da5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149795 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-30tdf#147892 DOCX: fix corrupt export at para marker revision historyLászló Németh4-16/+53
OOXML export of tracked deletion of tracked paragraph insertion resulted invalid document.xml, because change tracking history of paragraph markers isn't supported by OOXML. Export the tracked deletion of the last run of paragraphs without history (tracked insertion). This way w:p/w:pPr/w:rPr contains only w:del or w:ins, not both of them (with broken tag order). Note: it's possible to optimize the fix to keep the change tracking history of the characters of the last run of the paragraph, except the paragraph marker. Regression from commit eeee19b3fcf8b0374c361c7f6c285fd5c89b5a2f "tdf#142387 DOCX track changes: export w:del in w:ins". Minimal unit test document was created by Miklós Vajna. Change-Id: I425f4d63c8c6ac29ccd807c1574748c7b9b39e80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146782 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry-picked from commit 382892341a63e400f221e1a533fd5a5d6b4d9d70) Conflicts: sw/source/filter/ww8/docxattributeoutput.cxx Change-Id: I0e29195512d8786ac5f6a145ed88a9261f1c456e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149763 Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org> Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2023-03-28[1.1.1] external/openssl: add patch for CVE-2023-0464Taichi Haradaguchi2-0/+223
this issue should be fixed in release 1.1.1u Severity: Low Security Advisary: https://www.openssl.org/news/secadv/20230322.txt Change-Id: I470c72b516b2d1ba0086610bb470b1a98e2df8b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149640 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-27tdf#126632 tdf#152908 Resize the notebook bar on context changeJim Raykowski1-0/+5
For other than gtk vcl backend the tabbed compact toolbar tabs do not repaint correctly when the 'Table' tab is active and the cursor is move outside of the table. This patch adds a Resize after the context is set to make the tabs always show as expected. Change-Id: Iedf8a6eea52c3c55e9c1266b7aa79bc0f34deb22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149593 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit e0daa98a802cc1f84ceb0f306f5d15fecabd62c1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149599 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit b2575b26f403e97b5a1e85559d1506a0f60b3903) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149604 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-25 04:56:40 +0000