summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2023-03-26tdf#149485: Revert "tdf#142450 add code to store showing whitespace"Xisco Fauli3-33/+2
This reverts commit 5b07acbf3345918f450fccf7ee243ad5bcb3fd67. The reverted commit claims that "This option is stored at the document level like the other layout options." which is not true. The option is saved in the user profile, which makes other documents to look wrong. Reverting for now until it's implemented at document level as the commit suggests Change-Id: I2ae0daeb410090949f1b6cfc8245b711fe518216 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149541 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 3795729fd0f4bc4769d69b45d3536c7b01692b92) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149521 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-25sw: check GetActiveView()Xisco Fauli29-198/+297
See https://crashreport.libreoffice.org/stats/signature/SwView::GetDocShell() Change-Id: I90ebbff5082f1f9cae7fa3b940cbb9796d6c6dd3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149223 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149320 Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149503
2023-03-24update creditsChristian Lohmaier1-1751/+1811
Change-Id: Iea1190aa7e0b9d81a8cf73ebbafd318e73fca757 (cherry picked from commit 9469044db420f280bf60765e0d94bc7d94e6641e)
2023-03-24rhbz#2171265 Filter out all non *.rdb filesStephan Bergmann1-2/+4
In that rhbz issue ("Libreoffice cannot start"), it looks like some junk file named /usr/lib64/libreoffice/program/services/services.rdb;63ddcd86 caused soffice.bin to crash early, without any information (cf. a1faf14f74a62ea76141115538d7d30d90c9eeb6 "rhbz#2171265 Report fatal InitApplicationServiceManager failures more reliably"). So, following up on b8c7548527f5fc14fe8fcbe74a749c7e3c10d385 "ignore backup files in services/ directory to avoid debugging grief", extend the set of ignored files to anything starting with "." or not ending in ".rdb" (in any case). Change-Id: I154750465d2128b3ff6493f4ab606072dda61503 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149328 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit feb8b04a0ee86b0146a17393da220ae188babda8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149436 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149499
2023-03-24rhbz#2171265 Report fatal InitApplicationServiceManager failures more reliablyStephan Bergmann1-1/+3
For example, when initialization of the UNO type manager failed, any code run between this SetBootstrapError and the HandleBootstrapErrors in Desktop::Main which would need the type manager (e.g., to set a css::uno::Any) would have caused a crash, so would have failed to print to std::cerr the sought-after css::uno::Exception message. The mis-initialized process would most definitely crash sooner or later anyway, so there's no harm in a controlled std::abort() here (if that is even reached, and the process doesn't already crash in HandleBootstrapErrors, after it has printed the relevant information to std::cerr). Change-Id: Ic5889aedec0908fa4b1e2966eb188508d0f92d26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149323 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit a1faf14f74a62ea76141115538d7d30d90c9eeb6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149440 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149498
2023-03-22Revert "avmedia : use std::mutex instead of osl::Mutex"Michael Stahl1-7/+6
This reverts commit 477fa6c3cb92f578032dee60482718efdb8f44f2. MissingPluginInstaller requires a recursive lock: Thread 2 (Thread 0x7f8e73d69700 (LWP 29931)): 0 __lll_lock_wait () at /lib64/libpthread.so.0 ... 5 std::unique_lock<std::mutex>::lock() (this=0x7f8e73d65a88) at /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/std_mutex.h:267 6 std::unique_lock<std::mutex>::unique_lock(std::mutex&) (this=0x7f8e73d65a88, __m=...) at /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/std_mutex.h:197 7 avmedia::gstreamer::(anonymous namespace)::MissingPluginInstaller::detach(avmedia::gstreamer::Player const*) (this=0x7f8e644c6be0 <rtl::Static<avmedia::gstreamer::(anonymous namespace)::MissingPluginInstaller, avmedia::gstreamer::(anonymous namespace)::TheMissingPluginInstaller>::get()::instance>, source=0x75d2fa0) at avmedia/source/gstreamer/gstplayer.cxx:187 8 avmedia::gstreamer::Player::disposing() (this=0x75d2fa0) at avmedia/source/gstreamer/gstplayer.cxx:334 9 cppu::WeakComponentImplHelperBase::dispose() (this=0x75d2fa0) at cppuhelper/source/implbase.cxx:104 10 cppu::PartialWeakComponentImplHelper<com::sun::star::media::XPlayer, com::sun::star::lang::XServiceInfo>::dispose() (this=0x75d2fa0) at include/cppuhelper/compbase.hxx:90 11 cppu::WeakComponentImplHelperBase::release() (this=0x75d2fa0) at cppuhelper/source/implbase.cxx:79 13 rtl::Reference<avmedia::gstreamer::Player>::~Reference() (this=0x7f8e7c028f20) at include/rtl/ref.hxx:129 ... 21 std::__debug::set<rtl::Reference<avmedia::gstreamer::Player>, std::less<rtl::Reference<avmedia::gstreamer::Player> >, std::allocator<rtl::Reference<avmedia::gstreamer::Player> > >::clear() (this=0x7f8e644c6cd8 <rtl::Static<avmedia::gstreamer::(anonymous namespace)::MissingPluginInstaller, avmedia::gstreamer::(anonymous namespace)::TheMissingPluginInstaller>::get()::instance+248>) at /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/debug/set.h:426 22 avmedia::gstreamer::(anonymous namespace)::MissingPluginInstaller::report(rtl::Reference<avmedia::gstreamer::Player> const&, _GstMessage*) (this=0x7f8e644c6be0 <rtl::Static<avmedia::gstreamer::(anonymous namespace)::MissingPluginInstaller, avmedia::gstreamer::(anonymous namespace)::TheMissingPluginInstaller>::get()::instance>, source=..., message=0x7cdb400) at avmedia/source/gstreamer/gstplayer.cxx:156 23 avmedia::gstreamer::Player::processSyncMessage(_GstMessage*) (this=0x75abfe0, message=0x7cdb400) at avmedia/source/gstreamer/gstplayer.cxx:536 24 avmedia::gstreamer::pipeline_bus_sync_handler(_GstBus*, _GstMessage*, void*) (message=0x7cdb400, data=0x75abfe0) at avmedia/source/gstreamer/gstplayer.cxx:382 25 gst_bus_post () at /lib64/libgstreamer-1.0.so.0 Change-Id: Ia8e7fef4d4cee2dde7189702af6dddf883b6cceb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149233 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 621143588b3cb438baf27fb6893ab02e7b06f9dd) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149298 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-22tdf#153255 DOCX import: fix footnote orderLászló Németh3-3/+46
Simple unit test for tdf#152203 allowed to create bad ordering algorithm by accident without noticing the problem, which caused problem for most of the DOCX files, where serialization in footnotes.xml doesn't follow the order of the footnotes. Regression from commit 9b39ce0e66acfe812e1d50e530dc2ccdef3e1357 "tdf#76260 DOCX import: fix slow footnote import". Follow-up to commit 09ae3c01940bbc25ffde51963683b04e3cb4bb6a "tdf#152203 DOCX import: fix mixed footnotes/endnotes". Change-Id: I0628d96e3b8ad4df38d26e9288b47d39b958c441 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149176 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit ed0372bac123b402fe3cd694a455e8328117752d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149243 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-03-22curl: upgrade to release 8.0.1Michael Stahl1-2/+2
Apparently 8.0.0 had a serious regression. Change-Id: Icc761f5e5e01b5d9bebecc13f7cba608f5834f54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149204 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit e5005c76bd60a004f6025728e794ba3e4d0dfff1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149112 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-03-22curl: upgrade to release 8.0.0Michael Stahl1-2/+2
Fixes CVE-2023-27535. Also hopefully fixes excessive storage consumption during build: o build: drop the use of XC_AMEND_DISTCLEAN [62] Change-Id: I8792e95bc7634ee496488e80fec5a1310b24a31c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149153 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit bbe0d0534abe6480c4502ce8fb543a736d3399d8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149105 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 38b54a4d86e05bbbbdbf2a38771395579d1b005a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149108 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-03-22crashreporting: CreateEmbeddedObject might failCaolán McNamara1-0/+3
Change-Id: I0e1ccbea92343d18e5ff3a9af1f54ed5e0dd796b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149113 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit fa1760d0c7ac8b9fb2e88f7d6d7f9de14479cbf6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149245
2023-03-21tdf#154232 signal_drag_begin callback can delete current GtkTargetListCaolán McNamara1-3/+3
so fetch the up to date one on calling gtk_drag_begin_with_coordinates ==3221972== Invalid read of size 8 ==3221972== at 0x23F281DA: gtk_drag_begin_internal (gtkdnd.c:1801) ==3221972== by 0x23F2886F: gtk_drag_begin_with_coordinates (gtkdnd.c:1995) ==3221972== by 0x23845075: (anonymous namespace)::GtkInstanceWidget::signal_motion(_GdkEventMotion const*) (gtkinst.cxx:3139) ==3221972== by 0x23844F09: (anonymous namespace)::GtkInstanceWidget::signalMotion(_GtkWidget*, _GdkEventMotion*, void*) (gtkinst.cxx:3130) ==3221972== by 0x23C0FC56: _gtk_marshal_BOOLEAN__BOXED (gtkmarshalers.c:84) ==3221972== by 0x1378C05F: g_closure_invoke (gclosure.c:832) ==3221972== by 0x137B8F65: signal_emit_unlocked_R.isra.0 (gsignal.c:3796) ==3221972== by 0x137A8ED5: g_signal_emit_valist (gsignal.c:3559) ==3221972== by 0x137A96F2: g_signal_emit (gsignal.c:3606) ==3221972== by 0x23EF1073: gtk_widget_event_internal.part.0.lto_priv.0 (gtkwidget.c:7812) ==3221972== by 0x23D825AD: UnknownInlinedFun (gtkmain.c:2588) ==3221972== by 0x23D825AD: propagate_event.lto_priv.0 (gtkmain.c:2691) ==3221972== by 0x23D83320: UnknownInlinedFun (gtkmain.c:1921) ==3221972== by 0x23D83320: gtk_main_do_event (gtkmain.c:1691) ==3221972== Address 0x2c7d8070 is 0 bytes inside a block of size 16 free'd ==3221972== at 0x48460E4: free (vg_replace_malloc.c:884) ==3221972== by 0x1383388C: g_free (gmem.c:229) ==3221972== by 0x1384E093: g_slice_free1 (gslice.c:1185) ==3221972== by 0x23CD7A08: gtk_drag_source_set (gtkdragsource.c:162) ==3221972== by 0x23ED1EAB: gtk_tree_view_enable_model_drag_source (gtktreeview.c:14303) ==3221972== by 0x23877F41: (anonymous namespace)::GtkInstanceTreeView::drag_source_set(std::__debug::vector<_GtkTargetEntry, std::allocator<_GtkTargetEntry> > const&, GdkDragAction) (gtkinst.cxx:16279) ==3221972== by 0x238440B3: (anonymous namespace)::GtkInstanceWidget::do_enable_drag_source(rtl::Reference<TransferDataContainer> const&, unsigned char) (gtkinst.cxx:2707) ==3221972== by 0x23877E99: (anonymous namespace)::GtkInstanceTreeView::enable_drag_source(rtl::Reference<TransferDataContainer>&, unsigned char) (gtkinst.cxx:16270) ==3221972== by 0x36AAE6D2: SwContentTree::DragBeginHdl(bool&) (content.cxx:1227) ==3221972== by 0x36AAE2CE: SwContentTree::LinkStubDragBeginHdl(void*, bool&) (content.cxx:1180) ==3221972== by 0x238D38DA: Link<bool&, bool>::Call(bool&) const (link.hxx:111) ==3221972== by 0x23878D2D: (anonymous namespace)::GtkInstanceTreeView::do_signal_drag_begin(bool&) (gtkinst.cxx:16520) Change-Id: Idffa33c6a549bf17a92eb56760ddfb7d5424b7ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149101 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2023-03-20Update git submodulesChristian Lohmaier1-0/+0
* Update translations from branch 'libreoffice-7-4' to c95ce4d9b66b58b9cf329b7bc71f036ed703c303 - update translations for 7-4 and force-fix errors using pocheck Change-Id: I909a60defa5948ee9530cc82f982e265e90641a4
2023-03-18sw: fix null dereferenceXisco Fauli1-5/+6
See https://crashreport.libreoffice.org/stats/signature/SfxDispatcher::ExecuteList(unsigned%20short,SfxCallMode,std::initializer_list%3CSfxPoolItem%20const%20*%3E,std::initializer_list%3CSfxPoolItem%20const%20*%3E) Change-Id: I7f5471f003798f260d9d015782bd2a798baa22d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148999 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 11ce7e810ef5ba540afe676d58575fabf4ab386d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149019
2023-03-18xmloff: ODF export: produce alt text and description for MediaShapeMichael Stahl1-0/+5
... and others where it was inexplicably missing (PluginShape, AppletShape, FrameShape). Change-Id: Idf1c44488370a81bc90fb316ab6056994d782a1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148917 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 9070c1b0404fb72d2553f6fa8f702e70c0abb269) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148960 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-14tdf#132847 emit NotifyScrolled on use of end/home to scroll to end/startdistro/lhm/libreoffice-7-4+backportsCaolán McNamara1-0/+1
Change-Id: I8d4366b6ad667f28ff35f18fef13f2e0f3e9b194 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148758 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-03-13tdf#153819 sw: fix crashing MakeFramesForAdjacentContentNode()László Németh3-2/+197
In Hide Changes mode, copying cells before a tracked deleted table crashed in SwTableNode::MakeFramesForAdjacentContentNode(). Regression from commit 794fd10af7361d5a64a0f8bfbe5c8b5f308617a5 "tdf#147347 sw: hide deleted table at deletion in Hide Changes". Change-Id: I3ac070d35006e61b01a065359431e302e6974e17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148344 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 317ed3e81a5aa7826176a5122c2d8ea76aa0fb37) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148323 Tested-by: László Németh <nemeth@numbertext.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148640
2023-03-12Resolves: tdf#154087 update scrollbar range when search criteria changeCaolán McNamara4-4/+14
Change-Id: Iaf5f20c8952b15f3dcccb65277dadb171a705605 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148616 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-03-11Resolves: tdf#132847 large scrolls that cause page up/down are still "scrolls"Caolán McNamara1-2/+2
and should emit NotifyScrolled even if the scroll is large enough that the call to internal "scroll" optimization is omitted. (and like cursor up/down call NotifyScrolled after ShowCursor) Change-Id: Ie605bde8ce8312b2ff2be9fb471e2f7516b355d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148623 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-03-09tdf#136904 tdf#116084 tdf#121176 sw: fix Undo & anonymized w:del in w:insLászló Németh3-15/+52
Undo/Redo crash resulted by the workaround for anonymized w:del in w:ins. Anonymized (no time stamp) redlines are loaded with Epoch time (1970-01-01) since commit 2c51746997478ad5d0e7cc64aa6489769c473d43 "tdf#146171 DOCX: fix loss of change tracking, if no date", so it's possible to fix the original DOCX import problem using this value: don't combine anonymized deletion inside/over anonymized insertion, and remove all the workaround, keeping only their adjusted unit tests, and add new tests for the export fixed finally, which keeps anonymized w:del in anonymized w:ins. Revert commit 2de1fd7d8b8bd42c66190140cc4506df0c3367f1 "tdf#125187 DOCX track changes: fix w:del within w:ins", commit df4f405a153603551f67e289bbaccf9ac39b923c "tdf#121176 DOCX track changes: same size w:del in w:ins" and commit 7a810d6a9fb79a24d00e5dbd8e1223e6f8b09677 "tdf#116084 DOCX track changes: fix w:del within w:ins". Regression from commit 2de1fd7d8b8bd42c66190140cc4506df0c3367f1 "tdf#125187 DOCX track changes: fix w:del within w:ins". See also commit 64dcedcf7c073d1819794d68a33651b14877e1b5 "tdf#147760 tdf#142902 DOCX export: anonymize date and moveFromRangeStart". Change-Id: Id6e41187e7f94154389f24dd525067ac47ec7e58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148479 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 8f26482986fd9af5eac4efd44ec56fd994ec69f1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148498 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-03-08sw: fix crash in GetUpperSpaceAmountConsideredForPrevFrameAndPageGrid()Miklos Vajna1-0/+5
Crashreport signature: program/libswlo.so SwFlowFrame::GetUpperSpaceAmountConsideredForPrevFrameAndPageGrid() const sw/source/core/layout/flowfrm.cxx:1741 program/libswlo.so objectpositioning::SwAnchoredObjectPosition::GetTopForObjPos(SwFrame const&, SwRectFnCollection* const&, bool) const include/svl/itemset.hxx:101 program/libswlo.so objectpositioning::SwToContentAnchoredObjectPosition::CalcPosition() sw/source/core/objectpositioning/tocntntanchoredobjectposition.cxx:1020 program/libswlo.so SwAnchoredDrawObject::MakeObjPosAnchoredAtPara() sw/source/core/layout/anchoreddrawobject.cxx:424 Change-Id: If162602f6a1cc2108c0de385652e93e23be920be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148396 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-03-08tdf#154039 wina11y: Increase refcount for returned COM interfaceMichael Weghorn1-0/+1
The reference counter for the IUnknown interface of the COM object needs to be increased in `CMAccessible::get_accSelection` as well, not just in the called `CEnumVariant::Next`, because calling VariantClear` on the temporary variant afterwards decreases the ref count again. Regression from commit 00c0ee8cf0fac0c933c5ae600e99a64b1c7d4397 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Jan 31 07:41:14 2022 +0000 tdf#147083 wina11y: Return a11y object instead of child ID Change-Id: Id968c3d80b38961b836fbb1a9bd6dfeefdff813f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148393 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 38e2dde00da0207c5f7157bb427a006d32dfeb5b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148400 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-03-08ofz#56734 AbrtCaolán McNamara1-1/+1
Change-Id: I0426c0d3a56789b2f2d24fc87ed9e88653700ca5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148320 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-03-07tdf#154042 Use an initial height of one row for toolbar layoutCaolán McNamara1-0/+5
so the Toolbar positions this in the same place regardless of how many rows it eventually shows Change-Id: I7ec31e50557a099962fb051a1948781ef9abdfb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148403 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-03-07tdf#153642 ucb: fix broken save with cached DAVOptionsLászló Németh1-0/+5
Trying to save a document within the lifetime of the cached connection, e.g. re-save within a few seconds after the first and successful save failed with an error message in the case of Vibe 4.0.6 WebDAV server. Waiting 5-10 seconds after the last try was the only workaround to re-save the document. Details: aDAVOptionsException in Content::getPropertyValues() removed the isClass1 bit of the cached DAVOptions of the same TargetURL (note: of the folder of the WebDAV document). This disabled the DAV detection part of Content::getResourceType(), and later the correct HTTP redirect for the DAV connection. Fix this by keeping the cached bit in that case, too, when the added connection has a different lifetime, than the cached one. Follow-up to commit 30ca48f4dc0e65a3798e6b21574bc80f6d4953fa "tdf#152493 ucb WebDAV: fix upload using HTTP 1.0 fallback". Change-Id: I5d4578232581a4df654f76198fdddf096cba5267 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147570 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit d6182cb6704c06f33d284874b9fe96c85cce5bf5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147606 Tested-by: Jenkins
2023-03-07eFormat modified inside GetDateArea, but change not propogated to the callerCaolán McNamara2-2/+2
regression from: commit 6e7e19d9c300dbdd279789b09f94781e946fad52 Date: Wed Jul 15 12:10:32 2020 +0100 weld DateControl Change-Id: I74bc01383f04fd4e54a45058fbbc3bc082eef0e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148322 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-07Check iframe target for allowed document URLsSamuel Mehrbrodt2-1/+4
Change-Id: I00e4192becbc160282a43ab89dcd269f3d1012d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147919 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> (cherry picked from commit 288c0920a8475f9f2c537212e04aa7649192ad8c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148229 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-06tdf#153891 DOCX import: crash fix at missing cell propertiesLászló Németh3-1/+8
Regression from commit 81ce88aa80f8e7cde4fdc5b211e9500a3599643c "tdf#132514 DOCX import: fix lost table style with footer". Note: no crash without this fix by removing styles.xml from the test document. Change-Id: I7fd7edfc8f62e6b17c0c8f7a3bdec7d986ba57eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148053 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit e34074feeb1b918ab9f26a18c5fdb0b1f2e35f94) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148105 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 2a7ec5f17e01041418262dcb0229fe537fa8139f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148109
2023-03-04Resolves: tdf#153924 handle non-numeric and error values in rank arrayEike Rathke1-12/+32
... of LARGE()/SMALL() instead of yielding error value for all result elements. Fallout from commit e4c2d0bb57ab8ea8f5c400d103d01376b8140f22 CommitDate: Fri Nov 30 22:14:17 2018 +0100 i#32345 Support a matrix of rank argument for LARGE()/SMALL() that in ScInterpreter::GetTopNumberArray() required the entire rank array would have to be numeric, which with an empty cell or string it isn't. Change-Id: Ieaa1a68bb8f98614119550b1442665b6fbb4817a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148178 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 019e751c71dcb2d34c6fd8bb9dda267c6ba2b48e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148218 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-03update creditsChristian Lohmaier1-1944/+1971
Change-Id: I6d5a9f661041361e7c516887a298c84ac71e14ff (cherry picked from commit 7545f47eb93373324eed35a7253e55448bbbdfbd)
2023-03-02Update git submodulesChristian Lohmaier1-0/+0
* Update translations from branch 'libreoffice-7-4' to d3fef19e637f36da1a7b7b431d5e38324675621b - update translations for 7.4.6 rc2 and force-fix errors using pocheck Change-Id: I5de070e4831b68bc2923e4c779024974116a0ce4
2023-03-02Fix viewsettings countSamuel Mehrbrodt1-1/+1
Was missed in d0cacf09a1105d89bf3df84b18623d790e3aeb82 Change-Id: I43c1c9b595a8fc8e2982027093695556e182074e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148081 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> (cherry picked from commit 31a503a0a10aea0489ac2ebe5abd745f37e6402b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148094 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-03-02Related: tdf#153784 margin_bottom is a cnp nonsense, should be margin_endCaolán McNamara1-2/+2
Change-Id: Id14f63a8bfb64622e505903820b7f081c368389c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147924 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 3b279889daa9c37fe91663d16dd2d8c5938cc0d5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147992 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-03-01postgresql: upgrade to release 13.10Taichi Haradaguchi3-5/+5
Fixes CVE-2022-41862 Reference: https://www.postgresql.org/support/security/CVE-2022-41862/ Change-Id: I6075838972fec1c091f3150b19c5da4dc80ad6d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147982 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2023-03-01tdf#153669: Track formulas that stopped listening ...Kohei Yoshida7-31/+157
... then have them start listening again after the copy from clipboard is complete. Note that in case the pasted cells are formula cells, those will be handled together as well. Change-Id: Ia4be814b888734267a39f7c89435011968570b7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147940 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org> (cherry picked from commit e83c243018c1c7f6662f9a8ecdc731c5c071ea31) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147912 (cherry picked from commit 33b6c065a1629afd36c9ae0fe5daa18b972620e5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147983
2023-03-01curl: upgrade to release 7.88.1Taichi Haradaguchi3-6/+6
Fixes CVE-2023-23916, 2 CVEs that probably don't affect LO. Reference: https://curl.se/docs/security.html Change-Id: If9b3fc7c5ce66bfe1027caff39ea2c1cf55df7ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147977 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-02-28Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'libreoffice-7-4' to 1cc8b46fcaf00a436d8a4bd9d1b07a848d9e6eff - tdf#149056 Bad Help link for Address book wizard Change-Id: I3093fb88733b444b9a074d43d9971ad92ce384e2 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147064 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-02-27Always push a result, even if it's only an errorEike Rathke1-2/+2
PERCENTILE() and QUARTILE() if an error was passed as argument (or an error encountered during obtaining arguments) omitted to push an error result, only setting the error. Fallout from commit f336f63da900d76c2bf6e5690f1c8a7bd15a0aa2 CommitDate: Thu Mar 3 16:28:59 2016 +0000 tdf#94635 Add FORECAST.ETS functions to Calc Change-Id: I23e276fb0ce735cfd6383cc963446499dcf819f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147922 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 64914560e279c71ff1233f4bab851e2a292797e6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147900 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2023-02-27RES_LR_SPACE should fall through to default not RES_BACKGROUNDCaolán McNamara1-12/+12
due to commit 29dfcc7521311e547fc069466cc3edc9fcbdbe03 Date: Mon Nov 23 16:17:37 2015 +0100 tdf#94088 add import of HTML inline graphics splitting the condition that used to fall through to default handling with an unrelated RES_BACKGROUND case instead Change-Id: I26a077c755f214cf35582ec146fcf34f87cc4494 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147690 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-02-27Resolves: tdf#153763 first/last buttons in tabbar not respondingCaolán McNamara1-6/+9
Change-Id: Id6e70eca7c2d523643d9e38e8c7402879464bf5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147292 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-02-23tdf#153179 ODP export regression: fix lost shape at missing objectTünde Tóth2-0/+61
If the object is missing, it's still possible to keep its shape by exporting its preview graphic, as before the regression. Regression from commit adc042f95d3dbd65b778260025d59283146916e5 "tdf#124333 PPTX import: fix Z-order of embedded OLE objects". See also commit 907da02bf8b33c080538731864225b3c44251328 "tdf#152436 PPTX export regression: fix lost shape at missing object" Change-Id: I614730435a857c6cdf01d4cdfc525fc452dffa29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146247 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit da725dfe07f2cf10349772d1667591c4d6a6fe8a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146990 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146991
2023-02-23tdf#153640 Fix changing chart background color back to NoneSamuel Mehrbrodt1-1/+2
Change-Id: I653028d6016ca0caa72cb2a877cd23592c322a18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147351 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> (cherry picked from commit a2732de4bd080e3ed8894ba3618f48bc4c6d9abe) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147446 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-02-22update creditsChristian Lohmaier1-2610/+2848
Change-Id: Ic974dbd48cb9b1b2e417430325e4611a66d1aa7c (cherry picked from commit 1e12a4cc980ebabadde592d3159b93cc12e733a7)
2023-02-22tdf#132714 sw: fix crash at table row deletion associated to a chartLászló Németh3-0/+29
Using the table toolbar, deletion of the row of a text table resulted crashing in ActualizeSelection(), if the text table is associated to a chart, and the deleted row was the first data row of the chart. Fix this by emptying the outdated table selection cache m_SelectedBoxes in GetCellRangeName(). Note: since commit eea37aa26932d06ed8e93d001862bf45175c4446 "tdf#122995 Trigger Chart refresh directly in UpdateCharts for SW", the crash occurred immediately, i.e. without double clicking on the chart after the row deletion. Note: uitest needed to get the crash, not uiwriter. Change-Id: I78d126f245839ec1d8a8cc01257fe96d94ac0a21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147224 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 5b9855acc7fa6d1e4a5f53ff0bc47e1dd4729827) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147251 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-02-21nss: upgrade to release 3.88.1Michael Stahl1-2/+2
Fixes CVE-2023-0767 CVE-2022-3479 Change-Id: I688dc7d0785ed3344c33e331c7e9ef37baa720ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147387 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 538975a0e511ad79a7dd3c71300b993d1554cd03) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147360 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-20sc: fix divide by zero in ScGridWindow::DrawPagePreviewXisco Fauli1-6/+9
Seen in https://crashreport.libreoffice.org/stats/signature/ScGridWindow::DrawPagePreview(short,long,short,long,OutputDevice%20&) Change-Id: Iff64d0fe84c7d53b18db38598709ac47475a6715 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147236 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-20fix openssl build on aarch64 - _umul128 is not available on non x64Christian Lohmaier2-0/+59
adding upstream patch that uses __umulh as a fallback Change-Id: Ib95de30d3f7208c38421df0c63eb1ceafccd9354 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146839 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 821f4d6f0987450233e4f63e01f89484ec737258) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147228 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-02-20check SmGetActiveView()Xisco Fauli3-9/+10
it might be null See https://crashreport.libreoffice.org/stats/signature/SmPrintOptionsTabPage::~SmPrintOptionsTabPage() Change-Id: I7bc17da230784e6e3fc9c0b33848423ac113ab29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147221 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit a7fd1e067eb2af0ef329719c4c7dbb32cc5926b2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147246 (cherry picked from commit b905b793be520b9fdece8d12614566be82ce3c92) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147312 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-02-20tdf#153724: make sure to retrieve the variable value before checking the typeMike Kaganski3-1/+48
Commit 5760c94b8847164f9a7a181f031c7c86643944af tried to avoid all cases which could set an error in SbiRuntime::PushForEach. To do that, it checked the type of xObjVar before trying to get an object from it, which otherwise could set an error. But the type of the contained value can be not known until it is retrieved (which can happen inside SbxValue::Get in a call to SbxValue::Broadcast with SfxHintId::BasicDataWanted). This happens e.g. when the container passed to 'for each' is a call to some special function, like VBA's 'Selection'. Then SbxValue::GetFullType would return SbxEMPTY prior to SbxValue::Get. Let's make sure to call SbxValue::Get first (asking for a Variant, to avoid errors on type mismatch), and only then, check the actual result data type. Change-Id: Iaa697f38285505e50504ae09f9307fbd29e09a53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147273 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147298 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-02-17Stack check safety belt before fishing in muddy watersEike Rathke2-2/+14
Have it hit hard in debug builds. Change-Id: I9ea54844a0661fd7a75616a2876983a74b2d5bad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147205 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 9d91fbba6f374fa1c10b38eae003da89bd4e6d4b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147245 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-17check GetActiveWrtShell() and CheckAndGetWrtShell()Xisco Fauli10-73/+101
See https://crashreport.libreoffice.org/stats/signature/SwModule::ApplyItemSet(unsigned%20short,SfxItemSet%20const%20&) Change-Id: I7c719c5fe4cda9f6571592c30f39bd440053dbe9 Change-Id: Iaa4448dccd1a0ec1aefa539e476b5046ed50f7b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147203 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 05:07:15 +0000