summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2022-02-10Better handling of inetlocsRenwa Hiwa1-0/+1
LIBREOFFICE-39BBF6YM Change-Id: Iadae856a524a0ccda238785f60c8f3459e7b6157 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129714 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 7484c3393dc2216239cdb730983725fe2e08e730) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129622 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-10Update git submodulesChristian Lohmaier1-0/+0
* Update translations from branch 'libreoffice-7-3' to 72724a621be8785e2073bfbe5b081bc76b868011 - update translations for 7.3.1 rc1 and force-fix errors using pocheck Change-Id: I4aaa09256fc6fc2a2b70fb47f013613770e009e3
2022-02-10tdf#113785 sc FillAutoSimple: also optimize in negative directionJustin Luth1-4/+16
By only coding the optimization for the downward autofill, it totally broke an upward autofill. So this patch simply fixes the LO 4.3ish regression from commit a995462e6855061816c6529c366f20ace2b45868. This fix means that the non-hidden cells get the auto-value instead of being erased. However, the hidden cells are still erased (which is the topic of tdf#119957). I'm not going to bother with a unit test for this portion. If I can solve bug 119957 as well, then the unit test for that can cover both situations. Change-Id: If6320ccf87fa8893ca6766c265b7760cc46ed7d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129723 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> (cherry picked from commit 618084819babc839510860b74b36631749093c4c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129753 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-10tdf#147182 sw: accept/reject all changes of a table selectionLászló Németh3-3/+112
Selecting multiple cells of a text table which contain tracked text changes, and choosing Accept Track Change/Reject Track Change, only text changes of the first cell were accepted/rejected (a problem inherited from OOo). The fix allows to accept/reject also all tracked row deletions/insertions in the selected table rows by a single click. Note for manual testing: first cell of the selection should still contain a tracked change, otherwise Accept Track Change/ Reject Track Change menu items/icons aren't active. Conflicts: sw/qa/extras/uiwriter/uiwriter4.cxx Change-Id: I11e71075f4144bba86dda690ec712a24ccf815dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129717 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry-picked from commit 23846867ea32667ccf328c36142394dd6aaee8ba) Change-Id: I0d04de5b4c482e64ffd1a3b166968163139e7791 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129743 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2022-02-10tdf#147181 tdf#147322 sw: fix drag & drop multiple table rowsLászló Németh3-17/+255
With change tracking, moving multiple table rows tracked only the first row as deleted, and in the insertion point, as inserted. Without change tracking, only the first row were deleted from the original position. This is a regression of tdf#84806 from commit 5e8aa259e48d5602b932353bb146ebb523982cf2 "tdf#146967 sw table: fix freezing in Hide Changes mode". Add unit tests for the change tracking fix and for the original table moving fix in commit 7fe64353dc9950e19182a59a486a1ecac27cf98e "tdf#84806 Writer: drag and drop selected tables, don't empty". Conflicts: sw/qa/extras/uiwriter/uiwriter4.cxx Change-Id: I43250fcef4bbf482e67a7414f4f655e75d226b55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129635 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry-picked from commit 2bb9ad2078e355b71ab25db0c46f3d0bb19cf6d4) Change-Id: Id90664ba7611bb0fb7f03bcdf029ae4f211904cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129742 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2022-02-10tdf#147262: CallByName() argument names does not match that of VBAJulien Nabet2-2/+2
Change-Id: I3029b98abbe3b8facf01f0e50a7efdff545c2141 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129646 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit a555aa25bd17781b2828e13ac81456a45387284d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129754 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-02-10tdf#144353, tdf#146281 - Correctly copy the information about variablesAndreas Heinisch1-1/+4
During the assignment of a variable, copy its information only if there isn't already one present. Change-Id: I29fcfcd10406f2af0708a879d57e0a3c704f179e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127387 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> (cherry picked from commit d8428094c7f8b186b37c76fd7e9508a075424f80) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129752 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-10sw ODF shape import: improve is-textbox checkMiklos Vajna3-1/+49
This builds on top of commit 28d67b792724a23015dec32fb0278b729f676736 (tdf#107776 sw ODF shape import: make is-textbox check more strict, 2019-08-26). Before that commit, any non-empty parent style name on a shape resulted in an sw textbox. After that commit, we filtered out Writer images by checking for the Frame parent style name. The problem with this approach is that in case two documents are to be merged together, then it's reasonable to rename the Frame style, but then the complex content inside the shape gets lost. Fix the problem by going with a middle ground: require Frame as a prefix, but allow other names as well. This gets e.g. FrameX to work without breaking the "reject Graphics" use-case. (cherry picked from commit c2726c29b233b8fa7fbd390aafe149bdf7e94b07) Conflicts: xmloff/qa/unit/draw.cxx Change-Id: Id59ed28a64a9398f2f1620f69b5f148d65e6c95a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129729 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-02-10Sync flatpak-manifest.in with FlathubStephan Bergmann1-0/+1
...including <https://github.com/flathub/org.libreoffice.LibreOffice/commit/36da4a90d90eef38f5d02beed427a6dd112b93bb> "Merge pull request #178 from JamesBelchamber/file-picker-bookmarks: Adding access to gtk-3.0 config" Change-Id: Ie491cfa4481251ac55b8ab38a5068272165c12de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129727 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 12697a559b89539b03779030f94079a27cb1a12f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129751 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-02-10Resolves: tdf#132591 set property if Fixed Ratio checkbox was toggledCaolán McNamara1-5/+5
Change-Id: I10a2085e91bb592a8ccea7a50b7188250288e74a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129756 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-02-10Related: tdf#132591 connect adjustments to the correct spinbuttonsCaolán McNamara1-2/+2
commit eb807e785b6acda1529b2f58ada2c1e84b38f7f5 Date: Fri Feb 19 12:54:21 2021 +0100 Resolves tdf#140511 - UI glitches Clean-up of nested grids and boxes removed adjusments 1 to 4 commit dd5039ceea319ebfc72a3e032753b22538add12e Date: Tue Aug 24 11:14:46 2021 +0200 Resolves tdf#143633 - Image size wrong after disabling relative image width Adjustments added back, missing from 3cbecf3d0d9d68de286589e153ee31f8f709be03 restored them, but added two of them back to different widgets than they were originally connected to. but that's not the problem described in the bug report Change-Id: I6dcfbf76a6d76ac2f40679a678bcfb384b07d165 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129755 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-02-09(related: tdf#147206) writerfilter: fix another end in...Michael Stahl1-3/+13
...DomainMapper_Impl::PopFieldContext() that probably should use the m_aTextAppendStack insert position. Change-Id: I718d4b745258ca88e8ffec0bff5e5ea95037a312 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129686 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit d794c377e503aa7d00dbc6daad0aa32efad9e682) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129626 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-02-09tdf#147251 can't generally shrink popovers if they don't fit under/overCaolán McNamara1-17/+34
so instead forget about forcing under/over if it doesn't fit on either side and just position so its visible Change-Id: I529bf0d2bb1a3108a8702792ef067372441c2002 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129614 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-02-09docx import: right margin was not respected for para with listVasily Melenchuk3-0/+12
If paragpraph has list defined somewhere in styles and right margin defined in current style this margin was overriden with older value from parent styles. Change-Id: Ic0a2e9a1ce5f77b9ef38c549a62f1494c050982c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129595 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> (cherry picked from commit 42c5506a9e9ef58efd8193a193464e3b49d481ca) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129617
2022-02-09tdf#146672 - CDbl: skip spaces and tabs at the end of the scanned stringAndreas Heinisch3-15/+35
Change-Id: Ib7a4e8c7145b549a5327de23549d39d11f8590cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129648 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> (cherry picked from commit a79e7dc9e8097c199e91288027861e3883e14d1b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129620 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-09drop checksum assert that is platform dependentCaolán McNamara1-11/+0
Change-Id: I3459d753a8f655ca34ecf6c25fdfd9655687c6d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129660 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit dbf92d1825bed9f79925f232a5be7cd9f3a330f3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129615 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-02-09tdf#126287: docx import: use defered linebreakVasily Melenchuk5-3/+65
In some cases when we have combo linebreak, endparagraph and end section at very bottom of page, MS Word does ignores linebreak to avoid empty page with same section and lonely end paragraph mark. With defered linebreak we could simulate and ignore such linebreaks during import. Change-Id: Ie6ee4c0990ee1c2e853691a76953c83191664e43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119709 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129661
2022-02-08adjust gradient drawing in vclcanvas (tdf#144073)Luboš Luňák1-0/+12
For whatever strange reason the drawing does not use the given geometry, but something bigger. When I added direct drawing using VCL in a46cb5dc607d1d1af402ff3e8fce731e7427854d I naively assumed that the drawing area for the gradient would be the given area. Change-Id: Ia62cb0e5046e622679143eef56a3c6782781bf59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129298 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit adc2ac31fb2763077e48658756946a39d91c8e12) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129263 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-08PDF export: increase default precision of doublesMiklos Vajna1-3/+3
Follow-up to commit 50682cea4196819980c8e2d4018f80384097ce6f (PDF export: improve precision of pdf image sizes, 2022-02-04), sounds like a good idea to do this in general, not only in that specific case that was required for the test to pass. Change-Id: I5b36a5a3be26132e96a4de9d224abcaaf79beadb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129599 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit 30585873ca8c861aa2d13f85797930f62195ee55) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129613 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-08RTF paste: fix cursor creation on shapesMiklos Vajna3-3/+68
This went wrong in commit 232ad2f2588beff50cb5c1f3b689c581ba317583 (API CHANGE: add a "position" parameter to XParagraph/TextPortionAppend methods, 2012-11-28), the problem is that the text range is part of the shape text's node range, so we have to call createTextCursorByRange() on the shape's XText, not on the body text. Change-Id: Ifa97213659130b8c279022a6a03f920dca6061bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129603 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit ce8b6f3426e55b6d09a52eb4a7d17614fc1a6c15) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129612 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-02-08be more stylistically standardCaolán McNamara1-4/+4
Change-Id: I8fa978a5b58faa79c9c07b2c832a56b4d5230dd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129504 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit c59f37b9735a0ca122f29606508c50d25bbaa985) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129611 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-08sdext.pdfimport tdf#137128: Recognize more font name and weight...Kevin Suo2-1/+37
...values from the embeded 'PS' font names. Change-Id: I8465a6b1d845ce626848112f0a735a9ee3696e5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129136 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit bcf10015c5d12d363d0be9f6da25092c83112692) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129430 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-02-08tdf#145868 sd replace: if search changes, restart find/replaceJustin Luth4-9/+34
REPLACE is really a replaceAndFind instead of a findAndReplace. Thus, when you changed your search parameter and did a replace, it replaced the previously searched for item, and then found the first instance of the new search parameter. That of course is just wrong. So make sure to verify that the previous search matches the current search competely. However, that doesn't mean that the entire searchItem matches, since we don't want to restart the search just because the replace parameter changed. In my testing, this wasn't an issue for REPLACE_ALL. So the only time we need to worry about the last search result is in a replace once situation. P.S. This commit exposed that mpSearchItem can point to a destructed SvxSearchItem, so this patches unit test will crash if the other 7.4 commit is missing. Change-Id: I7be14d64534018718145c6ac5f8629ff5f2e5611 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129385 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129630
2022-02-08PDF export: improve precision of pdf image sizesMiklos Vajna2-2/+44
This helps exporting full-page PDF images from Draw more accurately. In case the page size was A4, then the page height is 841.8897637795276 i.e. 842 points. Full-page PDF images are scaled to this size, so the referred PDF form XObject has the reciprocal of that scaling. We used to just write 0.00118, doubling the precision leads to 0.0011878840. In practice the old precision resulted in e.g. hyperlink rectangles to get out of sync with link text after 2 roundtrips, while the new precision doesn't result in any noticeable modification to the link text position after a roundtrip. Change-Id: I72cc68696b9b9bcc1cbfde8df331c2b9c5f9eb29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129482 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit 50682cea4196819980c8e2d4018f80384097ce6f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129608 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-08tdf#113191: Add 21 and 42 in size list for CJK for typographic scale conventionJulien Nabet1-0/+2
Change-Id: I2be3160dbab780254b6f02db8dec69389ec500d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129530 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit ad9aa572594f04d2c498d087fb81b0fb215b8e7d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129609 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-08related tdf#145868 sd: Clone SvxSearchItem to avoid use after freeJustin Luth2-3/+2
I tested "if (mpSearchItem)" which passed, but then it crashed when trying to access (*mpSearchItem) == (*pSearchItem) because the mpSearchItem's DTOR had already been called prior to the if(mpSearchItem). Since mpSearchItem is never compared to another memory pointer, it is safe to assign it to a Clone. Steps to reproduce: 1.) open Impress and search for something 2.) change the search string to something else 3.) search again. Note that there isn't currently any code that hits this. I discovered it trying to craft a fix for bug 145868. Change-Id: Idc5f5a3e812ed3e49631347c35c3f4b2d8bb4127 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129347 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129629
2022-02-07ofz#44471 crash in isMoved if re-insert of invalid range failedCaolán McNamara1-1/+2
Change-Id: I21a3a3e544c016205d65d7e81889ebfddc7e322d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129563 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2022-02-07fix big-endian hsql to firebird migrationco-22.05-branch-pointCaolán McNamara1-2/+4
Change-Id: I047d2366ad80eca701924cb0f66b6b1bcfdcac5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129565 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2022-02-07tdf#145030 if all in effects list is unselected retain last marked objCaolán McNamara1-0/+5
in the slide selection Change-Id: Ibdd9c827fea3ef33f0ae385147b3fa633d5dff83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129244 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129271 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-07tdf#147032 unselect anything set_cursor selected as its side-effectCaolán McNamara1-0/+2
Change-Id: I723bbd82fc01f644de3bfb2a80b4640cec0cfbca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129243 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129249 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-07Revert "tdf#145030 resync with empty selection if we unselected everything"Caolán McNamara1-26/+11
This reverts commit ba535d8cbda1026823ce9796c20f97b7367d581f. Change-Id: I277e640c0f8ed0038e8ea867ddeef999a00b7b87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129242 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129248 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-07test fails with both fedora KacstBook and bundled KacstBook installedCaolán McNamara1-3/+1
fedora KacstBook ver is less than bundled KacstBook ver so bundled is preferred, bundled KacstBook has no Latin glyphs, but glyph fallback finds system one and sees it has the missing glyphs, determines that the whole thing can be done in the fallback font, so the toplevel is unused and so "invalid" and this test fails on checking that. The test is supposed to ensure that glyph caching gives the same result as uncached, which it does, so just assert if there is a difference between cached and uncached Change-Id: I3c424a17f3e544aa64f4af98e0c151fc00b2e6e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129437 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-02-07this test assumes KacstBook has no Latin glyphsCaolán McNamara1-2/+4
which is true for the one bundled with LibreOffice but is not true for the fedora one (kacst-book-fonts-2.0-26.fc35), but neither of them have Cyrillic glyphs Change-Id: Ide8b84502886c7b9e0bc4fcef4685b4b89ec2bc3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129436 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-02-07this test is endian-dependantCaolán McNamara1-0/+6
Change-Id: I03c1c926441f80c3741bb7d9231363603d0dbffe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129551 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-02-07WaE: storing the address of local variable [-Wdangling-pointer]Caolán McNamara1-1/+1
this is presumably what was intended Change-Id: I0c436c1440207140158ae902b17b43549a94d8c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129548 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-02-07qt5: crash entering ë with french IMCaolán McNamara1-0/+8
which for me with french IM enabled on my keyboard is physically AltGr+[ (crashes here on trying to underline ¨ with a length of 2) then e. Change-Id: Id59bd84af2ab4d8403b11b1a13efb2bbdb608199 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129547 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-02-07WaE: angle[1|2] may be used uninitialized [-Wmaybe-uninitialized]Caolán McNamara1-1/+1
Change-Id: If8771e4c73656d6f6d236d2d530d0ec92c1f5a7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129534 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-02-07Resolves: tdf#74577 tdf#92960 Create missing offsets in very outer tableEike Rathke1-0/+10
... if local table is outer table. Change-Id: I5996609264f4ad9efa8d76a8d0ab730bf1dded24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129540 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 8a9b870a40c41c7cae6e43452b593804fa17f831) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129550 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-02-06Resolves: tdf#147218 label doesn't have use-underline setCaolán McNamara1-0/+1
so the _ is shown to the user, not used to add an underline Change-Id: I2de707a2d1da8d842ef03497f9b8f69d37368f12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129442 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-02-05Colibre: New large Text Direction iconsRizal Muttaqin4-2/+2
Change-Id: Icd69c7b2bd873cdf1ea4547946802347cdd95873 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129446 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-02-05We no longer know how to contact TLX anywayStephan Bergmann2-21/+0
GCC 12 trunk started to warn > svtools/source/control/asynclink.cxx: In member function ‘void svtools::AsynchronLink::HandleCall_PostUserEvent(void*)’: > svtools/source/control/asynclink.cxx:76:15: error: storing the address of local variable ‘bDeleted’ in ‘*this.svtools::AsynchronLink::_pDeleted’ [-Werror=dangling-pointer=] > 76 | _pDeleted = &bDeleted; > | ~~~~~~~~~~^~~~~~~~~~~ > svtools/source/control/asynclink.cxx:75:10: note: ‘bDeleted’ declared here > 75 | bool bDeleted = false; > | ^~~~~~~~ > svtools/source/control/asynclink.cxx:75:10: note: ‘<unknown>’ declared here And while that is arguably a false warning, it points at some dubious code anyway: The only reason for the AsynchronLink _bInCall and _pDeleted members is to potentially SAL_INFO some "valuable historical artefact", if AsynchronLink::Call were ever called recursively. But 0de7513cd73f1f35265e42f9a2b9befe81302c2c "osl::Mutex->std::mutex in AsynchronLink" apparently already argued that such recursive calls can never happen, as locking _aMutex in a recursive call of Call would now deadlock. Change-Id: I9ee47ac65652e40e23a37be3d0694fa1185b877a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129104 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit a4348ec796e6efe0edce7bb8bfa47b1fa95d0e34) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129445 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-05Avoid -Werror=dangling-pointer=Stephan Bergmann2-27/+18
> vcl/source/bitmap/Octree.cxx: In constructor ‘Octree::Octree(const BitmapReadAccess&, sal_uLong)’: > vcl/source/bitmap/Octree.cxx:69:17: error: storing the address of local variable ‘aColor’ in ‘*this.Octree::mpColor’ [-Werror=dangling-pointer=] > 69 | mpColor = &aColor; > | ~~~~~~~~^~~~~~~~~ > vcl/source/bitmap/Octree.cxx:67:21: note: ‘aColor’ declared here > 67 | BitmapColor aColor; > | ^~~~~~ > vcl/source/bitmap/Octree.cxx:67:21: note: ‘<unknown>’ declared here (new with GCC 12) Change-Id: I5b1ffa15b92f2c41dbe51dfa843eb6bab3a4b449 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128517 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 5db574727f4564238a54159a1a0673eaa2884b69) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129444 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-05ScriptForge - (SF_Calc) fix range parsing error when leading $Jean-Pierre Ledure1-8/+11
When sheet name contains - a leading $ - surrounding single quotes an error message was errorneously displayed to the user. Corrected in the SF_Calc._ParseAddress() function Correction on master: https://git.libreoffice.org/core/+/de03a5ca23ddb09a55014f9d79ebcd6df54503bb%5E%21 Change-Id: I588c07132b9d98a3351f03e3e876ef81812d2f04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129426 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2022-02-04tdf#147088: Also handle U+FFFE, U+FFFF invalid XML 1.0 charactersStephan Bergmann1-19/+35
Change-Id: Ieec81fcde41e3508c6a9aa4250d7050db2fbb442 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129296 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 2f3a0bfbfe110c0837b3c7e04f9ad0969d6e56e4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129329 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-04fix direct leaks in vcl cppunit testsCaolán McNamara1-138/+138
the uses of new are wholly unnecessary Change-Id: Id7238be6e73567add8a0d3ed6dc9f3262e15c043 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129435 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-04tdf#125849 cannot modify the ruler unit of measure in translated UICaolán McNamara4-5/+21
Change-Id: Ica74dd5e55d30605ee03affa4b724ffa4ec65b5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129333 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-02-04tdf#147144: Writer crash after adding rectangle, add link and delete itJulien Nabet1-5/+8
bt: 0 SdrMark::GetMarkedSdrObj() const (this=0x0) at include/svx/svdmark.hxx:68 1 0x00007f958c31555c in SwDrawBaseShell::GetState(SfxItemSet&) (this=0x6bbcd70, rSet= SfxItemSet of pool 0x2dc5730 with parent 0x0 and Which ranges: [(5678, 5678), ... = {...}) at sw/source/uibase/shells/drwbassh.cxx:899 2 0x00007f958c3148bd in SfxStubSwDrawBaseShellGetState(SfxShell*, SfxItemSet&) (pShell=0x6bbcd70, rSet=SfxItemSet of pool 0x2dc5730 with parent 0x0 and Which ranges: [(5678, 5678),...] = {...}) at workdir/SdiTarget/sw/sdi/swslots.hxx:8315 3 0x00007f95a6025de1 in SfxDispatcher::FillState_(SfxSlotServer const&, SfxItemSet&, SfxSlot const*) (this=0x65acbe0, rSvr=..., rState=SfxItemSet of pool 0x2dc5730 with parent 0x0 and Which ranges: [(5678, 5678), (5713, 5713),...] = {...}, pRealSlot=0x7f958d1eb190 <aSwDrawBaseShellSlots_Impl>) at sfx2/source/control/dispatch.cxx:1658 4 0x00007f95a6004fe9 in SfxBindings::Update_Impl(SfxStateCache&) (this=0x65863c0, rCache=...) at sfx2/source/control/bindings.cxx:259 Change-Id: I910429103f505e855d88b7efe9a5ca771d5fc92e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129388 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 91fd537a4517409da87229fd7c0f21d269973d43) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129344 Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2022-02-04the real font used for 'Roman' is arbitraryCaolán McNamara5-10/+6
the font name isn't a typical semi-standard one so it neither exists nor has a standard fallback. binary-hack "Roman" to "Arial" which is conveniently the same length and does have a standard fallback of "Liberation Sans" which we can add a dependency on via more_fonts Change-Id: I1d9b8294f67a00a1e5cabe38b71467e66b83aedf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129473 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-02-04tdf#147119:Revert "tdf#123973 fix missing MasterPage content in export"Xisco Fauli1-0/+4
This reverts commit 87866def6bfe2ee91be34a5ce37b79d6da881617. Change-Id: Ic3c8c70ef789b83cec0614e766a3c067cbf078fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129351 Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129407
2022-02-04rhbz#2047319 drop the SolarMutex before QApplication::init()Caolán McNamara2-8/+16
https://invent.kde.org/qt/qt/qtwayland/-/merge_requests/24#note_383915 reproducible with with qt5-qtwayland-5.15.2-17.fc35.x86_64 and export OOO_FORCE_DESKTOP=plasma5 export SAL_USE_VCLPLUGIN=gtk3 Change-Id: Icdf6b8709865c723c266e6400169b33639a1b0e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129428 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-25 07:07:54 +0000