summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2022-01-10tdf#130426 - Rename file for tdf#145693Andreas Heinisch1-0/+0
Change-Id: I1435f3e8c8ecf41ecd6b2766e19009c6b1783326 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128099 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128211
2022-01-10tdf#68341: trim some variables passed on Base wizardJulien Nabet1-2/+2
Here is a git grep -n fillString: dbaccess/source/ui/dlg/ConnectionPage.cxx:232: fillString(*_rSet,m_xJavaDriver.get(), DSID_JDBCDRIVERCLASS, bChangedSomething); dbaccess/source/ui/dlg/ConnectionPage.cxx:235: fillString(*_rSet,m_xConnectionURL.get(), DSID_CONNECTURL, bChangedSomething); dbaccess/source/ui/dlg/ConnectionPageSetup.cxx:134: fillString(*_rSet,m_xConnectionURL.get(), DSID_CONNECTURL, bChangedSomething); dbaccess/source/ui/dlg/DBSetupConnectionPages.cxx:144: fillString(*_rSet,m_xETBaseDN.get(),DSID_CONN_LDAP_BASEDN, bChangedSomething); dbaccess/source/ui/dlg/DBSetupConnectionPages.cxx:416: fillString(*_rSet,m_xETDriverClass.get(),DSID_JDBCDRIVERCLASS,bChangedSomething); dbaccess/source/ui/dlg/DBSetupConnectionPages.cxx:417: fillString(*_rSet,m_xETHostname.get(),DSID_CONN_HOSTNAME,bChangedSomething); dbaccess/source/ui/dlg/DBSetupConnectionPages.cxx:418: fillString(*_rSet,m_xETDatabasename.get(),DSID_DATABASENAME,bChangedSomething); dbaccess/source/ui/dlg/DBSetupConnectionPages.cxx:531: fillString(*_rSet,m_xETDriverClass.get(),DSID_JDBCDRIVERCLASS,bChangedSomething); dbaccess/source/ui/dlg/admincontrols.cxx:117: OGenericAdministrationPage::fillString( *_rSet, m_xHostName.get(), DSID_CONN_HOSTNAME, bChangedSomething ); dbaccess/source/ui/dlg/admincontrols.cxx:118: OGenericAdministrationPage::fillString( *_rSet, m_xDatabaseName.get(), DSID_DATABASENAME, bChangedSomething ); dbaccess/source/ui/dlg/admincontrols.cxx:121: OGenericAdministrationPage::fillString( *_rSet, m_xSocket.get(), DSID_CONN_SOCKET, bChangedSomething ); dbaccess/source/ui/dlg/admincontrols.cxx:123: OGenericAdministrationPage::fillString( *_rSet, m_xNamedPipe.get(), DSID_NAMED_PIPE, bChangedSomething ); dbaccess/source/ui/dlg/adminpages.cxx:219: void OGenericAdministrationPage::fillString(SfxItemSet& _rSet, const weld::Entry* pEdit, sal_uInt16 _nID, bool& _bChangedSomething) dbaccess/source/ui/dlg/adminpages.cxx:227: void OGenericAdministrationPage::fillString(SfxItemSet& _rSet, const dbaui::OConnectionURLEdit* pEdit, sal_uInt16 _nID, bool& _bChangedSomething) dbaccess/source/ui/dlg/adminpages.hxx:218: static void fillString(SfxItemSet& _rSet,const weld::Entry* pEdit,sal_uInt16 _nID, bool& _bChangedSomething); dbaccess/source/ui/dlg/adminpages.hxx:219: static void fillString(SfxItemSet& _rSet,const dbaui::OConnectionURLEdit* pEdit,sal_uInt16 _nID, bool& _bChangedSomething); dbaccess/source/ui/dlg/advancedsettings.cxx:351: fillString( *_rSet, m_xAutoIncrement.get(), DSID_AUTOINCREMENTVALUE, bChangedSomething ); dbaccess/source/ui/dlg/advancedsettings.cxx:353: fillString( *_rSet, m_xAutoRetrieving.get(), DSID_AUTORETRIEVEVALUE, bChangedSomething ); dbaccess/source/ui/dlg/detailpages.cxx:146: fillString(*_rSet,m_xOptions.get(),DSID_ADDITIONALOPTIONS,bChangedSomething); dbaccess/source/ui/dlg/detailpages.cxx:303: fillString(*_rSet,m_xEDHostname.get(),DSID_CONN_HOSTNAME,bChangedSomething); dbaccess/source/ui/dlg/detailpages.cxx:406: fillString(*_rSet,m_xEDDriverClass.get(),DSID_JDBCDRIVERCLASS,bChangedSomething); dbaccess/source/ui/dlg/detailpages.cxx:407: fillString(*_rSet,m_xEDHostname.get(),DSID_CONN_HOSTNAME,bChangedSomething); dbaccess/source/ui/dlg/detailpages.cxx:408: fillString(*_rSet,m_xEDSocket.get(),DSID_CONN_SOCKET,bChangedSomething); dbaccess/source/ui/dlg/detailpages.cxx:608: fillString(*_rSet,m_xETBaseDN.get(),DSID_CONN_LDAP_BASEDN,bChangedSomething); So I don't think that trimming these may be harmful. Now we could also add a boolean fillString to indicated if a trim is needed but does it worth it? Change-Id: I6fa841a0c062d4b81a09549cbe865fd627d070cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128029 (cherry picked from commit 470d1be4ec5a3a5a0aba8febda06600ea39852c5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127960 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-10ofz#43818 delete of uninitialized pointerCaolán McNamara1-0/+12
Change-Id: I91509915c18c3e9b54cb3047462b9dd9a8c7a46b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128086 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-09tdf#146084 No hyphenation warning for PashtoHossein1-0/+1
Pashto language, which is spoken in Afghanistan and Pakistan uses the Arabic script, and does not use hyphenation. Change-Id: I87a1235b183055b0961ab27f45281be7aa9965c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128191 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 7ac5ee3546e15455c5ee306af234bb7fe8a29049) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128148
2022-01-09tdf#146641 allocations attempted while hidden are discarded by gtkCaolán McNamara1-0/+5
Change-Id: I46288cf4c106e2763feba298f1c44dbbf6c85581 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128080 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-09tdf#146423 don't set a size-request during a size-allocCaolán McNamara4-26/+44
and use a better width calculation Change-Id: Ib873a8ed9e6424c09630650af352ba5a20c674b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128077 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-09Resolves: tdf#129745 don't override child help for application framesCaolán McNamara1-2/+11
the glue WindowInstance is created on demand, and on creation descends into any existing open dialogs and changes their help handlers. We could not descend into child dialogs, but we shouldn't change the app frame help handler anyway. Change-Id: I8d149d324f04824fbe9eec517d8c482fd96b125b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128075 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-09Resolves: tdf#146285 the "edit" button should be insensitiveCaolán McNamara1-1/+2
for this case Change-Id: Ib60577d10bd4a91ea01c5aa6fcf3d50b38fbe24d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128067 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-09tdf#146084 Don't warn for languages without hyphenationHossein3-1/+28
Upon opening a Writer document containing some languages that do not use hyphen, an alert is created with the text: 'Missing hyphenation data Please install the hyphenation package for locale "ab_CD".' in which 'ab_CD' is the locale. This patch removes the warning for these languages, that do not use hyphenation: * Arabic script languages (except Uighur) + Persian (Farsi) + Kashmiri + Kurdish (Central Kurdish and Southern Kurdish with Arabic script) + Punjabi + Sindhi + Malai + Somali + Swahili + Urdu "Words are not hyphenated in Arabic language text, however hyphenation is possible for Uighur text written in the Arabic script" https://www.w3.org/International/i18n-tests/results/word-break-shaping The list from MS documents is lenghty, but some of the languages are were not available in LibreOffice, so they are ommited: https://docs.microsoft.com/en-us/typography/script-development/arabic There were languages like Hausa and Kanuri from Nigeria that use both Latin and Arabic script, but only Latin script was listed in the LibreOffice languages, so they were also ommited. * CJK languages + Japanese + Korean + Chinese + Yue Chinese "CJK languages differ from European languages in that there are no hyphenation rules" https://tug.org/TUGboat/tb25-0/cho.pdf * Vietnamese "In Vietnamese all words consist of single syllables, so they are often very short; hyphenation is not allowed at all." https://tug.org/TUGboat/tb29-1/tb91thanh-vntex.pdf Hyphenation is declined in Vietnamese orthography since 1975 https://www.quora.com/When-did-hyphenation-decline-in-Vietnamese-orthography The fix for Japanese (tdf#143422) was previously done in: 53d5555f13371252874ec962dee4643168d26780 and the functionality is preserverd with the current patch. An alternate approach would be adding all the unicode scripts, specifying the script for each langauge, and decide upon the script (mostly) and not (only) the language. More information about the hyphenation usage of many scripts can be found in: https://r12a.github.io/scripts/ This is the list of Unicode scripts: https://unicode.org/standard/supported.html https://en.wikipedia.org/wiki/Script_(Unicode)#List_of_scripts_in_Unicode Change-Id: I7d2b4ee55a0893d1f0d1f9cd3b7cc037a49589b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126435 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 151c56ed547490a99d912524c0e56b5d6d4a1939) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128082 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-08Update libassuan to 2.5.5Thorsten Behrens3-5/+6
Change-Id: Icd1034f4c6b43605f5d43fe28f7e0d191311daf0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127664 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> (cherry picked from commit 568a5bba2a30ab588b52677106bf209d4c0df758) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128084 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-08Update gpgme to 1.16.0Thorsten Behrens11-145/+17
* remove GPGME_CAN_EXPORT_MINIMAL_KEY, upstream now has support for key export flags in c++ wrapper (gpgmepp >= 1.14) * therefore, external/gpgmepp/add-minimal-keyexport.patch now fully obsolete, tweaked xmlsecurity code to use upstream function * bits of external/gpgmepp/find-libgpg-error-libassuan.patch are upstream now (configure and makefile pieces, though we keep configure.ac changes for the while - to not pick up system versions too easily) * external/gpgmepp/gpgme.git-fe2892618c20cd40c342cce26ffb6ac4644fd3c3.patch.1 was from upstream anyway, removed Change-Id: I991c20c0eeff0f9135e97c991afcb905be55a959 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127665 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> (cherry picked from commit 78dae8b20b85686d1a642415195d2e10fbb2dc1f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128085 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-08Update libgpg-error to 1.43Thorsten Behrens3-35/+35
Change-Id: Iecd4a131f9c5b43bb03c5f9c4b6c7efe36e443aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127663 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> (cherry picked from commit 7d50d74d0a10b4811b82f66dc5ac5a696c2974c7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128083 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-07tdf#146617: iterators may be invalidated during handler callMike Kaganski1-12/+12
... when the handler decides to remove itself from listeners. Change-Id: I1d5fe802f50d284bf70d747edaff0a19852c5a7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128054 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit e9dce4e8cbea04d6c6636a45f5a172e986714409) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128074 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-07ofz#43052 crash in WW8TabDesc::MergeCellsCaolán McNamara1-0/+45
Change-Id: I4d7acc006458598ad43033fa8e35b2f422d76ff5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127770 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-07ofz#43376 Null-dereferenceCaolán McNamara1-2/+5
Change-Id: I57f67465e4f8ca6fc6bd47d7b095e9b470d9d2c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128072 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-07Resolves: tdf#146592 "Reset" to the current document propertiesCaolán McNamara1-2/+6
not those seen at the initial load of the TabPage Change-Id: Ieba4c278a0a9b7fef3030d8462cb845c27dba9b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127959 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-06Add configure test for the backtrace implementationIsmael Luceno7-44/+43
Improve robustness by testing explicitly; instead of assuming based on the OS, test first the libc and then test for libexecinfo. The assumption was wrong for FreeBSD (included since 2017) and for musl-based systems (not in libc). Also, remove INCLUDE_BACKTRACE and clean up a bit. Ref: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220271 Change-Id: Ib4b7fd4fe2cdf5f76babe47a21bd2990fcf42649 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127538 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit c1be12396088563ed77ed61e54fd4e153469701d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127767 Reviewed-by: Ismael Luceno <ismael@iodev.co.uk> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-05Fixed tdf#143142 when unable to scroll table column width properties.alt1-0/+7
Fixed the issue when unable to scroll table column width properties on some occasions. Change-Id: Id0a89d248d2a4effc0cb08ca0dc60aa23f66d70e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127938 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit a409739efe4507e23926d1862215c128904fda88) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127955 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-05Outline folding: Check frame area is valid before using pointer toJim Raykowski3-31/+56
saved outline frame It seems when a frame is removed it is not immediately destroyed, so a pointer to the removed frame may not be a null pointer. This patch checks for valid frame area definition before using the save outline frame pointer with intention to fix an intermittent crash occurrence when an outline paragraph is removed. Change-Id: I4f9b55acc6aeb83553a3f26c2701159c2ba439a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127717 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127933 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-05tdf#134960 SwNavigator: Improve table content member list orderingJim Raykowski1-15/+12
by sorting by table node index in the document model This has advantage over sorting by frame layout top position because it always shows the tables in the order they appear from start to end in the document independent of single-view, muliple-page, or book view. Change-Id: I9103c32bbb32afd44e0528b1c7744812075b2339 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127828 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127932 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-05tdf#146471: Firebird: impossible to delete an external tableJulien Nabet1-2/+5
See https://bugs.documentfoundation.org/show_bug.cgi?id=146471#c1 for full explanations Change-Id: Ie75669cf951429654ff8e6c28508b9fee2ee03bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127715 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 13de0ade50bec34be612ba4a3196c2efd9ce3b4e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127584 Reviewed-by: Lionel Mamane <lionel@mamane.lu> Tested-by: Jenkins
2022-01-05tdf#146489 writerfilter: ensure only character propertiesJustin Luth3-1/+65
This is another RTF regression found against LO 6.0's commit fdfdea4d5af51a68f2d497cc5c3359d74c385fd5 tdf#82173 writerfilter: apply char properties to footnote The original commit in LO 6.0 intended that only character properties were used. A follow-up commit for RTF tried to ensure that these would be on the top of the stack. However, in this case, it seems like somehow the table is getting involved in putting the paragraph context on the top. (Actually, there is no GetTopContextOfType(CONTEXT_CHARACTER) at all.) In any case, aFontProperties should only contain character properties, so ensure that. The unit test shows that there is still some kind of import problem, because the footnote marker should be a large, red character, but it is just normal text. See tdf#108949. Change-Id: I1ea7256891b198046f79f0d3a36e43d6c2ae3383 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127943 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> (cherry picked from commit 44c37c4af2d23d1469cdeeb56f2f5a2bef493986) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127954
2022-01-04tdf#146432: fix crash with REGEXP_REPLACE() executed in query editor to MariaDBJulien Nabet2-2/+33
See bt here: https://bugs.documentfoundation.org/attachment.cgi?id=177292 Noticing: warn:legacy.osl:7697:7697:connectivity/source/drivers/mysqlc/mysqlc_general.cxx:188: mysqlToOOOType: unhandled case, falling back to VARCHAR I found REGEXP_REPLACE returned a MYSQL_TYPE_LONG_BLOB and some locations should be taught about it. Also, let's also deal with MYSQL_TYPE_TINY_BLOB and MYSQL_TYPE_MEDIUM_BLOB Change-Id: Ib7fd6ef747ce1b1851c788d2bb5a1d4ec673aee1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127919 (cherry picked from commit e43573aae0fa07d170fb042b7184156c851c1f77) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127952 Reviewed-by: Lionel Mamane <lionel@mamane.lu> Tested-by: Jenkins
2022-01-04For now, disable tests giving dubious results on AArch64Stephan Bergmann3-0/+16
when built with -ffp-contract enabled (-ffp-contract=on default on Clang 14 trunk since <https://github.com/llvm/llvm-project/commit/f04e387055e495e3e14570087d68e93593cf2918> "Making the code compliant to the documentation about Floating Point", cf. 19559ebbee160d1625d06feec7e6566772dad231 "Allow for a presumably more precise result of BESSELY(80,9)"; and -ffp-contract=fast default when building with optimizations on GCC) on both Linux (with 6cb20e0b298f41fe88984aebfe5454f936a0ae3a "Disable CppunitTset_sc_*_functions_test for linux_aarch64 for now, too" reverted) and macOS. Change-Id: Ie867d999173410ec9868bd14c0ee04bbba371920 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126727 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 72b25619960cdaa829c8ea10e27d9c0b20a2c26f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127784 Reviewed-by: Eike Rathke <erack@redhat.com>
2022-01-04Update git submodulesOlivier R1-0/+0
* Update dictionaries from branch 'libreoffice-7-3' to ea693b5eae635edf5c6da4cda695724b335a8681 - Update French hyphenation rules Change-Id: Iece44334bc101a97f6297d13b24b2fc764ffc7f5 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/127910 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 3fc3d99f071693dd40a78ba1f729ef47dc189692) Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/127780 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-04tdf#126269 Add clipping to diagonal border linesArmin Le Grand (Allotropia)2-58/+235
See task for in-deep discussion. Needed to do some re-arrangements to add clipping to diagonal border lines. It is necessary to only clip visible geometry but not touch vectors that get added to be able to solve all that dynamic border line style start/end overlapping. Change-Id: I656a5cd63a011140ee1281873e44ab5e60606b67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127713 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127757 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-04tdf#134982: use the right protocol for Mysql/MariadbKrzysztof Hałasa1-3/+7
Thank you Krzysztof Hałasa for the patch! Change-Id: Ib7532a716b7e0fa73f309e0a4f9af9e663e0d3df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127673 Reviewed-by: Lionel Mamane <lionel@mamane.lu> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins (cherry picked from commit 0143ec4d3d56eeee7edf16371c1d3c3981890b71) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127786 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-04Always use <poll.h>, no modern system needs <sys/poll.h>Ismael Luceno3-6/+2
This was standardized in IEEE 1003.1-2001, so more than 20 years old. Verified following systems using online resources: - FreeBSD 3.0 (1998) - NetBSD 1.3 (1998) - OpenBSD 2.0 (1996) - CentOS 5.0 (2007) - Debian 4.0 (2007) - IRIX 6.5.30 (2006) - SunOS 4.1.3 (1992) - SUSE 10.2 (2008) - Red Hat 5.0 (1998) So the check used for BSDs on vcl/unx/generic/dtrans/X11_selection.cxx was never correct. On GNU/Linux specifically, <poll.h> is provided since glibc 2.0 (1997). musl libc produces the following warning if the non-standard header is included: /usr/include/sys/poll.h:1:2: warning: #warning redirecting incorrect #include <sys/poll.h> to <poll.h> [-Wcpp] Change-Id: Ia8f4b9e1ee069f86abe03140c18a77d17336d09c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127666 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 4242c7b91887236375e08e2b6b24de0cecbf1626) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127586 Reviewed-by: Ismael Luceno <ismael@iodev.co.uk> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-04idlc: Always use sys/wait.h on UNIXIsmael Luceno1-5/+0
According to (and since) POSIX.1-1988 it's always <sys/wait.h>; and all supported systems include it, back to 1995. AFAICT, none of the systems mention <wait.h> in their manual pages. musl libc produces the following warning if the non-standard header is included: /usr/include/wait.h:1:2: warning: #warning redirecting incorrect #include <wait.h> to <sys/wait.h> [-Wcpp] Change-Id: Iff1293a08ad080fdc987770596b10ef08cc145a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127537 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 9d0568609be69a2b533d9a4bf4d03c37c15e779d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127585 Reviewed-by: Ismael Luceno <ismael@iodev.co.uk> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-04tdf#146223 PPTX import: fix master objects visible propertyTibor Nagy3-0/+25
Master objects were always visible after the import, which could change the background of the slides. Change-Id: Idc5260718f2916e207f751286044e9a7fabdee89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126833 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 4574a1ea408c2ac30042dca32d02207ec7add4da) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127777 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-03changed CuiResId into SvxResId.Kiyotaka Nishibori1-1/+2
though some translation entries for tooltip for border preset images were in svx.mo, cui/source/tabpages/border.cxx referred the entries to cui.mo with CuiResId route, and the translations was not gotten. this commit is alternative change. Change-Id: Ica7a7ea71f7afe7044104b9d953f1b3edf9c2503 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127771 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-03CppunitTest_sc_subsequent_filters_test2: check format instead of stringXisco Fauli1-5/+7
Otherwise, this might fail. See 660e538ee77109bc3e7dff4491164d696e503abc < Disable broken part of ScFiltersTest2::testTdf126116 > Change-Id: I40534b70fc19ee163d9e6cb0c081fae40b81fdb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127774 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-03crashtesting: set document reference only onceVasily Melenchuk1-1/+1
For SdtHelper we need to keep valid reference to main document (in our case first call), not to any of substreams like header, footer, etc. Change-Id: Id9d99c1a9bff9a3392eea4cc6e2abe774e5868d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127672 Tested-by: Jenkins Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de> (cherry picked from commit 923665ac525e8dad218724327fdbd98d4fb790ad) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127581 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-03tdf#136368 bump to libnumbertext 1.0.8László Németh1-2/+2
– Soros.py: fix FutureWarning: Possible nested set at position, reported by Rene Engelhard – tdf#136368 fix Old Hungarian transliteration – fixes for Chinese, French, Marathi, Polish, Ukrainian Change-Id: I99f56b8a6089bc94f43056bcdedcae89ff4e68c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127821 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 98fd4fcdc61202846e0957cb6aaed9e4a2d2c520) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127773 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-03Update git submodulesAdolfo Jayme Barrientos1-0/+0
* Update helpcontent2 from branch 'libreoffice-7-3' to 3b4862b4c8deab562584d00830ea5883a65b488d - These don’t need to be translatable Change-Id: I58aaae67b6c4e138ff7b7d7a655bdc3a71761bb7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127886 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 66835d0b781676751880a47989a5464b9dd1590f) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127772 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-01-02Bump copyright year to 2022Adolfo Jayme Barrientos18-99/+100
Change-Id: Icbb000677066127fa67e8c22fb0ab6880acc0169 (cherry picked from commit fb32c4d96141ccc1766fa4e39405130fcf409a6a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127848 Reviewed-by: Martin Srebotnjak <miles@filmsi.net> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-12-31tdf#146472: Missing page count in Go to Page dialog for some localesJulien Nabet1-1/+0
See https://bugs.documentfoundation.org/show_bug.cgi?id=146472#c2 and https://bugs.documentfoundation.org/show_bug.cgi?id=146472#c3 The _ is added by use_underline/use-underline In the case of Czech language, "z" was used as the shortcut for _Cancel/_Zrušit and since "of" is translated "z", the "_" had been put before the 1 and "z $1" was transformed into "z $_1" So let's remove the shortcut for "page_count" Change-Id: I11a03cf11cafe108f77f4b6427fa66b1686d0ea7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127768 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-12-29tdf#145960 - Return type of boolean operators should be of type booleanAndreas Heinisch4-4/+62
In addition, added missing vba test to the test routine. Change-Id: I3ee837e1eab30f10e0a4169d11014f9b6574ad1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127631 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> (cherry picked from commit 565a5fdee3c00b383b4d36180be845d48fd42556) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127580 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-29Fix autoconf>=2.70 gcc-wrapper breakageThorsten Behrens1-0/+1
Re-generated configure file gets confused & claims not finding C89- compatible compiler for gcc-wrapper-building libassuan with msvc underneath. Work-around the problem by telling toolchain right off that this _is_ a std c compliant compiler. Change-Id: I4fa23673b790bc70a9294951df545c27f5236f81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127641 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> (cherry picked from commit 1bb0e177124d5d6661b72df6c7d848fb23639652) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127578
2021-12-28update creditsXisco Fauli1-1449/+1449
Change-Id: Id193ff586cecdb483a212c8e44d438ee905736ae
2021-12-28tdf#140726 Change func func(<?>) to func <?>(<?>) in MathJeff Huang1-1/+1
Change-Id: I9b28097c0043c7c6daffb047683b6af1f0202223 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127393 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 54115790926a5964534472dff7e4661ea34acb28) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127377 Reviewed-by: Po-Yen Huang <jeff@mail.ossii.com.tw> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-12-28tdf#145090 LO Calc Crash with drop-down-menuNoel Grandin2-3/+3
avoid attempting to call into widgets while in the middle of dispose regression from commit 8d485ec0cd35ee1ae7684f2b6ca96c0f0c6f9dac IsDisposed->isDisposed in vcl/../window Change-Id: If346dc9dc8547f8da28d091bfa20eff39162a0b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127437 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 3454055d4da3326540905fc69626b934d5aa0744) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127483 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-12-28tdf#126269 Handle diagonal borderline better for merged cellsArmin Le Grand (Allotropia)1-74/+143
Change-Id: I04776bbd237dc1fa881385bfe9be7f034b58e35a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127431 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127591 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-12-27tdf#146257: sw: better handling for list numbering = NONEVasily Melenchuk3-1/+58
Previously during refactoring were lost some corner cases with some level having disabled numbering. In this case LO should strip useless delimiters up to next level. For example, if second level has disabled numbering, third level should look like "1.1", but not "1..1". Change-Id: I259a16b456f51bc76d5c8360974d0acadfc36776 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127517 Tested-by: Jenkins Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de> (cherry picked from commit bf2b46aa15665dde63ceff4e7686b99b3990354f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127569 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-27tdf#130595: Parameter query with :parameter IS NULL doesn't workJulien Nabet1-0/+6
Problematic SQL here: SELECT * FROM "Table1" WHERE "Name" = :name OR :name IS NULL Firebird considers there are 2 parameters. When providing an empty string, no pb, OPreparedStatement::setNull is called which is ok for both parameters When providing a non empty string, we go to OPreparedStatement::setString. For first param no pb but for second param, sql type is SQL_NULL so it must be taken into account See https://www.firebirdsql.org/file/documentation/html/en/refdocs/fblangref25/firebird-25-language-reference.html#fblangref25-datatypes-special-sqlnull for full details Change-Id: I80dff259d85957e8547c098e4c48b642cce26804 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127571 Reviewed-by: Lionel Mamane <lionel@mamane.lu> Tested-by: Jenkins
2021-12-27Related tdf#130595: SQL_NULL means pVar->sqldata = nullptrJulien Nabet1-2/+4
Fix this assertion: 0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:49 1 0x00007fcc7f2b2536 in __GI_abort () at abort.c:79 2 0x00007fcc7f2b241f in __assert_fail_base (fmt=0x7fcc7f418998 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=0x7fcc614a5de7 "false", file=0x7fcc614b3542 "/home/julien/lo/libreoffice/connectivity/source/drivers/firebird/Util.cxx", line=346, function=<optimized out>) at assert.c:92 3 0x00007fcc7f2c1212 in __GI___assert_fail (assertion=0x7fcc614a5de7 "false", file=0x7fcc614b3542 "/home/julien/lo/libreoffice/connectivity/source/drivers/firebird/Util.cxx", line=346, function=0x7fcc614b3865 "void connectivity::firebird::mallocSQLVAR(XSQLDA *)") at assert.c:101 4 0x00007fcc6149c715 in connectivity::firebird::mallocSQLVAR(XSQLDA*) (pSqlda=0x5bca950) at connectivity/source/drivers/firebird/Util.cxx:346 5 0x00007fcc61470722 in connectivity::firebird::OPreparedStatement::ensurePrepared() (this=0x5bc6a10) at connectivity/source/drivers/firebird/PreparedStatement.cxx:110 6 0x00007fcc614714df in connectivity::firebird::OPreparedStatement::getMetaData() (this=0x5bc6a10) at connectivity/source/drivers/firebird/PreparedStatement.cxx:147 7 0x00007fcc6147165d in non-virtual thunk to connectivity::firebird::OPreparedStatement::getMetaData() () at connectivity/source/drivers/firebird/PreparedStatement.cxx:154 8 0x00007fcc66694776 in dbaccess::OPreparedStatement::getMetaData() (this=0x5bc6cc0) at dbaccess/source/core/api/preparedstatement.cxx:178 9 0x00007fcc6669480d in non-virtual thunk to dbaccess::OPreparedStatement::getMetaData() () at dbaccess/source/core/api/preparedstatement.cxx:179 10 0x00007fcc667711bd in dbaccess::OSingleSelectQueryComposer::getColumns() (this=0x5bb99f0) at dbaccess/source/core/api/SingleSelectQueryComposer.cxx:824 Change-Id: I285c9bcd0b1fd059994d339ae4d419dec516f220 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127551 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit abaf2b4ac7faada914885d95c49b554f576d7cee) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127567 Reviewed-by: Lionel Mamane <lionel@mamane.lu>
2021-12-27tdf#146003 tdf#106613 Draw: fix slide rename not updated in NavigatorJim Raykowski3-12/+8
Change-Id: Iee2d34e3192e3f7875ab10f3e79e9dc1a2fb20b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127397 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit 9bfc42015acd6ae3475ab7927ccc006507cc38a2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127486 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-26bump liborcus dependency in pkg-config check to >= 0.17.2Rene Engelhard1-1/+1
since that is what is needed now since aadbac5467bb6ab768f87ed6ec003c55159d54aa to make the tests pass. (One could do a version-check like done with libmwaw etc, too, but didn't follow that route) Change-Id: Id70871104b5c12462db12f14b637c6884a98954c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127144 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org> (cherry picked from commit e31191d45c27965bb1a73577b9fcc99b5d88795a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127374
2021-12-26Outline folding: check pointer before useJim Raykowski1-4/+9
Change-Id: Ifa79ef5f286da77fdac9464b4e271021107bf34e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127348 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit 1609bb6ab5e34fc8fff67240e3c49dde93f2d2d7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127378 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-26Resolves: tdf#146377 Propagate condition error of IF(condition)Eike Rathke1-1/+7
Previsouly a given ELSE-path was executed as the condition is never TRUE on error, which wasn't significant unless the ELSE was an error evaluating function like IFERROR() or ISERROR() or other IS...() functions. This changes behaviour of an undocumented side effect, so *might* break existing expressions that (unwillingly?) relied on it. Gnumeric, Excel and GoogleSheets all agree on propagating the error value as implemented now. Change-Id: I0905a363be7a3b02925f1c41b4e6c8d36f12df93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127515 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 1c14b9efb0677dea65ff220222fbb8d5c2aa6973) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127481
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 19:16:47 +0000