summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2019-06-20Version 6.3.0.0.beta2, tag libreoffice-6.3.0.0.beta2libreoffice-6.3.0.0.beta2Christian Lohmaier3-0/+0
Change-Id: Ifa10fe199213eddd931a9ee8990899be45f7a0ef
2019-06-20bump product version to 6.3.0.0.beta2Christian Lohmaier1-1/+1
Change-Id: Id76f90f60d1674a91d1d750c9e5fd69e8bc3ae85
2019-06-20tdf#122221: Bin apparently unnecessary early returnTor Lillqvist1-6/+0
Removing these few lines of code fixes the problem on iOS, and has no apparent ill effect on macOS. But sure, I didn't check that thoroughly on macOS, so in case this has a bad effect on macOS after all, need to reinstate the few lines but make them #ifndef IOS. (Still passes make check.) Change-Id: I2380d010ba223a698acfe916fca4580a1502be98 Reviewed-on: https://gerrit.libreoffice.org/73470 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2019-06-20fix putting ; between entriesCaolán McNamara1-1/+1
broken since... commit 8bddb3c77048814b370351e0eb72c31f289fb34f Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Mar 14 12:51:31 2019 +0000 weld SwInsertBookmarkDlg Change-Id: I2a07820dd5ea13976a1044323a5b52835fd711f1 Reviewed-on: https://gerrit.libreoffice.org/74469 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2019-06-20Resolves: tdf#108209 let auto fill handle double click stop at existing dataEike Rathke1-26/+37
Also consolidate the code to take both, left and right, data areas into account, still preferring left if it exists. Change-Id: I3d46b32f3790fd367fe92712fbcab0c392294599 Reviewed-on: https://gerrit.libreoffice.org/74462 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 7dd57a914be5f8fc2b53b7725c16625887cf7439) Reviewed-on: https://gerrit.libreoffice.org/74468
2019-06-20Update git submodulesChristian Lohmaier1-0/+0
* Update translations from branch 'libreoffice-6-3' - update translations for 6.3.0 beta2 and force-fix errors using pocheck Change-Id: I2f20dff5fd47ee5f99d612b22661d5248adaccc2 (cherry picked from commit a56aea7a0ea288b3bd3abf15cfa8ab2506841850)
2019-06-20tdf#125754 sw_redlinehide: avoid recursive layout in SetHideRedlines()Michael Stahl2-0/+5
During SwLayHelper::CheckInsertPage(), SwRootFrame::CheckViewLayout() is called, which may change the size of the view, which causes a StartAction()/EndAction(), therefore layouting the frames existing at that point, which moves some content onto the newly created frame, but CheckInsertPage() expects to find only SwLayoutFrames on it and crashes. 40 SwLayAction::InternalAction(OutputDevice*) (this=0x7fffd2333f00) at sw/source/core/layout/layact.cxx:551 41 SwLayAction::Action(OutputDevice*) (this=0x7fffd2333f00) at sw/source/core/layout/layact.cxx:348 42 SwViewShell::ImplEndAction(bool) (this=0x56eaff0, bIdleEnd=false) at sw/source/core/view/viewsh.cxx:295 43 SwViewShell::EndAction(bool) (this=0x56eaff0, bIdleEnd=false) at sw/inc/viewsh.hxx:600 44 SwCursorShell::EndAction(bool, bool) (this=0x56eaff0, bIdleEnd=false, DoSetPosX=false) at sw/source/core/crsr/crsrsh.cxx:254 45 SwView::OuterResizePixel(Point const&, Size const&) (this=0x5589850, rOfst=Point = {...}, rSize=Size = {...}) at sw/source/uibase/uiview/viewport.cxx:1125 46 SwView::DocSzChgd(Size const&) (this=0x5589850, rSz=Size = {...}) at sw/source/uibase/uiview/viewport.cxx:203 47 SizeNotify(SwViewShell const*, Size const&) (pVwSh=0x56eaff0, rSize=Size = {...}) at sw/source/uibase/docvw/edtwin3.cxx:67 48 SwViewShell::SizeChgNotify() (this=0x56eaff0) at sw/source/core/view/viewsh.cxx:1077 49 AdjustSizeChgNotify(SwRootFrame*) (pRoot=0x56ea6c0) at sw/source/core/layout/pagechg.cxx:824 50 SwRootFrame::CheckViewLayout(SwViewOption const*, SwRect const*) (this=0x56ea6c0, pViewOpt=0x0, pVisArea=0x0) at sw/source/core/layout/pagechg.cxx:2377 51 SwPageFrame::Paste(SwFrame*, SwFrame*) (this=0x66aa500, pParent=0x56ea6c0, pSibling=0x0) at sw/source/core/layout/pagechg.cxx:941 52 InsertNewPage(SwPageDesc&, SwFrame*, bool, bool, bool, bool, SwFrame*) (rDesc=..., pUpper=0x56ea6c0, bOdd=true, bFirst=false, bInsertEmpty=false, bFootnote=false, pSibling=0x0) at sw/source/core/layout/frmtool.cxx:2853 53 SwLayHelper::CheckInsertPage() (this=0x60a9170) at sw/source/core/layout/laycache.cxx:680 54 SwLayHelper::CheckInsert(unsigned long) (this=0x60a9170, nNodeIndex=1699) at sw/source/core/layout/laycache.cxx:890 55 InsertCnt_(SwLayoutFrame*, SwDoc*, unsigned long, bool, unsigned long, SwFrame*) (pLay=0x6f20f60, pDoc=0x54c86a0, nIndex=1698, bPages=true, nEndIndex=2627, pPrv=0x6ef2d20) at sw/source/core/layout/frmtool.cxx:1503 56 MakeFrames(SwDoc*, SwNodeIndex const&, SwNodeIndex const&) (pDoc=0x54c86a0, rSttIdx=SwNodeIndex (node 1588), rEndIdx=SwNodeIndex (node 2627)) at sw/source/core/layout/frmtool.cxx:1910 57 UnHideRedlines(SwRootFrame&, SwNodes&, SwNode const&, std::__debug::set<unsigned long, std::less<unsigned long>, std::allocator<unsigned long> >*) (rLayout=..., rNodes=..., rEndOfSectionNode=..., pSkipped=0x0) at sw/source/core/layout/wsfrm.cxx:4445 58 SwRootFrame::SetHideRedlines(bool) (this=0x56ea6c0, bHideRedlines=false) at sw/source/core/layout/wsfrm.cxx:4539 59 SwView::Execute(SfxRequest&) (this=0x5589850, rReq=...) at sw/source/uibase/uiview/view2.cxx:658 To avoid that, do StartAction()/EndAction() in the UI caller of SwRootFrame::SetHideRedlines() already; the other callers in Undo/DocumentRedlineManager should already be covered by Actions. Change-Id: I366140415d5714d386af3cf9db30e39b12ade2ce Reviewed-on: https://gerrit.libreoffice.org/74369 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit dd489bc01adc22fc5015ea56b61d66104af184a8) Reviewed-on: https://gerrit.libreoffice.org/74430
2019-06-20tdf#125660 sw_redlinehide: don't create redlines for GrfNode/OLENodeMichael Stahl1-0/+5
This started to assert/crash with commit d258fc29560baa5ecae03ebc2740e11420643e27, but such redlines are really not valid so it's a regression from commit 16916a14a2ce382aa4ff2a25f8e477108aba5a67. Change-Id: I4c03a96a43b62a3c5321535a34c2d09b155b79c0 Reviewed-on: https://gerrit.libreoffice.org/74371 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit edca548f865f4c19f213c1386905ec3591326461) Reviewed-on: https://gerrit.libreoffice.org/74418
2019-06-20zero width column in manage changesCaolán McNamara2-6/+26
https://github.com/exaile/exaile/issues/580 the fixed_width request is not handled by the time the width is queried. Use the requested width if the width is still 0. assert when such columns value are stored, and ignore existing useless ones on read Change-Id: Ibce74ec6a232edcf36b929f71474418b3e742856 Reviewed-on: https://gerrit.libreoffice.org/74445 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-20tdf#125982 a11y use-after-free of editengineCaolán McNamara1-2/+8
Change-Id: I467f0715b2e7e1e65faed19bd2a5e31939426bfd Reviewed-on: https://gerrit.libreoffice.org/74429 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-20dispose on all responses, not just OKCaolán McNamara1-1/+1
Change-Id: Ie78a1cb4fa7f188aeab547d49123449f06b0da6c Reviewed-on: https://gerrit.libreoffice.org/74427 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-20tdf#125309 XLSX editing: fix hyperlink at numeric dataTünde Tóth1-3/+12
Long Cell-level hyperlink was clickable in neighboring cells. Change-Id: I3e2a4db170975d997f3fe471188fd0ead593ad6e Reviewed-on: https://gerrit.libreoffice.org/74033 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 711ccfbac1ef28fdf03ceea820be8d3e9f8a4009) Reviewed-on: https://gerrit.libreoffice.org/74420 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-06-20InvalidateAtWindow should be preferredCaolán McNamara1-1/+1
it already call GetWindow()->Invalidate(aClipRect) internally for the usual case, and correctly calls EditViewInvalidate when the editview is not used in a vcl::Window Change-Id: I9f985cb91bc768b410838289efc994d9a5b249d4 Reviewed-on: https://gerrit.libreoffice.org/74422 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-20fix crash with non-window outputdevice betterCaolán McNamara1-12/+17
Change-Id: I93511574f8ab7d564baf1f031d54ca0e72ca345e Reviewed-on: https://gerrit.libreoffice.org/74417 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-20Resolves: tdf#92503 introduce TimeZone to calendar loading and default to UTCEike Rathke7-14/+110
Without that, the system's time zone was used which on DST transition dates leads to non-existent times when switching to/from DST. As the calendar use and number parser/formatter nor conversions or calculations are time zone aware, using not DST afflicted UTC is the better choice. Change-Id: I3303c6620d8c4b9d081555c8293954fb1bd67895 Reviewed-on: https://gerrit.libreoffice.org/74386 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 942de6a01ba990e5f3bc55ce4ab3737a03f67f39) Reviewed-on: https://gerrit.libreoffice.org/74399
2019-06-20InvalidateWindow should be preferredCaolán McNamara1-1/+1
it already call View::GetWindow()->Invalidate internally for the usual case, and correctly calls EditViewInvalidate when the editview is not used in a vcl::Window Change-Id: Ic83150117a8738ce5c6f34875057fd743bdb173a Reviewed-on: https://gerrit.libreoffice.org/74366 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-19Colibre: Fix wrong master/page, remove uneccessary extra bold linerizmut121-57/+62
Change-Id: Ibb809807294a9fef201fa6c62912f25917374259 Reviewed-on: https://gerrit.libreoffice.org/74373 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 36fe1461c5ae7a7db175c77688aaff1a1d12551a) Reviewed-on: https://gerrit.libreoffice.org/74388 Tested-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2019-06-19tdf#126000 Crash deleting templateNoel Grandin1-4/+7
regression from commit 72c191e046112df73c66be8dc8d1bec5a546fa60 Date: Wed Sep 19 12:11:38 2018 +0200 loplugin:useuniqueptr in ThumbnailView Change-Id: I9bdcec5c2f14b1bd33998041d4b2d8cd2f7be052 Reviewed-on: https://gerrit.libreoffice.org/74362 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 801bb2d4002cf2034315875440a6aee358951eb9) Reviewed-on: https://gerrit.libreoffice.org/74372 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-19allow copy/paste when not hosted in vcl::WindowCaolán McNamara1-4/+4
Change-Id: I1b30cb700461fa66192a4b86bf577d1babc76cb7 Reviewed-on: https://gerrit.libreoffice.org/74354 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-19fix memory usage regression when loading files with lots of marksNoel Grandin1-3/+6
regression from commit 3c3a371c799d00475deb13b4c3e0a8860c7e4fb3 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Wed May 15 15:35:51 2019 +0200 tdf#125254 Performance: A spreadsheet opens too slow, part2 without this fix, the file from the above bug chews up more than 16G and crashes my box. With the fix, it loads, and requires about 2G. Change-Id: I87063196e56b49eab52e77126347bf8d421b1e0f Reviewed-on: https://gerrit.libreoffice.org/74352 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 64362b2e10ad5cbe88374bcafa6d5f120d27fe5b) Reviewed-on: https://gerrit.libreoffice.org/74358
2019-06-19NB tabbed_compact cleanupandreas kainz3-249/+88
Change-Id: I070f81e2c5a623374c72a8a4ff5a034bf3d1f11c Reviewed-on: https://gerrit.libreoffice.org/74338 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com> (cherry picked from commit e1f5b833f5e8d7b7d08cbcfb102df3f49d2dd518) Reviewed-on: https://gerrit.libreoffice.org/74356
2019-06-19SmartArt: support ForEach referencesGrzegorz Araminowicz7-1/+90
ForEach 'ref' parameter causes specified ForEach node to be used instead. Used to create recursive structures like organisation charts. Change-Id: Iee61b2e103759355b59beb8d3f33eb3cce47c590 Reviewed-on: https://gerrit.libreoffice.org/74271 Tested-by: Jenkins Reviewed-by: Grzegorz Araminowicz <grzegorz.araminowicz@collabora.com> (cherry picked from commit 76478f9938a5f6d96ac65b3b633280024b60baed) Reviewed-on: https://gerrit.libreoffice.org/74337
2019-06-19sw: fix assert on layout of ooo63564-1.odtMichael Stahl1-1/+23
The problem is that some SwTextFrames (1415 in particular) inside the follow-flow-row of a table move backwards, during(!) which the follow-flow-row is deleted; i.e., the SwTextFrame was already moved backwards by the pNewUpper->Calc() in MoveBwd(), then it is Cut and Pasted at the end of pNewUpper, when it is actually already a lower, somewhere in the middle... This triggers the assert in SwFrame::PrepareMake() that was added in commit e14056e6e88d9b8d988b7b88b2776a8fc952031b Prevent this by using the IsDeleteForbidden() check that was introduced in commit 0005b330eaed0b5559042d2597fb45e0c9125d7e; this is similar to how MoveBwd() already locks section frames to prevent such problems. Ultimately a regression from 18765b9fa739337d2d891513f6e2fb7c3ce23b50. Change-Id: I893ec3e491b4cbe1569edf97fec31d3dd74548ed Reviewed-on: https://gerrit.libreoffice.org/74298 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 1e6dec4b4313212a3bdc6bb06155fd65e795368b) Reviewed-on: https://gerrit.libreoffice.org/74342
2019-06-19SmartArt: support multiple levels of shapes in LayoutNodesGrzegorz Araminowicz4-17/+38
it is needed for recurrent ForEach node, so that shapes on different levels are divided and can be layouted separately Change-Id: Iefbc82925078fe2346858748259680fa8ea252d6 Reviewed-on: https://gerrit.libreoffice.org/74043 Tested-by: Jenkins Reviewed-by: Grzegorz Araminowicz <grzegorz.araminowicz@collabora.com> (cherry picked from commit 596a03b65e1b870be671ea1a44f4fba9fc66e4ae) Reviewed-on: https://gerrit.libreoffice.org/74341
2019-06-19tdf#111824 Chart OOXML Export: fix Z axis labelsBalazs Varga3-0/+16
Export 3D barchart Z ("deep") axis properties into <serAx> xml tag, as the OOXML Standard requires. Change-Id: I8ee2282a28e9b4bdea6e96c96256f832b1a1aada Reviewed-on: https://gerrit.libreoffice.org/74170 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 1b26a6e7a4e3865d1555fa0612845c765b114b49) Reviewed-on: https://gerrit.libreoffice.org/74339 Reviewed-by: Balazs Varga <balazs.varga991@gmail.com> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-06-19tdf#125782 use correct 'current point' for quadraticcurvetoRegina Henschel3-17/+31
Use the same way to get the 'current point' as in command arcangleto. The error was visible in shape teardrop. Change-Id: Ie7af2b9111150bae7e3ea492eeb439a0cc2bfe7c Reviewed-on: https://gerrit.libreoffice.org/73723 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> (cherry picked from commit 39599fc689364b70cf83e834a5742cc2181b13b0) Reviewed-on: https://gerrit.libreoffice.org/74253 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-06-19tdf#125947 Two tools are missing from default Form Controls toolbarRoman Kuznetsov9-18/+18
Change-Id: Ie54b2a3f5051b115f8f04467282090a93525dfc3 Reviewed-on: https://gerrit.libreoffice.org/74191 Tested-by: Jenkins Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com> (cherry picked from commit 385128671716e70b9540a67e213d6495bf50662b) Reviewed-on: https://gerrit.libreoffice.org/74267 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-06-18Colibre, elementary, KJ: Fix for tdf#107144rizmut64-58/+60
elementary: - Fix blurred zoom icons - Reverse top arrow on Small Capitals icons Change-Id: I81883334e5cfaf3dab528ed61ea46894017a6c36 Reviewed-on: https://gerrit.libreoffice.org/74301 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 11a1bdc5fa0312111ddf9c1b7779a114b97e361c) Reviewed-on: https://gerrit.libreoffice.org/74317 Tested-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2019-06-18tdf#125934 Qt5 set the desktop file name...Jan-Marek Glogowski1-2/+4
.. but only on wayland, as this also overrides the individual window icons on X11. Change-Id: I1b453b23f0dfd4ef2616d7b8054580a6018cdc53 Reviewed-on: https://gerrit.libreoffice.org/74293 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 17c91a53d25c0b82524e04a0c108f8e0abc76685) Reviewed-on: https://gerrit.libreoffice.org/74304
2019-06-18Qt5 initialize bool before lcl_textMimeInfo callJan-Marek Glogowski1-2/+2
Change-Id: Ie1b2e77145c4f84dc7d2c1edd214363b7fa0625e Reviewed-on: https://gerrit.libreoffice.org/74294 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 288e729ecfdb7dbb9a4ca00cbc03bcdfe9442a0d) Reviewed-on: https://gerrit.libreoffice.org/74303
2019-06-18fix crash in header/footer calc dialogCaolán McNamara2-6/+17
cut and paste can happen when the EditView isn't in a vcl::Window Change-Id: I9fdbfe28c5ca5dd680b821ff8ce4e0133ab203aa Reviewed-on: https://gerrit.libreoffice.org/74280 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-18tdf#89991 DOCX: import Show changes from older formatsLászló Németh1-2/+10
w:formatting is optional, w:markup can be instead of w:insDel, too. Change-Id: Ic689499a880dcc7c97497e4381dff31610f745bf Reviewed-on: https://gerrit.libreoffice.org/73943 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 8b3c861c46ae12d21b7b3a550e2daa21d2006b77) Reviewed-on: https://gerrit.libreoffice.org/74274 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-06-18NB tabbed compact big update and syncronisation between appsandreas kainz5-2706/+7773
Change-Id: Ie1178e1e36334b35c7a00b2ec918c79041150c80 Reviewed-on: https://gerrit.libreoffice.org/74268 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com> (cherry picked from commit 1f2bc634cd48e6f093fa6821253bd18621eaa1e3) Reviewed-on: https://gerrit.libreoffice.org/74273
2019-06-18tdf#120170 Prevent escape key press focus to documentJim Raykowski2-3/+8
...from style, fontname, and fontsize comboboxes used in sidebar tool boxes when sidebar is undocked Windows build does not show this bug but Linux does for SAL_USE_VCLPLUGIN's gen, gtk, and gtk3. This patch checks the combobox parent object type for type sidebar tool box and if so skips the release focus call that sets focus to the frames container window which incorrectly sets focus to the document for Linux build. Probably a lower level fix for this but I'm not at that level yet :-) Change-Id: Ie33ea4238f7e8715fbd0389efd9185598a528ced Reviewed-on: https://gerrit.libreoffice.org/72970 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit c81055eb075efffa9cd123913a684ac3258903d5) Reviewed-on: https://gerrit.libreoffice.org/74250 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-06-18tdf#89991 DOCX: import/export Show changes modeLászló Németh8-5/+48
handled by the optional w:revisionView OOXML setting. Using disabled Show Changes mode, exported DOCX contains <w:revisionView w:insDel="0" w:formatting="0"/> as the documents exported from MSO with disabled Show Changes and disabled Options -> Trust Center -> Trust Center Settings -> Privacy Options -> Make hidden markup visible when opening or saving (Note: this last setting needs also for opening the documents really with disabled Show Changes in MSO). Change-Id: I9f2c7df572f33838ae63185de21431102a7e139e Reviewed-on: https://gerrit.libreoffice.org/73885 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 0e27158c4f6a6a7676a77afb6b37dd30b3f6d100) Reviewed-on: https://gerrit.libreoffice.org/74254 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-06-18tdf#75659 Chart: fix empty legend at not available legend namesBalazs Varga3-2/+36
by using localized versions of "Unnamed Series 1" etc. Note: OOXML files don't contain the default or fallback legend names used by MSO in this case, so the original empty string replacement of the missing names resulted bad chart import. Change-Id: I2897c70d9003e1ab3241dd569de0d79821d896b1 Reviewed-on: https://gerrit.libreoffice.org/73817 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 007bf60611e2ba5a65ffabe80dbb0e279fcb9f26) Reviewed-on: https://gerrit.libreoffice.org/74252 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga991@gmail.com> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-06-18tdf#120047 Support attribute harpoon/wideharpoon in MathTakeshi Abe16-7/+51
... for an alternative style of vectors. They are vec/widevec analogs but with COMBINING RIGHT HARPOON ABOVE (U+20D1). The new attribute names are deliberately long in order to make fewer accidental collisions with variable names in formulae of exising documents. This also adds a glyph uni20D1 to OpenSymbol. Change-Id: I31666e57808aa0e0327500916d3b862549891886 Reviewed-on: https://gerrit.libreoffice.org/72987 Tested-by: Jenkins Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> (cherry picked from commit 93eeaf0ad902214fb6b4205606b24046a458ee45) Reviewed-on: https://gerrit.libreoffice.org/74251 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-06-18tdf#125916 DOCX import: fix outline numbering at tracked deletionLászló Németh3-0/+19
Now there is no extra header after import (fixed regression from the commit 8acc15b5113c798ecdbeed91456a92e7b0c1334e "tdf#118699 DOCX import: don't add numbering") and the actual outline numbering is stable during the next export/import cycles (losing correct numbering is the original bug of DOCX import with change tracking). Change-Id: I49a78549c10c4ce0b97bb2d593059bf25c4d7aab Reviewed-on: https://gerrit.libreoffice.org/74054 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org> (cherry picked from commit eeb9481304572cc404ea1da9f3dabff43d6d191c) Reviewed-on: https://gerrit.libreoffice.org/74255 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-06-18tdf#125719 sw: rtf: refactor associated character propertiesSerge Krot10-134/+495
1. \rtlch, \ltrch should be placed before their properties. 2. Do not mix associated and normal character properties in output. 3. Do not output empty "\rtlch \ltrch", "\ltrch \rtlch" pairs. 4. Handle associated character properties runs instead of handling separately their parts without order of them. Change-Id: Ibbf7365d04708682a5f1eb664a579c60a47465d2 Reviewed-on: https://gerrit.libreoffice.org/72578 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit fd95fb975b754d71d3750e85431a4e596a40e659) Reviewed-on: https://gerrit.libreoffice.org/73868 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-18tdf#124549 Check Button toggle state before toggle.Shubham Goyal1-0/+4
Change-Id: I362cbc5613010e6586d63d6ebe45b40f05ffcbf1 Reviewed-on: https://gerrit.libreoffice.org/74117 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 770bf5a1f42be2d7397b30b91467a7dca4dc1785) Reviewed-on: https://gerrit.libreoffice.org/74248 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-06-18tdf#125968 fix the result order of text mime infoJan-Marek Glogowski1-2/+2
lcl_textMimeInfo returns three booleans when decoding the text mime string in the order: NoCharset / locale encoded, UTF16, and UTF8. Change-Id: I3cc4090e9874125ed68ec953d7d72889dead269b Reviewed-on: https://gerrit.libreoffice.org/74183 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins (cherry picked from commit 3a804b9301cbf68ae583d9f37b0e4e1635e63abe) Reviewed-on: https://gerrit.libreoffice.org/74207
2019-06-18tdf#122239 Qt5 implement lazy clipboard handlingJan-Marek Glogowski5-339/+513
This changes the Qt5Clipboard to a lazy loading one, which will just deliver data on read requests. This fixes not only the PRIMARY selection problems with Writer, but will generally speed up C'n'P, inside LO, because the data has not to be copied or transferred via QMimeData. This is mainly done by implementing the "mirror" interface of the Qt5Transferable, the Qt5MimeData using the retrieveData override. To prevent clipboard loss on shutdown, this sets a deep copied QMimeData of the current XTransferable, to make it persistent. This code explicitly doesn't use any of the QMimeData convenience functions and relies completely on LO's string handling, so we won't mix in eventual Qt bugs; all bugs are ours... Change-Id: I43d92a95df8fcac88dc41b00021cea0b5f040413 Reviewed-on: https://gerrit.libreoffice.org/73288 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit bcca1cf28cbd6c961d59bd8b8a8e58184dfc3823) Reviewed-on: https://gerrit.libreoffice.org/74206
2019-06-18Qt5 refactor and move XTransferable implementationsJan-Marek Glogowski8-236/+239
There is already duplicate code getTransferDataFlavorsAsVector. Maybe getTransferData can be also merged later. Change-Id: Iaa1c16990c1f19757f04944bcd21f395f6b8f69b Reviewed-on: https://gerrit.libreoffice.org/73301 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 2f0114b6244af429def59e107bd0b2835818913c) Reviewed-on: https://gerrit.libreoffice.org/74205 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-06-18Qt5 remove header using namespaces and Vcl prefixJan-Marek Glogowski4-81/+84
This is mainly about the using namespace in the Qt5Clipboard header. While at it get rid of the Vcl prefix. Change-Id: I62a804a83afe2feb4bf130eb5475790bc52365c4 Reviewed-on: https://gerrit.libreoffice.org/73287 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 6e8448cdf0541f017e8b54734dd0928e935c73fa) Reviewed-on: https://gerrit.libreoffice.org/74204 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-06-17Colibre: Fix for tdf#107144 & clean SVG filesrizmut102-341/+85
Change-Id: I6747f6e4331720828eff7ece184f4a8203684571 Reviewed-on: https://gerrit.libreoffice.org/74178 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit df878758fc8abb13dd9e97f2619f400a28d99d66) Reviewed-on: https://gerrit.libreoffice.org/74197 Tested-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2019-06-17KJ & elementary: Fix for tdf#89884, tdf#124127rizmut444-3388/+825
- Add/update support for locale language - Update for RTL language elementary: - Change ruler related icons's color - Update caption to be real caption - Update shadow below form icons - Add 3D extrusion, direction & surface icons - Update doc properties to use wrench just like upstream etc Change-Id: I7bea93526c98835da74e5818d9a55785a8462d60 Reviewed-on: https://gerrit.libreoffice.org/74180 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit c8f9bd9e1bc4c077d3fc3038d3a7147de0dfb0c7) Reviewed-on: https://gerrit.libreoffice.org/74196 Tested-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2019-06-17long winded falseCaolán McNamara1-2/+1
Change-Id: I79510d5156123f03b97dc4c2a0426347ef969d90 Reviewed-on: https://gerrit.libreoffice.org/74179 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-17weld SvxHlinkDlgMarkWndCaolán McNamara11-304/+261
Change-Id: I8aacfc54592074c976530fa9d1dbf860c1fb0ad4 Reviewed-on: https://gerrit.libreoffice.org/74155 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-17sw: restore ~SwIndexReg() assertMichael Stahl1-1/+1
Was commented out in b7b78dfc0719c3aa0e250b2992d3b04e135a26be, presumably by accident. Change-Id: I831b4a6a73183ee7969b63adc8fb87a8519789d4 Reviewed-on: https://gerrit.libreoffice.org/74161 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 3c5a468c4a9896d0c7b579002789cd87eb31dffd) Reviewed-on: https://gerrit.libreoffice.org/74168
2019-06-17Related: tdf#125935 allow focus in MenuButtonCaolán McNamara1-1/+1
Change-Id: Id1db5f1e30601154801b789a0e0d1fd186c09758 Reviewed-on: https://gerrit.libreoffice.org/74157 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>