summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2018-10-22Version 6.2.0.0.alpha1, tag libreoffice-6.2.0.0.alpha1libreoffice-6.2.0.0.alpha1Christian Lohmaier3-0/+0
Change-Id: I8c2cb5f1ae8296a3a56a4eabf320e8390a92a67b
2018-10-22bump product version to 6.2.0.0.alpha1Christian Lohmaier1-1/+1
Change-Id: I230a969bd89838aa476ed6e1b1d216d6649281af
2018-10-22add Lower Serbian (dsb) language packChristian Lohmaier3-0/+8
Change-Id: Ibafa81b412036e98fa9ab047fc8e204660eae120
2018-10-22Update git submodulesChristian Lohmaier1-0/+0
* Update translations from branch 'master' - update translations for 6.2.0 alpha1 also add Lower Sorbian and force-fix errors using pocheck Change-Id: I616de90d5159504de836211412a2266296b2f624
2018-10-22elementary: Finalize chart graphics, separate dbtable & regulaaaaaaaaaaaaar ↵Rizal Muttaqin432-2752/+341
table, etc Change-Id: Ib3c5a5a09eff26acabf64e4cbc2e7019ca3264e7 Reviewed-on: https://gerrit.libreoffice.org/62142 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-22tdf#120703 (PVS): too complex condition; wrong conditionMike Kaganski1-2/+2
V728 An excessive check can be simplified. The '(A && !B) || (!A && B)' expression is equivalent to the 'bool(A) != bool(B)' expression. V668 There is no sense in testing the 'pCTLOptions' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. The latter is apparently error in our condition, since the || turned it into unconditional execution, but _xISC must be a valid reference inside the block, since it's dereferenced there in all code paths. Change-Id: I7fbbb1c4b54503db50e8eabd2666cbcd05758103 Reviewed-on: https://gerrit.libreoffice.org/62153 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-21tdf#120703 (PVS): redundant nullptr checkMike Kaganski1-8/+5
V668 There is no sense in testing the 'hdo' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. Change-Id: Ic889dcba4e9d77a6dd27dd1603ed37d39e9fe581 Reviewed-on: https://gerrit.libreoffice.org/62152 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-21tdf#120703 (PVS): redundant nullptr checksMike Kaganski1-15/+11
V668 There is no sense in testing the 'pClipDoc' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. V560 A part of conditional expression is always true: pDoc. V560 A part of conditional expression is always true: pMergeFlagAttr. V560 A part of conditional expression is always true: pMergeFlag. Change-Id: Ief75a140cca58fe458dc3c1fd18a9bbaa1ea39cb Reviewed-on: https://gerrit.libreoffice.org/62143 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-21tdf#120703 (PVS): redundant nullptr checkMike Kaganski1-3/+1
V668 There is no sense in testing the 'pBackgroundPropertiesPtr' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. Change-Id: I728ffa74ec5e1f1f428224c79bd17c53b3ad3829 Reviewed-on: https://gerrit.libreoffice.org/62150 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-21tdf#120703 (PVS): missing nullptr check; redundant nullptr checkMike Kaganski1-54/+54
V1004 The 'pDocShell' pointer was used unsafely after it was verified against nullptr. Check lines: 258, 561. V668 There is no sense in testing the 'pFrameView' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. Change-Id: I768d3f56dbd5edd070da9d989ab2d85c4b8e868f Reviewed-on: https://gerrit.libreoffice.org/62149 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-21tdf#120703 (PVS): redundant nullptr checkMike Kaganski1-1/+1
V668 There is no sense in testing the 'pPor' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. Change-Id: I58d553fc59606f54013246f23a1b18a4ab673aac Reviewed-on: https://gerrit.libreoffice.org/62148 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-21pvs-studio: V590 The expression is excessive or contains a misprintCaolán McNamara1-4/+10
Change-Id: Ibe61e593b7f0fb3abc033132450ce620ee3294c9 Reviewed-on: https://gerrit.libreoffice.org/62136 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21pvs-studio: Expression 'condition == MQueryExpression::AND' is always true.Caolán McNamara1-3/+2
Change-Id: Ib3c5a5a09eff26acabf64e4cbc2e7019ca3264e6 Reviewed-on: https://gerrit.libreoffice.org/62098 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21pvs-studio: initialize maLockedRectCaolán McNamara1-6/+8
Change-Id: If95854af5072c9e693bec4011cdcd6c041dffdf3 Reviewed-on: https://gerrit.libreoffice.org/62094 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21tdf#120703 (PVS): redundant nullptr check; loop index sizeMike Kaganski1-7/+4
V668 There is no sense in testing the 's' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. V1029 Numeric Truncation Error. Result of the 'size' function is written to the 16-bit variable. Change-Id: I8e0598e892ca160ac074bccfed87c14367a3b46a Reviewed-on: https://gerrit.libreoffice.org/62139 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-21tdf#120703 (PVS): redundant nullptr check; unsafe pointer dereferenceMike Kaganski1-5/+8
V668 There is no sense in testing the 'mpTheme' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. V1004 The 'mpFont' pointer was used unsafely after it was verified against nullptr. Check lines: 879, 881. Change-Id: I47627de2cd98d3bb36e1ced7346ebe9177c21e65 Reviewed-on: https://gerrit.libreoffice.org/62141 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-21queryComplete is always trueCaolán McNamara3-33/+3
Change-Id: I455fc328a0b9aa3af3e37e9a9fa86ecba97dc5a4 Reviewed-on: https://gerrit.libreoffice.org/62099 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21pvs-studio: V501 same expression twiceCaolán McNamara1-1/+0
Change-Id: I3a2585c605ba9cb83f47fafc93653b36ab4104fc Reviewed-on: https://gerrit.libreoffice.org/62135 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21tdf#120703 (PVS): redundant nullptr checkMike Kaganski1-5/+0
V668 There is no sense in testing the 'pEffect' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. Change-Id: I979915efb406d3173e03b4f47883e01fe0ca5d2d Reviewed-on: https://gerrit.libreoffice.org/62140 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21pvs-studio: Expression 'pException' is always false.Caolán McNamara1-3/+3
Change-Id: Id81e01bd8a082e6bb4eda2f9e8bae1818389941f Reviewed-on: https://gerrit.libreoffice.org/62102 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21tdf#120703 (PVS): redundant nullptr checkMike Kaganski1-1/+1
V668 There is no sense in testing the 'pDest' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. Change-Id: I17773f92ed73359e925ad779d171ec99727f7905 Reviewed-on: https://gerrit.libreoffice.org/62133 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-21pvs-studio: V557 Array overrun is possibleCaolán McNamara1-1/+1
Change-Id: Ia4a7c857b3c94490364ed979ba2fcb9e192e3796 Reviewed-on: https://gerrit.libreoffice.org/62111 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21pvs-studio: Expression '_par0 > 0' is always true.Caolán McNamara1-6/+3
Change-Id: I61e49c665d84e34748ae9e5974edb7ee2785e044 Reviewed-on: https://gerrit.libreoffice.org/62100 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21pvs-studio: A part of conditional expression is always trueCaolán McNamara1-1/+1
Change-Id: I57e3feeedf6a235c576bfc2ed3a4bd98eb86a5c4 Reviewed-on: https://gerrit.libreoffice.org/62109 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21pvs-studio: condition always falseCaolán McNamara1-2/+1
Change-Id: I7dcb927028c89f06545fe92c75cb5660767a4817 Reviewed-on: https://gerrit.libreoffice.org/62106 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21aUS is always emptyCaolán McNamara1-19/+3
Change-Id: I77ae732ea4bcaf0e76acb71fd8886af6b36d8284 Reviewed-on: https://gerrit.libreoffice.org/62101 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21pvs-studio: reference becomes invalid when temporary object destroyedCaolán McNamara1-5/+5
Change-Id: Ibe39738e1a607e3bca273fc03f0f3232024254bc Reviewed-on: https://gerrit.libreoffice.org/62093 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21pvs-studio: A part of conditional expression is always true: !pIStmCaolán McNamara1-2/+3
Change-Id: I32af1d0041cebdb195e6433a0b44fa6ea271275c Reviewed-on: https://gerrit.libreoffice.org/62105 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21pvs-studio: Not all members of a class are initialized inside the constructorCaolán McNamara2-0/+7
Change-Id: I914c715c96a6701995212fdb76615a19c984a128 Reviewed-on: https://gerrit.libreoffice.org/62113 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21tdf#120703 (PVS): redundant nullptr checkMike Kaganski1-2/+1
V668 There is no sense in testing the 'pResult' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. Change-Id: I8c80df7100e6cdf6c3c51957e3bef3c8a9f30732 Reviewed-on: https://gerrit.libreoffice.org/62137 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-21tdf#120703 (PVS): Recurring check.Xisco Fauli1-6/+3
V571 This condition was already verified in line 224. Change-Id: I75a29c49c82c78d3afd1c900743b42af93817f84 Reviewed-on: https://gerrit.libreoffice.org/62046 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21tdf#120703 (PVS): Recurring check.Xisco Fauli1-2/+1
V571 The 'if (IsTabFrame())' condition was already verified in line 2879. Change-Id: I738d818207d7303bc914b140c73feeb182194b27 Reviewed-on: https://gerrit.libreoffice.org/62047 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21tdf#120703 (PVS): Recurring check.Xisco Fauli1-1/+1
V571 Recurring check. The 'mbBufferingAllowed' condition was already verified in line 177. Change-Id: Iea4c5a64e96ea3f513ce5a63fa3fc1f5062cb7cb Reviewed-on: https://gerrit.libreoffice.org/62072 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21pvs-studio: silence bogus V557Caolán McNamara1-14/+20
Change-Id: I5aa740afa1143adaf4e2afa5d5e1596497de8323 Reviewed-on: https://gerrit.libreoffice.org/62112 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21GetBulletOverride never returns nullptrCaolán McNamara2-19/+12
Change-Id: I9becc9397a93369cd46922b66b45990e9e6a51f1 Reviewed-on: https://gerrit.libreoffice.org/62108 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21pvs-studio: Potentially uninitialized pointer 'ret_type' used.Caolán McNamara1-1/+1
Change-Id: I2f6faf1264a62012724d9fe34352a76ea5491717 Reviewed-on: https://gerrit.libreoffice.org/62096 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21pvs-studio: _pView was already dereferencedCaolán McNamara1-2/+2
Change-Id: I72511a46524d02007c7b8e8b0e6486d62cbc7fa0 Reviewed-on: https://gerrit.libreoffice.org/62103 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21pvs-studio: silence bogus V656Caolán McNamara1-3/+4
Change-Id: Ib54677e4172b8d2b789cf49ab964fbcc112869f8 Reviewed-on: https://gerrit.libreoffice.org/62110 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21NB tabbed writer: finishing correct padding and final tab reviewandreas kainz1-244/+370
Change-Id: Ibcc0638176ed2f7b749cea06a00ed709c21aab33 Reviewed-on: https://gerrit.libreoffice.org/62134 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-21pvs-studio: The condition 'nIndex != - 1' of loop is always trueCaolán McNamara1-1/+1
Change-Id: I5b74d8ac2701adbd63816360812687201f645c39 Reviewed-on: https://gerrit.libreoffice.org/62097 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21clarify this code a bitCaolán McNamara3-8/+13
Change-Id: I44066ad4f2e2374e87771de89bdefdbccc816302 Reviewed-on: https://gerrit.libreoffice.org/62095 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21Update git submodulesAndras Timar1-0/+0
* Update translations from branch 'master' - Updated Slovenian translation Change-Id: If92bf4315d62bbd31c9c42c40f0673b240c1853b
2018-10-21tdf#120703 (PVS): redundant nullptr checkMike Kaganski1-1/+1
V668 There is no sense in testing the 'pCGM' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. Change-Id: Ib07d1ceaf01f657e67572c0f5bcd6aae497d2d07 Reviewed-on: https://gerrit.libreoffice.org/62132 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-21tdf#120703 (PVS): redundant nullptr checkMike Kaganski1-6/+0
V668 There is no sense in testing the 'aNewSdrGrafObj' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. Change-Id: I78159c7bd19bacea7120abc8015b866e6179c719 Reviewed-on: https://gerrit.libreoffice.org/62128 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-21tdf#120703 (PVS): redundant nullptr checkMike Kaganski1-2/+1
V668 There is no sense in testing the 'm_spNumberFormatterWrapper' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. Change-Id: Id9e89bfcb412c6034ac3c06f67236a77d335c9fc Reviewed-on: https://gerrit.libreoffice.org/62127 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-21tdf#120703 (PVS)Mike Kaganski1-21/+22
V668 There is no sense in testing the 'pBuf' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. V547 Expression 'ePageKind == PPT_NOTEPAGE' is always true. V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 3724, 3727. V1023 A pointer without owner is added to the 'aCharPropList' container by the 'emplace_back' method. A memory leak will occur in case of an exception. Change-Id: I5edae28a6ca1023a512fd5f86208951d439db941 Reviewed-on: https://gerrit.libreoffice.org/62131 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-21pvs-studio: A part of conditional expression is always true: bDisplayOKCaolán McNamara1-1/+1
Change-Id: If01f2d3b02219194cbeaeffbb0fd8242320432a8 Reviewed-on: https://gerrit.libreoffice.org/62056 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21pvs-studio: Expression 'mnInterlaced == 0' is always true.Caolán McNamara1-4/+1
Change-Id: Ie7f62b8eabf12010aa8f1ab03ca2f65d9c6856ed Reviewed-on: https://gerrit.libreoffice.org/62069 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21coverity#1440400 Resource leak in objectCaolán McNamara2-3/+3
Change-Id: I96aea5e6004e8074630bdeeb7cbe4d16a46d5648 Reviewed-on: https://gerrit.libreoffice.org/62087 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21Copy gpgme-w32spawn.exe to workdir/LinkTarget/ExecutableMike Kaganski1-0/+3
... to avoid "GpgME not installed correctly" message boxes during unit tests. See the mail list thread started with https://lists.freedesktop.org/archives/libreoffice/2018-October/081209.html Change-Id: Ie57e6b5a7281d8f20ba97912f3413eafaac9cfd4 Reviewed-on: https://gerrit.libreoffice.org/61903 Tested-by: Jenkins Tested-by: Jan-Marek Glogowski <glogow@fbihome.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-18 23:41:24 +0000