AgeCommit message (Collapse)AuthorFilesLines
2018-05-31Version, tag libreoffice- Lohmaier3-0/+0
Change-Id: Id9bbd29c9ef9c85b65c96b32cfb49efdd51c5034
2018-05-31bump product version to Lohmaier1-1/+1
Change-Id: I5607c84c0534954ac1ae6adc30eaf2f3c2598894
2018-05-31Branch libreoffice-6-0-5Christian Lohmaier4-1/+1
This is 'libreoffice-6-0-5' - the stable branch for the 6.0.5 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 6.0.x release, please use the 'libreoffice-6-0' branch. If you want to build something cool, unstable, and risky, use master. Change-Id: I53c242726ee31d2755f7abffaef772a831a1c945
2018-05-31tdf#38225: update API name when renaming using a base class refMike Kaganski3-49/+114
... but don't update it in case it's a predefined API name Change-Id: I20075a4e085bdeab8374860c16e7eb2a72772c33 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Mike Kaganski <> Reviewed-on: Reviewed-by: Christian Lohmaier <>
2018-05-31tdf#117864 TransferableHelper::GetSystemClipboard requires a focus windowCaolán McNamara2-1/+6
Change-Id: Ibd9b9218cf12e80db1fc9a70bdbab38d3df950f7 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Christian Lohmaier <>
2018-05-30tdf#111988 Bump OSX version in READMEXisco Fauli1-1/+1
Change-Id: I41a5be165af21c197c4f9d4f40f0ff27c80a7168 Reviewed-on: Reviewed-by: Sophia Schröder <> Tested-by: Jenkins <> Reviewed-by: Tor Lillqvist <> (cherry picked from commit 272577e68abe764ab05fe227e3cd7d185c59a900) Reviewed-on: Reviewed-by: Adolfo Jayme Barrientos <> Tested-by: Adolfo Jayme Barrientos <>
2018-05-30Resolves: tdf#117819 append trailing '0' as needed before separator insertionEike Rathke2-6/+26
To insert separators, literal strings between digits and other, the formatter operates backwards on the string obtained from doubleToUString() cleaned of the decimal separator. The number of decimals returned by doubleToUString() may be less than the decimals of the number format as entered by the user, which lead to separators inserted at wrong positions. This wrong behavior was triggered respectively made more obvious by commit 0f6203edf74832f84d8263d7a544d679203a4efc CommitDate: Wed Jan 13 14:47:57 2016 +0100 tdf#96918 display accurate integer double values up to (2^53)-1 which for integer values returns at most 15 decimals ('0' in this case). Before operating on the decimals' part ensure that the number of decimals matches the digits requested, and if shorter append trailing '0' characters for the required amount so the separators (and other strings) are inserted at the correct positions. Change-Id: Ic02652699ea7d6fae3b2b3348f6f7d183319e043 Reviewed-on: Reviewed-by: Eike Rathke <> Tested-by: Eike Rathke <> (cherry picked from commit 8b43f58891d4b422a8934050d839b0c2c1e3a18a) Reviewed-on: Tested-by: Jenkins <>
2018-05-30tdf#116420: Windows: Test if a filepath redirects to a WebDAV resourceMike Kaganski4-1/+114
In Windows, filesystem redirectors can map WebDAV resources to UNC paths, or to drive-based "local" paths; so a WebDAV URI of the form "http://WebDADServer/root/directory/File.ext" may be accessed using "\\WebDADServer\root\directory\File.ext" or "Z:\directory\File.ext". When using these paths, failure to create a lockfile aside the opened document should not be considered an error; so this patch checks for this. Regression from commit 6ca3b3648e25ae9d4d2d29a0df83349198ec3f5e. Change-Id: I1de55b66447dc91d22b6d2b5b121de96bf32e4ee Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Stephan Bergmann <> (cherry picked from commit 642a49e8d3006d000bc6c58def34d4e96764c6cc) Reviewed-on: Reviewed-by: Mike Kaganski <> Reviewed-by: Christian Lohmaier <>
2018-05-30Updated coreChristian Lohmaier1-0/+0
Project: translations 302381e4b2c30c3ed9d6194205a67f8dbd8da48b update translations for 6.0.5 rc1 Change-Id: If737c9f1a251608a0413d63a6309be1a5f5a371a
2018-05-29Updated coreKruno1-0/+0
Project: dictionaries 7da396b70265569b851a1c2327e7dcf757e3f936 Update Croatian dictionary to version 2.1.1 Change-Id: I8425ab128d04d428ccc99cb6c8abe2635292f143 Reviewed-on: Reviewed-by: Christian Lohmaier <> Tested-by: Christian Lohmaier <>
2018-05-29forcepoint#43 endless update ole2 preview recursionCaolán McNamara1-1/+11
Change-Id: I7a6a52d2ea63f840a8a1800fdf7039b1e7b24cdc Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Christian Lohmaier <>
2018-05-29tdf#117850: Just call _Exit() in our applicationWillTerminate:Tor Lillqvist1-0/+3
Sure, it is just a workaround, but a very effective workaround. Change-Id: Id0daff048a27dae5cf8fb5e0e949c5b21e03fc86 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Tor Lillqvist <> (cherry picked from commit aa81a086bd3dcd7d6b830951619f310bd0aff30c) Reviewed-on: Reviewed-by: Christian Lohmaier <>
2018-05-29tdf#113143 PDF export: fix mis-scaled JPGs on Impress note pagesMiklos Vajna3-65/+114
This is really similar to commit 4c2172a3e973bc6351107a3a1b554c77b40b75dd (tdf#106702 PDF export: fix missing images from Writer headers/footers, 2018-05-22) just this one is about the size of the output rectangle for JPG content, while the previous problem was about the position of them. Also extract PdfExportTest::exportAndParse() from the last two tests to avoid duplication. (cherry picked from commit 89dc667cebfec5315f0c0361e49d759e88458689) Change-Id: I9812924d505e9fdaca2a95b4990e7aaa5e44fd7f Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Christian Lohmaier <>
2018-05-29forcepoint#42 check available str lengthCaolán McNamara1-1/+1
Change-Id: Ie476968ddaa4c3e5475ae9aa6133e7aba38d5975 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Christian Lohmaier <>
2018-05-29forcepoint#41 null derefCaolán McNamara1-4/+7
Change-Id: I16e9e083811c6e14861da1ba1df7d46e8c8771d7 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Christian Lohmaier <>
2018-05-29forcepoint#40 null derefCaolán McNamara2-4/+4
presumably since commit 0098bee792c3e208ea4f6ef1c676958d3f4cd207 Date: Thu Sep 21 06:48:09 2017 +0200 tdf#112501: Pivot table: popupbuttons are placed on wrong cells Change-Id: I5413c0ba06fca25cb22256a20ef9640767dd9e50 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Christian Lohmaier <>
2018-05-29tdf#117628 crash after closing media player with X11 backendCaolán McNamara2-7/+6
Change-Id: I812da5ddf7343573f93ea64e592442edb31cad2d Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Christian Lohmaier <>
2018-05-29tdf#115582 Correct coordinate usage for sc's ::ArrayArmin Le Grand1-6/+15
In ScOutputData::SetCellRotations() eventually existing CellRotations are added to the svx::frame::Array data that gets created for repaint. This used the wrong coordinate calculation, thus in some cases the repaint of rotated Cells failed. Change-Id: Ib5df8576e8c9404d717d5dcc5662aa04b82cf959 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Armin Le Grand <> (cherry picked from commit 0185e65bcd73dbad2205a39369e1e06b33a2ca51) Reviewed-on:
2018-05-29tdf#117172 - Image context menu Save fails to do anythingMarco Cecchetti1-0/+7
Change-Id: I5c0980d85ef5ed050bfafbc368576c5ad72a80a7 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Miklos Vajna <> (cherry picked from commit 796bee47e90efee7c076f6acdc2a95004ed081d0) Reviewed-on: Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-05-28Updated coreLászló Németh1-0/+0
Project: dictionaries 37c3e3924d33f29dbff7fb3dba40b36a694c6792 Hungarian dictionary v1.7 Extend Hungarian dictionary with boundary data for compound words and for disambiguation of digraphs to fix incomplete and bad Hungarian collate, sorting and hyphenation rules in the future. Other minor fixes (*idegenszó -> idegen szó, *periférikus etc.) (cherry-picked from commit e90e83b23b6ace35349fc2b3e65bd2d69c80ddd8) Reviewed-on: Reviewed-by: László Németh <> Tested-by: László Németh <> Change-Id: I3278801ac875f2d33fd5dc62efc43a9a81194734 Reviewed-on: Reviewed-by: Christian Lohmaier <> Tested-by: Christian Lohmaier <>
2018-05-28tdf#117729 add Frisian (fy) UI langaugeChristian Lohmaier3-0/+8
Change-Id: I46f75e969b1252a95118888507c116f44578dfbd Reviewed-on: Reviewed-by: Christian Lohmaier <> Tested-by: Christian Lohmaier <> (cherry picked from commit f8fb04d0af7b1d21b8638e92922d0965e507c5d9)
2018-05-28Updated coreChristian Lohmaier1-0/+0
Project: translations b1dbd807900728ddd68a7b03ea58a5ce43717f6f add Frisian translation Change-Id: If5b9e5bf1f924e32b8fd0d6bd4c078e8fdb3f26f
2018-05-28tdf#117601 a11y crash after merging cellsCaolán McNamara3-4/+16
this is similar to tdf#87199, in this case the accessibiles for the merged cells are not visible so not removed when their frame is deleted, but remain in the cache pointing to invalid frames. Change-Id: Ibc5b9f27541683b8f3604839fa3d1431380a4039 Reviewed-on: Reviewed-by: Michael Stahl <> Tested-by: Jenkins <>
2018-05-27tdf#104086 cui: enable OpenGL when ignoring its blacklistMiklos Vajna2-0/+10
"Ignore OpenGL blacklist" is called "force OpenGL" in the code, so it make sense that OpenGLHelper::isVCLOpenGLEnabled() returns true in that case. But the UI suggested that enabling ignore doesn't enable OpenGL itself. Fix this by auto-checking the parent UI widget when enabling the blacklist. (cherry picked from commit 8118a5d2eb1524768784adc0b143b8cc1b9f3f61) Conflicts: cui/source/options/optgdlg.cxx Change-Id: I16bec69aebd645858260850f15ea8e687566fd0e Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-05-27tdf#106702 PDF export: fix missing images from Writer headers/footersMiklos Vajna6-24/+96
Position of an image is determined by the relevant bitmap scale metafile action when recompressing images. The same position was determined by PDFExtOutDevData "meta" info when not recompressing images. This second rectangle was never correct for images repeated in Writer headers/footers on non-first pages: the position was relative to the page, while PDF export sets the map mode (origin) of the output device during export, so such positions are expected to be absolute ones. The root of the problem seems to be that header images in Writer are both repeated (as the user sees it) and unrepeated (as the doc model sees it), and by the time we want to get its position, we only see the unrepeated SdrObject. Fix the problem by using the correct position from the scale action and not from PDFExtOutDevData if possible. (Also give up on running CppunitTest_vcl_pdfexport in the non-pdfium case, most of the tests there do require pdfium anyway, and the growing ifdef forest in that file just made it hard to read the code.) (cherry picked from commit 4c2172a3e973bc6351107a3a1b554c77b40b75dd) Conflicts: vcl/ vcl/qa/cppunit/pdfexport/pdfexport.cxx Change-Id: I31c14d4bd223b2804859982542ebd6d5f9abd312 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-05-27tdf#117505 RTF export: fix incorrect header distance for first/follow pagesMiklos Vajna5-1/+26
In case the first and the follow page format has different header distances, the DOC and DOCX import work with the distance from the first page format when they take the last item from the MSWordSections container at the end of the export. RTF writes section info before the document content, and in case there are separate first and follow page formats, then we work with the follow format since commit 20a53cb9e9c7b797c091fe6ac6a34dfb28c61304 (INTEGRATION: CWS limerickfilterteam08 (1.16.32); FILE MERGED, 2003-09-01) as a fix for i#13107. There is no perfect solution here, the sw doc model can store different header distances for first and follow pages, while Word works with a single distance. But RTF/DOCX/DOC import puts the relevant header distance to the first page format and DOCX/DOC export reads the distance from there, so be consistent and do the same in the RTF export as well. This means the DOCX import -> RTF export -> RTF import sequence from the bugreport will result in a correct header distance. (cherry picked from commit 5956828c88501ef1366e60010b05053a8e1e642e) Change-Id: I3f1fe3080360702c41d680b8785cc3602e74685e Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-05-27tdf#117821: fix copy-paste wrong control typeJulien Nabet1-1/+1
Since 5ad8376d1698026ccab0634605fdb17ea3c59f3a Resolves: tdf#111080 framework user of convert menu needs action names set 2017-08-08 Change-Id: I2ec8358005e335941bd1c2530f30ce696d3e808f Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Julien Nabet <> (cherry picked from commit 1e9e01dff0a8d65bb10d5a886cca7899b43979da) Reviewed-on: Reviewed-by: Adolfo Jayme Barrientos <> Tested-by: Adolfo Jayme Barrientos <>
2018-05-25fix variable nameDavid Tardon1-1/+1
Change-Id: Ie3eef59c934f5fe4146a911e4ee652457b94edd8 (cherry picked from commit 8978fdf58a403aa62e04d47e65cd799740e6b909) Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Stephan Bergmann <>
2018-05-24external/python3: Drop nis.cpython-*m.soStephan Bergmann1-1/+0
At least Fedora 28 glibc-2.27-8.fc28 no longer provides the nis development headers and libraries. (It only still contains some binaries for backwards compatibility, in the libnsl sub-package: "This package provides the legacy version of libnsl library, for accessing NIS services.") There is probably no real need to have nis.cpython-* contained in external/python3/ (it probably just happened to build fine when that list was originally created, so was included). Change-Id: Ic6128fd872432005c0ded76640c5b56781ca69a1 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Stephan Bergmann <> (cherry picked from commit 93e6a823bd8543d30621769c7b34d6261ea5cb01) Reviewed-on: Reviewed-by: Tor Lillqvist <> Reviewed-by: Miklos Vajna <>
2018-05-24apparmor: allow also /usr/lib{,32,64}/jvm/**/bin/javaRene Engelhard1-0/+1
since /usr/lib{,32,64}/jvm/**/jre/bin/java doesn't exist since OpenJDK 9 Change-Id: Ic9c052a756ba4a93595595da98148ff22169d333 Reviewed-on: Reviewed-by: Rene Engelhard <> Tested-by: Rene Engelhard <>
2018-05-23deb#899380 apparmor: fix gpg encryption hang trying to lock random_seedRene Engelhard1-0/+1
Change-Id: Ib9fb7652922dcc8364567953d17d7cae8ad170a7 Reviewed-on: Reviewed-by: Rene Engelhard <> Tested-by: Rene Engelhard <> (cherry picked from commit 8615efe611abe8654e643e1ccbc0dc8f52d2e0b0) Reviewed-on:
2018-05-23Open template read-onlyTor Lillqvist1-1/+3
Otherwise when creating a new docuent based on a template, the template document file is opened read-write eventually (after first being opened read-only five times, and closed again...). Sure, LibreOffice probably doesn't actually write anything to it, but still, just opening read-write when you are going to only read is silly. Stack trace from the read-write opening: #0 0x00007f063dea0047 in openFilePath(char const*, void**, unsigned int, unsigned int) (cpFilePath=0x7ffeacc7d610 "/ssd1/lo/fedora/instdir/share/template/common/officorr/", pHandle=0x342af78, uFlags=3, mode=438) at /ssd1/lo/fedora/sal/osl/unx/file.cxx:1039 #1 0x00007f063dea027b in openFile(_rtl_uString*, void**, unsigned int, unsigned int) (ustrFileURL=0x33ff7e0, pHandle=0x342af78, uFlags=3, mode=4294967295) at /ssd1/lo/fedora/sal/osl/unx/file.cxx:1071 #2 0x00007f063dea01a8 in osl_openFile(rtl_uString*, oslFileHandle*, sal_uInt32) (ustrFileURL=0x33ff7e0, pHandle=0x342af78, uFlags=3) at /ssd1/lo/fedora/sal/osl/unx/file.cxx:1050 #3 0x00007f060aec5f1a in osl::File::open(unsigned int) (this=0x342af78, uFlags=3) at /ssd1/lo/fedora/include/osl/file.hxx:975 #4 0x00007f060aec5a8f in fileaccess::ReconnectingFile::open(unsigned int) (this=0x342af78, uFlags=3) at /ssd1/lo/fedora/ucb/source/ucp/file/filrec.cxx:50 #5 0x00007f060aee0324 in fileaccess::XStream_impl::XStream_impl(rtl::OUString const&, bool) (this=0x342af10, aUncPath="file:///ssd1/lo/fedora/instdir/share/template/common/officorr/", bLock=true) at /ssd1/lo/fedora/ucb/source/ucp/file/filstr.cxx:58 #6 0x00007f060aee8bac in fileaccess::TaskManager::open_rw(int, rtl::OUString const&, bool) (this=0x2c5ded0, CommandId=231, aUnqPath="file:///ssd1/lo/fedora/instdir/share/template/common/officorr/", bLock=true) at /ssd1/lo/fedora/ucb/source/ucp/file/filtask.cxx:766 #7 0x00007f060ae9ba9b in fileaccess::BaseContent::open(int, com::sun::star::ucb::OpenCommandArgument2 const&) (this=0x3428810, nMyCommandIdentifier=231, aCommandArgument=...) at /ssd1/lo/fedora/ucb/source/ucp/file/bc.cxx:937 #8 0x00007f060ae99dfa in fileaccess::BaseContent::execute(com::sun::star::ucb::Command const&, int, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) (this=0x3428810, aCommand=..., CommandId=231, Environment=uno::Reference to (ucbhelper::CommandEnvironment *) 0x341d088) at /ssd1/lo/fedora/ucb/source/ucp/file/bc.cxx:331 #9 0x00007f060ae9d001 in non-virtual thunk to fileaccess::BaseContent::execute(com::sun::star::ucb::Command const&, int, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) () at /ssd1/lo/fedora/instdir/program/../program/ #10 0x00007f06337395da in ucbhelper::Content_Impl::executeCommand(com::sun::star::ucb::Command const&) (this=0x3427f70, rCommand=...) at /ssd1/lo/fedora/ucbhelper/source/client/content.cxx:1258 #11 0x00007f063373be55 in ucbhelper::Content::openWriteableStream() (this=0x7ffeacc7f030) at /ssd1/lo/fedora/ucbhelper/source/client/content.cxx:751 #12 0x00007f06333f56c0 in utl::MediaDescriptor::impl_openStreamWithURL(rtl::OUString const&, bool) (this=0x7ffeacc801d0, sURL="file:///ssd1/lo/fedora/instdir/share/template/common/officorr/", bLockFile=true) at /ssd1/lo/fedora/unotools/source/misc/mediadescriptor.cxx:666 #13 0x00007f06333f3e01 in utl::MediaDescriptor::impl_addInputStream(bool) (this=0x7ffeacc801d0, bLockFile=true) at /ssd1/lo/fedora/unotools/source/misc/mediadescriptor.cxx:521 #14 0x00007f06333f4051 in utl::MediaDescriptor::addInputStreamOwnLock() (this=0x7ffeacc801d0) at /ssd1/lo/fedora/unotools/source/misc/mediadescriptor.cxx:490 #15 0x00007f05b132f0bf in filter::config::TypeDetection::impl_openStream(utl::MediaDescriptor&) (this=0x33caa10, rDescriptor=...) at /ssd1/lo/fedora/filter/source/config/cache/typedetection.cxx:1127 #16 0x00007f05b132e9ac in filter::config::TypeDetection::impl_askDetectService(rtl::OUString const&, utl::MediaDescriptor&) (this=0x33caa10, sDetectService="", rDescriptor=...) at /ssd1/lo/fedora/filter/source/config/cache/typedetection.cxx:981 #17 0x00007f05b132b7a4 in filter::config::TypeDetection::impl_detectTypeFlatAndDeep(utl::MediaDescriptor&, std::__debug::vector<filter::config::FlatDetectionInfo, std::allocator<filter::config::FlatDetectionInfo> > const&, bool, std::__debug::vector<rtl::OUString, std::allocator<rtl::OUString> >&, rtl::OUString&) (this=0x33caa10, rDescriptor=..., lFlatTypes=std::__debug::vector of length 168, capacity 256 = {...}, bAllowDeep=true, rUsedDetectors=std::__debug::vector of length 1, capacity 1 = {...}, rLastChance="") at /ssd1/lo/fedora/filter/source/config/cache/typedetection.cxx:934 #18 0x00007f05b1329b7c in filter::config::TypeDetection::queryTypeByDescriptor(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&, unsigned char) (this=0x33caa10, lDescriptor=uno::Sequence of length 6 = {...}, bAllowDeep=1 '\001') at /ssd1/lo/fedora/filter/source/config/cache/typedetection.cxx:429 #19 0x00007f05b132d321 in non-virtual thunk to filter::config::TypeDetection::queryTypeByDescriptor(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&, unsigned char) () at /usr/bin/../lib/gcc/x86_64-redhat-linux/8/../../../../include/c++/8/bits/stl_pair.h:331 #20 0x00007f060df5acdd in framework::LoadEnv::impl_detectTypeAndFilter() (this=0x7ffeacc80c48) at /ssd1/lo/fedora/framework/source/loadenv/loadenv.cxx:739 #21 0x00007f060df58796 in framework::LoadEnv::startLoading() (this=0x7ffeacc80c48) at /ssd1/lo/fedora/framework/source/loadenv/loadenv.cxx:357 #22 0x00007f060df57280 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (xLoader=uno::Reference to (framework::Desktop *) 0x282bf98, xContext=uno::Reference to (cppu::ComponentContext *) 0x145b790, sURL="file:///ssd1/lo/fedora/instdir/share/template/common/officorr/", sTarget="_default", nFlags=0, lArgs=uno::Sequence of length 4 = {...}) at /ssd1/lo/fedora/framework/source/loadenv/loadenv.cxx:160 #23 0x00007f060dfaef40 in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x282bf20, sURL="file:///ssd1/lo/fedora/instdir/share/template/common/officorr/", sTargetFrameName="_default", nSearchFlags=0, lArguments=uno::Sequence of length 4 = {...}) at /ssd1/lo/fedora/framework/source/services/desktop.cxx:617 #24 0x00007f060dfaeffb in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) () at /ssd1/lo/fedora/include/rtl/stringutils.hxx:170 #25 0x00007f06381ee762 in SfxTemplateManagerDlg::OpenTemplateHdl(ThumbnailViewItem*) (this=0x310e160, pItem=0x33925d0) at /ssd1/lo/fedora/sfx2/source/doc/templatedlg.cxx:690 Change-Id: Iaa5cc2bd4c80bc239b8f1bf7ed8aa62d89151d62 (cherry picked from commit e439816281f9fe24c7332b5f1e16df845f5213f2) Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Stephan Bergmann <>
2018-05-23tdf#104893 vcl opengl: fix assert failure when starting chart editingMiklos Vajna1-2/+13
OpenGLContext::prepareForYield() assumed that in case we have a current context, then it's the last one, but that's not the case for chart windows since commit 78b100ec9cb0db2f7b33ece5ad3287a67a37246f (only init the OpenGL context if we need it, 2016-06-07), which creates an OpenGLContext instance (which is then the last one in the context list) but explicitly doesn't initialize it (so that it would become the current one). Fix the problem by resetting not the last but the last current context. (cherry picked from commit 2a6171ed6fb85b3419dcf5cf1346cf1eec447987) Change-Id: Ie0e96927473290590cd6333e5cdcb7daa009431b Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Bartosz Kosiorek <>
2018-05-22tdf#104658: Fix jumping bitmap-filled chart barsKatarina Behrens1-1/+6
Coincidentally this also resolves almost identical issues in chart wall (tdf#114132) Change-Id: Ib566110639d00aa46463ee592861ce3e15c64f50 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Katarina Behrens <> (cherry picked from commit 2eaa978d135a53abf22df2dc3fcb8d04733fe2d3) Reviewed-on: Reviewed-by: Miklos Vajna <>
2018-05-20crashtesting: assert on fdo62508-1.odtCaolán McNamara3-5/+13
document, with meta:generator of "opxml2odf - Version KO 0.1" has a styles.xml xmlns of... xmlns:ofo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0" instead of the usual xmlns:fo=... use the importer namespace map to get the importers namespace prefix for the fastparser namespace uri for the token Change-Id: Ib633009f6c2b7dae5a3ceb1c921adfff84e21150 Reviewed-on: Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <> Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Michael Stahl <>
2018-05-19explicitly enable avahiChristian Lohmaier1-0/+1
Change-Id: I8d3c639bfeb6797a5d61ea21e55ac23da1504120 (cherry picked from commit c488328fd27a883e730d1eda47c4a4d2c07f3585)
2018-05-18tdf#116511: Drop questionable check for more keyboard inputTor Lillqvist1-23/+15
For some reason, on macOS, when this is being invoked through the shortcut, Application::AnyInput( VclInputFlags::KEYBOARD ) returns true, so the code thinks that there is more keyboard input and won't call UpdateTokenArray(), which sets m_pTokenArray. I think that optmisation is questionable, especially as the exact semantics of our event loop API, like Application::AnyInput(), is under-defined and probably can and will change in various minor ways when people work on improving it on the Mac (and perhaps other platforms, too). (The event loop etc certainly needs improvement on the Mac. Consider the "WindowServer grows to tens of gigabytes when running make check" issue which is closely related. Unfortunately nobody has come up with a simple fix for that yet, exactly because we use our event loop related APIs in so imaginative ways all over the code, and fixing one thing usually breaks another.) Change-Id: I865d46e5ee69609ad58bc915ff949e0f3602d8f5 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Tor Lillqvist <> (cherry picked from commit 16f784b10695d1d3212463f96f597c665a90a8e2) Reviewed-on: Reviewed-by: Eike Rathke <> Tested-by: Eike Rathke <>
2018-05-18tdf#105954 PDF export, ReduceImageResolution: fix re-compressing large imagesMiklos Vajna3-0/+52
Expensive re-compress is not pointless when the user opts in to reduce resolution. (cherry picked from commit 9fd6b6b1f5b83d923a47252b744358721761d9cf) Conflicts: vcl/qa/cppunit/pdfexport/pdfexport.cxx vcl/source/gdi/pdfextoutdevdata.cxx Change-Id: I1e04c6d4f0d95d41808ef885082239645401b2e2 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-05-18Resolves: tdf#117093 sanitize the active grid window valueEike Rathke2-13/+33
Don't know yet how that could had happened, but the sample document has a bad ActiveSplitRange value that doesn't match HorizontalSplitMode and VerticalSplitMode. * sanitize the value when reading view settings * prevent writing such value to help versions that don't sanitize Change-Id: I1b450c7b8102148a24d545ff7568f725d7492a6a (cherry picked from commit 646e9564007b13bd841d28e7c02c060d2f96fb39) Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-05-18curl: upgrade to release 7.60.0Thorsten Behrens2-6/+6
This fixes the following CVEs: * FTP: shutdown response buffer overflow CVE-2018-1000300 * RTSP: bad headers buffer over-read CVE-2018-1000301 Reviewed-on: Reviewed-by: Thorsten Behrens <> Tested-by: Thorsten Behrens <> Conflicts: download.lst Change-Id: Ic3229577083286501162aa5979a94ce934739557 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Miklos Vajna <>
2018-05-18Resolves: tdf#117612 truncate DateAdd("m",...) to last day of monthEike Rathke4-29/+41
... instead of resulting in error because of roll-over not being set. Fallout from commit 6d424f07701bf26d8fb173563b567d5f097c33e2 CommitDate: Tue May 2 23:12:34 2017 +0200 Replace mouth-painted "inaccurate around leap year" rollover algorithm that does stricter checking but DateAdd() needs a lax checking with truncate to last day of month. (cherry picked from commit 40c9a129e5a53e6eadfe8ca80c98ccf7eda957f9) Conflicts: basic/source/runtime/methods.cxx Backported. Change-Id: I9d6f95ad3ac38257d492019bd621070491e98e76 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Miklos Vajna <>
2018-05-18ofz#7322 lcl_MarkEqualByStart sort logic differs from that of operator==Caolán McNamara2-1/+8
when it encounters a SwPosition with a SwIndex nContent whose m_pIndexReg is null and compares to one whose m_pIndexReg is not null, where both have an m_nIndex of 0. operator== considers them different, while lcl_MarkEqualByStart doesn't care and sorts them as equal Change-Id: I29920b98c9e6f395487de1b9cafa6b1282b2b1b6 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Miklos Vajna <>
2018-05-18tdf#117477/tdf#100243: blacklist Intel HD Graphics 630 for Lenovo...Julien Nabet1-0/+6
+ Intel(R) Iris(TM) Graphics 550 from See Change-Id: Ifdd55d5b26ae7ef6d635527050296aa69c2244ab Reviewed-on: Reviewed-by: Noel Grandin <> Tested-by: Jenkins <> Reviewed-by: Julien Nabet <> Reviewed-on: Tested-by: Noel Grandin <>
2018-05-16tdf#117596 set the size for Asian and Complex char height tooTomaž Vajngerl1-0/+2
Change-Id: I703fc4d1cf34747d924a7fa44913a4bfe9bff67b Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Tomaž Vajngerl <> (cherry picked from commit d57c6f5d44ec7a8dff2121bd19103804329af66a) Reviewed-on: Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-05-16Related: tdf#116939 Disable <cols><col> overflow detection due to excess ...Eike Rathke1-4/+6
... custom column widths. It's probably just confusing to users, even if technically correct. Live with truncation of a "layout form" if no content is present. Change-Id: I43d77c3e019badd053cb21d92aacd64c7bbcf0e6 Reviewed-on: Reviewed-by: Eike Rathke <> Tested-by: Jenkins <> (cherry picked from commit f72bd4f02b70e1c4855795b4237e2965556c4689) Reviewed-on: Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-05-16tdf#96947 vcl opengl win: fix background of menu items w/ check/radio marksMiklos Vajna1-13/+38
Extract the actually used bounding box from the rendering code and reuse that for OpenGL texture purposes, so the available and the used size can't mismatch. The background itself is almost invisible, but the borders were lost due to this size difference. (cherry picked from commit b160db926b574b7e9d6696d49dbbce8dd289aade) Change-Id: I31b3e5aa0c0106461b90bfaab3a84d45b33afd71 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-05-16Merge in Flatpak improvementsStephan Bergmann1-1/+1
...from <>: Author: Stephan Bergmann <> Date: Mon May 14 16:51:37 2018 +0200 Find flatpak'ed Java installation via JAVA_HOME ...instead of via PATH, so that a JAVA_HOME inherited from the environment doesn't accidentally select a different Java installation. Fixes <> "undefined symbol: FT_Done_MM_Var". Change-Id: I2b4c3a55c92f0ef5c5925f0a9909b7b061eedeeb Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-05-14Resolves: tdf#117475 page properties change triggers page reorder eventCaolán McNamara2-10/+24
and page reorder remove and re-inserts the slide in the slide sorter, so the selected page property is removed when the page doesn't really get removed. So then there's no selection to apply the later master page property to. Change-Id: I4a32958542da1bf2f5041dde0294a772645e30ad Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Miklos Vajna <>
2018-05-14Resolves: tdf#117413 char doubling appearing under X with gtk3Caolán McNamara2-16/+22
like happened on gtk2, so make the rhbz#1283420 bodge happen for XLIB surfaces, regardless of the backend Change-Id: Ic51679a71523e8cc76832858411b102d915638cf Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Jean-Baptiste Faure <> Reviewed-by: Miklos Vajna <>
2018-05-11Related: ofz#8226 + valgrind: uninitialized valueCaolán McNamara1-2/+2
Change-Id: I63dea876dffe2d9e17b506dbd8515da2d97fbf08 Reviewed-on: Reviewed-by: Michael Stahl <> Tested-by: Jenkins <>