summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2013-10-16fdo#56007 - Read more bytes on Zip read (for thumbnails)cp-4.1-branch-pointMathieu Parent1-26/+38
Change-Id: Ia8c6caa44ed8019a8139beb5a855f0f28805544d Signed-off-by: Andras Timar <andras.timar@collabora.com>
2013-10-16fdo#56007 - fast zip directory find to accelerate Windows Explorer thumbnail.Michael Meeks1-11/+40
Change-Id: Id9436def56f40d2bb54dea35bea916bd99964653 Signed-off-by: Andras Timar <andras.timar@collabora.com>
2013-10-15resolved fdo#70319 exponent must be followed by at least one digitEike Rathke3-1/+21
(cherry picked from commit f20feba4c43c34fd2ee05b4658b0de0248c08eb9) work around crappy SbiScanner::NextSym(), fdo#70319 just to make test not fail that was wrong anyway (cherry picked from commit 472ad8ba7ef99982025b37aba562f2135ca8a999) Change-Id: Icdd22fa0f1efcdd18cfea7cb48e1cbf2cf8d3533 Reviewed-on: https://gerrit.libreoffice.org/6241 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-10-15CID#736943 clamp no of ttc entries to physical maxCaolán McNamara1-0/+33
Change-Id: Ic63defe9c14c6ee2b86bd5b7730a570238ca3981 (cherry picked from commit 225539ab08043b6937fdd67d9ae308ebd4104646) Reviewed-on: https://gerrit.libreoffice.org/6150 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-10-14sw: fix regex search/replace of $ in selectionMichael Stahl1-16/+0
SwView::Replace() nowadays first searches for the to-be-replaced text in the current selection, which does not work in the corner case of "$" when the selection starts at end of a paragraph, as it will when clicking "Find" to look for "$" and then clicking "Replace". The problem is that there is some antique code in SwPaM::Find() to move the cursor forward if it's at the end of a paragraph, which is presumably some pointless micro-optimization; the result is that "Replace" does not replace the selected paragraph break but the one in the following paragraph. (regression from 68a014dbca8bbd25056f75ef551fb81a0dbfb1b7) Conflicts: sw/source/core/crsr/findtxt.cxx (cherry picked from commit b60ce8465c8f01242354abccebe00742d164af60) Change-Id: I5aae9c272d102a48166c63e01775dc6322f9f02d Reviewed-on: https://gerrit.libreoffice.org/6230 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2013-10-14fdo#64495: sw: fix regex search for soft hyphen \xADMichael Stahl1-2/+7
The problem is that the soft hyphen apparently needs special handling, and SwPaM::DoSearch() looked for the no longer supported legacy syntax, not for any of the unicode character syntax that ICU regex supports. Change-Id: I754296d2cf9286242e083cc7906ce3b8fda78dd5 (cherry picked from commit dca5163b6ef206ceb1f2d56feb7546c1929afe60) Reviewed-on: https://gerrit.libreoffice.org/6229 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2013-10-14fdo#67796: sw: fix table cursor when setting language in status barMichael Stahl1-5/+11
Unfortunately it turns out that the neat hack in commit b227a8e4d65e4bbfe991aed9342fe3e30eca8639 does not work unless something actually _deletes_ the current m_pTblCrsr between Push() and Pop(), e.g. by calling SwCrsrShell::ClearMark() or KillPams(). It would be possible to do some invalidation of m_pTblCrsr in SwCrsrShell::ClearUpCrsrs() or UpdateCrsr(), to set it's bChg flag or perhaps call ParkTblCrsr(); not sure if doing that is an improvement; certainly it shouldn't be tried in a 4.0.6 backport. So work around the problem locally in SwTextShell::Execute(). Conflicts: sw/source/ui/shells/textsh1.cxx (cherry picked from commit 9533e01713c0170bdae030429de38756d9c5ca74) Change-Id: I2981506b3065e824532deda28d21dad4a5734a8c Reviewed-on: https://gerrit.libreoffice.org/6212 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2013-10-13fixed another "Out of bounds substring access"Eike Rathke1-6/+5
Introduced with 3c2a26c84e70fd996855181d319970e2230b2459 Didn't have consequences here because the result was used to check for a "startsWith" condition which it wouldn't had matched anyway. However, use the real startsWith() now. (cherry picked from commit b1caf176a44b6979d2e0ea47f495a3dacf86e197) With f81ed484ffd443e2593627f3d8d3133161817af2 in 4-1 we should have this as well. Change-Id: Ia1d558fc106d9a2010ad41c30f7eb2a2a480c59b Reviewed-on: https://gerrit.libreoffice.org/6218 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-10-11Resolves: rhbz#996162 apparent NULL bullet fontCaolán McNamara1-1/+7
Change-Id: I2f50ef1dabe2f152f2e18025edc88734158dbea2 (cherry picked from commit 166510ed48bf49b75a031ce973f41d08fb4e4518) Reviewed-on: https://gerrit.libreoffice.org/6153 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-10-11Extension shared library components must not use the "prefix" featureStephan Bergmann2-2/+2
...at least no non-bundled ones, see 9dfcee9266c9769153444cdcd4ab0e6e636c3eb6 "Not being able to honor a 'prefix' is a rather hard error" and the description there how that can lead to a crash when using mysql-connector-ooo.oxt: "'rm -rf instdir/*/share/extensions/mysql-connector-ooo', 'instdir/*/program/soffice workdir/*/Extension/mysql-connector.oxt', install the [extension] per-user, then 'File - New - Database - Connect to an existing database: MySQL - Next >> - Connect directly - Next >> - Database name: foo - Server / Port - Server: bar - Next >> - Test Connection', crash." This is a partial revert of cd79d51420b90117d0f3e1d5f3cdf9187bd61b88 "prefix all component_getFactory methods." Change-Id: Ia7a6272eb0597e3b3bbf4ab333174b3232448539 (cherry picked from commit 3bafe5f5f529f6539363c5a291dd13ef1e2cbbde) Reviewed-on: https://gerrit.libreoffice.org/6209 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-10-11resolved fdo#69948 honor a detected FilterNameEike Rathke1-6/+25
TypeDetection::queryTypeByDescriptor() adds the FilterName property to the MediaDescriptor, use that if present. Strangely enough the sequence returned by XNameAccess::getByName(sType) of the type detection contains an empty PreferredFilter value so that is useless in this scenario. (cherry picked from commit 823278dd095d754d0f673ef140c36c9fa7ebeffd) Backported. Change-Id: I5cdc9fe71e35bdb7c511739c7f7728134941649a Reviewed-on: https://gerrit.libreoffice.org/6207 Tested-by: Kohei Yoshida <libreoffice@kohei.us> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2013-10-11fdo#70143: fix SwDoc::ReplaceRangeImpl()Arnaud Versini1-3/+9
Fix fdo#70143 by reporting swaping of positions (regression from 6b08fe833186a04f9aef698a540d3a7493ac4519, which changed SwUndoReplace::Impl::SetEnd to use the wrongly set end position in rPam) Change-Id: I14c6f58bc5c1418c69eb565d42f1829856eed58c (cherry picked from commit 9685d20f2a0526a4c454cea1bd947eccbaeefa84) Fixes regex replace of "$" with nothing (to delete line breaks). Change-Id: If7ec1e5f524f7bb308a2949ace16cb8aa6989106 (cherry picked from commit f011a5c5071ed4a60f0ee7117608b72cecbb958d) Reviewed-on: https://gerrit.libreoffice.org/6175 Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2013-10-11Resolves: #i123359# need to call SdrEndTextEdit before...Armin Le Grand1-0/+9
manipulating objects at model/view (cherry picked from commit b5e8564995cd92e19cadcf8a6e9151be3efeeff4) Change-Id: Ie282370c7fc2dea4f9d59d85aac742b41d7c4541 (cherry picked from commit 668730fbdd1ccf9a23d0a55361d019ca9e58ff39)
2013-10-10Updated coreAndras Timar1-0/+0
Project: dictionaries 8349227a9dd98665d90b1ce744247fdaf5582936 updated pt dictionary Change-Id: I9380049c2e0b6716287c71aa2693f40dc78facf6 Reviewed-on: https://gerrit.libreoffice.org/6178 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-10-10Fail fast at least in debug buildsStephan Bergmann1-1/+1
Change-Id: I266d5cf5b98827617f7ed65c94a772e28808f386 (cherry picked from commit 57a28dc9556b4e6fff337e0eb9d0d8abc5223161) Reviewed-on: https://gerrit.libreoffice.org/6186 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-10-10Prevent out-of-bounds arguments to OUString::copyStephan Bergmann1-1/+3
...which would somewhat unhelpfully result in returning "!!br0ken!!" (partial backport of 34e951bd7284d2e771c279e3adc3899d191fdad0 "More OUString::copy out-of-bounds fixes") Change-Id: Ibf66d218fe5f0d7b6216795a3b991705d4afda73 Reviewed-on: https://gerrit.libreoffice.org/6183 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-10-09CID#736174 yikes, sizeof(char[]) includes 0, so 4 not 3Caolán McNamara1-1/+1
Change-Id: Ia54ecab9e08485ebffe98dc064f328360c17a120 (cherry picked from commit 8254648828e4f4d65a0516e160e5732f3d85765a) Reviewed-on: https://gerrit.libreoffice.org/6173 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-10-09bnc#779620 DOCX import: try harder to convert floating tables to text framesMiklos Vajna5-14/+54
Since 78d1f1c2835b9fae0f91ed771fc1d594c7817502, we convert floating tables to text frames only in case it's possible that there will be wrapping, to give better results for multi-page tables, which are multi-page, and technically floating ones, but that has no effect on the layout. The problem was that we try to do this decision too early, effectively the page width and margins were counted from the default letter size, instead of the actual values, which did not arrive at the time of the decision. Fix this by moving this logic at the section end. (cherry picked from commit bbef85c157169efa958ea1014d91d467cb243e6f) Conflicts: sw/qa/extras/ooxmlimport/ooxmlimport.cxx writerfilter/source/dmapper/DomainMapper_Impl.hxx Change-Id: Ic1fbceb54c8ec223ed01836fafe6220bb3b2410a Reviewed-on: https://gerrit.libreoffice.org/6104 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-10-09Fix fdo#70220 Superscript not imported from pptx.Thorsten Behrens3-24/+23
Import works now, though EditEngine still fscks up font scaling - seems for CharEscapementHeight to work, there has to be reference, non-scaled text in the same portion ... Change-Id: I5505ae83bd6b700ebe8c3465beec40a4df2efb78 Reviewed-on: https://gerrit.libreoffice.org/6154 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-10-09fdo#67074 push the localized macinstall.ulf to solverAndras Timar1-2/+2
Change-Id: I0c7ed3d5bbad93adeba6175f0a9789fcb8ec3d3f Reviewed-on: https://gerrit.libreoffice.org/6170 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-10-09fdo#64400: DXF import filter: fix OUString handlingMichael Stahl9-126/+110
The DXF import filter stores all strings read from the file in char[DXF_MAX_STRING_LEN+1] arrays, and then calls OUString constructor with that which then asserts because the string is actually shorter than the size of the array... avoid that by converting from char* to OString. Actually this also fixes the actual bug: the weird lines in the exported PDF were tiny Text elements from the document, repeated. (cherry picked from commit 96852a89da058084b2acf5ff706d9679b127b29a) Change-Id: I93c52788f88fe5d21968d450d029ed5db101d88b Reviewed-on: https://gerrit.libreoffice.org/6151 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-10-09fdo#70201: sw: eliminate no-extent RSID-only AUTOFMT hintsMichael Stahl1-0/+9
These are already filtered out in SwpHints::TryInsertHint(), but they can be produced by a SwTxtNode::Update() following some deletion like in SwTxtNode::ReplaceText() (or maybe CutImpl() and RstAttr() too?). So in order to prevent SwHistorySetTxt being created for these, filter them out in SwpHints::MergePortions(), which has the advantage that it's one location to change; probably filtering in Update() and RstAttr() both would work too. (regression from 6db39dbd7378351f6476f6db25eb7110c9cfb291) Change-Id: I597a9ab290dcc3fb1b624dd2dca241c462acf256 (cherry picked from commit 91159b1c31a7fd474ba0b97828f593604790ce3c) Reviewed-on: https://gerrit.libreoffice.org/6167 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-10-08fdo#62994 reportbuilder survive empty formulaLionel Elie Mamane1-0/+2
Change-Id: I1da053871d107730ad9a135deb48313d8a877d89 Reviewed-on: https://gerrit.libreoffice.org/6166 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-10-08WaE [-Wstrict-overflow] assuming signed overflow does not occurEike Rathke1-2/+2
... when assuming that (X - c) <= X is always true ... or that (X + c) < X is always false Change-Id: Ib2313827cd6358ced0141b41cba753896b676e28 (cherry picked from commit ca576e0804324bbb36b697543cbe992e34d4b951) Reviewed-on: https://gerrit.libreoffice.org/6158 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-10-08bump product version to 4.1.4.0.0+Christian Lohmaier1-1/+1
Change-Id: I7416968f44df48b25416bafe9d5357988cc55fef
2013-10-08Updated coreChristian Lohmaier1-0/+0
Project: translations e80c5f716acc72479afcb558d920a72925d1ff47
2013-10-08I forgot to add -d swith to signtoolAndras Timar2-26/+34
The UAC prompt shows a temporary random Program Name for msi, if the -d switch is not given. One more change: probably it is not wise to print the password of code signing key in clear text to log and to screen. Change-Id: I1f555754eee19708bbd7a3c70280fe662c77fc3a Reviewed-on: https://gerrit.libreoffice.org/6081 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2013-10-08fdo#52004 set resolution of .dmg background image to 72DPIAndras Timar1-0/+0
Apparently Mac OS X looks at the DPI value, not to the actual pixel size of the image. Change-Id: I9fd43228e4d2e05397f798ed4902d7d80ef2145f Reviewed-on: https://gerrit.libreoffice.org/6162 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2013-10-07fdo#66591 help needs this imageAndras Timar1-0/+0
Change-Id: I52c6455c1e8a09a6658b3d940e61d3424a16206e Reviewed-on: https://gerrit.libreoffice.org/6145 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-10-07fdo#70196: Python 2 compatibility for UNO import error handlingDavid Bolen1-8/+9
Add backwards compatibility support for Python 2 to the earlier change in fdo#66025 to improve import error handling under Python 3. Change-Id: I47bf8ef255c4c2a3e4a2754414977aaa8ed32483 Signed-off-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit df1076965f63eedc6cc104c96b993ab598b8b1d4)
2013-10-07rhbz#1001768: avoid deadlock in OAccessibleContextHelper::disposing()Michael Stahl1-1/+3
De facto this class is locked by SolarMutex, which is what the OExternalLockGuard actually locks; do not lock m_Mutex because it may cause deadlock. Change-Id: I88b226d73dbef9a5803347b0ac3191bec2ba4515 (cherry picked from commit 4100e3b6204fc304cc7b60b9d7ff2af75118b805) Reviewed-on: https://gerrit.libreoffice.org/6114 Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2013-10-07fix STL assert in accessibility::AccessibleGridControl::commitTableEventMichael Stahl1-8/+25
While running some JunitTest, crashes on an attempt to delete entries of an empty vector m_pImpl->m_pTable->m_pCellVector. The entries are created on-demand by AccessibleGridControlTable::getAccessibleChild(), so presumably that hadn't been called yet when the rows were deleted. Also fix bizarre abuse of all applicable variable naming conventions. (regression from 2095b2e1d44a158418d17836019352ed92f95d21) Change-Id: Id2d70ca4601a166718629c0fe922f805dd72eec1 (cherry picked from commit 4fc7deb7b0528010ebf644654bf4a36594e03f8c) Reviewed-on: https://gerrit.libreoffice.org/6131 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2013-10-04Resolves: #i123417# handle subsetting of empty ttf compound glyphs gracefullyHerbert Dürr1-2/+5
(cherry picked from commit d519b07ecd4b67cedf1fe3e1860ef33a48a01ae4) Signed-off-by: Caolán McNamara <caolanm@redhat.com> Conflicts: vcl/source/fontsubset/sft.cxx Change-Id: I51d4a97f1f01be49cb5ab058019cd153e23437bd (cherry picked from commit 6489f97fc428446c53c17f885963776cdcc21490) Signed-off-by: Caolán McNamara <caolanm@redhat.com>
2013-10-04fdo#69384 fix impress -> writer copy&pasteMiklos Vajna3-2/+40
Regression from 2ade07126971b79c92f729fae5709f2e2e2b495c (fdo#62044 RTF import: don't overwrite existing styles when pasting, 2013-06-04), during paste, if existing style was found, then the intention was to skip that style, but instead we tried to create one. (cherry picked from commit 5ebe826caf75e8d00656b3333385bf0bbc05cb27) Conflicts: writerfilter/source/dmapper/StyleSheetTable.cxx Change-Id: I83adaf9fe6b8a578fa60c21b9463fabde7707d7e Reviewed-on: https://gerrit.libreoffice.org/6126 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-10-04Initial fix for fdo#69915Jesús Corrius1-0/+6
Change-Id: Id673eb7a55aefb35ff8ab612f926bfd115129ab4 Reviewed-on: https://gerrit.libreoffice.org/6132 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-10-04compare against IDF_HARDATTR, fdo#69720Markus Mohrhard1-1/+1
regression from e851ea0ed30e9bb95c273a29aeab7f48f606145f Change-Id: I07819f90efe87fe9d82515d637960fe48ca40c80 (cherry picked from commit 6f2957969bd72308ddf79cb2befa2373f2dc1dbe) Reviewed-on: https://gerrit.libreoffice.org/6034 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-10-04allow to build for Windows XP when using Visual Studio 2012Christian Lohmaier4-2/+21
VS 2012 Update 1 added the possibility to target Windows XP by using a SDK that is based on the Windows 7 one. http://blogs.msdn.com/b/vcblog/archive/2012/10/08/10357555.aspx This patch probably should not be integrated as is, as it disables a test that fails in this configuration (CppunitTest_connectivity_ado) Change-Id: I3ba8723882452950c40049ccdc95b04c60862cbf Reviewed-on: https://gerrit.libreoffice.org/4966 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org> Reviewed-on: https://gerrit.libreoffice.org/6125 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-10-04configure.ac: always search for md5sumBenedikt Morbach1-6/+11
Since edf8db717f49199833de9fc9d2c9817bab613795, the MD5SUM env variable is used by solenv/bin/modules/{installer.pm,installer/systemactions.pm} like this: echo $languagestring | $ENV{'MD5SUM'} | sed -e "s/ .*//g" Because the MD5SUM check is behind "$enable_fetch_external" != "no", this causes an error with --disable-fetch external: sh: -c: line 0: syntax error near unexpected token `|' Move it out of the enable_fetch_external check. Change-Id: Ib0a9694226deed3957868c17fe4d982f38fd84b1 Reviewed-on: https://gerrit.libreoffice.org/6128 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-10-04Media/LastSequence is i4, so it has to be 32767->65535 in _Validation tableAndras Timar3-3/+3
Change-Id: Icfcd8c70da350e5b431d6ac802a34b35adf8035b Reviewed-on: https://gerrit.libreoffice.org/6108 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-10-04fdo#58144 - disable the ARP 'Remove' button on Windows XPAndras Timar6-0/+6
Windows installer on Windows XP cannot display messages, when the installer database is encoded in UTF-8 and support for CTL languages is not installed. This patch is a workaround, it disables the 'Remove' button in Control Panel's Add or Remove Programs applet, so the user has to choose 'Change', and has to uninstall LibreOffice with the Wizard, which does not exhibit the problem. Initially this bug was not expected, when we changed the enconding from legacy codepages to UTF-8 - I would say irreversibly. Then the severity of the bug was underestimated, because usually uninstallation needs no user interaction, so it does not matter, if the text is unreadable. However, in some circumstances uninstallation needs to reboot the computer, and the user needs to understand the question, whether to reboot now or later. Change-Id: I7d6b4e82cbe4142d23c29313e43a90fa43944b2f Reviewed-on: https://gerrit.libreoffice.org/6109 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-10-04CID#705749 mem leakCaolán McNamara1-0/+2
Change-Id: I8626e60d802b1c966667867d8c59ececff0a4255 (cherry picked from commit e17c91d1ff5c39b9b541b4d1bfb291c419fc76b5) Reviewed-on: https://gerrit.libreoffice.org/6118 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-10-04rhbz#1001768: AtkListener::disposing(): delay notificationMichael Meeks1-5/+20
Frame #10 in libatk-bridge.so calls atk_misc_threads_enter(), and having a look at the RHEL 6.5 at-spi package in ./at-spi-1.28.1/atk-bridge/bridge.c there is always the same call pattern: bridge_threads_leave (); [one function call] bridge_threads_enter (); ... so the bridge_threads_leave() has called the VCL gtk-plug function GtkHookedYieldMutex::ThreadsLeave() which releases the SolarMutex. This is of course not a good idea while there is a Window being deleted, and is the reason why the same Window is being deleted in thread 1 and thread 2: 31 0x00000fff94a5fc00 in Window::~Window (this=0xfff702b2d30, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:4272 16 0x00000fff94a5fc00 in Window::~Window (this=0xfff702b2d30, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:4272 Try to avoid the problem by delaying the atk_object_notify_state_change() that will release SolarMutex until idle, when deletion of the Window is finished. Thread 2 (Thread 0xfff4cbcf110 (LWP 17011)): 2 0x0000008013c6e718 in .pthread_mutex_lock () from /lib64/libc.so.6 3 0x000000801576e4fc in osl_acquireMutex (Mutex=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/sal/osl/unx/mutex.c:114 4 0x00000fff963a7908 in acquire (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/osl/mutex.hxx:58 5 ClearableGuard (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/osl/mutex.hxx:177 6 cppu::WeakAggComponentImplHelperBase::dispose (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/cppuhelper/source/implbase.cxx:392 7 0x00000fff5f1b3444 in comphelper::disposeComponent<com::sun::star::accessibility::XAccessible> (_rxComp=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/comphelper/types.hxx:114 8 0x00000fff5f273ba8 in VCLXAccessibleToolBox::implReleaseToolboxItem (this=<value optimized out>, _rMapPos=<value optimized out>, _bNotifyRemoval=<value optimized out>, _bDispose=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/accessibility/source/standard/vclxaccessibletoolbox.cxx:326 9 0x00000fff5f2747e4 in VCLXAccessibleToolBox::ProcessWindowEvent (this=0xfff5f8b8fe0, rVclWindowEvent=...) at /usr/src/debug/libreoffice-4.0.4.2/accessibility/source/standard/vclxaccessibletoolbox.cxx:612 10 0x00000fff951e4ad4 in VCLXAccessibleComponent::WindowEventListener (this=0xfff5f8b8fe0, pEvent=0xfff4cbcc950) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxaccessiblecomponent.cxx:136 11 0x00000fff951e4b20 in VCLXAccessibleComponent::LinkStubWindowEventListener (pThis=<value optimized out>, pCaller=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxaccessiblecomponent.cxx:121 12 0x00000fff946dd420 in Call (this=0xfff702b32a0, pEvent=0xfff4cbcc950) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/tools/link.hxx:123 13 VclEventListeners::Call (this=0xfff702b32a0, pEvent=0xfff4cbcc950) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/app/vclevent.cxx:66 14 0x00000fff94a4bab0 in Window::CallEventListeners (this=0xfff702b2d30, nEvent=<value optimized out>, pData=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:5272 15 0x00000fff94a4bc80 in Window::ImplCallEventListeners (this=<value optimized out>, nEvent=<value optimized out>, pData=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:5255 16 0x00000fff94a5fc00 in Window::~Window (this=0xfff702b2d30, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:4272 17 0x00000fff94a61138 in Window::~Window (this=<value optimized out>, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:4683 18 0x00000fff951efcf0 in VCLXDevice::DestroyOutputDevice (this=0xfff6801f010) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxdevice.cxx:56 19 0x00000fff952347a8 in VCLXWindow::dispose (this=0xfff6801f010) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxwindow.cxx:957 20 0x00000fff953c5f28 in UnoWrapper::WindowDestroyed (this=<value optimized out>, pWindow=0xfff70115a80) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/helper/unowrapper.cxx:263 21 0x00000fff94a60130 in Window::~Window (this=0xfff70115a80, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:4334 22 0x00000fff949cc8b4 in DockingAreaWindow::~DockingAreaWindow (this=0xfff70115a80, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/dockingarea.cxx:96 23 0x00000fff949cc918 in DockingAreaWindow::~DockingAreaWindow (this=<value optimized out>, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/dockingarea.cxx:96 24 0x00000fff951efcf0 in VCLXDevice::DestroyOutputDevice (this=0xfff6801c310) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxdevice.cxx:56 25 0x00000fff952347a8 in VCLXWindow::dispose (this=0xfff6801c310) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxwindow.cxx:957 26 0x00000fff953c5f28 in UnoWrapper::WindowDestroyed (this=<value optimized out>, pWindow=0xfff7001a320) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/helper/unowrapper.cxx:263 27 0x00000fff94a60130 in Window::~Window (this=0xfff7001a320, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:4334 28 0x00000fff94a1f7fc in SystemWindow::~SystemWindow (this=0xfff7001a320, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/syswin.cxx:89 29 0x00000fff94a6c744 in WorkWindow::~WorkWindow (this=<value optimized out>, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/wrkwin.cxx:150 30 0x00000fff94a6c7e8 in WorkWindow::~WorkWindow (this=<value optimized out>, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/wrkwin.cxx:150 31 0x00000fff951efcf0 in VCLXDevice::DestroyOutputDevice (this=0xfff8c486f48) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxdevice.cxx:56 32 0x00000fff952347a8 in VCLXWindow::dispose (this=0xfff8c486f48) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxwindow.cxx:957 33 0x00000fff88258ec0 in framework::Frame::impl_disposeContainerWindow (this=<value optimized out>, xWindow=...) at /usr/src/debug/libreoffice-4.0.4.2/framework/source/services/frame.cxx:2689 34 0x00000fff8826d71c in framework::Frame::dispose (this=0xfff8c308a08) at /usr/src/debug/libreoffice-4.0.4.2/framework/source/services/frame.cxx:1887 35 0x00000fff88263018 in framework::Frame::close (this=0xfff8c308a08, bDeliverOwnerShip=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/framework/source/services/frame.cxx:1650 36 0x00000fff88255908 in framework::Desktop::impl_closeFrames (this=<value optimized out>, bAllowUI=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/framework/source/services/desktop.cxx:1928 37 0x00000fff88256120 in framework::Desktop::terminate (this=0xfff8b3de388) at /usr/src/debug/libreoffice-4.0.4.2/framework/source/services/desktop.cxx:292 Thread 1 (Thread 0xfff930e82a0 (LWP 16956)): 2 0x0000008013c6e718 in .pthread_mutex_lock () from /lib64/libc.so.6 3 0x000000801576e4fc in osl_acquireMutex (Mutex=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/sal/osl/unx/mutex.c:114 4 0x00000fff946cd114 in vcl::SolarMutexObject::acquire (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/app/solarmutex.cxx:35 5 0x00000fff94a6ecb8 in SalYieldMutex::acquire (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/generic/app/geninst.cxx:49 6 0x00000fff8c24cb90 in GtkHookedYieldMutex::acquire (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/unx/gtk/app/gtkinst.cxx:91 7 0x00000fff8c24cd2c in GtkHookedYieldMutex::ThreadsEnter (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/unx/gtk/app/gtkinst.cxx:64 8 0x00000fff8b6dfabc in ?? () from /usr/lib64/gtk-2.0/modules/libgail.so 9 0x00000fff8b9f333c in .atk_misc_threads_enter () from /usr/lib64/libatk-1.0.so.0 10 0x00000fff8c1d534c in ?? () from /usr/lib64/gtk-2.0/modules/libatk-bridge.so 11 0x00000fff8c1d65fc in ?? () from /usr/lib64/gtk-2.0/modules/libatk-bridge.so 12 0x00000fff936af4e0 in ?? () from /lib64/libgobject-2.0.so.0 13 0x00000fff936b13d0 in .g_signal_emit_valist () from /lib64/libgobject-2.0.so.0 14 0x00000fff936b18f8 in .g_signal_emit () from /lib64/libgobject-2.0.so.0 15 0x00000fff8b9e5f3c in .atk_object_notify_state_change () from /usr/lib64/libatk-1.0.so.0 16 0x00000fff8c23083c in AtkListener::disposing (this=0xfff5f98dbc8) at /usr/src/debug/libreoffice-4.0.4.2/vcl/unx/gtk/a11y/atklistener.cxx:81 17 0x00000fff963aee2c in cppu::OInterfaceContainerHelper::disposeAndClear (this=<value optimized out>, rEvt=...) at /usr/src/debug/libreoffice-4.0.4.2/cppuhelper/source/interfacecontainer.cxx:316 18 0x00000fff9659d944 in comphelper::AccessibleEventNotifier::revokeClientNotifyDisposing (_nClient=<value optimized out>, _rxEventSource=...) at /usr/src/debug/libreoffice-4.0.4.2/comphelper/source/misc/accessibleeventnotifier.cxx:162 19 0x00000fff9659b20c in comphelper::OAccessibleContextHelper::disposing (this=0xfff5f8bb7e0) at /usr/src/debug/libreoffice-4.0.4.2/comphelper/source/misc/accessiblecontexthelper.cxx:130 20 0x00000fff5f275898 in VCLXAccessibleToolBoxItem::disposing (this=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/accessibility/source/standard/vclxaccessibletoolboxitem.cxx:265 21 0x00000fff963a79fc in cppu::WeakAggComponentImplHelperBase::dispose (this=0xfff5f8bb7e0) at /usr/src/debug/libreoffice-4.0.4.2/cppuhelper/source/implbase.cxx:404 22 0x00000fff5f1b3444 in comphelper::disposeComponent<com::sun::star::accessibility::XAccessible> (_rxComp=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/comphelper/types.hxx:114 23 0x00000fff5f273ba8 in VCLXAccessibleToolBox::implReleaseToolboxItem (this=<value optimized out>, _rMapPos=<value optimized out>, _bNotifyRemoval=<value optimized out>, _bDispose=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/accessibility/source/standard/vclxaccessibletoolbox.cxx:326 24 0x00000fff5f2747e4 in VCLXAccessibleToolBox::ProcessWindowEvent (this=0xfff5f8b8fe0, rVclWindowEvent=...) at /usr/src/debug/libreoffice-4.0.4.2/accessibility/source/standard/vclxaccessibletoolbox.cxx:612 25 0x00000fff951e4ad4 in VCLXAccessibleComponent::WindowEventListener (this=0xfff5f8b8fe0, pEvent=0xfffdc31f990) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxaccessiblecomponent.cxx:136 26 0x00000fff951e4b20 in VCLXAccessibleComponent::LinkStubWindowEventListener (pThis=<value optimized out>, pCaller=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/toolkit/source/awt/vclxaccessiblecomponent.cxx:121 27 0x00000fff946dd420 in Call (this=0xfff702b32a0, pEvent=0xfffdc31f990) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/tools/link.hxx:123 28 VclEventListeners::Call (this=0xfff702b32a0, pEvent=0xfffdc31f990) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/app/vclevent.cxx:66 29 0x00000fff94a4bab0 in Window::CallEventListeners (this=0xfff702b2d30, nEvent=<value optimized out>, pData=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:5272 30 0x00000fff94a4bc80 in Window::ImplCallEventListeners (this=<value optimized out>, nEvent=<value optimized out>, pData=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:5255 31 0x00000fff94a5fc00 in Window::~Window (this=0xfff702b2d30, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/window.cxx:4272 32 0x00000fff949d41c4 in DockingWindow::~DockingWindow (this=0xfff702b2d30, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/dockwin.cxx:473 33 0x00000fff94a35944 in ToolBox::~ToolBox (this=0xfff702b2d30, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/window/toolbox.cxx:1698 34 0x00000fff88343e40 in framework::ToolBar::~ToolBar (this=<value optimized out>, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/framework/source/uielement/toolbar.cxx:35 35 0x00000fff88343e88 in framework::ToolBar::~ToolBar (this=0xfff702b2d30, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/framework/source/uielement/toolbar.cxx:35 36 0x00000fff94a66a00 in ~LazyDeletor (this=0xfff40007720, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/vcl/lazydelete.hxx:162 37 vcl::LazyDeletor<Window>::~LazyDeletor (this=0xfff40007720, __in_chrg=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/solver/unxlngppc64.pro/inc/vcl/lazydelete.hxx:164 38 0x00000fff94998868 in vcl::LazyDelete::flush () at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/helper/lazydelete.cxx:54 39 0x00000fff946d2294 in ImplYield (i_bAllEvents=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/app/svapp.cxx:434 40 Application::Yield (i_bAllEvents=<value optimized out>) at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/app/svapp.cxx:463 41 0x00000fff946d22f8 in Application::Execute () at /usr/src/debug/libreoffice-4.0.4.2/vcl/source/app/svapp.cxx:408 Change-Id: Ic742442dd6ffeba59655c2e66df8dbabc906f061 (cherry picked from commit c3ef735fd5d8866c8ce28b89744150e733087427) Signed-off-by: Michael Stahl <mstahl@redhat.com>
2013-10-03Updated coreNagy Akos1-0/+0
Project: dictionaries 307cb4cdf237ee21d4a90e9059a347b524b13f69
2013-10-03Resolves: rhbz#1013844 fdo#47482 encrypted OOo 1.0 docs cannot be reopenedCaolán McNamara3-5/+39
Workaround for the encrypted OpenOffice.org 1.0 documents generated by Libreoffice <= 3.6 with the new encryption format and using SHA256, but missing a specified startkey of SHA256 Change-Id: Ib1acc4441b5adc6721cb3cde7a1191aa978e9a1b (cherry picked from commit 11ad93f4ba84f190c908e92a2c960f7a9fa800c0) Reviewed-on: https://gerrit.libreoffice.org/6105 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2013-10-02rhbz#1014010: Missing dependencies in isBootstrapType listStephan Bergmann1-11/+26
...the list has been fixed now by copying its elements into an ENTRIES file and running "unoidl-write udkapi/ @ENTITIES TEMP && unoidl-read TEMP >/dev/null" and adding any reported unknown entities until it succeeds. However, the updated list lead to deadlock when css.reflection.ParamInfo UnoType resolves css.reflection.XIdlClass UnoType resolves css.reflection.XIdlMethod UnoType resolves css.reflection.ParamInfo UnoType, so broke the circle by no longer resolving the interface methods' return and parameter types in InterfaceType::dumpMethodsCppuDecl (which is why those type infos are only generated on demand anyway; looks like this had been a careless thinko in the generation of comprehensive type info that had remained unnoticed all the time). Change-Id: I50ef2fde16242298e055c6fa5971e70fad1a2b68 (cherry picked from commit 254f59f623f58c320175a06a2c93bcee7868b623) Reviewed-on: https://gerrit.libreoffice.org/6099 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-10-01All the content of cppuhelper/source/compat.cxx must be in namespace cppuStephan Bergmann1-2/+2
Change-Id: I30dde10d1c299dbd9c0b2cb2fa025ce432df6cce (cherry picked from commit 69f1846f4095a9dc607a0e568980d8625d657c94) Reviewed-on: https://gerrit.libreoffice.org/6097 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-09-30fdo#66743 fix import of some RTF_CLSHDNG valuesMiklos Vajna3-2/+17
This should be in sync with model.xml, got broken when the somewhat random values got fixed to be the same as the ones which are in the ww8 spec. (Regression from 26d40686128e70916a636e20f5ccc5763bbb6cc8.) (cherry picked from commit 21e07d473d1ce995ca0f1d0ac0edb03e75a7dfc1) Conflicts: sw/qa/extras/rtfexport/rtfexport.cxx Change-Id: Id62047e0b2d5d8402a7c8bce95de487afe627e32 Reviewed-on: https://gerrit.libreoffice.org/6091 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-09-28Sign .msi/.msp files when build signing is enabled on WindowsAndras Timar1-0/+49
Change-Id: I927d78ae898596e6425b086f4d50fc4e1b9361c1 Reviewed-on: https://gerrit.libreoffice.org/5987 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2013-09-27fdo#69450 - IDF_ATTRIB & IDF_CONTENTS must be disjoint.Michael Meeks1-1/+1
Change-Id: Ib971824a7f274334012b872acec65310535ad767 Signed-off-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-09-25Uploading libmwaw 0.1.11Fridrich Štrba1-2/+2
Change-Id: Idf9589e13eaf143c854a9c98e2d773d8a28bd43f Reviewed-on: https://gerrit.libreoffice.org/6033 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-16 09:20:46 +0000