summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2019-10-10update creditslibreoffice-6-2Christian Lohmaier1-1311/+1339
Change-Id: Ib98367116f9727f6ec54372d4cd90b657258b0d7 (cherry picked from commit 70ae1da67310a596e5bc49f1053c7ff72c84f539)
2019-10-09tdf#128013: fix Crash when linking an odp fileJulien Nabet1-4/+7
See bt here: https://bugs.documentfoundation.org/attachment.cgi?id=154847 Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=3c86ffd8ded628e6f2b4187948a1b1056f6a0f56 Reviewed-on: https://gerrit.libreoffice.org/80500 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 1dc4c8266d45eb2f5c3de303eaa9233e3b52f058) Reviewed-on: https://gerrit.libreoffice.org/80506 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Change-Id: Id9355958b0c4a56215ff98f0e5be13a3074ce45f Reviewed-on: https://gerrit.libreoffice.org/80539 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-10-09Update git submodulesChristian Lohmaier1-0/+0
* Update translations from branch 'libreoffice-6-2' - update translations for 6.2.8 rc2 and force-fix errors using pocheck Change-Id: I2341567f45e7f639212e55292e568bebe88dbd9b
2019-10-09tdf#124391 Fix doubled menu in global menuSamuel Mehrbrodt1-2/+6
Regression from 3bedbfd9b3cee5a8d2da6ee0486859bd725979ba Change-Id: I56473a2b0620f90f23b1bcde3ae1290801021038 Reviewed-on: https://gerrit.libreoffice.org/80465 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-10-04Related: tdf#124600 sw textbox: sync left/right margin of shape to textboxMiklos Vajna3-0/+24
Writer TextFrames have a default left/right margin; sync from shape to textbox is needed to have correct layout when a DOCX shape has 0 left or right margin. The left margin of the shape was already correct. (The shape in the docx file was extended to have text.) (cherry picked from commit ff5f02b9282e19a2a8a68604c588e9487021b0b5) Change-Id: I832f1bc460f2553bd7f08252d3e21000b4906538 Reviewed-on: https://gerrit.libreoffice.org/80109 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-10-03Related: tdf#124600 DOCX import: ignore left wrap on left-aligned shapesMiklos Vajna5-1/+21
The DOC import does the same in SwWW8ImplReader::AdjustLRWrapForWordMargins(). This fixes one sub-problem of the bugdoc, so now the shape anchored in the header has a correct position. This made it necessary to re-visit the tdf#115719 testcases, which are minimal reproducers. The original document had from-left alignment (instead of align-to-left), but this did not matter before. Bring the test documents closer to the original large document, so the tests still pass and don't depend on LO mis-handling the above mentioned left-aligned situation. (The interesting property of tdf115719.docx, where Word 2010 and Word 2013 handles the document differently is preserved after this change.) (cherry picked from commit 4883da6fd25e4645a3b30cb58212a2f666dae75a) Change-Id: I973c13df47b0867e2c4756f0c448495257b7c9d5 Reviewed-on: https://gerrit.libreoffice.org/80041 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-10-03Resolves: tdf#127873 accept ',' comma group separator in number entities againEike Rathke1-1/+6
Existing documents unwittingly may have used that as decimal separator in such locales (though it never was as this is always the en-US locale). "Regression" from commit 9336286a7ea5385541344f444e6f8702c85bdacb CommitDate: Fri Nov 30 22:15:22 2018 +0100 [API CHANGE] Resolves: tdf#42518 new KParseTokens::GROUP_SEPARATOR_IN_NUMBER Change-Id: I0ffc1b8ec7c1820fccd8277036c64093dddf82fe Reviewed-on: https://gerrit.libreoffice.org/80023 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 2caa9d7ddcff3f6e380c306b737e9b5e9cdaf4c2) Reviewed-on: https://gerrit.libreoffice.org/80045 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-10-03Resolves: tdf#127786 cache Glibc locale string in LanguageTagImplEike Rathke1-10/+20
... for non-simple @modifier strings that are constructed using liblangtag, as loading resource strings needs it over and over and over again. Change-Id: Ib6a74e5ddb44508aa41f101c200a508bfa4a13bd Reviewed-on: https://gerrit.libreoffice.org/79770 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 24c7c12224f1c1d66f335f6fe085595352137646) Reviewed-on: https://gerrit.libreoffice.org/79775 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 99782b52c3cc25a32661c382ca98a32f6ec87003) Reviewed-on: https://gerrit.libreoffice.org/79787
2019-10-01filter: XHTML: make "calc-heading-digit" a little fasterMichael Stahl1-7/+4
Exporting OpenDocument-v1.3-csd01-part3-schema.odt to XHTML fails with: runtime error: file share/xslt/export/xhtml/body.xsl line 1404 element variable xsltApplySequenceConstructor: A potential infinite template recursion was detected. You can adjust xsltMaxDepth (--maxdepth) in order to raise the maximum number of nested template calls and variables/params (currently set to 3000). Unfortunately the document contains this many headings, and the calc-heading-digit computes the value by recursively looking at every preceding heading in the document, without TCO apparently... Try to improve this by using XPath to filter early the headings that are effectively ignored in the 3rd xsl:when case anyway: the ones with a level lower than the one for which the number is requested; this limits the recursive calls to the number of headings on the same level. Change-Id: Iddf5a91664402a57a0138731ddc9cebb06b0a126 Reviewed-on: https://gerrit.libreoffice.org/79720 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 86cca6b40ced4031dec4b708ac67b5cbe70cddf9) Reviewed-on: https://gerrit.libreoffice.org/79841 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-09-30tdf#125585 write default layer status for OLE objectsRegina Henschel1-0/+9
The layer status is taken from the active view, when saving the document. But embedded documents have no view. Error was, that for all layers value 'false' was written in that case. With this patch the defaults (visible, printable, not locked) (true, true, false) are written. Change-Id: I2388ce31cc208fba075083889ec1bb2f874ef482 Reviewed-on: https://gerrit.libreoffice.org/79701 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> (cherry picked from commit 12f9a9f341fd8f8a98f7cd98f296a8729d279e0d) Reviewed-on: https://gerrit.libreoffice.org/79786 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-09-26bump product version to 6.2.9.0.0+Christian Lohmaier1-1/+1
Change-Id: Id40e5d89c1b2dd29187e9226332bca3f363cac38
2019-09-26Revert "tdf#117988 writerfilter: IgnoreTabsAndBlanksForLineCalculation"Justin Luth2-1/+1
This reverts LO 6.2 commit 49ddaad2f3ba4e17e1e41e94824fb94468d2b680. tdf#127617 proves it simply was not the correct solution. I replaced the unit test document with one that clearly demonstrates that spaces/tabs should NOT be used in line height calculations. Example document tested with Office 2003, 2010, 2016. Change-Id: I2833384a017526d665adef0cae968bc4aef0dd94 Reviewed-on: https://gerrit.libreoffice.org/79473 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org> (cherry picked from commit 202bee1a819de7b1e8c75dd863c4154f66419400) Reviewed-on: https://gerrit.libreoffice.org/79484 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit b0c5bc47d0d170df1384dd48cee9291ce6044083) Reviewed-on: https://gerrit.libreoffice.org/79527
2019-09-25tdf#99115: add Css selector '*' style only if the element...Xisco Fauli3-14/+112
... is on top of the hierarchy Otherwise, we add it for every element on the hierarchy Adapt unittest from https://bugs.documentfoundation.org/show_bug.cgi?id=100198 Provided by Sam Yygier Reviewed-on: https://gerrit.libreoffice.org/78997 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 4007ced54d611d1397387f7329a47de5efaca32f) Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Change-Id: I72c7ae08f3ce0194eff86697b202d5553810abeb Reviewed-on: https://gerrit.libreoffice.org/79018 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2019-09-25tdf#127652 sw_redlinehide: don't set invalid SwTextFrame offsetsMichael Stahl1-1/+2
The obvious problem here is that if a deletion spans multiple text frames, the offset of the 2nd one must not be reduced lower than the start position of the deletion; apparently this fixes the subsequent crashes with stale text portions having now invalid indexes into the string. (regression from 0acde7514e666fc04805fd36503bd174162336ca) Change-Id: Iaf9e2c5ca06ed36dc0e8611891d19c22f7661d34 Reviewed-on: https://gerrit.libreoffice.org/79421 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 9ec2c77046901fdacca77753052b54c81e6bc82c) Reviewed-on: https://gerrit.libreoffice.org/79433 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-09-24Update git submodulesChristian Lohmaier1-0/+0
* Update translations from branch 'libreoffice-6-2' - update translations for 6.2.8 rc1 and force-fix errors using pocheck Change-Id: I373ede836681f1aa2f1fbf9729b52ecbe198dd79
2019-09-24Resolves: tdf#127695 IsGroupObject == true doesn't mean its a SdrObjGroupCaolán McNamara1-3/+5
but that it has a SubList Change-Id: I473464de5c6bba5c36be1ad7cbd21a3158645d66 Reviewed-on: https://gerrit.libreoffice.org/79412 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit e6c07d2018d0b6be7492664fa22f70461b1422b8) Reviewed-on: https://gerrit.libreoffice.org/79428 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-09-24tdf#127235 break if object is larger than pagePatrick Jaap3-2/+28
We will always have an overlap if the object is larger than the whole page. Look for the next page style: if it is missing or the same as the current, we simply stop. Change-Id: I699d5146d215f17b4775dbcb32811fa5b6ebf60d Reviewed-on: https://gerrit.libreoffice.org/78696 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/79104
2019-09-18update creditsChristian Lohmaier1-1416/+1486
Change-Id: I4d6c996cbc25053fed93ce62e261c6ae77119961 (cherry picked from commit cfcf0731c919a20387cebc56c033f9328a0af735)
2019-09-17tdf#119809: FILESAVE DOCX The combo box ActiveX control is lostTamás Zolnai5-2/+22
The problem was with the empty combobox. The implemenation before this commit imported a combobox only when the combobox had any item. Reviewed-on: https://gerrit.libreoffice.org/78024 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 3ceefe9abff98fc24ffb5e8e405f4999faddc351) Change-Id: I945098277d1ed34c65b43f0f6ad8eb361cf41b53 Reviewed-on: https://gerrit.libreoffice.org/78394 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-09-17latest expatCaolán McNamara6-15/+12
Change-Id: Ia98c9718ccd8e18b5f56851027bde944164f05c4 Reviewed-on: https://gerrit.libreoffice.org/78978 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-09-17Resolves: tdf#98844 calculate as shown with SUM() againEike Rathke1-1/+5
Change-Id: I0032bdb9a8f54baa2e599861e45691a255f45275 Reviewed-on: https://gerrit.libreoffice.org/78708 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 4321d8c8b09fd880a18b4106cdd1f90acc18a861) Reviewed-on: https://gerrit.libreoffice.org/78728 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-09-12tdf#126184 Use max paper dimensions to calculate clip regionMichael Weghorn1-3/+7
Assuming at least A4 for the page size isn't enough if e.g. A2 or larger is used, so too much was clipped in that case. Therefore, use the the maximum paper width/height instead, which is 6 m by default. This is still far from the 19 km that caused tdf#63955 and I cannot reproduce tdf#63955 with that new limit. A big thanks to Regina Henschel for the great analysis in tdf#126184! (Side note: Comments 18 and 19 in tdf#63955 suggest to do the whole clipping elsewhere, so if anybody wants to take a look at this...) Change-Id: Iccacad621675df6c7b4477182d7332c4a3d67139 Reviewed-on: https://gerrit.libreoffice.org/78690 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 1dccd6814f1fe7a06f3168d01d18d347269cd3c1) Reviewed-on: https://gerrit.libreoffice.org/78759 (cherry picked from commit 859f49294ad95d3a6596e135e550253155d6517b) Reviewed-on: https://gerrit.libreoffice.org/78790 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-09-10tdf#118710 - Report Builder Character Settings dialog Highlighting tab pageTamás Zolnai1-1/+1
doesn't set background. Regression from: 62fb96e075e79676b45912a3a8ec2702b1e3aaf2 Change-Id: Ie60a4b4d988ba00b3a425dda73ed6ffeb40394c9 Reviewed-on: https://gerrit.libreoffice.org/78340 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 6cc5baa0a15014c442932c60bb60dc2a84edc25f) Reviewed-on: https://gerrit.libreoffice.org/78379 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 583425d04937c4a2842185497742608c5e7b76df) Reviewed-on: https://gerrit.libreoffice.org/78392
2019-09-06tdf#121983 cairo: fix RPATH to contain $ORIGIN, not libtool's nonsenseMichael Stahl3-1/+17
Also transmit $(verbose) to the build so it's debuggable. Change-Id: I8620fdcae2fcd34807b6b83b7c38aa5ca1ba2caa Reviewed-on: https://gerrit.libreoffice.org/78596 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit bb9c07b82f4921941112de7e545af13a24b37f5d) Reviewed-on: https://gerrit.libreoffice.org/78629 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-05tdf#127189 FreeType <= 2.8 will fail to render stretched horizontal brace...Caolán McNamara3-0/+46
glyphs in starmath at a fairly low stretch ratio. The failure will set CAIRO_STATUS_FREETYPE_ERROR on the surface which cannot be cleared, so all further painting to the surface fails. This appears fixed in 2.9 with https://git.savannah.gnu.org/cgit/freetype/freetype2.git/commit/?id=91015cb41d8f56777f93394f5a60914bc0c0f330 "Improve complex rendering at high ppem" Change-Id: I8cbf8347ccd29beda4057b14f2e68678f6030bf4 Reviewed-on: https://gerrit.libreoffice.org/78590 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-09-04Resolves: tdf#126928 allow link updates in an intermediate linked documentEike Rathke4-31/+49
... if link updates are allowed in the current document and that intermediate document resides in a trusted location. This works with both, the "Always (from trusted locations)" and the "On request" settings under Tools -> Options -> Calc -> General. It can't work with documents residing in a non-trusted location as there is no way to allow updates on demand for a such loaded document (hidden via formulas). Reviewed-on: https://gerrit.libreoffice.org/77588 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 54bf84746a2a9a2e2aaf0df9e429b0cfd538f640) Conflicts: sc/source/ui/docshell/docsh4.cxx sc/source/ui/docshell/externalrefmgr.cxx Backported. Also includes commit 1663b1e8233db6c6d1c2b35639ad984961084009 CommitDate: Tue Feb 26 21:15:57 2019 +0100 tdf#120736: For Calc shared documents also check the original document URL Change-Id: Ie483f7743db7c6d5cf947dc16a9c3660855f3423 Reviewed-on: https://gerrit.libreoffice.org/77613 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-03assert on selecting text from end to start in shape with a11y enabledCaolán McNamara1-1/+1
Change-Id: I0a135236cf5e5f291b6289cc76228290a6f77e98 Reviewed-on: https://gerrit.libreoffice.org/78409 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-09-02tdf#127085: FILESAVE: Transparency is lost after RTTamás Zolnai3-3/+14
Reviewed-on: https://gerrit.libreoffice.org/77963 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 505cbb9c3d2771a12c989515663cc1eb73dd0c2f) Change-Id: I22ba83b5cc00f84112a3755898ee2be58337afd6 Reviewed-on: https://gerrit.libreoffice.org/78263 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-08-29tdf#126007 tdf#122355 online help won't look into a dialog notebookCaolán McNamara2-51/+97
when the focus is on the help button, offline will through the help fallback route, but online will just fire and forget and let the server side do a fallback, which can't know what the current notebook page was. so bodge it to look at the notebook page right from the start if there is one and its the help button itself which starts the request Change-Id: Ida1d3101d838d99639dda12c438414c16b1ccda5 Reviewed-on: https://gerrit.libreoffice.org/77550 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-08-28bump product version to 6.2.8.0.0+Christian Lohmaier1-1/+1
Change-Id: I1f8f009e442244cdf1bb6a9479690a016a264377
2019-08-28Update git submodulesChristian Lohmaier1-0/+0
* Update translations from branch 'libreoffice-6-2' - update translations for 6.2.7 and force-fix errors using pocheck Change-Id: Ie4f27c58ff9e329beeafef4c4b6f70a8378742f9
2019-08-28warn on load when a document binds an event to a macroCaolán McNamara32-114/+329
a) treat shared/Scripts equivalently to document scripts This doesn't automatically warn/block running those scripts when used in a freshly loaded document on its own however because DocumentMacroMode::checkMacrosOnLoading will see at... if ( m_xData->m_rDocumentAccess.documentStorageHasMacros() || hasMacroLibrary() ) that the document contains no macros and flip the allow macros flag to true so that potentially new uses of macros added by the user during the edit are allowed to run b) so, add an additional flag to indicate existence of use of macros in a document c) for odf import, set it when a script:event-listener tag is encountered d) for html import when registerScriptEvents or SwFormatINetFormat::SetMacroTable is called e) for doc import when Read_F_Macro or StoreMacroCmds is called as well for good measure f) for xls import when registerScriptEvent or ScMacroInfo::SetMacro is called g) for oox import when VbaProject::attachMacros is called Change-Id: Ic1203d8ec7dfc217aa217135033ae9db2888e19b Reviewed-on: https://gerrit.libreoffice.org/77387 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2019-08-28tdf#126784 sw: only distribute across selected columnsJustin Luth7-23/+52
partial revert of LO6.2 commit ab18c17d70e1dcf5cf9db38256d35e6af479373e because MERGED cells had a very unexpected effect on the columns that were altered. Unselected columns are INCLUDED in the calculation IF they extend over the selected columns when SwTableSearchType::Col uses the entire table column. The last table in the unit test demonstrates why the regressive behaviour was included. A user can make an ugly layout if they don't choose a good set of columns. However, the merged cell really changes the way the calculation works, and since giving power to the user is ultimately the best, just revert the portion that tries to save the user from themself. I struggled then and now to get a good enough understanding to improve the documentation - which really is needed since reading it didn't help me a lot. However, since my understanding was and is obviously flawed, I'll just revert back to the original wording. Change-Id: Icf8f01f095652e2a023e0398852f43aa6b90332f Reviewed-on: https://gerrit.libreoffice.org/77985 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-27Fix old boost build for goodTomáš Chvátal3-3/+16
With the previous approach the code could lead to crashes in the flowfrm.cxx Change-Id: I3b56ed46db9d37a606a1cd793a20b8aff22db6e2 Reviewed-on: https://gerrit.libreoffice.org/78001 Reviewed-by: Tomáš Chvátal <tchvatal@suse.com> Tested-by: Tomáš Chvátal <tchvatal@suse.com> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-26Improve checkStephan Bergmann1-1/+1
Change-Id: I8280a81eef2ced0ff0ace51ea9f094421abafe13 Reviewed-on: https://gerrit.libreoffice.org/78108 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 761e6dd25782420bf06e4a2ff3205a79b6cbb136) Reviewed-on: https://gerrit.libreoffice.org/78129 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-24Resolves: tdf#126693 cannot put focus into combobox entryCaolán McNamara1-1/+1
Change-Id: I52a316e5c88a41c66ef08be1bae8fcdd10d2ab8e Reviewed-on: https://gerrit.libreoffice.org/78032 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-08-22tdf#126271 Revert "tdf120965 Simplify SdrPathObj::AddToHdlList()"Regina Henschel1-27/+44
This reverts commit 26001f4f84b0d921c8612d888856613735ba5314. Change-Id: Ib4df476b405e65be9203ab376c9c68b03198c040 Reviewed-on: https://gerrit.libreoffice.org/77882 Tested-by: Regina Henschel <rb.henschel@t-online.de> Reviewed-by: Regina Henschel <rb.henschel@t-online.de> (cherry picked from commit 59189f3e02acbdf4e5bbd35fc278252b30022f43) Reviewed-on: https://gerrit.libreoffice.org/77940 Tested-by: Jenkins
2019-08-21Resolves: tdf#122110 convert condition decimal separator to target localeEike Rathke3-3/+34
Otherwise re-scanning the format code in the target locale failed. Change-Id: Ia4face1b5630c197f68b1f521e62b163550301e6 Reviewed-on: https://gerrit.libreoffice.org/77852 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 152c4fcbf1aa5b7454834581927056cfc9d1d7e5) Reviewed-on: https://gerrit.libreoffice.org/77859 Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2019-08-20Fix buidling with older boostTomáš Chvátal2-0/+12
Change-Id: I49691e8bf708aa9146d5c4f61532e7a215f4ac2d Reviewed-on: https://gerrit.libreoffice.org/77716 Reviewed-by: Tomáš Chvátal <tchvatal@suse.com> Tested-by: Tomáš Chvátal <tchvatal@suse.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-19Improve check for absolute URIStephan Bergmann1-1/+1
Change-Id: I4dee44832107f72f8f3fb68554428dc1e646c346 Reviewed-on: https://gerrit.libreoffice.org/77706 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit c79efeb66f7951305d0334bc288aee1c571a8728) Reviewed-on: https://gerrit.libreoffice.org/77724 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-19Resolves: tdf#126951 crash in custom slide showCaolán McNamara1-1/+1
on selecting entry 0 which doesn't exist Change-Id: I67656bed63f9055bc6c5dd5781e79f967996500d Reviewed-on: https://gerrit.libreoffice.org/77560 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 5d3e9ababc0b3e049a7556b210bb6349e3e3322c) Reviewed-on: https://gerrit.libreoffice.org/77696 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-08-19Writer: Saving a damaged file as DOCX crashesTamás Zolnai1-8/+11
Reviewed-on: https://gerrit.libreoffice.org/77412 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit de8415ff5a730465258cd5f0ab7c0d989ba5518d) Reviewed-on: https://gerrit.libreoffice.org/77444 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 0f7eb072fdc2d5b4ee1690597dafc475a611f007) Change-Id: I42de376c69d0b1caa0a03622506d1bf6385ca57e Reviewed-on: https://gerrit.libreoffice.org/77670 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-08-16an absolute uri is invalid inputCaolán McNamara1-0/+5
Change-Id: I392be4282be8ed67e3451b28d2c9f22acd4c87fc Reviewed-on: https://gerrit.libreoffice.org/77564 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 3c076e54f736980e208f5c27ecf179aa90aea103) Reviewed-on: https://gerrit.libreoffice.org/77572 Tested-by: Jenkins
2019-08-15Resolves: tdf#126943 load styles should be modalCaolán McNamara1-0/+1
Change-Id: I7526cd974d3c3ac47f29fda95af226d42d63f583 Reviewed-on: https://gerrit.libreoffice.org/77518 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-08-14tdf#124700 don't pull from or insert into cache for PixelSnapHairlineCaolán McNamara2-11/+19
Change-Id: I7ca0f556164b6bc462cee3c5532733dbd6b68a2b Reviewed-on: https://gerrit.libreoffice.org/77457 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
2019-08-14tdf#126808 vcl: fix crash due to leaking the frame's buffer vdevMiklos Vajna1-0/+1
This vdev is used to do vcl-level double-buffering, which is off by default, but e.g. listboxes/comboboxes use it to avoid flicker with Windows GDI. The root cause was introduced in commit ea5e83abcfa1406c401b8a1ec91efda65373b74b (tdf#92982 vcl: stop creating/disposing the paint buffer in PaintHelper, 2015-07-30), which removed the explicit mpBuffer.disposeAndClear() in the PaintHelper dtor, but forgot to explicitly dispose it elsewhere. This is now a much more visible problem since commit d4714b0fdb81e6e561ae526cc517ecc9a40a603e (tdf#101978 vcl combobox/listbox floating window: avoid flicker, 2019-06-17) as the infrastructure is used for all list/comboboxes. Fix the problem by explicitly disposing the vdev before deleting the frame data, so the underlying GDI resource is released, even if we have a reference cycle. Change-Id: Ia217bbd78780a214308e497044e73e378ee8ecd6 Reviewed-on: https://gerrit.libreoffice.org/77370 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit e71093c0bc52426647a9d3a41ac0643bbc6cb0c6) Reviewed-on: https://gerrit.libreoffice.org/77395 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-08-14configure: don't enable export validation if there are no schemasMichael Stahl1-0/+6
Schemas are excluded from tarballs since commit 34dced99c33a97dab86c4538fa267ad4ad4fb41f because of the license. Change-Id: I6540926d9ebb390d7956bbd1df3bb915adebb64b Reviewed-on: https://gerrit.libreoffice.org/77383 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit c78dd0a726b32d922a0d75a26a51d4c30612368c) Reviewed-on: https://gerrit.libreoffice.org/77393 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-08-13tdf#116085 add more Gpg4Win binary locationsThorsten Behrens1-3/+8
Seems Gpg4Win recently grew a few more variants where to put stuff. Look there, too. Change-Id: Ifa09db11665671f518a6a66480c1a71fd619d8cd Reviewed-on: https://gerrit.libreoffice.org/77341 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 536ab2f3ba1e71badaaf98db9419ca7c7ddd7ac4) Reviewed-on: https://gerrit.libreoffice.org/77421
2019-08-13Resolves: tdf#122358 ensure right/bottom borders are included in damage regionCaolán McNamara1-1/+6
a simple safely backportable expand of damage region by one pixel Change-Id: If4d226d8546d55b00172d826c8816b09b55d54ef Reviewed-on: https://gerrit.libreoffice.org/77209 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-13Resolves: tdf#126766 fix rounding correction at start of negative valuesEike Rathke1-2/+12
doubleToString() is entered with an inaccuracy afflicted fValue=-9999.9999999999927 for which the rounding into the next magnitude incremented the '-' character to '.' instead of appending a '1' (and '0' and then "000") thus yielded ".0000" instead of "-10000" This seems to have been always the case. Change-Id: I66170defa71fec40ca0b85f68affde8eff0d5ccb Reviewed-on: https://gerrit.libreoffice.org/77208 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit be8da97976658ff19b4dd010bff328cd3f424c1b) Reviewed-on: https://gerrit.libreoffice.org/77216 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>