summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2017-01-23use tools::SvRef in ImpSdrObjTextLinkUserDataNoel Grandin2-2/+3
since the field is SvRefBase-derived Change-Id: Ie84c48daf93e3805b2db240a497a8496779fe750
2017-01-23use rtl::Reference in ODatabaseFormNoel Grandin2-13/+10
rather than manual acquire/release Change-Id: Ic5f013b7e4cafc597c659c61fbf568adccfd806a
2017-01-23use rtl::Reference in SubmissionPropertyHandlerNoel Grandin2-10/+8
rather than manual acquire/release Change-Id: I3276361153591a3af8c6b00b478365b2700dedf5
2017-01-23use rtl::Reference in bib::OComponentListenerNoel Grandin2-24/+9
rather than manual acquire/release Change-Id: Ib4b52fb4a85223f974e9905bc3d02eb839150030
2017-01-23use rtl::Reference in DocumentHolderNoel Grandin2-12/+10
instead of manual acquire/release Change-Id: Id795dca5ff9e392fa2649f4721a73ce3ffd6de2c
2017-01-23use rtl::Reference in OCommonEmbeddedObjectNoel Grandin7-76/+70
instead of manual acquire/release Change-Id: Ie641f72687a05e1cd3cf697d551f9c6d21ac4487
2017-01-23use rtl::Reference in SbaXGridControlNoel Grandin2-21/+19
instead of manual acquire/release Change-Id: Ie103377d89419648d5f1d786933030b6f6166515
2017-01-23use rtl::Reference in OResultSetNoel Grandin2-17/+11
instead of manual acquire/release Change-Id: I8baa2e7ac64445ea69d4b62566a89b6e42307e51
2017-01-23use rtl::Reference in OPropertyChangeListenerNoel Grandin2-20/+10
instead of manual acquire/release Change-Id: Ie80253b5a59a3e3fcd52f98d9c26bcde42fe985a
2017-01-23use rtl:Reference in SmartContentNoel Grandin2-18/+6
instead of storing both a raw pointer and an uno::Reference Change-Id: Ia7a177ed9adcd9d413c86490b57036b0bd80f76d
2017-01-23Lok: unittest batch APIAshod Nakashian1-0/+45
Change-Id: I33bc59756f46b51a69efd91b89813ba17eca6218 Reviewed-on: https://gerrit.libreoffice.org/33403 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-01-23tdf#104061 MSWordExportBase: tables shouldn't prevent sectionbreakJustin Luth3-4/+7
This also reverts temporary commit ba2c31da9723182d2087e27a1ea0f95d9617f343 which was done to look for more pro or con proof documents. None found. This section of code has been essentially unmodified since the initial import in 2000, so apparently the necessity for preventing the processing of a section if the table item contains pageBreak info is no longer valid. My guess is that tables were excluded to fudge round-tripping better. Recent use of dummy paragraphs during import fixes many import problems, and thus export of the section node no longer should be avoided. Change-Id: I28bcf618f596a1676e2e7820de192ca63bffe68f Reviewed-on: https://gerrit.libreoffice.org/32936 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-01-23Lok: support for batch API callsAshod Nakashian4-0/+50
Mouse and keyboard operations typically come in batches, and often each results in tile invalidations and/or layout modifications. Processing each input event on its own, then processing the resulting output event is very costly and unecessary when we know there is more of the same. The new API adds support for batching such related input events by disabling the output events generated by Core until the batch is done. The client can then process the resulting events, which will be compressed and deduplicated. Change-Id: Id381dab807186d010021a8778ee440074a739920 Reviewed-on: https://gerrit.libreoffice.org/33402 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-01-23bEncodedFilter is always falseMaxim Monastirsky2-3/+3
Change-Id: I1b959ce8f46f45a789bb7d493c371677ba775f3b
2017-01-22coverity#1399045 Untrusted value as argumentCaolán McNamara1-0/+9
Change-Id: Icac88c7b439036434cbf2352ac50e954139db4ce
2017-01-22wrong streamCaolán McNamara1-1/+1
Change-Id: I4e890ab80ed4ddb24b0fd41dae12264c99fb1477
2017-01-22return early on not goodCaolán McNamara1-0/+2
Change-Id: I4aca6cb1c3dae652595b93ff7507db713a668d5f
2017-01-22move loop variables to loopsCaolán McNamara1-15/+14
Change-Id: I914206bad88fb3c405a335c2926fb51e39b7857e
2017-01-22align commentCaolán McNamara1-7/+7
Change-Id: I50a728e785589e3ec2d9128679f3e69451c5102a
2017-01-22coverity#1399029 silence Out-of-bounds readCaolán McNamara2-5/+6
Change-Id: I025e416a6a162316d82cfbde9fbfcb0a45e888d5
2017-01-22Updated coreAndras Timar1-0/+0
Project: dictionaries d759f48f50da7ecd05b045780079b54d339f36c6 tdf#105396 update German dictionaries Change-Id: I74d65e945c3ad080d95d77d846e56b4fa493c3aa Reviewed-on: https://gerrit.libreoffice.org/33395 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-01-22cppcheck: memleak (false positive)Jochen Nitschke1-3/+2
but manage ownership from start Change-Id: I22d855d89bd93c56fbbcc1fb64e757fc950aa791 Reviewed-on: https://gerrit.libreoffice.org/33391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-22cppcheck: multiConditionJochen Nitschke1-5/+0
> Expression is always false becase 'else if' condition matches > previous condition at line 1130. Change-Id: Ic56379716ada435ad7e2a00252310bfa50868f04 Reviewed-on: https://gerrit.libreoffice.org/33388 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-22cppcheck: useInitializationListJochen Nitschke1-2/+0
no need to initialise twice, actually no need to explicit initialise unique_ptr to nullptr Change-Id: Iff213722e22a0056d7e4c635e62437479c021f08 Reviewed-on: https://gerrit.libreoffice.org/33389 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-22cppcheck: useInitializationListJochen Nitschke1-7/+9
don't initialise the unique_ptr m_pFat twice Change-Id: Ifa4d9b68756c89c76a1be5803e84526dcfa2c1e7 Reviewed-on: https://gerrit.libreoffice.org/33390 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-22add SKEWP test caseZdeněk Crhonek1-0/+6874
Change-Id: I4b1e9711d1d85670e7ec698d961eb63f3cb53e6e Reviewed-on: https://gerrit.libreoffice.org/33382 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-01-22gbuild-to-ide, final cleanup in parser.jan Iversen1-33/+21
Now the json file can be expanded with new keys, without the need to touch parser. Change-Id: I8182e8030e206e302258bd156d7392ff5c98f3d4
2017-01-21cppcheck: funcArgOrderDifferentJochen Nitschke2-11/+8
fixes > Function 'Writer' argument order different: > declaration 'nDocWidthInput, nDocHeightInput, nDocWidth, > nDocHeight, nJPEGcompressMode' > definition 'nTWIPWidthOutput, nTWIPHeightOutput, nDocWidthInput, > nDocHeightInput, nJPEGcompressMode' use arguments in initializer list Change-Id: I746da5ef237b62a983df6745e1704342bcea5f9d Reviewed-on: https://gerrit.libreoffice.org/33381 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-21add HEX2BIN, HEX2DEC, HEX2OCT test caseZdeněk Crhonek3-0/+17523
Change-Id: I94232c713306f98816308840cc654b7ae1d3d6d3 Reviewed-on: https://gerrit.libreoffice.org/33357 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-01-21coverity#1399435 Unused valueCaolán McNamara2-21/+23
and coverity#1399438 Unused value coverity#1399439 Unused value its all ok as it was, but doesn't hurt to skip the exception test if the previous test failed anyway Change-Id: I110ac062d72514c51d415944a2250c3095584531
2017-01-21coverity#1399156 split ImplCreateSwapInfo and ImplClearGraphicsCaolán McNamara2-7/+12
Change-Id: Iab449967c70a55c03c3e6b95de8e7d973cb68089
2017-01-21coverity#1399443 UrF: Unread fieldCaolán McNamara1-2/+1
fix like... commit b9d63d49be66ed1bfc4a76924f1c52ec3630adc8 Date: Tue Jan 12 15:27:41 2016 +0200 remove some unused Java code found by UCDetector Change-Id: Ic0295a24b26e206eb53eda2da540755477df86df Change-Id: I5ce651905edbba3f23ebb421ebc0acadd54f39cf Reviewed-on: https://gerrit.libreoffice.org/33379 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-21coverity#1399442 UPM: Private method is never calledCaolán McNamara1-96/+1
since commit 10cb59eb914ba722c203242272de244d795a51e8 Date: Mon Jan 16 16:41:53 2017 +0200 remove some unused Java code Change-Id: I00c0b1b22f29165fea73b39b4bf946af453186a3 Reviewed-on: https://gerrit.libreoffice.org/33378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-21coverity#1399444 UwF: Unwritten fieldCaolán McNamara1-33/+9
and coverity#1399441 NP: Null pointer dereference since commit 10cb59eb914ba722c203242272de244d795a51e8 Date: Mon Jan 16 16:41:53 2017 +0200 remove some unused Java code Change-Id: Ieab0325c8685cdc89458570ac8e4d3292af84dff Reviewed-on: https://gerrit.libreoffice.org/33377 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-21add IMABS, IMAGINARY testcaseZdeněk Crhonek2-0/+11534
Change-Id: Icb4f4339318b88c4c2038cb4d1f16af7fc5057a2 Reviewed-on: https://gerrit.libreoffice.org/33361 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-01-21gbuild-to-ide clean replaced GbuildLinkTarget with dictjan Iversen1-108/+75
The class GbuildLinkTarget was removed and replaced by a dict. This is first step in avoiding typing the json key names multiple times Change-Id: I3a2006979929c5d21549693e51eb47df7233400d
2017-01-21this.cmdLine assigned twiceCaolán McNamara1-1/+0
Change-Id: Icbc2393ac623d76c3ca5ae74525705f784b99c1c
2017-01-21coverity#1399047 Untrusted loop boundCaolán McNamara1-1/+1
Change-Id: I1c4c4613349935c803d1cf7729c52a3a18ee5375
2017-01-21coverity#1399043 Resource leakCaolán McNamara1-29/+29
Change-Id: I11c23a02241712bbbae62c4716d0ca48c0436107
2017-01-21coverity#1399016 Logically dead codeCaolán McNamara1-2/+6
Change-Id: Ib3f0ca4d07dffb568287bcd6a283ab4e529519ff
2017-01-21coverity#1399031 golden, Out-of-bounds readCaolán McNamara1-1/+1
There are 17 elements, so SAL_N_ELEMENTS(sppnPatterns) is 17 The largest valid index is 16, not 17, so valid max index is out by one Change-Id: Id20218a0e73cb9e502a631fa6bfbb3f0a22c4727
2017-01-21coverity#704601 Dereference after null checkCaolán McNamara1-1/+2
Change-Id: Icfef8f4ded311790a90b61b37c08254592d979ab
2017-01-21coverity#704602 Dereference after null checkCaolán McNamara1-1/+2
Change-Id: I069716ad675a217ecd97aee6b07346cf838fd653
2017-01-21coverity#1399027 Dereference after null checkCaolán McNamara1-1/+1
Change-Id: I6006e98ea45a8326899c0afb7c39b0062fd27220
2017-01-21coverity#1399024 Explicit null dereferencedCaolán McNamara1-1/+2
Change-Id: I9e8f4bf693734625ec3544e5d4f35a7d048ea609
2017-01-21coverity#1399025 Dereference after null checkCaolán McNamara1-8/+7
Change-Id: I58ccfeb03388a60a6e2a506a22490ada5feb669f
2017-01-21coverity#1399026 Unchecked dynamic_castCaolán McNamara1-0/+1
Change-Id: I60188c36bdd6d44c5bd8dae28debafc10b6c9f3b
2017-01-21coverity#1399023 Unchecked dynamic_castCaolán McNamara1-1/+1
Change-Id: Id5d0a3cca9587f577000244a9776d7f1f61b5487
2017-01-21coverity#1399022 Dereference after null checkCaolán McNamara1-2/+2
Change-Id: I33c2007a8caf4f0c83cfe1119bba828f6a7c7c29
2017-01-21coverity#1399021 Unchecked dynamic_castCaolán McNamara1-2/+2
Change-Id: I2b43a918f8f01bbe075c2edd8ca963e13588903c