summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2018-09-18tdf#118691 DOCX import: fix table loss caused by <w:cr>László Németh3-2/+14
According to the OOXML standard, <w:cr> (carriage return – Unicode character 000D) is equivalent to a break with null type and clear attributes, so we handle it as a <w:br/>, instead of endOfParagraph, fixing losing table paragraphs and tables containing <w:cr/>. Note: It seems, MSO cannot handle carriage return characters in table cells correctly. It shows squares (unknown characters) without line break there. Copying this text to a non-table paragraph in MSO, we get the correct layout with line breaks. Copying this text with carriage return characters back to a table cell, we get squares again. With this LO fix, it will be possible to fix the bad tables edited by MS Word by using LO, because LibreOffice import/export converts all <w:cr>s to <w:br>s (as before, but now without destroying the structure of the tables). Change-Id: Iee42f71e9a00531353582e7127c2c212ea0890d0 Reviewed-on: https://gerrit.libreoffice.org/60585 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit f63a60f56156e4ac17887e6c96d15fb865a2a8eb) Reviewed-on: https://gerrit.libreoffice.org/60655 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-18crash editing previously added remote cmisCaolán McNamara1-0/+18
http://crashreport.libreoffice.org/stats/crash_details/61ba172a-ce27-46d7-8493-dc7cb688b10a presumably since... commit 767188fd1b1e1f504864f9489076283ebc413625 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu May 17 16:21:02 2018 +0100 make PlaceEditDialog a bit more ordinary which missed the other ctor Change-Id: Iece359b94afdd0d2c48afe7f301e7178180f1dc5 Reviewed-on: https://gerrit.libreoffice.org/60587 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-09-18tdf#119875 sw: fix invalid pos of frame after 0-sized section with laycacheMiklos Vajna3-4/+39
The interesting part of the layout of page 2 is: - frame #40 is a section frame with a text frame which is in a list ("A") - frame #48 is a section frame after that, with the same top=19213 Given that frame #40 has height > 0, they overlap when the page is rendered. What happens is: - frame #40 grows - there are other section frames between #40 and #48 in-between, but they don't have an SwSection - these frames are skipped - then the position of #48 is invalidated So the next time we calculate the position of #48, we look the last skipped (previous) section frame (which still has top=19213, since its position was not invalidated above), and since its height is 0, we conclude that our current top=19213 is valid after all. This is like this since commit 84a3db80b4fd66c6854b3135b5f69b61fd828e62 (initial import, 2000-09-18), so leave the code there that invalidates not only the next frame, but all the way down to the first non-SwSection-less-SwSectionFrame. But instead of just invalidating the last frame, invalidate the in-between SwSection-less-SwSectionFrames as well. In practice this did not cause a problem in case the document has no layout cache. If it does, then the frames are created on pages hinted by the cache, then later moved to their final place. In practice this bug was visible only in this later case. (I.e. such a layout cache can be only created if the machine that saved the document last time does not have the fonts needed by the document installed; and then the document is opened on an other machine which has those fonts.) (cherry picked from commit b5937112d4035fb9ffb472e1bf36567d9c78c820) Conflicts: sw/qa/extras/layout/layout.cxx Change-Id: I02ae9f63d0b4b5e9d014df53ed2cf21a04b15090 Reviewed-on: https://gerrit.libreoffice.org/60590 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-09-18Resolves: tdf#119860 missing block of code to set text positioningCaolán McNamara1-0/+84
Change-Id: Ia57fc61147179a92569918417692e44e11ad6061 Reviewed-on: https://gerrit.libreoffice.org/60647 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-09-18ofz#10395 Null-dereferenceCaolán McNamara1-5/+8
Change-Id: I7bde5987a51949d60174335327652186e0ad8998 Reviewed-on: https://gerrit.libreoffice.org/60559 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 07b3bfb125fae70e0ab796a929a4f2abe4937912) Reviewed-on: https://gerrit.libreoffice.org/60564 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-09-17tdf#119316 sfx2 store: no move on macOSMiklos Vajna1-3/+11
osl::FileStatus::getAttributes() and osl::File::setAttributes() doesn't preserve all the necessary file properties (at least "Hide extension" is not handled), so always copy on macOS instead. (cherry picked from commit 7823684cb6fbe752dc64300799c5d102f61e0b70) Change-Id: I529467cc3d432d04e593f936c13ed4656a18150c Reviewed-on: https://gerrit.libreoffice.org/60307 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-17tdf#119897: "Version " prefix is optionalMike Kaganski1-2/+2
Hopefully this fixes the problem, which is being incorrect version written for the font in MSI (1.0.0.0), and comparing with installed one (1.3), the font is removed and not reinstalled. Change-Id: Iee675e2c2b3f29c76e35dcf41bbcce9b6181bf62 Reviewed-on: https://gerrit.libreoffice.org/60548 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 38aae53a1004bb7393c81a98c7b370344613244e) Reviewed-on: https://gerrit.libreoffice.org/60556 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-17tdf#118203 Avoid endless recussion in MeasureObjectArmin Le Grand1-3/+3
Change-Id: I1e6fff80e7b6d36830f61387cc5245fc54877d95 Reviewed-on: https://gerrit.libreoffice.org/60546 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> (cherry picked from commit d357e50fa1734da0bf341dbd49fc0596011bdfe3) Reviewed-on: https://gerrit.libreoffice.org/60557 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-09-17SOSAW080: Derive SdrObjGroup from SdrObjListArmin Le Grand183-1160/+1331
Also simplify parent/child relationships, get rid of double data (SdrPage/Parent infos in SdrObjects, also in SdrObjList). This is all not needed - when a SdrObject is inserted to a SdrPage, get SdrPage by traveling over parents (no double info, member as soon as inserted, ...). More cleanups/reworks included, will need some more cleanups, too. Stabilizing: SetRectsDirty/DefaultStyleSheet Had to correct the SetRectsDirty stuff for 3D due to going down the hierarchy while the 2D implementation goes the other direction -> endless loops. Added special handling for 3D stuff for now (will be chnaged again when SnapRect is no longer needed at SdrObject level). Also had to adapt how the DefaultStyleSheet is set at incarnated SdrObjects - better: their properties. Since we now always have a SdrModel, it is possible to correctly initialize with the correct default StyleSheet from that SdrModel. This needs to be done after ForceDefaultAttributes and in a way that again deletes Items that are set in the StyleSheet. This leads to an error in CppunitTest_sd_import_tests where I checked tdf100491 - it is okay and thus I change the control instance of the imported, XML-dumped file. The less hard attributes, the better for Styles in general. Cleanup of comments for last two commits Corrected SvxShape::getParent() Needed to get the direct parent, so test for SdrObject first (to get SdrObjGroup/E3DScene), for SdrPage second Fixed CppunitTest_sc_subsequent_export_test Several problems arose. The used SdrCaptionObj was Cloned, but the clone not inserted to a SdrPage. This leads to not being able to access a UNO API imlementation of the SdrPage (SvxPage) on lower levels. It worked before due to SdrObject having a SdrPage* additionally to being added to a SdrPage - this is exactly the main cleanup this change does. Looked for why it is cloned, could see no reasons. The SdrCaptionObj exists during all im/export, not difference to other SdrObjects (that do not get cloned). It is not changed in any way. It *might* be to suppress a crash that happened due to UNO API Service emfio/emfio not being available in the UnitTest scenario. Interestingly it did not crash with the cloned SdrCaptionObj, but the Graphic exported was probably wrong. Fixed by no longer Cloning the SdrCaptionObj and adding emfio/emfio UNO API Service. d139f821a5b39535a3e7b9c6261df7e18f8ae8ac 910e7f4bc628a715fda7545dffaf3369d5e76ea0 ca1de01b723051e09ac37d7ec7bba978beea41c5 3a76da1471dfe75e69847f64a6a3519ad21c8c9c Change-Id: I986586e326b563acebf00d931a7084c6eb09e5f8 Reviewed-on: https://gerrit.libreoffice.org/54689 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> Reviewed-on: https://gerrit.libreoffice.org/60535 Tested-by: Jenkins
2018-09-16Update git submodulesMartin Srebotnjak1-0/+0
* Update translations from branch 'libreoffice-6-1' - Updated Slovenian translation Change-Id: I30ddc409c25c35a2204a3e5bf89fc1cf2b8cf761
2018-09-14Join the thread only if launch succeeded.Michael Meeks1-1/+1
Change-Id: Idee779cea587e11f6d0f7902182c9394e73d46eb Reviewed-on: https://gerrit.libreoffice.org/60488 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 6b12e4a9be9283951ac234692e79c9e00cd32654) Reviewed-on: https://gerrit.libreoffice.org/60501 Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-14tdf#108028 OOXML: Fix line breaking of chart titleBalazs Varga1-0/+1
With adding the "TextMaximumFrameWidth" property to the chart title's textbox property, it breaks chart titles longer then the chart width, as in OOXML reference implementation. LibreOffice previously distorted the text and squeezed the chart. This patch will fix it. Change-Id: Ic086d25b49e9c5cf9c6f2c79f141592749adc7d8 Reviewed-on: https://gerrit.libreoffice.org/59991 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 063e92004b65411dbee7fc12ab00c78aa9c69a86) Reviewed-on: https://gerrit.libreoffice.org/60305 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-09-14kde5backend.cxx: Fix inverted logic leading to invalid writeMichael Weghorn1-1/+1
Only write to 'pFakeArgv[2]' when 'aDisplay' is NON-empty. Otherwise, the 'pFakeArgv' array only has size 2 and the write is invalid. (Found by valgrind while looking at another issue.) Change-Id: I58aff6d25c8647bc6ef346af8ac09b0b0fc030b8 Reviewed-on: https://gerrit.libreoffice.org/60476 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 2fdafe62ef3959ec34e05daf312088a8f0534d9a) Reviewed-on: https://gerrit.libreoffice.org/60485 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-09-14tdf#119305 Chart created from fully selected sheet only targets header rowNoel Grandin1-1/+3
regression from commit 3acc5a2383f5b0458e3caf1505fe6b8ad7dc3fb0 tdf#69977 improve creation of large charts Change-Id: I09d02447b0e4691e98a44222608a3dc5edc95b0b Reviewed-on: https://gerrit.libreoffice.org/60318 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit aaa3c31ba79b1b3d335dcf55d72837a13411b45e) Reviewed-on: https://gerrit.libreoffice.org/60369 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-14Ensure fastparser thread is joined in case of exceptions.Michael Meeks1-1/+17
Change-Id: Ie0fb21776514a9a67e9fdff2ae856392cd711adb Reviewed-on: https://gerrit.libreoffice.org/60361 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit efa2681db1fb66e5f3677adff3a5e91ccba6b9ec) Reviewed-on: https://gerrit.libreoffice.org/60372 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-14tdf#119562 Fix export of AutoFit property of shapes to XLSXBalazs Varga3-1/+17
With this patch the "Resize shape to fit text" property (TextAutoGrowHeight) will be exported correctly to XLSX format. Change-Id: I488ceead452aef9096e7766f957de425c8486f85 Reviewed-on: https://gerrit.libreoffice.org/59778 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/60304 Reviewed-by: László Németh <nemeth@numbertext.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-09-14tdf#118500 Impress losing slide transition sound on savingSamuel Mehrbrodt1-28/+31
This reverts commit b223028d65d24ffcd8e27974c29c2744a5df6227. Change-Id: Iac12092a4f6b0edb3b6a5228ed17e7d0c1794357 Reviewed-on: https://gerrit.libreoffice.org/60391 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 61bc0d058dd95961761056a104ecd729ddfa4a82) Reviewed-on: https://gerrit.libreoffice.org/60399 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-09-14tdf#119793 Crash on redo of rectangle movement and textNoel Grandin1-4/+4
regression from commit be48eb2e82a3d8891ee84145567e2b89884f1fd6 return std::unique_ptr from SdrMakeOutliner Change-Id: Iec4421558ed29121973c87b9363da0303f71e203 Reviewed-on: https://gerrit.libreoffice.org/60317 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 4926b0f348dd1ddf170fe41df0cde4d426ab3b5f) Reviewed-on: https://gerrit.libreoffice.org/60441
2018-09-14tdf#118881: Fix HTML parsing for personasMuhammet Kara1-9/+9
This is just a band-aid to make personas feature work again. Change-Id: I80b54fe9a8ddc93d93744fcf2c7f739d81f6face Reviewed-on: https://gerrit.libreoffice.org/60432 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr> (cherry picked from commit e98ac43ec42ff398ad489d6719960d595f0327be) Reviewed-on: https://gerrit.libreoffice.org/60468 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-09-13tdf#119802 LibreOffice crashes when I save multiple times in a rowNoel Grandin1-1/+1
regression from commit c2452e52f644649723df10e3cd6bbd48d6bafb49 loplugin:useuniqueptr in SfxDispatcher_Impl Change-Id: Ia6e097c72e8571540c9cbd1512aedd85e4c2433e Reviewed-on: https://gerrit.libreoffice.org/60395 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 3778399872ad592b4416e54a154e8bcc02d73a2e) Reviewed-on: https://gerrit.libreoffice.org/60420
2018-09-12CJK preview text missing from format->characterCaolán McNamara1-25/+25
since... commit 16700331da2087bbb53c1774605cef2d0411206a Date: Wed Feb 21 17:51:19 2018 +0400 tdf#114768: Update default font list for Simplified Chinese Liberation Sans doesn't have any CJK glyphs in it Change-Id: I8c2822055ccabdf1fac2cf035a959015e5a33d33 Reviewed-on: https://gerrit.libreoffice.org/60400 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins
2018-09-12sync opcodes blacklisted for calc threading from masterLuboš Luňák1-0/+12
This makes the branch use the same blacklist, i.e. commits 4aecbe996349c7767ba3fb1e81db2ef6f94d39ba and fbd79a36ca8110e37434bb2eb5cc83e892710392. Change-Id: I85ae8e79ee5285f26a5594ad2fddd4a37284afd0 Reviewed-on: https://gerrit.libreoffice.org/60254 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins
2018-09-11tdf#109229: Set "TextBox" prop before filling textbox-related propsMike Kaganski3-5/+32
Otherwise those properties aren't set, and defaults are used Change-Id: Ib6671c019ff652ec5b59d9cbbf02a4e536a17817 Reviewed-on: https://gerrit.libreoffice.org/60267 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit c3422cd205d8da852f5c310b5f08028d6c4c5eb4) Reviewed-on: https://gerrit.libreoffice.org/60299 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-09-10Update git submodulesChristian Lohmaier1-0/+0
* Update translations from branch 'libreoffice-6-1' - update templates for 6.1.1 rc2 Change-Id: I0300893173264ca4eb17a1bc1eeb0ad4c8c51641
2018-09-10sw: tdf#119742 fix null pointer in SetCursorInHdFtJuergen Funk1-1/+2
In SwWrtShell::ChangeHeaderOrFooter the ChgPageDesc destroys the frames of the header, that's why GetCurrFrame returns null later. Change-Id: I26915237c8b455a5b8ad0bbd5c2de38537dfef08 Reviewed-on: https://gerrit.libreoffice.org/60130 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 77d075facaf4fc8954666ad541ed14f75d964fba) Reviewed-on: https://gerrit.libreoffice.org/60249 Tested-by: Jenkins
2018-09-10tdf#119381 sfx2 store: don't break symlink targetsMiklos Vajna2-5/+15
osl::File::move() would not follow symlinks for the target, so don't move the file in that case. (cherry picked from commit 72be5ac08aa963bdd42d2e56a62f43e69f728caa) Change-Id: I907e1ba8db04dad670c884ea0283947f953117da Reviewed-on: https://gerrit.libreoffice.org/59982 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-09-10tdf#114400 Import drawoo:fontwork-xyz attributesIlhan Yesil1-0/+15
Either the document has attributes in the old namespace or in the new, both will be imported. But export is still in the old namespace. Change-Id: I9f4d1ca0d8af37c13b513f99cc7d254c68867bb2 Reviewed-on: https://gerrit.libreoffice.org/59405 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 278e66488135c8fa2714520d056573c64ea803cf) Reviewed-on: https://gerrit.libreoffice.org/60206 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-09-07update creditsChristian Lohmaier1-1859/+1890
Change-Id: I946580363eb272f95694b000d6daa997e761285d (cherry picked from commit 01b19afeceb417e258df771677c65c36210a7c4d)
2018-09-07Update git submodulesChristian Lohmaier1-0/+0
* Update translations from branch 'libreoffice-6-1' - update translations for 6.1.1 rc2 Change-Id: I12d3b01f03cd4d9933da71b598b06214bf652013
2018-09-07tdf#119694: read embedded hsqldb file generated before 6.1Julien Nabet1-0/+1
Regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=ebb34571c19c5ac939fbf5aed2ab66ee18e298dc Thank you Drew Jensen for the bibisect! Change-Id: I9550f61709e8582a52554f578ef043c6551f09f0 Reviewed-on: https://gerrit.libreoffice.org/60117 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 4b5194bd1d0dd893720ec0b311ee215a3168219f) Reviewed-on: https://gerrit.libreoffice.org/60131 Tested-by: Jenkins
2018-09-07tdf#75341: fix condition to approve row (form)Julien Nabet1-3/+4
Considering rColInfo.nNullable != ColumnValue::NO_NULLS is ok to approve row isn't sufficient in the case the field is "Input required" in form. Change-Id: I27c57fe8ce5afac97eb0650f93703333c85f1421 Reviewed-on: https://gerrit.libreoffice.org/60109 (cherry picked from commit dbb444e4ed7c19a11733ce8438bbb6546d42f852) Reviewed-on: https://gerrit.libreoffice.org/60125 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins
2018-09-07tdf#91837: fix deinitializeControls (forms)Julien Nabet1-0/+1
m_bControlsInitialized wasn't ever reset to false Change-Id: I9f7bd6504ccaa0a41c9cb075c1ba33436f0f97dc Reviewed-on: https://gerrit.libreoffice.org/60059 (cherry picked from commit d80b3235cc106e17a0c10dea44e8afa8db724400) Reviewed-on: https://gerrit.libreoffice.org/60065 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2018-09-06Resolves: tdf#118850 disentangle the twisted wrong cell type vs format typeEike Rathke1-6/+12
Change-Id: Idb5267c9bc50e8844654c2f2cd0d123fcbb7aa12 Reviewed-on: https://gerrit.libreoffice.org/60026 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit ede27cf598ed2aef41b9552b2c787ef8331400fc) Reviewed-on: https://gerrit.libreoffice.org/60033 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-09-06tdf#117895: "Edit document properties before saving"...Henry Castro8-27/+152
option leaves just-saved document modified; changes are not saved Change-Id: Icad48fe1edcfb4c10c40f297326c23110144df53 Reviewed-on: https://gerrit.libreoffice.org/57211 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/59142 Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-06fix duplicate-mnemonic + no-labelled-byCaolán McNamara2-3/+1
Change-Id: I6d3637bc18317e0ed36c6b477cb8b46aba3c2abc Reviewed-on: https://gerrit.libreoffice.org/60023 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-06default focus colorset on popover gaining focusCaolán McNamara2-0/+7
Change-Id: Icb731c4c9544d754bb3ad88ecf15ffc04f216294 Reviewed-on: https://gerrit.libreoffice.org/60018 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-06tdf#119685 Fix infinite loop in gtk3_kde5 filepickerMichael Weghorn1-2/+2
Since 'string::find()' returns the position of the given character in the string and that was passed as the amount of characters to delete from the string, 'm_responseBuffer' would always be a string starting with a newline character afterwards, when this part of the code was reached. Subsequent calls to 'Gtk3KDE5FilePickerIpc::readResponseLine' therefore always returned an empty string and left 'm_responseBuffer' unchanged, resulting in the lambda function inside 'readResponse' in 'gtk3_kde5_filepicker_ipc.hxx' to loop infinitely. While at it, make a little more explicit that 'it' is of type 'size_t' here. Change-Id: I3b1c209f8307ab71465d9538a82616dff8656415 Reviewed-on: https://gerrit.libreoffice.org/60047 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 1f5698ba8b62e62999b0efb363916a91bdd54c94) Reviewed-on: https://gerrit.libreoffice.org/60067 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-09-06upgrade curl to 7.61.1Thorsten Behrens1-2/+2
Reviewed-on: https://gerrit.libreoffice.org/60042 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit d15d3ce697e88e72cec84b5b9b9619a37a8ae7ed) Conflicts: download.lst Change-Id: I4590f5f705dd08c63a1532ce5afa94a3af953f24 Reviewed-on: https://gerrit.libreoffice.org/60054 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-05Properly encode OAuth2 credentialsStephan Bergmann2-0/+60
Change-Id: Ic3edeae035262309e91fb01e3aca5c2f905bc3e5 Reviewed-on: https://gerrit.libreoffice.org/59986 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 33f7485dedea90e0f80c6348fa8ac5f27c5052e0) Reviewed-on: https://gerrit.libreoffice.org/60016 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-05-Werror=return-local-addr (-with-webdav=serf)Stephan Bergmann2-2/+2
Missing adaption after 2e142c0ee54744d35517f0b9c49a24302fb32d47 "tdf#114227: Add support for PAC to ucbhelper::InternetProxyDecider on Windows", found by <https://ci.libreoffice.org//job/lo_tb_random_config_linux/1456/>. Change-Id: I5093827035a9bbc31f3d8d2262e14df55fa610aa Reviewed-on: https://gerrit.libreoffice.org/59961 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 200f88c55842a3947eb3cbc5ce05b044eb25d338) Reviewed-on: https://gerrit.libreoffice.org/59981 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2018-09-05tdf#119152 Hide Text Direction dropdown from Columns tab by defaultGabor Kelemen1-1/+1
To restore behavior seen before 6.1 Change-Id: I7dd6b566b4964298a3e08c6c6dd663f87857d038 Reviewed-on: https://gerrit.libreoffice.org/59479 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 4f3dec1104a21d93d400c76ab0ae85083aec8492) Reviewed-on: https://gerrit.libreoffice.org/59955 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-09-05Resolves: tdf#119574 set specific width for style list widgetCaolán McNamara1-0/+4
so super wide style name doesn't break things Change-Id: I096eb1d3deeb935b43566b4d3ccb45d89ac2a56a Reviewed-on: https://gerrit.libreoffice.org/59929 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-09-04tdf#119344 fix libcmis build with boost 1.68rezso2-0/+16
Change-Id: I80d6ea8ecd001dc02b941c1eb8974c9244316045 Reviewed-on: https://gerrit.libreoffice.org/59958 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 3ef3569c4ae1c5319aff0664d52cbd8a8d42c909) Reviewed-on: https://gerrit.libreoffice.org/59971 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-09-04Resolves: tdf#118799 use spelling/search dialog as message dialog parentCaolán McNamara2-20/+16
when visible Change-Id: Id4d6df2a85aebd6887949f285e1a5ec1046dbf64 Reviewed-on: https://gerrit.libreoffice.org/59456 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 50c9ed67d29d6105f3907cb7a2fe3322685af53c) Reviewed-on: https://gerrit.libreoffice.org/59975 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-09-04ofz#10198 reset uncommitted fly stuff & pams before applying redliningCaolán McNamara1-0/+3
Change-Id: I2a2587ec4590926f7cffc2a4d58a22d9d5f19c99 Reviewed-on: https://gerrit.libreoffice.org/59947 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
2018-09-04ofz#10189 check container sizeCaolán McNamara1-2/+6
Change-Id: Ie99e3b082795989290799d057a99b1bcff94b161 Reviewed-on: https://gerrit.libreoffice.org/59912 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
2018-09-04upgrade to openssl 1.0.2pCaolán McNamara1-2/+2
Change-Id: Ifacf5dce39d830838b3cf57df760a04df97ade4b Reviewed-on: https://gerrit.libreoffice.org/59927 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-09-04Resolves: tdf#119533 reintroduce time rounding but cut, tdf#118800 follow-upEike Rathke1-12/+50
This is a combination of 2 commits. Resolves: tdf#119533 reintroduce time rounding but cut, tdf#118800 follow-up Regression from commit c69e7266916ac1b8917477fb4eccdb9098da5792 CommitDate: Thu Jul 19 14:01:30 2018 +0200 tdf#118800 fix rounding error in Calc function HOUR, MINUTE, SECOND. Rounding was only an error if it produced a value of a full day in seconds, or if it otherwise led to an inappropriately rounded-up individual value, but in general some rounding is necessary. Instead of omitting rounding completely, basically round to nanoseconds and then do not round individual hour,minute,second values but instead truncate to the next magnitude so 23:59:59.9999 gives 23h59m59s instead of 24h0m0s Reviewed-on: https://gerrit.libreoffice.org/59677 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 273b3e10eab70ebc084cb62568bd699fddfb376e) Shortcut small negative values to 0:0:0, tdf#119533 tdf#118800 follow-up ... instead of letting them end up as 24:0:0 Reviewed-on: https://gerrit.libreoffice.org/59699 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 98cb91686901dc0133c5c23dc5658d9623dbd436) 0212a2b422a931a24fd2748aa2826a5b60d2a397 Change-Id: I93df1aa54212c1b8816237c9467f270ed28a3f1f Reviewed-on: https://gerrit.libreoffice.org/59678 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-04Increase arbitrary sort elements limit from 100000 to two full columnsEike Rathke1-1/+3
The value 100000 already was in the year 2000 initial commit, probably some memory and performance constraints back then. At least one full column should be sortable, make it two so we don't bail out that early for functions like MODE() that can take multiple ranges. In fact maybe ScMatrix::IsSizeAllocatable() should be taken into account, which is much larger though and QuickSort() might not play well with it. Change-Id: I061abfd0f061c8df62c31468df744eb5dc7152be Reviewed-on: https://gerrit.libreoffice.org/59637 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit e8cb36fd6234270c8c31147db35cccab9c234529) Reviewed-on: https://gerrit.libreoffice.org/59660 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-04Use INPUTSTRING_PRECISION to enable input of fraction of secondEike Rathke1-2/+2
This got lost when SvNumberFormatter::INPUTSTRING_PRECISION was introduced but not all places changed using the previous hard coded number 300, so input of fraction of second in time clock and duration was either truncated or not available at all, already since commit 0ce0dd5863208500d8d4658f1f68f34e254ab015 CommitDate: Tue Dec 1 16:58:07 2009 -0500 #i46511# Fixed one bug where the standard percent format incorrectly got unlimited precision. Change-Id: I9e4dd867b07090db16b23639fd01fb2cebb3f5d0 Reviewed-on: https://gerrit.libreoffice.org/59815 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 73c200d7e5779b18ee1406b7fbd2000a8c901589) Reviewed-on: https://gerrit.libreoffice.org/59838 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-20 12:54:38 +0000