summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2018-04-18tdf#117021: fix datasource exampleJulien Nabet1-1/+1
Change-Id: I1e4112ab18e76eec4cb11fb4bc3a7cea67e7ae1d Reviewed-on: https://gerrit.libreoffice.org/53065 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-04-18NB Impress tabbed toolbar big updateandreas kainz1-1563/+10559
Change-Id: I4e0a6e3eb1f945daf2036bc1d009ae96d5a72802 Reviewed-on: https://gerrit.libreoffice.org/53072 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-04-18Resolves: tdf#117068 wrong parent for exception dialogCaolán McNamara3-4/+4
Change-Id: I51e6b32593f2e67585c6c45b0b1daefcf4860e20 Reviewed-on: https://gerrit.libreoffice.org/53067 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17tdf#117015 EMF+ Fix for displaying EMF+ files where GetDC is usedBartosz Kosiorek2-1/+10
With EMF+ Only mode, still the EMF records could be used for displaying objects, by using Get Device Context (GetDC). Files identified as EMF+ Only can contain both EMF+ records and EMF records. All EMF+ records are used to render the image. The EMF records that are part of the drawing are those preceded by a Get Device Context record. Unfortunately after finishing EMF drawing, the clip region was not reset. As a result records after EMF record was not displayed. With this patch, the issue was fixed by resetting clip region. Change-Id: I998b14e7c3b56a7711ba6a7bec08ec2097e0dfce Reviewed-on: https://gerrit.libreoffice.org/52897 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-04-17NB Implementation: sync impress label with writer/calcandreas kainz1-1/+10
Change-Id: I6d87ddc3520c74f776321329e39e7562c93ad6da Reviewed-on: https://gerrit.libreoffice.org/53060 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-04-17grab an early libetonyek-0.1.8 snapshotCaolán McNamara7-48/+43
Change-Id: Ib31a8cb75f4cebcaa974b95097270362b3b26aef Reviewed-on: https://gerrit.libreoffice.org/52689 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17Resolves: tdf#116928 dispatch hyperlink dialog new doc in idle callbackCaolán McNamara2-75/+106
collect up all the piece of data that the dispatch requires and launch it in an idle. So if a dialog appears its embedded mainloop will not return to body if the deleted SvxHyperlinkNewDocTp Change-Id: Ie978bc552c3b88dc11eae2ec49417cc8bd0f02bc Reviewed-on: https://gerrit.libreoffice.org/53056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17tdf#117034 check for runtime version check gtk_menu_popup_at_rectCaolán McNamara1-21/+24
Change-Id: I2386c2d8f7c6754b197df9216eed82e0152a35c8 Reviewed-on: https://gerrit.libreoffice.org/53045 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17Related: tdf#116928 set specific parent for document warning dialogCaolán McNamara4-9/+23
Change-Id: I827563c16a2ae59c698e1bfa82022a11f5256483 Reviewed-on: https://gerrit.libreoffice.org/53055 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17Fix typosAndrea Gelmini3-3/+3
Change-Id: I3423511c0d7a13bd28e9a808e0d634148b759643 Reviewed-on: https://gerrit.libreoffice.org/53057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-04-17More containsPreprocessingConditionalInclusion checking in loplugin:casttovoidStephan Bergmann1-0/+5
...to avoid false positive with --disable-dbgutil in SfxApplication ctor (sfx2/source/appl/app.cxx), which contains bool bOk = InitializeDde(); #ifdef DBG_UTIL ... #else (void)bOk; #endif Change-Id: I4de6322a848a9c6aea3057e4598b2161888dee6a Reviewed-on: https://gerrit.libreoffice.org/53051 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-17We don't build for i386 on macOS anywayTor Lillqvist1-20/+0
No no need to patch the Firebird build settings for i386. Change-Id: Ic187ff462325511a9a498e312f54350be7542366 Reviewed-on: https://gerrit.libreoffice.org/53054 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-04-17weld DropDownFieldDialogCaolán McNamara8-147/+185
Change-Id: I58ceb44f96d8ae3e3732b85eafd44c4d6eab42aa Reviewed-on: https://gerrit.libreoffice.org/53035 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17tdf#45904 Move _SheetSortDescriptor Java tests to C++Jens Carl9-267/+287
The C++ tests are now located in sheetsortdescriptor2.(hxx|cxx), because this is the latest implementation of the UNO API interface (SheetSortDescriptor2.idl). Change-Id: I5b11a38f6cd0473714c4d57ee92889bfd7605e83 Reviewed-on: https://gerrit.libreoffice.org/52930 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-04-17let's just run ResHookProc over everythingCaolán McNamara5-62/+102
Change-Id: I1c675ffbfd4737a6c618c2b4d548e27c1ec295b7 Reviewed-on: https://gerrit.libreoffice.org/53038 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17Updated coreStephan Bergmann1-0/+0
Project: help f4c54d3af32ca4c6d02afff71532dbf10147fd33 Include help2.js not help.js Otherwise, causes a ReferenceError: getParameterByName is not defined when loading <file:///.../instdir/help/index.html?swriter/.uno:HelpIndex?Language=en-US&System=UNIX&Version=6.1> in the browser. Change-Id: I13cdd36e44859a74c9a1b4e3b020fed2f56edda0 Reviewed-on: https://gerrit.libreoffice.org/53048 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-04-17Resolves: tdf#117057 use same style warning as elsewhereCaolán McNamara5-32/+13
Change-Id: I3072c7725d0769c0a4a1974664b1546ca3ee35ad Reviewed-on: https://gerrit.libreoffice.org/53036 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17No need to restrict optimization to -O1 levelTor Lillqvist1-2/+0
Works fine with -O2 as far as I see. At least with current Xcode. Change-Id: Id28e1bb905efffa3e3b548eb34f3455c8a021f63 Reviewed-on: https://gerrit.libreoffice.org/53041 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-04-17weld SwAuthenticationSettingsDialogCaolán McNamara2-186/+159
Change-Id: I60cb9bbc4c094cea909ecbe4365b37ae0d9a4f78 Reviewed-on: https://gerrit.libreoffice.org/53040 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17presumably Kernel is leakingCaolán McNamara2-3/+3
Change-Id: I3b6815b3ca7ec94021be9229ae320b86e86f5418 Reviewed-on: https://gerrit.libreoffice.org/53020 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17missing dialog parent for restart for language changeCaolán McNamara1-1/+1
Change-Id: I3f04519ad3fe35bcaa040934547d5b206184efbd Reviewed-on: https://gerrit.libreoffice.org/53039 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17Fix typoAndrea Gelmini1-1/+1
Change-Id: I4e6ace300ffc19c5586d1d0371a06fca36b81080 Reviewed-on: https://gerrit.libreoffice.org/52954 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-17Fix typosAndrea Gelmini8-11/+11
Change-Id: If89ec640901253121529c09aef4537c6b13cee1d Reviewed-on: https://gerrit.libreoffice.org/52280 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-17remove ImpBitmapNoel Grandin23-314/+120
it's not adding anything useful, just hold the underlying SalBitmap instead Change-Id: I54852707b2f8af99283b9c882a428a8a7a11c4cf Reviewed-on: https://gerrit.libreoffice.org/52955 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-17NB Implementation: show menubar in NBShortcuts everywhereandreas kainz2-1/+2
Change-Id: I4a34890c1db282a0db4ce332e0221113dedcd3d2 Reviewed-on: https://gerrit.libreoffice.org/53034 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-04-17coverity#1434889 Uncaught exceptionCaolán McNamara5-7/+12
and coverity#1401334 Uncaught exception Change-Id: Ib2fadd83068cc94c972f6312719081d5ac75d8ce
2018-04-17Only relevant whether mpTestEqualCondition is non-nullStephan Bergmann1-3/+3
...so change it from 'const bool*' to just 'bool' Change-Id: Ibc36058f2faab565162cd05f6e798ecaae094dc1 Reviewed-on: https://gerrit.libreoffice.org/52990 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-04-17coverity#1434893 Uninitialized pointer fieldCaolán McNamara1-12/+8
Change-Id: Idaa49b1abc0d50ab50eae35e0f4c015aeeedbd42 Reviewed-on: https://gerrit.libreoffice.org/53019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17coverity#1434900 Uninitialized scalar fieldCaolán McNamara1-1/+2
Change-Id: Ia4758d8e1fb50d25d8efeb9e3e1950e47bf3401c Reviewed-on: https://gerrit.libreoffice.org/53028 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17tdf#116725: justify selection to handle right-to-left selectionsMike Kaganski1-10/+11
Change-Id: I6298a87170236059ff08a1f891ead21236be663a Reviewed-on: https://gerrit.libreoffice.org/52979 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-04-17ofz#7729 Null-dereference READCaolán McNamara1-5/+7
Change-Id: I223f4f7fd622822b42d8e7cb342d451c54d6dcbd Reviewed-on: https://gerrit.libreoffice.org/53017 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17tdf#116812: Revert "The mfFontScale[n] is always 1.0"Khaled Hosny3-11/+43
This reverts commit 1b7e788eb3bf9cbe56ed5cc4a3fa7fa5e70ac40a and followup commit 843c6d6eec95b99e867c28ab27860215d5d72b37. Change-Id: I42d1ab76778466db356f0597c90e1afc2dc9997d Reviewed-on: https://gerrit.libreoffice.org/53013 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2018-04-17Enable new Help to be installed as extensionOlivier Hallot1-7/+92
This patch enables the new help to be installed as an extension The extension must match the locale and LibreOffice version Extension id must be <locale>.help.libreoffice.org Version must match product version Help extension can be packed as Uno package from new help offline build (--with-help=html) To test the patch, use the en-US help in uno package format available in https://helponline.libreoffice.org/Help_en-US_6.1.oxt (To make it distinct from other help installations, the headings paragraphs are in red.) Change-Id: I2ff9eb94ef932c29ff7a93ce0241837213b25f2f Reviewed-on: https://gerrit.libreoffice.org/52700 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-04-17ofz#7671 Undefined-shiftCaolán McNamara1-1/+1
Change-Id: I84c6e6a3bb97d9949e9833adf14edf6bb89fe073 Reviewed-on: https://gerrit.libreoffice.org/53018 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17tdf#117017 Make modifier keys not trigger the InputChanged handlerMaxim Monastirsky1-0/+4
Change-Id: Ib05883688ef4143c0b53871c4336920dde6f91cc Reviewed-on: https://gerrit.libreoffice.org/52924 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-04-17tdf#116821 Keep row/column buttons enabled even when insert impossibleMaxim Monastirsky2-4/+0
So other commands included in these buttons (like delete or set height/ width), could still be used. Change-Id: If9e96116aebf73b2d20fb8d63ee67da3d17e3d9f Reviewed-on: https://gerrit.libreoffice.org/52909 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-04-17weld SwFieldInputDlgCaolán McNamara11-168/+140
and GetWindowState/SetWindowState are unused as it turns out Change-Id: Id1c5dad151e1f3c94189b7bca1a7cf335613d3bd Reviewed-on: https://gerrit.libreoffice.org/53001 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17tdf#100715 Slide transition sound: Remember remember last folderSamuel Mehrbrodt6-14/+34
Change-Id: I37bfb088a167464cdbd93a1f993a8161d12b379a Reviewed-on: https://gerrit.libreoffice.org/26937 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-04-17weld SwMultiTOXMarkDlgCaolán McNamara8-55/+102
Change-Id: Idff6120f0a04bd94ec8402ae02daa9599f133698 Reviewed-on: https://gerrit.libreoffice.org/53004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17weld SwJavaEditDialogCaolán McNamara7-279/+269
Change-Id: I409e66ed7446ad56933bb806093aa7f7b1d62a4e Reviewed-on: https://gerrit.libreoffice.org/53000 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17Simplify calls to Menu::CheckItemMuhammet Kara12-40/+46
in cui, dbaccess, vcl, sc, sd Change-Id: I328d81cf6cd5a7e31fb21a758e4b2670e7df1b91 Reviewed-on: https://gerrit.libreoffice.org/52797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-04-17move the ImpBitmap::GetBitCount logic up to BitmapNoel Grandin2-4/+6
in preparation for removing ImpBitmap Change-Id: I1ca76c645a8e988f6cd9be8a01b0d2853f6d6750 Reviewed-on: https://gerrit.libreoffice.org/53014 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-17remove no longer necessary operator new/delete overridesNoel Grandin22-191/+20
and use "using" statements for the places where the overrides were resolving ambiguities Change-Id: Icb1d1a41f19e00f28a19947aa2c40bd5778fff94 Reviewed-on: https://gerrit.libreoffice.org/52993 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-17tdf#42949 Remove unnecessary localization headers from swGabor Kelemen58-63/+0
Found by searching for the header names and the localization function: git grep -l -e \<strings.hrc\> sw | xargs grep -c -e SwResId -e StartProgress -e GetResource | grep :0$ | grep -v /pch Change-Id: I041a4e8b4c4cc7414f83bd08e64a1ff921244b44 Reviewed-on: https://gerrit.libreoffice.org/52919 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-17tdf#116848 sw, sections in tables: no split in headers or footersMiklos Vajna3-1/+13
The motivation for split section-in-tables was multiple pages, so disabling it for headers/footers is not a problem, and fixes the layout loop. Change-Id: I3e13690f6e6b50c35417f8a4f7886fd0befe7962 Reviewed-on: https://gerrit.libreoffice.org/53006 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-17tdf#115600 Display messages in Findbar for Text Frame, Graphics, OLEJim Raykowski1-0/+10
...object, Drawing, and Control navigation Change-Id: Ic9809e60ae18179f0ea36a4e3c61d09aea3c2929 Reviewed-on: https://gerrit.libreoffice.org/52935 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-04-17Set parent window for print dialogSamuel Mehrbrodt1-1/+2
In embedded LO this dialog sometimes shows up in background. Change-Id: I9b7f423aaa6b2bbe915398287a5f3b955af930b4 Reviewed-on: https://gerrit.libreoffice.org/52962 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-04-17tdf#100726 - Improve readability of OUString concatanationsGökhan Gurbetoğlu5-110/+105
Change-Id: I3ba75dbe6754b8138f61e223387832a6fb53c1c5 Reviewed-on: https://gerrit.libreoffice.org/52752 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-17cppcheck: identicalInnerCondition in scJochen Nitschke4-13/+6
and remove a related known condition dpcache.cxx Change-Id: I6069849c33ea03eff61a55eb790ce6a8aad3d915 Reviewed-on: https://gerrit.libreoffice.org/53005 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-17cppcheck - fix variableScope in some filesGökhan Gurbetoğlu4-13/+9
Reduced the scope of some variables in source. Change-Id: Ib3b521ca5df8b9b254b51eab5f1d7040d6cfd846 Reviewed-on: https://gerrit.libreoffice.org/52974 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>