summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2018-06-12libnumbertext: update to 1.0 beta 3László Németh4-5/+9
– new Bulgarian and Icelandic language support – fixes of language data based on libreoffice-l10n's patches and feedback (see ChangeLog in the external package for details) Reviewed-on: https://gerrit.libreoffice.org/54936 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry-picked from the commit ae50762741a967a20bae9f39f1f8f7aa7dd4e763) Change-Id: I98598747c8b4e8e7fba380998c6ebbc1f63fef2e Reviewed-on: https://gerrit.libreoffice.org/55642 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-06-12rhbz#1589029 tdf#93789 impress not showing text highlight in presentation modeCaolán McNamara4-21/+119
the text hightlighting feature was implemented backed on to the vcl TextFillColor feature. TextFillColor fills the background of the bounds of the text with that color Likely either the same problem or similar as tdf#93789 Change-Id: Iace62cedc49e5f5844ac35d3caa23249b6cb4bc1 Reviewed-on: https://gerrit.libreoffice.org/55634 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-12Updated coreGabor Kelemen1-0/+0
Project: help 7623916541246501c8c797ab9b6decece8ae230a tdf#118115 Fix bookmarks and ahelps on Signature Line pages Change-Id: I26de5e74067ffadd0a9ba11234bf1f2125d0c169 Reviewed-on: https://gerrit.libreoffice.org/55652 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com> Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> (cherry picked from commit 7b320d053840e707047969943e94370634cbe93a) Reviewed-on: https://gerrit.libreoffice.org/55659
2018-06-12Colibre 32px size supportandreas kainz69-5/+35
Change-Id: Ia6389b9115b773c1887e34161dfaf803cb575b73 Reviewed-on: https://gerrit.libreoffice.org/55651 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-06-12Fix tdf#117410 - UI: Settings in PDF Options not remembered...Matteo Casalin1-1/+2
for next export Change-Id: I6f066c81d96595a4560f5bb9e148001b004b38f0 (cherry picked from commit 85613aa81a885488f99ed038f2254ddb0c8a1037) Reviewed-on: https://gerrit.libreoffice.org/55647 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-06-12Karasa Jaga: Change some legacy Galaxy icons & update shape iconsRizal Muttaqin457-9/+12
Change-Id: Id5f84e58ef8d4e2239eaf3c6678a9f7660b4e6c6 Reviewed-on: https://gerrit.libreoffice.org/55641 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com> (cherry picked from commit 90e4c55d01637178418c33ffe818263114a53374) Reviewed-on: https://gerrit.libreoffice.org/55649
2018-06-11Colibre 32px size supportandreas kainz28-0/+14
Change-Id: I52b776bce09e2fe3204782daf087840ae11de874 Reviewed-on: https://gerrit.libreoffice.org/55631 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-06-11Derive NativeNumberXmlAttributes2 from NativeNumberXmlAttributes, tdf#115007 ↵Eike Rathke5-33/+55
follow-up Also ensure that transliteration-spellout and (transliteration-format,transliteration-style) are mutually exclusive and transliteration-spellout is only written if ODF version is >1.2, namespace 'loext' for 1.2 with extensions and namespace 'number' in anticipation of ODF 1.3 (may need to be adapted). Change-Id: I371dee8883ecb0d4638510c92b4bf59acd09f636 Reviewed-on: https://gerrit.libreoffice.org/55491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 807d4382cb021d2ac3ea99d6757a7b368a32941d) Reviewed-on: https://gerrit.libreoffice.org/55626 Tested-by: Eike Rathke <erack@redhat.com> Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2018-06-11tdf#115007: add import/export to NatNum12 (spell out numbers,László Németh11-26/+142
dates and money amounts, supporting all the XNumberText/libnumbertext formatting codes, for example "ordinal", "ordinal-number", "ordinal-feminine", etc., and ISO 4217 currency codes, also their possible combinations. NatNum12 formatting codes are stored by using the newly introduced (yet, loext:)transliteration-spellout attribute. creator-initials also added to token list Change-Id: I20f93c9d16778f142067a56d53b336d0acbe2d92 Reviewed-on: https://gerrit.libreoffice.org/54673 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 32f1c56d8ff5e6f87dbcf086fd3743d6d36182bc) Reviewed-on: https://gerrit.libreoffice.org/55625 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: László Németh <nemeth@numbertext.org>
2018-06-11tdf#115007: Use [NatNum12 params...] syntaxMike Kaganski13-58/+237
This allows using all the libnumbertext library functions. [NatNum12] gives cardinal number names (one, two, three, ...) [NatNum12 ordinal] gives ordinal number names (first, second, third, ...) [NatNum12 ordinal-number] gives ordinal indicators (1st, 2nd, 3rd, ...) [NatNum12 money USD][$-409] gives formal English (US) money text ... etc (see numbertext.org for syntax). Change-Id: I16dbb44d8d4bdb82a1b950de6d438c8311b554ff Reviewed-on: https://gerrit.libreoffice.org/54366 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 90d233b0311a208967a3e264820e00395bf057fb) Reviewed-on: https://gerrit.libreoffice.org/55624 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: László Németh <nemeth@numbertext.org>
2018-06-11Add unit test for NatNum12 decimals spell-outEike Rathke1-0/+3
Change-Id: I31c84eb2267b4978f110a4f38cbf4d2377d59400 (cherry picked from commit e025c561d75c6b1e04d3df0ba90b38d3801241ac) Reviewed-on: https://gerrit.libreoffice.org/55623 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: Eike Rathke <erack@redhat.com>
2018-06-11Properly decompose vnd.sun.star.pkg URLStephan Bergmann2-8/+56
When the URL encoded in the vnd.sun.star.pkg URL's authority contains a "@" (e.g., because it is a file URL denoting a pathname containging a "@" in one of the segments), that "@" need not be encoded (cf. the grammar at the top of tools/source/fsys/urlobj.cxx) and INetURLObject::GetHost would only return the part following the "@". When constructing sBaseURI in ODatabaseContext::loadObjectFromURL (dbaccess/source/core/dataaccess/databasecontext.cxx), the path part shall obviously not be decoded (but which the original code erroneously did). However, when obtaining sStreamRelPath in ODBFilter::implImport (dbaccess/source/filter/xml/xmlfilter.cxx), it isn't clear to me whether the path should be decoded, so I left that in (and added a TODO). (Caused `make CppunitTest_sw_uiwriter CPPUNIT_TEST_NAME=SwUiWriterTest::testEmbeddedDataSource` to fail when SRCDIR is such a pathname containing a "@" in one of the segments.) Change-Id: I6ffd842f3f3d37d2682e7cf14399fb3dbfa0a2aa Reviewed-on: https://gerrit.libreoffice.org/55286 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit e310ac4ab942feb014f3bb5bc4519dcf966b47fc) Reviewed-on: https://gerrit.libreoffice.org/55633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-06-11par2script: don't bother removing already removed parts of argumentsChristian Lohmaier1-2/+0
the s/\@// conflicts with jenkins default directory naming for concurrent builds and is wrong at this place/in this form: 0ce067c1fc334680a7d99e573ae8c2f3e623b645 already changed the format of the parameter from @listfile to @@listfile, so stripping a single @ at the front won't help at all. Furthermore the stripping already was added to the par2script/parameters.pm earlier, so the worker functions don't need to deal with transforming commandline arguments. Change-Id: Ic55b8cda3cd114dfc5cb7ded6d53174cd8283af9 Reviewed-on: https://gerrit.libreoffice.org/55196 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 6fbcb4f1ad6bbcaac1fade0abf6bbe8215c1f4ab) Reviewed-on: https://gerrit.libreoffice.org/55632
2018-06-11tdf#117984 Make MapMode thread-safeArmin Le Grand1-1/+3
...using o3tl::ThreadSafeRefCountingPolicy due to being used indirectly (~Bitmap) in parallelized 3D renderer Change-Id: Ia5eab219c6844570a04c83f71cca5e7b7da4326d Reviewed-on: https://gerrit.libreoffice.org/55365 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> (cherry picked from commit d84517a171a17dfa12f25ad4305a06b20f3b7c76) Reviewed-on: https://gerrit.libreoffice.org/55411 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-11tdf#118068 InsertionIndicator should be temporaryCaolán McNamara1-0/+4
its original use is during a drag/drop operation so its expected to be in use just for a temporary scope, so End after Start Change-Id: I3efdc4079ef7e1466b49e027fed0698715b5fd58 Reviewed-on: https://gerrit.libreoffice.org/55620 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-11Add overloaded read/send funcs for uint64_t (conditionally)Katarina Behrens1-0/+12
otherwise build fails on 32bit platforms as multiple matching overloaded func are found. Thanks _rene_ and mst_ for helping me to figure this out Change-Id: Ief4571ad735ad4efea9ddc70daea45885e5954c7 Reviewed-on: https://gerrit.libreoffice.org/55474 Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Rene Engelhard <rene@debian.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit ca4dede186183ca760013ad1885947d68bae02f4) Reviewed-on: https://gerrit.libreoffice.org/55628
2018-06-11menubar: framework/startpage sync help menubar entryandreas kainz1-1/+2
Change-Id: I8895c79a65750330600ebf0be19d184736fe2c1c Reviewed-on: https://gerrit.libreoffice.org/55543 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 878785291da91d74cb13f005ce5287bd9ead8b79) Reviewed-on: https://gerrit.libreoffice.org/55601 Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-06-11tdf#102907 selection indicator missing on vertical textNoel Grandin1-2/+4
regression from commit 79800559268c636740fec69018b1f99f047c3f93 convert MT_ constants to scoped enum The original code used bit-wise operations and some clever constant values, which I did not convert correctly Change-Id: I2fcd9e2584638d4a690773ef3f178415153b8b19 Reviewed-on: https://gerrit.libreoffice.org/55596 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 16b1d80070142e2ffecaba64b62dbe836daafb4f) Reviewed-on: https://gerrit.libreoffice.org/55598
2018-06-11weld SwTextFlowPageCaolán McNamara4-374/+287
Change-Id: I9f182874551e7c1e32b2a00e72f7c3a8f1356fc3 Reviewed-on: https://gerrit.libreoffice.org/55566 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-10support comboboxtext id valuesCaolán McNamara3-9/+28
Change-Id: Ibebdaab5b073a55cb646687890bc16d5f55c0341 Reviewed-on: https://gerrit.libreoffice.org/55487 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-10fix CppunitTest_dbaccess_hsqlbinary_importRene Engelhard1-1/+2
at least with system-hsqldb. add missing connectivity/source/drivers/hsqldb/hsqldb to gb_CppunitTest_use_components Change-Id: I6e845dadd67276b137734f68ba922a1d5890c809 Reviewed-on: https://gerrit.libreoffice.org/55551 Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Rene Engelhard <rene@debian.org> (cherry picked from commit b7279359107ccafc691c198e94aa4e990b6300dc) Reviewed-on: https://gerrit.libreoffice.org/55559
2018-06-10Fix build with GLM 0.9.9.0, tdf#118070Louis Sautier1-0/+6
One of the test files was forgotten in 953c4add8fd76d88f49a81ae4c21a1fdcc007e57 Change-Id: I0315433c688ff7edb2ba599bbef203cac9de3022 Reviewed-on: https://gerrit.libreoffice.org/55554 Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Rene Engelhard <rene@debian.org> (cherry picked from commit 5f1bf6598b5725ad1e50ae9f7ec7524cc8a834fa) Reviewed-on: https://gerrit.libreoffice.org/55556
2018-06-09properly go to next row when walking mdds containerLuboš Luňák2-2/+2
Since only elements from nOffset up to nEnd are iterated, then the difference is not just nEnd but (nEnd-nOffset). Without this, ScColumn::HandleRefArrayForParallelism() skips some cells and e.g. fdo#77750-1 asserts in ScFormulaCell::MaybeInterpret(). Change-Id: I4d595e9faff51f08bf074d549185c24aa00d8a45 Reviewed-on: https://gerrit.libreoffice.org/55488 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us> (cherry picked from commit cbe3ae1894800a5fddbd598403be54f9495cc964) Reviewed-on: https://gerrit.libreoffice.org/55502 Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Luboš Luňák <l.lunak@collabora.com>
2018-06-08tdf#118037 PPT import: fix lost crop of graphicMiklos Vajna3-0/+24
Regression from commit b11188835d3b87cd9d2a8cdb3da204cfda5d3e6e (DOC import: lazy-read images, 2018-04-20). (cherry picked from commit 11d542352e1088a2c870b0e73e14e10266276483) Change-Id: Ie2155c971d94153352a9372a9795cbb9d820dd40 Reviewed-on: https://gerrit.libreoffice.org/55468 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-08sync tristate/inconsistent featureCaolán McNamara2-0/+6
Change-Id: Id1107f4fb1f51f377ad546f9b673f9037fee1538 Reviewed-on: https://gerrit.libreoffice.org/55469 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-08Fix CppunitTest_xmlsecurity_signing with system-xmlsec 1.2.26Miklos Vajna1-14/+37
Swap the order of the default and custom callback registration, since the order of lookup is now reversed since <https://github.com/lsh123/xmlsec/commit/968646fb9b8428174a112fce2f08b1ec89d0ed97>. Thanks Tomas Chvatal for reporting this. (cherry picked from commit 576f899811a22e83b6fb6a120c8da303b1f4cac1) xmlsecurity: check for the libxmlsec version runtime, not build-time For the general benefit of --with-system-xmlsec usage scenarios (where LO may be built against an old version of xmlsec and run against a new one). (cherry picked from commit bc4e43dd926bbe6f5315b5c372770ac8c7222177) Change-Id: I60a347454701a679db4ccd8924a723a236d5edff Reviewed-on: https://gerrit.libreoffice.org/55462 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-08solenv/flatpak-manifest.in: Properly disable debug informationStephan Bergmann2-2/+1
...see 02248e9e191f798f96218a0c4d281f99e15bea31 "solenv/flatpak-manifest.in: Disable debug information again, for now" commit message Change-Id: I4a9f8c547a50e8a8c83b5f96768949867aa4bb7b Reviewed-on: https://gerrit.libreoffice.org/55453 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit a7db7f3ce699a46ce7e9eafdf4388a3213264464) Reviewed-on: https://gerrit.libreoffice.org/55463
2018-06-08Karasa Jaga: Update curved line and spacing iconsRizal Muttaqin28-0/+1
Change-Id: Id8565b07e612bff77009322a9b82a7800d748385 Reviewed-on: https://gerrit.libreoffice.org/55395 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-06-07Merge in Flatpak improvementsStephan Bergmann1-0/+15
...from <https://github.com/flathub/org.libreoffice.LibreOffice/>: commit 0242fa00493c0521d75c60cc4987fb8c7f3abeb1 Author: Robert McQueen <rob@endlessm.com> Date: Tue May 15 11:08:30 2018 +0100 add missing share of dconf runtime dir This breaks dconf change notifications, including the GSettings used for Gtk+ themes. Could also cause other weird settings problems. https://github.com/flathub/org.libreoffice.LibreOffice/issues/31 commit 800d0d553fec6bd093f813cb4aa2f10dcbe10aee Author: Stephan Bergmann <sbergman@redhat.com> Date: Thu May 31 18:02:13 2018 +0200 Re-enable GIO support ...that was inadvertently lost when switching from the GNOME to the freedesktop.org runtime. For one, LO configure's --disable-gtk erroneously implied --disable-gio, even under --enable-gtk3. For another, gvfs is missing from the freedesktop.org runtime; the recipe is copied from <https://gitlab.gnome.org/GNOME/gnome-sdk-images/blob/gnome-3-28/ org.gnome.Sdk.json.in#L536>. This hopefully fixes <https://github.com/flathub/org.libreoffice.LibreOffice/issues/41> "Again unable to open files on network shares". Change-Id: Ib0a3680dc4eb2595eb2d8b0bb30c54082651686c Reviewed-on: https://gerrit.libreoffice.org/55431 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 67aaa98600269e6b8fa631146c3649a261369471) Reviewed-on: https://gerrit.libreoffice.org/55438
2018-06-07Missing dependency on directoryStephan Bergmann1-1/+2
Change-Id: Icaf0f54d3487c8286486d265ebb9790f6b9e0910 Reviewed-on: https://gerrit.libreoffice.org/55419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 8ab697786e29865953c3a725256f3b1eb1160ea6) Reviewed-on: https://gerrit.libreoffice.org/55437
2018-06-07Updated coreOlivier Hallot1-0/+0
Project: help dc25f00e499d4ece26fab2e17427583e99e45adf Better use of embed for similar contents Save translation work for 'IFS functions Change-Id: I7e9c9fa9d84419f4faf28622be818eb7f2fe6d2a Reviewed-on: https://gerrit.libreoffice.org/55211 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> (cherry picked from commit 3e5bd012ebefd160ff4d7070b6e1794e44d91ae5) Reviewed-on: https://gerrit.libreoffice.org/55448 Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-06-07Updated coreOlivier Hallot1-0/+0
Project: help 8ae83bb638d652d80fef5b449c43cc6f577cfa24 tdf#117933 help pages for MAXIFS,MINIFS Change-Id: Ib0b27e4f00468b33a9a112ac0dc0967750570b18 Reviewed-on: https://gerrit.libreoffice.org/55144 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Sophia Schröder <sophia.schroeder@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-06-07tdf#118042: fix crash on Target box in Hyperlink dialogJulien Nabet1-1/+1
Change-Id: I493faf6e94c1a130b2bd88b6b8c33d6deb6bc268 Reviewed-on: https://gerrit.libreoffice.org/55443 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-07Updated coreSophia Schröder1-0/+0
Project: help 156af0219ea25704b386d6c16dca7e1ce8386995 Cleanups and improvements Help files in scalc/00/ Change-Id: I55ffb4961fb5614f75fbc3e71dd50b461dff17de Reviewed-on: https://gerrit.libreoffice.org/54603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 3765355e41d02ee3e5f64ef6ece336641553e7c7) Reviewed-on: https://gerrit.libreoffice.org/55435 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-06-07Updated coreSophia Schröder1-0/+0
Project: help 6d75ce4e4c15dfd0ef135de19977389508d95b8a Try to correct some visual glitches in online help Change-Id: I6b5cf5c95b01c0ba6be259d93425b7349df7578f Reviewed-on: https://gerrit.libreoffice.org/55154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> (cherry picked from commit 83d31a088aac0ed11189afb26d818f7fb56c9b2e) Reviewed-on: https://gerrit.libreoffice.org/55433 Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-06-07Updated coreAdolfo Jayme Barrientos1-0/+0
Project: help 98fba5b275bf5acd73f875109b4bf6d0b5f170e5 tdf#94121 Give code paragraphs a different background, again The old wikihelp had this, but this time it won’t look as tawdry. Change-Id: I709b94c512cb15d6c1b5ef5b76b9e1bb13b6f09b Reviewed-on: https://gerrit.libreoffice.org/55301 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> (cherry picked from commit 1b112c0bedae14d3c242d8662d16230acf8c333e) Reviewed-on: https://gerrit.libreoffice.org/55432 Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-06-07Updated coreOlivier Hallot1-0/+0
Project: help b372425faaa181a49305cd0d7487ce72226eff1c Fix default cases in switches Change-Id: I40f6c8e5a6fd0a0ff1d3e6205de449f14598212b Reviewed-on: https://gerrit.libreoffice.org/55108 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-06-07weld SwFormatTablePageCaolán McNamara7-384/+611
Change-Id: Ia82fdd5666a4a59cf4e1867d295ecb1d336e10a2 Reviewed-on: https://gerrit.libreoffice.org/55424 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-07vcl: refresh font cache only on real changeAshod Nakashian4-7/+8
GTK3 emits way too many style-updated, which triggers font cache updates. The avoidance of unecessary font cache updates was first implemented in 29c55564. Unfortuantely, it seems that the current font-options was never set as last-seen font-options, so still to many fonts-changed were emitted Change-Id: I01a47d4d7fb033e335b1a49ffa6e1bb98f7fd28d Reviewed-on: https://gerrit.libreoffice.org/55420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-07Update Flatpak to OpenJDK10Stephan Bergmann2-3/+3
see <https://github.com/flathub/org.libreoffice.LibreOffice/issues/42> "OpenJDK 10 is now available". Change-Id: Iaae9d22d91d984a5c11eee26bd05ab7d328d7a5b Reviewed-on: https://gerrit.libreoffice.org/55422 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 930cb22f75c672c2fa3a4153094df4dd3a71cb7f) Reviewed-on: https://gerrit.libreoffice.org/55428
2018-06-07tdf#116916 - Icon themes missing on LibreOffice Vanilla from macOS appstoreheiko tietze3-11/+32
Update of blacklist for $WITH_THEMES Fallback to Tango for ancient/unknown DE, Colibre only on Windows MPL vs. non-MPL on macOS Change-Id: Ibeefbaefae5a8e62e973bcb8cddd53845f96b67d Reviewed-on: https://gerrit.libreoffice.org/55295 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/54794 Reviewed-on: https://gerrit.libreoffice.org/55396
2018-06-07tdf#117824 switch embedded database storage away from doc on revokeCaolán McNamara1-0/+20
otherwise the database document still has the embedded storage open when the attempt to remove the storage is made Change-Id: Ie313923b969bdbc53b27b00e379ac20240ffb6e3 Reviewed-on: https://gerrit.libreoffice.org/55388 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit a432a2e481baffa77e6f25584efbfbb3b68bc9a6) Reviewed-on: https://gerrit.libreoffice.org/55406 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2018-06-07tdf#117949 Use small overlap for SVG gradient representationArmin Le Grand1-2/+9
Change-Id: Idd55df31aa87cc40dbb15001479cdc79e918ac19 Reviewed-on: https://gerrit.libreoffice.org/55376 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> (cherry picked from commit aa5d7477e8e1e4bcd0e56496e745c3dc3b05c369) Reviewed-on: https://gerrit.libreoffice.org/55398
2018-06-07Revert "tdf#116916 - Icon themes missing on LibreOffice Vanilla from macOS ↵Heiko Tietze3-39/+18
appstore" This reverts commit 0550189c28cd759c41b8a048a3f667ae12560c5e. Change-Id: Id02b5bef9e82ed474a718d57ea3e2159855283b6 Reviewed-on: https://gerrit.libreoffice.org/55369 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-06-06tdf#116552 restore copy on focus and jump focus to sourceCaolán McNamara4-0/+29
This is surely an utter abuse of focus and an a11y disaster, but it used to work this way. Change-Id: I265a2bafbc2cdd17ff4a5b7c2805def63c510d5c Reviewed-on: https://gerrit.libreoffice.org/55374 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-06weld SwSectionIndentTabPageCaolán McNamara9-83/+346
Change-Id: I961686c1257f0d85686df06aa7c73c324d0f70b8 Reviewed-on: https://gerrit.libreoffice.org/55389 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-06blacklist ocExternal for calc's threaded calculationsLuboš Luňák1-1/+2
Opcode ocExternal is used for functions implemented as UNO calls, which has a number of problems: - ooo#118213-2 contains GETEOMONTH(), which maps to ocExternal, which calls AnalysisAddIn::getEomonth() in scaddins, which ends up calling ScModelObj::getPropertyValue(), which deadlocks on SolarMutex - it uses ScUnoAddInCollection class, which uses delayed initialization (even though it's created on-demand), which is not thread-safe; however, it seems that the initialization is generally done already while loading a file, so this is possibly in practice safe - who knows what all kinds of race conditions there are in all the functions this may call via UNO Change-Id: I80c4264102b8bc492853852c2c12e5cd2a8ea99e Reviewed-on: https://gerrit.libreoffice.org/55382 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit abb19edc79bd7d96827214d3b49f80e270e1c0b7) Reviewed-on: https://gerrit.libreoffice.org/55390 Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Luboš Luňák <l.lunak@collabora.com>
2018-06-06Updated coreStephan Bergmann1-0/+0
Project: help 228048839b6df667fbe9f78bba5a1f7df5835180 (Partially) fix --with-help=html dependencies on .xhp files There are three rules in helpcontent2/CustomTarget_html.mk that process (with XSLT) all or some of the .xhp files in the helpcontent2/source/text/ tree (for en-US; or their translations in the workdir/HelpTranslatePartTarget/*/helpcontent2/source/text/ trees for other languages). Lists of all those .xhp files are defined in helpcontent2/AllLangHelp_*.mk (with gb_AllLangHelp_add_helpfiles), but the code in helpcontent2/CustomTarget_html.mk used `find` to assemble the relevant lists. That has two issues (at least for the en-US case operating on the untranslated helpcontent2/source/text/ files): For one, if the content of those .xhp files changes, the relevant XSLT processing is not re-run. For another, if .xhp files are added to or removed from the lists in helpcontent2/AllLangHelp_*.mk, the relevant XSLT processeing is not re-run, either. For the processing of translated .xhp files, there were already dependencies on those translated files in place. I assume (but have not really proved it) that those dependencies are already sufficient to cover both of the above issues. That only leaves the en-US case, operating on the untranslated files. The lists of .xhp files as defined in helpcontent2/AllLangHelp_*.mk (with "*" ranging over the various "modules": sbasic, scalc, schart, etc.) are now made available in gb_AllLangHelp_*_HELPFILES variables. The contents of those variables is used instead of `find` to pass the relevant .xhp files to the XSLT processings. (Needing some RESPONSEFILE and `xargs -n 1` boilerplate to feed individual files to the XSL processing without overflowing maximum command line lengths. Also, on Windows, var2file apparently writes CRLF line ends but the CR parts need to be filtered out again, and xargs problems must be worked around similar to df9edbcd2883cec2d0596133131cfbc220dee91f "Work around 'xargs: environment is too large for exec' errors on Windows".) However, those variables apparently cannot be used to specify dependencies for the three XSLT-processing rules. Presumably, the variables do not necessarily have their values assigned yet by the time the rules' dependencies are constructed (depending on the order in which .mk files are read?). So "dummy" gb_AllLangHelp_get_helpfiles_target targets are introduced, which depend on all the relevant .xhp files (and which get constructed during gb_AllLangHelp_add_helpfiles, just like the gb_AllLangHelp_*_HELPFILES variables), and which the XSLT-processing rules in turn depend on. That makes sure that the XSLT-processing rules are re-run when the content of .xhp files changes or when new .xhp files are added. However, the above still fails to re-run the XSLT-processing rules when .xhp files are removed. This is the helpcontent2 part of a commit spanning core and helpcontent2. Change-Id: I9a72c0f6837a8e13458a703fdecf7e5b0ef2076f Reviewed-on: https://gerrit.libreoffice.org/55364 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 5197a6b9def2e1886e3edab75517864272115089) Reviewed-on: https://gerrit.libreoffice.org/55380
2018-06-06(Partially) fix --with-help=html dependencies on .xhp filesStephan Bergmann2-1/+11
There are three rules in helpcontent2/CustomTarget_html.mk that process (with XSLT) all or some of the .xhp files in the helpcontent2/source/text/ tree (for en-US; or their translations in the workdir/HelpTranslatePartTarget/*/helpcontent2/source/text/ trees for other languages). Lists of all those .xhp files are defined in helpcontent2/AllLangHelp_*.mk (with gb_AllLangHelp_add_helpfiles), but the code in helpcontent2/CustomTarget_html.mk used `find` to assemble the relevant lists. That has two issues (at least for the en-US case operating on the untranslated helpcontent2/source/text/ files): For one, if the content of those .xhp files changes, the relevant XSLT processing is not re-run. For another, if .xhp files are added to or removed from the lists in helpcontent2/AllLangHelp_*.mk, the relevant XSLT processeing is not re-run, either. For the processing of translated .xhp files, there were already dependencies on those translated files in place. I assume (but have not really proved it) that those dependencies are already sufficient to cover both of the above issues. That only leaves the en-US case, operating on the untranslated files. The lists of .xhp files as defined in helpcontent2/AllLangHelp_*.mk (with "*" ranging over the various "modules": sbasic, scalc, schart, etc.) are now made available in gb_AllLangHelp_*_HELPFILES variables. The contents of those variables is used instead of `find` to pass the relevant .xhp files to the XSLT processings. (Needing some RESPONSEFILE and `xargs -n 1` boilerplate to feed individual files to the XSL processing without overflowing maximum command line lengths. Also, on Windows, var2file apparently writes CRLF line ends but the CR parts need to be filtered out again, and xargs problems must be worked around similar to df9edbcd2883cec2d0596133131cfbc220dee91f "Work around 'xargs: environment is too large for exec' errors on Windows".) However, those variables apparently cannot be used to specify dependencies for the three XSLT-processing rules. Presumably, the variables do not necessarily have their values assigned yet by the time the rules' dependencies are constructed (depending on the order in which .mk files are read?). So "dummy" gb_AllLangHelp_get_helpfiles_target targets are introduced, which depend on all the relevant .xhp files (and which get constructed during gb_AllLangHelp_add_helpfiles, just like the gb_AllLangHelp_*_HELPFILES variables), and which the XSLT-processing rules in turn depend on. That makes sure that the XSLT-processing rules are re-run when the content of .xhp files changes or when new .xhp files are added. However, the above still fails to re-run the XSLT-processing rules when .xhp files are removed. This is the core part of a commit spanning core and helpcontent2. Reviewed-on: https://gerrit.libreoffice.org/55363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit ec8edaa3e0b42158f17e540895d5422f91a99fbe) Conflicts: solenv/gbuild/AllLangHelp.mk Change-Id: I0cb5f83097db17fbd7ae8b528418b0ec24bee602 Reviewed-on: https://gerrit.libreoffice.org/55381 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-06fix broken control flow in ScTokenArray::CheckToken()Luboš Luňák1-19/+20
Before commit b366adcf5aca this function didn't do anything for unhandled opcodes, but the commit made the else branch disable vectorization for "the rest" of opcodes. That meant that basic opcodes such as ocAdd, which didn't get thrown out by the SC_OPCODE_START_BIN_OP block (since they are in the allowed subset), ended up in the else block and vectorization got disabled. Change-Id: I9eb408b601f48b8d7b5022ec85225d92729cd778 Reviewed-on: https://gerrit.libreoffice.org/55362 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit a5bae14bc3ae4fd1d0bd3bf72c5a6151d1ccf762) Reviewed-on: https://gerrit.libreoffice.org/55367 Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Luboš Luňák <l.lunak@collabora.com>