summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2018-02-22Branch libreoffice-6-0-1libreoffice-6-0-1Christian Lohmaier4-1/+1
This is 'libreoffice-6-0-1' - the stable branch for the 6.0.1 release. Change-Id: I73c6ff992a9cf02f62f7ab68d6d0b23fb1f5b45d
2018-02-08Version 6.0.1.1, tag libreoffice-6.0.1.1libreoffice-6.0.1.1Christian Lohmaier3-0/+0
Change-Id: Ie1cc3608504ebebd14226828406c76eaa88464ba
2018-02-08bump product version to 6.0.1.1Christian Lohmaier1-1/+1
Change-Id: I3a61ec533c3a1aa2b04907685085408b3ca548cc
2018-02-08Updated coreChristian Lohmaier1-0/+0
Project: translations d9691646f9c43068799b866ffaa9dd8d9ad77240 update translations for 6.0 Change-Id: Id8c4eaee752bfced960d94a76e2434b1c21a4638 (cherry picked from commit 4092195506ca82679ed8ed0feb596777a39aaa20)
2018-02-08ofz#4767 Bad-castCaolán McNamara9-59/+297
Reviewed-on: https://gerrit.libreoffice.org/47235 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 5670a9619b77a6a9e53b0cf20c059ea66ca5f450) Change-Id: Ibf8285efae7c570452954feb41a1a36bf44504a4 ofz: avoid deleting the table still being processed Change-Id: Ia92d469fd0e280bdc6470e780ab12b00366f0f8d Reviewed-on: https://gerrit.libreoffice.org/46902 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit f297b0d043e0767d85f00aa1e4cae5b036b0ac51) ofz#4753 Bad-cast, check all open tables Reviewed-on: https://gerrit.libreoffice.org/47199 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 80fc91db239869b513f47866f45d8a43fb98fe16) Change-Id: Ie6e2fb9f2e16e021a4719c418f52ce074c359904 CurrentTableInPaM->PendingTableInPaM Change-Id: Ic8b48d3b3e3f87e9ac3e8a6bb832f8e8dfe8ab7d (cherry picked from commit 2ed6eba4f99681fe717741ddc1534ed3ccc15e82) ofz#4848 Null-dereference READ Change-Id: I632aca7e3f59b7edf48c8c35eff4abf1946af652 (cherry picked from commit d4d0b1a2b9f11fb7629559e08c345697ba129c04) ofz#4817 Bad-cast Change-Id: I5dc9c66ce17f6401fbc9683cf8b10bf62755a166 Reviewed-on: https://gerrit.libreoffice.org/47236 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 9e269ef68e33fc9da154f6694be7cbcd5e3b4bfc) ofz#4872 Null-dereference READ we're going to need a bigger boat Reviewed-on: https://gerrit.libreoffice.org/47269 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit dfc72242e5bf67bdd5127bf38ed2ad5b3e49cea3) Change-Id: Ie4ee3ae1ac9f906ca3faec412bbafc0c6a911aaf ofz#4971 Bad-cast Reviewed-on: https://gerrit.libreoffice.org/47466 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit c75c3b2fdab5614664215e52d85657472ec86f05) Change-Id: Icf66aa82e72a2b9f24f590b84bb0441ebf09463f ofz#5007 Null-dereference READ Reviewed-on: https://gerrit.libreoffice.org/47537 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 6d05e0945054459ed04d50ae16731f933be48664) Change-Id: I830483071ce481fd14b0d1227c90e492e125f35e ofz#5235 Bad-cast Change-Id: I041f09f37941a92ccee3f0ebf9e5a950dee0c52f Reviewed-on: https://gerrit.libreoffice.org/47747 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 710cf469bf0e43a021fc1a24a80745bc602368ef) ofz#5909 Null-dereference READ Reviewed-on: https://gerrit.libreoffice.org/49218 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 5090d575117fbe6ced75dc45c514f8d990523251) Change-Id: I830d3e8bda517e7681cea7481c32457486ced693 ofz#6064 clear footnotes from tobe-deleted paragraph Change-Id: I33f75adab35d43a4bbf51e33a0abcb5daeca93a3 ofz: Null-deref Change-Id: I9992191fe5b4cfd771cc36a61d0ebaa8a9e6e9db Reviewed-on: https://gerrit.libreoffice.org/46743 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit e867b393ef95cb9bec7f68787771dfa329b00bea) ofz#4728 Null-deref Reviewed-on: https://gerrit.libreoffice.org/47000 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit f2e0c18cd44fff1e1b79924f582ced400fb00dad) Change-Id: Ide91a63424f864e2913b8268c4eca7961ba54572 Reviewed-on: https://gerrit.libreoffice.org/49357 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-08return early on short streamCaolán McNamara1-0/+2
Change-Id: Ia9cb4dec5358281322a2428c5f2153836a1ee1af Reviewed-on: https://gerrit.libreoffice.org/49374 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-08Don't re-sign vc_redist packagesMike Kaganski1-0/+2
Change-Id: I62f55463c04f9bab1dd37f80fe6e15e0296d10bf Reviewed-on: https://gerrit.libreoffice.org/49388 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit f19f8d1a3c175045fa43a8a5e2a12dd55fedb4b8) Reviewed-on: https://gerrit.libreoffice.org/49401 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-08stay within font boundsCaolán McNamara1-1/+6
Change-Id: Ie8ed610b71cb1b20963827c2be97155d2d8aa22c Reviewed-on: https://gerrit.libreoffice.org/49370 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-08what matters is the availability of the last element, not the firstCaolán McNamara1-2/+3
Change-Id: I23d3abdbe62b735d66261fb337613da88cc4206b Reviewed-on: https://gerrit.libreoffice.org/49379 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-08check kern table sizeCaolán McNamara1-2/+2
Change-Id: I65b5f0a8950d54c00d6fd7c385ca1c5dca2ef2c8 Reviewed-on: https://gerrit.libreoffice.org/49383 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-08init known ExtraLanguages before document loadsJustin Luth1-0/+4
Extensions can add RegisterOnTheFly languages for spell checkers. A late initialization of the LanguageTable resulted in the inability to recognize the available spell checker. So, if a .doc file had an onTheFly language inside, and it was the first document that LibreOffice opened, then the spell checking extension was disabled for any other document opened while LibreOffice was living, including docx and odt files. (Starting with a blank document, or a .docx or .odt file seems to initialize OK - and then subsequent .doc files are also ok in those sessions.) Ensuring that the static LanguageTable is intialized early in the process avoids this headache. In my case, .doc was failing with: LanguageTag::registerOnTheFly: not cross-inserted 0x7e0 for 'kbo' have 'en-US' but with this patch now matches .odt/docx with: LanguageTag::registerOnTheFly: cross-inserted 0x7e0 for 'kbo' [have 'kbo'] This fixes .ods .odg, odp, .xls .xlsx .ppt, pptx .doc and likely many others Change-Id: Ie6dcbfd73e063eef4573016c3c62d29cf8ad43ca Reviewed-on: https://gerrit.libreoffice.org/49142 Reviewed-by: Martin Hosken <martin_hosken@sil.org> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 427c0804cd4aecde1cadb7cb3c4f3487991bd573) Reviewed-on: https://gerrit.libreoffice.org/49171 Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-02-07tdf#114217: Consider relative width when importing floating tableMike Kaganski5-3/+20
Unit test included Change-Id: I8e3338d7df431bd016caa4e06e684fbd189127c4 Reviewed-on: https://gerrit.libreoffice.org/49324 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 76d6fcd05c630a928dd3bd028d560792d9c904ca) Reviewed-on: https://gerrit.libreoffice.org/49333 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-02-07tdf#114677 Correct title in Base formsSzymon Kłos1-2/+2
Change-Id: I07bdb46cce88e876583e1d4217dff3f77f2f3814 Reviewed-on: https://gerrit.libreoffice.org/48801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 5426a14e39660bde0dece27cf5ec26b9938bd962) Reviewed-on: https://gerrit.libreoffice.org/48810 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-02-07sanity check cmap table sizeCaolán McNamara1-0/+6
Change-Id: I010c2fd221bcd86a62efd9996a0c34930828cb6d Reviewed-on: https://gerrit.libreoffice.org/49349 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-07MemoryByteGrabber sequence has to exist for Grabber lifetimeCaolán McNamara1-3/+5
it just takes a c++ ref, so a temp is an unsuitable arg Change-Id: I40490e94d977df91b985bc4ae458b68ee85d5dfe Reviewed-on: https://gerrit.libreoffice.org/49322 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-07rtf: null-derefCaolán McNamara1-21/+30
Change-Id: I9c4510cb91e2572a3ab2b62497dc4dd9fd1119c8 Reviewed-on: https://gerrit.libreoffice.org/49341 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-02-07apparmor: fix @{HOME}/.mozilla/firefox access for XML signingRene Engelhard1-1/+4
the #include <abstractions/private-files-strict> bringing "audit deny @{HOME}/.mozilla/** mrwkl," in actually denies everything here. Use just <abstractions/private-files> and allow profiles.ini, secmod.db and cert8.db. At least opening the Digital Signatures dialog doesn't log apparmor DENIED now... Change-Id: Id557626fc26745841f0cca005d483fd1e6ac922d Reviewed-on: https://gerrit.libreoffice.org/48264 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/49253 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-07sw: disable testTableKeep on WNTMichael Stahl1-1/+1
Fails from time to time, like so: https://tinderbox.libreoffice.org/cgi-bin/gunzip.cgi?tree=MASTER&brief-log=1517842001.29090#err2 Change-Id: Ia33193fbfa05da58d31bcc5008beea32c1feb2fe (cherry picked from commit b2a053160c4c8eb0acd66b74c52dbda23a654bda) Reviewed-on: https://gerrit.libreoffice.org/49288 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-07tdf#114306 fix crash caused by special document 2Manfred Blume1-6/+12
Regression from 18765b9fa739337d2d891513f6e2fb7c3ce23b50 Change-Id: Ic4205777077e4e3d93bdddf743c51abba8950eaf Reviewed-on: https://gerrit.libreoffice.org/49031 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit d30eefb677b446886f7b5bab6de93d489ba63529) Reviewed-on: https://gerrit.libreoffice.org/49310 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-02-06tdf#114820 Fix reading external reference for VLOOKUP and HLOOKUPBartosz Kosiorek1-1/+4
Change-Id: Iaa1307123d97a740bdaf90647e8adff224211851 Reviewed-on: https://gerrit.libreoffice.org/49263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 5c3d0a70a0edb182714725ef920d74667feffb0e) Reviewed-on: https://gerrit.libreoffice.org/49315
2018-02-06tdf#115162 Fix support for external reference for IFS functionsBartosz Kosiorek1-2/+2
Functions SUMIFS, AVERAGEIFS, COUNTIFS, MINIFS, MAXIFS were not supported External references. The root cause issue, was using PopMatrix() method for: svExternalSingleRef and svExternalDoubleRef. PopMatrix() method only supports svMatrix, and in other cases returns FormulaError::IllegalParameter error. To resolve that issue, the method GetMatrix() was used. It is properly support svMatrix, svExternalSingleRef and svExternalDoubleRef. Change-Id: I3e30ca50069264a6d990b16ec668e6d0df51c6e6 Reviewed-on: https://gerrit.libreoffice.org/49264 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit b6db65752c60de7268e4f65d7fc5ac110adb2fb0) Reviewed-on: https://gerrit.libreoffice.org/49283
2018-02-06tdf#114815 pyuno: avoid 2 threads initing python in parallelMichael Stahl1-4/+16
According to the crash reports, it's possible for the grammar checking thread to call GetGrammarChecker, instantiating lightproof, at the same time as the main thread instantiates LngSvcMgr, which also instantiates (some?) (all?) grammar checkers. Ensure that pyuno_loader::CreateInstance() initialises Python only once with a C++11 thread safe static. Change-Id: I5b1faba9107355c508831a078366e4a29fdbfadf (cherry picked from commit 5357ca82846ea7147ad61e9340f25647a5934eb0) Reviewed-on: https://gerrit.libreoffice.org/49115 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-06tdf#114731: persona html can contain &quot; instead of &#34;Julien Nabet1-1/+4
So let's replace all &quot; with &#34 in the retrieved html Change-Id: I4a90ecc51e7ce6d1e080e6c1b17b82fe9a29d65e Reviewed-on: https://gerrit.libreoffice.org/49179 Tested-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 2e6bbc04d906ed308fc5ca769bad7b8b4676594e) Reviewed-on: https://gerrit.libreoffice.org/49285 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-02-06rhbz#1541486: Fix localized'ness of ooSetupFactoryUIName propsStephan Bergmann1-1/+1
8f44fb5ee0bd21d192820ffd359504f6d1c68a52 "Mark Base window titles for localisation" localized some uses of ooSetupFactoryUIName in officecfg/registry/data/org/openoffice/Setup.xcu, but failed to mark the prop as oor:localized="true" in officecfg/registry/schema/org/openoffice/Setup.xcs. (So some arbitrary localized version of the prop would win at runtime, potentially displaying certain window titles in wrong languages.) Other uses of ooSetupFactoryUIName in Setup.xcu (for "Calc", "Impress", "Writer", etc.) have never been localized, and are probably not meant to be localized. AFAICS, irrespective of oor:localized="true" in Setup.xcs, their values not being marked with xml:lang="en-US" in Setup.xcu will mean that they will not appear in translations/source/*/officecfg/registry/data/org/openoffice.po and will not accidentally start to be translated after this commit. (Theoretically, inconsistencies between oor:localized in xcs and uses of xml:lang in xcu could statically be caught at build time, e.g., with officecfg/util/sanity.xsl. However, those checks work on each XML file individually, so don't have the schema information available when looking at the data in the xcu file. And those checks are written in XSLT, which makes writing new checks rather, erm, unpleasant.) Change-Id: I9c61e8ebf75d3d54f7e5b6688eac47a6ed8dc5c3 Reviewed-on: https://gerrit.libreoffice.org/49252 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit ffd8369b909c86653ef30593fddf67c9f5308583) Reviewed-on: https://gerrit.libreoffice.org/49270 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-06Turn assert into SAL_WARNEike Rathke1-1/+4
In the wild there are named expressions without expression and formula error cells without formula. Change-Id: I11546b09173de65cebe776529edee74c549d73c8 (cherry picked from commit 951dd781743c975a7d29cc30e88e1b4a56c0b176) Reviewed-on: https://gerrit.libreoffice.org/49258 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-06ofz#5435 sw: fix SwCache::Insert() stale pointersMichael Stahl1-7/+25
If SwCache::Insert() happens to delete the object that m_pFirst or m_pRealFirst point to, which is unlikely as it means every other object is locked, then these pointers must be updated. This sometimes happens in the bugdoc after scrolling around for some time. Change-Id: I13f04d28c37969469efa4e1109c7f5b751ceba96 Reviewed-on: https://gerrit.libreoffice.org/49151 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 269d6d3366eea8541d965181dfdda1fdc5ef2d00) Reviewed-on: https://gerrit.libreoffice.org/49159 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-06tdf#75256 Sifr update 32px for bold and backcolorMatthias Freund11-0/+0
Change-Id: Ibd6dc50925ad6188292e38c87f5ffbbf10792993 Reviewed-on: https://gerrit.libreoffice.org/49255 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-02-05tdf#115416 allow build with classic libjpegCaolán McNamara1-1/+2
Change-Id: I96252e1a78dbc52d21095e11b7bdb0807e5d76b6 Reviewed-on: https://gerrit.libreoffice.org/49205 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-04Resolves: tdf#115369 wrong cell shadow iconsCaolán McNamara1-1/+1
regression from... commit 910f91a3e5228f26f0692f870a3fd3919835eb27 Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Dec 21 13:04:30 2016 +0000 unwind IL_SDW_BITMAPS ImageList Change-Id: I9ecb5c45c240af0214666c56401abb07eb99e5f1 Reviewed-on: https://gerrit.libreoffice.org/49167 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-02-04tdf#49134 tdf#114466 Transfer privilege to become foreground processMike Kaganski1-0/+8
... to already open soffice process from newly spawned one on Windows. When an application takes user input, a timeout is started during which other processes cannot create foreground windows that might steal focus, and thus interrupt user input. The timeout is defined by SPI_SETFOREGROUNDLOCKTIMEOUT (see SystemParametersInfo) and ForegroundLockTimeout registry setting (see https://technet.microsoft.com/en-us/library/cc957208). If an application that currently doesn't have right to become foreground tries to show popups in this interval, the popup will stay on background, and only flash in taskbar. The application that has the right to steal focus (see the list in https://msdn.microsoft.com/en-us/library/ms632668) may transfer its right to another process using AllowSetForegroundWindow function. So, the intended effect is this: 1. User interacts with some foreground process (e.g., Explorer); a timeout is started to prevent non-privileged processes from stealing focus; 2. As the result, the process launches a new soffice process, which has privilege to create foreground windows (as it is started by foreground process); 3. It communicates with already started soffice process, which is currently in background, and so doesn't have privilege to create foreground windows until timeout expires; 4. It transfers its right to the already started soffice process, and then issues the required commands that might lead to need to show popup windows. Change-Id: I4208665c2ae4106fa06e72269f4c3804af40d582 Reviewed-on: https://gerrit.libreoffice.org/48839 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 8d1d82dd63eada8faa2f6eb43ef900764a5fda62) Reviewed-on: https://gerrit.libreoffice.org/48853 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-02-04tdf#32935 tdf#49134 tdf#114466 Activate newly opened modal dialogsMike Kaganski1-1/+6
... based on ForceFocusAndToFront setting Change-Id: Ic76faa082f433d5a0150e49c30d7eda3c6c24c5f Reviewed-on: https://gerrit.libreoffice.org/48287 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/49214 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-02-03tdf#75256 Sifr update epub freezepane defineprintarea splitcellsMatthias Freund27-0/+0
Change-Id: Iba3a6675f00fe6aec6612c0348008c58f98e892a Reviewed-on: https://gerrit.libreoffice.org/48934 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2018-02-03sw: disable ooxmlexport testWatermark on WNTMichael Stahl1-0/+3
This one tends to fail quite a bit in CI builds, at least on Windows, most recently in https://tinderbox.libreoffice.org/cgi-bin/gunzip.cgi?tree=MASTER&brief-log=1517580416.5910 Change-Id: I243b317fb27c51d06fbddf085713e51734eae27a (cherry picked from commit c7f74bbab4c666a8b3b865dbd58b3666f1f63052) Reviewed-on: https://gerrit.libreoffice.org/49162 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-03sc: disable "forecast.ets.add.fods" test file on MacsMichael Stahl1-0/+4
This sometimes fails, since months, and nobody has fixed it. Let's improve the reliability of CI a bit. Change-Id: Ic4d2e085151855d35804f8ed6ebca04366815c0b Reviewed-on: https://gerrit.libreoffice.org/49144 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 00a6f0908a73a80fb0521e1f4cdc99647e43c126) Reviewed-on: https://gerrit.libreoffice.org/49155 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-02Breeze-icon: add 32px trackchangesbar icon for default writer barandreas kainz3-0/+10
Change-Id: I4cab78d3566e574e4176ca9b3b9692cd13f5bf86 Reviewed-on: https://gerrit.libreoffice.org/49121 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com> (cherry picked from commit 9529de103ce76cb7b4e95f4b70df94c2aa159849) Reviewed-on: https://gerrit.libreoffice.org/49146 Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2018-02-02ofz: guard against binary crap argument counts and ID/OpCode generationEike Rathke3-45/+85
This is a combination of 2 commits. ofz: guard against binary crap argument counts and ID/OpCode generation (cherry picked from commit 889c72a7e54f241342f42b1b0a05858902228cbc) Do not force non-existent parameters into the TokenPool, ofz-related (cherry picked from commit e6ced1496da9580cf885cce1a2fc9f67528c3a0e) 2fa0ae81b987af592c14486040077c9ff157fab9 Change-Id: I60e181729713f3b202e880707a79e9da80d9d85d Reviewed-on: https://gerrit.libreoffice.org/49161 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-02ofz: do not force non-existent parameters into the TokenPoolEike Rathke2-13/+31
This is a combination of 4 commits. ofz: guard against binary crap argument counts and ID/OpCode generation Same as in sc/source/filter/lotus/lotform.cxx LotusToSc::DoFunc() (cherry picked from commit d2473faee119c35b518849afe3daa6977a751c68) ofz: do not force non-existent parameters into the TokenPool Apart from that, the hard coded storage order for ocRRI and ocIpmt did the same as the general loop, just with a fixed number of parameters. Instead, limit the number of arguments for the loop for these opcodes. (cherry picked from commit bc697917c79609243305dcecc7aeef2f3776611c) Author was too dumb to adjust a copy-pasta digit (cherry picked from commit 6fc7f3f8409040a3d977b944b3fa4151faf31301) Check for end-of-stream after reading formula headers (cherry picked from commit 1698425c6e2341835aef8c405c06482d4d78d73a) 378ccaf60da61c1a385555451456d8422ee33c50 7d171fdf21c02af9a14600c5e0c6294c0f3ebb57 0de0ceeda63d733779aa595bdbd0f2be97827694 Change-Id: I4972e065ab96abdea42d64481d4e30674230ab99 Reviewed-on: https://gerrit.libreoffice.org/49120 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-01tdf#114045 do not add undo action for table attributesMark Hung1-1/+2
CreateUndoAttrObject() create extra undo steps when using table paint brush on table cells. Undo action for each selected cell is processed individually in SvxTableController::ApplyFormatPaintBrush(). Change-Id: I65034a2b510898db26a7a8ddc4b5f3b742fd9b88 Reviewed-on: https://gerrit.libreoffice.org/46729 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com> (cherry picked from commit 140aa3e7db0a4731f02ab078a1326b2f4523a4c5) Reviewed-on: https://gerrit.libreoffice.org/48698 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-02-01tdf#114596 dbaccess: fix mysterious dataloss bugMichael Stahl3-3/+9
OBookmarkContainer actually re-uses the reference count of ODatabaseSource, so converting ODatabaseSource::m_aBookmark to Reference created a cycle, which somehow causes the dataloss, because evidently something as important as storing the data must be done in the destructor. (regression from 2660d24a07866e083c5135ea263030f3e3a2e729) (cherry picked from commit 96ae2a3300811897c24cccb20f8c2faf382483df) tdf#114596 compilerplugins: add exception to [loplugin:refcounting] (cherry picked from commit e80da60895b45309fa1d018760d5f11cca4367f4) Change-Id: I4cad01dc9cdaf405c1eb31d6c0e161eb6712b78f Reviewed-on: https://gerrit.libreoffice.org/49025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-31the test is declared uncond., so define it so tooDavid Tardon1-7/+7
Change-Id: Idd107c0eebd0f2782c25fb17e3756cde88c5f4dc Reviewed-on: https://gerrit.libreoffice.org/49054 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-31libmspub, add update of config.subjan Iversen1-0/+2
Change-Id: Ia843520afae808fc8ed7dec6ae017400720394e7 (cherry picked from commit 7c026c92b6d03508ae9af9cf0313b809a4097212) Reviewed-on: https://gerrit.libreoffice.org/49036 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-31Fix protection of some unnecessarily strictly protected filesTor Lillqvist1-0/+6
Change-Id: I8bd18130c5fe87b2b352d285d58dd6a4f4499768 (cherry picked from commit 155086493c9e035c0568868f5ae3b3dcf3299e6f) Reviewed-on: https://gerrit.libreoffice.org/48960 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-30Avoid GPG when --enable-mpl-subsetTor Lillqvist1-1/+3
Change-Id: I7e41676965b6d98612ae697d65a5644fe0544649 Reviewed-on: https://gerrit.libreoffice.org/48917 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-30tdf#115013: quote columns with spaces and properly escape charactersMike Kaganski3-4/+47
Unit test updated Change-Id: If36c90c0ff372ce45666674d2487e6edf2536dbf Reviewed-on: https://gerrit.libreoffice.org/48038 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/48082 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-30DOCX import: handle horizontal flip of bitmapsMiklos Vajna4-2/+33
Horizontal mirror on the UNO API level, mirror on the vertical axis internally. (cherry picked from commit 4bdbb5502f5995727017e22bb8a74b9f45552067) Change-Id: If142274a8f81a6875059a2651af6d8470870a36a Reviewed-on: https://gerrit.libreoffice.org/48893 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-30tdf#115013: write merge field column into docx merge fieldsMike Kaganski3-1/+49
Change-Id: If1e0a8968407c72e42cb7ca487541d0b8227aabc Reviewed-on: https://gerrit.libreoffice.org/47895 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/47973 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-30tdf#115090 keep internal BaseModel alive long enoughThorsten Behrens2-1/+7
There's reams of code already preventing a close during save (SfxSaveGuard), but this looks equally effective. Avoids SfxBaseModel::dispose() pulling the rug under us, when SfxBaseModel::postEvent_Impl() wants to access parts of the interface containers during notification. Plus this one: tdf#115090 prevent SfxBaseModel destruction during notifications Additionally ensure refcount stays above sea level while notifying clients (who might dispose their own references, causing our own refcount to drop to zero). Otherwise, 2nd loop in postEvent_Impl() might already operate on freed mem. Reviewed-on: https://gerrit.libreoffice.org/48871 Change-Id: Iace1f9922c47a97ab2e798b577c6aec8a729da48 Reviewed-on: https://gerrit.libreoffice.org/48709 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 1841fcf896f50b7df1375d431857ecddd5f5b392) Reviewed-on: https://gerrit.libreoffice.org/48762 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-30tdf#75256 Sifr some new 32px iconsMatthias Freund28-0/+0
Change-Id: I6b0ea66424f36982b6c8eae8b9e405aaf30ca5d6 Reviewed-on: https://gerrit.libreoffice.org/48269 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2018-01-30fix tdf#114934 borderline feature regressionsArmin Le Grand14-373/+378
squashing some master commits, fixes the following bugs: - tdf#114934 which contains: - tdf#115169: Calc: Rotated Cells not shown rotated when using Print/PDF/PrintPreview - tdf#113751: Borders for Merged Cells are Partially Shown - tdf#114625: Calc can not print right border of merged cells from LO 6.0 - tdf#114824: Export to PDF and Printing: Borders of Merged Cells Flow to Page Footer BorderlineFix: Need to redesign Borderline paint for Calc To fix some errors, need to change svx::frame::Array conversion to Primitives, especially regarding handling of merged cells. These make problems in the currtent form where the full extended merged cell tries to be converted. This is bad for cropped stuff and also wrong for double-line stuff attaching to a merged cell. The solution is to handle cells single and merge created primitives which is more expensive but will work. This will involve special handling for X-Ed (crossed) and 'roated' Cells. Also need to be very careful since all this is used in the meantime for all visualizations of Tables in multiple apps/situations. Change-Id: If0652a3ba97a6f27dd5d782ea22b1514303f3710 BorderlineFix: Corrected missing borders in print In Print/PDF/PrintPreview border lines were missing, this happened for merged cells. It has to do with access to the involved Styles and/or 'Clip' set (to avoid creating everything). Thus a 'mixed' usage of cell and merged-cell stuff was needed. As it turns out support for this is already there, need to use it. Change-Id: Ic16085b97eef5c79a4501279432f43491bca350e BorderlineFix: Avoid BorderLines to be too prolonged For MergedCells there was an effect that the BorderLines were painted too far in PrintPreview/Print/PDF visualization, found reason and changed. Checked (hopefully) all usages, looks good. Change-Id: I0acf8dcb20548a98533f3ab317ac72c0d0f0a947 BorderlineFix: Corrected handling for 'rotated' CellBorders CellBorders can be rotated (including their Text) and need special visualization that is based on an own sheared/rotated coordinate system. Currently only possible for single cells (not merged ones) and needs to handle all borders (also bottom-right directly in the rotated cell, not in the neighboured ones to have the geometry, plus avoiding these in the non-rotated neighbour cells. Also corrected adding CellRotation data to svx::frame::Array in calc using SetCellRotations() which now gets called in the ScOutputData constructor to ensure it gets called in all places where it is used. Change-Id: I47bdfc29ba5ca76bbc07d98cb64733f867b1ee20 BorderlineFix: Fixed visual updates when scrolling For Cells with DoubleLine the connections to perpendicular DoubleLine-Styles may have to be displayed in a Cell which is 'around' the orig cell in a Cell-Border of one. To represent that and to avoid repaint errors when scrolling in, the preparation of Primitives has to take accordingly more neighbour cells into account. Tested this change with the usages in Calc, UI (Dialogs) and Calc exports Print/PrintPreview/PDF. This does not affect Tables in Writer and/or Draw/Impress. Change-Id: I3bcc68cdf7b4fc1825a87a9773892c359421024e BorderlineFix: Fix WriterPaint if scrolling CellTableBorders Similar to CalcBorders in Writer the overlap regions for FrameBorders have to be taken into account when repainting the CellBordes of WriterTables Change-Id: I488ba158e1de579bfb06b9c8353adaa2cac706c6 BorderlineFix: Corrected Draw/Impress TableStyle accesses In Draw/Impress the indices for accessing the correct neighbouring TableStyles were wrong and thus created wrong visualizations, corrected that. Change-Id: Iebc5f294adb62fa4c6358e2f8c27d29cc3163fbc BorderlineFix: Use svx::frame::Array tooling in Draw/Impress For creating the needed BorderPrimitives for TableCells for the Tables used in Draw/Impress, adapt the ViewContactOfTableObj doing this to use svx::frame::Array tooling now. This will correct the error for not taking the neighboured connects for merged cells into account and unify one more space to the same tooling. Change-Id: I2e6f732985e9b963359f156628bd29ddfec1a80c BorderlineFix: Corrected wrong indexing in Array initialization Change-Id: I4222ef1c82620a05cea9f6db1a0664196cfb3bd4 Reviewed-on: https://gerrit.libreoffice.org/48891 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-30tdf#115221 crash in printing and commentNoel Grandin1-3/+1
not wonderfully happy with this fix, because we're changing the delete ordering here, but the origin of this bug was commit a754294ac7a902fe96fbbd6b8b6824a360d6b248 use rtl::Reference in SwDocFac instead of manual acquire/releas and commit cc483d0470dbf0d01e4da818b148ff0b851c5187 (patch) tdf#112292 - fix memory leak and use more auto ref counting in sw so the delete ordering was obviously messed up in those already, and we have such a morass of callbacks here, I can't see where else to fix it. I tried to add a couple more "getDoc() != nullptr" checks, but we still ended up crashing with an SwViewShell that had a bad pLayoutAccess pointer. Change-Id: I4aa39d58ae25bed41e3fd2c32c6d53659012ec10 Reviewed-on: https://gerrit.libreoffice.org/48658 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit de9bcd167b059e00818304626c0cadaa330738a4) Reviewed-on: https://gerrit.libreoffice.org/48748 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>