summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2017-07-25Version 5.4.0.3, tag libreoffice-5.4.0.3-hotfix1libreoffice-5.4.0.3-hotfix1Christian Lohmaier3-0/+0
Change-Id: I5a33c5802b977212bfe7d1d51a193a35c5a7a4a8
2017-07-25tdf#109281 add fallback to GDI back when we can't bind a DCTomaž Vajngerl1-0/+5
Change-Id: Ideae3a5bcacfaadd2cb9d6b014a449d423d332dc Reviewed-on: https://gerrit.libreoffice.org/40399 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 10a2dd0ca46cf05234019d10d8eac19ebaca1b63)
2017-07-21Version 5.4.0.3, tag libreoffice-5.4.0.3libreoffice-5.4.0.3Christian Lohmaier3-0/+0
Change-Id: I2bf7e7f7f3e0b385ae89721b3c87d37f4e1068c9
2017-07-21bump product version to 5.4.0.3Christian Lohmaier1-1/+1
Change-Id: I700f9dcf86f0447b5f889d76f9ac95cbdac1b7f5
2017-07-21update credits - with aliases fixedChristian Lohmaier1-839/+601
Change-Id: I486428da5459e758d23dd58b189b539896886c4c (cherry picked from commit c48f659a38af4da57cd1c978f17f2598de19156a) (cherry picked from commit ad287a1f4fae8a890faa475f0500097680bcf2b2)
2017-07-21tdf#107166 improve AA mode selection, retry, more checksTomaž Vajngerl2-42/+91
Major problem when setting the render mode and the text antialias mode is that when you set the render mode to something that isn't compatible with the text antialias mode, then every next call will cause an error (invalid parameters). So we need to be sure that we never set incompatible modes. Additionally we just need to set it one time when we create the surface and not every time we draw. If we get the D2DERR_RECREATE_TARGET we can create a new render target and retry the whole call. Somethimes this is not possible so we try 3 times and the give up. We need to add more checks where we exit early or not continue with some calls as any additional calls could taint the draw state and some things wouldn't be drawn. For example if we calculate the sizes of 0 glyphs we shouldn't continue with binding the hDC with an "empty" rectangle. This will fail and cause some text that is called afterwards to not draw. Change-Id: I8f802da2e7ece0bf16d665f2e5011ffaa5267fca Reviewed-on: https://gerrit.libreoffice.org/40260 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit e197b4a88c421201e157552f94e7eaaa00a76269) Reviewed-on: https://gerrit.libreoffice.org/40274 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-07-21tdf#107166 BindDC doesn't handle 0 width/height rect consistentlyTomaž Vajngerl1-1/+4
When binding a GDI device context to D2D we need to provide a rectangle where the surface will have effect. When we just need some font information we need to bind the DC too, but we aren't really interested what the rectangle is, so we just provided a 0,0,0,0 rectangle in that case. This sometimes fails with a "out of memory" result and is dependent on the renderer. Instead of 0,0,0,0 rectangle we rather define a 0,0,1,1 rectangle which should never fail. This is not problematic as for actual rendering we later rebind with an actual rectangle. Change-Id: I79c7f0cf4d69f213370ed26a811a908ed16070ff Reviewed-on: https://gerrit.libreoffice.org/39902 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 35f8c78b5fbdbb3619b1c0f9fdee5f84ac1a6f73) Reviewed-on: https://gerrit.libreoffice.org/40273 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-07-21update creditsChristian Lohmaier1-1557/+1747
Change-Id: I3d2a7bd97c085c68dc5036b6cb3731c24ed63aa2 (cherry picked from commit 8f338d85a576dcc636907ce036cb34559e9c7e36) (cherry picked from commit 2cf15209811b79566b4813071dc4e67dd6a11e41)
2017-07-21Updated coreChristian Lohmaier1-0/+0
Project: translations db8f14aab056249579137c81c59fbf7d00e6c552 update translations for 5.4.0 rc3 and force-fix errors using pocheck Change-Id: I44afb116fdeb5809a82cf8647cd28e34351d8e9c (cherry picked from commit f9619b996bb12965acf934c8d8debf24dc4ad1e3)
2017-07-21tdf#73873 Fix missing embeddings in word/embeddings directoryBartosz Kosiorek2-4/+4
In commit: https://cgit.freedesktop.org/libreoffice/core/commit/?id=ad90e22f1970d019e1f2a1e8ba8020c0f0cb36c4 the refactor was made. Unorfunately due to mistake the embedding was always resetting. As a result only one embedding document was added, and the OOXML files were pernamentely corrupted. This simple fix is resolving mentioned issue. Change-Id: Ie268b1bf8906ac7b8e061526a9186b3b4b46bef6 Reviewed-on: https://gerrit.libreoffice.org/38369 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> Reviewed-on: https://gerrit.libreoffice.org/39787 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-07-21tdf#109197 crash when deleting user field variables in swNoel Grandin1-2/+5
regression from: commit a706bb06d5326e7a997dd1d71f3f947bd0ad28e6 "new loplugin: useuniqueptr: sw part 1" Change-Id: I57f9c9e6d7eeccc033b71d7182c960f3d79df73c Reviewed-on: https://gerrit.libreoffice.org/40244 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 8f232771e84ba0369acb27085813d5810b15724b) Reviewed-on: https://gerrit.libreoffice.org/40247 Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-07-21Blind fix tdf#108612 explicitly checking for and against clipboard documentEike Rathke1-1/+4
This is a combination of 2 commits. Attempt to blind fix tdf#108612 explicitly checking for clipboard document It seems that for some yet unknown reason in an (un)certain constellation ScDocument::IsClipboardSource() returns true because ScModule::GetClipDoc() does not return the clipboard document but the actual document instead, so destroying the clipboard document executes ScDocument::ClosingClipboardSource() and (or in earlier versions) ScDocument::ForgetNoteCaptions() on the actual document instead. Check also that ScDocument::bIsClip is set, hopefully curing the symptom, the real cause is something else. (cherry picked from commit d5020f35aec54f0241fa58557dc6caadc149f5a9) Another attempt to blind fix tdf#108612 Oddly in that scenario on Windows there are two clipboard documents alive when destroying one, so the destroyed one erroneously is said to be a clipboard source and then detachs the comments' caption information. There's no legit case where a clipboard document could actually be the real original source of another clipboard document, so bail out if the caller already is one. (cherry picked from commit 52e09f2c03f7cc024b2973c4806283c324fc23df) 0f8d240d8ec13bf91b77176dc6439a541cf14eaa Change-Id: I5ffd0706592d2737808e7004630a56c53115295b Reviewed-on: https://gerrit.libreoffice.org/40250 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.co.uk> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-07-21repaint whole range for range based cond formats, tdf#105696Markus Mohrhard4-9/+88
The range based cond formats need to be repainted across the whole range. This ensures that a change in condition which affects all cells causes a repaint. Change-Id: Ie6dd10088a1c11c1bafd1faa9c429a35a6469ff2 Reviewed-on: https://gerrit.libreoffice.org/35302 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 49922897d68835ae4e5c850b3c55107157fe7548) Reviewed-on: https://gerrit.libreoffice.org/39713 Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 6ed7a3085216caf29f9066154fccc6ee2f1b953d) Reviewed-on: https://gerrit.libreoffice.org/39925 Reviewed-by: Dennis Francis <dennis.francis@collabora.co.uk> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-07-21Resolves: tdf#75650 reset boolean number format to General for new formulaEike Rathke1-4/+22
Change-Id: Iec2feefcbb5a92c64f182d93b4055fc009dbe1e5 (cherry picked from commit 1c1783864a356a4394f80dec28db939f4cf572cd) Reviewed-on: https://gerrit.libreoffice.org/40054 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.co.uk> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-07-21Resolves: tdf#104186 spaces between function name and ( not allowed in OOXMLEike Rathke1-6/+22
(cherry picked from commit 7232980be6a4d67ed28a21b74ef3544cacb29d6a) Conflicts: formula/source/core/api/FormulaCompiler.cxx Backported. Change-Id: I6f6fcdab24a426d0f62052fa2d31f4098d1d893a Reviewed-on: https://gerrit.libreoffice.org/40087 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.co.uk> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-07-21tdf#108758 : do not write to undo document when...Dennis Francis3-2/+134
...updating references during a block move, for formula cells that are in the target range of the move operation. The fix is for formula cells that are not grouped. For the grouped case, it was already doing correctly. Added two unit tests in ucalc_formula.cxx for grouped formula and non-grouped formula cases. Change-Id: I9f4d988f5e154f56670bd1c0cc366ee6704fb858 Reviewed-on: https://gerrit.libreoffice.org/39883 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 2caaf9bfe8d3f81517467daf36de0bd8ddd6b543) Reviewed-on: https://gerrit.libreoffice.org/39923 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-07-21Resolves: tdf#108903 avoid recurse to deathCaolán McNamara2-2/+7
Change-Id: Iadde719a024c5fce97aa0f4c58947a5012639a84 Reviewed-on: https://gerrit.libreoffice.org/39920 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit e2075593e4d13b6e7c0b32b23912fdeed1ada6bf) Reviewed-on: https://gerrit.libreoffice.org/39989 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-07-21don't use memset on structure with std::shared_ptr memberMarkus Mohrhard4-6/+39
Change-Id: Ie6033b9820435bb6a45aa70f9a48115000571e0f Reviewed-on: https://gerrit.libreoffice.org/40004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit c7fe625c8d41f648f89765abc40bb7b8fd4ed12a) Reviewed-on: https://gerrit.libreoffice.org/40010 Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-07-20Fix crash when saving new spreadsheet as dBase/.dbf, tdf#108789 follow-upEike Rathke1-1/+1
... as there is no input stream. Regression from commit 7f1465a9599e9665159dd2d823a6e9064cca5703 Date: Sun Jun 25 17:21:45 2017 +0200 Change-Id: Ib97a4878fe8cf28e5d0f1dc6cc07800ea1635e68 (cherry picked from commit 22ae038a56b85e86219922c2759544545f2d813d) Reviewed-on: https://gerrit.libreoffice.org/40208 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-20tdf#106359: use SvFileStream to read iqy; fixes *nix compatibilityMike Kaganski1-37/+27
Change-Id: I42dc6559a57eaedcc64d2a4e59e16677b9dfeb1c Reviewed-on: https://gerrit.libreoffice.org/39862 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit f19fbadd00370820d026d9c29a7bc231e6fa49f0) Reviewed-on: https://gerrit.libreoffice.org/39872 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 71a5bda1f65fa1b87a290f15c24034d25a9f1f25) Reviewed-on: https://gerrit.libreoffice.org/39886 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-07-20Partially revert c1723a3b6Varun Dhall1-2/+3
The loop behavior was changed by the original commit instead of starting from 1 it started from 0 due to which it ends up saving Default Style and missed an important custom style Change-Id: I4853b70fbb6a24c9ccbd0b5713c6dbe4215830a6 Reviewed-on: https://gerrit.libreoffice.org/40093 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 315b6afc90298ac23de7d24449feae6beaade17a) Reviewed-on: https://gerrit.libreoffice.org/40129 (cherry picked from commit 9b6542dbeea01aedd3570d84231383c0dc34812f) Reviewed-on: https://gerrit.libreoffice.org/40137 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Varun Dhall <varun.vd1994@gmail.com> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-07-18Defer also loading of the English CalendarWrapper, tdf#109045 follow-upEike Rathke1-4/+8
Always constructing the en-US CalendarWrapper defeats the original intention that not for every construction of SvNumberFormatter a calendar is needed, plus if no en-US is requested constructing such calendar is just wasted. Since commit 2a22696546ace75c38a72ad13f7383aedd00e06a Date: Mon Jul 10 15:56:32 2017 +0200 tdf#109045: store en calendar separately in OnDemandCalendarWrapper Change-Id: I06e13754f03fc1fe4fbf48b76ccb82c917606480 (cherry picked from commit 21394b08475d1d869aa62c1dbb46c3dcc93ae3f0) Reviewed-on: https://gerrit.libreoffice.org/40097 Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Aron Budea <aron.budea@collabora.com> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-07-18gpg4libre: Wrap PGPOwner in own namespaceSamuel Mehrbrodt2-6/+9
as recommended by W3C: https://www.w3.org/TR/xmldsig-core/#sec-PGPData Reviewed-on: https://gerrit.libreoffice.org/40058 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 9127706ab39cd39da7a8b9a13acb553a77968890) Change-Id: I2cc0ae24eefc9137d2e3432da1d65e44245c7616 Reviewed-on: https://gerrit.libreoffice.org/40068 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 20d4c21c7f167559998526e36fb4859b41f2bf1f) Reviewed-on: https://gerrit.libreoffice.org/40114 Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-18gpg4libre: Import public key payload if verification result != validKatarina Behrens1-5/+14
it is essential to look closer at the results of verification (code doing that was removed by commit bdbebda1d80f538f946b14042) to be able to proceed with importing public key payload from the file if needed I've also killed one more instance of xmlStrlen being used on binary data Change-Id: I8cd45fe963c8dde91727471ddbebe6943374a121 Reviewed-on: https://gerrit.libreoffice.org/40066 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 53be53b35e18230004b5f173c961fb8aa7162b09) Reviewed-on: https://gerrit.libreoffice.org/40073 (cherry picked from commit 4ca03b46b53818a25636a96b5e42b3a0b116bc35) Reviewed-on: https://gerrit.libreoffice.org/40101 Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-07-18tdf#109045: store en calendar separately in OnDemandCalendarWrapperAron Budea1-18/+35
When working with pivot cache there's alternating use of locale dependent and locale indepentent formats, which causes unnecessary loading of calendars due to constant switching. OnDemandLocaleDataWrapper already does this, now do something similar in OnDemandCalendarWrapper. Reviewed-on: https://gerrit.libreoffice.org/39762 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 2a22696546ace75c38a72ad13f7383aedd00e06a) Change-Id: I3d64dbe8afa929cf416d87678762e82b45561d63 Reviewed-on: https://gerrit.libreoffice.org/39834 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-17gpg4libre: use full SHA1 hash for key identificationThorsten Behrens4-15/+20
Read and write full 20 bytes/40 hex chars of SHA1 key hash, instead of some abridged versions. See also https://lists.debian.org/debian-devel/2016/08/msg00215.html Change-Id: I741afc94ac7cf559880fe55ff02420723e13310d Reviewed-on: https://gerrit.libreoffice.org/40027 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 40f181207574827827d2bf1b4ad72d46fc8ff1fb) Reviewed-on: https://gerrit.libreoffice.org/40028 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-on: https://gerrit.libreoffice.org/40047 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-07-17tdf#108831 PGP signature shown as invalidSamuel Mehrbrodt1-6/+2
It was valid, but not trusted. We need to show the owner trust in another place. gpg4libre Change-Id: I344a7b064a22c16b647c73d52f7abd91cfc86be9 Reviewed-on: https://gerrit.libreoffice.org/39959 Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-07-17gpg4libre: Show whether pgp keys are trusted or notSamuel Mehrbrodt2-31/+43
Owner trust levels considered valid keys: Marginal Full Ultimate Owner trust levels considered invalid keys: Unkown Undefined Never Change-Id: I7338b587acfd105ca24e40b45960cea8d2c04ded Reviewed-on: https://gerrit.libreoffice.org/39958 Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-07-17gpg4libre: search for _all_ local keys in getCertificate()Thorsten Behrens1-1/+1
Otherwise, newly-imported ones will not show up, which is bad when trying to figure out how much we trust a key in DocumentDigitalSignatures::ImplVerifySignatures() Change-Id: I771cf71b5e0ddb5cc76db94d7ada4c5291fe56f1 Reviewed-on: https://gerrit.libreoffice.org/40023 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 59960eab5370477c809babdbfae9668dfa845e2d) Reviewed-on: https://gerrit.libreoffice.org/40025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit df84297026ddd16353456cb6b55f81d2ae7f9772) Reviewed-on: https://gerrit.libreoffice.org/40046 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de> Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-17gpg4libre: unconditionally use binary IOThorsten Behrens1-0/+1
Regardless of changing gpgme defaults, we don't want ascii armor anywhere. Change-Id: Ic1e80e134b8f24d05d6549ef19c5a82220718f1f Reviewed-on: https://gerrit.libreoffice.org/40024 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 8778e956d0e85b50dbf2512634e292c5360ba96d) Reviewed-on: https://gerrit.libreoffice.org/40044 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-07-17gpg4libre: Don't use xmlStrlen on binary dataKatarina Behrens1-2/+3
Odd things happen inside gpgme if the buffer is prematurely truncated due to \n char and valid signature is then evaluated as invalid Change-Id: I24d4d22af06a3dde6eb7fdfc12953cf1b5f19c1e Reviewed-on: https://gerrit.libreoffice.org/39945 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 02bb4ebf2b0dd656bfb0e8185e702267606a7e64) Reviewed-on: https://gerrit.libreoffice.org/39964 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-14tdf#108852: Put signature infobar into the right frameKatarina Behrens1-1/+1
and thus avoid crash when user clicks 'show signatures' button in a window where signature bar shouldn't even be Change-Id: I5eba8d1ddd8c76dd10acedfa03d732df586748de Reviewed-on: https://gerrit.libreoffice.org/39705 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit bc882e977144d60b850288045e3f6aab7cbad6f7) Reviewed-on: https://gerrit.libreoffice.org/39971 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-07-14tdf#109046 Show correct signature type for OpenPGPSamuel Mehrbrodt1-1/+4
gpg4libre Change-Id: I9c05f68e16928d14a29058f5bb9aa35c90b8f48b Reviewed-on: https://gerrit.libreoffice.org/39744 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit efb24fc7bab19840d4959d22706719981dc8bac0) Reviewed-on: https://gerrit.libreoffice.org/39911 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-13tdf#108977 Show signature info for keys we don't have locallySamuel Mehrbrodt11-27/+76
gpg4libre Reviewed-on: https://gerrit.libreoffice.org/39742 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 820bd4b3b64a5746599c48c729037a959ff61c84) Change-Id: I89593224590007e61bce95c14922c08551282067 Reviewed-on: https://gerrit.libreoffice.org/39793 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-13fix getrandom check in expat's configureChristian Lohmaier2-0/+41
https://github.com/libexpat/libexpat/issues/52 fixes /usr/include/sys/random.h:37:22: error: expected ')' misdetection of random.h feature, already fixed upstream: https://github.com/libexpat/libexpat/commit/602e6c78ca750c082b72f8cdf4a38839b312959f (cherry picked from commit f78ed1ec528604f6db9bdd2a07462c5e99e0ab99) Change-Id: I65e4aebaa838d2931a60cb34806d87b88861c4d8 (cherry picked from commit 5ff5e093aac0726e19962cd3622e54877d7acd51)
2017-07-12Updated coreChristian Lohmaier1-0/+0
Project: translations 77c44f36436e1f1f5c31a049636845e7174cdf4e update translations and force-fix errors using pocheck also update po files for low-completion-ratio (<10% in UI) langs Change-Id: I5c1d8fc0368c79a8d1d732cc21258214c7a39502 (cherry picked from commit d317414f8297e51842dc450bfaf5eeff5cb164ff) (cherry picked from commit c1ee41a84f22743ce1c9c3435ce48372fef1bdac)
2017-07-11Related tdf#108977 Fix crash when vieweing non-existing certificateSamuel Mehrbrodt1-1/+1
gpg4libre Change-Id: If72c2ee818b67b48753ee293de4f02b4832b9d96 Reviewed-on: https://gerrit.libreoffice.org/39743 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-on: https://gerrit.libreoffice.org/39792 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-07-07Updated coreAndras Timar1-0/+0
Project: translations 725e2d62450e1929429547d3c6de62c5a002dae8 Updated Slovenian translation Change-Id: Ibcfa731fec2385a067911c5dc95b8291d37505db (cherry picked from commit 17f8b5b75785d2d309966171b7d7383de50ed411) Signed-off-by: Andras Timar <andras.timar@collabora.com>
2017-07-06bump product version to 5.4.0.2.0+Christian Lohmaier1-1/+1
Change-Id: I20326cc20c31daec87ead5de6b3b92326562c83d
2017-07-06Branch libreoffice-5-4-0Christian Lohmaier4-1/+1
This is 'libreoffice-5-4-0' - the stable branch for the 5.4.0 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 5.4.x release, please use the 'libreoffice-5-4' branch. If you want to build something cool, unstable, and risky, use master. Change-Id: I3593a0085b25667f2ad43411a2f5115bafc0622e
2017-07-06tdf#106990 set cleartype setting / force to use GDI render modeTomaž Vajngerl2-3/+86
With this we read the system setting for cleartype and set it to the render target we are using. Additionally we set the GDI like rendering mode which forces that the text is rendered similar as this was done with GDI. Change-Id: If6fb72bc371accf50278c968c94e625aee3f0953 Reviewed-on: https://gerrit.libreoffice.org/39602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit a5a3e82e99e7a60ec65c339dd0463af5c680cead) Reviewed-on: https://gerrit.libreoffice.org/39647 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-07-06tdf#108873 fix merge data handling in fieldsJan-Marek Glogowski3-3/+21
This is a regression from tdf#70346 / commit 4851cde7b98226b0f82ae2b191c290173e9b06c6 It added the whole DB row as variables to the SwCalc hash set. This works correct for conditionals when hiding sections, but not for conditionals used in fields - actually they break. Previously the field would do a fallback to query the DB again, if no variable was in the dict and the only possible variables in the dict could have been user-defined fields. This handles the added variables correctly for fields. Also fixes a bug to store the DB number values as number variables and adds the record number, as SwCalc::VarLook does. Change-Id: Ib0dbeda68234e671768ede55b2012235a3680276 Reviewed-on: https://gerrit.libreoffice.org/39509 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit f54c6938f73b94fb6f722f3ea68454fee424e62e) Reviewed-on: https://gerrit.libreoffice.org/39612 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-07-06ofz: stay inside stringCaolán McNamara1-1/+1
Change-Id: Ia0d0ddfce4ee3d5f8763be6804fe52c514375bb3 Reviewed-on: https://gerrit.libreoffice.org/39629 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 073a2b2aef5c0b579aea8ed203dd9c1c5790b650) Reviewed-on: https://gerrit.libreoffice.org/39644 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-07-06tdf#108923 : Use display string for generating chart labelsDennis Francis2-20/+99
Use display string for generating chart labels in PivotTableDataProvider::collectPivotTableData as chart2 does not seem to use number format for labels although it does for the data. Added unit test PivotChartTest::testPivotChartWithDateRowField() for this fix. Change-Id: I668d4c9d7cf8bbb7e4213cce7a6e7cd4d7d07cbe Reviewed-on: https://gerrit.libreoffice.org/39548 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 5eeed755a2eadbadd7a2e0c06216258af028a96e) Reviewed-on: https://gerrit.libreoffice.org/39654 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-07-06ofz#2452 use shared_ptr for cshapeCaolán McNamara3-5/+5
Change-Id: Icf576c08b3502ea3e24fa4b3685b55f794e844db Reviewed-on: https://gerrit.libreoffice.org/39649 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-07-06Display string results in the Function Wizard quotedEike Rathke1-3/+11
To distinguish number strings from numeric results. Change-Id: I68e044e839b2d5d2e87835dd0002f42aa0fc8192 (cherry picked from commit 14f562b109042ebde90261f93952b4c730e1427d) Reviewed-on: https://gerrit.libreoffice.org/39608 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-07-06Watermark: tdf#91687 correct size in the .docSzymon Kłos6-6/+56
Export: * Watermarks saved using Writer were very small in the MSO. Export fUsegtextFStretch property in the Geometry Text Boolean Properties. * tdf#91687: SnapRect contains size of Watermark after rotation. We have to export size without rotation. Import: * When import set height depending on used font and width. Text will keep the ratio. Remember the padding for export. * added unit test * introduced enum to avoid magic numbers for stretch and best fit properties. Change-Id: I3427afe78488d499f13c543ca401c096161aaf34 Reviewed-on: https://gerrit.libreoffice.org/38979 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit d72e0cadceb0b43928a9b4f18d75c9d5d30afdda) Reviewed-on: https://gerrit.libreoffice.org/39607 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-07-06Updated coreOlivier Hallot1-0/+0
Project: help c2bea45cca3f5afa702b8b92ad744e0c9f8320db Rearrange help page for VBA functions Save work for translators. Change-Id: I2072d85443ba32f10235123f3ba2b681182127d2 Reviewed-on: https://gerrit.libreoffice.org/39139 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2017-07-06Updated coreOlivier Hallot1-0/+0
Project: help 61c61f1181927a3dd78447cd36581682395ccf2d Fixes for help pages after translation review. Thanks to all translators for pinpointing these mistakes. Change-Id: I3746d3d81ded2af1e012cb38cdd20e9e529c2667 Reviewed-on: https://gerrit.libreoffice.org/39331 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2017-07-06sw: fix use-after-free in SwAccessibleMap::FireEvents()Michael Stahl1-0/+5
As seen when running JunitTest_sw_unoapi_3 against "make debugrun", the damn thing can call itself recursively via an odd corner case in GetContext(): 0 in SwAccessibleEventList_Impl::~SwAccessibleEventList_Impl() (this=0x9a6a170, __in_chrg=<optimized out>) at sw/source/core/access/accmap.cxx:498 1 in SwAccessibleMap::FireEvents() (this=0x8198bb0) at sw/source/core/access/accmap.cxx:3023 2 in SwAccessibleMap::InvalidateCursorPosition(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible> const&) (this=0x8198bb0, rAcc=uno::Reference to (SwAccessibleParagraph *) 0x9a439d8) at sw/source/core/access/accmap.cxx:1069 3 in SwAccessibleMap::GetContext(SwFrame const*, bool) (this=0x8198bb0, pFrame=0x825ca10, bCreate=true) at sw/source/core/access/accmap.cxx:1925 4 in SwAccessibleMap::GetContextImpl(SwFrame const*, bool) (this=0x8198bb0, pFrame=0x825ca10, bCreate=true) at sw/source/core/access/accmap.cxx:1936 5 in SwAccessibleContext::InvalidateChildPosOrSize(sw::access::SwAccessibleChild const&, SwRect const&) (this=0x405a350, rChildFrameOrObj=..., rOldFrame=SwRect = {...}) at sw/source/core/access/acccontext.cxx:1196 6 in SwAccessibleMap::FireEvent(SwAccessibleEvent_Impl const&) (this=0x8198bb0, rEvent=...) at sw/source/core/access/accmap.cxx:898 7 in SwAccessibleMap::FireEvents() (this=0x8198bb0) at sw/source/core/access/accmap.cxx:3018 8 in SwViewShellImp::FireAccessibleEvents() (this=0x7744dc0) at sw/source/core/view/viewimp.cxx:460 9 in SwLayIdle::SwLayIdle(SwRootFrame*, SwViewShellImp*) (this=0x7ffc63395e30, pRt=0x7745120, pI=0x7744dc0) at sw/source/core/layout/layact.cxx:2267 Presumably all of mpEvents, mpEventMap and mpShapes must live until the outermost FireEvents() completes. Change-Id: I4e5a053035bf7fc12d9407913437d721889950ae (cherry picked from commit ddf8d9a150e3e1725de65577c48d47918b4b11a8) Reviewed-on: https://gerrit.libreoffice.org/39566 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>