summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2017-05-03bump product version to 5.3.3.2.0+libreoffice-5-3-3Christian Lohmaier1-1/+1
Change-Id: I181ce9f9b6f6e0bbfc62f49b5969dd59bc4f2c4c
2017-05-03ofz#1262 sw: DeleteAndJoin could delete proposed new redlineMichael Stahl2-0/+22
... because that calls CompressRedlines, which may combine the new redline with a previous one. In that case, the part of the new redline that follows the currently handled overlap cannot be checked for overlaps with subsequent existing redlines. So prevent this with a new flag m_isForbidCompressRedlines and instead call CompressRedlines() at the end of AppendRedline(). Change-Id: I7567962c31366ded9a433a13232d3db985745e43 Reviewed-on: https://gerrit.libreoffice.org/37041 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 5d1c6f1c9f392679cec6f1f4ab9673ab31e96585) Reviewed-on: https://gerrit.libreoffice.org/37195 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org> Tested-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2017-05-03update creditsChristian Lohmaier1-915/+939
Change-Id: I815bef830ed3699b17b19405c953892e7b716238 (cherry picked from commit fc8e4ebca569428e07d0b02855e4d09c4b4276be) (cherry picked from commit bb6d2d3476b0acfd92dc75ed26836ab2ff817378)
2017-05-03Updated coreChristian Lohmaier1-0/+0
Project: translations f2b98975dec2b6f7ec340f448f461767513c14c1 update translations for 5.3.3 rc2 and force-fix errors using pocheck Change-Id: Ia6145031ca6088ffe54c6e7c1d60d618cc061284 (cherry picked from commit 7439773399c3b11904cf66e4b24afc7c3c070376)
2017-05-03tdf#88555: band-aid fix, using GetPos/find instead of ContainsThorsten Behrens2-12/+12
to find out whether given format still exists. GetPos was replaced by Contains on multiple places in commit 98436c4b53639d86f261ac630c46d32e3c7b8e28 but sometimes after series of undos/redos, vtable of some items in those format arrays becomes corrupt and it makes dynamic_cast (as used by Contains) fail and Writer falls flat on its face. This is just a workaround, no idea about the root cause. Change-Id: I1e02fd932dbac741687c15900841b9b7c778e2d4 Reviewed-on: https://gerrit.libreoffice.org/37038 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 1df637bde32c484b681ecdfebf56fdca03db7fc1) Reviewed-on: https://gerrit.libreoffice.org/37043 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit e7068a7d9b945e0c6d4965445b6d951038e9c987) Reviewed-on: https://gerrit.libreoffice.org/37193 Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-05-03tdf#107211 sw: ODF import: add a horrible hack to import "Default"Michael Stahl2-0/+25
... character style for hyperlinks and index-entry-templates. The problem is that the "Default" character style doesn't actually exist, it is just displayed in the UI so you can remove a character style that is set. So for the most part there is no need to store "Default" in ODF files, except that for hyperlinks the default isn't "Default" but "Internet Link"/"Visited Internet Link". Hence it was not really a good idea to rename "Default" to "Default Style", because when importing existing documents the text:style-name="Default" is not found, and for new documents text:style-name="Default_20_Style" is not found either because there is no style:style element that sets up the mapping between the encoded style-name and the unencoded display-style-name. Add some hack in SwXMLBodyContext_Impl::SwXMLBodyContext_Impl(), when all style:style elements have been read (so we don't override what's in the document) to create the mapping for "Default", "Default_20_Style" and whatever the translation of that is. (regression from 783d13a9276931e274a90b9b53de2c92dc8c055e) Change-Id: I8a80847571f194204c5df267cb48e826a82328b2 (cherry picked from commit 157013219230f251346a5aa662c39d02f15420ec) Reviewed-on: https://gerrit.libreoffice.org/36788 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 05710ae52ff9962c0852a4e2e59e1814c785b461) Reviewed-on: https://gerrit.libreoffice.org/36936 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-05-03tdf#107427 sw: fix crash when deleting header with selected tableMichael Stahl1-0/+4
Restore resetting of the table cursor point position in SwCursorShell::ParkCursor(), which somehow prevents the crash. (regression from efc5995170f2ffe98374acb16a4f851bede6842d) Change-Id: Ia7ec2967c84cfcffe1718e9604d6b8506c3839a4 (cherry picked from commit b2fdb61446bc072ae1b6db380a584a87a1173f11) Reviewed-on: https://gerrit.libreoffice.org/37007 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit adc0b3b214323d7588cadd17f2b4faafeb5e4e80) Reviewed-on: https://gerrit.libreoffice.org/37057 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-05-03tdf#107126 sw: fix layout crash with section in footnoteMichael Stahl1-0/+6
SwContentFrame::WouldFit_() contains a hack to temporarily reparent a SwTextFrame. In the bugdoc, there is a SwTextFrame below a SwSectionFrame below a SwFootnoteFrame. The reparenting ignores the SwSectionFrame so the result is a SwTextFrame below SwFootnoteFrame, but it still has its mbInfSct set, hence crashes with a null pointer. If the SwTextFrame is permanently moved later on, in SwFlowFrame::MoveBwd() line 2450 a new SwSectionFrame is created. Change-Id: I45a7ab793b4459e551bd11b7fb83dedc58a6c8da (cherry picked from commit 4d43f9e9dda5edeeb6e4b99487b5b6a1fae4bd56) Reviewed-on: https://gerrit.libreoffice.org/37004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 0ae68775afc6227afb881e28c1b2045b3030ad53) Reviewed-on: https://gerrit.libreoffice.org/37056 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2017-05-02redland: add raptor patch to fix some bugsMichael Stahl2-0/+44
Change-Id: I4e3db61fdfe0b984d36b4f67f8e891da48f79ddb (cherry picked from commit 8af6e5e0c4191b12d830b20f72ec3552eea15747) Reviewed-on: https://gerrit.libreoffice.org/36694 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 8044b81f1eaa8ac40acf405d5de450e011c4a34c) Reviewed-on: https://gerrit.libreoffice.org/36740 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-02tdf#107398 sw: do not leave empty footnote container in layoutMichael Stahl1-0/+6
... when applying loop control in SwFlowFrame::MoveBwd(). The SwFootnoteContFrame is newly created in MoveBwd(), line 2062: pNewUpper = m_rThis.GetLeaf( MAKEPAGE_FTN, false ); If it stays empty, that is not a valid layout so delete it again. Since the idle/timer refactoring in VCL the invalid layout stays until the document is closed; presumably before LO 5.0 the timer based layout would reformat things again. (regression from af41b7f91f22052d49654d41ae9916d6981db3f6) Change-Id: I841f42b465f8123f9246f1fa70d1417ffdd57700 (cherry picked from commit e15b8997f0d2e54fa7b8345063755616d0b100b9) Reviewed-on: https://gerrit.libreoffice.org/37008 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 27bbee974eaf59f722c115c9717faa8c74b9d815) Reviewed-on: https://gerrit.libreoffice.org/37058 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-02tdf#107474 sw: fix crash when deleting header with active SdrObjectMichael Stahl1-0/+5
The problem is that the SdrView's text edit mode remains active when the header is deleted, which deletes the active SdrObject that is anchored in the header. Then the next call to SdrBeginTextEdit() will call SdrEndTextEdit() but the mxTextEditObj WeakReference is null then and so the cleanup code that resets the SdrOutliner's UndoManager is not called, but then the SdrOutliner is deleted. What's really horrible about this is that while text editing is active, both SdrObjEditView and ImpEditEngine consider themselves the exclusive owner of SwDoc's UndoManager. (regression from 12a4200e8ff7f045efcc7e9d15a24b15b248c437 and d7b7c9fdfe63deec26c420efc3ff1fd73c21bb27) Change-Id: I17c5165a03d2de1eaba8a335dfbfded56573f8a2 (cherry picked from commit 7f207fca577ef820be2aec0a442df7e8ab6e14a6) Reviewed-on: https://gerrit.libreoffice.org/37069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit e07c2c3861f47946ed72fc9b67aafeaa8598468d) Reviewed-on: https://gerrit.libreoffice.org/37156 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-02nss: upgrade to release 3.29.5Michael Stahl11-136/+53
- fixes CVE-2017-5461 and CVE-2017-5462 - drop ubsan-alignment.patch.0, there is apparently now some NO_SANITIZE_ALIGNMENT macro upstream to get this effect - drop some hunks to prevent hard-coding CC/CCC vars, upstream now respects environment vars (but doesn't quote them...) - drop first hunk of ubsan.patch.0, fixed upstream - drop hunk for gtest-internal.h, header looks much newer anyway Change-Id: I5c484c02c1235e185af1ef5166b069303d3378e1 Reviewed-on: https://gerrit.libreoffice.org/36756 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 0cdf41419af854acccee0f819d4add7e8cafb7dc) Reviewed-on: https://gerrit.libreoffice.org/36795 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit fd957eadfa1a042ceccc4083c275fcc43dfea458) Reviewed-on: https://gerrit.libreoffice.org/37055 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-02ofz#1284 InsertBundle may delete the bundle that pMarkerBundle is pointing toCaolán McNamara1-0/+15
Change-Id: Ic8bd538e80469b672ddd9c5fcceb2f5aac81d2a1 Reviewed-on: https://gerrit.libreoffice.org/37053 Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-02ofz#1220 sanitize nTyp to legal valuesCaolán McNamara1-1/+1
Change-Id: Iad71c4f79dbe03e2e325453eb0506a2d92d67c2d Reviewed-on: https://gerrit.libreoffice.org/36895 Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-02Resolves: tdf#99625 add parameter classification for TEXTJOIN and CONCATEike Rathke1-0/+2
So in array context the functions return a single string instead of an array of identical strings. Change-Id: Ia6ada10be4912745b60e281fac1736c560162d3a (cherry picked from commit f0fef88b747cc4f4de7a5ccb93da9c062545dcfb) Reviewed-on: https://gerrit.libreoffice.org/36743 Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-02add ICU changeset-39671 fix for CVE-2017-7867 CVE-2017-7868Eike Rathke2-0/+190
http://bugs.icu-project.org/trac/changeset/39671 https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=213 https://bugzilla.redhat.com/show_bug.cgi?id=1444101 Reviewed-on: https://gerrit.libreoffice.org/36754 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit c7de8233d15ed0c90fef6c49a54d60cf10119f58) Backported to older MSVC using the UGLY_SIZEOF_MAPTOUCHARS macro instead of sizeof(UTF8Buf::mapToUChars). Change-Id: I4e776ad4fe63c77057b0c823f8672a2b6703346f Reviewed-on: https://gerrit.libreoffice.org/36775 Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-05-02tdf#107205 vcl: don't always use D2DWriteTextOutRendererMichael Stahl2-7/+15
... because it cannot rotate text. (regression from commit df556aa47da22f96b3fcd356c12419d3035cba3c) Change-Id: If9bc6e98b8979c5eb02f1a5cfc12b4d19bdc481b (cherry picked from commit 2eb91035c2f60e9dc476336474d51b23b666bb04) Reviewed-on: https://gerrit.libreoffice.org/36904 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 8f51b4272450b6220f563740538f143c0bc70175) Reviewed-on: https://gerrit.libreoffice.org/36990 Reviewed-by: V Stuart Foote <vstuart.foote@utsa.edu> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-05-02ofz#1193 we only set these values, never read themCaolán McNamara4-14/+1
Change-Id: Ia2f54b536a4262e19abe260e8e19c9b15cc2d0ec Reviewed-on: https://gerrit.libreoffice.org/36782 Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-04-25update creditsChristian Lohmaier1-1754/+1801
Change-Id: Id21b158bcdb4ff51950bcce0869e6c79a7e48fc4 (cherry picked from commit aa6a9bbd66beb234c54d8f881b56da6d8753c423) (cherry picked from commit 3b40661889be16f2034c02d17564f63bda4dabb6)
2017-04-19bump product version to 5.3.3.1.0+Xisco Fauli1-1/+1
Change-Id: Ibd643db9efecbaadfe4ff3cd33725d3ce97509fd
2017-04-19Branch libreoffice-5-3-3Xisco Fauli4-1/+1
This is 'libreoffice-5-3-3' - the stable branch for the 5.3.3 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 5.3.x release, please use the 'libreoffice-5-3' branch. If you want to build something cool, unstable, and risky, use master. Change-Id: Ib8eed517c26e8390956998d394f043d965749a42
2017-04-19call UpdateReference also for single cell copying, tdf#105245Markus Mohrhard1-0/+9
This is a combination of 2 commits. call UpdateReference also for single cell copying, tdf#105245 Reviewed-on: https://gerrit.libreoffice.org/36393 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit cb57a432ba98ffe197c8fd2528e4b363c3285cc4) only handling copy&paste needed, cut&paste bailed out, tdf#105245 follow-up (cherry picked from commit 840ac578dc5c21731b927bad6113839c4c69c108) 946d9f09e7571d347111ad66326ab375d153e298 Change-Id: I5fed22d2835466cbd07f8dbd917e9f881b7b2832 Reviewed-on: https://gerrit.libreoffice.org/36557 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-04-18tdf#92650: handle overwritten references correctly in undo.Kohei Yoshida3-2/+12
(cherry picked from commit de39b6ba3a9edd20a476937ef0c78920df2f5c6d) Conflicts: sc/source/ui/docshell/docfunc.cxx Change-Id: Idc3fbd78f8163c97a9cd80a3ff474b6da0349353 Reviewed-on: https://gerrit.libreoffice.org/36539 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-04-18actually show the newly selected cell, tdf#106194Markus Mohrhard1-0/+1
Change-Id: I0c9f839cbe55f2670602567e61dc4aba77fbef61 Reviewed-on: https://gerrit.libreoffice.org/36303 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit dbc616c0021b86e6365930ba581818fea280d1a8) Reviewed-on: https://gerrit.libreoffice.org/36386 Reviewed-by: Eike Rathke <erack@redhat.com>
2017-04-18catch exception like text_wrapper_get_caret_offset doesCaolán McNamara1-1/+8
Change-Id: I7d681a5cd58af60005eefa9969ec975d5cfc5580 (cherry picked from commit 0d2a607a849e3f1b51092c7d96bc5529420cfab2) Reviewed-on: https://gerrit.libreoffice.org/36635 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-18Updated coreChristian Lohmaier1-0/+0
Project: translations 769636b6ac5701c4378d685440fed2e1f968f4bc update templates for 5.3.3 rc1 Change-Id: Id445b2ee9d0818a5af2de07f08890883065a4399
2017-04-17coverity#1405158 Wrong sizeof argumentCaolán McNamara1-1/+1
Change-Id: Ie6b7fc3d2b7d1ac709501698e55aabc72215b187 (cherry picked from commit b17177c63a4eac55dcdaa3006abec05ab71ca1b4) Reviewed-on: https://gerrit.libreoffice.org/36578 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-04-15tdf#106933 vcl: delete D2DWriteTextOutRenderer before exit()Michael Stahl3-10/+21
As it happens this DirectWrite stuff is using some thread pool internally, and that must be shutdown before exit(), as Win32 will terminate all other threads at that point, and then the thread pool wants to talk to threads that don't exist any more. https://blogs.msdn.microsoft.com/oldnewthing/20120427-00/?p=7763/ So convert this from a global variable that is deleted from DllMain() to a member of SalData, so it is deleted from DeInitVCL(). Change-Id: I51408a07c78758cf0c193ab66b9214d0c9dbd9e3 (cherry picked from commit df556aa47da22f96b3fcd356c12419d3035cba3c) Reviewed-on: https://gerrit.libreoffice.org/36534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-04-13ofz: header has to be at least 1 pair longCaolán McNamara1-1/+9
Change-Id: I5725048519a2b68265e90d12b1e4bcb506c56fc2 (cherry picked from commit e72f3ce68e18ac604469ce5e856341a469af27ff) Reviewed-on: https://gerrit.libreoffice.org/36519 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-04-13Replace EmfPlusRecordType decimal valuse with hexBartosz Kosiorek1-33/+55
Change-Id: Ia5f248282e663e86b76a8c90fb5dd55d112f6912 Reviewed-on: https://gerrit.libreoffice.org/36260 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> (cherry picked from commit 723ee43cf65f85d7b586ae8c98529a22621054a3) Reviewed-on: https://gerrit.libreoffice.org/36522
2017-04-13tdf#106970 DOCX import: don't collapse para auto space for different numsMiklos Vajna3-3/+24
Commit 1bf7f6a1a50ee9f24a3687240fe6ae390b905a6b (tdf#106690 DOCX import: fix automatic spacing before/after numbered para block, 2017-04-04) made sure that autospacing is only collapsed in case the adjacent text nodes both have a numbering rule. It turns out there is an additional condition: even if both text nodes have a numbering rule, do the collapsing only in case they have the same numbering rule. (cherry picked from commit e1c83d0514e6123faa50ad0a7aa6a9031b271c9a) Change-Id: Idb7a2b24d7eaa9094cc36f86b8a483045a33d028 Reviewed-on: https://gerrit.libreoffice.org/36510 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-12tdf#92007 python scripts with tuple-assignments fails on access from GUIWerner Tietz1-1/+6
Change-Id: Ice1d7d92cec56751cb26cbb31a5995ab30895125 Reviewed-on: https://gerrit.libreoffice.org/36399 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 7ef47336411389ac492729bef52fe62aebe90f5a) Reviewed-on: https://gerrit.libreoffice.org/36483
2017-04-12Resolves: tdf#106078 get bounding box of commented region for gtk3 tooltipsCaolán McNamara1-1/+19
Change-Id: I4fdc1f471c6c191be9c7c611926bd2b5b2b41308 (cherry picked from commit eb433f83a5f66dd1ca8ed0c62ef9cc0761b7f0ac) Reviewed-on: https://gerrit.libreoffice.org/36383 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-12ofz#1062 ensure cshape lifecycle matches expectationsCaolán McNamara5-35/+26
Change-Id: I586e9b3546516a0f05d86b2f7dd93e7c292a6795 Reviewed-on: https://gerrit.libreoffice.org/36300 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-12infinite SetDefaultSize->SetPosSize->SetDefaultSizeCaolán McNamara1-1/+2
https://retrace.fedoraproject.org/faf/reports/1278627/ presumably the 'optimal' starting size hits the invalid size path causing another attempt usin the optimal size, so force a valid initial fallback size Change-Id: I6c38ee5e1b90ce41a4550c8a8370e791f5c351b0 (cherry picked from commit 4930acb18bbd145fd995084cd95e3e9d631424ed) Reviewed-on: https://gerrit.libreoffice.org/36453 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-12tdf#106690 DOCX import: fix automatic spacing before/after numbered para blockMiklos Vajna5-7/+59
The context is text nodes with automatic before/after spacing and numbering rules set, like: A * B * C * D E The correct behavior seems to be (though I haven't found this explicitly written in the OOXML spec) to drop spacing between B and C and C and D, but not before B and not after D. Originally no spacing was dropped, then commit c486e875de7c8e845594f5043a37ee8800865782 (tdf#95031 DOCX import: auto spacing inside numbering means no spacing, 2016-10-18) removed spacing around all B/C/D. Fix the problem by checking the numbering rules and automatic after spacing of the previous paragraph, so spacing before B and after D is not removed. Change-Id: Icbdb36e31057ab0e8ac033888cf5cc7c52dad5d0 Reviewed-on: https://gerrit.libreoffice.org/36062 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 1bf7f6a1a50ee9f24a3687240fe6ae390b905a6b) Reviewed-on: https://gerrit.libreoffice.org/36142 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-12Resolves: tdf#107031 writer depends on ACTION_DEFAULTCaolán McNamara1-0/+8
to do its standard "honor the DragDropMode setting" on drag and drop of outline headings into a document Change-Id: Ie154fb237de57ae18fa22d6f50dbf890fb9ebc77 (cherry picked from commit 55e7f73640d754bf0004a0d8a989e0a20de00351) Reviewed-on: https://gerrit.libreoffice.org/36378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-12ofz: treat short properties as run endCaolán McNamara1-60/+68
Change-Id: I1250f74c9f4ed6679a89c7915fb704c8b8cd693f (cherry picked from commit 5252673d686913210dd65608b7d24b0e9d51cf00) Reviewed-on: https://gerrit.libreoffice.org/36147 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-12don't replace content of formula field when selecting range, tdf#58635Markus Mohrhard1-1/+4
Change-Id: I85953fdd7c2b7f193b2a815564526d985ae2bba4 Reviewed-on: https://gerrit.libreoffice.org/36309 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 42aece949ec96c775b31216bddd723aa5321e966) Reviewed-on: https://gerrit.libreoffice.org/36310 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-04-11out-of-bounds tab access when deleting second last sheetEike Rathke1-2/+2
Which in a debug build lead to STL assert Error: attempt to subscript container with out-of-bounds index Change-Id: I09fddbc9e4b214b0313c193f85830ed458d20c0e (cherry picked from commit 0c55972d747511dbc711f3c9cbb4db5d8c5dc2ff) Reviewed-on: https://gerrit.libreoffice.org/36274 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-04-11backport various fixes to aid future backportingCaolán McNamara8-500/+435
ofz#725 fix hwp leak Change-Id: I09088981ca63b297781307590092725bc1cbed1b (cherry picked from commit 681b6361f23a8f20511ad97989c642b07f25c495) valgrind: uninitialized reads Change-Id: Ia1e821d1e323d85c65484c980be09f015af6517b (cherry picked from commit afabc7d2f2fcf8fcd39ff5002f09c32e8f03d4bb) partial loplugin:useuniqueptr extend to catch more localvar cases hwpfilter part of... commit aa09b0c27a6d925da428d6267daadc7338829869 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu Apr 6 09:46:06 2017 +0200 loplugin:useuniqueptr extend to catch more localvar cases i.e. where the code looks like { foo * p = new foo; ... delete p; return ...; } Change-Id: Iad770d1904b2373b1bf8ce609f4c95882388eff8 ofz: epic slow use of std::list Change-Id: I790a3098272101fd33f83f21bdcef1bb061efd76 Reviewed-on: https://gerrit.libreoffice.org/34635 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 283e843be91ef4d727c0815d1b8a0420fd16a7fd) use rtl::Reference in HwpReader instead of storing both a raw pointer and an uno::Reference (cherry picked from commit 0bab51d8ad35a31685002118cdac20657b57137a) Change-Id: I02dd356d9693116f98ad2b96951570b3ba448b14 Reviewed-on: https://gerrit.libreoffice.org/36299 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-04-10tdf#106692 writerfilter: RTF import: fix \'0d in \leveltextMichael Stahl2-2/+10
It's not a newline but yet another one of those bizarre RTF-encodings. (regression from 10e733908038407791f9c14af2a86417cc4a653c) Change-Id: I568050b031b95ac0b6ebfa1a0c39107e62f68bed (cherry picked from commit 69b7204164945cfed385d58e64592ce1b17937d7) Reviewed-on: https://gerrit.libreoffice.org/36284 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-04-10rhbz#1438179 sw: fix toolbar "Next Track Change" / "Previous..."Michael Stahl2-25/+4
There's some confusing workarounds in SwView::Execute() that aren't needed if the SwCursorShell just calls NormalizePam() so it always makes progress. Change-Id: I3b014079b19925041234fcd858526148890f560c (cherry picked from commit 25eb0899227830cca7f28006376962d84f8e9c7a) Reviewed-on: https://gerrit.libreoffice.org/36166 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-04-10prev/next buttons start invisible in the .uiCaolán McNamara1-5/+2
Change-Id: Iec577adb469109a11188e83d95de6ed3960bc1c4 (cherry picked from commit 4a84cbaa3786e6ef9fa91c7eb3a6a49a9010456b) Reviewed-on: https://gerrit.libreoffice.org/36157 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-04-10Resolves: tdf#106725 paint default window bg before spin button bgCaolán McNamara1-3/+9
Change-Id: I0c7f982c3a47f45d022271eba69ebed896288d78 (cherry picked from commit 6f0f2278662e29d054690a85bad6583b5c65f918) Reviewed-on: https://gerrit.libreoffice.org/36097 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-04-10tdf#106253 Precision as shown for thousand dividorLaurent Balland-Poirier2-0/+12
Info().nThousand contains number of thousands dividors after which digits are not displayed, i.e. 12345 is displayed as 12 with format 0, (in en_US) Change-Id: Ifa5540f2efd8ab006a07eade53f7aa0d31a19eac Reviewed-on: https://gerrit.libreoffice.org/35097 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 60d7644a46970e6eaee882e0c5d65692da206c24) Reviewed-on: https://gerrit.libreoffice.org/35204
2017-04-10tdf#106252 Engineering notation for Precision as shownLaurent Balland-Poirier3-30/+98
with more tests Reviewed-on: https://gerrit.libreoffice.org/35089 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 5f2db66ad0de6fbbae309850516e17eaa17934cb) Change-Id: Ifc77b847af4eaaa3c85e904e46c2663b6d768241 Reviewed-on: https://gerrit.libreoffice.org/36369 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-04-10Tests for "Precision as shown" following tdf#105657 tdf#106052Laurent Balland-Poirier2-0/+107
I was unabled to add these test svl/qa/unit/svl.cxx because they required ScDocument::RoundValueAsShown() Found that other formats are not supported by "Precision as shown" option: - engineering tdf#106252 - thousand tdf#106253 Change-Id: Iaf98c404cabec0f5c69f94f2bf863351487fe9d7 Reviewed-on: https://gerrit.libreoffice.org/34750 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 7496f7d3cae8a932dc43ede8a30a99289366a264) Reviewed-on: https://gerrit.libreoffice.org/36368
2017-04-10tdf#106052 Treat SubFormat for "Precision as shown"Laurent Balland-Poirier4-2/+18
Get precision from the correct subformat Change-Id: I458e5b3d1fb515864f19499ac9ac529e1d68a267 Reviewed-on: https://gerrit.libreoffice.org/34505 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit e7f769bc67d3f132b477b3c253f8065243b9b8ac) Reviewed-on: https://gerrit.libreoffice.org/36367
2017-04-10don't obtain the underlying SvNumberformat thrice, tdf#105657 follow-upEike Rathke2-4/+9
... which all GetFormatTable()->...(nFormat) do. Also introduce SvNumberformat::GetMaskedType() for convenience. Change-Id: I9495d71b99116e74e8b877ffc9cd21bd36cc7b7f (cherry picked from commit 820cb1f86f3fd177877b8719315fc03534e2049c) Reviewed-on: https://gerrit.libreoffice.org/36366 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>