summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2017-04-19call UpdateReference also for single cell copying, tdf#105245Markus Mohrhard1-0/+9
This is a combination of 2 commits. call UpdateReference also for single cell copying, tdf#105245 Reviewed-on: https://gerrit.libreoffice.org/36393 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit cb57a432ba98ffe197c8fd2528e4b363c3285cc4) only handling copy&paste needed, cut&paste bailed out, tdf#105245 follow-up (cherry picked from commit 840ac578dc5c21731b927bad6113839c4c69c108) 946d9f09e7571d347111ad66326ab375d153e298 Change-Id: I5fed22d2835466cbd07f8dbd917e9f881b7b2832 Reviewed-on: https://gerrit.libreoffice.org/36557 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-04-18tdf#92650: handle overwritten references correctly in undo.Kohei Yoshida3-2/+12
(cherry picked from commit de39b6ba3a9edd20a476937ef0c78920df2f5c6d) Conflicts: sc/source/ui/docshell/docfunc.cxx Change-Id: Idc3fbd78f8163c97a9cd80a3ff474b6da0349353 Reviewed-on: https://gerrit.libreoffice.org/36539 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-04-18actually show the newly selected cell, tdf#106194Markus Mohrhard1-0/+1
Change-Id: I0c9f839cbe55f2670602567e61dc4aba77fbef61 Reviewed-on: https://gerrit.libreoffice.org/36303 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit dbc616c0021b86e6365930ba581818fea280d1a8) Reviewed-on: https://gerrit.libreoffice.org/36386 Reviewed-by: Eike Rathke <erack@redhat.com>
2017-04-18catch exception like text_wrapper_get_caret_offset doesCaolán McNamara1-1/+8
Change-Id: I7d681a5cd58af60005eefa9969ec975d5cfc5580 (cherry picked from commit 0d2a607a849e3f1b51092c7d96bc5529420cfab2) Reviewed-on: https://gerrit.libreoffice.org/36635 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-18Updated coreChristian Lohmaier1-0/+0
Project: translations 769636b6ac5701c4378d685440fed2e1f968f4bc update templates for 5.3.3 rc1 Change-Id: Id445b2ee9d0818a5af2de07f08890883065a4399
2017-04-17coverity#1405158 Wrong sizeof argumentCaolán McNamara1-1/+1
Change-Id: Ie6b7fc3d2b7d1ac709501698e55aabc72215b187 (cherry picked from commit b17177c63a4eac55dcdaa3006abec05ab71ca1b4) Reviewed-on: https://gerrit.libreoffice.org/36578 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-04-15tdf#106933 vcl: delete D2DWriteTextOutRenderer before exit()Michael Stahl3-10/+21
As it happens this DirectWrite stuff is using some thread pool internally, and that must be shutdown before exit(), as Win32 will terminate all other threads at that point, and then the thread pool wants to talk to threads that don't exist any more. https://blogs.msdn.microsoft.com/oldnewthing/20120427-00/?p=7763/ So convert this from a global variable that is deleted from DllMain() to a member of SalData, so it is deleted from DeInitVCL(). Change-Id: I51408a07c78758cf0c193ab66b9214d0c9dbd9e3 (cherry picked from commit df556aa47da22f96b3fcd356c12419d3035cba3c) Reviewed-on: https://gerrit.libreoffice.org/36534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-04-13ofz: header has to be at least 1 pair longCaolán McNamara1-1/+9
Change-Id: I5725048519a2b68265e90d12b1e4bcb506c56fc2 (cherry picked from commit e72f3ce68e18ac604469ce5e856341a469af27ff) Reviewed-on: https://gerrit.libreoffice.org/36519 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-04-13Replace EmfPlusRecordType decimal valuse with hexBartosz Kosiorek1-33/+55
Change-Id: Ia5f248282e663e86b76a8c90fb5dd55d112f6912 Reviewed-on: https://gerrit.libreoffice.org/36260 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> (cherry picked from commit 723ee43cf65f85d7b586ae8c98529a22621054a3) Reviewed-on: https://gerrit.libreoffice.org/36522
2017-04-13tdf#106970 DOCX import: don't collapse para auto space for different numsMiklos Vajna3-3/+24
Commit 1bf7f6a1a50ee9f24a3687240fe6ae390b905a6b (tdf#106690 DOCX import: fix automatic spacing before/after numbered para block, 2017-04-04) made sure that autospacing is only collapsed in case the adjacent text nodes both have a numbering rule. It turns out there is an additional condition: even if both text nodes have a numbering rule, do the collapsing only in case they have the same numbering rule. (cherry picked from commit e1c83d0514e6123faa50ad0a7aa6a9031b271c9a) Change-Id: Idb7a2b24d7eaa9094cc36f86b8a483045a33d028 Reviewed-on: https://gerrit.libreoffice.org/36510 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-12tdf#92007 python scripts with tuple-assignments fails on access from GUIWerner Tietz1-1/+6
Change-Id: Ice1d7d92cec56751cb26cbb31a5995ab30895125 Reviewed-on: https://gerrit.libreoffice.org/36399 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 7ef47336411389ac492729bef52fe62aebe90f5a) Reviewed-on: https://gerrit.libreoffice.org/36483
2017-04-12Resolves: tdf#106078 get bounding box of commented region for gtk3 tooltipsCaolán McNamara1-1/+19
Change-Id: I4fdc1f471c6c191be9c7c611926bd2b5b2b41308 (cherry picked from commit eb433f83a5f66dd1ca8ed0c62ef9cc0761b7f0ac) Reviewed-on: https://gerrit.libreoffice.org/36383 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-12ofz#1062 ensure cshape lifecycle matches expectationsCaolán McNamara5-35/+26
Change-Id: I586e9b3546516a0f05d86b2f7dd93e7c292a6795 Reviewed-on: https://gerrit.libreoffice.org/36300 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-12infinite SetDefaultSize->SetPosSize->SetDefaultSizeCaolán McNamara1-1/+2
https://retrace.fedoraproject.org/faf/reports/1278627/ presumably the 'optimal' starting size hits the invalid size path causing another attempt usin the optimal size, so force a valid initial fallback size Change-Id: I6c38ee5e1b90ce41a4550c8a8370e791f5c351b0 (cherry picked from commit 4930acb18bbd145fd995084cd95e3e9d631424ed) Reviewed-on: https://gerrit.libreoffice.org/36453 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-12tdf#106690 DOCX import: fix automatic spacing before/after numbered para blockMiklos Vajna5-7/+59
The context is text nodes with automatic before/after spacing and numbering rules set, like: A * B * C * D E The correct behavior seems to be (though I haven't found this explicitly written in the OOXML spec) to drop spacing between B and C and C and D, but not before B and not after D. Originally no spacing was dropped, then commit c486e875de7c8e845594f5043a37ee8800865782 (tdf#95031 DOCX import: auto spacing inside numbering means no spacing, 2016-10-18) removed spacing around all B/C/D. Fix the problem by checking the numbering rules and automatic after spacing of the previous paragraph, so spacing before B and after D is not removed. Change-Id: Icbdb36e31057ab0e8ac033888cf5cc7c52dad5d0 Reviewed-on: https://gerrit.libreoffice.org/36062 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 1bf7f6a1a50ee9f24a3687240fe6ae390b905a6b) Reviewed-on: https://gerrit.libreoffice.org/36142 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-12Resolves: tdf#107031 writer depends on ACTION_DEFAULTCaolán McNamara1-0/+8
to do its standard "honor the DragDropMode setting" on drag and drop of outline headings into a document Change-Id: Ie154fb237de57ae18fa22d6f50dbf890fb9ebc77 (cherry picked from commit 55e7f73640d754bf0004a0d8a989e0a20de00351) Reviewed-on: https://gerrit.libreoffice.org/36378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-12ofz: treat short properties as run endCaolán McNamara1-60/+68
Change-Id: I1250f74c9f4ed6679a89c7915fb704c8b8cd693f (cherry picked from commit 5252673d686913210dd65608b7d24b0e9d51cf00) Reviewed-on: https://gerrit.libreoffice.org/36147 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-12don't replace content of formula field when selecting range, tdf#58635Markus Mohrhard1-1/+4
Change-Id: I85953fdd7c2b7f193b2a815564526d985ae2bba4 Reviewed-on: https://gerrit.libreoffice.org/36309 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 42aece949ec96c775b31216bddd723aa5321e966) Reviewed-on: https://gerrit.libreoffice.org/36310 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-04-11out-of-bounds tab access when deleting second last sheetEike Rathke1-2/+2
Which in a debug build lead to STL assert Error: attempt to subscript container with out-of-bounds index Change-Id: I09fddbc9e4b214b0313c193f85830ed458d20c0e (cherry picked from commit 0c55972d747511dbc711f3c9cbb4db5d8c5dc2ff) Reviewed-on: https://gerrit.libreoffice.org/36274 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-04-11backport various fixes to aid future backportingCaolán McNamara8-500/+435
ofz#725 fix hwp leak Change-Id: I09088981ca63b297781307590092725bc1cbed1b (cherry picked from commit 681b6361f23a8f20511ad97989c642b07f25c495) valgrind: uninitialized reads Change-Id: Ia1e821d1e323d85c65484c980be09f015af6517b (cherry picked from commit afabc7d2f2fcf8fcd39ff5002f09c32e8f03d4bb) partial loplugin:useuniqueptr extend to catch more localvar cases hwpfilter part of... commit aa09b0c27a6d925da428d6267daadc7338829869 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu Apr 6 09:46:06 2017 +0200 loplugin:useuniqueptr extend to catch more localvar cases i.e. where the code looks like { foo * p = new foo; ... delete p; return ...; } Change-Id: Iad770d1904b2373b1bf8ce609f4c95882388eff8 ofz: epic slow use of std::list Change-Id: I790a3098272101fd33f83f21bdcef1bb061efd76 Reviewed-on: https://gerrit.libreoffice.org/34635 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 283e843be91ef4d727c0815d1b8a0420fd16a7fd) use rtl::Reference in HwpReader instead of storing both a raw pointer and an uno::Reference (cherry picked from commit 0bab51d8ad35a31685002118cdac20657b57137a) Change-Id: I02dd356d9693116f98ad2b96951570b3ba448b14 Reviewed-on: https://gerrit.libreoffice.org/36299 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-04-10tdf#106692 writerfilter: RTF import: fix \'0d in \leveltextMichael Stahl2-2/+10
It's not a newline but yet another one of those bizarre RTF-encodings. (regression from 10e733908038407791f9c14af2a86417cc4a653c) Change-Id: I568050b031b95ac0b6ebfa1a0c39107e62f68bed (cherry picked from commit 69b7204164945cfed385d58e64592ce1b17937d7) Reviewed-on: https://gerrit.libreoffice.org/36284 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-04-10rhbz#1438179 sw: fix toolbar "Next Track Change" / "Previous..."Michael Stahl2-25/+4
There's some confusing workarounds in SwView::Execute() that aren't needed if the SwCursorShell just calls NormalizePam() so it always makes progress. Change-Id: I3b014079b19925041234fcd858526148890f560c (cherry picked from commit 25eb0899227830cca7f28006376962d84f8e9c7a) Reviewed-on: https://gerrit.libreoffice.org/36166 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-04-10prev/next buttons start invisible in the .uiCaolán McNamara1-5/+2
Change-Id: Iec577adb469109a11188e83d95de6ed3960bc1c4 (cherry picked from commit 4a84cbaa3786e6ef9fa91c7eb3a6a49a9010456b) Reviewed-on: https://gerrit.libreoffice.org/36157 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-04-10Resolves: tdf#106725 paint default window bg before spin button bgCaolán McNamara1-3/+9
Change-Id: I0c7f982c3a47f45d022271eba69ebed896288d78 (cherry picked from commit 6f0f2278662e29d054690a85bad6583b5c65f918) Reviewed-on: https://gerrit.libreoffice.org/36097 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-04-10tdf#106253 Precision as shown for thousand dividorLaurent Balland-Poirier2-0/+12
Info().nThousand contains number of thousands dividors after which digits are not displayed, i.e. 12345 is displayed as 12 with format 0, (in en_US) Change-Id: Ifa5540f2efd8ab006a07eade53f7aa0d31a19eac Reviewed-on: https://gerrit.libreoffice.org/35097 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 60d7644a46970e6eaee882e0c5d65692da206c24) Reviewed-on: https://gerrit.libreoffice.org/35204
2017-04-10tdf#106252 Engineering notation for Precision as shownLaurent Balland-Poirier3-30/+98
with more tests Reviewed-on: https://gerrit.libreoffice.org/35089 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 5f2db66ad0de6fbbae309850516e17eaa17934cb) Change-Id: Ifc77b847af4eaaa3c85e904e46c2663b6d768241 Reviewed-on: https://gerrit.libreoffice.org/36369 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-04-10Tests for "Precision as shown" following tdf#105657 tdf#106052Laurent Balland-Poirier2-0/+107
I was unabled to add these test svl/qa/unit/svl.cxx because they required ScDocument::RoundValueAsShown() Found that other formats are not supported by "Precision as shown" option: - engineering tdf#106252 - thousand tdf#106253 Change-Id: Iaf98c404cabec0f5c69f94f2bf863351487fe9d7 Reviewed-on: https://gerrit.libreoffice.org/34750 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 7496f7d3cae8a932dc43ede8a30a99289366a264) Reviewed-on: https://gerrit.libreoffice.org/36368
2017-04-10tdf#106052 Treat SubFormat for "Precision as shown"Laurent Balland-Poirier4-2/+18
Get precision from the correct subformat Change-Id: I458e5b3d1fb515864f19499ac9ac529e1d68a267 Reviewed-on: https://gerrit.libreoffice.org/34505 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit e7f769bc67d3f132b477b3c253f8065243b9b8ac) Reviewed-on: https://gerrit.libreoffice.org/36367
2017-04-10don't obtain the underlying SvNumberformat thrice, tdf#105657 follow-upEike Rathke2-4/+9
... which all GetFormatTable()->...(nFormat) do. Also introduce SvNumberformat::GetMaskedType() for convenience. Change-Id: I9495d71b99116e74e8b877ffc9cd21bd36cc7b7f (cherry picked from commit 820cb1f86f3fd177877b8719315fc03534e2049c) Reviewed-on: https://gerrit.libreoffice.org/36366 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-04-10tdf#105657 Treat "Precision as shown" for fractionsLaurent Balland-Poirier5-63/+119
For Option "Precision as shown", fraction must specificly be treated ImpGetFractionElements retrieves values of each part of fraction (integer, numerator, denominator) independently from its exact representation Update: avoid include of zformat.hxx in document4.cxx Change-Id: Ia3ea2322f3d311c04ef71f3260730c7154c3dc15 Reviewed-on: https://gerrit.libreoffice.org/34331 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 5706b29974c1c3ab0ba5a23685accf2fbebc3e06) Reviewed-on: https://gerrit.libreoffice.org/36365 Tested-by: Jenkins <ci@libreoffice.org>
2017-04-10Resolves: tdf#102286 lets not crash on null pFrameCaolán McNamara1-2/+5
this is the FlyEmbeddedPrt case ensure we don't end up with a null pFrame at return time (cherry picked from commit 5ce387c4812466e6752b434cf0f5a54f98c6a147) Change-Id: I68ff6f0a36462cffc47d774865e69041c4dd15a8 Reviewed-on: https://gerrit.libreoffice.org/36277 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-10tdf#106943 Lock down Experimental features and Macro recordingGabor Kelemen1-0/+6
Visually disable these features if they are locked by system administrators Change-Id: Ib35840312ad9c506e689ec6c9d432a88c07a5c28 Reviewed-on: https://gerrit.libreoffice.org/36095 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/36319 Tested-by: Jenkins <ci@libreoffice.org>
2017-04-07Resolves: tdf#106732 the intent was surely to return a const refCaolán McNamara1-1/+1
Change-Id: Iaaa1f76a689645adaebf4fe5b87003ad238f71f2 (cherry picked from commit a7d008a8dfdc0a8b42061329b5e756b1b034abaf) Reviewed-on: https://gerrit.libreoffice.org/36276 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-07tdf#106190 Fix (again) left alignment of denominatorLaurent Balland-Poirier2-19/+13
Instead of moving spaces from left to right, like it was done previously, this patch insert spaces directly on right when in denominator This avoid complex calculation when user enter such (stupid) format: # ?/ ??? or # ?/" hello world "??? In SvNumberformat::ImpNumberFill, for NF_SYMBOLTYPE_FRAC_FDIV you need at least to move in sBuf, to insert text at the expected place for (stupid) format like # ?/ 100 or # ?/" hello world "100 All these formats works, but are stored in ODF with text after fraction Change-Id: I296e60643e93242b8006848a643135219ad4ad0c Reviewed-on: https://gerrit.libreoffice.org/35320 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 2fd110a78d03510d031c4c6cf6ad380d82899df8) Reviewed-on: https://gerrit.libreoffice.org/36232
2017-04-07Resolves: tdf#100011 (re-)add ocCeil and ocFloor .xls(x) export mappingsEike Rathke2-2/+7
This is a combination of 2 commits. Resolves: tdf#100011 (re-)add ocCeil and ocFloor .xls(x) export mappings ... for CEILING and FLOOR that were lost when introducing CEILING.MATH and FLOOR.MATH which are semantically identical, but the export needs a distinct known mapping otherwise the function is stored as a macro call, which Excel dislikes. (cherry picked from commit ea01a08763e56a7de66f0c24655a627669c8a7f7) these FUNCFLAG_EXPORTONLY need also FUNCFLAG_MACROCALL_NEW, tdf#100011 related Maybe one day we'll actually use these tables also for export capabilities ... (cherry picked from commit 4dd95cadcd330aee49b3c84d3e336b808217af46) f3d55ec008e321d95b21e0d284c7d58d13a2399b Change-Id: Id371c1732984a8e5567f74fd265b9aee88fb1898 Reviewed-on: https://gerrit.libreoffice.org/36233 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-04-07tdf#106974 docx export: Crop is "long", not sal_Int16Justin Luth3-4/+14
I got size sal_Int16 from the return value type of the border spacing, but somehow failed to lookup the return value of GraphicCrop. It now matches .doc export's sal_Int32. Bad mistake: regression 8eff1decd91cbfb10094c25d4cf1d2b434a4da72 Change-Id: Ie149630b9da9a067de319149f23ca21f78a186cf Reviewed-on: https://gerrit.libreoffice.org/36231 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-04-07tdf#104706 Enable icon for Clear Direct Formatting commandYousuf Philips1-0/+3
Change-Id: Iba3cbd8148794ac984a91d22d33cdec1f4453c5f Reviewed-on: https://gerrit.libreoffice.org/36221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 54f6a0fe470096f6bdc3942e9f3032e40dbfcd23) Reviewed-on: https://gerrit.libreoffice.org/36237 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-04-06ofz: treat short properties as run endCaolán McNamara1-1/+1
Change-Id: I00a5bab63663e2dde43825707e84568fca6aa594 Reviewed-on: https://gerrit.libreoffice.org/36216 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-06tdf#105908: restore previously deleted range references upon undo.Kohei Yoshida5-2/+49
Change-Id: If1932a5eb10da4c50fbcc3329af75f2e7a0a5137 Reviewed-on: https://gerrit.libreoffice.org/35607 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> (cherry picked from commit 749405af4fc38e0c16dc7e860d23a13dfceb4e40) Reviewed-on: https://gerrit.libreoffice.org/35672 Reviewed-by: Eike Rathke <erack@redhat.com>
2017-04-06tdf#106868: fix crash when modify external linkNoel Grandin6-64/+57
The EndDialog callback Hdl was disposing the Dialog, which is a little troublesome since the stack wants to go back through the Dialog code when the callback is done. Rather just the more normal synchronous Execute() style of Dialog execute, instead of the asynchronous StartExecuteModal. Change-Id: I14933bd475da228c9648a6fa0564bda4a60d9d12 Reviewed-on: https://gerrit.libreoffice.org/36074 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit cedbc4031f26ea13b188a4ecc5b90cc9646095fb) Reviewed-on: https://gerrit.libreoffice.org/36179
2017-04-05tdf#104686: do not crash if Menu has been somehow disposedAron Budea5-32/+58
The rare crashes in MenuFloatingWindow::ImplGetStartY() and MenuFloatingWindow::ImplScroll(bool) likely happen because of a disposed Menu. Let's guard against invalid accesses. Change-Id: Ie31240abbc48c06edd40d0a95f319725cdb3db16 Reviewed-on: https://gerrit.libreoffice.org/36026 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/36151 Reviewed-by: Aron Budea <aron.budea@collabora.com>
2017-04-05tdf#106237 sw: do some basic sanity checking on layout-cacheMichael Stahl3-10/+56
The bugdoc, with claimed generator AOO4.1.1 on Windows, contains a bogus layout-cache: debug:26706:1: nType P nIndex 29 2147483647 debug:26706:1: nType P nIndex 66 2147483647 debug:26706:1: nType P nIndex 105 2147483647 debug:26706:1: nType P nIndex 142 2147483647 debug:26706:1: nType P nIndex 178 2147483647 debug:26706:1: nType P nIndex 205 2147483647 debug:26706:1: nType P nIndex 229 2147483647 debug:26706:1: nType T nIndex 314 65535 Due to a loop-control this causes incorrect pagination if CalcLayout() is called only once. It should look like this: debug:26765:1: nType T nIndex 382 65535 debug:26765:1: nType T nIndex 790 65535 In this case we can easily detect that the indexes and types in the layout-cache are bogus by checking against the node types, so do that in SwLayHelper::SwLayHelper(). (cherry picked from commit 8a5374f2fdbd1e15c107133f55930cbc431edbd5) sw: [loplugin:sallogareas] (cherry picked from commit 282b3e8c4d45aacae57e3542b872cdbfebcc7195) loplugin:loopvartoosmall (cherry picked from commit dbaab58c1442e7f62ef0732376fe5a49840e9fd6) Change-Id: I7091af49a8c29bf0a11ceff0be9ba84b1f710fdb Reviewed-on: https://gerrit.libreoffice.org/36046 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-04-05Related: tdf#106515 show OpenSymbol if unavailable StarSymbol requestedCaolán McNamara1-0/+7
Change-Id: I442df1c44839642bd1f91afedee577214032466b (cherry picked from commit 011e1cdbf33e50626f1fefa8b7b4031fa368f3e8) Reviewed-on: https://gerrit.libreoffice.org/35974 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-04-05Resolves: tdf#106080 fix explicitly setting automatic in search by formatCaolán McNamara2-7/+21
this is still somewhat broken in that what you see is not what you get if you don't explicitly set automatic, but clears the regression part of things in that the old broken behavior is restored instead of the new broken behavior Change-Id: I8f53a276ee60f5c9f2f28d3b92a13990cc20314a (cherry picked from commit d7f1a1689d70b2d66d0f727b6a898ef1a971da9d) Reviewed-on: https://gerrit.libreoffice.org/35894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-04-05ofz: check olst sprm for valid ANLD payload lenCaolán McNamara1-0/+8
Change-Id: Ic1b6681a3f48ef0fe3f52eda9db8b7bc003ded55 (cherry picked from commit 98151bf95bda8d647310bdba6936dc6b388b05de) Reviewed-on: https://gerrit.libreoffice.org/36098 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-05tdf#106938 TSA Dialog: Improve Dialog LayoutThomas Beck1-37/+29
Moved Label above the content area Change-Id: I0a23af5540bedc849c83fd342ac43538827e6b4a Reviewed-on: https://gerrit.libreoffice.org/36071 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 3873669fef3cac05a9b530de08f15e0d2a3fdc57) Reviewed-on: https://gerrit.libreoffice.org/36105 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-04-05Resolves: tdf#106935 restore traditional toolbar labelsCaolán McNamara3-6/+21
(cherry picked from commit f1a53e7a0b388e0a5303fe68dfbb4c60f4c7a0ff) Change-Id: I00cf16e9ce429f9186cc900a07f4d386e33b8f7b Reviewed-on: https://gerrit.libreoffice.org/36083 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-04-04ofz: guard against bogus sprm lenCaolán McNamara1-0/+5
Change-Id: I9b4074e1024753549f468f427afbfdf9cd01b674 (cherry picked from commit d30fb62f4f1022ae6294e246974d0018596cf8ec) ofz: guard harder against bogus sprm len Change-Id: Ic82526e1454b24f094d3deee89647e88760bc44b (cherry picked from commit 924624b40a97d6925f66374259c2c21707805fcd) Reviewed-on: https://gerrit.libreoffice.org/36078 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-04ofz: check anldPap sprm for valid ANLD payload lenCaolán McNamara1-0/+7
Change-Id: Ie034e3b37e01c29cf19fe8ad78b1121f6eadecb2 Reviewed-on: https://gerrit.libreoffice.org/36053 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 29cf858a971273039fff50808082f231dbd43c92) Reviewed-on: https://gerrit.libreoffice.org/36075 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-04ofz: check bounds on readCaolán McNamara3-19/+31
Change-Id: I07779bec876b90e36f20a81d6dbf06ae727edf85 (cherry picked from commit fb05611064e12c8eda09bc32c42544cde8c2ab49) Reviewed-on: https://gerrit.libreoffice.org/36018 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-17 17:20:50 +0000