summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2017-01-11Related tdf#100151: use disposeAndClear for mpShowWindow (sd)Julien Nabet1-1/+1
See https://bugs.documentfoundation.org/show_bug.cgi?id=100151#c33 Change-Id: I81e483189eacee086b680367148f8dd3ca2d3493 Reviewed-on: https://gerrit.libreoffice.org/32904 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit bce35b8e13b0d82ba54bf3d380f448dad0ee13bb) Reviewed-on: https://gerrit.libreoffice.org/32947
2017-01-10tdf#104830, need an own termination listener for lib objectsMarkus Mohrhard5-9/+66
The destruction of the SwDLL object happens already through the normal termination listener but the other termination listeners might still depend on it. Also the outstanding events might need the SwDLL instance to be still around. This makes the destruction of the instance explicit and at a time when it should be safe. We should use the same code for calc, impress, math and base as well. Change-Id: I50b8f30426f5a4a54e362e748fe962839abca73e Reviewed-on: https://gerrit.libreoffice.org/32926 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-10Updated coreChristian Lohmaier1-0/+0
Project: translations 86d6efcc43918d0c1252b02e808f921cbc4f5a34 update translations for 5.3.0 rc2 and force-fix errors using pocheck Change-Id: Iaa074827e5f9e841a2f013a7de4e5e902fe88824
2017-01-10Resolves: tdf#104711 adjust range reference constructed of named anchorsEike Rathke4-10/+45
A constructed range reference of named anchors (i.e. extended during expression compilation) forms a range listened at that needs to be adjusted if the cell is shifted and one or both anchor parts are individually named relative references. Currently the resulting range (ScComplexRefData aka DoubleRef) does not know to distinguish between whether its anchors are the result of a literal range in a named expression or the result of individually named anchors, so such RelName DoubleRef needs to be adjusted unconditionally when shifting or moving the formula cell. Change-Id: I75e2cc79ac60116671acce7641567337d5f5f7ed (cherry picked from commit 439b2a134218b93e6ca9fa23005b89c19498f586) Reviewed-on: https://gerrit.libreoffice.org/32923 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-01-10ucb: cmis::DataSupplier::queryContent() looks rather questionableMichael Stahl1-4/+6
It's not immediately obvious if the caller is responsible for checking the index validity here, but all the other sub-classes of ResultSetDataSupplier that i looked at do check the index so do the same here. Change-Id: Ib0c5c38cb28282f08752cdb03202e4d6f3566693 (cherry picked from commit 84de69638362c7b575560e0da3efbc709b7ac476) Reviewed-on: https://gerrit.libreoffice.org/32906 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-10ucb: ReacquireableGuard::reacquire() is a no-opMichael Stahl3-80/+76
So remove this junk and use osl::ResettableGuard instead which actually works. Change-Id: Ieb49fab16c94f0a2847ee5a1b95b52f2c141c674 (cherry picked from commit a5a94537d804f20a0d6472ef2e5995cee2d5b2fe) Reviewed-on: https://gerrit.libreoffice.org/32907 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-10Resolves: rhbz#1409634 crash on close storing clipboard of database tableCaolán McNamara1-2/+1
Change-Id: I8e692314b4ef278f7881780d51bcecb60ca80c3f (cherry picked from commit 6c2725038b627535ba97ead89dadb96e0ff69c3c)
2017-01-10ofz#394 xbm ParseDefine problemCaolán McNamara1-2/+2
Change-Id: I75fb761d23fdb3780088a9d209200429edb57a26 Reviewed-on: https://gerrit.libreoffice.org/32877 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-01-10tdf#103225 revert setting of a fixed size for the dialogTomaž Vajngerl1-3/+0
Setting fixed size of a dialog causes a mess with HiDPI and could also cause problems with certain languages because the translated strings could streach the dialog size. It is better to let the dialog calculate its ideal size depending on the content, which in some cases is not ideal but at least it shouldn't create a mess. The decision to revert this was done in design hangout on 2016-12-22. Change-Id: I0ad1e38e1625cdbbf65b846118995bd5d3ebb47e Reviewed-on: https://gerrit.libreoffice.org/32912 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 62a94dcf0c750e335d6ce272d8a5df9813910d5a) Reviewed-on: https://gerrit.libreoffice.org/32913 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-01-09tdf#104944 gtk3: Ignore mouse up event if the wrong frameMaxim Monastirsky1-3/+4
Change-Id: I3d0aad6d2b434866df9110d3b8493fec2d2c94fe Reviewed-on: https://gerrit.libreoffice.org/32465 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit 23a13694a5a70098b5ecd58b99d99618111f3ea5)
2017-01-09tdf#105009 sw: fix a11y crash when removing drawing objectMichael Stahl1-4/+8
SwFrame::RemoveDrawObj() calls SwAnchoredObject::ChgAnchorFrame(0) so the SwAnchoredDrawObj has no anchor frame later when SwAccessibleMap::InvalidateCursorPosition() asks for the parent. (regression from 76c549eb01dcb7b5bf28a271ce00e386f3d388ba) Change-Id: Id55cb5fc41a4e37e863498265d1565e1621d508e (cherry picked from commit ade1d4c36053c2a7aed959e3dd09ebc1b8430ea8) Reviewed-on: https://gerrit.libreoffice.org/32802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-09tdf#105143 DOCX import: enable DoNotCaptureDrawObjsOnPage layout compat optionMiklos Vajna3-0/+9
Because that's what Word does to show only part of the shape in the bugdoc. Conflicts: writerfilter/source/filter/WriterFilter.cxx Change-Id: Ic5cb84cace9237671d71eda0c64e9dadfe244cb9 Reviewed-on: https://gerrit.libreoffice.org/32782 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/32784 Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-01-07Updated coreAndras Timar1-0/+0
Project: translations c54ca62057567513359adf7d7dce38167b54eb29 Updated Slovenian translation Change-Id: Ifbe0a2092a580deef5a4accc8ab4124789eaedae
2017-01-06recognize the broken "Err:xxx" written by 5.2 and earlier, tdf#105024 relatedEike Rathke1-5/+16
... and handle same as "#ERRxxx!" if present. Change-Id: I1ebb31d628b080c52b450a8fe624c20e9e1188b7 (cherry picked from commit 75d963bc7bb87429f304d29138c27178880c039a) Reviewed-on: https://gerrit.libreoffice.org/32793 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-06read single error constant formula as such, tdf#105024 relatedEike Rathke4-10/+25
... without creating a token so when writing again no leading '=' is prepended, with which we can enable 5.2 to read such thing correctly, and when re-reading in 5.3 it also doesn't lead to a "real" formula. Change-Id: I26fbd20536436b49b781e2bbb5bba1dc6bafbb37 (cherry picked from commit 4fcbe16959c839bfacf745cfa554b234e639f794) Reviewed-on: https://gerrit.libreoffice.org/32792 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-06check length of string as this can be called untokenized, tdf#105024 relatedEike Rathke1-2/+3
i.e. during import of ODFF Change-Id: I7f5419d393f89d8a84efca7444e8dde3a3e9199f (cherry picked from commit b36bf9f567f5b531f526dad6776c84e06203396f) Reviewed-on: https://gerrit.libreoffice.org/32791 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-06out of bounds string accessEike Rathke1-1/+1
Change-Id: Iecbe24f90cefe34a447cd52a44967a4b09b4394b (cherry picked from commit 00f17500520bcb2634146496adc8de9f4d28eea5) Reviewed-on: https://gerrit.libreoffice.org/32787 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-06Resolves: tdf#105061 Only one text box shown in case of 'between'Caolán McNamara2-0/+9
non-layout ScCondFormatList widget not responding to layout child change Change-Id: I7edd4fc54de9e71fb86b47a9b182bfc22fa4af25 (cherry picked from commit ac561ab34ea9d26243fe3791f624c440dcf7ae6d)
2017-01-06tdf#105127 VML import: handle <v:shape style="flip:..." path="...">Miklos Vajna3-0/+29
I don't see an easy way to implement this via UNO, so use the internal API. As to the internal API usage, SdrEditView::MirrorMarkedObjVertical() (for UI) and SvxMSDffManager::ImportShape() (for WW8 import) are example client code. Change-Id: I9bf27788db32fd35d6b56e0f1a240c4b7abc5604 (cherry picked from commit ac03883cd66a2d58c17c8dac555a053586e46625) Reviewed-on: https://gerrit.libreoffice.org/32778 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-01-06gbuildtoide: builddir is not necessarily same as srcdirChristian Lohmaier1-3/+6
Change-Id: Ied9f9abcc75f2edcd518ac247907f573aa21f35e Reviewed-on: https://gerrit.libreoffice.org/32405 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-06libpng: update to release 1.6.28Thorsten Behrens1-2/+2
Change-Id: Ie22e5eb6656ef1d2e7903011ea72a1aa26d4da7c Reviewed-on: https://gerrit.libreoffice.org/32768 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-01-06check "#ERRxxx!" constants for accepted error values, tdf#105024 follow-upEike Rathke2-1/+68
Change-Id: I9a11695710baa2f4e022c8e07f01b962cfabe2e7 (cherry picked from commit 6b89bcf85a911d043c9d93e843be12e6f23adedd) Reviewed-on: https://gerrit.libreoffice.org/32763 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-01-06check token array code errors when testing for equality, tdf#105024 relatedEike Rathke2-0/+16
To not end up with a series of equal errors when importing individual error cells and attempting to group them. Change-Id: Idfcbb2e7077fc8799ef925c2c2e17188ac5e3b14 (cherry picked from commit 44021bd4018f4f97d9f0f6b6e1f0a256e8853537) Reviewed-on: https://gerrit.libreoffice.org/32762 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-01-06Resolves: tdf#105024 generate and parse detailed "#ERRxxx!" error constantsEike Rathke1-1/+20
Change-Id: I4e5d98cdbbc2f3e7746cd3892f70151376bc5808 (cherry picked from commit 857be5b2db4b2726306199bc279942f621bf55d8) Reviewed-on: https://gerrit.libreoffice.org/32761 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-05process all outstanding events before shutdown, tdf#104969, tdf#104286, ↵Markus Mohrhard1-0/+5
tdf#104399 Change-Id: Id09c3dfdc94c430d5dcb2aebb017f17db80f17e6 Reviewed-on: https://gerrit.libreoffice.org/32486 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-on: https://gerrit.libreoffice.org/32667
2017-01-05tdf#105024 use context to generate "error only" formula stringEike Rathke1-1/+4
The ScGlobal::GetErrorString() shortcut produced error constants in the localized UI language, which was wrong anyway when storing ODFF. Use compiler with context instead to generate the proper symbols. However, this currently maps all not defined Err:xxx to #NULL! so to preserve those additional work is needed. Change-Id: I1de7621d6349d5b00a5aac1cedc9f265c78c7db1 (cherry picked from commit 896dd3962cd7e62bb2a9ebc6f97ff77936ec06a8) Reviewed-on: https://gerrit.libreoffice.org/32752 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-05Resolves: tdf#104919 crash with empty ScNavigatorDlg memberCaolán McNamara2-0/+10
commit 292560a957498bed70b625c992ec6bcf631dceb3 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Mon Oct 17 13:23:23 2016 +0200 loplugin:unusedmethods detected the intended methods to do this were unused, so restore then, but hook them up this time Change-Id: I3b7e4a557696a91a70956487468b99fec6324a93 (cherry picked from commit f91dc0342de13e648dba5d9a93c01db23ae83533)
2017-01-05require firebird 3.0 for build (don't allow 2.5)Lionel Elie Mamane2-17/+4
Keep firebird_integer_x64le.odb around for a future 3.x firebird that will allow opening Firebird 2.5 databases, so that we can test this capacity in our tests. Change-Id: I05dbef51284bdb25132ff6cb661659430eea6a92 (cherry picked from commit 860ecb9e583627ab43097784ad98b41afd983ff6) Reviewed-on: https://gerrit.libreoffice.org/32753 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-05handle paste special of single formula cell if IsEmptyDisplayedAsString()Eike Rathke1-0/+5
Similar to CopyCellsFromClipHandler. Change-Id: I7da8a55c3648c6f04c5f3b11459764fd42f51399 (cherry picked from commit 3afe82bd63fde41d2a88418fb64e4ff587b05436) Reviewed-on: https://gerrit.libreoffice.org/32743 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-05handle paste special of single formula cell with error resultEike Rathke1-0/+7
This apparently was never implemented, unlike in the block pasting code that handles it fine. Formula cells with error results were always copied as is if numeric was requested, even if formulas weren't requested. Change-Id: Id550c4e757b6bb2c06aa0637328216383cdf3d6b (cherry picked from commit 12ecd30476f17c6f6efde976f8e56d604eda0f1e) Reviewed-on: https://gerrit.libreoffice.org/32742 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-05tdf#99616 writerfilter: hideMark shouldn't force min sizeJustin Luth3-3/+14
hideMark in Word does not force the minimum possible row size, but simply ignores any cell marker styles/sizings. So an empty row then takes on the "at least" size defined for the row. Change-Id: Id24a52f2a360a5040c2eed5c17757c0d32d03520 Reviewed-on: https://gerrit.libreoffice.org/32380 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 1a58cdf8af1aba52ce0a376666dd7d742234d7cf) Reviewed-on: https://gerrit.libreoffice.org/32721
2017-01-05tdf#43370 docfnote.cxx: return correct FTNNUM for GetNumberingJustin Luth1-1/+1
way back in 2001 commit a7afc46b3766e4000ae5a9b8a914ede36bbd2991 removed the option to select per-chapter footnote-numbering for footnotes placed at the end of the document (or perhaps chapter since the variable is called FTNPOS_CHAPTER, but the UI refers to it as document). So only "Per Document" remained. However the function GetNumbering was never updated to reflect that fact that 2 options were removed from the list now, instead of one. So, the UI reported the choice as "Per Page", the only dropdown choice available was "Per Document", and the actual implemented choice was "Per Chapter". How's that for a mess? Change-Id: Ib8dc3d07c0ef62d39afdd2a1c78c14527649c6df Reviewed-on: https://gerrit.libreoffice.org/32700 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 15ca00601701c50ccdb3d8dbe08ba705787386a7) Reviewed-on: https://gerrit.libreoffice.org/32732
2017-01-04vcl: hold VclPtrs to avoid possible lifecycle related crashers.Michael Meeks1-13/+13
Makes code on common EnableInput crash reporter trace safer. Change-Id: Ibcf218d0d2460383d12e19f48aaf0ab08e541532 Reviewed-on: https://gerrit.libreoffice.org/32706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 61aa97c1be23398acb7e9160763b621f63c13d88) Reviewed-on: https://gerrit.libreoffice.org/32719 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-04tdf#104744 RTF import: fix unexpected zero para left margin wrt style dedupMiklos Vajna3-29/+76
See commit 1be0a3fa9ebb22b607c54b47739d4467acfed259 (n#825305: writerfilter RTF import: override style properties like Word, 2014-06-17) for the details on style override in RTF. Here the problem was that we added an unneeded "reset to 0" property, the opposite situation that commit 657c6cc3acec0528209a8584b838cd6de581c437 (tdf#104228 RTF import: fix override of style left/right para margin, 2016-12-13) was fixing (there a "reset to 0" was missing). (cherry picked from commit a9e029ace41562e28e9242d63230ad1ca275f5d3) Change-Id: I37f079b9cb4773214d2531c2e34920b3b8927211 Reviewed-on: https://gerrit.libreoffice.org/32718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-04gbuild: CppunitTest: export VCL_HIDE_WINDOWSMichael Stahl1-1/+1
This currently has no effect and so the CppunitTest_cppcanvas_emfplus pops up an annoying window. (regression from 181932b31ea9c07a9bec3677e73b67a9a6d4e3f2) Change-Id: I26314d98f10f6b39ca1c28821ccd0de6ba2a4358 (cherry picked from commit bde8054e1801ffd2e4bcdb7b4d6ba08f5ceddd6a) Reviewed-on: https://gerrit.libreoffice.org/32726 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-04tdf#103626 don't scale application icon to prevent a start-up loopTomaž Vajngerl3-24/+40
Reviewed-on: https://gerrit.libreoffice.org/32382 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 96b95f5010be090ebae6f755d4d3891a2334332c) + commit e36d9ae2cbe45f33aaaef3eb33eff9d13ee04a66 Typo: scalePrecentage->scalePercentage Author: Julien Nabet <serval2412@yahoo.fr> Change-Id: I2e65ba16d93167dc4abb029c7e941e91be9a62ab Reviewed-on: https://gerrit.libreoffice.org/32401 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-01-04tdf#104981 Fix deficiencies with PERCENTRANK functions.Winfried Donkers1-2/+7
Added constraint check for significance argument. Replced inproper use of log() with log10(). Improved code efficiency a little bit. Change-Id: Ie918857e6a04ea9fcf18410f789d7252f9c1cfc8 Reviewed-on: https://gerrit.libreoffice.org/32528 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit facb4e69e4c75839df89969206403d2e97146dbd) Reviewed-on: https://gerrit.libreoffice.org/32703
2017-01-04tdf#104339 Partially revert d5649ae7b76278cb3155f951d6327157c7c92b65Xisco Fauli1-18/+1
Change-Id: I5160c6efe7cf58351955d9d1d3066e3b33bdfe20 Reviewed-on: https://gerrit.libreoffice.org/32082 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 5903235d57acb13d9d5286d23b443a01aeab9a3c) Reviewed-on: https://gerrit.libreoffice.org/32146 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-01-03tdf#105026 Remove wrong constraint in PERMUTATIONA.Winfried Donkers1-1/+1
With permutations with repetitions, argument selection may be larger than argument elements. Probably inadvertently copied from PERMUT; has been there from pre-git. Change-Id: Icdee18eca647fb278f140630e45844684a1e3046 Reviewed-on: https://gerrit.libreoffice.org/32569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 25625f18a282209235214674f2b81604ecd067ad) Reviewed-on: https://gerrit.libreoffice.org/32704
2017-01-03WaE: unused variableDavid Tardon1-1/+1
Change-Id: Ib701d3adf1e79554e2ddcefb5943092e3a886041 (cherry picked from commit 99f3f180034b78900e9ff6953b9866fde3da01d6) Reviewed-on: https://gerrit.libreoffice.org/32694 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-02tdf#104876 writerfilter: m_bTableSizeTypeInserted = false hereJustin Luth2-1/+6
fixes commit cbd0fbc287051f918e4adb32b3e9b58dfbf8059d which removed the insertion code with the explanation saying we should simply not do anything, and that'll lead to the right behavior, don't try to be smart and try to set TABLE_WIDTH here but still left the flag set, falsely indicating that the tableSizeType had been inserted. Change-Id: I0720083c992d1d03a5fe259d5b4b177a0c8108f8 TODO: the table size still isn't correct. Reviewed-on: https://gerrit.libreoffice.org/32385 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit e73c961a7fb23246dc4a9c27d7ed0808b9ba74b5) Reviewed-on: https://gerrit.libreoffice.org/32636
2017-01-02ofz#355: lsan detected leakCaolán McNamara1-0/+1
Direct leak of 1296 byte(s) in 6 object(s) allocated from: #0 0x5de7a0 in __interceptor_calloc /src/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:72 #1 0xe0f2132 in hb_shape_plan_t* hb_object_create<hb_shape_plan_t>() /work/workdir/UnpackedTarball/harfbuzz/src/./hb-object-private.hh:129:24 #2 0xe0f2132 in hb_shape_plan_create /work/workdir/UnpackedTarball/harfbuzz/src/hb-shape-plan.cc:133 #3 0x85a3488 in CommonSalLayout::LayoutText(ImplLayoutArgs&) /src/libreoffice/vcl/source/gdi/CommonSalLayout.cxx:555:40 #4 0x3d97cf2 in OutputDevice::ImplLayout(rtl::OUString const&, int, int, Point const&, long, long const*, SalLayoutFlags, vcl::TextLayoutCache const*) const /src/libreoffice/vcl/source/outdev/text.cxx:1318:36 #5 0x3d990e1 in OutputDevice::GetTextArray(rtl::OUString const&, long*, int, int, vcl::TextLayoutCache const*) const /src/libreoffice/vcl/source/outdev/text.cxx:966:35 #6 0x3d98d2d in OutputDevice::GetTextWidth(rtl::OUString const&, int, int, vcl::TextLayoutCache const*) const /src/libreoffice/vcl/source/outdev/text.cxx:893:19 #7 0x485f630 in ImplFontMetricData::ImplInitTextLineSize(OutputDevice const*) /src/libreoffice/vcl/source/font/fontmetric.cxx:338:30 #8 0x3d6801e in OutputDevice::ImplNewFont() const /src/libreoffice/vcl/source/outdev/font.cxx:1095:42 #9 0x3d64d92 in OutputDevice::GetFontMetric() const /src/libreoffice/vcl/source/outdev/font.cxx:171:23 #10 0x8695053 in WinMtfFontStyle::WinMtfFontStyle(LOGFONTW&) /src/libreoffice/vcl/source/filter/wmf/winmtf.cxx:265:36 #11 0x8686b9b in std::__1::unique_ptr<WinMtfFontStyle, std::__1::default_delete<WinMtfFontStyle> > o3tl::make_unique<WinMtfFontStyle, LOGFONTW&>(LOGFONTW&) /src/libreoffice/include/o3tl/make_unique.hxx:27:35 #12 0x86eb23c in WMFReader::ReadRecordParams(unsigned short) /src/libreoffice/vcl/source/filter/wmf/winwmf.cxx:937:32 #13 0x86fb901 in WMFReader::ReadWMF() /src/libreoffice/vcl/source/filter/wmf/winwmf.cxx:1371:25 #14 0x47c5949 in ReadWindowMetafile(SvStream&, GDIMetaFile&) /src/libreoffice/vcl/source/filter/wmf/wmf.cxx:78:45 #15 0x61c7ac in LLVMFuzzerTestOneInput /src/libreoffice/vcl/workben/wmffuzzer.cxx:98:11 #16 0x1011f7e8 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) /src/libfuzzer/FuzzerLoop.cpp:541:13 #17 0x10120544 in fuzzer::Fuzzer::RunOne(unsigned char const*, unsigned long) /src/libfuzzer/FuzzerLoop.cpp:492:3 #18 0x1013ecca in fuzzer::Fuzzer::RunOne(std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > const&) /src/libfuzzer/FuzzerInternal.h:118:41 #19 0x1011ee3d in fuzzer::Fuzzer::ShuffleAndMinimize(std::__1::vector<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::allocator<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > > >*) /src/libfuzzer/FuzzerLoop.cpp:471:30 #20 0x100d0aea in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) /src/libfuzzer/FuzzerDriver.cpp:533:6 #21 0x100c38c8 in main /src/libfuzzer/FuzzerMain.cpp:20:10 #22 0x7fef8459582f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f) Change-Id: Iaa23f8282a45b7c584410b5e8c7b6e9774a34aaf Reviewed-on: https://gerrit.libreoffice.org/32508 Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit d19c05bbf0073033573ef428b63f37e7caa12337) Reviewed-on: https://gerrit.libreoffice.org/32586 Tested-by: Jenkins <ci@libreoffice.org>
2017-01-02tdf#81263 ww8par6: only use valid sal_uInt16 values for ULSpaceJustin Luth1-2/+3
VerticalOrient position returns a signed SwTwips number, but ULSpace uses unsigned int16, so negative numbers were creating huge margins. fixes commit 3755c87d0426a499d4755e82d8fbc77caa240764 Change-Id: I23daea9a913ef73efc42a65e0adfc393eaf4e775 Reviewed-on: https://gerrit.libreoffice.org/32400 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> (cherry picked from commit 604cf7024fce29143150ab77b2f14b59a45e61eb) Reviewed-on: https://gerrit.libreoffice.org/32402 Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-01-02ofz#372 check if ImplSplit succeededCaolán McNamara2-5/+10
Change-Id: I1e34295fe3ee5f77e787f583616d52fa92a0eca4 (cherry picked from commit 62a97e6a561ce65e88d4c537a1b82c336f012722)
2017-01-02ofz#358 SJIS_84 table mnLeadEnd is out by oneCaolán McNamara1-3/+3
sjis 82 and 83 correctly denote the last index available while 84 reports one past the last available index 0x84BE is the last value to map, not 0x84BF Change-Id: Idcadc2d554ee59586f6e2f2775301fe69c94d55a (cherry picked from commit 0f4eb22d5f3a86af9e5f8042c69e4ddf4a350b93) Reviewed-on: https://gerrit.libreoffice.org/32588 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-02Updated coreAndras Timar1-0/+0
Project: help 0df61eb0f112955ec3ea5e060df80fc8fbe9f62d Wikihelp converter cannot handle switch in switch Change-Id: I18ffb8a5ec7421431088fe094b541571ffccd1fc Reviewed-on: https://gerrit.libreoffice.org/32439 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-01-02Updated coreAndras Timar1-0/+0
Project: help d0cf5a48ffb60b28d8da5e22a16e62280561c667 Fix validation errors against xmlhelp.dtd Change-Id: I453fb62f45b445b360d4722db83023a633053fb8 Reviewed-on: https://gerrit.libreoffice.org/32437 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/32440 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2017-01-01tdf#104539 dir attribute of outerShdw has to be non-negativeAndras Timar1-1/+1
Change-Id: Ic6f1c8555eb8d137ced2f4e87baa866df84c69ac Reviewed-on: https://gerrit.libreoffice.org/32470 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-31tdf#105011, tdf#104795: copy string until its end if there's no commaJulien Nabet1-2/+4
5 0x00002aaab055f81e in rtl::OUString::copy (this=0x7fffffff29d0, beginIndex=3, count=-4) at /home/julien/lo/libreoffice/include/rtl/ustring.hxx:2223 6 0x00002aaab070acd2 in (anonymous namespace)::GetContentPart (_rRawString="CN=timur.davletshin@gmail.com", _rPartId="CN") at /home/julien/lo/libreoffice/sfx2/source/dialog/dinfdlg.cxx:748 7 0x00002aaab070dd85 in SfxDocumentPage::ImplUpdateSignatures (this=0x55555ca2e0b0) at /home/julien/lo/libreoffice/sfx2/source/dialog/dinfdlg.cxx:901 so do the same as GetContentPart from uui/source/secmacrowarnings.cxx (I suppose we should avoid the redundancy but that's another story) Change-Id: Ief3ce1cce7035fb572778bdee02a1073b7dfe1c1 Reviewed-on: https://gerrit.libreoffice.org/32530 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 5e149b630bd837ca6c8cae609a5c148f25f9ee82) Reviewed-on: https://gerrit.libreoffice.org/32532 Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-31tdf#104622 Add duplicate node entry to elements in emoji.json databaseGaurav Dhingra2-349/+698
Add boolean field "duplicate": true Change-Id: I8e45ed4694bfc75b18c2405146e5eaa142559c1b Reviewed-on: https://gerrit.libreoffice.org/31997 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> (cherry picked from commit 9fa5439cb6aa695ca2e3fefd4426bdd150091cbe) Reviewed-on: https://gerrit.libreoffice.org/32217 Tested-by: Akshay Deep <akshaydeepiitr@gmail.com>