summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2017-01-02valgrind: stick 0 at end of successfully read dataCaolán McNamara1-2/+2
(cherry picked from commit 0dfc6f70ab53a773ee05664235d7c8927ab20f2c) (cherry picked from commit 3ea598f65bed096dbf4bda5fe4105b57c58b5310) Change-Id: Id79f68c9095ab313ac05d2c8b55df71788df81d3 Reviewed-on: https://gerrit.libreoffice.org/32335 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-02Resolves: ofz#310: Sanitize 1 bit bitmap palette indexes tooCaolán McNamara1-16/+48
(cherry picked from commit b08e48166310ab8a53f06f4fee227a948416cf4a) (cherry picked from commit 3bff2da31ed580817f6b5b653f48727e38078af5) crashtesting: fix bmp->odg failure... id:000178,src:000000,op:havoc,rep:16.bmp id:000383,src:000047,op:flip2,pos:18,+cov.bmp id:000403,src:000047,op:arith32,pos:22,val:-33.bmp id:000317,src:000025,op:havoc,rep:8.bmp id:000119,src:000000,op:havoc,rep:16.bmp id:000167,src:000000,op:havoc,rep:8.bmp revealed since commit 81e3ca4f60e6ac0823c1233841c22a759cfe937f Author: Tor Lillqvist <tml@collabora.com> Date: Tue Jun 21 10:34:21 2016 +0300 Use real assert() instead of DBG_ASSERT() sanitize invalid palette entry indexes at the outer perimeter on initial load to try and avoid having to do it in all sort of places in the interior. we load the palette before getting here, so we should always know the palette size here (cherry picked from commit 92cee94a262a3a2f43c87bb940c50cb90a2ebd89) Change-Id: Ied2b71eb1c9088bbbff5fed97f7a04b43f4b4827 Reviewed-on: https://gerrit.libreoffice.org/32333 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-02tdf#81263 ww8par6: only use valid sal_uInt16 values for ULSpaceJustin Luth1-2/+3
VerticalOrient position returns a signed SwTwips number, but ULSpace uses unsigned int16, so negative numbers were creating huge margins. fixes commit 3755c87d0426a499d4755e82d8fbc77caa240764 Change-Id: I23daea9a913ef73efc42a65e0adfc393eaf4e775 Reviewed-on: https://gerrit.libreoffice.org/32400 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> (cherry picked from commit 604cf7024fce29143150ab77b2f14b59a45e61eb) Reviewed-on: https://gerrit.libreoffice.org/32402 Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 70b3dd697cb248fb56830db691269fe9e78c57fb) Reviewed-on: https://gerrit.libreoffice.org/32648
2017-01-02tdf#104876 writerfilter: m_bTableSizeTypeInserted = false hereJustin Luth1-1/+3
fixes commit cbd0fbc287051f918e4adb32b3e9b58dfbf8059d which removed the insertion code with the explanation saying we should simply not do anything, and that'll lead to the right behavior, don't try to be smart and try to set TABLE_WIDTH here but still left the flag set, falsely indicating that the tableSizeType had been inserted. TODO: the table size still isn't correct. Reviewed-on: https://gerrit.libreoffice.org/32385 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit e73c961a7fb23246dc4a9c27d7ed0808b9ba74b5) Change-Id: I0720083c992d1d03a5fe259d5b4b177a0c8108f8 Reviewed-on: https://gerrit.libreoffice.org/32647 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-01-02Revert "tdf#103514: Always ignore bitmap fonts on Windows"Khaled Hosny1-49/+61
This reverts commit e80621fb04093d5ab950485357f6058dcbaf8aaf. Lots of crashes related to this change, lets revert and see if we can fix it in 5.3: http://crashreport.libreoffice.org/stats/signature/ImplReleaseTempFonts(SalData%20&) Change-Id: I86b7d85fe1bfb7be28fbed7dc8957f71d1bedc55 Reviewed-on: https://gerrit.libreoffice.org/32591 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-02ofz#358 SJIS_84 table mnLeadEnd is out by oneCaolán McNamara1-3/+3
sjis 82 and 83 correctly denote the last index available while 84 reports one past the last available index 0x84BE is the last value to map, not 0x84BF Change-Id: Idcadc2d554ee59586f6e2f2775301fe69c94d55a (cherry picked from commit 0f4eb22d5f3a86af9e5f8042c69e4ddf4a350b93) Reviewed-on: https://gerrit.libreoffice.org/32589 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-01Resolves: tdf#104812 crash on exporting odpCaolán McNamara1-0/+3
was crashtesting: a gadzillion failures on export to odp e.g. fdo35235-1.odp (cherry picked from commit f1c08d6503442ec257aa8535dfbe3743c743e4a0) (cherry picked from commit 09b856289c44c0fe792082b681d48cf5ee70d808) Change-Id: I259cdc9ed073be2ad7d5208cd943d4f193f09c16 Reviewed-on: https://gerrit.libreoffice.org/32275 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-01-01tdf#71435: Accessible caret-moved events are missing when "freeze" is enabledTamás Zolnai1-1/+1
Two accessible document is created when "freeze" options is enabled. meSplitPos identifies which accessible document handle which part of the window. We should handle events only in that accessible document which handles the active part. Change-Id: Ic9674344951f620546dd272beaad796de611d258 Reviewed-on: https://gerrit.libreoffice.org/32065 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 06ea887f8ba34a628d7641eab210501f7bd2493d) Reviewed-on: https://gerrit.libreoffice.org/32078 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-01tdf#105011, tdf#104795: copy string until its end if there's no commaJulien Nabet1-2/+4
5 0x00002aaab055f81e in rtl::OUString::copy (this=0x7fffffff29d0, beginIndex=3, count=-4) at /home/julien/lo/libreoffice/include/rtl/ustring.hxx:2223 6 0x00002aaab070acd2 in (anonymous namespace)::GetContentPart (_rRawString="CN=timur.davletshin@gmail.com", _rPartId="CN") at /home/julien/lo/libreoffice/sfx2/source/dialog/dinfdlg.cxx:748 7 0x00002aaab070dd85 in SfxDocumentPage::ImplUpdateSignatures (this=0x55555ca2e0b0) at /home/julien/lo/libreoffice/sfx2/source/dialog/dinfdlg.cxx:901 so do the same as GetContentPart from uui/source/secmacrowarnings.cxx (I suppose we should avoid the redundancy but that's another story) Change-Id: Ief3ce1cce7035fb572778bdee02a1073b7dfe1c1 Reviewed-on: https://gerrit.libreoffice.org/32530 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 5e149b630bd837ca6c8cae609a5c148f25f9ee82) Reviewed-on: https://gerrit.libreoffice.org/32533 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-01tdf#104539 dir attribute of outerShdw has to be non-negativeAndras Timar1-1/+1
Change-Id: Ic6f1c8555eb8d137ced2f4e87baa866df84c69ac Reviewed-on: https://gerrit.libreoffice.org/32471 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-01tdf#104818 Show the right label when a11y enabledMaxim Monastirsky1-5/+5
Change-Id: If4da5b9435e96e3830bac3d01e06f7ddc87754eb (cherry picked from commit c9303b98ad69213fe346d0657a8bca5ac8fa3bd7) Reviewed-on: https://gerrit.libreoffice.org/32377 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-29add a crashreporter entry when we start the shutdownMarkus Mohrhard2-0/+4
This will help us identify shutdown related crashes. Reviewed-on: https://gerrit.libreoffice.org/32485 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Conflicts: framework/source/services/desktop.cxx Change-Id: Id09c3dfdc94c430d5dcb2aebb017f17db80f17e5 Reviewed-on: https://gerrit.libreoffice.org/32488 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-12-29Updated coreAndras Timar1-0/+0
Project: dictionaries b776c82c78b1cf53fc7269b725733aaaa3d98aac tdf#97349: typo fixes in control words Change-Id: I4896dd4084582e893914f09e730a2dd7d5a08acd Reviewed-on: https://gerrit.libreoffice.org/32477 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-12-20Resolves: tdf#103938 replace fix for tdf#78599/tdf#87977Caolán McNamara1-2/+14
i.e. revert commit 162c72d64077d9e0dae820d881ce2b56a5b2040c Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Jan 23 13:17:39 2015 +0000 and commit ad50b9a8636e0ee2f3c80669e8dde96577b26c4e Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Jan 23 15:52:58 2015 +0000 Related: fdo#78599 wrong method and restore the original RegisterToFormat logic, and instead block setting modifications of the document until the explicit SetModified call to avoid the original problem of trying to generate a preview of the document during the section where it cannot be done Change-Id: I9dbec0a371d4d747b780aa271789d50a46eccefd Reviewed-on: https://gerrit.libreoffice.org/31977 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-12-20tdf#104767: Fix calculus of child index in commitTableEvent (accessibility)Julien Nabet1-1/+1
bt: 1 0x00002aaade2fea5b in accessibility::AccessibleGridControlTableBase::ensureIsValidIndex (this=0x5555586abdb0, nChildIndex=11) at /home/julien/lo/libreoffice/accessibility/source/extended/AccessibleGridControlTableBase.cxx:257 2 0x00002aaade2f97f2 in accessibility::AccessibleGridControlTable::getAccessibleChild (this=0x5555586abdb0, nChildIndex=11) at /home/julien/lo/libreoffice/accessibility/source/extended/AccessibleGridControlTable.cxx:60 3 0x00002aaade2ee054 in accessibility::AccessibleGridControl::commitTableEvent (this=0x555557e97500, _nEventId=5, _rNewValue=uno::Any(void), _rOldValue=uno::Any(void)) at /home/julien/lo/libreoffice/accessibility/source/extended/AccessibleGridControl.cxx:354 Seems a regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=0f32ba56a1e775e8ecd6c827ebd48f7f2fb51c81 Change-Id: Ia973eb381832da27ecc39fc5273f67a685d5a7bb Reviewed-on: https://gerrit.libreoffice.org/32205 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 4e1c423358f60f7516a1682c97837edd21addcf3) Reviewed-on: https://gerrit.libreoffice.org/32209 (cherry picked from commit 899ea62194d59a69e04823962a3170f762a02e9b) Reviewed-on: https://gerrit.libreoffice.org/32210 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-12-19tdf#104488 editeng,svx: throw less Accessible exceptionsMichael Stahl3-22/+5
For some of these functions it doesn't make sense to throw DisposedException as they can return a sensible default value. Particularly AccessibleShape::getAccessibleChildCount() was throwing an exception that was never caught. (cherry picked from commit 5a3b2111172f106378cbf78aba0fde1db3642275) loplugin:unnecessaryoverride (cherry picked from commit 10bf49c18d56f198e63514953a1c6e2ea17fcc9c) Reviewed-on: https://gerrit.libreoffice.org/32187 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 0dd9e51abc5705b7ae253d3f9b284136cf1597d6) Change-Id: I000149cf9bb0fd13f69650ad8224a8daf26f7bee Reviewed-on: https://gerrit.libreoffice.org/32201 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-19tdf#104722: Wrong text alignment when text box is smaller than the text insideTamás Zolnai1-1/+9
The default TextHorizontalAlignment is block. Setting paragraph alignment (on UI) works when this text alignment property is set to block (otherwise has no effect). In general this works on this way, but the existing algorithm did not work in those cases when the text was bigger than the container shape. Change-Id: I02dba76f8e3033a465bb14dc826521966bb30987 Reviewed-on: https://gerrit.libreoffice.org/32123 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 5694b4970e3af096130e172ac6968b10ed587a6f) Reviewed-on: https://gerrit.libreoffice.org/32127 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-12-17tdf#104613 revert there is a function for that: CalcLineSpaceJustin Luth1-4/+12
it should have been ,m_bBorderDist instead of ,true. In 5.3, m_bBorderDist is always true, but not in 5.2 Just revert back to the original code, since this was just supposed to be a readability change anyway. reverts commit feacae8571d003c60960d852e835a17ef722265c Change-Id: I2cb16e3c05d3c028eb3f8dcecfcf112524385780 Reviewed-on: https://gerrit.libreoffice.org/32110 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2016-12-16tdf#97164 Add text for visualition of percent symbol.Gulsah Kose2-1/+4
Change-Id: I31dc1a7a4ed0bc0e760e10c1a2ff52660a258e12 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/29299 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp> (cherry picked from commit 8e466c431e6d61911b2b15895a4b63df12422057) Reviewed-on: https://gerrit.libreoffice.org/31976 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-14That's probably not meant to be a C++ reference to a uno::ReferenceStephan Bergmann1-1/+1
...as introduced with e75f6e549eb825c310d16d11babf0fba5ee7fd7a "sfx2: make SfxClassificationHelper not require a full doc shell". Made CppunitTest_sfx2_classification crash now when dereferencing m_xDocumentProperties in SfxClassificationHelper::Impl::pushToDocumentProperties, when built with a recent Clang trunk build. Change-Id: Id0b7fa0627b9642f748f07d7dfa05353114225fa (cherry picked from commit e90b004a41153770e672bb1d4524852499ab0ca5) Reviewed-on: https://gerrit.libreoffice.org/32003 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-12-14tdf#104545 SID_PARA_DLG: use passed PaM instead of GetCursorJustin Luth1-1/+1
reverts portion of commit 7d9bb549d498d6beed2c4050c402d09643febdfa Change-Id: Ia683c3bac786a9c2c3b13732b1cb49389074beda Reviewed-on: https://gerrit.libreoffice.org/31953 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit e08355618e13a83210b746c67bb9f7a0b425e1dc) Reviewed-on: https://gerrit.libreoffice.org/31985 Reviewed-by: Justin Luth <justin_luth@sil.org>
2016-12-14tdf#101563 - Export to PDF with linked images creates huge PDF files.Noel Grandin1-1/+1
Looks like it was introduced by commit 19b34c0039c6293f9b37aa70f8055aa2be28ba09 loplugin:passstuffbyref in svtools and since it's windows only, probably some subtle mis-compilation. Aron Budea tracked this one down. Change-Id: I77e65ea8a1fb0003d6ff0f3b0f8019f275ff3462 Reviewed-on: https://gerrit.libreoffice.org/31893 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit b7f92a21a458fc6fa68894fbc881eda0a1e8325e) Reviewed-on: https://gerrit.libreoffice.org/31973 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 871d610bc9b162ae68b263d857cf4168d124d180) Reviewed-on: https://gerrit.libreoffice.org/31974 Tested-by: Jenkins <ci@libreoffice.org>
2016-12-14Resolves: rhbz#1401082 gnome hangs opening a certain .docxCaolán McNamara4-4/+25
this seems to be a problem since.... commit 199eb08be994ef968eb38f4966bc27ef1756d382 Author: Miklos Vajna <vmiklos@collabora.co.uk> Date: Thu Jun 5 16:25:01 2014 +0200 SwAnchoredDrawObject::GetObjBoundRect: avoid SwDoc::SetModified() This is a const method, but it does a const_cast to still resize an object... if that's so, then we should ensure that the "is modified" flag of SwDoc is untouched. CppunitTest_sw_ooxmlimport's testChartSize is a reproducer for this, when shape text is imported as textbox. (note under gtk3 and wayland this isn't as noticable, there use export GDK_BACKEND=x11 to reproduce the freeze effect where even the mouse cursor doesn't move during part of the load) Change-Id: Ic0bd98b032dfe1255d79d8070d50f65fcfa676dd Reviewed-on: https://gerrit.libreoffice.org/31687 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit d393039655edf9bb884fc2956674badde59d2326) Reviewed-on: https://gerrit.libreoffice.org/31949
2016-12-13Resolves: rhbz#1401778 gtk3+wayland switching windows from the menu woesCaolán McNamara3-1/+8
ignore 0 timestamps cause they're useless and get the current event time stamp during MenuBarReturnFocus to determine the timestamp of the menu command dispatch (cherry picked from commit adfcd16220444ef3ea318515c5a331210250e45f) Change-Id: Ia4b00aafc9ef47b41dcca2c160e943200db5c524 (cherry picked from commit 1b2bb1c952a3e8dc5c625c7a9f0042f06ba1c9a0) Reviewed-on: https://gerrit.libreoffice.org/31706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-12-13tdf#101729 recover fnGetSize,fnLeftDist,fnRightDist,fnXIncMark Hung4-0/+29
Above field of struct SwRectFnCollection were removed because of loplugin:unusedfields. I can't find them refered in the source code but they do affect alignments. Partially recover d2df03574023b379ac09b1f71cae9e3ba3ac53e2 and e18b08363a939b35e7f5dc435e606d2c62bddebd. Cherry-picked from 611354a1c2e8281a80a1c3f5076a6c4593a4fe10 Change-Id: I38f2b7a31565773b749cfeb1f47574c390d38527 Reviewed-on: https://gerrit.libreoffice.org/31795 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/31912 (cherry picked from commit 6238f71ddbdc766e733b1c808a4fa7d66f7bde87) Reviewed-on: https://gerrit.libreoffice.org/31955 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-12-13Resolves: tdf#101588, do not prevent color de-selection tdf#96382 follow-upEike Rathke1-2/+6
Comparing colors to determine whether to set one in the result item set does not work if the color previously was set before SaveValue() was called unconditionally even for the "undetermined" color state. Actually we want to know whether the user selected a color instead. Change-Id: I508f791684ebd79ba4af9cb654f9aa0bb25bff5d (cherry picked from commit 429be969b39867d6d9f36978c9ac15b601e78ba6) Reviewed-on: https://gerrit.libreoffice.org/31923 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-13tdf#88351: Revert "coverity#704341 Logically dead code"Julien Nabet1-1/+1
This reverts commit 7b1f5cc16fdbc0c53d0b7f9e3f45decd1136f4fa. Change-Id: I85d4c45025817914d6b78458f24a343f3b05879c Reviewed-on: https://gerrit.libreoffice.org/31017 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 5507b741ccf018c06fb29694d13837abcac4486a) Reviewed-on: https://gerrit.libreoffice.org/31023 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-13oss-fuzz: handle W_META_CREATEFONTINDIRECT like EMR_EXTCREATEFONTINDIRECTWCaolán McNamara3-1/+2
Change-Id: Iaa142d5d0ac0f00e89e8b7d7ffdef8137157cec9 (cherry picked from commit e718ac0ae415bba2988c96c36995755bbfd9df7f) (cherry picked from commit d3ea20e55ca7d82b6121f7ed3db5fd170fcac94f) Reviewed-on: https://gerrit.libreoffice.org/31839 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-12tdf#104405 Clone Formatting ignores vertical text alignmentNoel Grandin5-51/+94
I removed the unit test, since it depends on some other changes to the dumpAsXml code that are not in this branch. Reviewed-on: https://gerrit.libreoffice.org/31623 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit d36aa2ba3132ce62a370b7260ca620642cbf7dbf) Reviewed-on: https://gerrit.libreoffice.org/31746 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit a7d13674bc2271e6f191e8ecda78151a47d413f6) Change-Id: I56cce69ddb21f7f9336b8f59e181e91306e92019 Reviewed-on: https://gerrit.libreoffice.org/31896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-12-11Resolves: rhbz#1362453 use the cairo scaling approach on both wayland and XCaolán McNamara5-25/+2
so have the same hidpi solution on both setups Change-Id: I669eba55830a28c1850f4679dfa824798bd3a383 Reviewed-on: https://gerrit.libreoffice.org/31540 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> (cherry picked from commit 3a9609653697ac851ee1c55a41aa143d3bca335e) Reviewed-on: https://gerrit.libreoffice.org/31836 Tested-by: Khaled Hosny <khaledhosny@eglug.org> (cherry picked from commit abf54716da33b8252c32b545bd02b33eef3b9a07) Reviewed-on: https://gerrit.libreoffice.org/31876
2016-12-11tdf#93430: Cannot get accessible text attributes for 'Not in dictionary' entryTamás Zolnai6-7/+100
Squashed from two commits: tdf#93430: Get run attributes of text objects .. which are not paragraphs. Note: For some reason in character attributes sequence we have a wrong Any value for "CharPosture" property. Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/31591 (cherry picked from commit 17773e1a8dd6e97f57db111819338c418f819cef) tdf#93430: Cannot get accessible text attributes for 'Not in dictionary' entry Reviewed-on: https://gerrit.libreoffice.org/31778 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit e0d8c3821b8fa1e7d00f7b4a7d007f9cb5c592a5) Reviewed-on: https://gerrit.libreoffice.org/31792 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> tdf#93430: Return the right offsets for runs MultiLineEdit is a special control which can have more text portions with different text attributes. Reviewed-on: https://gerrit.libreoffice.org/31813 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 8d52045853cecb716138d51b8b6ad0272a86af86) Change-Id: Ia45526c01cc381d3d6a1b56dbf4f03fdd38a0989 Reviewed-on: https://gerrit.libreoffice.org/31804 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-11don't overwrite the crashreport info that are written before uploadMarkus Mohrhard2-4/+34
There was a race condition that the OpenGL code was initialized before the old report has been uploaded. Therefore the OpenGL setting was overwritten by the new start and we were not getting the old value. Now we store any value that wants to be added before the dump.ini is ready in a temporary map and will write them as soon as we write all the common information. This problem was introduced by the dialog requesting permission to upload the crash report. Change-Id: I29391a1ff56bac6381218c5a4aefb58c2c03f024 Reviewed-on: https://gerrit.libreoffice.org/31846 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 80049d110a742060acedb89eaad763e66d7f75a5) Reviewed-on: https://gerrit.libreoffice.org/31851 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-10tdf#104445: PPTX import: Extra bullets are added to placeholder textTamás Zolnai4-2/+57
Reviewed-on: https://gerrit.libreoffice.org/31771 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit cb598029835477326b190bc99abd31a487cc5a91) Change-Id: I25ce98ed391f70292bed6238645b121b9cf50d5e Reviewed-on: https://gerrit.libreoffice.org/31791 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-12-10Related: rhbz#1397939 crash with null pSidebarControllerCaolán McNamara1-2/+2
Change-Id: I7627ff30564b2de61669c71dafd15e7b1778b5c6 (cherry picked from commit f5edbb4158e86bfea7267115395b64e60fd61dc7) (cherry picked from commit 5768416761756a386cba54314f783cb9c0d0d093) Reviewed-on: https://gerrit.libreoffice.org/31787 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-09oss-fuzz we don't want this stream to automatically resize on seeks past endCaolán McNamara1-1/+1
Change-Id: Ie42b2e173cd3ed9faaf17c3c978227613129fa84 (cherry picked from commit f212bd45a7c7d97fb16380cd9fa7c6abbfb71e05) (cherry picked from commit b832d7019f7e7499f5fb3da5d5f49ddbf0f35585) Reviewed-on: https://gerrit.libreoffice.org/31803 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-12-09tdf#104034 skip polygons with less than 2 points (LO 5-2)Tomaž Vajngerl1-0/+4
We can get polypolgons with polygons that have 0 or 1 point only, so we need to guard agains division-by-zero errors by skipping if we detect such polygons (as we can't draw them anyway). Change-Id: I08c4f4c9bb946fcbaedede4b4ae23c96e431190e Reviewed-on: https://gerrit.libreoffice.org/31790 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-12-09tdf#104495: prevent autotext to crash when drag&dropJulien Nabet1-1/+0
See bt https://bugs.documentfoundation.org/attachment.cgi?id=129407 For non regression, I retested tdf#91125 since the delete comes from https://cgit.freedesktop.org/libreoffice/core/commit/?id=06ecf7d2aebe64226142ee27c2512351960f8bb1 Change-Id: I7ce833ffce20f1f159242014ba8ffe0ce5b7b11c Reviewed-on: https://gerrit.libreoffice.org/31773 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit 8776c20c1c72110d0f205150913eb17cdf3f1aaa) Reviewed-on: https://gerrit.libreoffice.org/31784 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 56261b0bb06e29b71e2cc555086100282e54d62e) Reviewed-on: https://gerrit.libreoffice.org/31793
2016-12-09tdf#104105: fix Vcl lifecycle in CondFormat (reportdesign)Julien Nabet1-1/+6
Avoid this error: Window ( 7VclVBox()) with live children destroyed: N5rptui9ConditionE() * n by calling disposeAndClear on each element of m_aConditions m_aConditions is Conditions type Conditions type is ::std::vector< VclPtr<Condition> > See http://opengrok.libreoffice.org/xref/core/reportdesign/source/ui/inc/CondFormat.hxx#70 Change-Id: Ie99f8cdb5acd787892237787525d79f3231689db Reviewed-on: https://gerrit.libreoffice.org/31775 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 73131fc3806ce2a7da61c93590e467e5b044c341) Reviewed-on: https://gerrit.libreoffice.org/31780 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-08tdf#103651 check isForwardEvents() for symbols in commentsMark Hung5-1/+17
Every time a comment is referred, the whole comment stream is parsed but only the referred comment is extracted. But the symbol is always processed so it is added to all the comments. Reviewed-on: https://gerrit.libreoffice.org/31584 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 3caf89200c8fa7b38d6c340b666ca6cc8c2eb766) Change-Id: I3264de2d011ff188ef64f6500ae426cde0106c16 Reviewed-on: https://gerrit.libreoffice.org/31758 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-12-08Resolves: tdf#103313 idles never get to complete postit shell formattingCaolán McNamara1-1/+7
Change-Id: Ic01628bca8c306c48277ffbc84d334d1922a248b Reviewed-on: https://gerrit.libreoffice.org/30864 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 3690218b1f5073db8407a58f1b45a97d3d6fe7cd) Reviewed-on: https://gerrit.libreoffice.org/31757
2016-12-08add Venetian (vec) ui languageChristian Lohmaier3-0/+8
Change-Id: I643eb91691dddf2c4ece2edb27383cb7dd0e3fdc (cherry picked from commit cc89cb56d51b4f43d999701ff97a89ff9fb5a31a) Reviewed-on: https://gerrit.libreoffice.org/31726 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-12-07stab at the sick "units in character width of the standard font", tdf#101363Eike Rathke1-1/+5
Which gave problems in the unit test on tinderbox build machines, apparently because they don't have not even the resulting fallback font installed. Specifically here digit '1' was slightly wider (123) than digit '0' (122), which the import accounts for but the export didn't, so widths were divided by 122 instead of 123 hence resulted in 24.23 instead of 24, for example. Change-Id: If8a04383632de674ae2a15a79608661e434aeb54 (cherry picked from commit 20b54a228b2844ad66d80d930d4a9eb39ce8c336) Reviewed-on: https://gerrit.libreoffice.org/31728 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-12-07update creditsChristian Lohmaier1-1343/+1390
Change-Id: I0d80228d2e33c03daacb0b3be4c5f3fc90324836 (cherry picked from commit 2b5305d3020435c57d75d19f332acea10049ef69)
2016-12-07update creditsChristian Lohmaier1-1490/+1586
Change-Id: I8ce476f182ce5004619a8380b9effb135bcf7d55 (cherry picked from commit 4136757b4e51c4e6f7cb4132c95538a7f831ef2c)
2016-12-07Resolves: rhbz#1400683 ctrl+alt+c doesn't insert commentCaolán McNamara1-4/+1
only map GDK_SUPER_MASK to KEY_MOD3 and not GDK_META_MASK on wayland I'm getting a GDK_MOD1_MASK and a GDK_META_MASK on pressing the left alt. The check for KEY_MOD2 in Window::KeyInput trips up with the extra KEY_MOD3 bit set so the auto mnemonic underlines don't appear on pressing left alt under wayland Lets map only GDK_SUPER_MASK to KEY_MOD3 (cherry picked from commit a840b2526b8b8e44991bef2eb7b6ba44a1a90d3a) Change-Id: I1e9cc9fc095f5edfa7ad7c71440232c6de1ecf04 Reviewed-on: https://gerrit.libreoffice.org/31689 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-12-07tdf#34212: Accented Characters and Umlauts are missing with Type1 fontsJulien Nabet1-1/+1
Following the revert of previous patch: https://cgit.freedesktop.org/libreoffice/core/commit/?id=297b22bd49ea11a90063ab8503fb83090f351668 Gilbert Röhrbein proposed this patch See https://bugs.documentfoundation.org/show_bug.cgi?id=34212#c14 Change-Id: I1a30427cd88f5602e7633894ba35307104c2ed8d Reviewed-on: https://gerrit.libreoffice.org/29792 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> (cherry picked from commit 52040395e3046ac42b8c3dd385c7b1cb26b929f3) Reviewed-on: https://gerrit.libreoffice.org/30852 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-07tdf#102010 Never overwrite MM files via UNOJan-Marek Glogowski5-43/+107
Fixes the regression introduced by commit e637b6743a506ef74c93ccbe15ab6642f3baa34f This commit removed the crazy bSubjectIsFilename handling, where I didn't understood the case of bSubjectIsFilename and a user supplied prefix. Mail merge to files never overwrites an existing document, but there is the special case, when a user selects a target filename in the MM dialog for single file MM. Should be fixed by a successive commmit, reverting this and removing an existing file before starting the MM job. (cherry picked from commit bbf246e40c7814bfc4038d456d388d1f90048287) Reviewed-on: https://gerrit.libreoffice.org/31207 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 5b4b60b2d81452c79ece99c51f63199b7dcf4b1d) This commit also includes: MM allow easier manipulation of MM test arguments Keep the beans::NamedValue vector around and convert it to a uno::Sequence just before executing the mail merge job. (cherry picked from commit 660159a68acd54a8f213920457c1aeed79cffea5) Reviewed-on: https://gerrit.libreoffice.org/31206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit fda376a5ebf765789cfa4cb81ee04e0f1dafe44b) Change-Id: Idda487023e6984de9c1e701fc088a6b7f92e9847 Reviewed-on: https://gerrit.libreoffice.org/31636 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-06Revert "attempt to fix Linux-rpm_deb-x86_71-TDF tinderbox build, tdf#101363"Eike Rathke1-8/+1
This is a combination of 2 commits. Revert "try a volatile" This reverts commit 8a460cfa1b1ce01c7a479ce2e7f21a92a2c50de3. Turns out the cause is something completely different.. (cherry picked from commit ed4da005b076b5b1ea96dcc4b8caa994709ee733) Revert "attempt to fix Linux-rpm_deb-x86_71-TDF tinderbox build for 5-2, tdf#101363" This reverts commit 39aa5c2c653f36393416a6aadd6e599051bbfe7b. Turns out the cause is something completely different.. (cherry picked from commit 709053fc72db3eacfec0a7d8e47557b34bc6193e) Change-Id: I55f4ac6f48029676ec531a021d3b6939f670bde0 Reviewed-on: https://gerrit.libreoffice.org/31705 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-12-06tdf#103756 fix crash of this on 5-2 with initial backportNoel Grandin1-6/+5
This crashing when the user hits ctrl-Z, because when I backported: commit d1909ab7940109ce7d43da04e480db4e82b8310f Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Tue Nov 8 16:15:55 2016 +0200 tdf#103756 - CTRL+Z not working to undo changes performed through Navigator I missed that the older version of SdPageObjsTLB has two constructors while the new version (on master) only has one, and I only added the new line of code to one of them. Change-Id: Ic5bc59a20e26fecb823f5b0fadba874b947e77ad Reviewed-on: https://gerrit.libreoffice.org/31680 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-06try a volatileEike Rathke1-1/+1
Change-Id: Iadaeb1cdf8a73cac3308e82caa2e65db07ec0fc1 (cherry picked from commit 8a460cfa1b1ce01c7a479ce2e7f21a92a2c50de3) Reviewed-on: https://gerrit.libreoffice.org/31662 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-25 12:23:41 +0000