summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2013-09-29Version 4.1.2.3, tag libreoffice-4.1.2.3libreoffice-4.1.2.3Christian Lohmaier3-0/+0
Change-Id: I21273546478832a1b908a0b8c9803b7a650a980c
2013-09-29bump product version to 4.1.2.3Christian Lohmaier1-1/+1
Change-Id: Icbc3be5ca3191614c8cfccdb51c7a5e4f18b79ad
2013-09-28Updated coreChristian Lohmaier1-0/+0
Project: translations e59e79bddc8238831c8fcb955cdafb56cf62994d
2013-09-27fdo#69450 - IDF_ATTRIB & IDF_CONTENTS must be disjoint.Michael Meeks1-1/+1
Change-Id: Ib971824a7f274334012b872acec65310535ad767 Signed-off-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Signed-off-by: Norbert Thiebaud <nthiebaud@gmail.com> Signed-off-by: Caolán McNamara <caolanm@redhat.com>
2013-09-25Resolves: fdo#69220 crash in doc (ww6)Caolán McNamara1-1/+15
Change-Id: I5a09d121a0b0342f28ba5d2d39027b27e9c9eba2 (cherry picked from commit 2e93541d00f9d4aaa6ad2aeb35ee0c901d216cc0) Reviewed-on: https://gerrit.libreoffice.org/5991 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-09-25Resolves: fdo#69440 only ask for tabcontrol in builder dialogsCaolán McNamara2-1/+3
(cherry picked from commit d4edce3b72d585915516a0a27c4815a0d4996cfb) Change-Id: I6001f8921f3b90283525355b0094c4377c42c663 Reviewed-on: https://gerrit.libreoffice.org/5993 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-09-25valgrind: init. member variablesDavid Tardon1-0/+6
Change-Id: I7e0d99f549841d466d5dfb69cde74b424ae98b0b (cherry picked from commit 38797f7f4129e1e09be9308a36311cf2f1afef79) (cherry picked from commit 86128f3b24a830df87db4ed2f7176d84ede7230f) Reviewed-on: https://gerrit.libreoffice.org/5995 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-09-18bump product version to 4.1.2.2.0+Christian Lohmaier1-1/+1
Change-Id: I9967fba187bdf6c9c2fcce0b95d8664533cc596a
2013-09-17Updated coreChristian Lohmaier1-0/+0
Project: translations 36fc2c0c4f118dc2ab7952679c79516caf167445
2013-09-11fdo#68210: Make tiff import work again with merged-libsBjoern Michaelsen24-41/+84
- there was a symbol mismatch for dynamic loading - this fixes fdo#68210 and the other dynamically loaded functionality - this also includes Change-Id: I6041ca10f58335187928995368db673c1ce22e7b - this also includes Change-Id: Ie59f2ba4daec0375d1d64b765be3b1484e8cba3e (tests that ensure the master to be broken arent that helpful) Change-Id: I7e4d6baf256dbe7b145dcbc118b4cac2075e07f5 Reviewed-on: https://gerrit.libreoffice.org/5813 Reviewed-by: Tomáš Chvátal <tchvatal@suse.cz> Tested-by: Tomáš Chvátal <tchvatal@suse.cz> Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-09-11Resolves: fdo#68081 why would I want a spinner that doesn't repeatCaolán McNamara1-1/+1
surely WB_SPIN should imply repeat in the first place, *shrug* Change-Id: I1e4cb5a01d473cd0f8d907d566cd26d51a81da93 (cherry picked from commit f96771165ea145a759f1bab76cd34bb70def04f6) Reviewed-on: https://gerrit.libreoffice.org/5840 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2013-09-09fdo#69041 LibreLogo: fix SVG/SMIL timing with filled polylinesLászló Németh1-3/+4
Change-Id: Icebd47d57a830986c371a62ec7dab81ca8fd930a Reviewed-on: https://gerrit.libreoffice.org/5846 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-09-09fdo#65330 fix meta.xml of AbstractYellow.otpAndras Timar1-0/+0
title was Abstract Green instead of Abstract Yellow Change-Id: I80344940d96163809b889482334f02bb4f7a124f Reviewed-on: https://gerrit.libreoffice.org/5873 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-09-09fix validity dialog with lists, fdo#65686Markus Mohrhard1-1/+1
regression from b0cf3aba085373d84a55ef144b273a8a89d017af Change-Id: Ia3d39e02f35f3e23d93c7fe771bdbeb6eb3d2caf Reviewed-on: https://gerrit.libreoffice.org/5856 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/5880 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2013-09-06fdo#68313 fix combining diacritics problem with Graphite fontsLászló Németh1-1/+10
Change-Id: Ied29f864dc5fc21fc55aaa5ddd40b02b53a564f8
2013-09-06Fix misspelled text with VoiceOver on 10.9Boris Dušek1-0/+1
More in Apple's docs (Application Kit Release Notes for OS X v10.9, section "New Accessibility constants"). Change-Id: I92fb6d552e86997bfc789723f32626d908d11419 Reviewed-on: https://gerrit.libreoffice.org/5834 Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-09-03bump product version to 4.1.2.1.0+Christian Lohmaier1-1/+1
2013-09-03bDel is unused uninitializedCaolán McNamara1-0/+1
Change-Id: Idac3a6805700d896b8569d1df79d32ca493c48b3 (cherry picked from commit 91a557561c24c7532c525692f279b1fcfd520f92) Reviewed-on: https://gerrit.libreoffice.org/5764 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-09-03n#816593: docx consecutive tables with different tblpPr needs to be splitCédric Bosdonnat9-9/+118
When importing docx with 2 <w:tbl> following each other, we have 2 possible behaviors: either merge them as one table as we did before or split them into two tables. The tables need to be split if they have different floating position properties. This required the ooxml tokenizer to repeat the table properties for each row of the table: or how would we know we don't need to split the table? The basic idea behind this hack is to temporarily store the table position and table properties before saving them. Thus we can compare them at the end of the row and decide to split the table or not. (cherry picked from commit 173d24a7316fccf0e838f71b92c10a772b19298d) Signed-off-by: Miklos Vajna <vmiklos@suse.cz> Conflicts: sw/qa/extras/ooxmlimport/ooxmlimport.cxx Change-Id: I2e3e70dfe7386090fe356575ee9d0e81aa031dc4
2013-09-03n#816593: Floating table width import fix: adjust the frame widthCédric Bosdonnat3-3/+21
(cherry picked from commit 9f4c8a8bca06b4c2a916a51909367b453fc41a8b) Change-Id: I8212bc5981418f6cbd514bf5002e6a5dbdf53152 Signed-off-by: Miklos Vajna <vmiklos@suse.cz>
2013-09-03Resolves: rhbz#993963 NULL m_pWindow on firefox deleted pluginCaolán McNamara1-1/+1
Change-Id: Idb12b12e4313668bf3390a97551c688ee0dcde67 (cherry picked from commit 4a4ed52e57b540167c3ca45e6e762b9e21e874de) Reviewed-on: https://gerrit.libreoffice.org/5773 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-09-03fdo#68750: ensure that GetSuggestedEndOfSentence makes progressMichael Stahl1-1/+11
Checking a string of 17399 spaces takes 20 seconds here in GrammarCheckingIterator::GetSuggestedEndOfSentence() because BreakIterator_Unicode::endOfSentence() will always return 0 as a result regardless of what nStartPos it gets. Change-Id: Id02440a91d7015c2896e387854445ee5383092fa (cherry picked from commit b23999755a865a277c29adfc1dc0c249275bfd7e) Reviewed-on: https://gerrit.libreoffice.org/5758 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-09-03stop annoying temp full screen windows appearing on insert->index entryCaolán McNamara1-0/+8
Change-Id: I730617f5ce28149f79d1d22efbfb7eab22e5840d (cherry picked from commit 8f6b90a80c7b6e1c19422e944ca49657581e1042) Reviewed-on: https://gerrit.libreoffice.org/5761 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-09-03Resolves: fdo#68794 blank placeholders when there is no known language yetCaolán McNamara1-1/+7
Change-Id: I7f43144bd61ddc575d8b7094567433fdfd5ee291 (cherry picked from commit f42768fe0b60ecbbe9c68d775329bf28c0690131) Reviewed-on: https://gerrit.libreoffice.org/5751 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-09-02Updated coreAndras Timar1-0/+0
Project: translations ff3cff1f9e31f89c0648340f952dcb52a0403aaa
2013-09-01fdo#67584: remove .uno:FlipVertical from WriterCommands.xcuIvan Timofeev1-8/+0
mismerge in c991fb49aa174f300be0b978d89bc63e01e0aa2b Change-Id: I7d890495bac0fa1a458a86c8625158c94cdba717 (cherry picked from commit 58aa737b2a37fa939580ee65f8976a13870b1de9) Reviewed-on: https://gerrit.libreoffice.org/5741 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-09-01fdo#42434: swap flipvertical and fliphorizontal icons in some themesIvan Timofeev23-0/+0
Change-Id: I484a783547c3bed1d80a0f510434b4c0fe37bed7 (cherry picked from commit 07aefbe310cad43bf9a71ba073486cddd7e062f2) Reviewed-on: https://gerrit.libreoffice.org/5725 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-09-01fdo#68689 Sub-divide ruler ticks into 1/8 insted of 1/10 for inchTomaž Vajngerl1-1/+1
Change-Id: Ied2a6982d5564228b0ce7fecb89723f3742b6d0d Reviewed-on: https://gerrit.libreoffice.org/5726 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-09-01cppcheck: Array index is used before limits checkJulien Nabet2-3/+3
Change-Id: I531430ce4bc0937a023d3e2849ae07d8f94e3e70 Reviewed-on: https://gerrit.libreoffice.org/5723 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-08-31fdo#41068: writerfilter: fix image wrap polygon importMichael Stahl2-3/+5
Mainly the problem seems to be that Stein's GCD algorithm requires non-negative input parameters, and the document has this: <wp:lineTo x="-480" y="6104"/> (regression from 86898639d4144a078ed295d0a8bef406868802cb) Change-Id: I8da1272c3caae84f43472aa4acb65ed66dfbd8ae (cherry picked from commit f8307e5ae11e8235fa1fb88ed52625bf9c650dc2) Reviewed-on: https://gerrit.libreoffice.org/5700 Reviewed-by: Miklos Vajna <vmiklos@suse.cz> Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-08-30resolved fdo#67836 do not overwrite already interpreted English cellEike Rathke1-6/+11
... with a not matching locale dependent interpretation Change-Id: I66553627cab282ed333443ee8bf687596a616a28 (cherry picked from commit a6fdfb960ad0f5b019adff700d0046f20a740996) Reviewed-on: https://gerrit.libreoffice.org/5712 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2013-08-30Resolves: fdo#68396 Yield allowed layout timer to run during init layoutCaolán McNamara1-1/+1
There are multiple pages getting generated in the styles dialog because the dropcaps preview window calls "Yield" sometimes and sometimes the layout timer gets a chance to activate *during* the creation of the dialog so there ends up with two consecutive activations of some tabpages which has wonderful eventual know on effects resulting in that crash later on. Easiest thing is to disable the layout timer during the initial size calculation Change-Id: I7fb0a7ff89aa2c6013c5d8014deface107610000 (cherry picked from commit fe1cbda3b7513e0d3686d347aa991e7231067384) Reviewed-on: https://gerrit.libreoffice.org/5696 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-08-30Related: fdo#66700 don't crash on setting zoom state with no SfxObjectShellCaolán McNamara1-1/+5
(cherry picked from commit dd0f6c737b6af659389e473296e939ec6cfa5f4e) Conflicts: sfx2/source/appl/appserv.cxx Change-Id: Id2943c92ce6deaae3e4d507a35c08466db21cece Reviewed-on: https://gerrit.libreoffice.org/5697 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-08-30LibreLogo fixes (eg. fdo#68713 fix SVG cropping), see ChangeLogLászló Németh2-15/+69
Conflicts: helpcontent2 Change-Id: Ibb1cb41f526b4117e2d7ef39a2101286511bf48f Reviewed-on: https://gerrit.libreoffice.org/5687 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-08-30TPropertyValueLessFunctor must actually compare for "<"Stephan Bergmann1-1/+1
Change-Id: I584a410d90531a0f7b784e62f94c39e715713cf1 (cherry picked from commit 2410b3c3ddc6fea02dadd56b39bb1181312c383a) Reviewed-on: https://gerrit.libreoffice.org/5683 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-08-30fdo#67313: Use "lo" suffix for private URE libsStephan Bergmann17-81/+96
...(like is done for most of LO's non-URE libs already) to reduce likelihood of name clashes, esp. on Windows where URE libs are found via PATH. This introduces PRIVATELIBS_URE, and [does not remove not-yet]-unused UNOLIBS_URE. (cherry picked from commit 644c33a857c46d540202189228f519946dc33833) Conflicts: Repository.mk solenv/gbuild/Helper.mk solenv/gbuild/platform/IOS_ARM_GCC.mk solenv/gbuild/platform/WNT_INTEL_GCC.mk solenv/gbuild/platform/android.mk solenv/gbuild/platform/com_MSC_class.mk solenv/gbuild/platform/macosx.mk solenv/gbuild/platform/mingw.mk solenv/gbuild/platform/solaris.mk solenv/gbuild/platform/unxgcc.mk Change-Id: Ib95dd45f18de140a54e62d632dbf2239f83c232e Reviewed-on: https://gerrit.libreoffice.org/5667 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-08-29Allow to set EXTRA_BUILDID also via environment variable (fdo#58034)Petr Mladek1-1/+3
This is much easier with tinderboxed that work with static autogen.input Change-Id: Ifb0b7884bbad14a286023b3dbd7d1d2a12f36787 Reviewed-on: https://gerrit.libreoffice.org/5679 Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-08-29fdo#66215: sw: fix clicking on text above background flyMichael Stahl2-4/+43
SwPageFrm::GetCrsrOfst() tries to compare the distance to the closest text vs. fly but does not do it right because GetCharRect() returns just a line of width 1 on the left edge of the character; try to figure out the entire area covered by the character via 2 calls to GetCrsrOfst(), which gives much better clickability. (regression from e8fbe97900f13305b17015d9044993bde4adab36) Change-Id: I825e86daf65692dfb962ad576772c5f543d02d19 (cherry picked from commit edd2db1c783bd571ff796a5298385cacc91877b9) Reviewed-on: https://gerrit.libreoffice.org/5660 Reviewed-by: Miklos Vajna <vmiklos@suse.cz> Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-08-29fdo#67358: sw: "fix" line painting artifacts when resizing columnsMichael Stahl1-1/+3
SwEditWin::MouseButtonDown(): for unknown reasons invalidating the window here causes the column resizing lines to not be removed after the resize is done, so disable it. (regression from 289185fd02d6d9734b6dbde01f15c4e6c5beacbb) Change-Id: If3ba0a72c53c5c2734fb905ae35d62f6a3e8938b (cherry picked from commit a2c67975c03010b90c706523293f180c1f29e229) Reviewed-on: https://gerrit.libreoffice.org/5661 Reviewed-by: Miklos Vajna <vmiklos@suse.cz> Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-08-29Fix loplugin error: checking whether a config macro EXTRA_BUILDID is defined.Tor Lillqvist1-4/+5
Change-Id: Ieb04a8da4dc54b41f4df1d63b5e70ffb7ca7bb01
2013-08-29fdo#68648: SvxNumRule: serialize the aFmtsSet flags tooMichael Stahl1-5/+6
The constructor of SvxNumRule initializes aFmts[i] with a format but always sets aFmtsSet[i] to false, so SvxNumRule::Store() and SvxNumRule::SvxNumRule(SvStream &rStream) need to be able to round-trip that combination to prevent spurious numberings. It is unlikely that this class is serialized in the table auto-format files but i haven't checked; this change does not change the size of the serialization so shouldn't cause trouble anyway. (regression from a95cce27295f9cd255fa72eaded00972e3efb69b) Change-Id: I589ea108ac069624aaa7b26cdc3bfe8182b15851 (cherry picked from commit 4b798d89a55714218dc9a7de161f93f9c4d6fc80) Reviewed-on: https://gerrit.libreoffice.org/5671 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-08-29rhbz#1001768: avoid deadlock in AccessibleEventNotifierMichael Stahl1-14/+19
revokeClientNotifyDisposing(): drop the static lclMutex before calling pListeners->disposeAndClear(), which may want to acquire the SolarMutex and deadlock. Change-Id: Ib35fc7fad6596450a3b10d58d5193b9b55c575cb (cherry picked from commit cafff1bbc4effac74bbd2607fb83dd2547c8fa2e) Reviewed-on: https://gerrit.libreoffice.org/5659 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-08-29make the tinderbox information more reliable in the about dialog (fdo#58034)Petr Mladek5-3/+13
Pass the information via config_host/config_buildid.h. Then cui/source/dialogs/about.cxx will get rebuilt also in the incremental build. Change-Id: I058cbe162e7015cbea6c71253c20db097477708f Reviewed-on: https://gerrit.libreoffice.org/5677 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-08-29Updated coreCaolán McNamara1-0/+0
Project: help 0d8b37cd9e0b89d1136b09a81671c88fc91fee3e
2013-08-29Resolves: fdo#68192 always recode from trad symbol to apple symbolCaolán McNamara1-10/+11
Even if the symbol font bit isn't set, the oox import route lacks the ability to state that the bullet font is a font of symbol encoding. If the font is not available on the system we go into fallback logic to state that famous symbol fonts are in symbol encoding. But there is a symbol font on mac so its not unknown and that doesn't happen. And the mac symbol font is not actually in symbol encoding (seeing as it's all rearranged into the correct unicode positions) so the recode logic is skipped in this special case to map the microsoft/adobe private use area chars to the modern code points where they were moved in the apple font. I guess one alternative possible solution is to lookup all the fonts used in a openxml doc using the fonttable stream where the charset info is available. But seeing as it should only affect one particular font lets just move the encoder test outside the issymbol block. Change-Id: Ic5bd3ec15c8d8d99e2cab0fb67cc4bc33081c756 (cherry picked from commit b129867306ce918f4f8fbf9ec5f7dce86e52c9d2) Reviewed-on: https://gerrit.libreoffice.org/5669 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-08-28Updated coreCaolán McNamara1-0/+0
Project: translations e49890cde9c55dde50bcc9babe44c50906cc3ef3
2013-08-28Updated coreAndras Timar1-0/+0
Project: translations f805dd3ebe91a1105979b21df554dba1f62c1bd9
2013-08-28Uploading libvisio 0.0.31, fixing fdo#68477Fridrich Štrba4-33/+2
Base64 decoding in some boost versions throws on padding characters (cherry picked from commit 710eb05b0fe7a4396dcec169d15c337d1664e9d4) Conflicts: download.lst Change-Id: I9a9a43c2a7e55b6a6fca085302eae223bc8c1b13 Reviewed-on: https://gerrit.libreoffice.org/5656 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-08-28odbc insert: adjust buffer size *after* it is written toLionel Elie Mamane1-1/+1
the buffer (aBookmark) is written to by SQLBulkOperations or SQLSetPos, not by SQLBindCol, which merely sets up the instruction that the next call should write there. So its finak size is known only *after* the call that makes the write, obviously. Change-Id: I4faaaeffc060433645188f0eda3d9958b087cf6c Reviewed-on: https://gerrit.libreoffice.org/5650 Reviewed-by: Miklos Vajna <vmiklos@suse.cz> Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-08-28fdo#68315 odbc update *reads* a bookmark, not *writes* a bookmarkLionel Elie Mamane1-21/+39
This code was completely inverted. The row update operation *reads* a bookmark (that is, what row to update), not *writes* a bookmark. So we were passing an empty bookmark, and thus the update was failing because we were refering to a non-existent row. Change-Id: I676b1a7727a88e13a3e465bd96cbbaf18dad2fa6 Reviewed-on: https://gerrit.libreoffice.org/5648 Reviewed-by: Miklos Vajna <vmiklos@suse.cz> Tested-by: Miklos Vajna <vmiklos@suse.cz>