Age | Commit message (Collapse) | Author | Files | Lines |
|
The problem is that the process handle is freed regardless of whether osl_executeProcess was successful or not. Therefore, a segmentation fault would result, as a random memory address would be freed. This patch checks whether osl_executeProcess was successful. If it was, then it frees the handle; if it wasn't successful, the memory is not freed.
Change-Id: Ic3af07be06e7af7730a3bcb1680c659a88b66af3
Reviewed-on: https://gerrit.libreoffice.org/1530
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit dbfc8777bf73872d1b96f956b9e778d9099d52b3)
(cherry picked from commit 96b985145b3efbaf4552adbeccf24bfac2fa71b0)
Signed-off-by: Michael Stahl <mstahl@redhat.com>
|
|
Ignore this option on Windows.
This work-arounds a regression introduced by f4a4ba9ac
Windows appends -Embedding when LibreOffice is called by COM+
Before f4a4ba9ac this option was silently ignored.
Change-Id: I8a727895c9ec8fa4b06aea8ad66b2791ada66dd5
Reviewed-on: https://gerrit.libreoffice.org/1514
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 3616640054f4fc18c6e7307ba17e7d89a0f5ae69)
Conflicts:
desktop/source/app/cmdlineargs.cxx
(cherry picked from commit abf0ed8400d7787fec906b21de74698936d40e28)
Signed-off-by: Michael Stahl <mstahl@redhat.com>
|
|
(cherry picked from commit 374f7465729c98f2cc8af72f876a8eab01d192a6)
Conflicts:
libcdr/UnpackedTarball_cdr.mk
Change-Id: I715975dfa93d736cb537076feab4afe6b75c162a
Reviewed-on: https://gerrit.libreoffice.org/1547
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
|
|
No idea how to reproduce it; pSwView is checked before use except here.
(possibly regression from 2f9f480b22f2fff59d9c48b4b46706c3d5223e66)
Change-Id: Ia7667e879a6944e084a45c06133efc1ac2d8b3c0
(cherry picked from commit 1c52268a5bc6d79c6ee1344e4e341c7e3820d4e0)
Reviewed-on: https://gerrit.libreoffice.org/1546
Reviewed-by: Ivan Timofeev <timofeev.i.s@gmail.com>
Tested-by: Ivan Timofeev <timofeev.i.s@gmail.com>
|
|
this event used to get posted, somehow it seems it got dropped somewhere along
the line ( looks like the printer and printer monitor code got reworked )
Conflicts:
sfx2/inc/sfx2/sfx.hrc
Change-Id: Ib75ee9e7ecd41614275033d2be2a351785326e24
Reviewed-on: https://gerrit.libreoffice.org/1536
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
|
|
during some rework ( not sure if it was me or not ) we try to register
ControlContainerBase on construction as a XModifyListener ( but it's not ). Patch
make ControlContainerBase implement XModifyListener now. iirc the code in question
was moved from UnoDialogControl at some stage and it appears some balls were
dropped :-)
Change-Id: Ifc7084bd7260ceb06334117582facb95bafb6fed
Reviewed-on: https://gerrit.libreoffice.org/1535
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
|
|
So codepoints that are from the legacy range need to be converted to their
unicode equivalents even in the presence of an installed "symbol" font on
MacOSX.
This should work out ok if input codepoints that exist in the apple symbol
unicode are used, they should be left untouched by this conversion.
Change-Id: Ia9996e2d9bf632c86c8d26832d77c7c662cf1076
Reviewed-on: https://gerrit.libreoffice.org/1403
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
|
|
Change-Id: I8769a63be61d45817757be3ad23ffc7b01173041
Reviewed-on: https://gerrit.libreoffice.org/1538
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
|
|
Thank you John LeMoyne Castle for your support
http://nabble.documentfoundation.org/Wrong-indentation-which-leads-to-segfault-in-sc-source-ui-docshell-docfunc-cxx-td4026726.html
However, the weird thing is I reproduced the crash with master sources but didn't with 4.0 branch nor with 3.5.4.2 Debian packages
Change-Id: Ia5366f479a1066106551b77b5a6315fb78e1bf7d
|
|
... to actual minimum so that the fix for fdo#33090 in
UniscribeLayout::GetNextGlyphs subtracts exactly the right number.
The original value of mnSubStringMin is guessed and may be up to 8
smaller than the actual start of the first VisualItem.
For the bugdoc it happens that sometimes it's too small by 8 and then
the wrong entries in mpGlyphs2Chars are initialized and then apparently
there are single glyphs that represent multiple characters and so
GetNextGlyphs returns a -1 character which is invalid.
->GetNextGlyphs dir 1 36 mnSubStringMin 28
->GetNextGlyphs g2c #1 [8] = 36
->GetNextGlyphs g2c #1 [9] = 37
->GetNextGlyphs g2c #1 [10] = 38
->GetNextGlyphs g2c #1 [11] = 39
->GetNextGlyphs g2c #1 [12] = 40
->GetNextGlyphs g2c #2 [4] = 40
->GetNextGlyphs g2c #2 [3] = 39
->GetNextGlyphs g2c #2 [1] = 38
->GetNextGlyphs g2c #2 [1] = 37
->GetNextGlyphs g2c #2 [0] = 36
...
->GetNextGlyphs init nCharPos -1
->GetNextGlyphs g2c [2] nCharPos -1
->GetNextGlyphs set pCharPosAry -1
layout[0]->GetNextGlyphs 768,1024 a1800 c-1 0
Change-Id: Ie33ec797a412aa898bec3f4e8f97b88dcfed4d11
(cherry picked from commit cec68bceba9aa1e984d74897fcd7bf4db702d14b)
Reviewed-on: https://gerrit.libreoffice.org/1467
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
|
|
(cherry picked from commits 6fc868c6535932bedfa0fc51d8dd5a1814d73ee8 and
c58981ca3dbf65c998acf979fb104534991b08c4)
Change-Id: I3e3d0de98c9df1a5f9041f6a7dd03b92efb5d0f5
Reviewed-on: https://gerrit.libreoffice.org/1482
Reviewed-by: Muthu Subramanian K <muthusuba@gmail.com>
Tested-by: Muthu Subramanian K <muthusuba@gmail.com>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
|
|
Change-Id: I7313cca3335e1b41df2a70fe968bc1e6386a1e36
(cherry picked from commit 896e326ace53bedf9b17fa624d260032b91bcfd1)
Signed-off-by: Eike Rathke <erack@redhat.com>
|
|
Doing word-count by switching per-word between two different
kinds of word iterator was insanely slow. This preserves an
ICU break-iterator for each type of word-breaking.
Change-Id: I091a5a49db923342faabf02d667150ce6c538d2c
Reviewed-on: https://gerrit.libreoffice.org/1462
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
(cherry picked from commit 8041285b369e58df477b5e92df4bde68e96056a2)
Conflicts:
svl/source/numbers/zforfind.cxx
Change-Id: Ieeba328b1e2a1e0fdcd44ad7899da257f846a6b8
Reviewed-on: https://gerrit.libreoffice.org/1426
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Abbreviated combined date/time input was not accepted if the date
acceptance pattern ended in a separator, like "D.M." with input
"D.M. hh:mm".
Additionally check that for "D.M. #" input against a "D.M." pattern the
'#' (any number) is not interpreted as year if the input so far was
recognized to possibly match a date without time, in which case the
count of numbers in input must match the count of numbers in pattern and
input here is not a date.
(cherry picked from commit f2851a270eb9c617fce9bfdde5c8f2428ced7014)
Conflicts:
svl/source/numbers/zforfind.cxx
Change-Id: I7f1f9c8477e35241ee747bf92b9d8832b2de16fe
Reviewed-on: https://gerrit.libreoffice.org/1423
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Fixed position of insert new sheet button (+) when using a sheet with
a different directionality than that of the interface.
Change-Id: Ifc7020c4eb7a1686c23b4d827c47494b88a236b5
Reviewed-on: https://gerrit.libreoffice.org/1385
Tested-by: Lior Kaplan <kaplanlior@gmail.com>
Reviewed-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 53f23ca68dda1011f97bb28d672c7198e9e12c90)
Signed-off-by: Eike Rathke <erack@redhat.com>
|
|
a) fix up some entries in Wingdings for which we do have a suitable mapping
after all
b) on complete failure for mapping to OpenSymbol show a default
bullet, which is better than no glyph
c) document that the original tables were against StarSymbol which
had extra glyphs (and/or I thought it had)
(cherry picked from commit 0d777f33a1d818a7fd27d755e54db64823f46636)
Change-Id: I5e43cc0a5216e76d00b7df1a69967e08c3656e21
Reviewed-on: https://gerrit.libreoffice.org/1402
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
|
|
No idea how long this has been broken, or if it ever worked,
but inserting a picture sets the 'link' and 'preview' checkboxes to true
for the next time (as getValue() returns void*, which gets silently
converted to bool *sigh*).
Change-Id: I6af0e09ac5e475fc9ff04cd7f937af0bc7aeea77
|
|
Change-Id: If8e1936b897bfe0f3ae0d791c573267df3381954
Signed-off-by: David Tardon <dtardon@redhat.com>
Signed-off-by: Michael Meeks <michael.meeks@suse.com>
|
|
Change-Id: I9b28ac161f326ebeeaf0fa22e0a96915187d7c94
(cherry picked from commit 1c60abfdb617039cedc53982c7c8eca640e28cac)
Signed-off-by: Eike Rathke <erack@redhat.com>
|
|
SwHTMLWriter::OutFrmFmtOptions must return a value that includes the
parameter rEndTags.
(regression from 3852a6f54880af8ed9161227baa555580c7d4517)
Change-Id: I280a0de57e254f75b69d08d93e23bf7c765058ec
(cherry picked from commit a923084f872b8ce13f6213827fe5b1c711e6b15f)
Reviewed-on: https://gerrit.libreoffice.org/1390
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Iff0537a69b2c6ae929da6a05f26c0d55415d6d8a
Signed-off-by: Tor Lillqvist <tml@iki.fi>
|
|
Change-Id: I15cf378b51b1ecfbd05c7013e5a5b69fb87fdafb
Signed-off-by: Kohei Yoshida <kohei.yoshida@gmail.com>
|
|
Change-Id: I4d888fc7e9b68ee4c693b565d8ef23dcb825f7ce
Reviewed-on: https://gerrit.libreoffice.org/1251
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-on: https://gerrit.libreoffice.org/1387
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
|
|
formula import is buffered 'till the end of import. The processing of the
formula data need to happen before the scenario import happens. This is
necessary because sheet numbers stored in the formula addresses can become
invalid as scenario import insertes new hidden sheets upsetting the previous
table order
Change-Id: I9357f028f31bec1b1504ca991f5534f80d79c9bc
Reviewed-on: https://gerrit.libreoffice.org/1338
Reviewed-by: Kohei Yoshida <kohei.yoshida@gmail.com>
Tested-by: Kohei Yoshida <kohei.yoshida@gmail.com>
|
|
Change-Id: Ib0c661dbb3ce9a2f8c8d29707a1cf0c65aadc81f
Reviewed-on: https://gerrit.libreoffice.org/1337
Reviewed-by: Kohei Yoshida <kohei.yoshida@gmail.com>
Tested-by: Kohei Yoshida <kohei.yoshida@gmail.com>
|
|
(cherry picked from commit eac3e6e746300df379226941ba75c4e0ce1feb7a)
Conflicts:
sw/source/filter/ww8/docxattributeoutput.cxx
Change-Id: If204523d7da544b11b2d809993ada180476104ef
|
|
...when migrating user extensions from an old user profile.
Change-Id: I4425eba1e840bfdb33782bb3ed0542ce48b2f75f
(cherry picked from commit bd9c4510ff13ab7e935ed12c5b6d1f132c6f2b79)
Reviewed-on: https://gerrit.libreoffice.org/1313
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
|
|
Like a crash in the pivot layout dialog... :-/
Change-Id: I9a330ee3f39ebacb7299d24868bb13ee2a9c3ec5
Reviewed-on: https://gerrit.libreoffice.org/1345
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: Ia35c9fbcc023d29a5a0ecff04fa688aa00ce30e8
(cherry picked from commit f350e8ebe9a0aea0c13db3f6d8b5a35f20145e09)
Reviewed-on: https://gerrit.libreoffice.org/1341
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
|
|
The function does not handle the case where a paragraph was hit but no
background frame was hit properly, which may or may not (depending on
the platform) cause it to return a position of a frame when that is
undesirable, such as when called from SwWrtShell::UnSelectFrm().
When UnselectFrm() leaves a frame selected pasting multiple pictures
leads to a crash.
(regression from e8fbe97900f13305b17015d9044993bde4adab36)
Change-Id: I3604825f654c523a37f47a9fc660647d8b3e7077
(cherry picked from commit 2fc4af311656e7d019ca802d23444e5161f820ee)
Reviewed-on: https://gerrit.libreoffice.org/1314
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
which means that they are not there to be underlined
Change-Id: Ic02372c5284384e18198ebea44c36e83ccb6bf2a
(cherry picked from commit d3a9e97164c0071d8b18f8dcf4197ec7c5c5c2f9)
Reviewed-on: https://gerrit.libreoffice.org/1328
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
|
|
Change-Id: I32317a1a6500377f7e7bb98d1dcc65ad86feb9a2
(cherry picked from commit 7e3923520c27ff139bc3abab35a1c01e1a785fb1)
Signed-off-by: Michael Stahl <mstahl@redhat.com>
|
|
... objects at the right page. This was effectively disabled for all
anchor types except FLY_AT_PARA by a misplaced ! in the conditional,
and C++ not being a type safe language.
Change-Id: I64af2141e577ac896292eecd9f8c46c62a0548db
(cherry picked from commit c479ccc438edeb7197a2d05bdb99067365d7bac0)
Reviewed-on: https://gerrit.libreoffice.org/1290
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
As per https://bugs.freedesktop.org/show_bug.cgi?id=52240#c59
(cherry picked from commit b1184f8a4e4a3949d38407c5f1d5155c2c2b42d5)
Change-Id: I83afc59e4ac71b18219ace60dcbcabafebd5b525
Reviewed-on: https://gerrit.libreoffice.org/1288
Reviewed-by: Kohei Yoshida <kohei.yoshida@gmail.com>
Tested-by: Kohei Yoshida <kohei.yoshida@gmail.com>
|
|
Also referenced by nb-NO and ny-NO
Changes as per http://erack.org/blog/archives/18-comments.html#c351
Change-Id: I9e07f4307800e99fdff21bccde91af4178b244f3
(cherry picked from commit 638993d9b80b3793dfd31db0dacba3746ceb98fd)
Reviewed-on: https://gerrit.libreoffice.org/1287
Reviewed-by: Kohei Yoshida <kohei.yoshida@gmail.com>
Tested-by: Kohei Yoshida <kohei.yoshida@gmail.com>
|
|
Change-Id: I1efc684f3476cd20bd2ae5efcf603ab2e6adf83a
(cherry picked from commit 7d2a5b5114987f1ab415e32ebb5bb9a46b98dc17)
|
|
Otherwise ungrouping date grouped dimension may crash, or produce
incorrect results.
Change-Id: I3634e3c0bf8336fc1221f5d234cb7e01eb1f07c6
Reviewed-on: https://gerrit.libreoffice.org/1247
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Using a distance to click to select the best object to select between
normal text and background object.
(cherry picked from commit e8fbe97900f13305b17015d9044993bde4adab36)
Conflicts:
sw/source/ui/docvw/edtwin.cxx
sw/source/ui/inc/edtwin.hxx
Change-Id: Ib5b53161c7af2c16f4df379382f2e53fc6d8092b
Signed-off-by: Michael Stahl <mstahl@redhat.com>
|
|
...the same way it is done in soffice.bin. framework's Desktop::dispose()
requires the solar mutex to be still alive, which is destroyed in DeInitVCL, so
if the component context/service manager is only disposed afterwards, the solar
mutex is already gone.
This required moving disposeBridges() around, but it allowed to get rid of
DisposeGuard.
(cherry picked from commit 37cc83e594fa8ca131fc5fb98506287b7daedffd)
Conflicts:
desktop/source/pkgchk/unopkg/unopkg_app.cxx
desktop/source/pkgchk/unopkg/unopkg_shared.h
Change-Id: Ibec3d19040fdae23f492cd1e29084e673403e00b
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
In the libreoffice-3-6 branch the docx import crashes here when setting
the anchor position of a shape, because the previous setting of the
AnchorType was not done properly: the position of the anchor in the
SwFmt did not match the actual position of the text attribute, so we get
these assertions: "Missing FlyInCnt-Hint." and crash.
This cannot be reproduced with the docx import on master, because on
master a different intermediate AnchorType is set, and transitioning
from that happens not to cause the crash. But it can be reproduced with
a unit test.
The regression was introduced in libreoffice-3-6 with
backport commit bbbb10a0774b9da546557632cd09c4f6958f8939.
Change-Id: I394643e11862543177ba57958a26cd8ce06dc09c
(cherry picked from commit 01cd24df1ec7eaa53e9e2156d4d6890a7cc5996a)
Reviewed-on: https://gerrit.libreoffice.org/1264
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Otherwise setting text range afterwards crashes with pHnt being NULL.
Change-Id: Ib4ac2712c061605dcaaa262280c0307f7a9af2ce
(cherry picked from commit 5de61f7a4ddb502730454e4bf3232f7f4b4175e1)
Signed-off-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I57dfa64c55e046ed51797b2abeb7ba3242e637da
(cherry picked from commit dfc4832049c140b7442c085062599aef1953e8fd)
Signed-off-by: Michael Stahl <mstahl@redhat.com>
|
|
...since this was changed with fdo#53009 in LO 3.6.3.
Change-Id: I95b8da1311c666945e9bbe15d22da59add6b6227
(cherry picked from commit d35849b6f718990869b01209865bb70cb7343ceb)
Reviewed-on: https://gerrit.libreoffice.org/1254
Reviewed-by: Andras Timar <atimar@suse.com>
Tested-by: Andras Timar <atimar@suse.com>
|
|
... because XLineDashItem::GetName returns the so-called "api name"
(from RID_SVXSTR_DASH_DEF_START..RID_SVXSTR_DASH_DEF_END range), while
the listbox is filled with corresponding translated names.
Change-Id: I9edeeee6f6219f2b31fb02c24c70f3fef4f0efcb
(cherry picked from commit 44ee3ce747058eaf7ca241fe482f4aab54c9bc92)
Reviewed-on: https://gerrit.libreoffice.org/1238
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
This reverts changeset 723f772d for i#106749, then applies an
alternative fix for that issue.
Change-Id: Ib5a1788b67517c8d3cf80fd76801e30587535366
Reviewed-on: https://gerrit.libreoffice.org/1170
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I47c24131e95b9a8a691dbff4710869ba91df8306
(cherry picked from commit 4a1044229afd6b52ca10e5c55f1957b153a8c6ea)
Reviewed-on: https://gerrit.libreoffice.org/1245
Reviewed-by: Michael Meeks <michael.meeks@suse.com>
Tested-by: Michael Meeks <michael.meeks@suse.com>
|
|
This appears to fix an unexpected exception termination in
--enable-dbgutil when no JVM is available, see fdo#57553.
(cherry picked from commit b6b71d74fddca5e260ab2a3d6307603f5b469108)
Change-Id: I50377a12c2baadf48767e1d4c265417d3c8ab765
Signed-off-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I32dd8cdd34965bf8dd31729a79b65d8ee78af7dc
Reviewed-on: https://gerrit.libreoffice.org/1187
Reviewed-by: Petr Mladek <pmladek@suse.cz>
Tested-by: Petr Mladek <pmladek@suse.cz>
(cherry picked from commit aa61177f1d339422acb3322c8851962cd1ca7466)
Signed-off-by: Lior Kaplan <kaplanlior@gmail.com>
|
|
It is no good to change temporary object...
Change-Id: Ib1178e154341dd0216fd965d3ed6c264de40d634
Signed-off-by: Kohei Yoshida <kohei.yoshida@gmail.com>
|