summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2018-09-29Window Iterator without parent vectorfeature/window-iterJan-Marek Glogowski1-10/+14
2018-09-29Debug infrastructureJan-Marek Glogowski1-0/+174
Change-Id: Idd09c131240c1372a40c36feb07094e28c2a1581
2018-09-29Initial vcl::Window iteratorJan-Marek Glogowski1-25/+153
Change-Id: I414d9eb3539d6a2a8844e24a7ef245fa99935f1b
2018-09-29Handle initial TabControl and border windowJan-Marek Glogowski3-27/+44
ImplGetSubChildWindow has special code to handle a TabControl and its pages. If the function finds a TabControl as a child it'll return its window and then recurse into the current page. This currently breaks in the case where the initial parent is a TabControl. where the function will walk all of the tab pages. The function also ignores border windows, but not if the initial parent is a border window. This patch correctly handles both cases and as a bonus drops all the special page handling during child iteration. Change-Id: Ie8699dae8d08628b66b33e0704237b9e219874bc
2018-09-28Add number comments to WindowTypeJan-Marek Glogowski1-9/+10
Change-Id: Icc8bddb00a26f3844d8b264acd5535951ac64f1c
2018-09-28gla11y: check element visibilityJan-Marek Glogowski5-8/+35
Add warnings for different visibility settings in the "label-for" and "labelled-by" elements. Sine LO doesn't support multiple annotations per accessibility element, we have to switch them manually, if we change the visibility of one element of a pair. Change-Id: I9b3d941248b804b8435591536277677e99b77340 Reviewed-on: https://gerrit.libreoffice.org/61050 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-09-28Qt5AccessibleWidget: Add state mappingSamuel Mehrbrodt1-0/+125
Change-Id: I6c846fcb56ecfc24d966dfd01b97c47460fdf16b Reviewed-on: https://gerrit.libreoffice.org/61068 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-09-28Qt5AccessibleWidget: Implement foreground and background colorSamuel Mehrbrodt1-2/+8
Change-Id: Ice848f429ce8b9d4395e3cf1c23c22aa806fb5f9 Reviewed-on: https://gerrit.libreoffice.org/61043 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-09-28sw: new unit test for XTextRangeCompareSerge Krot2-0/+168
Change-Id: Ia0d216b94f8090c3479c6e4c593baf84cb28e5e2 Reviewed-on: https://gerrit.libreoffice.org/61005 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-09-28Fix TRANPARENT -> TRANSPARENTAndrea Gelmini4-4/+4
It passed "make check" on Linux. Change-Id: I70ccaae61eb7961a331cabcd8f4e56b5ea5dfc4c Reviewed-on: https://gerrit.libreoffice.org/61045 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-28tdf#111980 oox: connect empty radio groupsJustin Luth3-1/+43
affects doc, docx, xls, xlsx (at least). Handling optionbutton groups is new since 2017, so incremental enhancements are OK. In LO, if an option button with an empty groupName (like any form control which has no groupName option), then it stands alone, which is a ridiculous position to be in for a radio button. So, lets put them all together into an automatic group. In MSO, buttons without any explicit group stick together, so the effective group is the entire document, or entire sheet. One complication is that ActiveX radio buttons don't interact with Form radio buttons, even if all of them have no group name. That situation is not handled by this patch (and not very likely to happen since ActiveX defaults the group name to the sheet name). (A Group Box can also be used, which automatically groups all buttons fully within its area. That will be much harder to implement since every object will need to first be categorized as groupbox or optionControl - meaning that everything must first be imported. That implies a function call from every application doing the import.) Change-Id: I204adaea75ce99999a16c0cc4e9c3b8b08da9433 Reviewed-on: https://gerrit.libreoffice.org/61064 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-09-28Fix dictionnary -> dictionaryAndrea Gelmini1-10/+10
It passed "make check" on Linux. Change-Id: I893b7873f3a7d3f43bf742f2ee126524310dfafb Reviewed-on: https://gerrit.libreoffice.org/61029 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-28loplugin:useuniqueptr in SwTable::NewInsertColNoel Grandin1-3/+2
Change-Id: If22b13087ab193ed37ca092c2b252579d5ac5d0e Reviewed-on: https://gerrit.libreoffice.org/61003 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-28Move TabPage lookup into extra functionJan-Marek Glogowski1-23/+26
This way it's easier to read the follow up patch. Change-Id: I42e8f78b69b4ed2cb28bf0f36496eb751e8cb433 Reviewed-on: https://gerrit.libreoffice.org/61036 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-09-28Constify vcl::Window child lookupJan-Marek Glogowski2-16/+12
Also removes the function comments before the implementations, as these are just the same as already in the header. Change-Id: I11425dc4aa372423fcf469ab1374159ce8b180e2 Reviewed-on: https://gerrit.libreoffice.org/61035 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-09-28Fix typoAndrea Gelmini1-1/+1
Change-Id: I3473cb5a565aba822428178030572325425c6a13 Reviewed-on: https://gerrit.libreoffice.org/61030 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-28loplugin:unusedfieldsNoel Grandin15-213/+243
Change-Id: I355fad84ed8765e8eb3fadb7c239b3b902ec1747 Reviewed-on: https://gerrit.libreoffice.org/61059 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-28Fix typoAndrea Gelmini3-3/+3
Change-Id: I1493733ebbe796e4ba3ec6f2dc69b4b91f79efdf Reviewed-on: https://gerrit.libreoffice.org/61027 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-28loplugin:useuniqueptr in DocumentListsManagerNoel Grandin3-42/+12
Change-Id: Id179245161d707e27e009b6ebc53d925aae5ce0f Reviewed-on: https://gerrit.libreoffice.org/61000 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-28loplugin:useuniqueptr in ScChartPositionMapNoel Grandin2-105/+48
Change-Id: I7c3209dff1c09c40d7a3bb57db0f0b26254318f2 Reviewed-on: https://gerrit.libreoffice.org/60996 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-28loplugin:useuniqueptr in ScDPResultTree::MemberNodeNoel Grandin2-22/+12
Change-Id: I835e37a99ddab174e45681fe6cf55edaa41a727c Reviewed-on: https://gerrit.libreoffice.org/60995 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-28weld SvxMeasureDialogCaolán McNamara5-29/+62
Change-Id: I9fc3364d83fa5e55cee6c823f16c05934ee2dc43 Reviewed-on: https://gerrit.libreoffice.org/61053 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-28Guard against invalid statesSamuel Mehrbrodt1-1/+13
Happened while trying the qt5 a11y stuff that mpWindowImpl was invalid. Change-Id: Ibe238bdcce6410689b1e65f7f45f7b9deea06de7 Reviewed-on: https://gerrit.libreoffice.org/61032 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-09-28Implement Qt5AccessibleWidget::isValidSamuel Mehrbrodt1-1/+1
Change-Id: Ie2ef115bc655d0f64e8b269e73d3343176f115e3 Reviewed-on: https://gerrit.libreoffice.org/61042 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-09-28Fix toogle->toggleAndrea Gelmini1-3/+3
It passed "make check" on Linux Change-Id: Id25a7893e536a579cef58f63e8ec7ce240ad16fb Reviewed-on: https://gerrit.libreoffice.org/60633 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-28Fix E_SUCCEDED -> E_SUCCEEDEDAndrea Gelmini2-5/+5
It passed "make check" on Linux. Change-Id: I96b34c818f6d4170c110ecd1fb93af79c3279e57 Reviewed-on: https://gerrit.libreoffice.org/61028 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-28tdf#120099 Reintroduce .def filesStephan Bergmann18-0/+51
...that had been removed with 28b4f4aeaf160c7721dfecf5bd2445d7dbc6f01c "Get rid of Windows .def files in setup_native, use __declspec(dllexport)". Looks like for 32-bit builds, the .def file EXPORTS are still needed to avoid __stdcall's _...@NN symbol decoration (and for 64-bit builds __stdcall is effectively ignored, so the removed .def files didn't make a difference there). This is only a partial revert of 28b4f4aeaf160c7721dfecf5bd2445d7dbc6f01c, the addition of __declspec(dllexport) for the benefit of loplguin:external should still be fine. Change-Id: I76a1a3f4671824367bab495afeba291c0340108d Reviewed-on: https://gerrit.libreoffice.org/61047 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-28sw: increase horizontal line parastyle default borderwidthJustin Luth1-1/+1
RES_POOLCOLL_HTML_HR had the absolute minimum width of 1 (0.05pt). Dividing by 3 in the "convert to word size" formula returned zero. It looks like import or export must increase the size to 3 because round-tripping in ODT format loads in a larger value that works when resaving as .doc. cui/source/tabpages/border.cxx sets the default for a double style border to 10, but the minimal value of 3 will be better since it matches the ODT round-tripped value (and looks more like a single line which people probably expect from the horizontal line). Change-Id: I32a90f2add3fe746359cd9cece14762ccc2a58c1 Reviewed-on: https://gerrit.libreoffice.org/61022 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-09-28tdf#119760 writerfilter: cell border priority over tblBorderJustin Luth3-8/+27
If the tblBorder does not exist, or if first row's left-border has a different sized border than the overall table settings, use the cell's lineWidth value to determine the the spacing needed. The potential regression here is the spacing given to the cells. However, the current calculation is totally wrong (it needs to be based on per-cell, not on some table-level default) and so it was "wrong" a different way before. The unit test shows this visually. Plus, MS Office version are inconsistent in handling this unit test. The latest versions base the position on the *last* row and not the first row. The key reason for making this change is to support a table that doesn't have a table default, needed to fix tdf#92026. Change-Id: I319513a2f5550c1527dc564fb8b3806d1251a0c2 Reviewed-on: https://gerrit.libreoffice.org/60988 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-09-28Fix mbRefeshingPeer -> mbRefreshingPeerAndrea Gelmini2-5/+5
It passed "make check" on Linux. Change-Id: Ia28f23b78b467fc70431fa4a7ed41ae2f3a4c5fd Reviewed-on: https://gerrit.libreoffice.org/61046 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-09-27pass parent to CreateSfxDialogCaolán McNamara2-2/+2
Change-Id: Ie46de317003ebbfca3ee99d7ab60bef4ac762f76 Reviewed-on: https://gerrit.libreoffice.org/61054 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-27UND->AND; ODER->ORMike Kaganski3-6/+6
Change-Id: I921db377c257dc50e3f39fe04f0ad093f3db6a81 Reviewed-on: https://gerrit.libreoffice.org/59896 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-09-27-Werror=unused-variable (--enable-debug --disable-assert-always-abort)Stephan Bergmann1-1/+1
...found by <https://ci.libreoffice.org//job/lo_tb_random_config_linux/1504/> Change-Id: I8ebbe48cdbbdf378731bbc4548031d8799d91532 Reviewed-on: https://gerrit.libreoffice.org/61023 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-27sw: fix copying of PageDesc follows in SwDoc::AppendDocMichael Stahl1-9/+35
The problem in the bugdoc is that there are 2 styles; "First Page" has "Default Style" as the follow, and vice versa. When the "First Page" style is copied, its follow is copied as well, but the follow of the follow doesn't point to the *new* "First PageN" style that was just created, but the original "First Page" one. Change-Id: Ie5b0064581a585a3a545360ea5c05f60652f0d4e Reviewed-on: https://gerrit.libreoffice.org/60993 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-09-27Hide also TimeRecord, for tilebench for iOSTor Lillqvist2-0/+2
Change-Id: Iaf34e5f14b0753960a13b0a9ff3d734bfc08d139
2018-09-27Need to handle css::uno::RuntimeException too nowTor Lillqvist1-0/+1
Change-Id: Idedcaddeab80fcfdc3d5a4f2852712827a98e848
2018-09-27Draw rendered tile border here in the normally ifdeffed out snippetTor Lillqvist1-3/+7
Not just some stuff in one corner. When using this test code, I want to see the borders of the actual (combined) tiles that we attempt to render. Change-Id: I270d5a6b16ec717f8613def57d710b97fbd33672
2018-09-27Do build cppunit for iOS, tooTor Lillqvist4-84/+4
I am writing a separate unit test app that will include selected existing unit tests that make sense and are important to run on iOS. Change-Id: I4722f1ed872ba21e181eeba5ed3b58e82d8fed72 Reviewed-on: https://gerrit.libreoffice.org/61049 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-09-27printdialog: fix some accessibility warningsSamuel Thibault2-5/+14
Change-Id: Icf508473d194bc8c6f01e551b6659a625b8ee229 Reviewed-on: https://gerrit.libreoffice.org/60141 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-09-27weld ScTablePageCaolán McNamara3-245/+263
Change-Id: I38d86705de3215a7e8c24f03c2d253751e66b2d8 Reviewed-on: https://gerrit.libreoffice.org/61040 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-27qt5: Add basic a11y supportSamuel Mehrbrodt8-2/+653
Widget tree is displayed and basic role mapping is available. Still needs quite some work (positions, actions, texts, etc.) Change-Id: I9d26a762f1d9684f33bbb80a384cf2a0b8a905c0 Reviewed-on: https://gerrit.libreoffice.org/60853 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-09-27tdf#119238: keep replaced file's identity when renaming docfileMike Kaganski6-1/+110
Regression from 2157a3536f97ff5ae7c82611a801fef7e3708983 sfx2 store: try rename before copying Rename is cheaper then copying the content over manually, so try that first. On Windows, we need to keep the file's dentity, including metadata (e.g., creation time, which is kept in FS). WinAPI has ReplaceFileW specifically for this, and it keeps ACLs of the original file, and otherwise makes the changed file not a separate entry, but updated old file from system's PoV. Eventually, we could try to restructure creating backup copies (e.g., for documents when configured so) to take advantage of this function being able to do that. Change-Id: I6001a2a3af5e10bc010f5ef129f4bb6f83ee1581 Reviewed-on: https://gerrit.libreoffice.org/60163 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2018-09-27ofz#10696 null-derefCaolán McNamara1-0/+1
since... commit c6b8587eef3ead53418312c43012f4322789a33a Date: Wed Sep 19 16:35:10 2018 +0200 loplugin:useuniqueptr in SvxRTFParser Change-Id: Id901d5645500fedcb54b11e1b5b27fe81281f5a2 Reviewed-on: https://gerrit.libreoffice.org/61033 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-27coverity#1439332 silence Identical code for different branchesCaolán McNamara1-0/+1
Change-Id: I9f477e063fd764fff24843562a2de34b5498d4c5 Reviewed-on: https://gerrit.libreoffice.org/61038 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-27Fix typoAndrea Gelmini1-3/+3
Change-Id: I0542342f4a55bf4740fd8360b8e26dbd7e2ffa2d Reviewed-on: https://gerrit.libreoffice.org/61031 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-27xmlsecurity nss: avoid deleting the keys manager manuallyMiklos Vajna1-12/+13
Change-Id: I53a88116148db9e1ceac4024781516173c3d4666 Reviewed-on: https://gerrit.libreoffice.org/61021 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-09-27Fix typosAndrea Gelmini19-24/+24
Change-Id: Icfe120db02a70d43e4120d1f4cbb2704640d3990 Reviewed-on: https://gerrit.libreoffice.org/59470 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-27loplugin:methodcycles more graph theory for the winNoel Grandin89-1581/+190
implemeent a reduction approach, which is good at finding virtual methods that only themselves or their virtual partners. The accessibility GetVisArea stuff is dead since commit 891e41fac81fbd8d5cdb277b26639abfd25a7143 Date: Wed Apr 4 11:23:22 2018 +0200 dead code in AccessibleTextHelper_Impl::UpdateVisibleChildren Change-Id: I78d9d8bca585ecec8394f2c3fe2baa93db0e58f5 Reviewed-on: https://gerrit.libreoffice.org/60912 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-27dispose custom widget a11y on teardownCaolán McNamara1-1/+5
Change-Id: Iea80ffff0b36e093e4b8e513e924a21da67cb2ce Reviewed-on: https://gerrit.libreoffice.org/61009 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-27uitest: add the ModelessDialogVisible event to the execute_blocked_actionMarkus Mohrhard2-1/+4
Change-Id: I5496bf0bcce442c60d2ecd4207734d0e8b17935b Reviewed-on: https://gerrit.libreoffice.org/61026 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 01:43:59 +0000