summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2016-04-04subtable corruption is possibleCaolán McNamara2-3/+2
Change-Id: Ifbf4312df583724a22328491bea3b6e05b82418f (cherry picked from commit 9814cf713c57b211f5632733a853150d1d1e8da9) Reviewed-on: https://gerrit.libreoffice.org/23767 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-03-31tdf#92963 Pasting a whole row with data crashes all open LibO appsArul Michael1-0/+7
In ScColumn::GetNeededSize the memory pointed by rOptions.pPattern is freed and new value is set again in ScFormulaCell::InterpretTail function in pDocument->SetNumberFormat when pDocument->GetCondResult is called in column2.cxx:130.For fix setting the newly calculated ScPatternAttr* value after the GetCondResult call. Change-Id: I045404465b6dfa561b0821bb3b1875463aa7887a Reviewed-on: https://gerrit.libreoffice.org/23688 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 99bf0b931401f556033f67297aa9783c4cf19b00) Reviewed-on: https://gerrit.libreoffice.org/23709
2016-03-31vcl: tdf#98812: acquire reference count of WinFontInstancesMichael Stahl3-0/+25
... when they are inserted in WinSalGraphics::mpWinFontEntry. Not sure why one of these drops to 0 but is not removed from the WinSalGraphics when formatting this particular bugdoc. Acquiring the instances when retaining pointers to them should make the life cycle a little less insane. (cherry picked from commit 99207a26df0083851ba8e23be72d5c6974f98a3b) Reviewed-on: https://gerrit.libreoffice.org/23504 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 4ae7ec8c8d22e751b868459e1f51fcecc37dd6b1) tdf#98812: follow-up pFont->mpFontInstance can be NULL. Reviewed-on: https://gerrit.libreoffice.org/23654 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 9fa87bb1a42c45446f78b4d8c8096d7ce90a8022) Signed-off-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 4ab36bbd1816d6f297892a638e6826f28ca87150) Change-Id: If1404f46a13736b2a226e198bdf0c3ca8e09bb38 Reviewed-on: https://gerrit.libreoffice.org/23651 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-03-30tdf#96326 RTF import: handle checkbox form field undefined resultMiklos Vajna3-1/+44
The RTF spec is quite terse on how the form filed result should be interpreted, but the binary equivalent documents properly that checkboxes have 3 valid states: 0, 1 and 25, the later meaning undefined. Use the default value in that case. (cherry picked from commit 829596eb36de32bd87b426d9ad11901eabeae7be) Change-Id: I672bf8d1f63d7880227b7fa7b5c81f91e1877b2a Reviewed-on: https://gerrit.libreoffice.org/23511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-29tdf#98882 DOCX import: set default para properties on the Standard para styleMiklos Vajna3-27/+53
That's what the DOC import does, and that's the reason e.g. the strange unwanted crop of the as-char anchored picture doesn't happen there. This also needs the "reset all existing style properties back to default" logic to be adapted: the Standard style has to be reset before the default are set, and later it should be left alone, otherwise the defaults are lost. (cherry picked from commit eae2331f83bd58bacccd898d60f6c5f54856c036) Change-Id: Ie422a0b64b80a826fa4f469145a26283fb32d734 Reviewed-on: https://gerrit.libreoffice.org/23598 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-03-28Resolves: tdf#98642 comparing RPN insufficient in shared formula detectionEike Rathke1-1/+46
(cherry picked from commit d6b32653ad34f0879ad1ada421a3a2655dd766e1) Backported. Change-Id: I78812c2d6fdb3464ccc2ebeee901a76f675effa4 Reviewed-on: https://gerrit.libreoffice.org/23437 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-25tdf#88453 sw layout: fix split of nested tables with large amount of rowsMiklos Vajna4-1/+62
This does not fix the original bugdoc, just the case described in comment 2. The bugdoc has an outer table of a single cell, and that cell has a nested table with a single column and many rows. When we split the table, we set the height of the last row frame to zero, then the height of the last but one, and so on, till the reduced table fits the page, then move the 0-height frames to the next page, and so on. All this recursively, to support nested tables. The problem is that 0-height is set only for the contents of the cell frames, but not for the cell or row frames themselves, so in case e.g. the default ~0.10cm inner margin of the cell frames, even a 0-height text frame results in a cell frame height of 111 twips. And this error can accumlate if there are enough rows, e.g. with the default fonts 123 rows are enough to trigger the situation when even a completely reduced table doesn't fit the first page frame, and the layout throws up its hands. Fix the problem by setting the height of the cell and row frames to 0 as well in case their content is 0-sized anyway (so a re-format will later restore their correct height). (cherry picked from commits b4b5dbee1ec7770ed64d7270de46d5cfc06b87b6 and f4eb82cf9fea5c1df49fad6ee2d91fc51854cd29) Conflicts: sw/qa/extras/uiwriter/uiwriter.cxx sw/source/core/layout/tabfrm.cxx Change-Id: Iefbbb7bd6ef97a9a81929eb2599adb961e52fd38 Reviewed-on: https://gerrit.libreoffice.org/23513 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-03-24tdf#59699 RTF import: handle INCLUDEPICTURE fieldMiklos Vajna11-10/+96
On one hand, don't handle a fieldmark for it in dmapper. On the other hand, handle the field in the RTF tokenizer as it would be {\pict ...hexdump... }, that will result in an inline picture, as wanted. (cherry picked from commit 6f94cab9c43f88624b58a47ad03ad5f87032595d) Conflicts: writerfilter/source/dmapper/DomainMapper_Impl.cxx writerfilter/source/rtftok/rtfdocumentimpl.hxx Change-Id: I554fdf017920350144300fd86617bf74eed8995b Reviewed-on: https://gerrit.libreoffice.org/23298 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-24fix the "group not recalculated after delete" second part of tdf#97897Eike Rathke1-0/+18
If a formula cell group was split during deletion and the group also listened into the range where a cell was deleted, the group wasn't notified of the deletion. Change-Id: I858f5d4c0b647636611133fc32f3df7fbdaf7288 (cherry picked from commit 164419bfe6270015ccf94183c0b6273da7730391) Reviewed-on: https://gerrit.libreoffice.org/22784 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-24off-by-one error: columns are numbered from one, but the array from 0Lionel Elie Mamane1-1/+1
Change-Id: I14ef451999fa1f9d57757a9e231fc66be4e53f3a Reviewed-on: https://gerrit.libreoffice.org/23406 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-03-22tdf#95977: fix fly positioning regression from 0c5cbcd7Bjoern Michaelsen1-1/+1
Change-Id: I7e11c7072ba0ec82237985da79f8572fdda05778 Reviewed-on: https://gerrit.libreoffice.org/23430 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-03-22tdf#98416: Explicitly disable curl hardcoded CA certificate storeGiuseppe Castagno1-0/+1
Add --without-ca-bundle --without-ca-path options to curl configure in Linux, to explicitly disable the hardcoded curl CA certificate store. If the store is not disabled, curl configure will try to find one suitable for the Linux distro on which it's being built, leading to possible problems when building on a Linux distro type while targeting another Linux distro type (e.g. building on Red Hat derivative targeting Debian derivative). Change-Id: Id1ddf1d74e33bc66e4f7187e376d7379f5c4f36a Reviewed-on: https://gerrit.libreoffice.org/23141 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 30b9c6a457de61f3c94431ecc75716f866c3379e) Reviewed-on: https://gerrit.libreoffice.org/23245 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-21tdf#98740 Infobar should not be in the customization optionsSamuel Mehrbrodt1-3/+3
Change-Id: Ib6675d621ad9c6ee5c4576ff95bb6eac39ef4b5f Reviewed-on: https://gerrit.libreoffice.org/23357 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-03-18ensure a correct index is assigned to a duplicated ScRangeData instanceEike Rathke1-0/+1
ScRangeName::insert() assigns an index only if the passed ScRangeData instance's index was 0. Duplicating an ScRangeData object duplicates also the index, so effectively two instances with the same index could be inserted to the named expressions collection, a following ScRangeName::findByIndex() retrieved one of them by chance. Change-Id: Ic141ffb1a683bda5907f4359167da84faf1649e1 (cherry picked from commit 336d816176650726f6d14539464d9fd28ddd032d) Reviewed-on: https://gerrit.libreoffice.org/23324 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-18tdf#95421 Galaxy anchor markers can be dragged againRegina Henschel1-0/+0
The anchor markers in Writer could not be dragged, in case the Galaxy icon-theme is used. The reason is, that in their corner color is missing. The altered file adds some very transparent gray in the corners. The change is hardly visible. Change-Id: I6e0befcbf16826d4331bf0b9771b58c02a73e37f Reviewed-on: https://gerrit.libreoffice.org/23342 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 243f8abf829323877733612c311019ec63956d82) Signed-off-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-03-17tdf#98458 sw: Fix performance problem when searching in large documents.Jan Holesovsky1-4/+4
Change-Id: I0056a411d7a3bb018401d87bdd4a0112fed31df6 Reviewed-on: https://gerrit.libreoffice.org/23340 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-17upgrade openssl to 1.0.2gCaolán McNamara8-78/+93
We can't "break symlinks after extracting tarball" because they populate that dir during the build now. So instead cripple mklink.pl to copy instead of link. (Configure no-symlinks simply skips the symlink step instead of copying, so that appears useless) Reviewed-on: https://gerrit.libreoffice.org/21880 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 01798050c13fdfc51aff95967f6b0177d5d7f5bd) Change-Id: Ib30b2c1b8b3de72511d09c478297a7a5a4bc691e Reviewed-on: https://gerrit.libreoffice.org/23002 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-03-17tdf#98052 - even polygons were not drawn on the alpha deviceMarco Cecchetti1-0/+2
Change-Id: I5725ec23869b295c8021bef0330ee6f69f206351 Reviewed-on: https://gerrit.libreoffice.org/23025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-03-17fix nss build when targeting windows XP (using 7.1A SDK)Christian Lohmaier2-0/+11
otherwise build fails because of macro redefinitions warnings (that are now fatal because of warnings=errors) (cherry picked from commit 09e201fcf2813152335d50588dae0c38adc88d51) Change-Id: I0a15083d9ffd032c48ab491695319309f3053fb7 Reviewed-on: https://gerrit.libreoffice.org/23272 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-03-17tdf#97139: prevent loop while formatting small text linesOliver Specht1-1/+5
when text is inserted at the end of a line then text formatting starts some characters (platform and ENABLE_GRAPHITE dependent) before the insert position. In case of small lines this might even be the start of the line. To prevent going back to the previous line the cursor right margin flag needs to be reset. Change-Id: I73a62ce6c7707469fddeeffe0d7eec064c5989ea Reviewed-on: https://gerrit.libreoffice.org/22641 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de> Reviewed-on: https://gerrit.libreoffice.org/22667 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-03-16tdf#98416 fix curl's configure check for nss (missing -lnssutil3)Christian Lohmaier2-0/+18
without -lnssutil3, the configure check for nss fails when using internal nss: configure:24028: checking for SSL_VersionRangeSet in -lnss3 […] …/UnpackedTarball/nss/dist/out/lib/libnss3.so: undefined reference to `NSSUTIL_ArgParseModuleSpecEx@NSSUTIL_3.21' causing curl to build without ssl support: SSL support: no (--with-{ssl,gnutls,nss,polarssl,cyassl,axtls,winssl,darwinssl} ) This makes gdrive and other remote file methods fail Change-Id: I098feb10a760c2f80a474d9205d6f1e403477efd (cherry picked from commit 98d48dad9e807a4a40f4c3d1b5280d9e5156cb18) Reviewed-on: https://gerrit.libreoffice.org/23191 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-15Resolves: tdf#93196 add RecursionCounter guard also to InterpretFormulaGroup()Eike Rathke1-19/+29
... same as for ScFormulaCell::InterpretTail() Change-Id: I444f259fe4e86ed0638a04f1b5d9272edd182e2e (cherry picked from commit 29ee431c1cf859c3d5a5041cff5cb04b89db27a0) Reviewed-on: https://gerrit.libreoffice.org/23280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-15update creditsChristian Lohmaier1-1348/+1418
Change-Id: I7ea667687d4a11c026d69382d9e62533bc0db4ea (cherry picked from commit b4d9ba8aa9c63c5e527bf640f136c77990eb6747)
2016-03-15Resolves: tdf#94392 huge negative Y causes length exceptionCaolán McNamara1-1/+8
because this rendering stuff is deleted in later versions of LibreOffice and replaced with cairo rendering, just bodge this case to give up and go home. Change-Id: I4e60184b0919dc719edfe223ebb2d8ef684608e8 Reviewed-on: https://gerrit.libreoffice.org/23154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-03-15Resolves: tdf#82781 avoid dereferencing invalid iteratorsCaolán McNamara1-4/+9
when using print preview with cursor on 2nd page which consists solely of hidden text with show hiddle text enabled. inner mrParentViewShell.Paint can invalidate iterators, as later detected with the mbNewLayoutDuringPaint flag but we dereference for the purposes of drawing the shadow before we get there. easiest thing seems to be to just grab the bits of info we want before the inner paint occurs. (cherry picked from commit 4eb5f363ed9a3181a817f12d5ec49eede13b9c9c) Change-Id: I09c9b06449db440b7beba7de9e71c239ee64f6ca Reviewed-on: https://gerrit.libreoffice.org/23094 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2016-03-15enable build with gcc 6Caolán McNamara1-3/+3
Change-Id: I391550d243ae7f773d988cb36f45c482d0c97145 Reviewed-on: https://gerrit.libreoffice.org/23153 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-03-15recurse protection for XFConvertCaolán McNamara9-14/+25
Change-Id: Ib6008d4b07159acad26c7baeb775702119c12e3b (cherry picked from commit 9e0004f2cc64ffa23ecd5c7c82016624eb8a5a20) Reviewed-on: https://gerrit.libreoffice.org/23259 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2016-03-15tdf#94370: Make previews of master pages finally appearKatarina Behrens1-0/+1
Just force the whole ValueSet to be formatted. Individual rectangles are already being invalidated (when PREVIEW_CHANGED event comes), but something naughty must be happening in ValueSet that those changes don't show. Change-Id: I4fd8af36e34c3a445d7b16b59e45256f016fd9df Reviewed-on: https://gerrit.libreoffice.org/23115 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 1b98d7a3c4f1de39226e44e5b27351d8bfbbe6c0) Reviewed-on: https://gerrit.libreoffice.org/23116 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 819166500c1b45e4241fdb47f2de6653e4495372) Reviewed-on: https://gerrit.libreoffice.org/23253
2016-03-14tdf#98083: Always save cell formatKatarina Behrens5-13/+44
it was pretty bad idea not to save it for rich-formatted cells (tdf#92296) as there is more to cell format than just a font Due to a bug in xpath helper I'm backporting only part of the test (cherry picked from commit 7945cdf0ea570302a04550540848c03c0cd030ab) Change-Id: I0e5e7d7187c69519bb8f4de2b627e385fccd3d46 Reviewed-on: https://gerrit.libreoffice.org/23033 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-03-14Resolves: tdf#95428 backspace in readonly macro editor hangsCaolán McNamara1-4/+3
Change-Id: I16568b00e92d18f32818188ba3ab8df92bbd13aa (cherry picked from commit 5b3f84cec471ddbde98a46220096cdb952bb1935) Reviewed-on: https://gerrit.libreoffice.org/23088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-03-14treat ExtMargins with same recurse protection as MarginsCaolán McNamara3-5/+16
(cherry picked from commit bcecf9b13b7eee0e7c60a6827a310f8b38d13f69) Change-Id: I24640971ea6ca89878043966293492a991f01008 Reviewed-on: https://gerrit.libreoffice.org/23146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-03-14tdf#96687 - force validation after External InputJustin Luth1-0/+1
After external input (EndExtTextInput), the selection was marked as invalid, but bFormatted remained true, so all the functions that re-evaluated and marked the portion as valid again were skipped and therefore the invalid portion was not painted. Change-Id: Ibb2208bdaeb8ed17a4a34fa378a2fc750abf1b07 Reviewed-on: https://gerrit.libreoffice.org/20986 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 5a217ada5e28e17f052ebec8e53dce05c2aa9cae) Reviewed-on: https://gerrit.libreoffice.org/23190 Tested-by: Justin Luth <justin_luth@sil.org>
2016-03-11fix for 10 sec hang with audio-only formats with gstreamer1Caolán McNamara1-1/+2
just do the same as we did for gstreamer 0.10 and set the size found condition once we get the message even if there is no size Change-Id: I826d76dd1097432e5bd33d4acc1a187b8e5068da (cherry picked from commit 702790258c6b3ec05ce04f7c2839a48776381535) Reviewed-on: https://gerrit.libreoffice.org/23119 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-03-10nss: upgrade to release 3.22.2 fixing CVE-2016-1950Michael Stahl1-1/+1
Reviewed-on: https://gerrit.libreoffice.org/23070 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 4d77c8088b52c649e80c12e208131a6844a53b12) Change-Id: Idc89778b488f2c84e5b0d495d2f44e623cc542b5 Reviewed-on: https://gerrit.libreoffice.org/23104 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-10nss: Fix pointer truncation from 'char *' to 'long'David Ostrovsky1-0/+11
Change-Id: Ie1659c62cbf77f8b685fdf7d79cd62336fa99005 Reviewed-on: https://gerrit.libreoffice.org/22916 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> (cherry picked from commit 59907b36008010d87cc31b1f8ab581d5e4ac1c0b) Reviewed-on: https://gerrit.libreoffice.org/23103 Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: David Ostrovsky <david@ostrovsky.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-10Bump nss to 3.22.1 and nspr to 4.12David Ostrovsky6-25/+53
It seems like nss has activated -Werror, even though the code is not warning free: [1]. This applies also to the additional patches that would need to be patched to be a warning free patch, endless recursion. To avoid messing around with something like that: [2], we disable -Werror option for now. Also note, that [2] doesn't fix all warnings, but only part of them so that we let with unsolved non-trivially to fix warnings on different supported compilers if we would choose the warning-free-compilation-path. [1] https://groups.google.com/d/topic/mozilla.dev.tech.crypto/TgnF3tIMxJ0/discussion [2] https://git.fedorahosted.org/cgit/nss-pem.git/commit/?id=ec2b9a90623b1ec5adb6ebe8d6651b35854786ec Reviewed-on: https://gerrit.libreoffice.org/22650 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org> (cherry picked from commit 486c91147c587febdacf3fa95d56633dbd703d5f) Change-Id: I762c03acede6c4eac715d3b0589061eeabbcc7c2 Reviewed-on: https://gerrit.libreoffice.org/23102 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-10Updated coreKrunoslav Šebetić1-0/+0
Project: dictionaries a6d5e4951064e9a1027dd0045da0c49fa04713ef tdf#98531 Updated Croatian dictionary - converted .aff to UTF8 to match .dic encoding - removed nonsenses like "word1yyyyyyyyyyyyyyyword2" or "wordyyyyy." - added 123 new words - added some new classes to .aff (just because I could not use default ones, nothing fancy) - tried to improve suggestions by adding a REP section Change-Id: I002e86fbc1b8e239404220c550e08e12b99e5910 (cherry picked from commit 3bbf614616d6da0c94b8953299c467c1db7b912d) Reviewed-on: https://gerrit.libreoffice.org/23114 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-09external/nss: -fsanitize=nonnull-attributeStephan Bergmann1-0/+11
Change-Id: Ic3a20f56250d99a347df5deaf785800a2f96e470 (cherry picked from commit 8d2ac08383f894f428da63f4653d0cbd6649e0db) Reviewed-on: https://gerrit.libreoffice.org/23101 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-03-09tdf#87034 RTF import: fix multiple superscripts after footnote ...Miklos Vajna4-6/+21
... in the same paragraph. The intention was to avoid replaying the supertext buffer and using its contents as a custom footnote mark at the same time. However, it's enough to check if the buffer is empty to do so, and that avoids the mis-import of the bugdoc as well. (cherry picked from commit 93faf178195ca974747849879266783884ae27c5) Conflicts: sw/qa/extras/rtfimport/rtfimport.cxx Change-Id: I1e3b0c7f0c6d8eb8250d8b1d0d7d196039c40e79 Reviewed-on: https://gerrit.libreoffice.org/23084 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-09Resolves: tdf#95226 second case, stack error count in JumpMatrix contextEike Rathke1-0/+14
For the early bail out on errors to work correctly and not prematurely end calculations the current error function needs to be stacked in JumpMatrix context, otherwise we may end up with ((nErrorFunction=74)>=(nErrorFunctionCount=2)) or some such.. (cherry picked from commit 62b40429946c0e5021912072dc79a60fc11fce06) Change-Id: I3559e15180694961585db92f6aa98a46430ae372 Reviewed-on: https://gerrit.libreoffice.org/23091 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-09avoid infinite regress in busted documentsCaolán McNamara8-17/+28
Change-Id: I639617e41cd9a9a51a3dd3efa32ac1cf2991b9d2 (cherry picked from commit f16ceae46dd8f3974a379c6fb07feaffb8012b25) Reviewed-on: https://gerrit.libreoffice.org/23031 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-03-09tdf#97942 Return Ctrl+Shift+Space to the keyword customizeYousuf Philips1-0/+2
Change-Id: I4a886a9312a4b4afbe2451b88941b72dc5c6dadc Reviewed-on: https://gerrit.libreoffice.org/22621 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit f6f66bd6a102239f3d24c257298dc1f6c2fd8199) Reviewed-on: https://gerrit.libreoffice.org/22671 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-09Resolves: tdf#98297 exclude error values from COUNT in array/matrixEike Rathke3-9/+25
Backport of b2f5336b08b5f638f890a626eb2aeefaf499a79b Change-Id: I04ef53b8880243b3548e1b7fd926690dcb4a2137 Reviewed-on: https://gerrit.libreoffice.org/22846 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-09Resolves: tdf#98389 check memory requirement of matrixEike Rathke4-113/+268
Attachment 123203 of tdf#98389 has external references of the form [1]Data!$1:$1048576 which effectively address the entire cell range of sheet Data and allocating a matrix for a billion cells attempted to allocate 8GB+xGB of memory which the system said no-no ... Some brave soul along the road once decided that a check on the number of elements wasn't needed anymore and dared to remove it during refactoring.. This change reintroduces the check and adds it also to other places that try to instanciate or resize a matrix. When allocation of a matrix for an external range reference fails it is checked whether the request is for such nasty entire rows or entire columns ranges and if so tries to shrink the range to the actual data area used, which at least in this case helps and works. Additionally it fixes a long standing bug in the cached area to array mapping which caused the cache to not be hit but instead the matrix was aquired over and over again for the same range, causing a serious performance bottle neck specifically for VLOOKUP and related functions where the same external range is used in a lot of cells. (cherry picked from commit 9e60bbdb3aa5f80ca80c9c4fdf7accd12c4a5d1c) Change in convertToTokenArray() backported to older code flow. disable means Enable(false), not true.. tdf#98389 related EnableAdjustHeight(true) lead to the side effect that when clearing the range of a pivot table during import, formulas in the same rows were recalculated with then empty data. Through xSheetOp->clearContents() in PivotTable::finalizeImport() of sc/source/filter/oox/pivottablebuffer.cxx In the case of the bugdoc attached to tdf#98389 that lead to all VLOOKUP() calls resulting in #N/A errors because an empty string was looked up. (cherry picked from commit 088ba465d6bb0931c7034d564a3077e21078cb13) e629ce871d255cc871671165c4da974f21041cec Backported to ScMatrix implementation of 5-0. setCellRangeData: check matrix size before operating, tdf#98389 follow-up Now that we can have the one element error matrix we can't blindly call ExecuteOperation() on it that would access elements out of bounds. (cherry picked from commit 9cae3a88587deaf22ee83b2e36487013a1220a3b) Backported to older code flow. b6e5525f685c9324235f128a943dd716ea7a3fca Change-Id: I35f67b48e665bf1cc8d672325c32b889f2e05c57 Reviewed-on: https://gerrit.libreoffice.org/23003 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-09basic: tdf#87530 if a new password is set, must set mbLoadedSource flagMichael Stahl1-0/+10
... so that the library is stored (and encrypted), and not copied unencrypted from source storage. Change-Id: I9546087ec6f07007aa1ec377d2e959f2bae99a38 (cherry picked from commit 6a351c5cf91d0f667168d834ba2eb5c04121c7d5) Reviewed-on: https://gerrit.libreoffice.org/23043 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-09basic: tdf#87530 don't copy storage that doesn't existMichael Stahl2-2/+101
If the Basic library is newly created it may not have been stored to the document storage yet. (regression from 5246fa262450f686674850c53df666422f441c86) (cherry picked from commit aeb43916366b293935314efe9454c66b4877b9d1) tdf#87530 finish the regression test Need to store the document twice to actually reproduce the bug. (cherry picked from commit 7faecc70c286c0e1a3068b77ccde771640928b37) Change-Id: I9c2fc1d7446795b9c1c2224671118b2a671dcad8 Reviewed-on: https://gerrit.libreoffice.org/23042 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-08upgrade neon to 0.30.1Caolán McNamara3-48/+7
Reviewed-on: https://gerrit.libreoffice.org/22977 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 1827987fd11cd726005977e49d001283033f0419) Change-Id: If84ce83cdbde530f7a6743c93ae210b030a41c30 Reviewed-on: https://gerrit.libreoffice.org/23001 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-07Refresh graphite2.win64.patch.1 to apply using sle11 patch binary.Tomáš Chvátal1-25/+26
Change-Id: If43ca99631fab5a3a04e7dead9b694cf52944666 Reviewed-on: https://gerrit.libreoffice.org/20882 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 817192b3f55be0b0a4a6e877a3c1ab95d3a4b4cb) Reviewed-on: https://gerrit.libreoffice.org/22845 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2016-03-07Revert "gtktiledviewer needs gtk3 not gtk2"Adolfo Jayme Barrientos1-2/+2
This reverts commit 9d7e6cd14f82ae8bdb39901ac73999f6c9224307.
2016-03-07gtktiledviewer needs gtk3 not gtk2Caolán McNamara1-2/+2
(cherry picked from commit e451b03e8c21ad23cb1abfd6dd68b6d1e8188121) Change-Id: Iede2008139cb570ff65202762e92f6694548a065 Reviewed-on: https://gerrit.libreoffice.org/22983 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>