AgeCommit message (Collapse)AuthorFilesLines
2017-04-02fix crash when there are no row fields + testfeature/pivotchartsTomaž Vajngerl2-4/+44
Change-Id: I56852e953e32767fcf7d93f5cfcfd0fe7642443a
2017-04-02chart2: simplify pivot chart testsTomaž Vajngerl1-55/+38
Change-Id: I58ffe4b63a74e329272da3a371d6afebe1412975
2017-04-02Add table pivot chart supplier API, update testsTomaž Vajngerl18-64/+951
This adds the XTablePivotChartSupplier and related interfaces so we can access, create, delete pivot charts from UNO in a sheet document. With this we now distinguish between normal charts and pivot charts. This was mainly needed because we can't extend the "published" interfaces of TableChartSupplier. Updated the test framework in chart2 to use the new interfaces. Added an extensive test, which uses the API to create a new pivot chart when there was none, and checks that the pivot chart updates when the pivot table updates. Change-Id: I05891b44aac7bb780e04e31292eac244af0443d4
2017-03-31xmloff: assign the number format supplier at constructionTomaž Vajngerl2-4/+13
Change-Id: Ieb6af6351312a15bb71bbd8534d021a805b194a7
2017-03-31compile fixesTomaž Vajngerl2-2/+1
Change-Id: Ic1f67280b21c4b5343dee7f09e840f6e651daea8
2017-03-31chart2: pivot chart round-trip test, pivot table update testTomaž Vajngerl5-0/+376
Change-Id: Ia96bae4f24e7031929ceb9dc9fbeaa841def7547
2017-03-31xmloff: add ODF import/export for pivot chartsTomaž Vajngerl18-131/+381
This adds import and export for pivot charts: - Added loext:data-pilot-source attribute on chart:chart which is the internal name of the pivot table with which the pivot chart is associated with. If the element is present, then the it means the chart is a pivot chart, else it is a normal chart - Added service to create pivot chart data provider through UNO - Add new methods to XPivotChartDataProvider to create value and label data sequences separately from the data source, which is needed for pivot chart import - When importing defer setting the data provider until a later time when we know if we are creating a chart od a pivot chart Change-Id: I414203518a12d0f20ca17fe55c3af7bc683f60e2
2017-03-30change removed include XPopupRequest for XRequestCallbackTomaž Vajngerl1-1/+1
Change-Id: I472ee5593977f15b144cac2f0683c8de5690af76
2017-03-30chart2: check if data provider is pivot chart in VLegendTomaž Vajngerl1-2/+4
Change-Id: I03f92ec2fae2e832e8e4d4d27f208741dacb88ac
2017-03-30chart2: check if data provider is pivot chartTomaž Vajngerl1-0/+2
Change-Id: Ib5e034f4d9d91a7c7b8627383e4ff3f5ae34b6bb
2017-03-30remove (X)PopupRequest as it appears we won't need itTomaž Vajngerl8-94/+8
XRequestCallback alone is good enough for pop-up request so we don't need XPopupRequest and PopupRequest. Change-Id: I4617cb3db0c90f629e27db0d1991196ce75acae4
2017-03-30pivotcharts: show filter pop-up from charts on field button clickTomaž Vajngerl14-109/+259
This adds the functionallity to show a filter pop-up (from calc) when clicking on row / column / page field buttons. Additionally to implement this it was needed to add a new struct PivotTableFieldEntry, which transports the data for field buttons from the data provider to chart. This was necessary as in addition to the field name, it is needed to transport the dimension index. Other changes are: - some additional data provider fixes and clean-ups - mouse click on field button (mouse button down / up) - ignore other actions when detected a click is on a field button - parameters for the PopupRequest callback - parse parameters and execute the pop-up a the desired position Change-Id: Id40ffccbce7aaaddb045eb1894d55bfe0427ee6d
2017-03-30chart: change field button CID so it is easier to parseTomaž Vajngerl2-4/+4
Change-Id: If75e6a247ff619e850e6f07f308d3863754db5d4
2017-03-30charts: fix drawing multiple buttons in legendTomaž Vajngerl1-3/+4
Change-Id: I101d6ee6e06e78ba5e0748a796b6640c47fa67cf
2017-03-30chart: getModel (chart model) in DialogModel should be publicTomaž Vajngerl1-1/+2
Change-Id: Ia1a783ab91b944218956224268db98853f384307
2017-03-30charts: add field buttons if we have the pivot table dataTomaž Vajngerl2-27/+23
In ChartView (and VLegend) check if the data provider is a pivot chart data provider and get the pivot table field names to create the buttons on the UI. Change-Id: I08faaa17c953f0f40180e1ac1b0cb1dc6471607e
2017-03-30charts: use isDataFromSpreadsheet check in creation wizardTomaž Vajngerl1-4/+1
Change-Id: I6f4ee2639a3102f4390c6d97491244ede67abc59
2017-03-30clean-up code in chart creation wizardTomaž Vajngerl2-46/+51
Change-Id: I990dba44d4ce3d3f0538b6038133c289980fa315
2017-03-30pivotcharts: Check the data provider on pivot table updateTomaž Vajngerl1-3/+5
Change-Id: I8ae0756357c18c9fc0b0af64e8e3acb36e1a8564
2017-03-30chart model: checks if data provider is pivot table or sheetTomaž Vajngerl2-0/+16
Change-Id: I5f71004f15b72e6d0ef6bef30ee5814f31e4b1e7
2017-03-30Pivot chart specific data provider to get pivot table output dataTomaž Vajngerl4-7/+128
Change-Id: I6e1c4320316e7dcfad5b1de5d55403cfebd01a29
2017-03-30pivotcharts: collect and set the number format for the dataTomaž Vajngerl2-42/+104
Change-Id: I5eb2e9b9cb5abb798b99a23cfa16d790ff62ff08
2017-03-30pivotcharts: modify the pivot chart when the pivot table changesTomaž Vajngerl2-4/+39
Change-Id: I971e8bf90aaf2363adf3aa530b2cc8fd02abd273
2017-03-30pivotcharts: insert a pivot chart if cursor is in a pivot tableTomaž Vajngerl1-34/+54
Change-Id: I9fbde8e26cf10e68ff7a886e982b7ac1e5d7ef70
2017-03-30pivotcharts: extract and simplify pivot table data collectionTomaž Vajngerl2-103/+109
Change-Id: I49b0c4d06c3401f07ab3d2857213b12f109f0d8b
2017-03-30pivotcharts: set the correct number format for categoriesTomaž Vajngerl3-9/+35
Change-Id: I54980c3fbf37816c77fee549fe8b9728ae76ba28
2017-03-30fix warnings, clean-up and remove unused thingTomaž Vajngerl3-110/+34
Change-Id: Ia2061663fe1ee87bc37d9a20766ef0363caa21be
2017-03-30sc: Pivot chart specific data providerTomaž Vajngerl7-0/+1397
Adds a pivot chart specific data provider which uses provides the data from a pivot table to the associated chart. Change-Id: Ifbc5511645ef7ca8f6ff39095f74f76892a0d7bd
2017-03-30writerfilter: DOCX import: fix handling of w:hideMark vs. w:vMergeMichael Stahl1-1/+5
The problem is that Writer's layout can't handle the case where cells are vertically merged and the last row has a fixed height; the vertically merged cell will grow up to the height of the other cells in the non- fixed rows plus the fixed row height, but no larger. So for now, avoid setting fixed row heights in this case. (regression from d1278ef4849661b9ae0eb7aaf4d74fbf91ccaf11) Change-Id: Iac3689e0bb0d5b8a62115ca0fb1f2c553a6e6bbc
2017-03-30android: restore tabbed toolbar removed by accidentTomaž Vajngerl1-0/+19
commit 1503769fe15c122ff2bb8f6f7e7b4ab72656ddc2 removed tabbed toolbar by mistake Change-Id: I72e408d8e67b846e227d4563a8cd8455c1e73c29
2017-03-30tdf#96816 android: top part unreachable with soft keyboardXimeng Zu1-2/+2
Uncomment in Manifest file the line related to input method: android:windowSoftInputMode="adjustResize" This allows for panning and zooming to the top part of the document. Change-Id: Ic75489071add6b52948d381f4f8b7205148b78ef Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Tomaž Vajngerl <> Tested-by: Tomaž Vajngerl <>
2017-03-30Add superscript and subscript text formatting optionsbrainbreaker4-1/+60
This commit adds superscript and subscript text formatting options in formatting toolbar Change-Id: Id6966eb11b71b269431a21f46bd7c597fdcdb08c Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Tomaž Vajngerl <>
2017-03-30ofz#967 optimize tiff import if line is the same as previous lineCaolán McNamara4-24/+53
Change-Id: Ided61679a579a73481320f85c05b03e3ce3d762a
2017-03-30ofz#968 short-cut slow create mask when we are our own mask alreadyCaolán McNamara1-2/+9
Change-Id: I5969226bf2da34d34e30e44ae763792cdc072bc8 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2017-03-30tweak indent a littleCaolán McNamara1-119/+116
Change-Id: Icc3c69887a15eb0eacfa9209630a57f602c44422 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2017-03-30tdf#106325 - No way to create a new Documentbrainbreaker17-68/+586
This commit will add the ability to create a new document. A FAB is used in home screen which on expansion gives four options namely new writer document, new impress, new Sheet or new Draw. Two new events loadNewDocument and saveDocumentAs have been added. Another major change includes the use of constraint layout in LOUIActivity layout as it decreases nesting of views and improves the app performance. This was needed because of the new FAB layouts being added. Support for vector drawables has been enabled. Change-Id: Ia3ea17f73c0d8514f8ddb7b9a1cbd2ce7de6ac08 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Tomaž Vajngerl <>
2017-03-30Updated coreOlivier Hallot1-0/+0
Project: help e8045f04d057ea3e50726f99c442557e6e3986bc Fix list of View commands in Writer menu help Reorder and update View menu description for Writer Change-Id: Ib7af048b603977dabbdb53069935a5158e3a6bbe Reviewed-on: Reviewed-by: Olivier Hallot <> Tested-by: Olivier Hallot <>
2017-03-30Updated coreOlivier Hallot1-0/+0
Project: help 8291b5b5f748af4eeb68797193e9c84d11ecbda5 tdf#106861 - fix Autoinput entry in menu, plus - Reorder Calc tools menu help page - Remove ref to "Cell contents" - Move Recalculate to Data menu Change-Id: Id6165db40a99316eae9768955b6cdbb9d5f05afb Reviewed-on: Reviewed-by: Olivier Hallot <> Tested-by: Olivier Hallot <>
2017-03-30vcl PDF export, norefxobj: add test for thisMiklos Vajna2-0/+56
Assert two important properties: - the pdf image is described using the form xobject markup (not the reference xobject one) - the form xobject refers to a vector image, not to a bitmap one Change-Id: I94b88976c1e5392758d56254143fbeeeeba51412 Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Jenkins <>
2017-03-30NeonSession_NeonAuth(): avoid redundant OUString->OString conversionVitaliy Anderson1-9/+5
Change-Id: I6b8515c25d58a88a040d4e08e36ffbd442228828 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Mike Kaganski <>
2017-03-30tdf#105975 Add Formula field parsing (docx) in SWriterJean-Sebastien Bevilacqua4-2/+49
Introduction ------------ In MSWord, you can create a formula field (starting with =). When you save your file as `docx`, this `FORMULA` field is registered in you file (a field starting with `=`). In its current state, LibreOffice can't parse the `FORMULA` field in `docx` file. Context of this fix ------------------- This fix is entirely located in the `DomainMapper_Impl.cxx` file because it's where the parsing is done. How this fix works ------------------ First, we add `FORMULA` support by adding it to the `aFields[]` variable. Next, to handle the `FORMULA` constant, we add a condition (swith case) in `DomainMapper_Impl::CloseFieldCommand()` to call `handleFieldFormula`. Note ---- In function `lcl_ExtractToken`, if command starts with `=`, it's a `FORMULA` field. Change-Id: If7d25de5413aa3133b22523d8a3f34ab6961adfc Reviewed-on: Reviewed-by: Michael Stahl <> Tested-by: Jenkins <>
2017-03-30Access2Base Missing parentheses - tdf#106710Jean-Pierre Ledure4-6/+6
Due to more severe Basic interpreter on final parentheses missing parentheses were revealed Cherry picking was not sufficient as they were remaining cases in new LO5.4 code Change-Id: I6a883ceed22ae20bb61cba8e3966c2dc680bdd0c
2017-03-30ofz#969 endless loop in ppt loadingCaolán McNamara1-2/+2
Change-Id: If68bf21cd135c64957cc6def654230daa5240698
2017-03-30convert GradientType to scoped enumNoel Grandin4-13/+13
Change-Id: Ie71ead122965e967796ed01270cc2824d35905ac Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2017-03-30remove type decorations on char literalsJochen Nitschke65-170/+170
they are only needed where type deduction fails. left them in defines for now. Change-Id: I7f002dd6bc7acc083c73b6c64076de6dd28d0b09 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Stephan Bergmann <>
2017-03-30tdf#98416 libcmis: Google Drive 2FA fixSzymon Kłos2-0/+126
Change-Id: Ice6758d8e9bc0ece57e038561376e7a6d67ab616 Reviewed-on: Reviewed-by: David Tardon <> Tested-by: David Tardon <>
2017-03-30Updated coreMiklos Vajna1-0/+0
Project: help f2c45a2b93c88cf7fa1feba2197e8745f56de98a vcl PDF export, norefxobj: add help text for this Change-Id: I7d19333e0f025e2d9c8d894f082971feb7492c63
2017-03-30starmath: Hold error nodes as subnodes of SmBracebodyNodeTakeshi Abe1-21/+7
so that the resulting tree aligns them in a straightforward way. Change-Id: Ica86be557c5d462425f5e88930dbdec29947e5d7 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Takeshi Abe <>
2017-03-30use SFX_INTERFACE_NONE constantNoel Grandin4-7/+7
inside of constructing SfxInterface(0) by hand Change-Id: Ic2cbe39366a36b40b672242a250f68135d4e2cd3 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2017-03-30editeng: tweak commentMichael Stahl1-1/+1
Change-Id: I587fafea157a02d2c903dda4b85448b1fe349c3e