AgeCommit message (Collapse)AuthorFilesLines
2017-12-04lokdialog: Window* -> VclPtr<Window>, and a small simplification.feature/lok_dialog-backportJan Holesovsky4-16/+13
Change-Id: I853e2d6ec2e55c78894a9942aa201763a57fe195
2017-12-04lokdialog: Make the Autofilter popup work in Calc.Jan Holesovsky1-2/+12
For the moment we treat it as a 'dialog', but maybe we'll need a separate window type for this later. Change-Id: I21bff0b50b5f3e9f51d323600f7ba6d37c16bc9b
2017-12-04lokdialog: sc: Guard autofilter popup's LOK notificationPranav Kant1-1/+2
Change-Id: I8d39a701618926e35c84f200ac7e2ce66e62b8b7
2017-12-04lokdialog: multiview: Do not mix one view with otherPranav Kant7-30/+22
In GTV, use correct application window object to fetch the dialog object. Use correct view shell to notify window (dialogs, etc.) callbacks. Change-Id: I7d82b39d4522a4b4904e156757a032c342c71efb
2017-12-04lokdialog: Merge dialog & dialog child mouse event APIs into onePranav Kant6-136/+54
Change-Id: I91aaa6a58f33dd2d817e02533de96e0c8191f2ca
2017-12-04lokdialog: Rename postDialogKeyEvent -> postWindowKeyEventPranav Kant4-8/+8
Change-Id: I78b434106fbef153adde255d4fcc8f74a7169175
2017-12-04lokdialog: Simplify; make the LOK dialog API more genericPranav Kant25-396/+229
Merge the dialog floating window callbacks and function calls into one. Unique window ids across vcl::Window is enough to distinguish between them. Floating windows don't have a LOK notifier as they are created in the vcl itself (so we can't access them from sfx2). Use the parent LOK notifier in that case (which would be a dialog). This API should also help in autopopup filter tunneling later. Change-Id: I63a2c97ffdd84695dc967e14c793089a7c50b41b
2017-12-04lokdialog: Do not underestimate the dialog sizePranav Kant1-2/+2
Some of them like, EditStyle, can be much bigger. Change-Id: Iaad02fadba18846976b959369f06e2020feffc6f
2017-12-04lokdialog: Kill some code; use already existing method to paintPranav Kant5-25/+1
This is not require now in the new approach where the dialog is already created by the time paint request call for dialog happens. Layouting is already complete by that time. Change-Id: I610b050a268e61e8d4036aa7eb5766cf0c8b37e0
2017-12-04lokdialog: Allow closing a dialog from LOK clientPranav Kant6-12/+56
... and rename paintDialog -> paintWindow before it's too late. We not only render dialogs now but also popups. Change-Id: I6b1253c4d9be0c79199b683df4413658a461f850
2017-12-04gtv: Remember recently executed UNO commandsPranav Kant8-31/+170
Saves the recently executed UNO commands in a temp file and make it accessible to user in a combo box. Useful when debugging. Change-Id: Ic66961a388cc59dee3f65cb8d4de3c29a8a75eaa
2017-12-04gtv: Width, height properties should not be construct onlyPranav Kant1-2/+0
Change-Id: I2d1b29f52c1fe0449cf9afe47c509ef6250804a8
2017-12-04fix buildAron Budea1-2/+2
Change-Id: I08c84dbe0d068bf9dc4204476098319b3fedcfb1 Reviewed-on: Reviewed-by: Aron Budea <> Tested-by: Aron Budea <>
2017-12-04tdf#109240, tdf#112571: add unit testAron Budea2-0/+28
Follow-up to bba57a7eb9dd118df5772068b3a70aedb3602003 (cherry picked from commit f8b9d0fb0767d8bbe8477f92abaf6b8e0ff65546) Change-Id: Ib61fa81e34440681f0e3eb88a10de45062bc981f Reviewed-on: Reviewed-by: Aron Budea <> Tested-by: Aron Budea <>
2017-12-02Revert "tdf#114025 - avoid deadlock between x11 clipboard and ...Michael Stahl1-9/+6
... the lock dialog." SolarMutexReleaser hack can be avoided with the rtl_Instance fix from commit fa9c083c6071a0a4dc812f3c34731f347ddbabf7. This reverts commit b0e37303df56472fdc7782b977326c2391fdab07. Change-Id: Ib90cdec1420807afbadfd526a1ddb68d58db79c1 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Michael Stahl <> Signed-off-by: Michael Meeks <>
2017-12-01tdf#114025 framework: avoid deadlock between Desktop init ...Michael Stahl1-5/+25
... and SolarMutex: the problem is that rtl::StaticWithArg will first lock the implicit mutex of the C++11 static variable, and then the SolarMutex. So if one thread creates the Desktop singleton with SolarMutex locked and another thread without SolarMutex locked, this can deadlock. If we use rtl_Instance directly with SolarMutex, then there is still a static variable, but the SolarMutex will always be locked first, preventing this deadlock. Change-Id: Ibd37fdfa96a4a2b57f661be3814dd597eb52d338 Reviewed-on: Reviewed-by: Michael Meeks <> Tested-by: Jenkins <> (cherry picked from commit fa9c083c6071a0a4dc812f3c34731f347ddbabf7) Reviewed-on: Reviewed-by: Andras Timar <> Tested-by: Andras Timar <>
2017-12-01tdf#107806: Semantic and syntax for .uno:RowHeight have been changedHenry Castro6-32/+72
Change-Id: If9ce7ff36ef3ba8e55103765f3260e74ab2eebd4 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Henry Castro <> Reviewed-on: Reviewed-by: Jan Holesovsky <> Tested-by: Jan Holesovsky <>
2017-12-01lok: calc: small fixesMarco Cecchetti2-3/+3
For aligning with master Change-Id: I74cada5f50e88fc7c6ea0dfe78fdfab0d60a9af5 Reviewed-on: Reviewed-by: Marco Cecchetti <> Tested-by: Marco Cecchetti <>
2017-11-30lokdialog: Compress DIALOG_CHILD callbacksPranav Kant1-0/+1
In complex dialogs, they flood the lok client otherwise with duplicate callbacks. Change-Id: I6ab1ef12b90caed22dfc464e18068f5830cb9532 Reviewed-on: Reviewed-by: Jan Holesovsky <> Tested-by: Jan Holesovsky <>
2017-11-30etags: pass the "-e" flag directly to ctag binaryPranav Kant1-5/+1
'man ctags' says that emacs mode will be enabled if the ctags binary is renamed as etags or '-e' flag is provided to ctags binary. Before this patch, the script assumes that host system has an 'etags' binary renamed from 'ctags' program. This is not always the case in all hosts. Eg: In Fedora, 'etags' binary is provided by emacs-common package which doesn't understand the flags given later in the script. It is safe to just explicitly enable the emacs mode via '-e' flag to the ctags binary. Change-Id: Ic7ded56cff32683fc5e9d3fcc7405e79da4c23b7 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: pranavk <> (cherry picked from commit 3ece8264b4c0b41f480e77980b987db4540e49e7) Reviewed-on: Reviewed-by: Jan Holesovsky <> Tested-by: Jan Holesovsky <>
2017-11-30sc, sd: rework UI Text Language "More" button, tdf#113911Henry Castro2-27/+63
Calc and Impress handle different uno command to set language Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Henry Castro <> Change-Id: Ic0ffef6a8fee5078b29873934001819a384c8f3a f9e26dfd6702f167c831296f0280ae5fe955a8a9 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Maxim Monastirsky <> Reviewed-on: Reviewed-by: Jan Holesovsky <> Tested-by: Jan Holesovsky <>
2017-11-30lok: calc: set outline stateMarco Cecchetti6-45/+61
use a specific message from the client for set the visibility state of a group instead of hijacking the update row/column header message Change-Id: I9634c24bbffaddc916c8ad716ac6d5d31e735a55 Reviewed-on: Reviewed-by: Jan Holesovsky <> Tested-by: Jan Holesovsky <>
2017-11-30LOK: provide user feedback while preloading.Michael Meeks2-4/+47
Problems are hard enough to debug in a jailed kit process inside a docker image; provide some visual feedback via stderr. Change-Id: I54b0a21c1375be2acc9da0bbacf959a419471b08 Reviewed-on: Reviewed-by: Jan Holesovsky <> Tested-by: Jan Holesovsky <>
2017-11-30sd: enable language status bar itemHenry Castro5-36/+40
Change-Id: I7cb725cdcfc92366694fc8cb24c1443dd74d102e Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Henry Castro <> Reviewed-on: Reviewed-by: Jan Holesovsky <> Tested-by: Jan Holesovsky <>
2017-11-30lokdialog: Execute all UNO commands asynchronously for LOKPranav Kant2-0/+8
Especially in case of dialogs, Online cannot afford to wait till the call to UNO command returns as the same thread is responsible for doing many more tasks as well. And just adding this check doesn't seem to have any repurcussions, so I guess we are fine. Change-Id: Iac7c1413d90e8a264502dcf2bc280e09fd52683b Reviewed-on: Reviewed-by: Jan Holesovsky <> Tested-by: Jan Holesovsky <>
2017-11-30LOK: support password-protected PDF docsAshod Nakashian1-2/+10
Change-Id: I1a1177ae7eb5af4ade2863dedf8bab7188152c5e Reviewed-on: Reviewed-by: Ashod Nakashian <> Tested-by: Ashod Nakashian <> (cherry picked from commit dc773e81bd360316a96b1b61c552d263e1d87e89) Reviewed-on: Reviewed-by: Jan Holesovsky <> Tested-by: Jan Holesovsky <>
2017-11-29disambiguation (build fix on Windows)Andras Timar1-1/+1
Change-Id: Icd42b11564b715754b125af6cbcd1d1a359eb5bd Reviewed-on: Reviewed-by: Andras Timar <> Tested-by: Andras Timar <>
2017-11-29Use UTF-8 sequences (VS2013 doesn't accept u8)Mike Kaganski2-2/+2
Change-Id: I8c969646cff1c69107a5a6cfbfdc0e59c88b6641 Reviewed-on: Reviewed-by: Andras Timar <> Tested-by: Andras Timar <>
2017-11-29lokdialog: Make hyperlink dialog workPranav Kant3-1/+23
(cherry picked from commit 29f23a47f02b05ddd9a3a626a6cf8bfa7083d1bc) (cherry picked from commit 9ad0c1815e137c55f2d356c46630e67570262196) Change-Id: Ifd8c721b001b09ddab8d4fe06ae6818980d6ee76
2017-11-29Tile the writer surround rendering to avoid large image scaling.Michael Meeks1-12/+27
This also fixes a potentially large memory leak depending on zoom, and particularly with non-paginated rendering. Change-Id: Ia24e0b7baea725020f000a369708b0be3fc20c95 Reviewed-on: Reviewed-by: Ashod Nakashian <> Tested-by: Ashod Nakashian <> (cherry picked from commit badd7363df0cdd95ddd9ab7f2008edd54dc0cbc9) Reviewed-on:
2017-11-28Bump version to 5.3-32cp-5.3-32Andras Timar1-1/+1
Change-Id: Ia81627cb441158edd1e24d4cfb4b9c3f95853ec6
2017-11-28tdf#109240, tdf#112571: don't export dupe built-in named rangesAron Budea2-3/+7
XclTools::GetBuiltInDefNameIndex(...) only checked for prefix used in binary Excel format, and didn't recognize OOXML built-in names, which resulted in saving them twice in OOXML files. Adapt to check both binary and OOXML prefixes, similarly to XclTools::IsBuiltInStyleName(...). Saving "bad" files after the fix will purge bad "_0", "_0_0" etc. suffixed built-in names due to how GetBuiltInDefNameIndex(...) works. Change-Id: I1bbe11f9c654a142a4626003df4cb0fd2a0f9c71
2017-11-28sd lok: ensure default viewHenry Castro4-12/+39
In Tiled rendering case, the only default view is supported Change-Id: Ia6df85dba28f8ebb41bdc20ae48916b0437ea185 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Henry Castro <> Reviewed-on: Reviewed-by: Jan Holesovsky <> Tested-by: Jan Holesovsky <>
2017-11-28sw lok: add Accept/Reject All tracked changes, tdf#101977Henry Castro15-2/+246
Change-Id: I04d747343e24cb498a621c965d034d0791411d83 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Henry Castro <> Reviewed-on: Reviewed-by: Jan Holesovsky <> Tested-by: Jan Holesovsky <>
2017-11-28lok - calc: outline and group handlingMarco Cecchetti16-37/+408
Change-Id: Ibb287468653bc381acf034dcb8531c5faf61aef3 Reviewed-on: Reviewed-by: Jan Holesovsky <> Tested-by: Jan Holesovsky <>
2017-11-28lok: sc: subdivide headers data in rangeMarco Cecchetti1-1/+10
Change-Id: I984b5da5774f97172de7659ecab84675060f8301 Reviewed-on: Reviewed-by: Jan Holesovsky <> Tested-by: Jan Holesovsky <>
2017-11-28LOK: tilebench improvementsAshod Nakashian4-36/+74
* Arguments for max number of parts and tiles to render (optional). + Automatic estimation of maximum tiles to render based on max parts for Writer docs, since there is only 1 part, this caps the number of pages to render, similar to other doc types. * Fixed rendering of Writer documents over and over (as many times as pages). + Writer has a single part, unlike other doc types. + No point in rendering the whole document in writer to a single tile, since that's completely unrealistic and impractical (it takes forever for large docs and artificially spikes the memory). * Rendering starts at the current part and not the first. + This gives the spreadsheet of interest priority (if saved as visible). * The tile size is now more realistic as we use the same dimensions as the Online client does. * When rendering tiles at scale, we use the same dimensions as the Online client rather than splitting the width by 4, for realism. * Rendering of tiles is done rows-first, rather than columns-first, which is similar to what the Online client does, which is more cache friendly, therefore more realistic. * Enabled compiling of tilebench when GTK3 is disabled, which was erroneous, since tilebench doesn't have any dependency on GTK. + Now it's possible to compile with local Cairo/Pixman libs. Change-Id: Ib78d030ead387748914119f95fe49ddc1ce64498 Reviewed-on: Reviewed-by: Jan Holesovsky <> Tested-by: Jan Holesovsky <>
2017-11-28Fix 'unused parameter' warnings.Jan Holesovsky1-5/+5
Change-Id: I8478e907a66ca918eddc7a543cbcf23e17d9ee5a
2017-11-28lokdialog: Remove getDialogInfo + update gtktiledviewer accordingly.Pranav Kant5-67/+28
Change-Id: I6f810c97f2fadd3b1ea602a97e24c8b42f4a84b9
2017-11-28lokdialog: Notify the current view onlyPranav Kant1-10/+4
Change-Id: I55e0dbf1677a24905d337c58184a4419c1020a87
2017-11-28lokdialog: new callback size_changed with new size of the dialogPranav Kant1-2/+5
Change-Id: Ibb864cb588ae7db92381c5578701d3ce09185f34
2017-11-28lokdialog: Emit callback when title is changedPranav Kant1-0/+10
The plan is to remove the getDialogInfo from LOK API but one more step before doing that is to find out why the dialog size in 'created' dialog callback is less than what the actual dialog after painting is. Change-Id: I5176e175cbf7ed81c1465feeeea053c9a024fbd9
2017-11-28lokdialog: Launch dialogs which have a notifier registeredPranav Kant1-1/+1
Change-Id: I062fa291668b7dbfb8bc8e8d455a7933378ce7d9
2017-11-28lokdialog: Move the LOKWindowId <-> VclPtr<Window> mapping to Window.Jan Holesovsky15-95/+43
This allows registering & de-registering of non-sfx windows too, and makes the Calc autofilter popup to appear. Change-Id: I7cbbe94d208115aabcb6fa5f964646c7b7ce4c93
2017-11-28lokdialog: Move the LogicInvalidate from Dialog down to Window.Jan Holesovsky4-16/+17
Another step towards the autofilter popup working... Change-Id: I4907a23fcd0fc64da0c7f51e2f36b1657a17638c
2017-11-28lokdialog: Move the painting down to Window, and enable Calc and Impress.Jan Holesovsky22-366/+309
Tested with .uno:FormatCellDialog in Calc, Impress not tested. Change-Id: I6d911c29616988db0625be9e2a63cf2172c69ee8
2017-11-28lokdialogs: Assign the LOK window id only when necessary.Jan Holesovsky3-4/+13
Change-Id: Id48957a8c2bde068f30bb26e66df81972fe38e0f
2017-11-28lokdialog: Make the Autofilter popup notify about its creation.Jan Holesovsky2-0/+8
Change-Id: Ib4062fa887b44eb1368205a414f4ac162f648c5c
2017-11-28lokdialog: Move the Notifier down to vcl::Window.Jan Holesovsky16-109/+122
We need to tunnel more than just dialogs, so this is the 1st step to get the Autofilter popup rendered. Change-Id: I6523a39ddc7a6eb2a204e48ab364130a5822f548
2017-11-28lokdialog: Let all modal dialogs notify about creation, disposalPranav Kant2-0/+26
Change-Id: I8ec0ad81abcf1adf628906b02f7f94ab74a550b5