summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2018-01-22Support opening of (some) remote URLs through the KDE file dialogfeature/gtk3_kde5Milian Wolff3-44/+31
LO already supports http, https, webdav and webdavs through the WebDAVContentProvider. Ftp is supported via FTPContentProvider and then finally we have the GIOContentProvider that can potentially support SMB, if the dependencies for that are met. We now configure the KDE file dialog to allow these remote protocols. Note that this filtering depends on https://phabricator.kde.org/D10024 and https://phabricator.kde.org/D10025 to have any effect. Then we rewrite the URLs we receive from KIO to a format that is supported by LO. Most notably, we prepend `vnd.sun.star.` to the webdav URL schemes, such that they get picked up by the WebDAVContentProvider. Then finally, we clear the username from the smb:// URLs we get from KIO, as that prevents GIO from opening them. In all cases, the user will get prompted a second time for the credentials required to access the remote resource. This is unfortunate, but better than nothing. In the future, we may solve this issue through either a separate KIO UCP or by getting support for the FDO Secret Service specification in KWallet. Change-Id: I91df28434b115639c2698968e2a672b3320bf8e2
2018-01-22check for boost/process/child.hpp in configure.ac if --enable-gtk3-kde5Rene Engelhard1-0/+4
Change-Id: Idcd2931415558b41f94eb12a01f350f1ab53d134
2018-01-22Introduce gtk3_kde5 vcl pluginMilian Wolff54-5/+2821
This is a hybrid plugin which mostly wraps the GTK3 vclplug. Only the file and folder picker are replaced by KDE dialogs. This gives us a well-maintained GTK LO base with basic KDE integration with minimum effort. To prevent issues with nested event loops, the KDE dialogs are launched from a separate process, the new lo_kde5filepicker helper executable. A trivial stdin/stdout IPC mechanism transfers the data between LO and the Qt/KDE helper. The usage of an external process also allows us to copy'n'paste between LO and the KDE file dialog without freezing the UI, as would happen when one would do this in-process. This is in general also the architecture applied by the kmozillahelper, which is used to integrate KDE file dialogs into Firefox. While the KDE dialog is shown, the GTK3 main window is disabled and close requests are ignored. The KDE dialog in turn also sets the LO window as transient parent. Together, this makes the illusion perfect and the KDE dialog behaves like a modal dialog. This works properly also with multiple LO main windows, and only individual windows will get blocked as one would expect. Functionality wise, most of the features of the KDE4 dialog are supported. You can pick files and folders, and save files under a new name. Some custom checkbox widgets are supported, but lists, buttons and preview widgets are not yet implemented. Also, loading remote files via KIO is not possible yet. Change-Id: I1a97cf7c272307a19ace4222d5f12253bc722829
2018-01-22Add KDE5 desktop backendMilian Wolff9-0/+687
This is mostly a copy of the KDE4 backend ported to Qt5/KF5. One difference is that this code will initialize the QApplication on-demand, when it's not yet available. This will allow us to use this desktop backend also within a vclplug that does not use Qt itself, such as the upcoming Gtk3/KDE5 hybrid. Change-Id: I5cf96ac5729608c82a58eead6723a38f014ba875
2018-01-22Band aid fix build --with-kde5Katarina Behrens4-10/+12
Change-Id: Ifbcfdbb74bffaf88296351ec72536e16a4073b60
2018-01-22Extend build system to support linking against KDE Frameworks 5Milian Wolff9-5/+78
Pass --enable-kde5 to autogen.sh to enable this feature. Then add kde5 to the list of externals to link against KF5. I will introduce other code that depends on KF5 though which will leverage this feature. Change-Id: I17e434a53ac769000b0f805b1f41cdc5c2c84ee2
2018-01-22Actually remove the now-unnecessary, bad downcastStephan Bergmann1-1/+1
...after 8aa37ca1b94a340c0ca3dc4edebdc501edc25cf5 "ubsan SwTableBoxFormat is really SwTableLineFormat" Change-Id: I24d092a6cb4d3642e22045acde7eeffaf908075e
2018-01-22sc: std::iterator is deprecated in C++17Michael Stahl1-7/+8
Change-Id: I947dcf61e95bdc68d19eab7daca4c31ba8047d5e Reviewed-on: https://gerrit.libreoffice.org/48224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-22update flatpak-manifestDavid Tardon1-3/+3
Change-Id: If97c2f8826cbbd83821d9211040f1857e1a1e17f
2018-01-22Presumably misplaced castStephan Bergmann1-1/+1
...that was originally introduced as int intRadius = (int) radius + 1.0; in 05363527d84119c6759cdd638c76b041f2aa67b7 "Separable Gaussian Blur and Unsharpen Mask filter", and presumably was meant to cover the whole right-hand- side addition, not just "radius". Change-Id: I3c14f4055e74e3e4dcccbddce060a86f9bcc23f0 Reviewed-on: https://gerrit.libreoffice.org/48005 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-01-22tdf#109062 restore osx scrollwheel logicCaolán McNamara1-9/+12
to pre commit f7d2bf216afa10268e6a7c1d4613a2fd8f7c7f3c Date: Tue May 16 10:12:09 2017 +0100 Resolves: tdf#103174 & rhbz#1367846 improve gtk3 trackpad scrolling state. Change-Id: If5a494441731e73136158b4905c2744ba8bc8875 Reviewed-on: https://gerrit.libreoffice.org/48249 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-22iOS, performance updatejan Iversen2-8/+2
Set SAL_LOG to empty in SIMULATOR scheme, allowing to easy add +WARN+INFO when testing. Removed duplicate entry in Info.plist Change-Id: I7d0231b0c30fd710e578f91b450c3c16696deb08
2018-01-22tdf#100370 Selection icon now working properly on mouse clickKshitij Pathania1-1/+1
Change-Id: I45786ab3eb0b93d2f987d83156011b768869a414 Reviewed-on: https://gerrit.libreoffice.org/48279 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-01-22chart2: std::iterator is deprecated in C++17Michael Stahl1-4/+23
And it's immediately obvious why, if you look at the elegant and concise replacement code that doesn't trigger deprecation warnings. Change-Id: Ie4b3ca83951a89f7ac4d172086c23c7457087ba3 Reviewed-on: https://gerrit.libreoffice.org/48223 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-22vcl: various std::*::result_type deprecated in C++17Michael Stahl1-2/+2
Use decltype instead, to prevent MSVC 2017.5 warnings. Change-Id: I760659837e34eb2dc2a3293c43e7f29725b515d6 Reviewed-on: https://gerrit.libreoffice.org/48221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-22C++17 deprecated std::shared_ptr::unique()Michael Stahl11-16/+21
Most of these calls are in assertions, and the ones that aren't should be guarded by SolarMutex, so the thread safety concerns that caused unique() to be deprecated don't look relevant, so use use_count(), which oddly enough isn't deprecated. Change-Id: Ia166615af6c3ce85145c391752669c7461bd35fb Reviewed-on: https://gerrit.libreoffice.org/48222 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-22boost: upgrade to release 1.66.0Michael Stahl8-100/+13
This claims to support Visual Studio 2017.4, but not the current 2017.5. * remove boost.auto_link.patch; it does not apply; not sure why we need this if we can just define BOOST_ALL_NO_LIB (see commit 7f2e168421c3cd928a31a52a8b5afe97e931d3ba) * remove some hunks from clang-cl.patch.0 that look fixed upstream * add a global workaround for spurious GCC warning: oox/source/drawingml/shape.cxx:921:54: error: ‘oShadowColor.boost::optional_detail::tc_optional_base<int>::m_storage’ may be used uninitialized in this function [-Werror=maybe-uninitialized] aFormat.Color = *oShadowColor; Change-Id: I1eb1d8b66554a84a7d7269f1faaa98695fe2f501 Reviewed-on: https://gerrit.libreoffice.org/48187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-22tdf#115105 Fix Styles and Macros nodes don't expand in Customize dialogJim Raykowski1-0/+1
by initializing bSubLstOpDblClick true. Change-Id: I1e3419014cd0c0bf9d4363d0fc365124413d5508 Reviewed-on: https://gerrit.libreoffice.org/48227 Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr> Tested-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-01-22tdf#38915: set cProcessed condition on any process outcomeMike Kaganski4-7/+85
When application is initializing, initially request handler is not processing requests (its state is Starting). Requests processing is enabled in Desktop::OpenClients() after recovery had been processed. If another soffice process is started, it communicates over already established pipe, and sends a request to the first process. In IpcThread::process(), it is decided if the request needs to be checked for completion (e.g., if a file or specific module was requested to be open). After that, the prepared request is posted for processing. In case when the completion should be checked, PipeIpcThread::execute() then waits for Processed condition indefinitely. Request is processed in RequestHandler::ExecuteCmdLineRequests, which first checks that handler's state is RequestsEnabled, and if it isn't, then returns. Otherwise, after processing, Processed condition is set. The problem is, thus, in case when the request comes before requests processing is enabled (e.g., when recovery dialog is open): request handler thread waits indefinitely, but the processed condition will not be set. This will not allow to close the pipe to second process, and it will hang indefinitely. The IPC thread will be hung even after user closes recovery dialog, and continues working with program. So, subsequent attempts to open files from file manager (launching new process) will fail, and new zombie soffice processes will wait the first indefinitely. Also, when first process will be closed by user, the deinit sequence will attempt to wait for the IPC thread to finish (in RequestHandler::Disable(), after all visible windows had been closed), which will leave the first process hung, preventing all subsequent attempts to open LibreOffice. This patch ensures that the Processed condition is set at any outcome in RequestHandler::ExecuteCmdLineRequests. Also, it brings (possibly hidden) recovery dialog to front, making the reason why following attempts to open files fail apparent to user. Change-Id: Ibddf7483e5b1d6167ac7f307ea2442119f446129 Reviewed-on: https://gerrit.libreoffice.org/48280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Aron Budea <aron.budea@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-01-22improve RTL detection in TextEngineNoel Grandin3-10/+10
the ubidi_getLogicalRun call returns a direction bool in bit 0, so the old code would only have been correct for embedding level 0. found by an up and coming loplugin. Change-Id: I56658981fbd32caf0d961d47d76b668f1dd1b680 Reviewed-on: https://gerrit.libreoffice.org/48261 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-22remove some sal_Bool remnantsNoel Grandin9-35/+33
Change-Id: I0a9637aca523a73fbdbbd22f9ad735d6d1ba6898 Reviewed-on: https://gerrit.libreoffice.org/48273 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-22tdf#75256 Sifr update exportto numberformatthousands splitcellsMatthias Freund22-0/+0
Change-Id: Idb2b8e1234528cffcc54fd5a2e354ce3cb30a030 Reviewed-on: https://gerrit.libreoffice.org/48283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Matthias Freund <matti_lx@secure.mailbox.org>
2018-01-22tdf#115002 Including of bitness information into Java message on Windowstagezi2-1/+10
Change-Id: Id5235360110cf9838a38f8063448b06a5de1f82c Reviewed-on: https://gerrit.libreoffice.org/48272 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-01-22starmath: Make SmParser::Parse() return std::unique_ptrTakeshi Abe11-52/+39
Change-Id: I6c8811f71ab40398043cdcfa3334eee4381b4c7e Reviewed-on: https://gerrit.libreoffice.org/48098 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2018-01-22ofz#5526 restrict mml parsing depthCaolán McNamara2-4/+25
Change-Id: Ib74787137112fb8402a2f6400ab4313d43c103dc Reviewed-on: https://gerrit.libreoffice.org/48277 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-22ofz#5535 max decimal places for rtl_math_round is 20Caolán McNamara2-2/+5
Change-Id: I636e086c51ceb70bdac72acfbabe99ad29003cdb Reviewed-on: https://gerrit.libreoffice.org/48268 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-22copy ScAddress before possibly joining itCaolán McNamara2-1/+3
Change-Id: Ib1148584b9771da67d3f4b3141184228e1bbe3a2 Reviewed-on: https://gerrit.libreoffice.org/48271 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-22ubsan SwTableBoxFormat is really SwTableLineFormatCaolán McNamara1-5/+5
/sw/source/core/doc/tblrwcl.cxx:1937:29: runtime error: downcast of address 0x2b328cff7da8 which does not point to an object of type ´SwTableBoxFormat´ 0x2b328cff7da8: note: object is of type ´SwTableLineFormat´ 00 00 00 00 f0 ea dd 46 32 2b 00 00 b8 80 ff 8c 32 2b 00 00 e8 43 f5 00 90 61 00 00 58 79 65 80 ^~~~~~~~~~~~~~~~~~~~~~~ vptr for ´SwTableLineFormat´ #0 0x2b323c386daf in lcl_CopyLineToDoc(FndLine_ const&, CpyPara*) /sw/source/core/doc/tblrwcl.cxx:1937:29 Change-Id: I16f7b61a3561de3e599818aba538c72c631511ca Reviewed-on: https://gerrit.libreoffice.org/48282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-21tdf#113946 add 'topMargin' to GraphicHelpers importPatrick Jaap3-42/+51
The case '...topMargin' was not caught for setting a relative vertical position in GraphicHelpers. The test file demands a '7' here, which stands for 'PAGE_FRAME'. The '7' was overwritten in GraphicImport in case 'LN_CT_Anchor_positionV' by a call of 'resolve'. For a better overview a switch is inserted here. Change-Id: Ie98209fe445ecbba15c3dafe5980ca52421126f8 Reviewed-on: https://gerrit.libreoffice.org/47905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-21Fix typosAndrea Gelmini2-6/+6
Change-Id: Id3e707e89bd0fda4d86e02a185a16336c89e7c82 Reviewed-on: https://gerrit.libreoffice.org/48281 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-21uitest: add checked to radio button propertiesMarkus Mohrhard1-0/+1
Change-Id: I7e5a3f4b743029fc1a8ee01d9a4ab6ea49f9b73c Reviewed-on: https://gerrit.libreoffice.org/48274 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-01-21ofz#5508 Out of memoryCaolán McNamara1-7/+26
Change-Id: If46b4f98849d75164956e68c181b1c501a72fae0 Reviewed-on: https://gerrit.libreoffice.org/48266 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-21rework to remove intermediate streamCaolán McNamara3-30/+15
Change-Id: I6ff66cf6ea6ac38f7c36da7668b612b2062e4852 Reviewed-on: https://gerrit.libreoffice.org/48257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-21just return a vectorCaolán McNamara3-30/+13
Change-Id: Id6a75dee04c836ca28299dc6b3ab0b93361684c4 Reviewed-on: https://gerrit.libreoffice.org/48256 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-21just return SvMemoryStream*Caolán McNamara3-18/+9
Change-Id: I5c577984055e01f49c4e04685dc4df6672c8fc87 Reviewed-on: https://gerrit.libreoffice.org/48255 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-21use correct typesCaolán McNamara1-7/+7
Change-Id: I350f826f88bda85d3ea861ce7b05680900b850cf Reviewed-on: https://gerrit.libreoffice.org/48254 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-21ofz#5539 stricter on strings in dxfCaolán McNamara1-1/+4
Change-Id: I06823d9d767ffe11061531ec905f62ed3a5d302e Reviewed-on: https://gerrit.libreoffice.org/48267 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-21align typesCaolán McNamara7-39/+34
Change-Id: I6080d92ec26f9ee9bf3eb4319a36c10ae38caca2 Reviewed-on: https://gerrit.libreoffice.org/48253 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-21tdf#113572: removed redundant calc serviceVasily Melenchuk3-15/+11
calc service introduced previously in commit 0074951704022d173a5fdb9df933f47be1dcbb91 is not required, interface is enough for feature implementation. Change-Id: I9cf30f2201619465da9061c7ef1e574209062cf9 Reviewed-on: https://gerrit.libreoffice.org/47960 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-21deb#887593 apparmor: allow reading device informationVincas Dargis2-0/+2
* Add file read rule for paths like /sys/devices/virtual/block/dm-0/queue/rotational used by isRotational() in desktop/unx/source/pagenin.c. * Add file read rule for paths like /sys/dev/char/226:128/device/uevent used by libdrm. Change-Id: Ic41365b478c817b6766e25adadd6761fa03ff055 Reviewed-on: https://gerrit.libreoffice.org/48265 Tested-by: Rene Engelhard <rene@debian.org> Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-21tdf#75256 Sifr some new 32px iconsMatthias Freund28-0/+0
Change-Id: I6b0ea66424f36982b6c8eae8b9e405aaf30ca5d6 Reviewed-on: https://gerrit.libreoffice.org/48259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Matthias Freund <matti_lx@secure.mailbox.org>
2018-01-21more ScopedVclPtr for dialogsNoel Grandin3-8/+11
Change-Id: I0f19a0c1e312843bee0ee5c9939831918ddc2da7 Reviewed-on: https://gerrit.libreoffice.org/48198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-21remove accidentially committed flags=(complain)Rene Engelhard2-2/+2
Change-Id: Ia7116f77298b87d87221c80896b11a293d33f726
2018-01-21apparmor: allow running the "certificate manager" applications for gpgRene Engelhard1-0/+4
Change-Id: Ic71e05d7561e1dcb532795dbf0b6e9309c1032d2
2018-01-21iOS, removed iOS special handling in init()jan Iversen1-14/+0
Removed the need for the (limited) init() used earlier by iOS. Due to problems solved below init() it is now posible to use the standard init !! init.cxx still have some special handling of paintTile, which we should try to eliminate Change-Id: I42234aea8ac6b8dfcf8c3c88b386b4d4a97bba74
2018-01-21tdf#35301 Formatting ruby text on right side.Mark Hung3-45/+70
* BuildMultiPortion(): preserve room for the ruby text by increasing the width of the last portion of the base text. This allows the ruby portion to be selected with the base text so that they seemd like attached to each other. * CalcSize(): we need to be careful because the width and height of the base text line is swapped. * PaintMultiPortion(): render the base text on top of the preserved room mentioned above, by shifting the position back. * SwRubyPortion(): RubyPortion::RIGHT is designed for horizontal writing mode only. In vertical writing mode it fallback to RubyPortion::ABOVE. Change-Id: I5291e32221b6b2fc1c3e152b3a5defe857428163 Reviewed-on: https://gerrit.libreoffice.org/48244 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-01-21Make the condition more obviousMaxim Monastirsky1-2/+2
No need to look at possible enum values each time. Change-Id: I3191ab08d91c8f954ecfb027f1ab26b25a021f14 Reviewed-on: https://gerrit.libreoffice.org/48258 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-01-20readd lost commentRene Engelhard1-0/+1
Change-Id: I99e3b3941f0478213ec9efe6b5152f2d780a8d00
2018-01-20deb#887593 make gpg child profile really workRene Engelhard1-1/+6
now I can see my testkey and sign. Thanks Christian Bolz Change-Id: Idd46e7f7d2e16cf24bbdee10ecad772baaaa7f4a
2018-01-20Addition of focus_on_click to notebookbar ui filesMaxim Monastirsky13-6/+616
(automatic rewrite) Change-Id: I959b58b3b0b69de9344b0f7188594a19e8b9d4ea Reviewed-on: https://gerrit.libreoffice.org/48176 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-25 20:32:25 +0000