summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2018-09-27Revert "framework: mutex locking revision"feature/cib_contract935Thorsten Behrens2-1/+5
Revert "framework: remove solarmutex blocking since we are using own mutex" Revert "framework: fix compile error of b98bef638e7352918dd487c6dd0769e9e896a61e" Revert "Revert "debug: let's disable dispatch interceptors for a while"" Revert "framework: use own mutex for interceptors call" Revert "debug: let's disable dispatch interceptors for a while"
2018-09-27sw: fix copying of PageDesc follows in SwDoc::AppendDocMichael Stahl1-9/+35
The problem in the bugdoc is that there are 2 styles; "First Page" has "Default Style" as the follow, and vice versa. When the "First Page" style is copied, its follow is copied as well, but the follow of the follow doesn't point to the *new* "First PageN" style that was just created, but the original "First Page" one. Change-Id: Ie5b0064581a585a3a545360ea5c05f60652f0d4e Reviewed-on: https://gerrit.libreoffice.org/60993 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit a6a4fa526b8ad19ff6d44a89ee56d4268c8e90be) Reviewed-on: https://gerrit.libreoffice.org/61060 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-09-14CHSH-33 Disable dpi awareness in program manifestSamuel Mehrbrodt1-1/+1
Change-Id: Ib532dae9d547107698fe3b9ddc83ce943f9c54df
2018-09-10framework: mutex locking revisionVasily Melenchuk2-7/+21
- revert own mutex, use SolarMutex as before - extend SolarMutex protected area until queryDispatch() finish Change-Id: Ie94b120a594aff8a3a443b3eb6ee723eb3d5a26f
2018-09-10framework: remove solarmutex blocking since we are using own mutexVasily Melenchuk1-26/+0
Change-Id: Ib1a8462c172792d41bc8af618287b3ef2b694b04
2018-09-07framework: fix compile error of b98bef638e7352918dd487c6dd0769e9e896a61eVasily Melenchuk1-0/+4
Change-Id: I103d372479b634e056b4faf1753f3f54730f1456
2018-09-07Revert "debug: let's disable dispatch interceptors for a while"Vasily Melenchuk1-15/+2
This reverts commit 3b6fdf5eb0f6571383880e8c6af450a0e0069fca. Change-Id: I3c11a11061f4a4395f7bf2a1dfaed3f25721d448
2018-09-07Revert "framework: [experimental] add additional race conditions blockers"Vasily Melenchuk2-17/+4
This reverts commit f77744a7911ae846fbc401aad5dea37510a7f283.
2018-09-07framework: use own mutex for interceptors callVasily Melenchuk2-3/+7
instead of SolarMutex blocking not entire methods let's try to use own mutex (with guard) to lock only InterceptionHelper critical parts. Anyway, SolarMutex here looks like overhead. Change-Id: I572b796cb351035c48d0b496ae0b54ef26a18682
2018-08-30debug: let's disable dispatch interceptors for a whileVasily Melenchuk1-2/+15
Also make a debug run of interceptor code during registration Change-Id: Ie7c59eda4ca4e7b12ecd5a0a296de0e87d3d005b
2018-08-23framework: [experimental] add additional race conditions blockersVasily Melenchuk2-4/+17
Change-Id: I743a93b76886107b8d6a9f36c64bed11afab6ca3
2018-08-16google breakpad: use ful memory dump on crashVasily Melenchuk1-2/+3
Change-Id: I65c525a848ed59abd32e214889234333bd64a471
2018-07-04./g: don't exit early on ./g checkout -fThorsten Behrens1-1/+1
Reviewed-on: https://gerrit.libreoffice.org/56822 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 5fce97a58b8f764e35bf98128591c9a89537da05) Change-Id: I33f54c365bce64ccccfeb1c58fc8e4faddb7ad77 Reviewed-on: https://gerrit.libreoffice.org/56916 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit dca20728ebe798ada1045ea3dabcb981166e2b9d)
2018-05-28tdf#107605: Fix reading version 0 OS/2 font tableKhaled Hosny1-2/+2
The version 0 table os exactly 78 bytes since it does not have any of the extra fields from the later versions. Change-Id: Ie2e478bdefb201b988dc0844240d4ff193d66583 Reviewed-on: https://gerrit.libreoffice.org/43374 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> (cherry picked from commit abc401787179b097dcbc1006fa454980537bfc0b)
2018-05-09Revert "soffice.bin: increase stack-size tenfold"Samuel Mehrbrodt1-1/+1
This reverts commit eacb222cac1883c98da4a76b235916f5eda1a82f.
2018-05-09Revert "soffice.bin: slightly decrease stack-size, especially for 32bit"Samuel Mehrbrodt1-11/+1
This reverts commit 1638a4a740e84af7e441dbb3d6c04fb9b3439ce7.
2018-05-09tdf#116498 Use win metrics for 'DIN Light' fontSamuel Mehrbrodt3-1/+29
This adds a special treatment for fonts which rely on the win metrics for correct line spacing calculation. At the moment, only 'DIN Light' is known to need that treatment. Change-Id: Idd9fd6f63083ab7a706e0cbcd33a947d4949d4e9
2018-05-09tdf#107605: Fix line height cslculation for broken fontsKhaled Hosny1-5/+9
Change-Id: I06368dd15d7898dda61bc07b0f96bf82b00733b9 Reviewed-on: https://gerrit.libreoffice.org/43095 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> (cherry picked from commit 9bc39be417a4c436cbe18391fc87e5e835551b07)
2018-04-17Set parent window for print dialogSamuel Mehrbrodt1-1/+2
In embedded LO this dialog sometimes shows up in background. Change-Id: I9b7f423aaa6b2bbe915398287a5f3b955af930b4
2018-04-17make it possible to set parent window for printer error messagesCaolán McNamara7-10/+18
Reviewed-on: https://gerrit.libreoffice.org/50008 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 60ae5f530c3123341a8c2d49793693c2cd4521c2) Change-Id: I0effa3645454ef9d03393ae8b256cd624ca04f03
2018-03-15soffice.bin: slightly decrease stack-size, especially for 32bitThorsten Behrens1-1/+11
So especially for 32bit builds, creating many threads easily blows virtual address space. Let's be more frugal there. Change-Id: Ib877cb60a0dc4221b9ef7fd88933d5f3207d9a83
2018-03-13soffice.bin: increase stack-size tenfoldThorsten Behrens1-1/+1
Due to recursive UNO calls, and the bridges putting UNO data structs on the stack via alloca, need more space here. Change-Id: I0360e6c1baff84902bb5d6a82e8097996b66675c
2018-03-13Make last interceptor be the first in the list.Thorsten Behrens1-1/+1
This prevents the swriter dispatchinterceptor from being the first that's called, then calling out to java Change-Id: I22533511645d33ac80ea3b45b0c6138d67669902
2018-03-13Revert "tdf#96949 Remove global m_bPreferrFirstInterceptor"Thorsten Behrens2-1/+22
This reverts commit 5d4f1f6f630d4382679087a4fb0da364c9c9692b. Change-Id: Iad47f0658900e9f548f83314976ac67cb4b20828
2018-03-07sal: fix build after portsThorsten Behrens1-85/+15
Change-Id: I080ba9934e3e2b57c0fca37690cf3a12b9216d85
2018-03-07Symstore: Also add .exe and .dlls to symstoreSamuel Mehrbrodt1-1/+5
These are needed when analyzing the minidump. Change-Id: Ife296c298e3b2f1ca8a47dcbaaf1947e6aefdc81 Reviewed-on: https://gerrit.libreoffice.org/33631 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 8a0416be440180d0a6cedd449307f6a9bde22eaa) (cherry picked from commit ebe2acbebd8c7f375802f90a12b5d92691932194)
2018-03-07logging: add some strategic places around vcl messagesThorsten Behrens4-0/+9
Change-Id: I3eb1076a0dd697ceb3b4310444542f324848b358
2018-03-06bridges: Log function names, not string pointersSamuel Mehrbrodt2-0/+17
Change-Id: I5177dd4fbc8f1b638ceff14c5d88d19fff8076a3
2018-03-06sal: flush log-to-file, remove extra linefeeds otherwiseThorsten Behrens1-2/+2
syslog and windows debugger console don't need explicit line feeds. For ofstream, use endl which implies a flush. Change-Id: Id94e07aa1ae042557052fab6483e5db75aada89d
2018-03-06Fix crash when logging.ini does not existSamuel Mehrbrodt1-1/+4
Change-Id: I1ed82fdcce1eb15548e699ffbf93ae39664612b3
2018-03-06This code wouldn't otherwise build on 5.0.7@LinuxKatarina Behrens1-0/+31
Change-Id: I106c1a286ff5ad710a54cabc873cc5356f0a3123
2018-03-06Optionally include timestamp in the logSamuel Mehrbrodt1-1/+77
Change-Id: Ia9f162b704b6e16c84f259e9548e91b7bcd6a378
2018-03-06sal: log windows trace output to debugger consoleThorsten Behrens1-0/+7
Change-Id: Ic8fea70fd3b0b2d4881cd30e3616f5bbf7c0c533
2018-03-06sal: don't reopen logfile on every log lineThorsten Behrens1-4/+42
Change-Id: Iac34fc87a99e98ca5e41eb621d55bf356c371e97
2018-03-06Crashdump: Make crash directory configurableSamuel Mehrbrodt1-9/+24
Change-Id: I8106ec674080ede7072581dab2e6700040de5828
2018-03-06Disable CrashReportUISamuel Mehrbrodt1-2/+3
since we don't offer upload - only want the dumps Change-Id: I6d084757d83204cb960905d7eb78571b13f8f875
2018-03-06Add build id to crash metadataSamuel Mehrbrodt2-0/+3
Change-Id: I0e11a96936ea08cc439fcc1b1e3ff1f59c636665
2018-03-05download via https rather than httpCaolán McNamara1-3/+3
Change-Id: I2840d116d1a59e19f5869c0550c6ed3d1b911304 Reviewed-on: https://gerrit.libreoffice.org/37063 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 2f3060d40a7c6972a2054514e59cea36e0437951)
2018-03-05CheckLinkFormulaNeedingCheck() for named expressionsEike Rathke3-1/+12
This is a combination of 3 commits. CheckLinkFormulaNeedingCheck() for .ods named expressions This is specifically necessary for named expressions that are used in conditional format formulas, for which RPN is generated at a later stage, not during import. (cherry picked from commit eae9648e99be53ba441d9d8207aac6f3ce211ef2) CheckLinkFormulaNeedingCheck() for .xls named expressions (cherry picked from commit 8512f13c42ae3fbb287a555616fe10ff04295616) CheckLinkFormulaNeedingCheck() for .xlsx named expressions (cherry picked from commit a1f933ee2b9e23a505d937035821e9571cf4119c) Conflicts: sc/source/filter/oox/defnamesbuffer.cxx e03cb5767c34f8157a492a6d6c3b0700d065052d 217c89822ab477a6c383d170ae739e44efd10fa3 Change-Id: I54ab8dc14f81d6b18b0d17f448187d19d8e396fc Reviewed-on: https://gerrit.libreoffice.org/48858 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 908854a7b281454332af434be9468ec45d420030)
2018-03-05CheckLinkFormulaNeedingCheck() for conditional format expressionsEike Rathke4-2/+29
This is a combination of 4 commits. Prepare CheckLinkFormulaNeedingCheck() to use either RPN or tokenized code Conditional format formulas aren't finally compiled until needed so the check will have to operate on the tokenized expression instead of RPN code. (cherry picked from commit faa0305ba3d0dc698fce4915d4f3a1fb52422380) CheckLinkFormulaNeedingCheck() for .ods conditional format expressions (cherry picked from commit 2930ba2ac5d9423f2848b968edcd8ddc71966186) CheckLinkFormulaNeedingCheck() for .xlsx conditional format expressions (cherry picked from commit fef24d9f999ee54d7936900485d97ff26656f517) CheckLinkFormulaNeedingCheck() for .xls conditional format expressions (cherry picked from commit af2a2a0c72db312902e466c36697b5c198041e82) 45eb1ab5efa0ec9da2663f20427d2474ce300826 31ede1a23223a798141a0891deeabd8cf88fff58 afa112cc591b411d80ead48bf726788d361f6eb3 Change-Id: I68837e9bd33f125ab47b10b1a6fa18175abd1627 Reviewed-on: https://gerrit.libreoffice.org/48719 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit dc44111ad5965bf4179fc654b677e1e445dea2f0)
2018-03-05CheckLinkFormulaNeedingCheck() for .xls and .xlsx formula cellsEike Rathke7-2/+20
This is a combination of 3 commits. Move implementation to CheckLinkFormulaNeedingCheck() for further reuse (cherry picked from commit 55e484c7bcd3ef218e08d3fd93f97bf98fd8cb7f) CheckLinkFormulaNeedingCheck() for .xlsx cell formulas (cherry picked from commit f96dbc3dd9c33202f75e29ef49d962386595995d) CheckLinkFormulaNeedingCheck() for .xls cell formulas (cherry picked from commit 6bc48275558c3f76c4da25eb8af3c48583ac5599) a6dd195f7eb4d43483e87eeca59f651e7bf2dcb8 2587fbc4fec39b6f2c8e733331815a2953dee308 Change-Id: I541d2b6e12a88371c064b901b00e71206ee0c18e Reviewed-on: https://gerrit.libreoffice.org/48143 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 2bef4debcf7650f3b3922134dff0332d4a95da3f)
2018-03-05handle ocWebservice similarly to ocDdeCaolán McNamara10-45/+252
might have too much in here seeing as we don't need to worry about ocWebservice calling into itself Reviewed-on: https://gerrit.libreoffice.org/47819 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit e1946d75a1095c2596d7815600454ff01fcd3270) Signed-off-by: Andras Timar <andras.timar@collabora.com> Change-Id: I0145f38cc1c1f9ff514a496f7101d81cde9e7c67
2018-03-05Better handle ScDde formulas with missing dde-link entriesCaolán McNamara7-11/+19
typically each ScDde formula has a matching table:dde-link which results in a ScDdeLink getting inserted during the load. If that dde-link is missing then no ScDdeLink exists and ScDde() will create a new one without cached content. So detect that ScDde is used in the freshing loaded ods and defer fetching new content until the right time. only call GetHasMacroFunc to set SetHasMacroFunc and bHasMacroFunc is not accessed any other way, so this is an oxbow Reviewed-on: https://gerrit.libreoffice.org/47757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit b0597ba5d745974fce752e1b677451a19350d351) Reviewed-on: https://gerrit.libreoffice.org/47818 Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 4ede45eb239b1604bca900c22481b7d13e4c2790) Signed-off-by: Andras Timar <andras.timar@collabora.com> Change-Id: I016b53288076d83dd49e92e245346a5f7f560522
2018-03-05limit WEBSERVICE to http[s] protocolsCaolán McNamara1-0/+9
and like excel... 'For protocols that aren’t supported, such as ftp:// or file://, WEBSERVICE returns the #VALUE! error value.' Change-Id: I0e9c6fd3426fad56a199eafac48de9b0f23914b3
2018-03-05gbuild: populate local symstore on WindowsThorsten Behrens2-0/+82
Script based on Lubos' tb master script from http://nabble.documentfoundation.org/Daily-Win32-debug-builds-td4067279.html Change-Id: I7f3247367a63078881f3cf51cf3e2cad59ad67b5 Reviewed-on: https://gerrit.libreoffice.org/33088 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 17e9a5bf94eb08f88f8c78c9982dd0ce48a5e2d9)
2018-01-10tdf#114628 correct line spacing for impresslibreoffice-5-3Szymon Kłos2-17/+28
* use line spacing also for the first line * correct spacing in case of > 100% proportional spacing * impedit2.cxx only code readability change Change-Id: I24832e7dc2fa8cfbb2f9cdfe7062eaaaa63f1729 Reviewed-on: https://gerrit.libreoffice.org/46925 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/47571 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-01-10tdf#114848 Don't save empty themesSzymon Kłos3-0/+18
Change-Id: I7136f5c0bc884a2f9ea945b4e0bc093a5ef2d8df Reviewed-on: https://gerrit.libreoffice.org/47481 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/47579 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-11-25Add ICU changeset-40324 fix for CVE-2017-14952Eike Rathke2-0/+12
(cherry picked from commit cebe1279665960b732c9cb05c18e481c33e778bb) Conflicts: external/icu/UnpackedTarball_icu.mk Change-Id: Ia457669c5ec6ef5c568f4550c44ef5df32a4be66 Reviewed-on: https://gerrit.libreoffice.org/44494 Tested-by: Eike Rathke <erack@redhat.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2017-11-09Resolves: tdf#111428 swap ScColumn::mnBlkCountFormulaEike Rathke1-0/+3
This is a combination of 2 commits. (cherry picked from commit 423df1fa929784c14e3a133c06468589fe9269cd) (cherry picked from commit 911e2aff3cc37cb7410292728ffea05fffbfb0b3) CellStoreEvent remembered the original ScColumn::mnBlkCountFormula, hence after inserting a column to the left the quick check of ScColumn::HasFormulaCell() whether there are any formula cells worked on the swapped in count (originally the one to the right) that happens to be empty in the scenario. Things worked correctly by accident if the next column to the right already contained a formula cell. c44fed96c49bea7365bf1200e06788860966795c Change-Id: If993856ceee657736f516a81c293506041a6b7eb Reviewed-on: https://gerrit.libreoffice.org/44210 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Eike Rathke <erack@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/44493
2017-11-08tdf#103978 textboxhelper: syncProperty OPAQUE (wrap in background)Justin Luth3-0/+24
Although the containing shape is in the background (and thus the normal paragraph text is still visible), the shape's text was still painting over top of the normal paragraph text because the textbox was set as opaque and not transparent. Setting the textbox to sync the opacity value of its containing shape. Change-Id: I02477e2fa7def1f13590afcaa7c6564dd79d6406 Reviewed-on: https://gerrit.libreoffice.org/39672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> (cherry picked from commit cc438f60d6ad0855f754dd32da9c9a80c7cabf92) Reviewed-on: https://gerrit.libreoffice.org/44431 Reviewed-by: Andras Timar <andras.timar@collabora.com>