AgeCommit message (Collapse)AuthorFilesLines
2014-08-11Return to pixRect in Paint.feature/calctiledrendering_altAndrzej Hunt1-7/+5
Change-Id: I8ee807ba94c3e372b8dd1cbbf9302aaf9e85f323
2014-08-11Move variable definition closer to point of use.Andrzej Hunt1-4/+4
Previously it was in a very unlogical location. Change-Id: I6a09244eb1aa3bf413ae98e215c2667adcc96907
2014-08-11Return logic units for GetMergeSizePixel too.Andrzej Hunt1-3/+4
This is used for some cell drawing etc. This commit by itself isn't so useful as the clients also need to be updated to work with logic units rather than pixels. We should probably also rename the method at some point. Change-Id: I7e563d21885261b0dabe55e6e535b066b68a07a3
2014-08-11Use correct scalings for col/row-bar text too.Andrzej Hunt1-8/+2
Change-Id: I55d7a965bfef6a459d98845a329d1f399e23d63f
2014-08-11Use late conversions for col/row-bars too.Andrzej Hunt2-28/+114
Change-Id: I258408fef0f0c18b20c8973c2182fac2d5ed3298
2014-08-11Remove bad check.Andrzej Hunt1-10/+0
This was an issue with Tiled Rendering when we still used the FillData. We don't use FillData anymore, and more importantly we do actually want to be able to redraw just one column/row at a time (where nStart==nEnd). Change-Id: I3f8b85556d3b6d6cf7cdc50db93db1fa3119e9fc
2014-08-11DON'T MERGE: more work needed.Andrzej Hunt1-5/+8
Change-Id: Id3cb2f0146ffec4b4bd3ae2f06690e1cde8182b1
2014-08-11Use OutputDevice scaling for column-/rowbars too.Andrzej Hunt3-27/+74
This means we now match the new gridwindow dimensions. There are however some issues around selection/painting now, which are presumably related to some parts of the code still assuming pixel rather than logical dimensions. Change-Id: I15c2bc7210f26cededd63bc89dbd782e6e4c03b8
2014-08-11Pass PaintMapMode through to DrawGrid/DrawBackground.Andrzej Hunt6-32/+59
Change-Id: I1e89babc968278fb504a9afdb409ecc1a8142fc5
2014-08-11Ensure we actually render all cells in the selected area.Andrzej Hunt1-0/+4
Only cells within maVisibleRange are rendered, even if we request a larger area (and maVisibleRange is otherwise not updated for tiled rendering). Hence we should explicitly set it here. Change-Id: I399be9df1f266a2b3d32a95483960b21f561c6b3
2014-08-11Take into account drawing layer for data area size.Andrzej Hunt1-2/+18
The drawing layer could potentially have items that are outwith the data area, but we probably want to have them included for tiled rendering. Change-Id: I958c4fa29491cdb0fd80392dfcfa033306f2b76c
2014-08-11Use output device mapping for draw layer too.Andrzej Hunt1-1/+3
Otherwise draw layer items don't get scaled at all for tiled rendering. Change-Id: I4ed54f61420eae82fcf4692b8e9b605a3338fc52
2014-08-11Set correct scaling for normal painting.Andrzej Hunt1-0/+6
As we no longer read the scaling from the viewdata, we should instead set it on the output device when doing normal rendering. However the grid still doesn't exactly match the external axes yet, there are probably more rounding errors wherever they are painted. Change-Id: I25b1bd9b344115578fe892aa94fbf753a3c10c81
2014-08-11Use output device scaling to determine cells in draw-area.Andrzej Hunt1-11/+12
Change-Id: Idf4e6ccb72090a55b6a9234cafae21821e3df0b0
2014-08-11Don't scale grid and cell dimensions multiple times.Andrzej Hunt3-33/+40
Previously we had multiple layers of scaling, with rounding errors propagating, leading to up to 5% differences in expected and rendered sheet widths -- for tiled rendering dimensions have to scale accurately as we may paint the same tile at multiple zoom levels, by eliminating multiple scaling and letting the output device instead deal with the scaling once we can eliminate these errors. (However currently rendering of text/images isn't quite right.) Change-Id: I0a725fd5c030f3c089c2bbd25947088c321eb2d4
2014-08-08Implement data area size retrieval.Andrzej Hunt3-4/+49
Cell dimensions appear to be in TWIPs (but the drawing layer is in 100th mm).
2014-08-08Allow overriding of device for Paint, and use that for Tiles.Andrzej Hunt2-7/+14
Paint handles figuring out which cells are within the visible area for us etc. Gridwin being a Window which paints to itself is a bit of a pain, since we now need to be able to reroute painting calls to alternative output devices, however these changes seem to be sufficient to at least get the cells in the desired tile rendered. Change-Id: I7bd1434c97acc6e9ef6e1e63cbcf039b987c88e4
2014-08-08Calc: Add tiled rendering device to the paint view.Andrzej Hunt1-0/+13
This prevents the previous warnings of SdrPageView::DrawLayer: Creating temporary SdrPageWindow (ObjectContact), \ this should never be needed Change-Id: I76cb7c9ed4d45bfcbd297f697314309b4e036f80
2014-08-08Render tiles from calc.Andrzej Hunt3-14/+32
Currently the document size and number of cells to be rendered is hardcoded, this will need some more work to select the correct cells for a given tile (i.e. cells from location). Also, there isn't really a "size" for a calc sheet, so presumably we'd need to instead return the area containing cells that aren't empty, whilst still being able to render larger tiles? (And in any case the client will need to be aware of this and provide an appropriate interface, i.e. the current LO UI simply extends the sheet ad-infinitum.) We also currently get some warnings most likely related to the way we push our OutputDevice into the rendering methods: SdrPageView::DrawLayer: Creating temporary SdrPageWindow (ObjectContact), \ this should never be needed Change-Id: Ia9d64d7de6c22d5b401350f88497a7ec106f1973
2014-08-08vcl: don't throw misleading exceptions on every failed accessMichael Stahl1-1/+4
During the build different instances of gengal will create a temp file called "instdir/share/config/cdefghij.klm", and enumerate the directories in instdir/share/config; it may happen that the enumeration sees the temp file, and it is removed before fetchFileStatus is called, resulting in E_NOENT rc and the exception. The FileIsValidIconTheme() should be able to handle most errors here. (regression from 60954a8a96a66ff11e06b850838f3d16e8e1625f) Change-Id: Id9361a37b8569d01509efcc8cda2bc17e9eabcd8
2014-08-08DOCX export: handle date SDT on paragraphsMiklos Vajna5-6/+60
Date SDT's are normally imported as form controls, while most other SDT types are just custom properties on regular text portions or paragraphs. However, given that form controls are not supported in headers/footers, in that case even date SDT's are just custom properties. So support such properties on paragraphs in the exporter to properly roundtrip date SDT's in headers/footers. Change-Id: I19eb73a3673e387a7b8780756ce7426a1851e796
2014-08-08Unused optional elementsMiklos Vajna1-3222/+0
The scripts parsing this file don't care if an element is optional or not, so why bother. Change-Id: I0860c9209347d6fab83e1faf2867db4de94216ac
2014-08-08warning C4101: 'e': unreferenced local variableMichael Stahl1-0/+1
Change-Id: Ieaea27df421c939da895723485770830ac15c873
2014-08-08qsort and bsearch need different kinds of callback functionsStephan Bergmann1-9/+12
Change-Id: I4a661434c3a51169ec14336bb39a1d2ceeb139ad
2014-08-08Missing test dependenciesStephan Bergmann1-0/+4
Change-Id: I7ea8f2b02b66a15e86e20948536c34017d6a3999
2014-08-08bnc#885548: Write test for this.Kohei Yoshida2-1/+66
Change-Id: Ifbd4502a5e49dfbb60301b935291ed0ce65da706
2014-08-08fix image dragging inside a documentLuboš Luňák1-5/+1
Testcase is a document with a table and a wrap-through anchored-to-character image below it. Dragging the image up to be anchored to a place in a cell and positioned partially on top of the table does not actually change the image position if the image was below the table before the drag, but changes when the table was above. In the faulty case, SwToCntntAnchoredObjectPosition::CalcPosition() returns prematurely because of paragraph portion information not existing at that point (interestingly, the problem is also fixed simply by commenting out the return). This basically reverts 9b87346bf4a1d32abfa781aa66d4d5b627133edf . I'm unable to check the original problem as the bugreport references a web page that no longer exists. So if that one still exists, it'll need to be handled whenever somebody runs into a way of reproducing it. Change-Id: Id354237dace3179b94768146ec1a599cc3d49146
2014-08-08drop extra (David Tardon1-1/+1
Change-Id: Ib1b6abf7a2aca80e7206d792d31f2cdd0fbe3ff8
2014-08-08warning C4702: unreachable codeMichael Stahl1-0/+2
Change-Id: I8a1e67d3ec1ef0c94b41e46a29a40280468d5e76
2014-08-08osl: kill check for ancient freebsd < 7 versionsRiccardo Magliocchetti3-19/+3
Change-Id: I082611edd88daae36181d62f9fc56b588630629b Reviewed-on: Reviewed-by: Michael Stahl <> Tested-by: Michael Stahl <>
2014-08-08Generalize -fsanitize=address checksStephan Bergmann4-13/+17
...that are at least also relevant for -fsanitize=undefined Change-Id: I39044d2a73912a605af8e965eb1cdf8dfd4f0051
2014-08-08bnc#885548: Set the date time mode to non-fixed after the import is done.Kohei Yoshida1-0/+1
So that the new revisions will correctly record time stamps. Change-Id: I7d9b26bed04a95ce2652224faa0f214562818970
2014-08-08Forgot to add break here.Kohei Yoshida1-0/+1
Change-Id: Ic7322f111ca6732243741296d7b5f577af28bf14
2014-08-08DOCX import: handle date SDT in headers/footersMiklos Vajna1-7/+36
Turns out form controls are not allowed in headers/footers (see the comment in the patch), so if that happens, then just fall back to what we already do for other SDT types. Change-Id: Icc79c2a825e9eb2a85980489812a4178fde37576
2014-08-08DOCX import: tokenize CT_SdtDate / storeMappedDataAs and calendarMiklos Vajna1-0/+2
Change-Id: I7d47e7db08637488975b834f7cc72fe1251a14d3
2014-08-08sw: improve doc model xml dump of SwFmtAnchorMiklos Vajna1-1/+22
Change-Id: Icdfc370c4b525fd43d9d5935ff461534cf535233
2014-08-08Unused param elementsMiklos Vajna1-150/+42
Change-Id: Iaefcd143eea3a09040cc0b6aa5d07b2d131e525c
2014-08-08Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happyStephan Bergmann5-1/+5
Change-Id: Ib769dbbcb78e9440805aee40019ab98cd52e8477
2014-08-08Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happyStephan Bergmann2-0/+2
Change-Id: I610172167c49afa3989aa1626b10b8aaa1f91578
2014-08-08match va_start() with va_end()Takeshi Abe1-0/+1
Change-Id: I5c3c2570d6311f49da95bb80c0f9850f89970235
2014-08-08configure: SunStudio is not a (supported) C++ compilerMichael Stahl1-52/+1
Change-Id: I65d5f499b2948f9e57c47d262a2d6e5e8cbcf8da
2014-08-08odk: outdated documentationMichael Stahl1-6/+6
Change-Id: I7e675a544729a7e1763d69888d1ad721c70df77c
2014-08-08Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happyStephan Bergmann5-0/+9
Change-Id: Icb959b7e2e8558f251d4bfd3b21124ca31132183
2014-08-08Fix *_component_getFactory function typeStephan Bergmann1-4/+4
Change-Id: I91b18d4a96d10070fb9e7be76ea39b07541fa4db
2014-08-08Cleanup OUStrings in CustomShapesJoren De Cuyper4-136/+62
Signed-off-by: Stephan Bergmann <>, removing stray left-over sSecondLightDirection declaration Change-Id: I5c7f5c956b70adad953b52be3d456775b0f5fbc1
2014-08-08Remove redundant inclusions of header "cppuhelper/shlib.h"Matthew Pottage3-3/+0
Change-Id: Iab402035613a6cc96b7b4ebd2981a1fd0f8bed23 Signed-off-by: Stephan Bergmann <>
2014-08-08[API CHANGE] Removed two cppuhelper deprecated headers.Matthew Pottage11-551/+57
The headers cppuheader/compbase.hxx and implbase.hxx. They have been deprecated since 2001. Moved the definitions of the deprecated functions to cppuhelper/source/compat.cxx. Signed-off-by: Stephan Bergmann <>, adding fixes and clean-up in cppuhelper/source/compat.cxx and odk/ Change-Id: I48b3cbf551b59d72614737a883a96aab55fc2090
2014-08-08writerfilter: Move includes accordingly.Jan Holesovsky3-4/+2
Change-Id: I35c27dfa459fff3a2ee271333980c789d01fac56
2014-08-08writerfilter: Kill CreateElement and CreateElementMap.Jan Holesovsky5-63/+38
The last bogus usage unordered_map is now gone. Saves another 300k (stripped dbgutil build). Change-Id: I7be0c495d119e4b117eacc6eb5a5f19433582f73
2014-08-08-Werror,-Wunused-private-fieldStephan Bergmann1-5/+2
Change-Id: I03d8f81b17341e128c9c0517ecca2a76f7b4552c