summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2018-04-06SOSAW080: Solve UNO API calls that move SvxShapes to other Modelfeature/SOSAW080Armin Le Grand2-0/+38
Due to UNO API tests I got a call to insert an xShape to a xDrawPage which was constructed in another Model, this has now to be done by Cloning the SdrObject to the new SdrModel, getting rid of the old one and getting all the UNO implementation stuff right (referemces SdrObject <-> xShape). Change-Id: Ibf097ee7467895823fbd158a2a9543da3b5a5078
2018-04-06SOSAW080: Free SdrObjects when SdrModel goes downArmin Le Grand1-6/+19
In an UNO API test problem is that SvxShapes reference SdrShapes, but these are not added to a SdrPage and not 'owned' by the SvxShape. Thus these do not get deleted at all (same in master, memory leak). I extended SvxShape::Notify the case for ModelCleared to also Free the SdrObject when not owner and it's not added to a SdrPage (in that case it gets deleted with deleting the SdrModel) Change-Id: I7b5c241faec7488924e5935ae8b19f785846b5e4
2018-04-06SOSAW080: Reworked SvxShape to use SdrObject's SdrModelArmin Le Grand1-21/+30
Change-Id: I17bcb44d2e29920c0c74430c2d9c703b36cfa0ad
2018-04-06SOSAW080: Reworked SvxShape to use SdrObject's SdrModelArmin Le Grand6-445/+446
Change-Id: I17bcb44d2e29920c0c74430c2d9c703b36cfa0ad
2018-04-06SOSAW080: Corrected CppunitTest_sc_anchor_testArmin Le Grand1-1/+1
An adaption of a SdrPathObj instantiation was missing, added that. Seems as if that test is no tpart of the usual 'make' scenario, but used/executed in gerrit builds Change-Id: I1694b54903df784385abaa8452e1201e12344238
2018-04-06SOSAW080: Added missing include for MacBuildArmin Le Grand1-2/+1
Change-Id: If830fbc5fadd89d04be5edd2a5abf9b0d4bf0410
2018-04-06SOSAW080: Added Scale to DefaultPropertiesArmin Le Grand1-1/+17
If a SdrModel change happens in DefaultProperties copy constructor (used from Clone()), potentially a Scale for the SfxItems has to be done. Change-Id: If9e646242cf89f6fde1315046952252a2c429779
2018-04-06SOSAW080: Added include for Mac-BuildArmin Le Grand1-0/+1
Change-Id: Ic5137ba8c597c7b5f90318df50e87b93a39a28dc
2018-04-06SOSAW080: Corrected some SdrObject::Clone scenariosArmin Le Grand3-2/+34
Especially when cloning to another SdrModel and taking the sdr::properties into account. Change-Id: Ic366d60299f239e3df856ddffedb19e743e4be0c
2018-04-06SOSAW080: Corrected SdrPage constructorArmin Le Grand2-27/+2
Change-Id: I488b9601735ec1822433f82f633990063951fe08
2018-04-06SOSAW080: Added missing includesArmin Le Grand1-1/+2
Change-Id: I4caf6b6fbbe6e8130741d793dffb560fd01d4ed5
2018-04-06SOSAW080: getSdrModelFromUnoModel added override marksArmin Le Grand5-5/+8
Change-Id: I22de9a1c8af7c25be5c108671ddc548ba323ed47
2018-04-06SOSAW080: Corrected constructorArmin Le Grand2-2/+2
Change-Id: Ic1b5ed3c99bc7219a0061e4ece24ea42afd2889a
2018-04-06SOSAW080: Adapted some comments to make more readableArmin Le Grand13-17/+17
Change-Id: I446685a49a6d67aedd01cfbbd5e87b07f97a4d7b
2018-04-06SOSAW080: Removed ChangeModel from classesArmin Le Grand4-74/+4
Classes SvxTextEditSource and SvxDrawPage (including TextEditSource stuff) do not need change of SdrModel anymore. Change-Id: I8c4626274a5cc531dad27f27c0c45d4c528fb2fb
2018-04-06SOSAW080: Adapted GetObjGraphic to just take a const SdrObject&Armin Le Grand8-93/+67
Change-Id: I0a636caf3cb36c2f9c6cd11aa22cb9bc435dc8f2
2018-04-06SOSAW080: Stabilized for UnitTests, cleanupsArmin Le Grand64-1012/+198
Change-Id: I6878b33f8b05738a44c0910e40a60a0f0d1d58ed
2018-04-06SOSAW080: Debugging/Stabilizing/MakeUnitTestWorkArmin Le Grand8-192/+155
Change-Id: I33a6f3f306b70c223171aef796dd5ee041ad14df
2018-04-06SOSAW080: Smaller corrections/includes adaptedArmin Le Grand6-3/+52
Change-Id: I242b9e228a9a042c3a5bdd38b1ea6600144276d5
2018-04-06SOSAW080: Smaller corrections/includes adaptedArmin Le Grand2-0/+3
Change-Id: I242b9e228a9a042c3a5bdd38b1ea6600144276d5
2018-04-06SOSAW080: Adapted SdrPage/SdrModel relationshipArmin Le Grand60-993/+902
Also needed to work on copy-construction of SdrPage and hierarchy, quite some stuff removed, no copy-constructor anymore, no MigrateItemPool stuff. Builds well, test stuck, will need some cleanup/finetunung Change-Id: I763f39094b6a48b529a6952d01468f8776c97679
2018-04-06SOSAW080: removed and replaced old SdrModelArmin Le Grand189-2533/+2686
Removed and replaced GetModel()/SetModel() in all using classes (SdrObject, SdrPage, SdrView), added accessors to new referenced SdrModel, adapted all accessing places. Refactored/Extended ::Clone and ::operator== for these classes to allow cloning objects to a target SdrModel. Adapted places where this is done AFAP. Added quite some comments (tagged with 'TTTT') where possible further work is needed. Builds completely, thus checking in. This does not mean that this change is done yet. Change-Id: I24617494a0ef79f6e33dfcb02782a833a81c6434
2018-04-06SOSAW080: Make SdrModel& prerequisite to SdrObjectsArmin Le Grand223-1156/+2264
Added need for SdrModel& in constructors of SdrModel, SdrPage, SdrView and SdrObjList. Builds, not finished. Change-Id: I1cb7d573d323e98a89761fe662c10c4a654fdec0
2018-04-06SOSAW080: Added first bunch of basic changes to helpersArmin Le Grand18-110/+363
Change-Id: Iaf53535de0502a481466be74a1768bbb39f0e78c
2018-04-06Updated coredennisroczek1-0/+0
Project: help 552bd0cb910de00124ef01d25607648373cf1db4 fix link to the Sane Project Change-Id: I5e21ee3f572a54f90372af8a869829e3101019cf Reviewed-on: https://gerrit.libreoffice.org/52502 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2018-04-06loplugin:useuniqueptr in ScXMLTableRowCellContextNoel Grandin3-10/+17
Change-Id: Ie2c50b08eed674c129f0f66eae502c61e565a7f8 Reviewed-on: https://gerrit.libreoffice.org/52495 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-06tdf#111313: Honor bWriteNoLenParam in !bCompatibility, tooStephan Bergmann1-36/+26
e8deba22e887a972f60ff05551e93c334ac1e7b6 "INTEGRATION: CWS ab26" had added the bCompatibility case with all the argument checking ("2006/05/04 08:33:46 ab 1.66.10.3: #111951# Changed Mid runtime behaviour only for CompatibilityMode(true)"), and it was probably an oversight that, for !bCompatibility, it left the bWriteNoLenParam case (triggered by Basic code like s = "abc" Mid(s,1) = "d" ) calling OUStringBuffer::remove with an illegal argument of len=-1. Change that so that only setting ERRCODE_BASIC_BAD_ARGUMENT is controlled by bCompatibility, while all the other checks (that are probably all necessary to not call rtl string functions with illegal arguments) are done in both modes. Also, the check nStartPos + 1 > nArgLen should probably be nStartPos > nArgLen instead, as nStartPos has already been decremented from the one-based Basic index to the zero-baesd rtl string index. Change-Id: I75deec0acf75b8677aa89f91897c06c1caa5614d Reviewed-on: https://gerrit.libreoffice.org/52500 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-06improve field names in CellAppearancePropertyPanelNoel Grandin2-132/+90
to make the code easier to read Change-Id: I8f5cb13c017e00f3a0b992be1e03acbce9f61769 Reviewed-on: https://gerrit.libreoffice.org/52492 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-06tdf#116836 Don't move objects out of cell when shrinking cellSamuel Mehrbrodt1-2/+6
Change-Id: I8185f3501eb17a62ef4f55b2c8bb2d70f1895365 Reviewed-on: https://gerrit.libreoffice.org/52491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-04-06tdf#86404 - use Ctrl+TAB to switch between tabs/sheetsheiko tietze2-24/+26
Introduced mod1+tab and mod1+shitf+tab and assigned it to next/prev sheet in Calc Change-Id: I49e4dee685bbf81595f24222907664a271a3f121 Reviewed-on: https://gerrit.libreoffice.org/52392 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-04-06tdf#77747 handle Hebrew numbering in ppt.Mark Hung3-0/+23
Change-Id: I4af60a701e4dc2c3bae1c223ec56e03c16210996 Reviewed-on: https://gerrit.libreoffice.org/52225 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-04-06Colibre icon: fix size issue for insertcolumns/rows beforeandreas kainz4-2/+2
Change-Id: I64962d49d3997fa15ccad989e2e91885c0aa2b4b Reviewed-on: https://gerrit.libreoffice.org/52488 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-04-06merge CellBorderUpdater into CellAppearancePropertyPanelNoel Grandin5-127/+39
no point in having it separate, the code flow is cleaner this way Change-Id: Ibc04eb4fa0ee6438b84f181a2cbdb6de22872ac5 Reviewed-on: https://gerrit.libreoffice.org/52487 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-06Fix Python file URL construction on WindowsStephan Bergmann1-5/+2
...after d76281864b0e83812c0edf7490b1e8271e89fff5 "Create temp copies of test docs in Python/UITests" Change-Id: I4b6a5149c68f9e6cdc0a2037c07b50e8acc3623f Reviewed-on: https://gerrit.libreoffice.org/52486 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-06tdf#116628: Fix expanding the entries in Help's Contents tab.Jan Holesovsky1-1/+2
Change-Id: I50627ca577bf89810c716bf9e1db9ae74cec58d1 Reviewed-on: https://gerrit.libreoffice.org/52473 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-04-06tdf#115407: preselect sound file savedJulien Nabet1-3/+5
To display the sound in the dropbox, the complete filename (eg: file:///home/julien/lo/libreoffice/instdir/share/gallery/sounds/pluck.wav) was compared with items of the sound list formed like this: file:///home/julien/lo/libreoffice/instdir/program/../share/gallery/sounds/pluck.wav See https://bugs.documentfoundation.org/show_bug.cgi?id=115407#c1 Since listbox displays only basename, let's just compare basenames Change-Id: I5fb49990322423fa7818e5d6e1cafd828e3500ec Reviewed-on: https://gerrit.libreoffice.org/52476 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-06osl: Remember the last error before returning osl_Socket_ErrorTakeshi Abe1-10/+11
This prevents from e.g. com.sun.star.bridge.UnoUrlResolver's emitting confusing messages, when trying to connect to a port on which no LibreOffice process is listening, like: > Traceback (most recent call last): > File "<stdin>", line 1, in <module> > __main__.NoConnectException: Connector : couldn't connect to socket (Success) ^^^^^^^ After applying this patch: > Traceback (most recent call last): > File "<stdin>", line 1, in <module> > __main__.NoConnectException: Connector : couldn't connect to socket (Connection refused) You can see the above behavior with the following python code: import uno x = uno.getComponentContext() y = x.ServiceManager z = y.createInstanceWithContext("com.sun.star.bridge.UnoUrlResolver", x) url = "uno:socket,host=localhost,port=2002;urp;StarOffice.ComponentContext" a = z.resolve(url) ... provided that no process is waiting on port 2002. Change-Id: Id094cf9271fe77d84f2284d91a0e452448de2bc2 Reviewed-on: https://gerrit.libreoffice.org/52018 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-06fix bug in SwWrtShell::InsertNoel Grandin1-1/+1
ever since commit 9ce556080fe4b4a1810653aa45d06e9cb34274b0 Date: Tue May 18 13:13:46 2004 +0000 INTEGRATION: CWS swundo01 (1.22.126); FILE MERGED found by my unusedvariablesmore plugin Change-Id: I6cc1e7959cabf6452a37829482600f38a90cd993 Reviewed-on: https://gerrit.libreoffice.org/52447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-06NB Calc: needed icons for Layout Tabandreas kainz2-0/+6
Change-Id: I9b9567664df919e418ac519930c907198ba2b728 Reviewed-on: https://gerrit.libreoffice.org/52482 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-04-06NB Calc: needed icons for Insert Tabandreas kainz3-0/+17
Change-Id: I3a622a4b658c314bfac6f89a12ffedd09b44bb3b Reviewed-on: https://gerrit.libreoffice.org/52481 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-04-06fflush() followed by fclose() is redundantTakeshi Abe3-6/+1
Change-Id: Iacb9332635cb6afa90ec1a72e96388b3b5b7b56c Reviewed-on: https://gerrit.libreoffice.org/52420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-06ucb: Shift property "IsRowCountFinal"'s index from 0 to 1Takeshi Abe1-4/+4
The original 0 seems a typo. Cf. ucb/source/sorter/sortresult.cxx and ucb/source/ucp/ftp/ftpresultsetbase.cxx. Change-Id: I5c2331483aa8186a031bba9fb2fc906ee4a1e535 Reviewed-on: https://gerrit.libreoffice.org/52484 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-06svx: Fix the sequence's lengthTakeshi Abe1-6/+5
Change-Id: I8b1798659efb798ca4f4883469118a297f40b83b Reviewed-on: https://gerrit.libreoffice.org/52466 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-06fix bug in View::CreateSelectionDataObjectNoel Grandin1-2/+1
ever since commit 5e6def1bd4e36379e8dce78402820540bd6f02e2 Date: Fri Jan 19 18:15:28 2001 +0000 Redesign for XTransferable found by my unusedvariablemore plugin Change-Id: I80c8db159c026cbdc93449ace61444adf7c854ce Reviewed-on: https://gerrit.libreoffice.org/52448 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-06Allow .NET SDK 4.7.1Mike Kaganski1-2/+2
Change-Id: I24be20fdedf36153e4012dde6d7cc899098f769e Reviewed-on: https://gerrit.libreoffice.org/52479 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-04-06vcl: more migrations to GetSizePixel() in BitmapExChris Sherlock1-40/+50
Change-Id: I2b9fa2cff8a64e35288d67314b95b9d01c2441cc Reviewed-on: https://gerrit.libreoffice.org/52452 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-04-06Resolves: tdf#116796 Ok -> OkCancelCaolán McNamara1-1/+1
Change-Id: Ib816862a462614a47045628ffe57358a4986149b Reviewed-on: https://gerrit.libreoffice.org/52477 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-06Updated coreOlivier Hallot1-0/+0
Project: help cb53adf410d240b9fcecc9e11e0253aa67bcd455 Better wording for public key management help page Change-Id: I56a355e1a62fd981cb6d37de9778b7ab81e4e33e Reviewed-on: https://gerrit.libreoffice.org/52478 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-04-05interim cut down on spew some moreCaolán McNamara1-0/+1
Change-Id: I534a01d9cd8e507b8b277eb185dc96bcd9bd63fe
2018-04-05tdf#42949 Remove unnecessary localization headers from chart2Gabor Kelemen28-36/+0
Found by searching for the header names and the localization function: git grep -l -e \<ResId.hxx\> -e \<strings.hrc\> chart2 | xargs grep -c SchResId | grep :0$ | grep -v /pch Change-Id: Ic4fd9245a7e4c3dc96216687f6f8e9820e062a5e Reviewed-on: https://gerrit.libreoffice.org/52410 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-19 22:03:14 +0000