AgeCommit message (Collapse)AuthorFilesLines
2018-01-28BorderlineFix: Corrected wrong indexing in Array initializationfeature/BorderlineFixArmin Le Grand1-1/+1
Change-Id: I4222ef1c82620a05cea9f6db1a0664196cfb3bd4
2018-01-28BorderlineFix: Use svx::frame::Array tooling in Draw/ImpressArmin Le Grand4-108/+92
For creating the needed BorderPrimitives for TableCells for the Tables used in Draw/Impress, adapt the ViewContactOfTableObj doing this to use svx::frame::Array tooling now. This will correct the error for not taking the neighboured connects for merged cells into account and unify one more space to the same tooling. Change-Id: I2e6f732985e9b963359f156628bd29ddfec1a80c
2018-01-28BorderlineFix: Corrected Draw/Impress TableStyle accessesArmin Le Grand1-4/+4
In Draw/Impress the indices for accessing the correct neighbouring TableStyles were wrong and thus created wrong visualizations, corrected that. Change-Id: Iebc5f294adb62fa4c6358e2f8c27d29cc3163fbc
2018-01-28BorderlineFix: Fix WriterPaint if scrolling CellTableBordersArmin Le Grand1-0/+22
Similar to CalcBorders in Writer the overlap regions for FrameBorders have to be taken into account when repainting the CellBordes of WriterTables Change-Id: I488ba158e1de579bfb06b9c8353adaa2cac706c6
2018-01-28BorderlineFix: Fixed visual updates when scrollingArmin Le Grand1-5/+26
For Cells with DoubleLine the connections to perpendicular DoubleLine-Styles may have to be displayed in a Cell which is 'around' the orig cell in a Cell-Border of one. To represent that and to avoid repaint errors when scrolling in, the preparation of Primitives has to take accordingly more neighbour cells into account. Tested this change with the usages in Calc, UI (Dialogs) and Calc exports Print/PrintPreview/PDF. This does not affect Tables in Writer and/or Draw/Impress. Change-Id: I3bcc68cdf7b4fc1825a87a9773892c359421024e
2018-01-28BorderlineFix: Corrected handling for 'rotated' CellBordersArmin Le Grand4-12/+29
CellBorders can be rotated (including their Text) and need special visualization that is based on an own sheared/rotated coordinate system. Currently only possible for single cells (not merged ones) and needs to handle all borders (also bottom-right directly in the rotated cell, not in the neighboured ones to have the geometry, plus avoiding these in the non-rotated neighbour cells. Also corrected adding CellRotation data to svx::frame::Array in calc using SetCellRotations() which now gets called in the ScOutputData constructor to ensure it gets called in all places where it is used. Change-Id: I47bdfc29ba5ca76bbc07d98cb64733f867b1ee20
2018-01-28BorderlineFix: Avoid BorderLines to be too prolongedArmin Le Grand2-21/+39
For MergedCells there was an effect that the BorderLines were painted too far in PrintPreview/Print/PDF visualization, found reason and changed. Checked (hopefully) all usages, looks good. Change-Id: I0acf8dcb20548a98533f3ab317ac72c0d0f0a947
2018-01-28BorderlineFix: Corrected missing borders in printArmin Le Grand2-26/+25
In Print/PDF/PrintPreview border lines were missing, this happened for merged cells. It has to do with access to the involved Styles and/or 'Clip' set (to avoid creating everything). Thus a 'mixed' usage of cell and merged-cell stuff was needed. As it turns out support for this is already there, need to use it. Change-Id: Ic16085b97eef5c79a4501279432f43491bca350e
2018-01-28BorderlineFix: Need to redesign Borderline paint for CalcArmin Le Grand7-235/+179
To fix some errors, need to change svx::frame::Array conversion to Primitives, especially regarding handling of merged cells. These make problems in the currtent form where the full extended merged cell tries to be converted. This is bad for cropped stuff and also wrong for double-line stuff attaching to a merged cell. The solution is to handle cells single and merge created primitives which is more expensive but will work. This will involve special handling for X-Ed (crossed) and 'roated' Cells. Also need to be very careful since all this is used in the meantime for all visualizations of Tables in multiple apps/situations. Change-Id: If0652a3ba97a6f27dd5d782ea22b1514303f3710
2018-01-28tdf#114736 no need to call AdjustLayout hereTamas Bunth1-2/+0
Change-Id: Iae8c953155d46e53cffdf3483e3b4b95157719f6 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Tamás Bunth <>
2018-01-28tdf#115276: multiply quarter-points by 5 (not divide) to convert to twipsMike Kaganski1-1/+2
Unit test will come in separate commit Change-Id: I4cd6983d708868883c766b239cb57752106a59bf Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Mike Kaganski <>
2018-01-28ofz#5747 short->sal_Int32 like in StgDataStrmCaolán McNamara1-4/+4
Change-Id: I254c00b1142d7187beabe5d18532efec036de494 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-01-28tdf#35301 offapi: add RubyPosition for filters.Mark Hung3-0/+48
RubyPosition describes the position of the ruby text relative to the base text. ABOVE and BELOW were defined in ODF, while INTER_CHARACTER is originated from CSS to indicate the alignment used in traditional Chinese. For INTER_CHARACTER, the ruby text is aligned vertically on the right side of the base text, disregard of the writing mode is horizontal or vertical. Change-Id: I89224704c192adf9ebb94024d0f2b03f00880cf5 Reviewed-on: Reviewed-by: Stephan Bergmann <> Tested-by: Jenkins <>
2018-01-28mailconfig UI: default POP port 995 and toggle with IMAP portsJustin Luth2-2/+30
SSL is now default, so change POP3's default to port 995. Also, suggest appropriate secure/insecure ports for IMAP and POP as the user switches between them. Change-Id: Ib930504956a222d0d6eb3cad969907751602c106 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-01-28tdf#111786: PPTX export: Shape's line transparency is not exportedTamás Zolnai3-2/+30
Change-Id: Iab11906e6ed79e1e39bba1b07b50a25887517f3a Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Tamás Zolnai <>
2018-01-28mailconfig UI: pre-fill username from mail addressJustin Luth1-0/+12
Be nice to the user. We already asked them for their email address. Typically, the username for authentication matches the email address, so pre-populate that. Change-Id: Ia390bdc293510900220c996be13c238d88817b81 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-01-28tdf#104707 ooxmlexport: support RawText in textboxesJustin Luth1-3/+9
Thanks to Caolan, we got some more sample documents from tdf#43431 and tdf#33596 to help flesh this out a bit better. Change-Id: I47cf4b7e2af6854e0da1f8dbdc1e564494ee0e17 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Justin Luth <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-01-28tdf#114821 calculate correct label positionSzymon Kłos3-2/+40
Max is now equal to whole surface size, not only point pos. Change-Id: If231fb7224b23e9993fcf575f5a020ca8e2b04ab Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Szymon Kłos <>
2018-01-28coverity#1428661 Uninitialized scalar fieldCaolán McNamara1-1/+2
Change-Id: Ie0578786fdd167e1ec8dd581f656bfcbbb3c2a58
2018-01-28tdf#115269: fix crash when changing horizontal align (reportdesign)Julien Nabet1-1/+1
See bt: Regression from Change-Id: Id23dbbec7dd93a603d906b5d8f7bbf74d14e1d65 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Julien Nabet <>
2018-01-28SvxAccessibleTextIndex::mnEEIndex need not be bounded sal_uInt16Stephan Bergmann2-9/+9
It was originally introduced with type USHORT (a909acb7009acadffa53e74ea05ddb88803490f1 "#98735# Refactored unoedit/unoedacc.cxx"), then shortly after changed to sal_Int32 (a0089a21f047ce8b5378b45f1535269e3600d681 "#98735# Fixed various off-by-one mistakes"), presumably because it needed to hold values slightly larger than USHRT_MAX. But at least since the surrounding code has been changed to use sal_Int32 throughout (e.g., structs like EPosition and ESeleciton in include/editeng/editdata.hxx with 3cbfcee36dd16e451d76c561eaaaee0ff29b01a5 "xub_StrLen and tools/string.hxx final straw"), there appears to be no more reason to effectively restrict mnEEIndex to sal_uInt16 values. Change-Id: I78f02be1f2736a626a836ac992230a74cc669fd3 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Stephan Bergmann <>
2018-01-28tdf#115208 Apparmor profile update (allow JVM execution)Olivier Tilloy1-0/+1
Change-Id: I2911066f77fcd79b05c5247ea1086b671d546216
2018-01-28Remove redundant checksStephan Bergmann1-3/+2
...that date back to a909acb7009acadffa53e74ea05ddb88803490f1 "#98735# Refactored unoedit/unoedacc.cxx", before SvxTextForwarder::GetParaBounds was changed from sal_uInt16 to sal_Int32 with 2af1f5691e8d64afd5246d245d7876b5a2cd5cd8 "resolved fdo#35756 import more than 64k HTML table cells" Change-Id: Ia92dcf1fb6742779e5fd51ed3ba8f0db565f8965 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Stephan Bergmann <>
2018-01-28loplugin:useuniqueptr in SfxRequestNoel Grandin2-13/+12
Change-Id: Id2b2a1ac9803b0caa2d28163160d85be5253dd9e Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2018-01-28make SvxTableController constructor take SdrTableObjNoel Grandin3-23/+17
since the only call site already effectively checks that, simplify the constructor code accordingly Change-Id: I29e5283d529a988693972d85cfa8196ba2906220 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2018-01-28make RECT_EMPTY purely an implementation detailNoel Grandin5-24/+34
and make outside code use the IsEmpty/SetEmpty methods Change-Id: I4821d1bdceb99bb6a837a85ff2131003f9a160a5 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2018-01-28Remove shared mxComponent in scdatapilotitemobjJens Carl1-18/+4
Change-Id: I9e1b98f203e5e85c25947d6b26f62f36672264c8 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Jens Carl <>
2018-01-28Remove shared mxComponent in scdatapilotfieldobjJens Carl1-20/+7
Change-Id: I96e733f14561037dd2ad1df080adfdb911b8243e Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Jens Carl <>
2018-01-28Remove shared mxComponent in scdatabaserangesobjJens Carl1-19/+4
Change-Id: I55eda7486ebadb02569c5ce21e709704dbf1d795 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Jens Carl <>
2018-01-28Remove shared mxComponent in scdatabaserangeobjJens Carl1-20/+7
Change-Id: I46f45eababddc61b90b4883a804f52f97e87e87f Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Jens Carl <>
2018-01-27Modernize a bit formsJulien Nabet7-125/+80
by using for-range loops + use returned iterator by erase call Change-Id: Ia41c9fae190dbad6a25b62a9b15ad51e89dd2906 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Julien Nabet <>
2018-01-27tdf#115090 keep internal BaseModel alive long enoughThorsten Behrens2-1/+4
There's reams of code already preventing a close during save (SfxSaveGuard), but this looks equally effective. Avoids SfxBaseModel::dispose() pulling the rug under us, when SfxBaseModel::postEvent_Impl() wants to access parts of the interface containers during notification. Change-Id: Iace1f9922c47a97ab2e798b577c6aec8a729da48 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Thorsten Behrens <>
2018-01-27uitest for tdf#81351Zdeněk Crhonek4-0/+97
Change-Id: Ieb9ea4d7c1ed9a65396046ea388bf9f6c3975a83 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Markus Mohrhard <>
2018-01-27tdf#115221 crash in printing and commentNoel Grandin1-3/+1
not wonderfully happy with this fix, because we're changing the delete ordering here, but the origin of this bug was commit a754294ac7a902fe96fbbd6b8b6824a360d6b248 use rtl::Reference in SwDocFac instead of manual acquire/releas and commit cc483d0470dbf0d01e4da818b148ff0b851c5187 (patch) tdf#112292 - fix memory leak and use more auto ref counting in sw so the delete ordering was obviously messed up in those already, and we have such a morass of callbacks here, I can't see where else to fix it. I tried to add a couple more "getDoc() != nullptr" checks, but we still ended up crashing with an SwViewShell that had a bad pLayoutAccess pointer. Change-Id: I4aa39d58ae25bed41e3fd2c32c6d53659012ec10 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2018-01-27Remove shared mxComponent in scconsolidationdescriptorobjJens Carl1-19/+4
Change-Id: I4b71673fa19459eeb7ea97bb291a62f327d69958 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Jens Carl <>
2018-01-27Remove shared mxComponent in sccellrangesobjJens Carl1-19/+4
Change-Id: If357e94566440276bb1df88a4b899125beffe148 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Jens Carl <>
2018-01-27Remove shared mxComponent in sccellrangeobjJens Carl1-36/+7
Change-Id: I6044091da3b883d885642bfda3dce8acc8044420 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Jens Carl <>
2018-01-27Remove shared mxComponent in sccellobjJens Carl1-21/+3
Change-Id: I4b1fa30316c05cd0527ba429f8ad863db8be77a3 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Jens Carl <>
2018-01-27Remove shared mxComponent in sccellcursorobjJens Carl2-27/+9
Change-Id: I24d3641feb34e66959ff2afe4cdb3546e7cd7ca4 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Jens Carl <>
2018-01-27improve subtyping when dealing with tools::WeakReferenceNoel Grandin30-158/+131
tweak the templating to make it easier to declare a WeakReference that points to a subclass for a weak-capable class. Which lets us declare some fields with more specific types, and dump a lot of unnecessary casting. And make WeakBase be inherited from virtually, so we don't end up with weird states where two weak refernces could point to two different parts of the same object. Change-Id: I3213ea27e087038457b0761b5171c7bce96e71f3 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2018-01-27tdf#114771 make focus rect in Navigator content tree position correctlyJim Raykowski1-0/+1
Change-Id: I747d3ef2bbe7227b048e29bd8c5758fb7778ab9d Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Tamás Zolnai <>
2018-01-27writerfilter: FindStyleSheetBy... remove StyleName optionJustin Luth3-17/+1
It is confusing having three undocumented Find functions. Reduce by one - either search on the imported WW8 (ISTD) name or on the internal (converted) name. The one remaining use of ByStyleName was testing against an already set property, so by definition it was set using convertedStyleName. (Plus, that was my code anyway...) Change-Id: If5a352bedb7d297698f449fbb629a1350e27c51c Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Justin Luth <>
2018-01-27mailconfig: default to secure port 587Justin Luth1-2/+2
A very readable explanation of ports 25 / 465 / 587 was In short, 465 was a very temporary and never official port to use for encrypted sending. Port 587 is the official port for encrypted (or even non-encrypted) mail submissions. For a very long time now, every public mail server (and likely even private internal servers) supports STARTTLS, so default to using secure connections. Change-Id: Ic8a6886221fa2e7b733b2535a84a584fe64d3165 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Heiko Tietze <> Tested-by: Heiko Tietze <> Reviewed-by: Jan-Marek Glogowski <> Reviewed-by: Justin Luth <>
2018-01-27Updated coreDmitri Kharchev1-0/+0
Project: help f244829556e67657cdd5c08d4126151b067a2a15 tdf#100810 CEILING.XCL, CEILING.MATH not in help Change-Id: I94325c24e5e34db2a6d44d6124cd2e44cb76d201 Signed-off-by: Olivier Hallot <> Reviewed-on:
2018-01-27lok: Allow whitelisting languages that should be used by LibreOfficeKit.Jan Holesovsky5-1/+59
LOK may get way too many languages if there are dictionaries for them installed which blows the pre-init to >2G easily; let's allow limiting that. Also make the preloading of languages work with the internal spell checking dictionaries and thesauri. Change-Id: I77119970030a7386a5cccbe4fdc89b15eab56ef1 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Michael Meeks <>
2018-01-27Updated coreAndrea Gelmini1-0/+0
Project: help 9bd1736a8b3dc0631e14b12fd81ba4136e8aaa99 Fix typos Change-Id: I1c9a02aab47a26a9f18d2327ca0f4f58adac2c0d Reviewed-on: Reviewed-by: Julien Nabet <> Tested-by: Julien Nabet <>
2018-01-27Modernize a bit connectivity (part2)Julien Nabet15-129/+110
by using for range loops Change-Id: Ibbc4cdaa78c4c9d88487132a2761ac1040b1ecd8 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Julien Nabet <>
2018-01-27Add HSQLDB schema importTamas Bunth19-6/+929
It can be enabled by initializing the DBACCESS_HSQL_MIGRATION variable. Create new library "dbahsql" which is responsible for migrating the embedded hsql database to any database covered by sdbc. The hsqldb schema is stored in a file named "script" in form of SQL statements. The SQL statements used by DBMS's differ mostly by the defined types. Because of that, only the create statements need to be parsed, alter statements will work (with a little luck) without actually modifying it. User / security settings which can occur in the script file (e.g. GRANT statements) are dropped. Statements starting with SET are also dropped (they are hsql specific stuff) Change-Id: I6a22942e8a9a76765f80e50f0ad68f4d72e1ff9d Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Tamás Bunth <>
2018-01-27Fix typosAndrea Gelmini14-25/+25
Change-Id: I8d5a8251a01af7cdf9832d98d8a6573b907f8532 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Jens Carl <>
2018-01-27Fix typosAndrea Gelmini17-29/+29
Change-Id: Id1a19f2c8b44131773d4d5270a607c1907b16597 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Jens Carl <>