AgeCommit message (Collapse)AuthorFilesLines
2015-12-11vcl: use a custom tag for VCL OpenGLContext's to avoid re-use.feature/5-1-pickMichael Meeks6-11/+9
Other code is out of legacy mode now, so can't legacy as a proxy for VCL usage. Change-Id: Ie3807a3af680b707f2f08d058db955bc9cae6c2b Reviewed-on: Reviewed-by: Michael Meeks <> Tested-by: Michael Meeks <>
2015-12-11tdf#93529 - move to a Mac-like double-buffered OpenGL model.Michael Meeks11-73/+357
This moves us to always rendering to an off-screen texture, and then (at idle) blitting this to the screen & swapping buffers. Ideally we should never see any rendering, or flicker again with this approach. Several fixes are included: + avoid multiple OpenGL contexts being created for the same window, created excessive flicker problems. + de-virtualize UseContext - which context we use is less critical. + kill 'mbOffscreen' distinction - all VCL rendering is offscreen. + implement 'doFlush' and high priority idle flushing. + bind stencil buffer for clipping vs. textures - fixing complex clopping when rendering to virtual-devices, and off-screen. + document environment. variables. + use white as default background glClear color, but red or random color for DBGUTIL. Change-Id: I6be08595b6c8deb7e6db0dbd81308b2c97d2b4ff
2015-12-11Get Double-buffered context creation working on linux.Michael Meeks1-6/+7
Change-Id: I3db1d6792fcd51577f047b82029124ec825ea319
2015-12-11vcl: gtk frames should DeInitialize properly, to handle GL cleanup.Michael Meeks1-4/+3
Conflicts: vcl/unx/gtk/gtksalframe.cxx Change-Id: Ie6a5464c28b89f08639939690052023e685a3d33
2015-12-11vcldemo: avoid svg load/render for icon test.Michael Meeks1-0/+2
Change-Id: Ie3f49ff759f0b5b038a7b6a3fb09c5e220aa4645
2015-12-11writer: Defer update, until post first render to avoid flicker.Michael Meeks2-1/+10
Change-Id: Ib16f5b345901adc7036a8a90d0f46aa3499d66ae
2015-12-11Calm unit test down for GL row-strides.Michael Meeks1-1/+2
Change-Id: Ie4123fc692f4fac33f082bb2d86b949d834f1858
2015-12-11silence -Werror=strict-overflowEike Rathke1-3/+3
error: assuming signed overflow does not occur when assuming that (X + c) < X is always false [-Werror=strict-overflow] if ( rAddress.Row() < Row() ) Change-Id: Ia643491657680fffcaacae4a474af479b9a07e35 (cherry picked from commit 0e40e1e3243d57fdf67c54d7c5b69e77fe7d03ce)
2015-12-11unit test for sticky end col/row anchors, tdf#92779Eike Rathke1-0/+184
Change-Id: I78584e37e5944327db9cc5b6472a9e7ea972b37e (cherry picked from commit fe445df126ff0be771494dfef3aec09ca82f8aef)
2015-12-11geez, how about actually checking the Move() error return? tdf#92779 relatedEike Rathke13-44/+181
Handle failure condition where we know how to treat it, i.e. when updating references, assert in all other places that so far silently ignored it and implicitly assumed the failing Move() truncating at bounds would be alright. In case we'll encounter an assertion we'll have to inspect those places and decide what to do about it. Noticed this error with a reference like B1048575 and inserting two rows above, it became B1048576 instead of B#REF! Change-Id: I00757f3ed2e305b591178047933ed60f1533317e (cherry picked from commit 9c1ba0988f5db05bb796eaf7cf902a0b601c6736)
2015-12-11sticky end only if it already was a range on the same axis, tdf#92779Eike Rathke1-2/+2
Change-Id: I66f624e696a4a6e681733ab863cd57c342cc0bc1 (cherry picked from commit d6f6459350e9e661bc09191cfb31c5e779d522de)
2015-12-11tdf#96384: Add a new signal 'text-selection' to lokdocviewPranav Kant1-1/+20
To help client know when the user has selected a non-null text. Change-Id: Ie939612fc5f38e2e50e9ad9792e04e89ae918886 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Miklos Vajna <> (cherry picked from commit ea5c99428f56e1d3a3e782505aa2f56f905038a4) Signed-off-by: David Tardon <>
2015-12-11tdf#93991: One pixel here or there, who is counting?Tor Lillqvist1-1/+1
<tools/gen.hxx> Rectangle, I love you. Change-Id: Iaf7ae2930d6098349f04cd429cd35dffcaf7ca3b (cherry picked from commit edbe61b671bc4c384be914099ee8bcdfd8491f3a)
2015-12-11Revert "Impress/Draw: Open Navigator in the Sidebar"Samuel Mehrbrodt1-2/+14
This breaks starting a slideshow with Navigator visible. Also leads to problems like tdf#96286 Needs more thought & design. This reverts commit 6f493f9e379af1e005b85606c6aab515726be993. Change-Id: Ia796de5a8ef0be61f36517bc0aa896c66a95c1e8
2015-12-11tdf#85767 Enable rotated/flipped icons in the SidebarSamuel Mehrbrodt12-228/+141
This is a combination of 3 commits: * Make buttonstatuslistener a generic listener for any widgets ac97f32307feb488c86d6fa962258fe79320d31b * Move icon rotation/flip handling from ToolbarManager to vcl's Toolbar c5fe98905deac6de4f9e76a17097ce83fe381ac3 * These should still be virtual. e20df218257c45c5daa234daafac9609d53aa77f Change-Id: I34e2446660ec94d60654b4db40ce1bbb8014477f Reviewed-on: Reviewed-by: Samuel Mehrbrodt <> Tested-by: Samuel Mehrbrodt <>
2015-12-11tdf#96075 Frame alignment buttons not using correct tooltipsSamuel Mehrbrodt3-32/+19
Tooltips change on state change, and they were taken from another source. Unify this to reuse the existing strings from the uno command. Change-Id: I8ff6fc43bc0469f15c9e930695d950f6d664bfdf Reviewed-on: Reviewed-by: Samuel Mehrbrodt <> Tested-by: Samuel Mehrbrodt <> (cherry picked from commit ba659f71f482dd74a83aaa9710ea65fff27ac274) Reviewed-on:
2015-12-11tdf#96396 evoab2 does not need gtkDavid Tardon1-1/+0
Change-Id: I727d90e4ffc4d567ad02ca5b55b1e8d26d15e928 (cherry picked from commit b672126e7c4ffd32d42594cf527b09a9f0434cb9)
2015-12-11update creditsChristian Lohmaier1-1219/+1224
Change-Id: Ibee5fdd8a59b1e06112bc32ee5dad7f1699fae9b (cherry picked from commit f2070db3f2ad7e0c4b7d7233b5999bcf869226b5)
2015-12-10tdf#96042: Oops, fix a typo.Jan Holesovsky1-1/+1
This fixes a regression from commit 4c4999d944bbf8a34f8a320b8de6f4a325bd5d97. Change-Id: Ie8496392f4811cc1ff146d7a5c43988da0d539c2
2015-12-10need a dynamic cast hereCaolán McNamara1-1/+1
53rd and final distinct crash fix of this sequence Change-Id: Id170132c2082fd4905192adc840125088ef5da27 (cherry picked from commit 3735b05668ffcaa37fcecf2907478616db52f2b4)
2015-12-10guard against empty StoryCaolán McNamara1-1/+1
Change-Id: Ide44aed9a3189b0fd21a8adc039eb61bd3d3dc14 (cherry picked from commit ef68438d384ed6dd919fa0f1a3830d2171f8e002)
2015-12-10guard against broken formula and bad lengthsCaolán McNamara1-1/+16
Change-Id: Iab13d67fdc218c84400a4d84e177e5096bb68379 (cherry picked from commit 1e0b9881b4dc7d002d5da767f1476fb1c2147fc7)
2015-12-10check for null ModifiersCaolán McNamara1-1/+1
Change-Id: I842122f7e2cba48d4798905f41f63b3e06775d00 (cherry picked from commit 6834384e80cf5cd374cdec471ce385ba2ca94580)
2015-12-10check for null contentCaolán McNamara1-3/+6
Change-Id: I824c29b39fe1e9e631a21f09611758bea03b0ca9 (cherry picked from commit 4a573e67c67ddf15403a79e7ec8d984d189dc83a)
2015-12-10detect infinite recurse in object creationCaolán McNamara2-1/+7
Change-Id: Ie56eb27bb1827860b2600a5586e866e39cd31518 (cherry picked from commit 48c3eb3c91fd98c313bcec18f24cc949d6e788b3)
2015-12-10tdf#93263: Take function mask from ScPivotFieldKatarina Behrens2-3/+11
and not from ScDPLabelData (that's what old code used to do as well). Afaics ScDPLabelData.mnFuncMask member is never modified as the array gets populated in ScDPObject::FillLabelDataForDimension. UI has thus only its default value (PIVOT_FUNC_NONE) and so subtotals get reset on every change. ScPivotField however contains the right func mask, so take it from there. Change-Id: I862be121683aac079e788ce535f714ac8cdbcd0b Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Eike Rathke <> Tested-by: Eike Rathke <> (cherry picked from commit 0bfa6ddc99710c1e166140f97cf3212348d04d05) Reviewed-on:
2015-12-10this needs to be a dynamic castCaolán McNamara1-1/+1
Change-Id: Id606e58292a25309adb67cf05cc9b9a237e83f81 (cherry picked from commit 67296edb5c8c7cbb185fe2d31c46eadc5dd927b8)
2015-12-10add a reference to ensure pPara exists until end of scopeCaolán McNamara1-0/+1
Change-Id: I0067ead587c25296ab195b80f461fb0766b1899a (cherry picked from commit 61f55b25c62eaa2714ad8b991edcf54be5e41e0c)
2015-12-10need dynamic casts here, etc.Caolán McNamara3-13/+15
Change-Id: I578343719d2d7feff51775ff1b073b6584e76f82 (cherry picked from commit 46fe3bddebf30775ae19eaa0fefe1d8e2f78eced)
2015-12-10there can be 0 columnsCaolán McNamara1-2/+2
Change-Id: Ie367e88df7165d728015a1b3987b220a23203765 (cherry picked from commit 6857a386a4cfe4ddb42515cb00df5bd6648d0964)
2015-12-10guard against missing rangeCaolán McNamara1-31/+37
Change-Id: Icdb0694b9c1771a475368aeeb4cb11f4ba8b84f3 (cherry picked from commit 1aff042d88b2d6d3c3b7ed9db4b36bed640a0f06)
2015-12-10tdf#96357 Switching icon theme doesn't update toolbar or statusbarMaxim Monastirsky1-6/+5
Regression of 6480b4d11a0cf2dd489d30b6290aa6d831704a45 Change-Id: I00141b3d9c5ea8dc813530a2ee095d61a35b3c04 Reviewed-on: Reviewed-by: Maxim Monastirsky <> Tested-by: Maxim Monastirsky <> (cherry picked from commit f513a173152cb1c1afd7b700d1b264bc2ea6a5a8) Reviewed-on: Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2015-12-10guard against missing FoundryCaolán McNamara1-1/+1
Change-Id: I7e76589689d2c9e79a8823d594e8f3ca030e26cf (cherry picked from commit 6093ba6065ea339c5c6de162294eabf0eebe3c80)
2015-12-10check dynamic castsCaolán McNamara1-6/+6
Change-Id: Icc3eee0776fb385a5c750293811dec796458a26b (cherry picked from commit 54e95789adf05c6852db18b80a549b789a40d6d3)
2015-12-10don't trust that this is what its supposed to beCaolán McNamara1-1/+1
Change-Id: I8ae6252039729a1cba8c2fe34f72222c94e3e449 (cherry picked from commit 9ad6f07e0b5494e55d70642120f173961845ce30)
2015-12-10check is within legal boundsCaolán McNamara1-1/+4
Change-Id: Ie3f9e52575436b9505a412b20c7e1b24fa61f6cb (cherry picked from commit 8410527550ef6db8348e8590eb0c52bccbe40310)
2015-12-10guard against missing FoundryCaolán McNamara1-20/+29
Change-Id: Id15a2692f8aa572c0b5db87f04761ca3eac0249e (cherry picked from commit ed09d4f55d752dbc7d815fdc90e6cbe2656690b7)
2015-12-10avoid divide by zeroCaolán McNamara1-0/+2
Change-Id: I7d6502c752a7b9f39f94d5cddd5f44240e0b6d04 (cherry picked from commit 92b936e3ef947cc096b1445455332625900c3024)
2015-12-10guard against missing HeadHolderCaolán McNamara1-1/+1
Change-Id: Ic12ee6f4366285fc05fd59b94ec371d8ca013a4a (cherry picked from commit ca868de5e41b45a077949e40ef80f063c362892b)
2015-12-10don't trust that this is what its supposed to beCaolán McNamara1-1/+1
Change-Id: If0450bdab2c315a94a75060e1fadf2f8513f9dae (cherry picked from commit f792baefbfb645eafd5e6b7073bfe6e389d666dc)
2015-12-10guard against corrupt LwpTocSuperLayoutCaolán McNamara1-4/+9
Change-Id: I18648e74d16b932cfa6fbd2057d1e9987c498fd4 (cherry picked from commit e0dca588239c0902ea90fcdc2b6d0ee2b1525ec2)
2015-12-10Memory leakStephan Bergmann2-3/+3
Change-Id: Ica40750d628946678019376d91db67ba3f9ed67e (cherry picked from commit 5ac6e00274e732435b55c2908db9cea658fe549b)
2015-12-10remove misleading commentDavid Tardon1-1/+0
Change-Id: I0408b2956c2156c30e60cf5d21efbac2e0566d10 (cherry picked from commit 66bd1e491102de97ceeb1db5705a15ff2dd69a58)
2015-12-10guard against missing grandfather layoutCaolán McNamara1-1/+1
Change-Id: I1282b2c3c920ef89460aa57026d89c8928155116 (cherry picked from commit f9164c1785432996092d376fb3983e1a3f78dad7)
2015-12-10guard against missing FoundryCaolán McNamara1-0/+3
Change-Id: Id6961e7c35df56ca37d5cb57c2d3d1e03e31dd6d (cherry picked from commit 92c15e8b299504ef76847cceb5911ef6c7ff26f1)
2015-12-10guard against missing geometryCaolán McNamara1-2/+2
Change-Id: I6b2945f1d5a1654f6b5d6a5f5287b4cb9514d97c (cherry picked from commit d4d247866eac108162f43dae2c6ddbd9c12382a6)
2015-12-10use of uninitialized variableCaolán McNamara1-1/+1
Change-Id: I1149eb9f5946228a2448c121e7ec7211861b3b3d (cherry picked from commit 65deab68f7918c82026951b04a414eefee2683b2)
2015-12-10guard against missing parent layoutCaolán McNamara1-1/+3
Change-Id: Ib08403edf805367c7392325fcfb66bc7ed4d6f6a (cherry picked from commit 713d737b1ff73e76c6543198ce9299e1c83ac147)
2015-12-10protect against missing Ruby MarkerCaolán McNamara1-0/+2
Change-Id: I04809443b5dc50904654936e608360b57c2e85c3 (cherry picked from commit 215516a52fd01170bb4a79828b0f0948884b727a)
2015-12-10guard against infinite recursionCaolán McNamara1-1/+1
Change-Id: I43e195df570990f21c780311a98be64b682e5315 (cherry picked from commit 338c6ba3a0983009cfd1faff52ac56d6ea092d6f)