Age | Commit message (Collapse) | Author | Files | Lines |
|
SwAddPrinterTabPage doesn't access any private members,
so doesn't have to be a friend.
Change-Id: I82918af61e7b1568127002e70da8c767aec7f03f
Reviewed-on: https://gerrit.libreoffice.org/83392
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
This is a follow-up to bd2ada701aad2c4e85d03cd8db68eaeae081d91c,
which added the check for nesting hints in MarkManager::makeMark().
Change-Id: Ife847a677514fb1aeb28dc8d6254caea365b754d
Reviewed-on: https://gerrit.libreoffice.org/83388
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
In Calc when a cell is copied and its value is filled/pasted to different
cell(s) by using the "Enter" key when focus is on selected cells --
replace warning is not shown even if the selected cells have values of
their own inside it. The old data is simply lost. Provide a replace
warning dialog box whenever such a case is encountered.
Change-Id: I13acb424bc449e096512b5a0864ebc47a407f234
Reviewed-on: https://gerrit.libreoffice.org/83333
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: Ic4cb8444123864fdaee64960f00a05b3066ae5fc
Reviewed-on: https://gerrit.libreoffice.org/83387
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
text, also its preview in the dialog window, when the URL contains
anchor at the end.
Change-Id: Ibedb86238f660177b3dd476cd6a13f1ca5f05e12
Reviewed-on: https://gerrit.libreoffice.org/82654
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
|
|
Change-Id: I55972388b1f15dc86d309c5ffe998b44596b1cf2
Reviewed-on: https://gerrit.libreoffice.org/83351
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
|
|
by exporting PercentageNumberFormat, checking the "Label" format
directly and taking the respective number format based on that.
Note: also fix the "LinkNumberFormatToSource" property. If we create a
pie chart with data labels and set the "Show value as number" or
"Show value as percentage" and check on/off "Source format", this move
is not set the property in the XPropertySet.
Because of this, it fixes also the export of correct value of
"link-data-style-to-source" property into ODS files.
But this patch doesn't fix the export of old ODS files to OOXML,
because they contain wrong (always true) "link-data-style-to-source"
value.
Change-Id: I4098a245dec5bf35cde20c9ccb79aca726230118
Reviewed-on: https://gerrit.libreoffice.org/82703
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
|
|
As discussed in the commit message of 46c645bf4e9909f5296e75028f1f5434e83942d2
"Move dubious file: -> smb: conversion from INetURLObject to file UCP", it is
unclear why exactly file://<host>/ URLs should be retried as smb URLs on Linux.
That commit had tried to keep that dubious feature alive with a different hack,
but tdf#128598 "FILEOPEN: Certain syntax of opening file from samba share
results in Document in Use dialog" demonstrates that that hack doesn't work well
either (see libreoffice-6-4 <https://gerrit.libreoffice.org/#/c/83396/>
"tdf#128598: Revert 'Move dubious file: -> smb: conversion from..." for further
details).
So just drop the dubious (mis-)feature entirely from LO 6.5. On Linux, use
GIO's smb URLs to access Windows SMB shares, just like you would use e.g. GIO's
afp URLs to access AppleTalk resources.
Change-Id: I2ad53f508919a5f581e3afc4c4a5d26461b8ed2b
Reviewed-on: https://gerrit.libreoffice.org/83402
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I8451e88f8e1ea9b58e18015159d2acc65d818bf7
Reviewed-on: https://gerrit.libreoffice.org/83379
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
making this similar to existing cases like the writer word count
and other toggleable utility windows
Change-Id: I0239114596a01d8c341e2ed2fd92bf1bd323938b
Reviewed-on: https://gerrit.libreoffice.org/83380
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
They were exported with 86ea64f216819696cd86d1926aff0a138ace2baf "Support for
native 32bit Bitmap in VCL and SVP (cairo) backend" but appear to only be used
within Library_vcl.
Change-Id: I03595c8345b289676e6260e7bd88b6b146ac002d
Reviewed-on: https://gerrit.libreoffice.org/83385
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I041dfdaac4903d1bb0bb9ee70a2e5e705af3aafb
Reviewed-on: https://gerrit.libreoffice.org/83398
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I8a7efffb2866e46e978d09ca9fb5c9dec231e132
Reviewed-on: https://gerrit.libreoffice.org/83384
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Change-Id: Ibc90b3b68a55f8396fbe623eb0db6c289fe978a1
Reviewed-on: https://gerrit.libreoffice.org/83383
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
* Update helpcontent2 from branch 'master'
- TDF#128911 typo in formula SUMIF.
Change-Id: I30241cc84bc715ac9ae0a6af39db3a9e95476860
Reviewed-on: https://gerrit.libreoffice.org/83389
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
so the TreeList does not get the mouse release it expects stolen
from it by the dialog, leaving it stuck in "selecting" limbo
Change-Id: If83dcdd8697b2a67e67fb062ae65ad947f49e8cd
Reviewed-on: https://gerrit.libreoffice.org/83372
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Test this from sd, so that SdModelTestBase::saveAndReload() calls
BootstrapFixture::validate() for us.
Change-Id: I6c90a3a71a5603604e69f9b45137bc8e4388dc0f
Reviewed-on: https://gerrit.libreoffice.org/83371
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Fixes CVE-2019-18197.
Remove obsolete e03553605b45c88f0b4b2980adfbbb8f6fca2fd6.patch.1.
Change-Id: I95cf498e245083528f98bfef8cdd240bbe2211b9
Reviewed-on: https://gerrit.libreoffice.org/83312
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
Scenario: a new document where the first thing the user wants
to do is create a footer. Scroll down to the bottom of the page
(this does mean that you can't see the top of the page, right?
None of my screens show an entire page by default anyway...)
and click in the footer area. The screen jumps back to the top
of the page and the user needs to scroll to the bottom again
in order to enable the footer.
So, in the very specific case of the control being turned on
(because I don't care about a jump if the control is being
turned off) don't process a return to the cursor position.
Regression potential:
The only use case I can think of is someone trying to
drag a section by starting too low on the page. The early return
will quickly cancel any kind of drag attempt. Basically if the user
clicks in the footer area without intending to get the
separator bar, it might act differently than what previously
happened. I don't really see this scenario as a problem.
One additional limitation could be added to only apply this
if it is dealing with the footer, since in the case of a
header there would be no screen-jump.
Change-Id: I11cd3089b85d8eb49063b902e6bf8bf2e1412aa7
Reviewed-on: https://gerrit.libreoffice.org/82701
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
|
|
if the object isn't valid, e.g. link to something that doesn't exist, set the fallback
graphic as mxGraphic so SdrOle2Obj::GetGraphic will show the fallback, otherwise
the failing mxObjRef.is test in SdrOle2Obj::GetGraphic means it doesn't get used
Change-Id: I8f1aea6b25dc216e01a0f888a44d10876bb1bebd
Reviewed-on: https://gerrit.libreoffice.org/83322
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
* Recheck after recent refactorings and improvements in f-u-i
* Drop now unused TabPageIds.h
* The problem noticed in bug #119699 now seems to be gone too
so drop those lines from the blacklist.
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: I44f26c7370f5328c8f67ac61cd8f0cdb29077f15
Reviewed-on: https://gerrit.libreoffice.org/83182
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I82fe7ae4e9a564af27d1f080c0bf27e5aab17bfd
Reviewed-on: https://gerrit.libreoffice.org/83188
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Change-Id: I21eadcd210aef38e7690da2492bf1dfe030427e4
Reviewed-on: https://gerrit.libreoffice.org/83356
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I390ac076136140f6aaa391212afeca49ebbd1dc3
Reviewed-on: https://gerrit.libreoffice.org/83355
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
|
|
or it has a parent style so when a custom paragraph style is in use it
can be deleted and the style will revert to the parent
Change-Id: I0e4ff953835c105241d3bb027d24841afdccc7ba
Reviewed-on: https://gerrit.libreoffice.org/83008
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
Change-Id: Iafa89df6f724fa6b64712d970502091e38300dad
Reviewed-on: https://gerrit.libreoffice.org/83341
Tested-by: Jenkins
Reviewed-by: Aron Budea <aron.budea@collabora.com>
|
|
This patch provides intended highlight behavior to my understanding of
comments found in the toolbox source code.
*only highlight when the focus is not inside a child window of a
toolbox eg, in an edit control
*do not highlight when focus is in a different toolbox
*only clear highlight when focus is not in toolbar
Change-Id: Ia18d35c4255ed0940bce5f0c6d9448ed2c85c6fe
Reviewed-on: https://gerrit.libreoffice.org/81356
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
Change-Id: Ia8f00cd882c1c8c239b95de8e917ff317a6485e8
Reviewed-on: https://gerrit.libreoffice.org/83152
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
At present this doesn't work with gtk3 backend. Works with X11, tested
by using SAL_USE_VCLPLUGIN=gen. I suspect it also works with kf5.
Change-Id: I14b82bc7a6f25a4c88d547290d847217aa1b0de2
Reviewed-on: https://gerrit.libreoffice.org/83252
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
...that had been introduced with 51eb969cb77f8b54681033f4959b15ce32116b56
"Replace comphelper::ServiceInfoHelper::addToSequence" and obsoleted by
<https://gerrit.libreoffice.org/#/c/83291/> "loplugin:redundantfcast: Don't warn
about cast from braced-init-list"
Change-Id: Ic5bb63cf4f528285587f46437a27bafbb05a07ac
Reviewed-on: https://gerrit.libreoffice.org/83315
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...in non-deduced context. That means that the necessary cast in
84322944980f6e2f9d4a531de7a6803797156968 "Simplify sequence initialization"
(cf. <https://gerrit.libreoffice.org/#/c/82974/4/>) no longer causes a false
positive, and doesn't need to use comphelper::OUStringLiteralList.
Change-Id: I788da61cc0be82d2166653760e527bb18e366c99
Reviewed-on: https://gerrit.libreoffice.org/83291
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Id5f7a9c34d1d159dd0f930a4ce66871bdd3796c1
Reviewed-on: https://gerrit.libreoffice.org/83305
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
This gets rid of the last 72 lost bytes I could identify in the
huge valgrind logs to look like its PDF generation related.
Change-Id: Idda3c2c5b7f5ce0211199b86503037b74438ccf2
Reviewed-on: https://gerrit.libreoffice.org/83302
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
fixup from 93ee955c5359e283e2fe88e45b4c02a60525ed11
Change-Id: I94fa357e982bdf6a74bc182a51fb562ac39c0090
|
|
The color's alpha is normally lost when we roundtrip SvxColorItem's
tools Color via TextSimplePortionPrimitive2D's basegfx::BColor.
One way would be to add an extra transparency member to the primitive,
like BackgroundColorPrimitive2D does that.
However, a much easier way is to go via UnifiedTransparencePrimitive2D,
that way we handle transparency in
drawinglayer::impBufferDevice::paint(), rather than platform-specific
code like CairoTextRender::DrawTextLayout() in the Linux case.
Change-Id: Ie7aebe77ad9ac776dd27fc50538a5045200c8010
Reviewed-on: https://gerrit.libreoffice.org/83307
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
... which is, surprisingly enough, required to build the latest libxslt.
Change-Id: Ifbb36ed61b8f68185f9c788f63a8edeb58899f94
Reviewed-on: https://gerrit.libreoffice.org/83311
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
fixes CVE-2019-9903 CVE-2019-9631 CVE-2019-9545 CVE-2019-9543
CVE-2019-14494 CVE-2019-12293 CVE-2019-11026 CVE-2019-10873
CVE-2019-10872 CVE-2019-10871 CVE-2019-10018
remove obsolete 0001-ImageStream-getLine-fix-crash-on-broken-files.patch.1
Change-Id: I72b3bf89b294ed3e24157c7e75fd58d4f68d9f35
Reviewed-on: https://gerrit.libreoffice.org/83308
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
Change-Id: I3d26320061f3da01e9b857cb3dad277f3d7aa4f5
Reviewed-on: https://gerrit.libreoffice.org/83293
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
On Win10 with master sources updated today + Visual Studio, I had this part:
[build CXX] bridges/source/cpp_uno/shared/component.cxx
Microsoft (R) Macro Assembler (x64) Version 14.23.28107.0
Copyright (C) Microsoft Corporation. All rights reserved.
MASM : warning A4018:invalid command-line option : /safeseh
Assembling: C:/BLP/core/bridges/source/cpp_uno/msvc_win32_x86-64/call.asm
[build CXX] bridges/source/cpp_uno/shared/types.cxx
See this link for rationale:
https://docs.microsoft.com/en-us/cpp/build/reference/safeseh-image-has-safe-exception-handlers?view=vs-2019
According to https://bugzilla.mozilla.org/show_bug.cgi?id=581909 (9 years ago)
"...For some reason ml64 ignores the -c following -safeseh..."
I don't know if recent Visual Studio versions still ignore or not the following parameters
but let's fix this
Change-Id: I9ae5416f32429597fab35fcce8bf06707af4def5
Reviewed-on: https://gerrit.libreoffice.org/83230
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Ia263f9f7c78dbf48143678fc2f577402fb1ce998
Reviewed-on: https://gerrit.libreoffice.org/83304
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I331f6edcd530d0d409986cf40ebc05b134dfbd1d
Reviewed-on: https://gerrit.libreoffice.org/83314
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Idc1cbb5ba7580963dd47f293d4104998d1f0095d
Reviewed-on: https://gerrit.libreoffice.org/83218
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
|
|
by creating a copy of ScQueryCellIterator that is specialised for this
use-case.
Takes the opening time from 50s to 8s on my machine.
Change-Id: I193a7c181a5dfed6fecf75e871729d73625d0df6
Reviewed-on: https://gerrit.libreoffice.org/83299
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I6e152f69850d1fd3671660decd4186d8cd29465e
Reviewed-on: https://gerrit.libreoffice.org/82047
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
Change-Id: I4ecc13cd7163304c0fa1683e75299d03ccc06446
Reviewed-on: https://gerrit.libreoffice.org/83283
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I5e28a4253b755fc3f5ed7c02c99c2611513e5bd8
Reviewed-on: https://gerrit.libreoffice.org/83282
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I0008393be56341fe7e1f385bd111475b67446240
|
|
Extra cell borders appeared on the bottom, top, left or right
of the 1-cell tables when only the "inside borders" option was selected.
The extra borders were the ones that would normally have appeared as
inside borders if there were more than one cells in the table.
Change-Id: I05d5f2a5a0168989f220d20a95b6dacf5152f9f7
Reviewed-on: https://gerrit.libreoffice.org/82675
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
|
|
Change-Id: I449a0c2db77888a87a0ae983617848a9f0886ef1
Reviewed-on: https://gerrit.libreoffice.org/83233
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
|
|
Change-Id: I605b62ef0dfa29db93e4d7df8285a05a12bda8e3
Reviewed-on: https://gerrit.libreoffice.org/83270
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|