summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2016-09-23Revert "Revert "remove SfxPoolItemArrayBase_Impl typedef""Noel Grandin2-5/+3
This reverts commit b0eecd2d3ba4a1a424a2d52cccf64fe6fc09c34b. Now that the necessary parent commits are in, we can re-apply this.
2016-09-23Resolves: tdf#101971 OleLoad under structured exception guardsCaolán McNamara1-2/+15
sample pptx crashes down in the depths of (apparently pre-installed on 32bit Windows 10) Flash.ocx Change-Id: I4e083d492e56e72df47b2c172d7f07f0e39b82ea Reviewed-on: https://gerrit.libreoffice.org/29199 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-09-23cid#1373353 uninitialized membersMiklos Vajna1-0/+1
Change-Id: I88ae046866c616cc7de226e85eaab1a0e76eb59e
2016-09-23tdf#100726 Improve readability of OUString concatinationAsela Dasanayaka1-7/+1
concat string in module i18npool to improve readability Change-Id: I7f447d64703cf5eb07742329ff2656f67214898b Reviewed-on: https://gerrit.libreoffice.org/29206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-09-23move SfxPoolItemArray_Impl::ReHash to poolio.cxx ...Jochen Nitschke2-19/+19
... it's declared in poolio.hxx Change-Id: I8cc4a7152f66cf89fb01cd7a718974d76825ec04 Reviewed-on: https://gerrit.libreoffice.org/29181 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-23Fix Cppcheck report: reduce scope of the variable 'fTemp'Laurent Balland-Poirier1-2/+2
Change-Id: I935de8e287f94f3219542dfe67f7bb4a05be14da Reviewed-on: https://gerrit.libreoffice.org/29200 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-23don't write item right before destructionJochen Nitschke3-14/+4
SetRefCount writes only SfxPoolItem members m_nRefCount and m_nKind Change-Id: Ibd06d4edc619b9a840a8a232d9395dd85c452149 Reviewed-on: https://gerrit.libreoffice.org/29195 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-22attempt to fix build, ScImportExport( ScDocument*, const OUString& )Eike Rathke2-0/+44
... is not unused but only in ifdef _WIN32 commit c4cd079b8f613084a99a83b95c3968b65cbd8900 Date: Thu Sep 22 15:08:42 2016 +0200 loplugin:unusedmethods in sc..vcl Change-Id: I36c8d57fddfffe8c99cf40ae514270f445388d08
2016-09-22desktop: that wasn't unused, just rarely usedMichael Stahl1-0/+4
Change-Id: I87c0fb287aa0b3fc5ad0216d8007772de3d03b2f
2016-09-22attempt to fix build, reintroduce TabitemValue::isLast()Eike Rathke1-0/+1
commit 7419057e3ec4365748fa6456e207f40fd9e09c62 Date: Thu Sep 22 16:34:14 2016 +0200 loplugin:unusedmethods in chart2..svx removed that but vcl/unx/kde/salnativewidgets-kde.cxx needs it. Change-Id: I1ddc98ffafb1f6a1a22642a9a83cc58085cb4271
2016-09-22attempt to fix build, PrinterInfoManager::changePrinterInfo() goneEike Rathke1-5/+0
commit 7419057e3ec4365748fa6456e207f40fd9e09c62 Date: Thu Sep 22 16:34:14 2016 +0200 loplugin:unusedmethods in chart2..svx removed that from include/vcl/printerinfomanager.hxx vcl/unx/generic/printer/printerinfomanager.cxx but not the empty base class implementation from vcl/null/printerinfomanager.cxx Change-Id: I9bfd1c77490c70b9bf7a69c93d34bd0249cce64f
2016-09-22-Werror,-Wunused-private-fieldStephan Bergmann2-3/+1
Change-Id: I88df0a06482a04609eb0c394dc7d9a023fc7e921
2016-09-22fix windows buildNoel Grandin1-0/+2
by reverting part of commit commit 7419057e3ec4365748fa6456e207f40fd9e09c62 Author: Noel Grandin <noel@peralex.com> Date: Thu Sep 22 16:34:14 2016 +0200 loplugin:unusedmethods in chart2..svx Change-Id: I72515c9b5f3739f57d4b63a724a9fa32075b2612 Reviewed-on: https://gerrit.libreoffice.org/29197 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-22fix windows buildNoel Grandin2-0/+8
by reverting part of commit c4cd079b8f613084a99a83b95c3968b65cbd8900 Author: Noel Grandin <noel@peralex.com> Date: Thu Sep 22 15:08:42 2016 +0200 loplugin:unusedmethods in sc..vcl Change-Id: I4d925532369b37e13d97edd907c12f59a350e6ea Reviewed-on: https://gerrit.libreoffice.org/29196 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-22tdf#75757 remove inheritance from std::vectorJochen Nitschke2-2/+21
Change-Id: Ief06d3ea0288e8ebf34f2f67f3d1dfc9405b6d49 Reviewed-on: https://gerrit.libreoffice.org/29180 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-09-22Revert "remove SfxPoolItemArrayBase_Impl typedef"Noel Grandin2-3/+5
This reverts commit d141d5b3bd11ba6154b5d064fb69900405724b13. seems like I pushed it too soon, it depends on other commits not in yet.
2016-09-22remove SfxPoolItemArrayBase_Impl typedefJochen Nitschke2-5/+3
Change-Id: Id4d3f80b3906395838afaffb2b0d00437d17f6dd Reviewed-on: https://gerrit.libreoffice.org/29182 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-22convert SfxItemKind to scoped enumJochen Nitschke5-39/+48
reduced size because it is stored in widely used SfxPoolItem. converted 'if' chains to 'switch case' Change-Id: Id9b5e375b681c88e8c91c561abd1a50610aa4815 Reviewed-on: https://gerrit.libreoffice.org/29186 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-22tdf#53698: Cache more than 1 item in NumberFormatCodeMapperMaarten Bosmans2-55/+37
In zforlist.cxx the function SvNumberFormatter::GetPreviewStringGuess switches between the system locale and en_US in order to guess the formatting of a number. This results in poor performance, because in the created SvNumberFormat only the last used locale is cached. Caching more than 1 entries improves the load time for the document attached to tdf#53698 from 90s to 60s in case of non en_US locales. Change-Id: Id0eb4447dea6213015e2d958d8303a1e7892487a Reviewed-on: https://gerrit.libreoffice.org/29136 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-22loplugin:unusedmethods in chart2..svxNoel Grandin54-490/+13
Change-Id: Ifb6045885049733415895f58cdd911256f48323c Reviewed-on: https://gerrit.libreoffice.org/29187 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-22loplugin:unusedmethods in sc..vclNoel Grandin72-1452/+5
Change-Id: I70fcf95dfd3db05b4fd6e5cee37866f673d3afa8 Reviewed-on: https://gerrit.libreoffice.org/29183 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-22sd lok: fix pixel-to-logic conversion in DrawViewShell::MakeVisible()Miklos Vajna3-0/+56
The problem, as seen by the user is that during shape text edit, sometimes just traveling with the cursor causes invalidations, which is unexpected. What happens is sd::Window::KeyInput() invokes sd::DrawViewShell::MakeVisible(), which does a pixel-to-logic conversion, but because the map mode is in general disabled in the LOK case, nothing happens. Then a bit later aVisArea.IsInside(rRect) fails, as it compares pixel and logic units, which results in sd::ViewOverlayManager::UpdateTags() scheduling an async call to sd::ViewOverlayManager::UpdateTagsHdl(), which at the end causes a full invalidation in sd::SmartTagSet::remove(). Fix the situation by temporarily enabling map mode, so we don't detect a visible cursor area as a non-visible one. Change-Id: I6d16f24d13143dc263a89317fbc38111e652c0ac
2016-09-22KDE4 enable and handle rollover menubarJan-Marek Glogowski2-10/+11
Change-Id: Ice2657c8e8ecccb67d1b14292514a42ff37caa39
2016-09-22VCL add support for rollover menubarsJan-Marek Glogowski3-6/+29
KDE theme engines can explicitly support rollover menubars via styleHint( QStyle::SH_MenuBar_MouseTracking ). So this adds support for this feature to the vcl::Menu. Change-Id: Ica923ff2d06cfd54e548ba858b3d90f70d9c255a
2016-09-22tdf#97721 KDE4 no PRESSED state for checkboxesJan-Marek Glogowski1-1/+1
Selecting radio and check boxes is handled via QStyleOptionMenuItem::checked. Actually forwarding the QStyle::State_Sunken creates strange artifacts in all menus. Change-Id: Ia0b0864b9bec5961023b4f25315a8acf1fae4683
2016-09-22KDE4 no more progress bar flickeringJan-Marek Glogowski1-1/+2
This will always redraw the progress bar over the last one. It stops the flickering at least in KDE4 from re-painting the background, but obvously will break any transparent or alaiasing effect, if it was used. There is actually a mbProgressNeedsErase in the global settings, so actually use it when setting a new progress value. Change-Id: Ic62784da4f6d08bf0e03a9e04848a5cc687ee236
2016-09-22tdf#94172 KDE4 fix gradient toolbarsJan-Marek Glogowski1-1/+1
Bug introduced by commit 4f5fe008a3d5f0b5ddfa656299306cff9d57d802. The code was moved from ImplInitSettings to ApplySettings and somehow a not (!) got lost. Change-Id: Ie3fa4fb99d030d106aab712cd6bdafada8c6d423
2016-09-22tdf#94112 KDE4 use disabled WindowText colorJan-Marek Glogowski1-1/+1
Libre office just has a general disabled color. Instead of the general QPalette::Mid, use the color QPalette::WindowText of the palette QPalette::Disabled. Change-Id: Ie6943b455d3e6545289b241ee4ab85128f4fd7ab
2016-09-22KDE4 Switch default image color to transparent...Jan-Marek Glogowski1-9/+36
... and just fill the painted image once at the beginning. Also adapt background based on the control information from Qt4. Change-Id: I39c03b2ca779381920e2597b4bea7973fea6ae2a
2016-09-22add GAMMA test caseZdeněk Crhonek1-0/+4693
Change-Id: If8778c62ec7c88e036c86ea7cb1fb018c251235e Reviewed-on: https://gerrit.libreoffice.org/29147 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-22add VLOOKUP test caseZdeněk Crhonek1-0/+1609
Change-Id: Ia185cbf7b72ffe014b0f2a3f99bf21c0a33cee06 Reviewed-on: https://gerrit.libreoffice.org/29153 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-22Resolves: tdf#102347 configure size/expose might never come...Caolán McNamara4-22/+2
if you request a size you might not get it. This attempt dating through... commit 6dc1d2706f519d91617ac1a12fc2051d97ef98c0 Author: Caolán McNamara <caolanm@redhat.com> Date: Mon Jun 15 10:56:33 2015 +0100 another stab at tdf#91393 block paints only if the new requested size is larger than the original and unblock on explicit expose events as well as configure ones ... commit 8f324aebfb94c4b2023894121b954ad4f35eb395 Author: Caolán McNamara <caolanm@redhat.com> Date: Sun Jun 14 15:49:56 2015 +0100 Resolves: tdf#91393 autotext (etc) not fully drawn ... commit e6a1956034c98204e30b0ca40330249d6f6f8155 Author: Jan Holesovsky <kendy@collabora.com> Date: Fri Jun 12 15:36:03 2015 +0200 tdf#91301: Don't cache incomplete tabs. After introduction of the Idle processing, something has changed so that the underlying GetGdkWindow() does not update its size fast enough; even though the gtk_window_resize() is called before the Window::Erase() (that actually paints the background) etc. is all junk. I don't see the original problem of tdf#91393 or tdf#91301 anymore under gtk2 after reverting this yet anyway to see if they need another fix. Change-Id: Ide071eba279de726a9c6a80884bc9021c8914d9d
2016-09-22gbuild: remove gb_CFLAGS/gb_CXXFLAGS += -fno-omit-frame-pointerMichael Stahl8-16/+0
This did not take effect anyway because unxgcc.mk unconditionally overwrites it; see https://lists.freedesktop.org/archives/libreoffice/2016-September/075218.html Nobody knows why it was added so just remove it. Change-Id: Ib1a6d06ed8e380e63c588a72b6a65bfbeaacb924
2016-09-22gbuild: remove gb_CXXFLAGS += -mminimal-toc on PPC64Michael Stahl1-1/+0
This did not take effect anyway because unxgcc.mk unconditionally overwrites it; see https://lists.freedesktop.org/archives/libreoffice/2016-September/075218.html Change-Id: I33a2ae9aae44d974d6b5466a2d7dae61ae5cc92c
2016-09-22gbuild: gb_COMPILERDEFAULTOPTFLAGS doesn't existMichael Stahl1-1/+1
... since commit 8541943b8d08f62217e99c9d47a5f222e1fba86e Change-Id: I56b12ebd59b8387878f20d625381d3f743558a43
2016-09-22Missing "const"Stephan Bergmann2-2/+2
Change-Id: Ib0cd605cf8e71e94f4442c07300726aff1d9ce03
2016-09-22loplugin:unusedmethods unused returnsNoel Grandin12-32/+26
Change-Id: I4da3374e31d3c7407b401d66275da7f56ae83d30 Reviewed-on: https://gerrit.libreoffice.org/29178 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-22sw: Clean up forward declarationsTakeshi Abe5-9/+1
Change-Id: I02eb887101f2ebe9eb5abe8e2291f8cf5d79d2ce Reviewed-on: https://gerrit.libreoffice.org/29141 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-09-22loplugin:unnecessaryvirtualNoel Grandin6-17/+19
Change-Id: I7b1aa65a557f3855939ad8b183bba8ff656946f8 Reviewed-on: https://gerrit.libreoffice.org/29173 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-22Silence some MSVC warnings for autogenerated filesMike Kaganski1-0/+2
Change-Id: I8b4430f9f8282ef7a6b23964ca51d3444a450305 Reviewed-on: https://gerrit.libreoffice.org/29174 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-09-22sw: move LOK_CALLBACK_VIEW_CURSOR_VISIBLE to SwCursorShellMiklos Vajna3-5/+14
That's where the non-view variant is emitted, and SwVisibleCursor said visibility=false even if the cursor was expected to be visible. Also fix the test callback that checked if the payload is equal to the "true" literal, but actually the payload was a JSON. Change-Id: Ifa0e23eb274925e8ab8ef5e7c21370ad2cd22282
2016-09-22remove unused definesEike Rathke1-3/+0
Change-Id: I72eea07e775fa1987081b952523dc4e32483fc8a
2016-09-22rename GetId() to GetTablesHintId() and GetIndexHintId()Eike Rathke3-5/+5
In preparation of moving SfxSimpleHint that has GetId() to SfxHint. Change-Id: If781ba9578931d9543875ee288ce37c727bfba10
2016-09-22Use 'with open(file) as f:' to avoid 'ResourceWarning: unclosed file'Mike Kaganski1-5/+11
Removes 220 warnings from build log (at least under Windows). Requires Python 2.5+ Change-Id: I06b18b14a08f2c27528fcb009faddff081ffd54e Reviewed-on: https://gerrit.libreoffice.org/29172 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-09-22tdf#102355 Fix disabling entries via dispatch interceptionMaxim Monastirsky1-0/+1
... in ResourceMenuController based top-level menus. MenuBarManager doesn't set frame action listener for top-level. This wasn't an issue when top-level always was the menubar, but now top-level can be a popup menu. Change-Id: Ibc9116389239eb06f84a2e53b31eacc0a09d438e
2016-09-22Fix JunitTest_framework_complex:CheckXTitleLuke Deller1-12/+46
This unit test class relies on calling waitForEventIdle to wait for UI transitions to complete. On Windows this is not reliable, due to VCL's use of PostMessage (Windows message queue) to asynchronously handle some events such as focus changes. This issue causes the test to intermittently fail when the dispatcher for the action the test wants to perform (like closing the print preview) is not available yet. - Change the test code to explicitly wait for the desired dispatcher to be available - Remove the sleep which was added earlier this year to address this symptom in one location Change-Id: Id701209a28cd0c806ab0a548508d31f9f11211f5 Reviewed-on: https://gerrit.libreoffice.org/29167 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-22Fix memleak in GtkSalMenu::NativeSetItemCommandMaxim Monastirsky1-0/+1
Change-Id: Id952f3dc236d2dc2c6839ce75943bda162fabf82
2016-09-22Don't unnecessarily activate all menus in gtk2Maxim Monastirsky1-1/+2
Change-Id: I9d4b4e55673f73dd6c518bb169416958fde72a32
2016-09-22desktop: guard against nullptr frame in doc_registerCallback()Miklos Vajna1-1/+1
Change-Id: I96956d6631ed574c06df62e9b633d7e1e4d5a5f2
2016-09-22Notebookbar: separate .ui files settings for each moduleSzymon Kłos10-598/+181
* each module have own list of implementations * deleted placeholder .ui files from Calc and Impress Change-Id: Ib7d4cafbb332447e769ca753003d31e9f3025f0a Reviewed-on: https://gerrit.libreoffice.org/29143 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-20 08:10:52 +0000