Age | Commit message (Collapse) | Author | Files | Lines |
|
Allow print twips coordinates in LOK_CALLBACK_CELL_VIEW_CURSOR
Change-Id: I0373cbd2b87b4d1088af41453ab548274de6ca23
|
|
Allow print twips coordinates in LOK_CALLBACK_REFERENCE_MARKS
Change-Id: I1bf84c5aebe84ee034ac27932fa8a01d0a3ae831
|
|
when we send the message in print twips coordinates. It is important for
the client to know the exact position and coordinates to allow client
side print-twips -> tile-twips conversion when/if it is needed.
Change-Id: I6699894758886f1b5648ac9bf3c9e6ab4192c72e
|
|
Allow print twips coordinates in LOK_CALLBACK_CELL_CURSOR msg.
Change-Id: Ib9de372db46db9d462983e15fb12d58624d066f5
|
|
Change-Id: Ie8f23bd7ba8de57d7aab104add99501a54f08819
|
|
to avoid code repetitions.
Change-Id: If83b42175fb53132174fa33d169806e17a4a5cbe
|
|
and avoid some code repetitions.
Change-Id: I3e006bc8d9880f3e1ec892aa8f2423edbf9bbf14
|
|
and drop static keyword from the local functions. No functional changes
involved, just a pure refactor to aid an upcoming cleanup of
getRowColumnHeaders() method.
Change-Id: I7daafdc8f644f73d10d594cb7e0f5b25e6464ca5
|
|
if the client visible area is "close" to these limits. Also
send tile-invalidations for the new area uncovered.
** All this is done only if the flag scPrintTwipsMsgs is set.
Change-Id: I3d6b8c6aaae1eb934030c5bdbc1094dc8be16a9f
|
|
if the new feature flag scPrintTwipsMsgs is set.
Change-Id: Ia36b9f3835115fb6f30e4e8f57d5d7a1b57df609
|
|
This is to notify the clients about changes in current sheet's geometry
data.
Change-Id: I478d2e646606320399905d7b15881a165a53146d
|
|
for conditioning all changes needed to allow calc messages in print
twips coordinates.
Change-Id: I407b4d4d4e0a1dfb2c4339cafa10b368b437c82d
|
|
Change-Id: I92cead8212f30d0cc9b811be21b6639830e84fa4
|
|
while encoding the information as string.
Change-Id: I890efc4a9b60125c68c663a69569864308fdbdcf
|
|
(Testing of groups/ouline case is not included)
Change-Id: Ia53e5489c376d2d86461a9fd3db4f5b7dc963b99
|
|
ITiledRenderable::getSheetGeometryData(bool bColumns, bool bRows,
bool bSizes, bool bHidden,
bool bFiltered, bool bGroups)
and implement it for the Calc derivation (ScModelObj).
The aim is to use it actively in LOOL instead of the interface:
ITiledRenderable::getRowColumnHeaders(const tools::Rectangle& /*rRectangle*/)
This is used by the LOOL to fetch the sheet geometry data for just the
current view-area in the clients, so LOOL queries this everytime some
client's view-area changes.
Like the existing interface, the new one will provide all 'kinds' of
sheet geometry info [col/row sizes(twips), hidden/filtered and
grouping]. But the difference is, it generates data for the whole sheet
(not view-area specific). So the method need not be queried every time
the view area changes in the LOOL clients, and more importantly it
enables the clients to locate any cell at any zoom level without any
further help from the core. This means core needn't send various
client(zoom) specific positioning messages in pixel aligned twips. It
just can send all positioning messages in print twips uniformly to all
clients.
Change-Id: Ib6aee9a0c92746b1576ed244e98cb54b572778c0
|
|
The calc tiledrendering unit tests that use view-data's nPPTX directy or
indirectly are failing in pristine master build (at least in my setup).
When creating a document for each test via createDoc(), the docshell has
an output-factor != 1.0 by default (at least for these unit-tests). We
do call ScModelObj::initializeForTiledRendering() soon afterwards which
does the right thing by setting it back to 1.0 (indirectly), but nPPTX
value in view-data is not updated and stays wrong.
I haven't had a chance to investigate more why this happens only in my
setup, but as an interim fix, an explicit call to RefreshZoom() is added
to createDoc().
Change-Id: Ia7044381fa203e03c56f8a2589140c634347fe66
|
|
...to 1d0bc2139759f087d50432f8a2116060676f34e1
"use std::experimental::source_location in uno::Exception"
Change-Id: I2b18dbae89c6f219edacba5d147ea265ca83725e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94422
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
... to configuration and UI.
The new default is ODF 1.3 Extended, which is now ODFVER_LATEST and
stored as value "3" in configuration.
Adapt a few places related to DocumentDigitalSignatures etc. to new
default.
Change-Id: I420da4f7787cc864c6bd88470d61b146b9399aa1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93177
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
Remove everything that's in ODF 1.3; it's no longer necessary and some
of it requires overriding named patterns from the schema so that has to
be removed.
Change-Id: I716957dc8ccc3fa54fc69c96d8a3b577a5c7e126
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93176
Tested-by: Michael Stahl <michael.stahl@cib.de>
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
When direct character formatting defined in w:pPr/w:rPr
overwrites some character style properties (character
style defined by w:pPr/w:rPr/w:rStyle), empty paragraphs
lost such direct formatting, resulting for example,
different page layout by different height of empty
paragraphs. Also text of that originally empty paragraphs
got different formatting during typing.
Co-authored-by: Justin Luth <justin_luth@sil.org>
Change-Id: Ic7b3a73d4d7364993cc58073c9e1a09a2711d1b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94308
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
In the model, changing a tab page's title or enabled/disabled
status is done via methods 'XTabPageModel.setTitle' and
'XTabPageModel.setEnabled'.
Changes to the title and enabled/disabled status are
propagated to the tab page container containing the
tab page (s.a. 25c692c2a94ab83c2c859ac5ab334b62ac8b825e
("ControlModelContainerBase: Use property for enabled status",
2020-05-15)).
Make 'VCLXTabPageContainer' derive from 'XPropertiesChangeListener'
and implement the 'propertiesChange' method defined in that
interface to handle property changes for the tab pages and have
'UnoControlTabPageContainer' forward 'PropertyChangeEvent's
to its peer so they can be handled there.
This way, changes for those tab page properties via UNO
are now properly updated in the UI as well.
Change-Id: I6fa1fadf781575c4ad1d066aed9c3a651b10869d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94402
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
0 line width is the thinnest possible line width,
but without its explicit export (a:ln w="0"), shape
outline was imported with 0.75 pt line width by MSO.
Co-authored-by: Balázs Regényi
Change-Id: I40f7aefe6358bebe9a3853fe3e7d6faa170bc34c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93968
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
|
|
only an outputdevice in this editeng-in-a-widget case
Change-Id: Idf054872a48befba652012cd511e4f9df4437166
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94415
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I7c5ad1673776fd0991a61b4c9f9a947e42764f44
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94414
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Follow-up to 5eda583443cd0ec323e925395ea734c20fdbcf13
Change-Id: Icde98be0a8dccc58ca7c7c260e387bafb7f05b46
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94412
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
ODF 1.3 schemas are supported; only thing missing is the MIME-type
for the master template document.
(actually we don't need this in the LO build because we use custom
schemas anyway but let's test if there aren't any problems with
the validator itself)
Change-Id: Ic0a34f5e2551603e543504ba01c82e2fcacfc7f8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93782
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
META-INF/manifest.xml[8,137]: Error: element "manifest:start-key-generation" was found where no element may occur
The problem is that in the schema, manifest:start-key-generation
precedes key-derivation but LO writes it in swapped order.
This is apparently a workaround for a bug in OOo < 3.2 ODF import and
specific to ODF >= 1.2 because the element didn't exist in ODF 1.1; as
it turns out we don't care about OOo < 3.4 being able to load encrypted
ODF 1.2 documents anway since commit
0b7c3b7d9fa71f59eed75c3e80e5e12245c5e1c5 "tdf#114939 officecfg,sfx2:
always use AES/SHA256 in ODF 1.2".
Change-Id: I3b62e3eba719f13e39fb24bf9792f764b24ccaeb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94413
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
... but remove unintentional changes from manifest-schema.
Change-Id: I4d8de0fb896fcebed7cb0553a7a7c8cec6491d39
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93175
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
Tested-by: Jenkins
|
|
...in case it contains addtional arguments like -fsized-deallocation besides the
compiler's pathname, which would have caused failures like
basename: extra operand '-fsized-deallocation'
Try 'basename --help' for more information.
dirname: missing operand
Try 'dirname --help' for more information.
dirname: missing operand
Try 'dirname --help' for more information.
(printf reuses the format operand to satisfy all argument operands, so that \n |
head hack is needed to get just the first one, assuming that CXX did not contain
any carefully crafted escape sequences inside that first argument that would
expand to a newline when printing. Also, this does not cater for leading
var=value or (even more far-fetched) redirection words in CXX, but the original
code did not, either.)
Change-Id: Iae4d1a0ae3b67cc5e8c7a8a36258230f8ab8fd70
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94406
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I66c0d8fc4d307c376af20673e756944626df907b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94411
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
|
|
Change-Id: I98319183a7bd9abb9ed6b1dd9f85cf00ee701fc5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94405
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
|
|
Change-Id: I8796c0937fe4b046d9a13e2e50368e45e0e45611
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94404
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I95391ef6ed5154efc2c7705dde22afa59da24a70
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94403
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ic5254e402d153a13c29928b59738cbe1603d0139
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94399
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
This does not actually ensure everything is built before tests
are run, so this doesn't fix the test failures it was intended to fix.
This reverts commit 4054a30e2b2fa254dfb20718ce757ceb2f638fd5.
Change-Id: Ie0fb9f98f90aeb6fc3ecf373efe9dadb6e2a5c39
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92589
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
It's not enough to check the paint area. because it's
in logic units, which does not change by zooming.
Change-Id: I9ee51c03e7edc2c70d91d6ef6dbaaae8c2c7beff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94400
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
Change-Id: Ief02e5d5284b0cbad26b04c0a282dccfee577b90
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94398
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Pitäkää tunkkinne.
This reverts commit 1f6b7678d52e1bf9092e3ce2cf7b7c4ffdcb2ba2.
|
|
Patch significance :-
1) Added a new tab "Styles Inspector" at the side bar
2) Added the "Character Styles" properties in the inspector
Change-Id: I717f0a555d9c90f833c61b641c8eba53f93d4655
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93909
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Margin (left, right, inner, outer) alignments of VML shapes
weren't handled.
Co-authored-by: Attila Bakos (NISZ)
Change-Id: I5f8ece64707a2d699b71d6151887db05ac39c4f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93723
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
In a build via ssh, the test hangs while trying to connect to Evolution
Data Server that presumably isn't running:
1 in g_cond_wait () at /lib64/libglib-2.0.so.0
2 in e_flag_wait () at /lib64/libedataserver-1.2.so.24
3 in e_client_wait_for_connected_sync () at /lib64/libedataserver-1.2.so.24
4 in e_book_client_connect_sync () at /lib64/libebook-1.2.so.20
5 in e_book_client_connect_direct_sync () at /lib64/libebook-1.2.so.20
6 in connectivity::evoab::(anonymous namespace)::OEvoabVersion38Helper::createClient(ESource*) (this=0x912d150, pSource=0x90c0660) at connectivity/source/drivers/evoab2/NResultSet.cxx:480
...
35 in SwMailMergeConfigItem::GetResultSet() const (this=0x8f10b30) at sw/source/uibase/dbui/mmconfigitem.cxx:875
...
63 in SwMailMergeWizard::SwMailMergeWizard(SwView&, std::shared_ptr<SwMailMergeConfigItem> const&) (this=0x8f0f340, rView=..., rItem=std::shared_ptr<SwMailMergeConfigItem> (use count 3, weak count 0) = {...}) at sw/source/ui/dbui/mailmergewizard.cxx:60
Change-Id: I1b43b05509f4e293ce1f00044a05f045bf975ce4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94364
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
So it can be removed and client code can be adjusted accordingly.
Change-Id: Ib3ca86cf147387fdbd646eb46077eff89d4c56f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94397
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
tdf#92472 DOCX import: fix checkbox size set by direct formatting
at beginning of paragraphs.
Follow-up of the commit 22ad4d69d771708f28a2d9e137cfd43ac846cf3a
(tdf#121045 DOCX import: fix checkbox size in table).
See bt here:
https://bugs.documentfoundation.org/attachment.cgi?id=160936
Change-Id: I9868679a46de54519250ab6f9d501a04a414b88e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94385
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
Change-Id: I998ffadeef2232366bb5d2fdeb5632e799366038
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94127
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Clang and gcc have moved this out of experimental and into std::source_location,
but only in their very latest releases.
Change-Id: I9d9d9155788ee4240455ac4628b298dface4ad24
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93868
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Make --with-help mean the same as --with-help=html to avoid generating
such unintentionally.
Change-Id: Ie53b3604f53c3301cb196b2239dce6f0c08acbd3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94145
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
|
|
Change-Id: Icc1b53f068b94ff3b3f26b144f366344dcbff2ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94345
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: Ic7799492a709c53324780d44040034a83ef854a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94344
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: Ica4400cdb1e5c24dfb302426548ac976da802c74
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94343
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|