summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2018-06-25Use Tango as default icon theme when Breeze is not includeddistro/collabora/lov-6.0.5Tor Lillqvist1-0/+6
Change-Id: Id81c2355abfbdf29599842f06ad8b3c754db708b (cherry picked from commit d62acf55f17f5b1213f150fb4fb0fd2e8bb0b9b0) Reviewed-on: https://gerrit.libreoffice.org/56418 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-06-20Version 6.0.5.2, tag libreoffice-6.0.5.2libreoffice-6.0.5.2Christian Lohmaier3-0/+0
Change-Id: I6a23b0494bc7ce031734ece9eaa1b9a08f766782
2018-06-20bump product version to 6.0.5.2Christian Lohmaier1-1/+1
Change-Id: Iede9f64a62c3f78d35b1cb15b095504d9716bc4b
2018-06-20tdf#117827 Restore Synchronize labels in templateLaurent BP1-0/+0
Correction of de14f0487118d8ea15db54d94c44d7bd28833c82 Update Businesscard-with-logo - restore "Synchronize labels" function - restore links that need to be updated at the begining - change Tab for name and profession to center Tab - change "Sektsioon" to "Section" - change "Paneel" to "Frame" - change "Pilt" to "Image" Change-Id: If3123ed76faf1055f539dc9f47051696f3f1b40b Reviewed-on: https://gerrit.libreoffice.org/55243 Tested-by: Jenkins Reviewed-by: Laurent BP <laurent.balland-poirier@laposte.net> (cherry picked from commit e92e240693ca13ac2ee38da3518b12f57d3974db) Reviewed-on: https://gerrit.libreoffice.org/55906 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-06-19tdf#114736 no need to call AdjustLayout hereTamas Bunth1-7/+0
Change-Id: Iae8c953155d46e53cffdf3483e3b4b95157719f6 Reviewed-on: https://gerrit.libreoffice.org/48761 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/55795 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-06-19Resolves: tdf#118073 one leading 0 is significant for 0.Eike Rathke1-1/+1
Regression from commit 9a6527a98fb968b3fe6bc293ff7520a9480d43d0 CommitDate: Mon Jun 27 21:57:52 2016 +0200 stringToDouble() do not parse separator without digit as 0.0 Change-Id: I9d90aedc324ef0938297224297d89817e3fd1e90 Reviewed-on: https://gerrit.libreoffice.org/56028 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 5c0783cecb0b141885a25ca26220614ad3125f8e) Reviewed-on: https://gerrit.libreoffice.org/56047 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-06-19tdf#116552 restore copy on focus and jump focus to sourceCaolán McNamara4-0/+29
This is surely an utter abuse of focus and an a11y disaster, but it used to work this way. Change-Id: I265a2bafbc2cdd17ff4a5b7c2805def63c510d5c Reviewed-on: https://gerrit.libreoffice.org/55670 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-06-18Updated coreChristian Lohmaier1-0/+0
Project: translations d828c52dac496d84e64186752f3a77a65c8d0513 update translations for 6.0.5 Change-Id: Ib6a28251fa103419f503aa9b0fdb18439538d41a (cherry picked from commit ef368dd67d17898df7f837b56350c3b5deaeb8aa)
2018-06-18Fix CppunitTest_xmlsecurity_signing with system-xmlsec 1.2.26Miklos Vajna1-14/+37
Swap the order of the default and custom callback registration, since the order of lookup is now reversed since <https://github.com/lsh123/xmlsec/commit/968646fb9b8428174a112fce2f08b1ec89d0ed97>. Thanks Tomas Chvatal for reporting this. (cherry picked from commit 576f899811a22e83b6fb6a120c8da303b1f4cac1) xmlsecurity: check for the libxmlsec version runtime, not build-time For the general benefit of --with-system-xmlsec usage scenarios (where LO may be built against an old version of xmlsec and run against a new one). (cherry picked from commit bc4e43dd926bbe6f5315b5c372770ac8c7222177) Change-Id: I60a347454701a679db4ccd8924a723a236d5edff Reviewed-on: https://gerrit.libreoffice.org/55462 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 3d532502c9a17049bdd383a3d5c56005222331b7) Reviewed-on: https://gerrit.libreoffice.org/55948 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2018-06-18Handle English vs locale's General keyword, tdf#33689 follow-up, tdf#107867Eike Rathke2-12/+41
Caller of ImpSvNumberformatScan::GetKeyWord() needs to know if English or locale's keyword was found and act on it. Pointed out by an assert when attempting to copy "STANDARD" length characters (8) from "General" (7), which doesn't harm because when not in debug it copied the terminating 0-character. However, the keyword name also needs to be replaced for the locale's resulting format code. Change-Id: Ia5211b307ea44c1ba9c2b86786368355c570d4a2 Reviewed-on: https://gerrit.libreoffice.org/55293 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit bfe6e9ecb18e8a3d9da368a1eb48e807ab9041cf) Reviewed-on: https://gerrit.libreoffice.org/55299 Reviewed-by: Laurent BP <laurent.balland-poirier@laposte.net> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-06-18Resolves: tdf#118161 use ScCellIterator::isEmpty() for COUNTA()Eike Rathke1-1/+1
... instead of hasEmptyData() that considers inherited svEmptyCell as well. Effectively a regression from commit 0e9e3be6f51436c1e5bf1481a434a85e334c09ea CommitDate: Tue Mar 26 01:41:17 2013 -0400 More on ScCellIterator usage migration. that started to include mpCurFormula->IsEmpty() in ScCellIterator::isEmpty() which later was renamed to ScCellIterator::hasEmptyData() and isEmpty() introduced for real empty. Change-Id: Iec97d58080016c28bc9a7e47d056e4d301263928 (cherry picked from commit cfe2e4eb835c06b24adabd60c7a3fddbd3f4dbc9) Reviewed-on: https://gerrit.libreoffice.org/55805 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-06-18tdf#118068 InsertionIndicator should be temporaryCaolán McNamara1-0/+4
its original use is during a drag/drop operation so its expected to be in use just for a temporary scope, so End after Start Change-Id: I3efdc4079ef7e1466b49e027fed0698715b5fd58 Reviewed-on: https://gerrit.libreoffice.org/55667 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-06-18vcl: refresh font cache only on real changeAshod Nakashian4-7/+8
GTK3 emits way too many style-updated, which triggers font cache updates. The avoidance of unecessary font cache updates was first implemented in 29c55564. Unfortuantely, it seems that the current font-options was never set as last-seen font-options, so still to many fonts-changed were emitted Change-Id: I01a47d4d7fb033e335b1a49ffa6e1bb98f7fd28d Reviewed-on: https://gerrit.libreoffice.org/55668 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-06-18forcepoint#45 object may not be a EMFPPenCaolán McNamara1-1/+1
Change-Id: Ifb5c17e13faf6e9d246e1668ef7916957a5296b6 Reviewed-on: https://gerrit.libreoffice.org/55680 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-06-18Resolves: tdf#116527 backport min value setting for print mailmerge rangeCaolán McNamara1-1/+17
Change-Id: I7934fa72956ba5b2a32a45f6eedaf7f4f447449b Reviewed-on: https://gerrit.libreoffice.org/55669 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-06-15Restore binary compatibility for ClassLoaderFactoryStephan Bergmann4-9/+6
As discussed in the mail thread starting at <http://mail-archives.apache.org/ mod_mbox/openoffice-dev/201806.mbox/%3c651c8fee-b467-421c-eae1-a8710f41692c @apache.org%3e> "Just a little side note on the scripting framework ...", external code that uses the Java class com.sun.star.script.framework.provider.ClassLoaderFactory stopped working because LO changed that class in binary (and compile-time) incompatible ways over time. The class is not listed at <https://api.libreoffice.org/docs/java/ref/index.html> (and neither at <http://www.openoffice.org/api/docs/java/ref/overview-summary.html>), so it was not considered part of the stable URE interface. But it is apparently used by external code, and it indeed seems to make sense that it is used by external code that implements scripting providers. (A follow-up commit should therefore mark the class as part of the stable URE interface. I keep that separate so that it is easier to backport this functional fix.) With ScriptProviderForooRexx.oxt from https://svn.code.sf.net/p/bsf4oorexx/code@r589 installed in LO, "Tools - Macros - Organize Macros - ooRexx... - My Macros - Create... - Library1 - OK - Create... - Macro1 - OK - Edit" failed due to > warn:cui.dialogs:21768:21768:cui/source/dialogs/scriptdlg.cxx:740: Caught exception trying to invoke N3com3sun4star3uno9ExceptionE msg: [jni_uno bridge error] UNO calling Java method invoke: non-UNO exception occurred: java.lang.NoSuchMethodError: com.sun.star.script.framework.provider.ClassLoaderFactory.getURLClassLoader(Lcom/sun/star/script/framework/container/ScriptMetaData;)Ljava/lang/ClassLoader; > java stack trace: > java.lang.NoSuchMethodError: com.sun.star.script.framework.provider.ClassLoaderFactory.getURLClassLoader(Lcom/sun/star/script/framework/container/ScriptMetaData;)Ljava/lang/ClassLoader; > at com.sun.star.script.framework.provider.oorexx.ScriptEditorForooRexx.edit(ScriptEditorForooRexx.java:305) > at com.sun.star.script.framework.browse.ScriptBrowseNode.invoke(ScriptBrowseNode.java:200) cae57d2e588a4b5a104171e022b00abcc1605775 "ClassLoader->URLClassLoader" (which this commit reverts) had changed the return type of the two getURLClassLoader overloads from ClassLoader to derived URLClassLoader (and ultimately only for cosmetic effect; it was leftover from a previous attempt at fixing a Coverity issue by using URLClassLoader.close(), but which is only available in Java 1.7, so the attempt had been reverted). That caused the above failure. And 68cd011c907d00493bf2bfde531c1e244819596b "java: reduce scope, make some methods private" (which this commit also reverts) had changed the second getURLClassLoader overload (which is not called in the above scenario) from public to private, which is also a binary-incompatible change. Other commits removed throws clauses, which is only a compile-time issue but not a binary-incompatible change. I left those changes in for now, but if need be they could also be reverted. Change-Id: I98f533d88c7c1580956c3c281e72a1c78fa3f56f Reviewed-on: https://gerrit.libreoffice.org/55874 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-14update creditsChristian Lohmaier1-1669/+1720
Change-Id: I7012888221c01140b5e93042635a05e453f8470e (cherry picked from commit 3a3bf63bfb10e97e045a9b7cf1f357930b668ac2) (cherry picked from commit 0503090e47ffe5d09a26ee7a20134decf7ae1328)
2018-06-14Updated coreChristian Lohmaier1-0/+0
Project: translations d6b34ab0d7d0ee3e1334f21b84dae5d065575231 update translations for 6.0.5 rc2 and force-fix errors using pocheck Change-Id: Icc79a9bc1066fae8003a75c1eb5041b884607ba8 (cherry picked from commit f36f376a6ecb26fb91315b06c8ed60ea99f055b6)
2018-06-12Fix build with GLM 0.9.9.0, tdf#118070Louis Sautier1-0/+6
One of the test files was forgotten in 953c4add8fd76d88f49a81ae4c21a1fdcc007e57 Change-Id: I0315433c688ff7edb2ba599bbef203cac9de3022 Reviewed-on: https://gerrit.libreoffice.org/55554 Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Rene Engelhard <rene@debian.org> (cherry picked from commit 5f1bf6598b5725ad1e50ae9f7ec7524cc8a834fa) Reviewed-on: https://gerrit.libreoffice.org/55556 (cherry picked from commit 4731827db269a11b8f12e22076a2f3c297298450) Reviewed-on: https://gerrit.libreoffice.org/55557 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 3a2505715f91cc871004aad064f11516d0027ed6) Reviewed-on: https://gerrit.libreoffice.org/55639 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-05-31bump product version to 6.0.5.1.0+Christian Lohmaier1-1/+1
Change-Id: I508f0a499faa87d6d4e22ebba4cbddf2059bfefb
2018-05-31Branch libreoffice-6-0-5Christian Lohmaier4-1/+1
This is 'libreoffice-6-0-5' - the stable branch for the 6.0.5 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 6.0.x release, please use the 'libreoffice-6-0' branch. If you want to build something cool, unstable, and risky, use master. Change-Id: I53c242726ee31d2755f7abffaef772a831a1c945
2018-05-31tdf#38225: update API name when renaming using a base class refMike Kaganski3-49/+114
... but don't update it in case it's a predefined API name Change-Id: I20075a4e085bdeab8374860c16e7eb2a72772c33 Reviewed-on: https://gerrit.libreoffice.org/54879 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/54890 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-05-31tdf#117864 TransferableHelper::GetSystemClipboard requires a focus windowCaolán McNamara2-1/+6
Change-Id: Ibd9b9218cf12e80db1fc9a70bdbab38d3df950f7 Reviewed-on: https://gerrit.libreoffice.org/55075 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-05-30tdf#111988 Bump OSX version in READMEXisco Fauli1-1/+1
Change-Id: I41a5be165af21c197c4f9d4f40f0ff27c80a7168 Reviewed-on: https://gerrit.libreoffice.org/55061 Reviewed-by: Sophia Schröder <sophia.schroeder@libreoffice.org> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 272577e68abe764ab05fe227e3cd7d185c59a900) Reviewed-on: https://gerrit.libreoffice.org/55092 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-05-30Resolves: tdf#117819 append trailing '0' as needed before separator insertionEike Rathke2-6/+26
To insert separators, literal strings between digits and other, the formatter operates backwards on the string obtained from doubleToUString() cleaned of the decimal separator. The number of decimals returned by doubleToUString() may be less than the decimals of the number format as entered by the user, which lead to separators inserted at wrong positions. This wrong behavior was triggered respectively made more obvious by commit 0f6203edf74832f84d8263d7a544d679203a4efc CommitDate: Wed Jan 13 14:47:57 2016 +0100 tdf#96918 display accurate integer double values up to (2^53)-1 which for integer values returns at most 15 decimals ('0' in this case). Before operating on the decimals' part ensure that the number of decimals matches the digits requested, and if shorter append trailing '0' characters for the required amount so the separators (and other strings) are inserted at the correct positions. Change-Id: Ic02652699ea7d6fae3b2b3348f6f7d183319e043 Reviewed-on: https://gerrit.libreoffice.org/55039 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 8b43f58891d4b422a8934050d839b0c2c1e3a18a) Reviewed-on: https://gerrit.libreoffice.org/55060 Tested-by: Jenkins <ci@libreoffice.org>
2018-05-30tdf#116420: Windows: Test if a filepath redirects to a WebDAV resourceMike Kaganski4-1/+114
In Windows, filesystem redirectors can map WebDAV resources to UNC paths, or to drive-based "local" paths; so a WebDAV URI of the form "http://WebDADServer/root/directory/File.ext" may be accessed using "\\WebDADServer\root\directory\File.ext" or "Z:\directory\File.ext". When using these paths, failure to create a lockfile aside the opened document should not be considered an error; so this patch checks for this. Regression from commit 6ca3b3648e25ae9d4d2d29a0df83349198ec3f5e. Change-Id: I1de55b66447dc91d22b6d2b5b121de96bf32e4ee Reviewed-on: https://gerrit.libreoffice.org/53070 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 642a49e8d3006d000bc6c58def34d4e96764c6cc) Reviewed-on: https://gerrit.libreoffice.org/54925 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-05-30Updated coreChristian Lohmaier1-0/+0
Project: translations 302381e4b2c30c3ed9d6194205a67f8dbd8da48b update translations for 6.0.5 rc1 Change-Id: If737c9f1a251608a0413d63a6309be1a5f5a371a
2018-05-29Updated coreKruno1-0/+0
Project: dictionaries 7da396b70265569b851a1c2327e7dcf757e3f936 Update Croatian dictionary to version 2.1.1 Change-Id: I8425ab128d04d428ccc99cb6c8abe2635292f143 Reviewed-on: https://gerrit.libreoffice.org/53579 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-05-29forcepoint#43 endless update ole2 preview recursionCaolán McNamara1-1/+11
Change-Id: I7a6a52d2ea63f840a8a1800fdf7039b1e7b24cdc Reviewed-on: https://gerrit.libreoffice.org/55004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-05-29tdf#117850: Just call _Exit() in our applicationWillTerminate:Tor Lillqvist1-0/+3
Sure, it is just a workaround, but a very effective workaround. Change-Id: Id0daff048a27dae5cf8fb5e0e949c5b21e03fc86 Reviewed-on: https://gerrit.libreoffice.org/54924 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit aa81a086bd3dcd7d6b830951619f310bd0aff30c) Reviewed-on: https://gerrit.libreoffice.org/54995 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-05-29tdf#113143 PDF export: fix mis-scaled JPGs on Impress note pagesMiklos Vajna3-65/+114
This is really similar to commit 4c2172a3e973bc6351107a3a1b554c77b40b75dd (tdf#106702 PDF export: fix missing images from Writer headers/footers, 2018-05-22) just this one is about the size of the output rectangle for JPG content, while the previous problem was about the position of them. Also extract PdfExportTest::exportAndParse() from the last two tests to avoid duplication. (cherry picked from commit 89dc667cebfec5315f0c0361e49d759e88458689) Change-Id: I9812924d505e9fdaca2a95b4990e7aaa5e44fd7f Reviewed-on: https://gerrit.libreoffice.org/54989 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-05-29forcepoint#42 check available str lengthCaolán McNamara1-1/+1
Change-Id: Ie476968ddaa4c3e5475ae9aa6133e7aba38d5975 Reviewed-on: https://gerrit.libreoffice.org/54978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-05-29forcepoint#41 null derefCaolán McNamara1-4/+7
Change-Id: I16e9e083811c6e14861da1ba1df7d46e8c8771d7 Reviewed-on: https://gerrit.libreoffice.org/54974 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-05-29forcepoint#40 null derefCaolán McNamara2-4/+4
presumably since commit 0098bee792c3e208ea4f6ef1c676958d3f4cd207 Date: Thu Sep 21 06:48:09 2017 +0200 tdf#112501: Pivot table: popupbuttons are placed on wrong cells Change-Id: I5413c0ba06fca25cb22256a20ef9640767dd9e50 Reviewed-on: https://gerrit.libreoffice.org/54970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-05-29tdf#117628 crash after closing media player with X11 backendCaolán McNamara2-7/+6
Change-Id: I812da5ddf7343573f93ea64e592442edb31cad2d Reviewed-on: https://gerrit.libreoffice.org/54912 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-05-29tdf#115582 Correct coordinate usage for sc's ::ArrayArmin Le Grand1-6/+15
In ScOutputData::SetCellRotations() eventually existing CellRotations are added to the svx::frame::Array data that gets created for repaint. This used the wrong coordinate calculation, thus in some cases the repaint of rotated Cells failed. Change-Id: Ib5df8576e8c9404d717d5dcc5662aa04b82cf959 Reviewed-on: https://gerrit.libreoffice.org/53171 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> (cherry picked from commit 0185e65bcd73dbad2205a39369e1e06b33a2ca51) Reviewed-on: https://gerrit.libreoffice.org/54922
2018-05-29tdf#117172 - Image context menu Save fails to do anythingMarco Cecchetti1-0/+7
Change-Id: I5c0980d85ef5ed050bfafbc368576c5ad72a80a7 Reviewed-on: https://gerrit.libreoffice.org/54359 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 796bee47e90efee7c076f6acdc2a95004ed081d0) Reviewed-on: https://gerrit.libreoffice.org/54931 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-28Updated coreLászló Németh1-0/+0
Project: dictionaries 37c3e3924d33f29dbff7fb3dba40b36a694c6792 Hungarian dictionary v1.7 Extend Hungarian dictionary with boundary data for compound words and for disambiguation of digraphs to fix incomplete and bad Hungarian collate, sorting and hyphenation rules in the future. Other minor fixes (*idegenszó -> idegen szó, *periférikus etc.) (cherry-picked from commit e90e83b23b6ace35349fc2b3e65bd2d69c80ddd8) Reviewed-on: https://gerrit.libreoffice.org/54480 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org> Change-Id: I3278801ac875f2d33fd5dc62efc43a9a81194734 Reviewed-on: https://gerrit.libreoffice.org/54747 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-05-28tdf#117729 add Frisian (fy) UI langaugeChristian Lohmaier3-0/+8
Change-Id: I46f75e969b1252a95118888507c116f44578dfbd Reviewed-on: https://gerrit.libreoffice.org/54699 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit f8fb04d0af7b1d21b8638e92922d0965e507c5d9)
2018-05-28Updated coreChristian Lohmaier1-0/+0
Project: translations b1dbd807900728ddd68a7b03ea58a5ce43717f6f add Frisian translation Change-Id: If5b9e5bf1f924e32b8fd0d6bd4c078e8fdb3f26f
2018-05-28tdf#117601 a11y crash after merging cellsCaolán McNamara3-4/+16
this is similar to tdf#87199, in this case the accessibiles for the merged cells are not visible so not removed when their frame is deleted, but remain in the cache pointing to invalid frames. Change-Id: Ibc5b9f27541683b8f3604839fa3d1431380a4039 Reviewed-on: https://gerrit.libreoffice.org/54903 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins <ci@libreoffice.org>
2018-05-27tdf#104086 cui: enable OpenGL when ignoring its blacklistMiklos Vajna2-0/+10
"Ignore OpenGL blacklist" is called "force OpenGL" in the code, so it make sense that OpenGLHelper::isVCLOpenGLEnabled() returns true in that case. But the UI suggested that enabling ignore doesn't enable OpenGL itself. Fix this by auto-checking the parent UI widget when enabling the blacklist. (cherry picked from commit 8118a5d2eb1524768784adc0b143b8cc1b9f3f61) Conflicts: cui/source/options/optgdlg.cxx Change-Id: I16bec69aebd645858260850f15ea8e687566fd0e Reviewed-on: https://gerrit.libreoffice.org/54763 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-27tdf#106702 PDF export: fix missing images from Writer headers/footersMiklos Vajna6-24/+96
Position of an image is determined by the relevant bitmap scale metafile action when recompressing images. The same position was determined by PDFExtOutDevData "meta" info when not recompressing images. This second rectangle was never correct for images repeated in Writer headers/footers on non-first pages: the position was relative to the page, while PDF export sets the map mode (origin) of the output device during export, so such positions are expected to be absolute ones. The root of the problem seems to be that header images in Writer are both repeated (as the user sees it) and unrepeated (as the doc model sees it), and by the time we want to get its position, we only see the unrepeated SdrObject. Fix the problem by using the correct position from the scale action and not from PDFExtOutDevData if possible. (Also give up on running CppunitTest_vcl_pdfexport in the non-pdfium case, most of the tests there do require pdfium anyway, and the growing ifdef forest in that file just made it hard to read the code.) (cherry picked from commit 4c2172a3e973bc6351107a3a1b554c77b40b75dd) Conflicts: vcl/Module_vcl.mk vcl/qa/cppunit/pdfexport/pdfexport.cxx Change-Id: I31c14d4bd223b2804859982542ebd6d5f9abd312 Reviewed-on: https://gerrit.libreoffice.org/54690 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-27tdf#117505 RTF export: fix incorrect header distance for first/follow pagesMiklos Vajna5-1/+26
In case the first and the follow page format has different header distances, the DOC and DOCX import work with the distance from the first page format when they take the last item from the MSWordSections container at the end of the export. RTF writes section info before the document content, and in case there are separate first and follow page formats, then we work with the follow format since commit 20a53cb9e9c7b797c091fe6ac6a34dfb28c61304 (INTEGRATION: CWS limerickfilterteam08 (1.16.32); FILE MERGED, 2003-09-01) as a fix for i#13107. There is no perfect solution here, the sw doc model can store different header distances for first and follow pages, while Word works with a single distance. But RTF/DOCX/DOC import puts the relevant header distance to the first page format and DOCX/DOC export reads the distance from there, so be consistent and do the same in the RTF export as well. This means the DOCX import -> RTF export -> RTF import sequence from the bugreport will result in a correct header distance. (cherry picked from commit 5956828c88501ef1366e60010b05053a8e1e642e) Change-Id: I3f1fe3080360702c41d680b8785cc3602e74685e Reviewed-on: https://gerrit.libreoffice.org/54697 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-27tdf#117821: fix copy-paste wrong control typeJulien Nabet1-1/+1
Since 5ad8376d1698026ccab0634605fdb17ea3c59f3a Resolves: tdf#111080 framework user of convert menu needs action names set 2017-08-08 Change-Id: I2ec8358005e335941bd1c2530f30ce696d3e808f Reviewed-on: https://gerrit.libreoffice.org/54865 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 1e9e01dff0a8d65bb10d5a886cca7899b43979da) Reviewed-on: https://gerrit.libreoffice.org/54871 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-05-25fix variable nameDavid Tardon1-1/+1
Change-Id: Ie3eef59c934f5fe4146a911e4ee652457b94edd8 (cherry picked from commit 8978fdf58a403aa62e04d47e65cd799740e6b909) Reviewed-on: https://gerrit.libreoffice.org/54807 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-24external/python3: Drop nis.cpython-*m.soStephan Bergmann1-1/+0
At least Fedora 28 glibc-2.27-8.fc28 no longer provides the nis development headers and libraries. (It only still contains some binaries for backwards compatibility, in the libnsl sub-package: "This package provides the legacy version of libnsl library, for accessing NIS services.") There is probably no real need to have nis.cpython-*m.so contained in external/python3/ExternalPackage_python3.mk (it probably just happened to build fine when that list was originally created, so was included). Change-Id: Ic6128fd872432005c0ded76640c5b56781ca69a1 Reviewed-on: https://gerrit.libreoffice.org/52535 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 93e6a823bd8543d30621769c7b34d6261ea5cb01) Reviewed-on: https://gerrit.libreoffice.org/54685 Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-24apparmor: allow also /usr/lib{,32,64}/jvm/**/bin/javaRene Engelhard1-0/+1
since /usr/lib{,32,64}/jvm/**/jre/bin/java doesn't exist since OpenJDK 9 Change-Id: Ic9c052a756ba4a93595595da98148ff22169d333 Reviewed-on: https://gerrit.libreoffice.org/54754 Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Rene Engelhard <rene@debian.org>
2018-05-23deb#899380 apparmor: fix gpg encryption hang trying to lock random_seedRene Engelhard1-0/+1
Change-Id: Ib9fb7652922dcc8364567953d17d7cae8ad170a7 Reviewed-on: https://gerrit.libreoffice.org/54726 Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Rene Engelhard <rene@debian.org> (cherry picked from commit 8615efe611abe8654e643e1ccbc0dc8f52d2e0b0) Reviewed-on: https://gerrit.libreoffice.org/54731
2018-05-23Open template read-onlyTor Lillqvist1-1/+3
Otherwise when creating a new docuent based on a template, the template document file is opened read-write eventually (after first being opened read-only five times, and closed again...). Sure, LibreOffice probably doesn't actually write anything to it, but still, just opening read-write when you are going to only read is silly. Stack trace from the read-write opening: #0 0x00007f063dea0047 in openFilePath(char const*, void**, unsigned int, unsigned int) (cpFilePath=0x7ffeacc7d610 "/ssd1/lo/fedora/instdir/share/template/common/officorr/Modern_business_letter_sans_serif.ott", pHandle=0x342af78, uFlags=3, mode=438) at /ssd1/lo/fedora/sal/osl/unx/file.cxx:1039 #1 0x00007f063dea027b in openFile(_rtl_uString*, void**, unsigned int, unsigned int) (ustrFileURL=0x33ff7e0, pHandle=0x342af78, uFlags=3, mode=4294967295) at /ssd1/lo/fedora/sal/osl/unx/file.cxx:1071 #2 0x00007f063dea01a8 in osl_openFile(rtl_uString*, oslFileHandle*, sal_uInt32) (ustrFileURL=0x33ff7e0, pHandle=0x342af78, uFlags=3) at /ssd1/lo/fedora/sal/osl/unx/file.cxx:1050 #3 0x00007f060aec5f1a in osl::File::open(unsigned int) (this=0x342af78, uFlags=3) at /ssd1/lo/fedora/include/osl/file.hxx:975 #4 0x00007f060aec5a8f in fileaccess::ReconnectingFile::open(unsigned int) (this=0x342af78, uFlags=3) at /ssd1/lo/fedora/ucb/source/ucp/file/filrec.cxx:50 #5 0x00007f060aee0324 in fileaccess::XStream_impl::XStream_impl(rtl::OUString const&, bool) (this=0x342af10, aUncPath="file:///ssd1/lo/fedora/instdir/share/template/common/officorr/Modern_business_letter_sans_serif.ott", bLock=true) at /ssd1/lo/fedora/ucb/source/ucp/file/filstr.cxx:58 #6 0x00007f060aee8bac in fileaccess::TaskManager::open_rw(int, rtl::OUString const&, bool) (this=0x2c5ded0, CommandId=231, aUnqPath="file:///ssd1/lo/fedora/instdir/share/template/common/officorr/Modern_business_letter_sans_serif.ott", bLock=true) at /ssd1/lo/fedora/ucb/source/ucp/file/filtask.cxx:766 #7 0x00007f060ae9ba9b in fileaccess::BaseContent::open(int, com::sun::star::ucb::OpenCommandArgument2 const&) (this=0x3428810, nMyCommandIdentifier=231, aCommandArgument=...) at /ssd1/lo/fedora/ucb/source/ucp/file/bc.cxx:937 #8 0x00007f060ae99dfa in fileaccess::BaseContent::execute(com::sun::star::ucb::Command const&, int, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) (this=0x3428810, aCommand=..., CommandId=231, Environment=uno::Reference to (ucbhelper::CommandEnvironment *) 0x341d088) at /ssd1/lo/fedora/ucb/source/ucp/file/bc.cxx:331 #9 0x00007f060ae9d001 in non-virtual thunk to fileaccess::BaseContent::execute(com::sun::star::ucb::Command const&, int, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) () at /ssd1/lo/fedora/instdir/program/../program/libucpfile1.so #10 0x00007f06337395da in ucbhelper::Content_Impl::executeCommand(com::sun::star::ucb::Command const&) (this=0x3427f70, rCommand=...) at /ssd1/lo/fedora/ucbhelper/source/client/content.cxx:1258 #11 0x00007f063373be55 in ucbhelper::Content::openWriteableStream() (this=0x7ffeacc7f030) at /ssd1/lo/fedora/ucbhelper/source/client/content.cxx:751 #12 0x00007f06333f56c0 in utl::MediaDescriptor::impl_openStreamWithURL(rtl::OUString const&, bool) (this=0x7ffeacc801d0, sURL="file:///ssd1/lo/fedora/instdir/share/template/common/officorr/Modern_business_letter_sans_serif.ott", bLockFile=true) at /ssd1/lo/fedora/unotools/source/misc/mediadescriptor.cxx:666 #13 0x00007f06333f3e01 in utl::MediaDescriptor::impl_addInputStream(bool) (this=0x7ffeacc801d0, bLockFile=true) at /ssd1/lo/fedora/unotools/source/misc/mediadescriptor.cxx:521 #14 0x00007f06333f4051 in utl::MediaDescriptor::addInputStreamOwnLock() (this=0x7ffeacc801d0) at /ssd1/lo/fedora/unotools/source/misc/mediadescriptor.cxx:490 #15 0x00007f05b132f0bf in filter::config::TypeDetection::impl_openStream(utl::MediaDescriptor&) (this=0x33caa10, rDescriptor=...) at /ssd1/lo/fedora/filter/source/config/cache/typedetection.cxx:1127 #16 0x00007f05b132e9ac in filter::config::TypeDetection::impl_askDetectService(rtl::OUString const&, utl::MediaDescriptor&) (this=0x33caa10, sDetectService="com.sun.star.comp.filters.StorageFilterDetect", rDescriptor=...) at /ssd1/lo/fedora/filter/source/config/cache/typedetection.cxx:981 #17 0x00007f05b132b7a4 in filter::config::TypeDetection::impl_detectTypeFlatAndDeep(utl::MediaDescriptor&, std::__debug::vector<filter::config::FlatDetectionInfo, std::allocator<filter::config::FlatDetectionInfo> > const&, bool, std::__debug::vector<rtl::OUString, std::allocator<rtl::OUString> >&, rtl::OUString&) (this=0x33caa10, rDescriptor=..., lFlatTypes=std::__debug::vector of length 168, capacity 256 = {...}, bAllowDeep=true, rUsedDetectors=std::__debug::vector of length 1, capacity 1 = {...}, rLastChance="") at /ssd1/lo/fedora/filter/source/config/cache/typedetection.cxx:934 #18 0x00007f05b1329b7c in filter::config::TypeDetection::queryTypeByDescriptor(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&, unsigned char) (this=0x33caa10, lDescriptor=uno::Sequence of length 6 = {...}, bAllowDeep=1 '\001') at /ssd1/lo/fedora/filter/source/config/cache/typedetection.cxx:429 #19 0x00007f05b132d321 in non-virtual thunk to filter::config::TypeDetection::queryTypeByDescriptor(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&, unsigned char) () at /usr/bin/../lib/gcc/x86_64-redhat-linux/8/../../../../include/c++/8/bits/stl_pair.h:331 #20 0x00007f060df5acdd in framework::LoadEnv::impl_detectTypeAndFilter() (this=0x7ffeacc80c48) at /ssd1/lo/fedora/framework/source/loadenv/loadenv.cxx:739 #21 0x00007f060df58796 in framework::LoadEnv::startLoading() (this=0x7ffeacc80c48) at /ssd1/lo/fedora/framework/source/loadenv/loadenv.cxx:357 #22 0x00007f060df57280 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (xLoader=uno::Reference to (framework::Desktop *) 0x282bf98, xContext=uno::Reference to (cppu::ComponentContext *) 0x145b790, sURL="file:///ssd1/lo/fedora/instdir/share/template/common/officorr/Modern_business_letter_sans_serif.ott", sTarget="_default", nFlags=0, lArgs=uno::Sequence of length 4 = {...}) at /ssd1/lo/fedora/framework/source/loadenv/loadenv.cxx:160 #23 0x00007f060dfaef40 in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x282bf20, sURL="file:///ssd1/lo/fedora/instdir/share/template/common/officorr/Modern_business_letter_sans_serif.ott", sTargetFrameName="_default", nSearchFlags=0, lArguments=uno::Sequence of length 4 = {...}) at /ssd1/lo/fedora/framework/source/services/desktop.cxx:617 #24 0x00007f060dfaeffb in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) () at /ssd1/lo/fedora/include/rtl/stringutils.hxx:170 #25 0x00007f06381ee762 in SfxTemplateManagerDlg::OpenTemplateHdl(ThumbnailViewItem*) (this=0x310e160, pItem=0x33925d0) at /ssd1/lo/fedora/sfx2/source/doc/templatedlg.cxx:690 Change-Id: Iaa5cc2bd4c80bc239b8f1bf7ed8aa62d89151d62 (cherry picked from commit e439816281f9fe24c7332b5f1e16df845f5213f2) Reviewed-on: https://gerrit.libreoffice.org/54686 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>