summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2017-11-21ASan heap-buffer-overflowStephan Bergmann1-0/+16
e.g. during CppunitTest_sd_misc_tests (see <https://ci.libreoffice.org/job/lo_ubsan/735/console>) after 66dbd4da3afcadb1393daf9be9cecff71b86509a "tdf#113918: Workaround: Load 1bpp indexed PNG as 8bpp indexed Bitmap". Looks like PNGReaderImpl::ImplDrawScanline also needs to special-case mnPngDepth == 1 in the mbTransparent case (and, TODO, also in the mbAlphaChannel case)? Change-Id: Ie6a0230ec606f7cc5aaf174b9c0075a3b4cb5b1d
2017-11-21Fix typosAndrea Gelmini15-19/+19
Change-Id: I40b3a46d46f0586d086bdbe41876c088f8c1cb58 Reviewed-on: https://gerrit.libreoffice.org/45007 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-11-21Avoid static_cast on dead SwVirtFlyDrawObj object for nowStephan Bergmann1-0/+2
...in SwFlyFrame::GetVirtDrawObj (sw/source/core/layout/fly.cxx) after 487ac20ecd73cf3d98071ba30cf5597d957017f7 "RotateFlyFrame3: add support for AutoContour" added this code, which causes at least UBSan (e.g., during CppunitTest_sw_rtfimport) to produce errors (starting with <https://ci.libreoffice.org/job/lo_ubsan/733/console>). There appear to be no negative consequences across 'make check' with this code disabled, so do that for now to unblock UBSan builds, until a real fix is provided. The backtrace of the bad static_cast on dead SwVirtFlyDrawObj is > SwFlyFrame::GetVirtDrawObj() (/sw/source/core/layout/fly.cxx:2599) > SwFlyFreeFrame::~SwFlyFreeFrame() (/sw/source/core/layout/flylay.cxx:93) > SwFlyAtContentFrame::~SwFlyAtContentFrame() (/sw/source/core/inc/flyfrms.hxx:161) > SwFlyAtContentFrame::~SwFlyAtContentFrame() (/sw/source/core/inc/flyfrms.hxx:161) > SwFrame::DestroyFrame(SwFrame*) (/sw/source/core/layout/ssfrm.cxx:431) > SwLayoutFrame::DestroyImpl() (/sw/source/core/layout/ssfrm.cxx:517) > SwFrame::DestroyFrame(SwFrame*) (/sw/source/core/layout/ssfrm.cxx:429) > SwLayoutFrame::DestroyImpl() (/sw/source/core/layout/ssfrm.cxx:540) > SwPageFrame::DestroyImpl() (/sw/source/core/layout/pagechg.cxx:295) > SwFrame::DestroyFrame(SwFrame*) (/sw/source/core/layout/ssfrm.cxx:429) > SwLayoutFrame::DestroyImpl() (/sw/source/core/layout/ssfrm.cxx:540) > SwRootFrame::DestroyImpl() (/sw/source/core/layout/newfrm.cxx:621) > SwFrame::DestroyFrame(SwFrame*) (/sw/source/core/layout/ssfrm.cxx:429) > std::_Sp_counted_deleter<SwRootFrame*, void (*)(SwFrame*), std::allocator<void>, (__gnu_cxx::_Lock_policy)2>::_M_dispose() (/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/shared_ptr_base.h:470) > std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release() (/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/shared_ptr_base.h:154) > std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count() (/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/shared_ptr_base.h:684) > std::__shared_ptr<SwRootFrame, (__gnu_cxx::_Lock_policy)2>::~__shared_ptr() (/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/shared_ptr_base.h:1123) > std::shared_ptr<SwRootFrame>::~shared_ptr() (/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/shared_ptr.h:93) > SwViewShell::~SwViewShell() (/sw/source/core/view/vnew.cxx:364) > SwCursorShell::~SwCursorShell() (/sw/source/core/crsr/crsrsh.cxx:2743) > SwEditShell::~SwEditShell() (/sw/source/core/edit/edws.cxx:64) > SwFEShell::~SwFEShell() (/sw/source/core/frmedt/fews.cxx:700) > SwWrtShell::~SwWrtShell() (/sw/source/uibase/wrtsh/wrtsh1.cxx:1662) > SwWrtShell::~SwWrtShell() (/sw/source/uibase/wrtsh/wrtsh1.cxx:1655) > SwView::~SwView() (/sw/source/uibase/uiview/view.cxx:1045) > SwView::~SwView() (/sw/source/uibase/uiview/view.cxx:1011) > SfxViewFrame::ReleaseObjectShell_Impl() (/sfx2/source/view/viewfrm.cxx:992) > SfxViewFrame::~SfxViewFrame() (/sfx2/source/view/viewfrm.cxx:1363) > SfxViewFrame::~SfxViewFrame() (/sfx2/source/view/viewfrm.cxx:1357) > SfxViewFrame::Close() (/sfx2/source/view/viewfrm.cxx:1044) > SfxFrame::DoClose_Impl() (/sfx2/source/view/frame.cxx:155) > SfxBaseController::dispose() (/sfx2/source/view/sfxbasecontroller.cxx:1003) > (anonymous namespace)::Frame::setComponent(com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController> const&) (/framework/source/services/frame.cxx:1474) > (anonymous namespace)::Frame::close(unsigned char) (/framework/source/services/frame.cxx:1681) > SfxFrame::DoClose() (/sfx2/source/view/frame.cxx:121) > SfxViewFrame::Notify(SfxBroadcaster&, SfxHint const&) (/sfx2/source/view/viewfrm.cxx:1251) > SfxBroadcaster::Broadcast(SfxHint const&) (/svl/source/notify/SfxBroadcaster.cxx:49) > SfxModelListener_Impl::notifyClosing(com::sun::star::lang::EventObject const&) (/sfx2/source/doc/objxtor.cxx:167) > SfxBaseModel::close(unsigned char) (/sfx2/source/doc/sfxbasemodel.cxx:1348) > SwXTextDocument::close(unsigned char) (/sw/source/uibase/uno/unotxdoc.cxx:623) > SfxBaseModel::dispose() (/sfx2/source/doc/sfxbasemodel.cxx:722) > SwXTextDocument::dispose() (/sw/source/uibase/uno/unotxdoc.cxx:615) > SwModelTestBase::tearDown() (/sw/qa/extras/inc/swmodeltestbase.hxx:206) > CppUnit::TestCaller<testN695479>::tearDown() (/workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:185) > CppUnit::TestCaseMethodFunctor::operator()() const (/workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32) > (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) (/test/source/vclbootstrapprotector.cxx:39) > CppUnit::ProtectorChain::ProtectFunctor::operator()() const (/workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20) > (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) (/unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89) > CppUnit::ProtectorChain::ProtectFunctor::operator()() const (/workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20) > (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) (/unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63) and the backtrace of the destruction of that SwVirtFlyDrawObj object is > operator delete(void*) (/builddir/build/BUILD/valgrind-3.13.0/coregrind/m_replacemalloc/vg_replace_malloc.c:576) > SwVirtFlyDrawObj::~SwVirtFlyDrawObj() (/sw/source/core/draw/dflyobj.cxx:433) > SwFlyFrame::FinitDrawObj() (/sw/source/core/layout/fly.cxx:379) > SwFlyFrame::DestroyImpl() (/sw/source/core/layout/fly.cxx:277) > SwFlyFreeFrame::DestroyImpl() (/sw/source/core/layout/flylay.cxx:87) > SwFrame::DestroyFrame(SwFrame*) (/sw/source/core/layout/ssfrm.cxx:429) > SwLayoutFrame::DestroyImpl() (/sw/source/core/layout/ssfrm.cxx:517) > SwFrame::DestroyFrame(SwFrame*) (/sw/source/core/layout/ssfrm.cxx:429) > SwLayoutFrame::DestroyImpl() (/sw/source/core/layout/ssfrm.cxx:540) > SwPageFrame::DestroyImpl() (/sw/source/core/layout/pagechg.cxx:295) > SwFrame::DestroyFrame(SwFrame*) (/sw/source/core/layout/ssfrm.cxx:429) > SwLayoutFrame::DestroyImpl() (/sw/source/core/layout/ssfrm.cxx:540) > SwRootFrame::DestroyImpl() (/sw/source/core/layout/newfrm.cxx:621) > SwFrame::DestroyFrame(SwFrame*) (/sw/source/core/layout/ssfrm.cxx:429) > std::_Sp_counted_deleter<SwRootFrame*, void (*)(SwFrame*), std::allocator<void>, (__gnu_cxx::_Lock_policy)2>::_M_dispose() (/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/shared_ptr_base.h:470) > std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release() (/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/shared_ptr_base.h:154) > std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count() (/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/shared_ptr_base.h:684) > std::__shared_ptr<SwRootFrame, (__gnu_cxx::_Lock_policy)2>::~__shared_ptr() (/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/shared_ptr_base.h:1123) > std::shared_ptr<SwRootFrame>::~shared_ptr() (/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/shared_ptr.h:93) > SwViewShell::~SwViewShell() (/sw/source/core/view/vnew.cxx:364) > SwCursorShell::~SwCursorShell() (/sw/source/core/crsr/crsrsh.cxx:2743) > SwEditShell::~SwEditShell() (/sw/source/core/edit/edws.cxx:64) > SwFEShell::~SwFEShell() (/sw/source/core/frmedt/fews.cxx:700) > SwWrtShell::~SwWrtShell() (/sw/source/uibase/wrtsh/wrtsh1.cxx:1662) > SwWrtShell::~SwWrtShell() (/sw/source/uibase/wrtsh/wrtsh1.cxx:1655) > SwView::~SwView() (/sw/source/uibase/uiview/view.cxx:1045) > SwView::~SwView() (/sw/source/uibase/uiview/view.cxx:1011) > SfxViewFrame::ReleaseObjectShell_Impl() (/sfx2/source/view/viewfrm.cxx:992) > SfxViewFrame::~SfxViewFrame() (/sfx2/source/view/viewfrm.cxx:1363) > SfxViewFrame::~SfxViewFrame() (/sfx2/source/view/viewfrm.cxx:1357) > SfxViewFrame::Close() (/sfx2/source/view/viewfrm.cxx:1044) > SfxFrame::DoClose_Impl() (/sfx2/source/view/frame.cxx:155) > SfxBaseController::dispose() (/sfx2/source/view/sfxbasecontroller.cxx:1003) > (anonymous namespace)::Frame::setComponent(com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController> const&) (/framework/source/services/frame.cxx:1474) > (anonymous namespace)::Frame::close(unsigned char) (/framework/source/services/frame.cxx:1681) > SfxFrame::DoClose() (/sfx2/source/view/frame.cxx:121) > SfxViewFrame::Notify(SfxBroadcaster&, SfxHint const&) (/sfx2/source/view/viewfrm.cxx:1251) > SfxBroadcaster::Broadcast(SfxHint const&) (/svl/source/notify/SfxBroadcaster.cxx:49) > SfxModelListener_Impl::notifyClosing(com::sun::star::lang::EventObject const&) (/sfx2/source/doc/objxtor.cxx:167) > SfxBaseModel::close(unsigned char) (/sfx2/source/doc/sfxbasemodel.cxx:1348) > SwXTextDocument::close(unsigned char) (/sw/source/uibase/uno/unotxdoc.cxx:623) > SfxBaseModel::dispose() (/sfx2/source/doc/sfxbasemodel.cxx:722) > SwXTextDocument::dispose() (/sw/source/uibase/uno/unotxdoc.cxx:615) > SwModelTestBase::tearDown() (/sw/qa/extras/inc/swmodeltestbase.hxx:206) > CppUnit::TestCaller<testN695479>::tearDown() (/workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:185) > CppUnit::TestCaseMethodFunctor::operator()() const (/workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32) > (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) (/test/source/vclbootstrapprotector.cxx:39) > CppUnit::ProtectorChain::ProtectFunctor::operator()() const (/workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20) > (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) (/unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89) > CppUnit::ProtectorChain::ProtectFunctor::operator()() const (/workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20) Change-Id: Ida6e66c3bc8f85c9cbe60a33aaf40f5e83f16212 Reviewed-on: https://gerrit.libreoffice.org/44976 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-21TypedWhichId for SDRATTR* constants (2)Noel Grandin20-198/+256
Change-Id: I9926d55568f8b5bbc67f448bbf7fb660e74505fd Reviewed-on: https://gerrit.libreoffice.org/44964 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-21Translate German variable nameJohnny_M1-5/+5
Change-Id: I70f9355bc7f219e8d6aaf9fb8ecc356e1a86d9da Reviewed-on: https://gerrit.libreoffice.org/44921 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-11-21Fix typosAndrea Gelmini4-4/+4
Change-Id: Ifd95ada4477d7d21ffbadd355226f91f2a2371e1 Reviewed-on: https://gerrit.libreoffice.org/45004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-11-21TSCP: disable bullets in impress for classification text objectTomaž Vajngerl1-2/+3
Change-Id: I1f941e3711c2835cbb50af000fcd7ffa9b953edf Reviewed-on: https://gerrit.libreoffice.org/44946 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-21CppunitTest_swarm_solver_test also consistently fails for UBSan buildStephan Bergmann1-2/+2
...at least for my local one, with > /data/sbergman/lo-san/core/sccomp/qa/unit/SwarmSolverTest.cxx:387:(anonymous namespace)::SwarmSolverTest::testMultipleVariables > double equality assertion failed > - Expected: 0 > - Actual : 1 > - Delta : 1e-05 so disable that part unconditionally for now. Change-Id: Id8c091781baf4381696e2a8f0501df1f3f83724f Reviewed-on: https://gerrit.libreoffice.org/44977 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-20Updated coreGabor Kelemen1-0/+0
Project: help 01e27eb146e6809019a3dc886e115f3f1176e12e Cosmetic changes to Title Page page - Don't start note paragraphs with 'Note:' - Consistently use and emphasize 'First Page' and 'Default Style' names Change-Id: I5a93f3a5a5afd56fd69118c821543fc2e672485f Reviewed-on: https://gerrit.libreoffice.org/45000 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-11-20Updated coreGabor Kelemen1-0/+0
Project: help be08a64ffccd2566cd3cd92b93cecdc36bad0a4b Display extended help on the Bullets and Numbering button Change-Id: I8c7393855cff20640a4b4dfe5e26f94e3f31a0f1 Reviewed-on: https://gerrit.libreoffice.org/44999 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-11-20Updated coreGabor Kelemen1-0/+0
Project: help c43bfbb67d64bfa72f36177784bbebf165f06a39 Display extended help tips in Writer Formula toolbar Change-Id: I8f00071bc9a67e59b6dcede06a3ac2c4b5ca48fb Reviewed-on: https://gerrit.libreoffice.org/44998 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-11-20Updated coreGabor Kelemen1-0/+0
Project: help 6786fb57ceb730812c8096365ee199bc108f3524 Display extended help on the Help Lines Move icon of Drawing Object toolbar Change-Id: Id5717e6d6fdd019f05e20e0c90d0aaee5bae9f9e Reviewed-on: https://gerrit.libreoffice.org/44997 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-11-20Updated coreGabor Kelemen1-0/+0
Project: help cca1afdd2c096c85d4513983cb75f54cf34169ac Display extended help on the Grid Visible icon of Drawing Object toolbar Change-Id: I5365fbea2defcc911d10dfa96009bca1114d0573 Reviewed-on: https://gerrit.libreoffice.org/44996 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-11-20Updated coreGabor Kelemen1-0/+0
Project: help 5ab607135831f51674336313fa84e76305dfef99 Display extended help on the Wrap Left/Right icons of various toolbars Change-Id: I91330c2a2c0bcc9d3bb3156d67566ca0ecf44f0f Reviewed-on: https://gerrit.libreoffice.org/44995 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-11-20Updated coreGabor Kelemen1-0/+0
Project: help 673c52f0f6725ff47a145f612e45cca6e9455867 Fix a missing ahelp and a bookmark Change-Id: I8630a0c95f8068bdfe44518f924862b7d41a2089 Reviewed-on: https://gerrit.libreoffice.org/44994 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-11-20Updated coreGabor Kelemen1-0/+0
Project: help 5045aff02e47e50d0c9abaa2dd51f817171bf739 Display extended help on the Paragraph icon of Formatting toolbar Change-Id: I3590ef4b21cf6e4c4205732125beb84428d6db70 Reviewed-on: https://gerrit.libreoffice.org/44991 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-11-20Updated coreGabor Kelemen1-0/+0
Project: help 5e138269eb7353b7ca7e3aba5f8bb266cff7f5ae Display extended help on the Spacing icon of Formatting toolbar Change-Id: I6be9c9476ca0d1a423e2afcc3ba3c93f76a13eec Reviewed-on: https://gerrit.libreoffice.org/44990 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-11-20Updated coreGabor Kelemen1-0/+0
Project: help 06742805c6d5cf4f5a86f6affae0d93941e4598a Display extended help on the Font Color icon of Formatting toolbar Change-Id: Ibe29d120a38f70f67008a41c2beefdfbf016eaf0 Reviewed-on: https://gerrit.libreoffice.org/44989 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-11-20Updated coreGabor Kelemen1-0/+0
Project: help 2d215df1e40410fd186cc57bbd0a9aa71e6c3221 Display extended help on the Line Spacing icon of Formatting toolbar Change-Id: I4fb45d2f82111d43d1727a2b1e62e3e508e79f87 Reviewed-on: https://gerrit.libreoffice.org/44988 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-11-20Updated coreGabor Kelemen1-0/+0
Project: help cdd9d1d296f3a2dfad988e2f7f3244747408a87d Display extended help on the New/Update/Load Style icons of Formatting toolbar Change-Id: Ic2b5620789192e1928ffe2cef9b4be3030e9e4de Reviewed-on: https://gerrit.libreoffice.org/44987 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-11-20Updated coreGabor Kelemen1-0/+0
Project: help 774662d0051ba14f915f8104c0d00cc77e5c6559 Display extended help on the Outline dropdown of Formatting toolbar Change-Id: I6e1ff34ae7dd175cdb70a2314351dca3eccb8dc1 Reviewed-on: https://gerrit.libreoffice.org/44986 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-11-20Updated coreGabor Kelemen1-0/+0
Project: help 1e4d6e9b6ae36bd5ad0c1fb1c300f18eabcd8a9d Display extended help on the Clear icon of Formatting toolbar Change-Id: Ieb8b894a4307bcc2538483c3a0c65802ec86dbd0 Reviewed-on: https://gerrit.libreoffice.org/44985 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-11-20gpg4libre: add glib2 dependency for WindowsThorsten Behrens14-1/+5744
Change-Id: Ib6b5393323a4dbfe94ea89689ac9170f8afa3899 Reviewed-on: https://gerrit.libreoffice.org/44856 Reviewed-by: Siegmund Gorr <siegmund.gorr@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-11-20tdf#95880 Add a lock mark on protected sheet tab.Gulsah Kose6-0/+49
Change-Id: Ic9ec598d9bfdf98336cc4a11af21502ca7a1e4fb Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/44558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-20Updated coreOlivier Hallot1-0/+0
Project: help 2efb8853f37090026c902720613ac9512132f393 tdf#113949 Add more info on audio video support After cloph's askbot answer. Change-Id: I0dceef8b2ba500ca28a70231c04ecbfbaa0e925e Reviewed-on: https://gerrit.libreoffice.org/45006 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-11-20Updated coreGabor Kelemen1-0/+0
Project: help 11046428321a6a5186d9199b59f7c8bc854f7411 Display extended help on the Style dropdown of Formatting toolbar Change-Id: I383c5f3063efb82e7fbf5299a9e66e423802f9a3 Reviewed-on: https://gerrit.libreoffice.org/44982 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-11-20ofz#4321 Direct-leakCaolán McNamara2-10/+9
Change-Id: I0ce2da99f34082e4e090753e3a4aa8fcc4420a5d Reviewed-on: https://gerrit.libreoffice.org/44955 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-20ofz#4338 Integer-overflowCaolán McNamara1-2/+2
Change-Id: I6019da51dced0ef560490b7e7cf303b8193f17ce Reviewed-on: https://gerrit.libreoffice.org/44971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-20Updated coreGabor Kelemen1-0/+0
Project: help 82ec230767b5e9217dd7468a31828f9101fa8f03 Display extended help on the Hyperlink icon of Standard toolbar Change-Id: Icfe14aa888473195dbb536145adcaa11ecbc8d55 Reviewed-on: https://gerrit.libreoffice.org/44993 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-11-20Updated coreGabor Kelemen1-0/+0
Project: help 9857d750e09df835b3afaf8ded3df58471e5188f Display extended help on the Load URL dropdown of Standard toolbar Change-Id: Ie6f197e88dc7e5bc10aa296782d9089ef7831e46 Reviewed-on: https://gerrit.libreoffice.org/44992 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-11-20Updated coreGabor Kelemen1-0/+0
Project: help 36f359e93946f68ec78ade86657e50f750d905ef Display extended help on the Save As icon of Standard toolbar Change-Id: Ieda031ebdfdbdc22e65a152d87747041fb4045f5 Reviewed-on: https://gerrit.libreoffice.org/44984 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-11-20Updated coreGabor Kelemen1-0/+0
Project: help 215ea7c387871288fa0e7129b152eea8b7289b4e Display extended help on the Open icons of Standard toolbar Change-Id: I39c3a10ac7bf7096f41d41299aac351885548826 Reviewed-on: https://gerrit.libreoffice.org/44983 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-11-20Updated coreGabor Kelemen1-0/+0
Project: help 2aa2111068d6506462f51c5b61c639a70068eda3 Display extended help on the Undo/Redo icons of Standard toolbar Change-Id: I1a0687c925264625d6bafc2016a1487c008b6480 Reviewed-on: https://gerrit.libreoffice.org/44980 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-11-20Updated coreGabor Kelemen1-0/+0
Project: help b5a003be3ce255973c1be86269a7f5554b2e1e3b tdf#106861 Last occurrence of Tools - Cell Contents removed Change-Id: I2dbaa2847271b2453ae62f86847c156a60feb41d Reviewed-on: https://gerrit.libreoffice.org/44981 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-11-20tdf#79754 updated windows shellnew template filesYousuf Philips4-0/+0
the old template files were created with OOo 3.1 and use Arial and Times New Roman as default fonts, while these new files were created with LO 6.0 alpha use Liberation fonts as defaults Change-Id: I54c98f092af3f1eae31ea0b3458c0e91a1d1c074 Reviewed-on: https://gerrit.libreoffice.org/43625 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-11-20Updated coreLászló Németh1-0/+0
Project: help ebc20f206274da2125fb814da5f5dd1650aaba84 tdf#113739 help text of "Grammar By" user dictionary field Change-Id: I600f7b898510bdf2706a949a33d715d73e0c3a25 Reviewed-on: https://gerrit.libreoffice.org/44941 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-11-20Make CppunitTest name consistent with file nameStephan Bergmann1-10/+10
Change-Id: Ice44f10673d127b1f1c7f701ec2d7905eab7029e
2017-11-20Upgrade to ICU 60.1Eike Rathke15-329/+79
Change-Id: I6d90f51ee88c4e1005edbaa93d23cfb94cb2acfb Reviewed-on: https://gerrit.libreoffice.org/44871 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-11-20tdf#113880 a11y: make bitmap tab of area tab accessibleYousuf Philips1-21/+35
Change-Id: Icfdb3f68bb0660b20ebe3f98e5e4fb8fcf3e54f1 Reviewed-on: https://gerrit.libreoffice.org/44897 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-11-20Non-blacklisted file wasn't formatted according to clang-format rulesStephan Bergmann1-0/+1
...so blacklist it, as needed to push a change to it in a follow-up commit Change-Id: Ia43737fb92311d8461e1eb5f9b3862c1e9ca57bd
2017-11-20tdf#89216 forward empty cells as empty to BASIC instead of 0.0Matti Lehtonen1-2/+3
This change causes that either empty or unknown cells are forwarded to macros as empty, not as zero (double). Change-Id: Ia73bcb2ab48e08f97b46cdb45ae4dc3d21bbffd5 Reviewed-on: https://gerrit.libreoffice.org/43226 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-11-20tdf#113918: Workaround: Load 1bpp indexed PNG as 8bpp indexed BitmapTor Lillqvist1-3/+28
The alternative, to fix the X11 disaster area used by the gen, gtk, and kde4 VCL plugins, seemed more difficult. Somebody else with more time, feel free to revert and do that instead. Change-Id: I068ea27224ba98be25e01671546137ddd70691a7 Reviewed-on: https://gerrit.libreoffice.org/44957 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2017-11-20renameModuleOrDialog: add missing check for valid Referencetagezi1-1/+1
Change-Id: I2cf33a4fae4db45b854e77e31e166afa0281a054 Reviewed-on: https://gerrit.libreoffice.org/44956 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-20external/pdfium: -fsanitize=nonnull-attributeStephan Bergmann1-0/+12
...as seen during CppunitTest_vcl_pdfexport: > workdir/UnpackedTarball/pdfium/core/fxcrt/string_data_template.h:81:31: runtime error: null pointer passed as argument 2, which is declared to never be null > /usr/include/string.h:44:28: note: nonnull attribute specified here > #0 0x7f6506471c0d in fxcrt::StringDataTemplate<char>::CopyContentsAt(unsigned long, char const*, unsigned long) workdir/UnpackedTarball/pdfium/core/fxcrt/string_data_template.h:81:5 > #1 0x7f650645f9db in fxcrt::ByteString::ByteString(fxcrt::StringViewTemplate<char> const&, fxcrt::StringViewTemplate<char> const&) workdir/UnpackedTarball/pdfium/core/fxcrt/bytestring.cpp:137:12 > #2 0x7f6505e6bfbc in fxcrt::operator+(char const*, fxcrt::ByteString const&) workdir/UnpackedTarball/pdfium/core/fxcrt/bytestring.h:242:10 > #3 0x7f650671798c in CFX_FolderFontInfo::ReportFace(fxcrt::ByteString const&, _IO_FILE*, unsigned int, unsigned int) workdir/UnpackedTarball/pdfium/core/fxge/cfx_folderfontinfo.cpp:223:21 > #4 0x7f6506716ea1 in CFX_FolderFontInfo::ScanFile(fxcrt::ByteString const&) workdir/UnpackedTarball/pdfium/core/fxge/cfx_folderfontinfo.cpp:193:5 > #5 0x7f65067154fb in CFX_FolderFontInfo::ScanPath(fxcrt::ByteString const&) workdir/UnpackedTarball/pdfium/core/fxge/cfx_folderfontinfo.cpp:151:36 > #6 0x7f650671546a in CFX_FolderFontInfo::ScanPath(fxcrt::ByteString const&) workdir/UnpackedTarball/pdfium/core/fxge/cfx_folderfontinfo.cpp:151:15 > #7 0x7f6506714c86 in CFX_FolderFontInfo::EnumFontList(CFX_FontMapper*) workdir/UnpackedTarball/pdfium/core/fxge/cfx_folderfontinfo.cpp:121:5 > #8 0x7f650676d271 in CFX_FontMapper::LoadInstalledFonts() workdir/UnpackedTarball/pdfium/core/fxge/cfx_fontmapper.cpp:360:16 > #9 0x7f650676d469 in CFX_FontMapper::MatchInstalledFonts(fxcrt::ByteString const&) workdir/UnpackedTarball/pdfium/core/fxge/cfx_fontmapper.cpp:365:3 > #10 0x7f6506773376 in CFX_FontMapper::FindSubstFont(fxcrt::ByteString const&, bool, unsigned int, int, int, int, CFX_SubstFont*) workdir/UnpackedTarball/pdfium/core/fxge/cfx_fontmapper.cpp:573:22 [...] Change-Id: I0221a099198d8f23f239e8493509bdf1816fbc59
2017-11-20LibreOffice.natvis: a small correctionMike Kaganski1-1/+1
Change-Id: I6f9971bf3fc8eec996a19c0a56202947f65a07ae Reviewed-on: https://gerrit.libreoffice.org/44972 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-20Move position of Formula in File > New to similar to start centerYousuf Philips1-17/+17
Change-Id: I3d5f81e444d2f48f2f2d90e474bd51dbd6a674b5 Reviewed-on: https://gerrit.libreoffice.org/44926 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-11-20tdf#108872 Also remove VBA module info on module removaltagezi1-0/+3
If this information is left, then css.container.ElementExistException is thrown on following creation of a module with the same name in XVBAModuleInfo::insertModuleInfo called from ScriptDocument::Impl::createModule (see commit 2be139d76bdb66e77719613d802dc0047c284456) Change-Id: I6750819ce36c112c146d7800a6bab4cc207e0062 Reviewed-on: https://gerrit.libreoffice.org/44940 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-20SwDBManager: move implementation details from interfaceMike Kaganski2-151/+186
Change-Id: I738e8306f2f9af7f284cc236d55f5e184e632323 Reviewed-on: https://gerrit.libreoffice.org/44951 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-20Disabled slot with Put leaks entry (StateFormatPaintbrush/sw)Julien Nabet1-4/+6
Same as https://cgit.freedesktop.org/libreoffice/core/commit/?id=21dde7a09e2cfe7b48d2fec1edc7a94fa94af5c3 Change-Id: I670c01eb5e5e747ceb77995ad855ee448faa054f Reviewed-on: https://gerrit.libreoffice.org/44931 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-20l10n: dont translate non-text character tab fill characters (2)Yousuf Philips1-3/+3
Change-Id: Ib46cef900e681664e50b06c2e4a5af2b63a8f83f Reviewed-on: https://gerrit.libreoffice.org/44953 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>