summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2017-09-21lok: Don't freeze the LibreOfficeKit via the spell-checking popup menu.cp-5.3-26Jan Holesovsky2-3/+12
Change-Id: I045ed919daeefca612d7908dd7de50c36536c9a0 Reviewed-on: https://gerrit.libreoffice.org/42608 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-19Bump version to 5.3-26Andras Timar1-1/+1
Change-Id: I0108167312db0063f4bdd5e6807c5d5017a32e07
2017-09-19ofz#3301 sw: DeleteAndJoin found yet another way to delete new redlineMichael Stahl2-36/+31
Not only can that happen in CompressRedlines(), it can also happen in the SwComparePosition::Outside case when the DeleteRedline() decides in particular circumstances to split up the inserted new redline. Arguably it's wrong to split up the new redline in this case; not sure if that ever happens in a legitimate use case though. Avoid this by removing the hack to temporarily insert the new redline and instead create a temporary SwUnoCursor that will be corrected on behalf of the new redline, while the new redline is parked on a safe node. This not only avoids the crash on this file but also makes the "corrupted redline table" assertions go away. Change-Id: I478f4cfc53a19d2cf2f0937f631962f80b1815ff Reviewed-on: https://gerrit.libreoffice.org/42408 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit a562be54f3127f4e22a3a38e62db2b38d48499f3)
2017-09-19ofz#3412 SYLK import: check ;X;Y;C;R col/row validity earlyCaolán McNamara1-0/+10
Change-Id: I91fcd2571e528201e01467f3bcdbbff30cdfb50c Reviewed-on: https://gerrit.libreoffice.org/42426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 51854f5432de42bcc1154469edb5395328870613)
2017-09-19Word 2013 and 2016 does not honor the <w:view> setting, let's ignore it too.Jan Holesovsky2-6/+5
In other words, let's open documents in the non-web view even when saved with <w:view w:val="web"/>. The behavior I see in Word 2013 (and it's documented that his happens in 2016 too) is that the setting is not a document setting any more, but user's setting. Ie. regardless of what is written in the file, the .docx document opens in the Print Layout if the Word was in the Print Layout until now, and in the Web Layout if it was that mode. We handle the non-web layout much better than the web layout, so let's just default to the normal layout on load. Change-Id: Ieba7ddc280b9b79501a6b89ff21b03a86356583c Reviewed-on: https://gerrit.libreoffice.org/42414 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/42412 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-09-19lok: Expose the automatic spell checking state in the UI.Jan Holesovsky2-0/+2
Change-Id: I5c22ff70d3895b0f4a86eb8be85dde971604874a Reviewed-on: https://gerrit.libreoffice.org/42479 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-09-19tdf#111305: Fix group name refresh in pivot tableDimitri Bouron1-0/+14
Change-Id: Ibc22bfba5765aba3014651df50afb23b893d2b5a Reviewed-on: https://gerrit.libreoffice.org/40712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 3d37e10684edf9536beefe5670b144571e6c9792)
2017-09-18tdf#108572 remove connection also if not savedSzymon Kłos3-5/+44
Change-Id: Iddce37c3ad187f4a5572cb3cc2362535134c28e8 Reviewed-on: https://gerrit.libreoffice.org/42357 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 29bd193146b40cf90bda5db04b136987f3c7c94d) Reviewed-on: https://gerrit.libreoffice.org/42369 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-18gbuild: strip away unexpected CR char at the end of Windows filenamesMiklos Vajna1-0/+7
As reported at e.g. <https://ask.libreoffice.org/en/question/90346/building-libreoffice-in-cygwin-leads-to-infinite-loop/>, sometimes MSVC (seen with 2013 on libreoffice-5-2, but there is no indication that 2015 on master would be different) emits CR characters at the end of filenames, resulting in unnecessary rebuilds at per-module builds, and actually to an infinite loop when doing toplevel make. Given that CR characters are unexpected in any filenames, it should be safe to just strip those away unconditionally. Change-Id: I3d56670b4d930a32489f889085711bfd436de82a Reviewed-on: https://gerrit.libreoffice.org/40452 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit e9b9a456221b4b0660f90efa1ee092ea00c2c728)
2017-09-18detect corrupted job setupCaolán McNamara1-7/+15
Change-Id: I0d3b4850c3d4c015a0a7e5d36d87113a749c7e0f Reviewed-on: https://gerrit.libreoffice.org/42385 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 1eb3822d74f535f75aa336b27568ee8a6084c4dd)
2017-09-18valgrind: Conditional jump or move depends on uninitialised valueCaolán McNamara1-1/+1
Conditional jump or move depends on uninitialised value(s) at 0x4C3535E: strstr (vg_replace_strmem.c:1623) by 0x4FCD9E59: SmFilterDetect::detect(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&) (smdetect.cxx:102) by 0x41A1A774: filter::config::TypeDetection::impl_askDetectService(rtl::OUString const&, utl::MediaDescriptor&) (typedetection.cxx:1038) Change-Id: I2f98fd3f7799f34cb5bd9242379ce6440645034d Reviewed-on: https://gerrit.libreoffice.org/42381 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 64aa36e8b999ea4dcad69904da941705effad618) Reviewed-on: https://gerrit.libreoffice.org/42387 Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 256a405d4b1feeafd8a09e98bce9fb0c9125ee3d)
2017-09-18sax: Check if it starts with 5 bytes of "<?xml"Takeshi Abe1-5/+3
Reviewed-on: https://gerrit.libreoffice.org/40139 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit b64e564492220b34c14f069e8e1f42675bd9abe6) ofz: string has to be at least 5 chars long Reviewed-on: https://gerrit.libreoffice.org/42379 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> this should presumably be 5, rather than 4 Change-Id: Iec5b748b188c7b1bf61e8137faf4b3f2d480d7f1 98c50a59c03fc886d50362b9c5dd8c84f60e0b62 20c6a6fb34485f42c2a828618e8918d8a441860a Reviewed-on: https://gerrit.libreoffice.org/42395 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 44815f1439bb36e9fb5f0181c541fc4d0c9422f1)
2017-09-18svtools: HTML import: don't put lone surrogates in OUStringMichael Stahl1-1/+2
The bytes "ed b3 b5" in fdo67610-1.doc (which, as the name indicates, is an HTML file) are converted to the lone UTF-16 surrogate "dcf5", which is inserted into SwTextNode and causes asserts later on. The actual encoding of the HTML document is probably GBK (at least VIM doesn't display any missing characters with that), but because it doesn't contain any indication of its encoding it's apparently imported as UTF-8; the ImplConvertUtf8ToUnicode() thinking a surrogate code point is valid even if the Java-compatible mode RTL_TEXTENCODING_JAVA_UTF8 is not specified is a bit of a surprise. [note: the master commit says "JSON-compatible mode" but i was confusing different text encoding perversions there] Change-Id: Idd788d9d461fed150171dd907439166f3075a834 (cherry picked from commit fc670f637d4271246691904fd649358ce2e7be59) Reviewed-on: https://gerrit.libreoffice.org/42101 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 756949c06b8bf933bcd13a226f449b8909cbf3ae)
2017-09-18tdf#112311 oox: fix UAF of std::shared_ptrMichael Stahl4-22/+29
OOXMLFastContextHandlerShape::sendShape() deletes the parent context's ShapeTypeContext::mrTypeModel. It looks like the sendShape() can't be delayed because writerfilter wants to import the v:textbox content into a text frame. Keep the shape alive until the end of the containing context. Not sure if it's going to process the v:fill element properly, but at lest valgrind is happy. (probably regression from CWS writerfilter32bugfixes01) Change-Id: Ifeab84751a1b20b2f272c4dd74b7097deb5eece0 (cherry picked from commit 88c84e71e2559ec6d0b4f8c5101a149daa4a2b2b) Reviewed-on: https://gerrit.libreoffice.org/42245 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 7c7c19d80e6a6327be563a18febc3854d9a38daf)
2017-09-18ofz#3362 SYLK import: check ;X;Y;C;R col/row validity earlyEike Rathke1-0/+20
Change-Id: I37d5ce67f975b6b89c4b8a9baefae2467da2eb84 (cherry picked from commit 34ac0f9a0376b43bcff78a49ccaf4caa34c8c990) Reviewed-on: https://gerrit.libreoffice.org/42278 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit c759f30a5220dfd29894e34ee16c3fe2bf415592)
2017-09-18i#32546# - Java UnoRuntime.getUniqueKey/generateOid do not work reliablyDamjan Jovanovic1-1/+13
In the Java UNO bridge, UnoRuntime.generateOid() generated the object-specific part of the OID using java.lang.Object.hashCode(), which is only 32 bits long, and is commonly overriden and could thus return values from an even smaller range, so OID collisions were quite likely. This changes UnoRuntime.generateOid() to use 128 bit UUIDs for the object-specific part of the OID, and store these in an object => oid java.util.WeakHashMap, making OID collisions almost impossible. Patch by: me Suggested by: Stephan Bergmann (stephan dot bergmann dot secondary at googlemail dot com) (cherry picked from commit 6dd83d1c6c5c580d14ca3d0458be4020603ba118) Change-Id: I8e851a7a69ac2defefa15e9a00118d8f9fc0da95 Reviewed-on: https://gerrit.libreoffice.org/41576 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 3f84390f585cf71331a77ab5ca632cacaf3ad7b9)
2017-09-14Bump version to 5.3-25cp-5.3-25Andras Timar1-1/+1
Change-Id: I689583d3a97a543b1fce8cbdfa456b26db4c30ae
2017-09-14gbuild: suppress -Werror on new GCC 7 warnings for release branchMichael Stahl1-0/+14
These are endemic and fixes too many to backport. Change-Id: I07b3c18c4fe654a840dcbd395bfc05e80649d574 Reviewed-on: https://gerrit.libreoffice.org/42247 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 387974a78a68d54db38e3b74a1ac687928cd04a4)
2017-09-14WaE: include needed headerDavid Tardon1-0/+1
"error: In the GNU C Library, "major" is defined by <sys/sysmacros.h>. For historical compatibility, it is currently defined by <sys/types.h> as well, but we plan to remove this soon. To use "major", include <sys/sysmacros.h> directly. If you did not intend to use a system-defined macro "major", you should undefine it after including <sys/types.h>." Change-Id: I7f5741d4c2eae277e316c5fc97aa73b9430fbdc1 (cherry picked from commit 01bf741a79241829b0d5c048e8f45e3cf6914d3e) Reviewed-on: https://gerrit.libreoffice.org/42246 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 831c187d831972ed96ac4d535ef5773503c3db00)
2017-09-14Resolves: tdf#106163 safe fix for wrong final row/col selection in rtlCaolán McNamara1-0/+2
Change-Id: I773de03768b0a5b28e6b4f63bd65dd270dc975cd Reviewed-on: https://gerrit.libreoffice.org/42199 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit a3ea07e14bab234ee04c441e0dca7a9d12dc7a9b)
2017-09-14tdf#112348: Pivot table: page field filtering is not imported from XLSTamás Zolnai4-29/+141
Reviewed-on: https://gerrit.libreoffice.org/42201 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 55a43f30a54816e13eb6704a8ec5952a63b01a64) Change-Id: I3477cd17f679bdfefb9340656999630380713d3f Reviewed-on: https://gerrit.libreoffice.org/42225 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-14tdf#112337: Pivot table: empty / blank item is not imported from XLSTamás Zolnai4-3/+48
Reviewed-on: https://gerrit.libreoffice.org/42181 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit d44c7ffda598d4d4e8a3963133735a771ba3fe30) Change-Id: I7ed9e5cacdf6df80b2f100d040cbbeda33b085d3 Reviewed-on: https://gerrit.libreoffice.org/42224 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-14tdf#112328: Pivot table, XLS: Popup button for column fields is missingTamás Zolnai1-2/+2
...after round trip in Calc Wrong heading row was exported. Change-Id: I410eeeff7d7af408de1ea8128b6b21ac0cc76ea5 Reviewed-on: https://gerrit.libreoffice.org/42175 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit bc9714fefb2dd2ad55a92aaacb6b246f354ed2c0) Reviewed-on: https://gerrit.libreoffice.org/42223 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-14Revert "Disable spellcheck when LOK is active"Michael Meeks2-6/+1
This reverts commit c92ebc850345924619a12327f36cc6ac9c0b09d1. Change-Id: Idd01cffbd71643d5a9132b518432c5e173b4787a
2017-09-14Pre-load dictionaries for online.Michael Meeks1-0/+24
Change-Id: Ied81f20900060ff6a78704fa9195320b8fb86e45
2017-09-14implementing callback for ruler invalidationAditya Dewan18-5/+177
adding commands to fetch and changee ruler state '.uno:RulerState' and '.uno:RulerStateChange' Change-Id: I66107039a7ae5893691feb45c8ab2e4aa476ea76 Reviewed-on: https://gerrit.libreoffice.org/40727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-09-12Bump version to 5.3-24cp-5.3-24Andras Timar1-1/+1
Change-Id: Ia5370a4cbb5d9aaf07f7cc0095f59792ef3b26c6
2017-09-12tdf#108572 remove connections only for current shellSzymon Kłos4-16/+43
Also remove connections to temp files. Change-Id: Ie5c09eb365d1246e053dc52884c72687ac226f3c Reviewed-on: https://gerrit.libreoffice.org/42095 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/42208 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-12tdf#112304 Revert "Watermark: not visible if page background was set"Szymon Kłos4-33/+6
This reverts commit 39c08074a286855dd014ce1c30b8f7ef95b10242. Fixed by: I69517efb7d82acd719d6a27a09ba61554dbf1ec9 Change-Id: Icd45b3f55292670ff7338a367eba212453a0687e Reviewed-on: https://gerrit.libreoffice.org/42155 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/42165 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-12tdf#112278: Pivot table: filtering of non-string fields is not exported to XLSTamás Zolnai14-50/+501
It is needed to use the right string representation of field value. During export this representation is available directly, next to the actual value. During import we can use the number format attached to the corresponding pivot field. Reviewed-on: https://gerrit.libreoffice.org/42069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 7c429ddca63c09a2b656715292968000bfe86a1a) Change-Id: Ie8f731f6c72d7f55f43c318e52d63dc4e993d9c0 Reviewed-on: https://gerrit.libreoffice.org/42137 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-12tdf#112346: take Word no-wrap limit into account also for ww8Mike Kaganski6-40/+97
This also makes ww8 floating-table conversion decision heuristics somewhat closer to OOXML code. Change-Id: I29ca2ebabd1758ad98e02aaf560cf2f44daec3a8 Reviewed-on: https://gerrit.libreoffice.org/42196 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/42216 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-12tdf#108572 let remove storage elementSzymon Kłos1-0/+2
void OStorage_Impl::RemoveElement( SotElement_Impl* pElement ) expects that m_pAntiImpl will be nullptr, if not throws an exception. This caused that in case of deleting embedded database used for mail merge it wasn't fully removed and it was impossible to import the same datasource second time. Change-Id: I0310fde2ad819c96474a857f37ee42d052fad266 Reviewed-on: https://gerrit.libreoffice.org/42028 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/42043 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-12tdf#112247 correct the size only for WatermarkSzymon Kłos1-6/+9
Change-Id: I770cd36d5f8bca0f2fa97b7ad4afaaf539bf5f1f Reviewed-on: https://gerrit.libreoffice.org/42052 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 91d909ac8ec53ea135401babe8227f9c41b779b8) Reviewed-on: https://gerrit.libreoffice.org/42058 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-12tdf#108572 revoke connection if mail-merge is cancelledSzymon Kłos3-0/+45
Change-Id: Idca4969af8043f7dbc54f4a63b99e92155ef1585 Reviewed-on: https://gerrit.libreoffice.org/41949 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit ba368643e6a0c5ac7a7b7ea8d72899d60b2a8331) Reviewed-on: https://gerrit.libreoffice.org/42044 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-12tdf#112169: Crash while saving character background color to DOCXTamás Zolnai3-1/+8
Reviewed-on: https://gerrit.libreoffice.org/41857 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 242688f3b4fc7228637837e0f4fec3da71ac2710) Reviewed-on: https://gerrit.libreoffice.org/41867 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 9b3e2486d8e96b6fdd844fbdb5fa59c7782e82ee) Change-Id: Iff12b9587b639166caef86f895fb841e83596817
2017-09-12tdf#111891 unostyle: use default handler for non-page styleJustin Luth3-1/+12
LO 5.1 commit 664197d95becd516c3dac25a50439078ba61e051 introduced a handler for RES_TEXT_VERT_ADJUST to handle page styles, but that meant that the default handler was no longer called for frames (the only other item currently using RES_TEXT_VERT_ADJUST). Change-Id: I33827160fe64dc4cc2107afc26f7ac2e698007e1 Reviewed-on: https://gerrit.libreoffice.org/41538 Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Justin Luth <justin_luth@sil.org> (cherry picked from commit 10dc371d31f003ac3ed9b89ca1db95d36603603f) Reviewed-on: https://gerrit.libreoffice.org/41910 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 461aa995d75f031209711feda9d785d915c42dd2) Reviewed-on: https://gerrit.libreoffice.org/42082 (cherry picked from commit db7a015c86248bd2a3d090240f9360f84b3bec8c)
2017-09-12tdf#104602: don't re-draw page background when bOnlyTextBackgroundJustin Luth1-3/+2
In 2014 Writer gained support for Paragraph and PageStyle DrawingLayer FillAttributes, it changed some behaviour with PaintBackground, so that compat setting BACKGROUND_PARA_OVER_DRAWINGS now overwrote the entire "hell" layer as the page background was re-applied. Only DOCX uses this 2012 compatibility setting. Change-Id: I69517efb7d82acd719d6a27a09ba61554dbf1ec9 Reviewed-on: https://gerrit.libreoffice.org/41744 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/42166 Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-09-10tdf#112306: containsSemiMixedTypes is true for blanks-onlyMike Kaganski3-46/+66
Also export containsNonDate Change-Id: I16283a272d51e6c305f8c381c359168c1e3848a8 Reviewed-on: https://gerrit.libreoffice.org/42130 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/42131 Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-08tdf#112280: Export spin animation in PPTX.Jan Holesovsky3-10/+89
Contains also: tdf#112280: Unit test. Change-Id: I9f13bbc2bd3a3de582491ea5b2ad16535589420a Reviewed-on: https://gerrit.libreoffice.org/42079 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-09-08tdf#111974: Ensure sufficient space for all sheets in FormulaBuffer...Dennis Francis3-1/+11
and not just for the number of sheet fragments. This is important because we changed the internal storage of FormulaBuffer from based on std::map to std::vector in d17a83fa549f828f29e6939b16ba8b568a75f95e Added simple unit test that loads the bugdoc in subsequent_filters-test.cxx Reviewed-on: https://gerrit.libreoffice.org/41792 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Dennis Francis <dennis.francis@collabora.co.uk> (cherry picked from commit 20169423d492b58ab93fb0e8e9d2918c0baebc92) Reviewed-on: https://gerrit.libreoffice.org/41841 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Conflicts: sc/qa/unit/subsequent_filters-test.cxx Backported. Change-Id: I7320dd537266e540d585d3fccfbb8665bba457c7 Reviewed-on: https://gerrit.libreoffice.org/42057 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 500b5727fd5902b7d14c6e707c2ad3d2b227bb1a)
2017-09-08Resolves: tdf#112269 libwpd fixCaolán McNamara2-0/+43
Change-Id: I0d8d6887fa360c05d5f9e2a070410c77926b9ce1 Reviewed-on: https://gerrit.libreoffice.org/42056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com> (cherry picked from commit 05da1c67e49a2d758799db735a826c4d292fea44)
2017-09-08tdf#112163 sw: avoid crashing in layout on this documentMichael Stahl1-4/+11
SwTextFrame 0x5dfb7a0 is join locked so doesn't GetFormatted() so doesn't have a SwTextLineAccess created; add some defensive programming just to make it not crash. Whether this is the right fix or just a workaround for something going wrong in the 179 layout stack frames is beyond my meager knowledge. In case anybody has an obvious idea, the layout frames that are currently being formatted (SwTextFrame or SwTabFrame) are: #3 0x5dfb7a0 is master of 0x5e56330 #4 0x5e56330 #10 0x5e5f3f0 is follow of 0x5e56330 #19 0x5e60d30 SwTabFrame::Split #30 0x5e56330 #44 0x5dfb7a0 #53 0x2cefae0 master of 0x5dfb7a0 #57 0x63d1440 SwTabFrame::MakeAll is follow of #58 #58 0x5e106c0 SwTabFrame::MakeAll #68 0x5e812d0 #77 0x5e11f80 is master of #68 #86 0x2cef600 is master of #77 #90 0x5f86c00 SwTabFrame::MakeAll #91 0x63d0150 SwTabFrame::MakeAll #98 SwFlowFrame::MoveFwd #101 0x63cf3d0 #110 0x5e05ff0 is master of #101 #119 0x5e0c700 is master of #110 #128 0x5bd0ad0 is master of #119 #136 0x5f8b800 is master of #128 #145 0x86b29a0 is master of #136 #154 0x2c37340 is master of #145 #158 0x5e04ab0 SwTabFrame::MakeAll #168 0x2c371a0 #173 0x5e16340 SwTabFrame::MakeAll Change-Id: I716b5faec1512cbf1fbdb04a436da302bd628c51 (cherry picked from commit 6c8c51231e7415ecc20d1343211acf8382666613) Reviewed-on: https://gerrit.libreoffice.org/42041 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit b8e84ac201f5611635177f8404c28f7fa8d0c806)
2017-09-08tdf#112164 sax: handle errors on last call to XML_Parse()Michael Stahl3-5/+10
If XML_Parse() is called with isFinal=1 and there are open tags, that is an error (XML_ERROR_NO_ELEMENTS) that must be converted to an exception. This reveals that we already had an incomplete input document, which needs to be moved to "fail" now. (cherry picked from commit e530a7ddb1c9423487ce936e6b23b8e36449d555) tdf#112164 add test document (cherry picked from commit aad2cdce2a2e89f35366c55878129d268cc92bef) Change-Id: I7ce3b51bd87923b5edde621508cf38d7ebbc2b14 Reviewed-on: https://gerrit.libreoffice.org/41965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 3604ca211204b9a0971a65c96a5075ba43f15693)
2017-09-08tdf#112122 xmloff: inserting index marks into editengine throwsMichael Stahl1-2/+9
Catch the exception, since that isn't even invalid input, editengine just can't do it. Change-Id: I362923889add4f1a1d3f8f18b0795993119d54b1 (cherry picked from commit 98552e46521b012e7694c056eca956ae4ee27a0c) Reviewed-on: https://gerrit.libreoffice.org/41759 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 037d5fa9b129a4060f8f572cb72801b7dfa1608f)
2017-09-08tdf#109261: Crash when adding a video to a slide with zero undo stepsTamás Zolnai1-2/+6
When undo is disabled (no undo steps), ReplaceObjectAtView() method frees pPickObj, so we need to save it's reused data first. Reviewed-on: https://gerrit.libreoffice.org/41822 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 27068e6cc39aed8ebfa5fdd7a67acb89f5adcb89) Change-Id: Icbc800d4d33cf229006aecde7d62aa2a7ea35879 Reviewed-on: https://gerrit.libreoffice.org/41861 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 3ce90f78ed77c76ec6e0af3731f2fb37628ef89c)
2017-09-08Resolves: tdf#112018 number-columns-repeated has the data type positiveIntegerCaolán McNamara2-1/+1
Change-Id: I534885fe7a36a8e3ad891a3f5ed50b589f36e3b9 Reviewed-on: https://gerrit.libreoffice.org/41692 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 3415764d00044a19568b3a1b5d5382c73a0342c9) Reviewed-on: https://gerrit.libreoffice.org/41964 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit eab61f66c6cfa4b290c8789a375e6894be054f32)
2017-09-08Resolves: tdf#107249 round ascent/descent/extleading on conversion to intCaolán McNamara1-10/+15
Reviewed-on: https://gerrit.libreoffice.org/41944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 0c8b749e602b6743857a9bc4efb24b6183690311) Change-Id: Ia3ab5960d5288f5831aaa4ade800ca7513dad766 Reviewed-on: https://gerrit.libreoffice.org/41956 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit e0ea7df25faeaae9f98ebde32f49eec92603d629)
2017-09-07tdf#99617 convert powerpoint angle to degreeRegina Henschel1-6/+6
1 powerpoint angle unit = 1/60000 degree Roundtrip test not yet possible because of tdf#106002. Change-Id: I5854c4f9f013f1a2db7e9536fc9cf5198c7a02ed Reviewed-on: https://gerrit.libreoffice.org/34279 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/42078 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-09-07lok - support for watermark - fix namespace problemMarco Cecchetti1-1/+1
Change-Id: I76426f11c3155263652d786c62eb32f823ee1f18
2017-09-07tdf#106867: Export videos in PPTX.Jan Holesovsky10-9/+235
Contains also: tdf#106867: Implement pptx export of AnimationNodeType::COMMAND. tdf#106867: Import target for commands in PPTX. tdf#106867: Write also the extended markup to fully support embedded videos. tdf#106867: Unit test for the export of embedded videos. Change-Id: I7f4f389a72aa7ecef65d87f07bb69ba8f3374a14 Reviewed-on: https://gerrit.libreoffice.org/42017 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-26 15:17:44 +0000