summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2017-05-16Bump version to 5.3-12.cp-5.3-12Jan Holesovsky1-1/+1
Change-Id: I922085fdfaeaccf914550e2eeb5129a43af2062a
2017-05-16lok: sc: selection overlay was not updated on document size changedMarco Cecchetti1-0/+2
Change-Id: I193f37d50ac3ff0ccbf7e39caab4bf25ed3c9a9c Reviewed-on: https://gerrit.libreoffice.org/37403 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-05-16lok: sc: invalidate cached position on undo row/col operationsMarco Cecchetti2-1/+46
Change-Id: I822ecdeda0e7c26c65096e5a249a35f7c2f3a9fe Reviewed-on: https://gerrit.libreoffice.org/37259 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-05-16lok: sc: insert a row affects another view's selection on another tabMarco Cecchetti4-137/+199
Problem: - Open a spreadsheet with two views. - With view A select a cell on 2nd sheet (H10 for example). - With view B delete a row above H10. => View A's selection moves up. Similarly with insertion and with columns. The new solution takes care of the current tab each view is displaying. Change-Id: I47272ec7ef68471b530868dab57fa92091277324 Reviewed-on: https://gerrit.libreoffice.org/37258 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-05-16lok: sc: invalidate col/row header on undo row/col operationsMarco Cecchetti2-1/+23
Change-Id: Ifabce9941541a615840163168af6fedaf54575cd Reviewed-on: https://gerrit.libreoffice.org/37256 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-05-16lok: sc: make row/col header updating, on row/col operations, tab-awareMarco Cecchetti5-22/+34
Now, on inserting/removing or resizing a row/col, the row/col header invalidation callback is notified to another view only if it is displaying the same tab of the view where the row/col operation is occurring. Change-Id: Ic65fd82b2e3009420c7b481e7e8c1ff8bb11bcce
2017-05-16lok: sc: fix for row/col header updating on changing tabMarco Cecchetti1-0/+2
When you switch tab the current row/col header needs to be invalidated. Change-Id: I26ef6f9990726f3c96ddfc9ac45472fafc8e8507
2017-05-16lok: sc: misplaced comment mark on inserting/deleting/resizing row/colMarco Cecchetti11-46/+150
A unique id has been introduced, in a similar way of what occurs in Writer. Change-Id: I7b2ef694867fb4184c4cfc616fe1c8f12da3b676
2017-05-16tdf#104312, tdf#105428: use static vars in ReplaceStringHookProcAron Budea1-9/+15
And use call_once to initialize them once. Reviewed-on: https://gerrit.libreoffice.org/37318 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit f9f511317fa5f1c655d189a8507f8a5492a3b08d) Change-Id: Ic2f97a51ccc6ee400eb1af56da2c8fd88e226a9d Reviewed-on: https://gerrit.libreoffice.org/37528 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-05-16lok: sc: address and formula text field empty on creating a new viewMarco Cecchetti4-0/+15
When the client starts the address and formula text field were empty because the updating callbacks occurred before the view callback handler had been registered. So a new method `afterCallbackRegistered` has been added in order to perform any needed updating/initialization soon after the view callback handler has been registered. Change-Id: Ia47234e32796f7e4bc1a8408736102054b4666e2
2017-05-16lok: sc: notify cell cursor position to address control in clientMarco Cecchetti5-8/+103
A new callback has been introduced for notifying the client: LOK_CALLBACK_CELL_ADDRESS Change-Id: I40b38a3cb8fb658c3f00332d56cfcbaf98e13771 Reviewed-on: https://gerrit.libreoffice.org/37357 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit 9cc9300bc20e9367728aa4b7ec3a789fdd274aff)
2017-05-16fix gdi resource leak (svx/compressgraphicdialog)Julien Nabet1-1/+1
Change-Id: Iea6e481384cee4d7e2ff6787c64d3048ba9c9d65 Reviewed-on: https://gerrit.libreoffice.org/37587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 68a1cb23ede1d4ae6195850190fca6953c30417f) Reviewed-on: https://gerrit.libreoffice.org/37592 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit c41d6c4db6a29fb85b4547b0cf04b3693c472764)
2017-05-16fix gdi resource leak with unreleased virtual deviceJulien Nabet1-1/+1
(copycat Markus https://cgit.freedesktop.org/libreoffice/core/commit/?id=289711c2a469bfbe06aef3b3870b65f9c788f56d) Change-Id: I3974609559dd44257d7c3e9e9544348d622953f6 Reviewed-on: https://gerrit.libreoffice.org/37586 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 11c4cc15fdd491e15ffd4e7d9fb5d4082898f926) Reviewed-on: https://gerrit.libreoffice.org/37591 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 6eb0df62aaa00f2c1508b1650e8df3145822f84f)
2017-05-16tdf#82326 calc 32bits unable to open files with a lot of cond formattingfrederic vroman1-2/+2
The code to build and compute formulas is using an fixed size array. The size of this array has been changed from 512 to 8192 by commit 9c1ca6dca3b553c302a635357e33591605343b99 Since then, LO consumes a LOT of memory while opening scalc files which are making extensive use of conditional formatting. This is a silent issue when working with a 64bits versions of LO because the memory is immediately released at the end of the load phase. However, with 32bits versions, some files can not be opened anymore as it can consume the full process memory space (2GB on windows). The parser is creating ScCondtionEntry objects to store conditional formatting expressions which are immediately compiled in the constructor. However the compile method did not return a flattened token array. Change-Id: Id290bc1f5838c246d4c2322b297b13307defaf88 Reviewed-on: https://gerrit.libreoffice.org/37527 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit f566e2d579f5385b01d9b124e7055721313325c9) Reviewed-on: https://gerrit.libreoffice.org/37644 (cherry picked from commit 4366a6bcc175886680ff1b727207ed1ae4f97ce9)
2017-05-16fix gdi resource leak with unreleased virtual deviceMarkus Mohrhard1-1/+1
Change-Id: I1fd8c76a206cfc940e3d646e4025618785985e52 Reviewed-on: https://gerrit.libreoffice.org/37583 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 289711c2a469bfbe06aef3b3870b65f9c788f56d) Reviewed-on: https://gerrit.libreoffice.org/37585 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit e4fdaa5d9a7b0c507278ef70aab7ce4c9e7ee62d)
2017-05-16tdf#106051 Notify listeners on top and bottom of split formula groupArul Michael1-0/+6
Change-Id: Icecb59a476f57cee0c04c3e21d60e6c7fa12f65a Reviewed-on: https://gerrit.libreoffice.org/37011 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit c882c60f54cc90740a674eed8c47bde0e9959652) Reviewed-on: https://gerrit.libreoffice.org/37543 (cherry picked from commit f55f0b57b1f206763e97065f6121fcb55c53e53d)
2017-05-16sd: fix atexit crash in CanvasUpdateRequester::maRequesterMapMichael Stahl4-30/+54
https://retrace.fedoraproject.org/faf/problems/bthash/?bth=2c9e4b335a4f17dea5e095f0a3e8f79aa40943cb Clearly it's a really bad idea to own these objects at shutdown, so instead use weak references, and also ensure that the CanvasUpdateRequester is not deleted before the event is dispatched just in case. (cherry picked from commit baa253d00ab6aa67fa100472db00227baa14c87a) sd: oops, skipped one entry on every erase by incrementing Thanks Noel for the hint. (cherry picked from commit 670631cae260263e4822d8aa63bc5c2e4349c796) Change-Id: Iee8a109fe5969b2a3345e0ef266aee014962ae57 Reviewed-on: https://gerrit.libreoffice.org/37263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 0f54a0f218834bfcc74b00f0a105785d3099bd40)
2017-05-16tdf#93171 Subtotal function with function indexes don't updateArul Michael3-0/+15
Calling InerpretTail during Hide rows by SfxHintId::ScDataChanged broadcast Reviewed-on: https://gerrit.libreoffice.org/37509 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 970b431f1a7b6b96c4c9536657ce4fe9d8f5b585) Backported. Conflicts: sc/inc/column.hxx Change-Id: Ie78170bb6d49933a49d828a18637cb410796dc06 Reviewed-on: https://gerrit.libreoffice.org/37522 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 318b6b8ea87cba41995436bbc44818a068b35b6d)
2017-05-16tdf#107572: retrieve Default autoformatJulien Nabet1-0/+2
by fixing DefaultFirstEntry comparison operator. From http://www.cplusplus.com/reference/map/map/key_comp/: "... Two keys are considered equivalent if key_comp returns false reflexively (i.e., no matter the order in which the keys are passed as arguments). ..." Certainly regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=652158c3f2c9cd0d6f71ecd14bf5d5cc02a71b50 author Julien Nabet <serval2412@yahoo.fr> 2015-09-15 19:41:48 (GMT) committer Julien Nabet <serval2412@yahoo.fr> 2015-09-30 12:11:35 (GMT) commit 652158c3f2c9cd0d6f71ecd14bf5d5cc02a71b50 (patch) tree 13ad29a110565f24e7010a68d902cadf1c441b62 parent 8727afe771a3e4d585e98ca9cceff2504e500bb0 (diff) tdf#94173: Calc doesn't save your own created autoformat presets This new patch has also been tested for tdf#94173 Change-Id: I60de5fffe39be9b3615c32a317611812b42bafc7 (cherry picked from commit 965494c544dd8f35ae83b7cf38549009da06c367) Reviewed-on: https://gerrit.libreoffice.org/37487 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 9fd3f402e7a6dfe133433d05de7452f32e1c41ba)
2017-05-16tdf#107706 fix crash when closing Calc documentNoel Grandin1-0/+2
regression from commit e8b49f09074fe184374bee5062715357427ae044 "new loplugin: useuniqueptr: vcl" Change-Id: I07ac157a02aa82b1ddbb741797fea093772f93f1 Reviewed-on: https://gerrit.libreoffice.org/37497 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 2ff893426093652221a8602e71c7924c46d3386f)
2017-05-16Add distro-pack-install-strip targetStephan Bergmann1-5/+12
...to be used by dev-tools' flatpak/build.sh Change-Id: Ie61edfc2aeddf10aa70dee07c3496fd6b2aebcc4 (cherry picked from commit 58891d589bd8da700f135b098dd50833277c65dc) Reviewed-on: https://gerrit.libreoffice.org/37473 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 6b35505deabbfb9b00d9bc21fa31b95376a0aed0)
2017-05-15finally switch the workaround offEike Rathke1-2/+3
Change-Id: I284292a2749c2b38ef874315d5b526e403d578e8
2017-05-15turn assert into SAL_INFOEike Rathke1-11/+7
The old assert conditions don't hold anymore since removeFromDrawPageAndFree() only deletes the SdrCaptionObj on the last refcount, but info can be useful. Change-Id: I456149b8799a0509dcd7a2da09d627fb0de1a912
2017-05-15control deletion of SdrCaptionObj within ScCaptionPtr by refcountEike Rathke1-1/+5
I guess this is about the first time ever that repeated Undo and Redo of Cut&Paste of a cell comment does not crash.. Change-Id: I493a0a5439efde133a07d73ddcbcdf5bda4bc276
2017-05-15bail out early if there is no caption to removeEike Rathke1-1/+3
Change-Id: Id08d82751560092fd6225131970f607dbb2e4801
2017-05-15in RemoveCaption() forget() instead of reset(nullptr)Eike Rathke1-1/+6
Change-Id: Id97d4d97c1d46ac6de6198515756a0786a54626e
2017-05-15deleting pModel also deletes the SdrCaptionObjEike Rathke1-0/+3
Change-Id: Icf3aed35ede1c211d6238dc66d86cb2866b247cd
2017-05-15set mbNotOwner at various placesEike Rathke1-0/+7
Change-Id: I1ff14c573d556cad15513dfe3f0fecbf9107fa41
2017-05-15reset variables when not ownerEike Rathke1-2/+9
Change-Id: Ieab4bf36b89abac2d2ff377fc2b6f31ce0e1d3aa
2017-05-15rename ScCaptionPtr (mb|set)InUndo to (mb|set)NotOwnerEike Rathke3-13/+13
... which better suits the general purpose we'll need Change-Id: I32805c91d17180d5f18225a02c8a436826242e19
2017-05-15there are still cases where the caption pointer is danglingEike Rathke1-0/+5
Change-Id: I8c186fa32d7fc3f26d7952268cb1e614025ecf37
2017-05-15finally free the SdrObject in ScCaptionPtr::decRefAndDestroy()Eike Rathke1-10/+12
There may be cases left still to be discovered where a setInUndo() is necessary in some Undo situations, but this is a start. Change-Id: Ic62267e3c3d24e4587343ff42da0292fbb166929
2017-05-15flag ScCaptionPtr::setInUndo() in ScUndoReplaceNoteEike Rathke1-1/+12
Change-Id: I174be1262074e1fed784806d2f052b36749dff0d
2017-05-15introduce ScCaptionPtr InUndoEike Rathke2-4/+20
Change-Id: Iccc2671b61f524244107233b77b56aaa45f5c72a
2017-05-15Add bool bIgnoreUndo parameter to removeFromDrawPageAndFree()Eike Rathke2-8/+12
In preparation of using that in the dtor. Change-Id: I9a8713390c548e774c1e23cef201effe00a29be9
2017-05-15move implementation from RemoveCaption() to removeFromDrawPageAndFree()Eike Rathke2-21/+30
Change-Id: I4f98112c13dfcd5c6c2fdb5b682cca494d63a954
2017-05-15narrow the assert condition further downEike Rathke1-3/+4
Change-Id: Ia9b1db652b2f15b66b89b51038d16fb0da6ffb6d
2017-05-15can't keep track of drawlayer insertionEike Rathke2-12/+4
Draw Undo independently can reinsert a caption to the drawlayer, which is beyond our knowledge. To track that cumbersome manual tracking (or callbacks or whatever) would be needed, which actually this tries to get rid of instead of increasing.. Change-Id: I373843ad61d0b6e19b9d3f98fd8f9e01a448296d
2017-05-15yet another mxCaption refs==1 case to exclude from assertEike Rathke1-2/+4
Change-Id: Iffa8f2bc7d0bb77d5145a569da2c03aefbb9de4a
2017-05-15no assert for one reference while destroying the Undo documentEike Rathke1-2/+3
Change-Id: Idf9e0b2600d503ff50cd6269e8d528c0fad12a3e
2017-05-15finally turn this into a hard assertEike Rathke1-1/+3
Change-Id: Iba6abafeaa2542fc94b76a642ddb0eb5b70b572d
2017-05-15it's raining drawing layersEike Rathke1-0/+15
Change-Id: Ieee5cb5792535185ef09c3775072ed739fb0e4b0
2017-05-15add/use ScCaptionPtr::removeFromDrawPage()Eike Rathke2-2/+21
Change-Id: Ibe073f071b120b61738b7e813a14824248f1fcfc
2017-05-15sprinkle some drawing layers over test casesEike Rathke2-13/+39
... so things actually work like intended and creation of caption objects doesn't silently fail. Well, it does SAL_WARN or OSL_ENSURE but that's never displayed unless a test fails. Change-Id: Ibf4cc075cc3d6dadbe8f6208b2949310124b5749
2017-05-15probably should work like sketchedEike Rathke1-5/+11
Change-Id: I5ad52c718cf53c2f3fb14a7970917e0012d01875
2017-05-15use ScCaptionPtr::insertToDrawPage()Eike Rathke1-3/+4
Change-Id: I98dafdf8e571e4745e05df6cbcbf00fd9ecd8ec6
2017-05-15add ScCaptionPtr::insertToDrawPage()Eike Rathke2-5/+26
Change-Id: I1266b55c2558d306b20b0f2d9fba07b0bc46544e
2017-05-15move assignment onto self should not happenEike Rathke1-2/+1
Change-Id: Ic44f4362762cb1c1fe027b69a78baf768c0a53da
2017-05-15let ScNoteUtil::CreateTempCaption() return ScCaptionPtrEike Rathke4-17/+15
Change-Id: Idcb7fc24a13d650d88bec9ba359d7c78006096ec
2017-05-15coverity#1401471 implement move assignment and move ctor at ScCaptionPtrEike Rathke2-0/+56
Change-Id: Ic429f5e177bb1a35857f00c6e13e5cbb34d46578
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 00:34:42 +0000