Age | Commit message (Collapse) | Author | Files | Lines |
|
Paragraph mark of inner table (0x0D) sometimes has
sprmPFInnerTtp, but no sprmPFInnerTableCell. This still counts
as cell end (at least, MS Word treats it that way).
Unit test included.
Reviewed-on: https://gerrit.libreoffice.org/35763
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit 59af9cbbccee600408c89e872d548d153523ab1f)
Change-Id: I5589cdd486c03ca4567d61882826cc7c245a40c9
|
|
(cherry picked from commit a15ec82edebf14baa41a888ead7da8e0556ab0bb)
Change-Id: I238599cf5ed464c4bb99a894ac47126fbc32796d
|
|
This reverts commit 2a9e6ecc61b232be08d8b1687874289ca0fe8d43.
|
|
Change-Id: Id9805d79ab5ed17dda48b680d80c0d6fd3a72772
|
|
Change-Id: Id767422facef7d5cc51e107e12948abe24693f25
|
|
Change-Id: Idf4d3ba6b55be1f885f9d8fc89157e7e498d4e42
|
|
Conflicts:
desktop/CppunitTest_desktop_app.mk
desktop/qa/desktop_lib/test_desktop_lib.cxx
include/LibreOfficeKit/LibreOfficeKit.hxx
Change-Id: I9dbb62950e639376c26122ceb9fcec2982b3ca82
|
|
Change-Id: Ib2773d1aca6ff0ca8bfad2263b59daf1450fff6a
|
|
Project: translations 8ba1c3a82ca9f1b13f2bd3aebe2e41e40f8b582b
changed wording of cell merge warning
Change-Id: I024b805f10df7462b813204715372ab4dbdcf322
|
|
Reviewed-on: https://gerrit.libreoffice.org/26406
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
(cherry picked from commit 80cb33570557010547a08b5b1cd6bc0c1ee018fc)
Change-Id: I52de5d7062bebe816e90ba39f559cd57dfc1067c
|
|
This is a follow-up of ed5450f2a5ed8e72b48b4d976217746cea04a5c9 where the
check for the HasView has been removed. Turns out that there are conditions
when this really can happen, leading to crashes in the LOK searching.
Unfortunately I did not manage to find a reliable reproducer to create a
unit test :-( - so I suspect this commit might be more a workaround than a
root cause fix. Would be great to find out the exact conditions leading to
the situation when the EditEngine does not contain the EditView, and evaluate
this fix against that - but that's hard without a reliable reproducer.
A unit test for this fix is missing from the same reason. The unit test from
ed5450f2a5ed8e72b48b4d976217746cea04a5c9 still passes.
(cherry picked from commit 9fc3d9b445d8c2bb8e259b42430cfe089642ab03)
Change-Id: I1cca7219817119d27a224b35efb660a84d35b8fa
|
|
blind fix for this since I cannot seem to make it work on my dev box no
matter how far back I go.
This seems to be a regression from commit
c7e8f21a538c409abe70b90d7bba38386e90a876 "loplugin:unusedmethods"
Change-Id: I99f0f0ca662a5fe246057b1bb8da3bd3d3c7bac6
(cherry picked from commit 4dfba3b59021f55957fc486531f8fdc67cc307b0)
|
|
Change-Id: I177e6a63dfcb23416fb383901490a96e59096e98
|
|
Change-Id: I7049e45b1f1f22e32cc4bcbda89586491c4c5d9b
|
|
Change-Id: I59b71ee6815cbcfa4c8b5f68ae6dc9299856d49e
|
|
Change-Id: I43ed9f53618dca09e0289bffadc2c05056e0eebb
|
|
Not ideal, not suitable for Android etc. Better fix in online/master.
Change-Id: I49299cdae19fa91c294196e6d82582aaf376fab7
Reviewed-on: https://gerrit.libreoffice.org/35338
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
|
|
More important is always to perform the paint.
Change-Id: I392dd6cea4a5f43a646fca04d284b365b5fb5b78
|
|
Change-Id: I5469332c4ef98bce8cd9c2caff5bf61dbf102b23
Reviewed-on: https://gerrit.libreoffice.org/32688
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
|
|
Change-Id: Ie7c55c3a5c366618cafa51f9f1a102fb3cb26ec5
Reviewed-on: https://gerrit.libreoffice.org/32691
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
|
|
Change-Id: Ib0ec104b14385473a2a7f7dc2a33558d998996fa
Reviewed-on: https://gerrit.libreoffice.org/32690
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
|
|
This reverts commit fe87a31885dc870a9a8e4c4dcb105a4a5627164f
Change-Id: I8fb9b67696913c1de0778d22b242673c89b07813
Reviewed-on: https://gerrit.libreoffice.org/32689
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
|
|
Change-Id: Ib9fb351996cd63280cc138f43c900b97b9beaf40
|
|
As per http://support.microsoft.com/kb/157482, the files are plain-text
files with an URL and optional GET and POST parameters (static and
dynamic).
This commit introduces basic support to open these files
(without support for POST and dynamic parameters).
Reviewed-on: https://gerrit.libreoffice.org/34928
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit 099f9406b6657a03a37fbe5cedf7cb7da765d4aa)
Change-Id: Ib733c97780d363243644247196402f402c495cd1
Reviewed-on: https://gerrit.libreoffice.org/35011
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
|
|
Same code which was added to the method
DrawingFragment::onEndElement() in
d178d7bef193565a7d6aacbc37a58dfc4bd7b316
A shape's size and position inside a chart object
are primarily defined by <cdr:from> and <cdr:to> tags in
drawing.xml, but in the same file we also have
an <a:xfrm> tag which is used for the same thing
(defining size and postion) in general. Testing with
MSO it seems it ignores what values are set to <a:xfrm> and
uses only the <cdr:from> and <cdr:to> values.
The test document showing this problem must be created
an earlier version of MSO, becuase <a:xfrm> is set to some
random values. Editing the chart and saving it with MSO
2013 the <a:xfrm> values are set consistently with
<cdr:from> and <cdr:to> pair.
Reviewed-on: https://gerrit.libreoffice.org/35069
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
(cherry picked from commit aa204f1c09a760d6753c408376ab7307fb13ad91)
Change-Id: Icbaff78e5a6fcea36678c3b3755c97f57976b626
|
|
the start value is out by one row
Change-Id: I77ed154358516ccd47a090cf7ed45bb609bc81a3
Reviewed-on: https://gerrit.libreoffice.org/34995
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit a99f52608f38fb6be309fdfa22c7f4c418031394)
|
|
Without fully understanding the code, best to let the condition be
there. Use the same function to check for validity as before.
(IsValid() which was renamed to IsValidForXml().)
(cherry picked from commit a77908a2d82986ad9d2d9597536d1e22ce2cafd2)
Change-Id: If50df539737352f12cb0178706cbc38512a99366
|
|
What an odd restriction. Oh well. Don't export the conditional formats
for the cell(s) in that case then.
See https://msdn.microsoft.com/en-us/library/03AE6098-BDC2-475B-BA2C-B8AEF7882174
Change-Id: I4eeec8d33f9fbc572a02f727f38564d6c43b4f10
|
|
Its length must be greater than or equal to 1 and less than or equal
to 54, so if the author is empty, use a single space, and otherwise
truncate to max 54 characters.
See https://msdn.microsoft.com/en-us/library/dd945371
Change-Id: I7604ae9e1d8eea336b42116ea7d305e183e6ca51
(cherry picked from commit 27e34a7dbb9aa2ce52ca529ec835d54c6a5508fc)
|
|
Change-Id: I59d46f6a713e4f252844cda0f631ace239d73cdb
Reviewed-on: https://gerrit.libreoffice.org/32115
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 36cdf3c35459df63ce137e550a6840a61865c0ca)
|
|
See https://msdn.microsoft.com/en-us/library/dd952807 :
nts (26 bytes): An optional FtNts structure that specifies the
properties of this comment object. This field MUST exist if and only
if cmo.ot is equal to 0x19.
Change-Id: Ib4a007940c29a4f8eac1087601cfc7d242cfebd3
(cherry picked from commit 20a7d4b16d600101f4073ad4ce669a7566bf14c1)
|
|
Change-Id: Ife4449f5afa7321c18e8eb963878d9c037f6d623
(cherry picked from commit 93a53e0ebba62873c768d887c6aa1125967aa9e4)
|
|
The constants were commented out, so uncomment them.
Probably lots of the same left.
Change-Id: Iac87bef3bc331ae126741efbb4d58cc539e5a42a
|
|
So generate such a record only when the protection state is on.
See https://msdn.microsoft.com/en-us/library/dd922139(v=office.12).aspx
Change-Id: I710395527cd53dc47018806e51fcc699e11fb461
(cherry picked from commit 4a332d54b80bbc502ccc98bf924a269e00c10070)
|
|
See https://msdn.microsoft.com/en-us/library/dd908919(v=office.12).aspx .
This means we will never set the EXC_FORMULA_RECALC_ONLOAD flag, hmm?
Change-Id: Ic081caa7f98426394cbc7b0b320fa1a5a9a34f6c
(cherry picked from commit 727ee3f92a8882914ac3f68eaf53ac519ace5f38)
|
|
See https://msdn.microsoft.com/en-us/library/dd906117(v=office.12).aspx .
Change-Id: I4ff278f4cdd388947bbe81b88b6c39ff2b208b1a
(cherry picked from commit 970f8dc7847967719652590f71f0f19e46ba7268)
|
|
Read also a type value from registry so user can specify
a type for a property of an extensible group.
Reviewed-on: https://gerrit.libreoffice.org/34961
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
(cherry picked from commit 145accd9a5b55070959d40c9314d870dffa5e4bc)
Change-Id: I4105ba559a64ce96bfe5a390660ad7f349ba894c
|
|
This reverts commit ed930e8eabe20c3656720a3d7578fbb533296287.
|
|
Previous code unconditionally treated all cells in merge groups as
rows span, thus in some conditions it merged incorrectly when there
were cells from same row.
The fix is inspired by SwTable::PrepareMerge().
Also, fixed improper adjustment of too narrow cells in
WW8TabDesc::CalcDefaults(), which also happens in files where
column spans are represented by spanned 1-twip-wide cells.
Unit test included.
Change-Id: If043cfc466879d45141c655f7be1588792f898d3
Reviewed-on: https://gerrit.libreoffice.org/34820
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/34884
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
remove extra size in favour of vector size and don't resize
and memcpy data, just use vector::insert
Change-Id: I8efb91a8c11fbd862c0458042554cf7e94b813cd
Reviewed-on: https://gerrit.libreoffice.org/34893
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 789dc289b8b7ff79a6195e8648d0ac6be5cf13bb)
|
|
Change-Id: Icbd2608a3341652b1b40f6bdebb66c4caf6e810a
Reviewed-on: https://gerrit.libreoffice.org/34896
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 90643e244cbd42866a49a7cf878dc9473ab2e6c0)
|
|
because the loss of focus in the current editeng causes writer annotations to
save their contents, making the pContent of the current EditMaps invalid
(cherry picked from commit 71a84b69ae30458a941f38869aa994118051a063)
Change-Id: Ic01379291fa66dd58246d33287b18801f5da49c0
Reviewed-on: https://gerrit.libreoffice.org/34614
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 612903384bbe68dfb3be1b36111e28b869aa0be8)
|
|
when generating a new one, otherwise on exporting the same table
twice to two consecutive .doc footnotes will think the second
export of the table is a level lower because it will find it
in the map and
WW8TableNodeInfo::Pointer_t WW8TableInfo::insertTableNodeInfo
does pNodeInfo->setDepth(nDepth + pNodeInfo->getDepth());
using the cached pNodeInfo depth and not a new fresh pNodeInfo of
depth 0
Change-Id: I7aa7ac6a19814910c1d19d78f04cfd9886c444c5
(cherry picked from commit 6f3e24ad64dd40b3ef8def7d879ba395a16874a1)
Reviewed-on: https://gerrit.libreoffice.org/34766
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit c496b67a52ee4b5c7f9053cfe3dc54290e8d6392)
|
|
Change-Id: Ib0945d5a4606915aff9ee3019203caaf2a3cc7c5
(cherry picked from commit aacaacc16938b030a1341d8dbaf56c6a2efeb1dc)
Reviewed-on: https://gerrit.libreoffice.org/34744
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 92fcd775ef67df1c96a417151a60a94530379b8f)
|
|
cause it grows to fit if its a resizable stream
Change-Id: I28b42becdfc8eb591d19d2512cdc1f1ec32c3bbe
(cherry picked from commit a42d9c5b541d637dcf24086e30f341b30e03c4c7)
Reviewed-on: https://gerrit.libreoffice.org/34754
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit 19561b0a54d0753db860e3b06b7b2ebba45a801c)
|
|
Change-Id: Ie35617997845de25af9e528668bce4c332ac408a
(cherry picked from commit 1c29456c9c9007b788297aebea58a1a765f77c84)
Reviewed-on: https://gerrit.libreoffice.org/34786
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit f96840d17562250aa7ac55f99934ee938008ce0c)
|
|
Change-Id: I786b5d6fb10afe3ebb8482f999115fe72ffe2d4c
Reviewed-on: https://gerrit.libreoffice.org/34853
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit f8de39789767f58c03b149371388a92722cb0427)
|
|
(cherry picked from commit 7277991e78c264025b4894ae07b40fb12cd57ce6)
Reviewed-on: https://gerrit.libreoffice.org/34374
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 3d9e1d16b884417ec892f67da625cf02d897f2cc)
Change-Id: I2120f13fff58d4736ab55071236e0c2f80ba2eb0
|
|
Commit c2ccd20c0fd92bddfff76447754541705e3eb8f3 introduced 0 as a valid
value for page number offset in sw core.
Unfortunately the table dialog was not changed then; previously
page number 0 would do automatic numbering, but since then 0 was set as
the offset, and once you have a 0 offset there's no easy way to remove
it, you have to remove the whole page break.
* change the label before the text number edit widget to a checkbox
that disables the edit widget
* keep the id "pagenoft" so that translations still work
* set initial value to 1; 0 is a really bad default since we can't
export it to ODF
* add a little bit of left margin so the line is indented below the
upper line
(cherry picked from commit c1e7fc6f497d7570cb0832c43647d295f8592567)
Reviewed-on: https://gerrit.libreoffice.org/34763
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 362ff67556cca0890ca01f2de44596491c0e9bc8)
Change-Id: I70cf5a66d4191acd2c19b3d0a83609e2b348a886
Reviewed-on: https://gerrit.libreoffice.org/34811
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit e4f50efd000734c8259ed2915bf0dd1c71700ceb)
|
|
Commit c2ccd20c0fd92bddfff76447754541705e3eb8f3 introduced 0 as a valid
value for page number offset in sw core.
Unfortunately the paragraph dialog was not changed then; previously
page number 0 would do automatic numbering, but since then 0 was set as
the offset, and once you have a 0 offset there's no easy way to remove
it, you have to remove the whole page break.
* change the label before the text number edit widget to a checkbox
that disables the edit widget
* keep the id "labelPageNum" so that translations still work
* adapt SfxToSwPageDescAttr so it can not just set but also clear the
page number
* set initial value to 1; 0 is a really bad default since we can't
export it to ODF (see tdf#91306)
(cherry picked from commit d36fa0589ab822dc617c65b4d0d3bf68c092ad37)
Reviewed-on: https://gerrit.libreoffice.org/34745
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit a5104f575a5acf8aea957cb79aa0fd67bc74f141)
Change-Id: Ic4ca9e2562bb65ac359b305a2202f782e8598307
Reviewed-on: https://gerrit.libreoffice.org/34810
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit c43cc2d70a8083c70e615335d19780bd59f40fd8)
|