summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2016-07-22Resolves: tdf#100845 exception during vcl painting -> std::terminatecp-5.1-2Caolán McNamara1-9/+16
GetText throws under the circumstances described in the bug where the record is missing Change-Id: I03b0ce9a19d93a7eb8842831b433b80a20628541 (cherry picked from commit d8e225304b7c8465f5e7f038ec02270445e1b600) Reviewed-on: https://gerrit.libreoffice.org/27341 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 90a26f7501b3829eba28e61f5dbae6ce6927b1f1)
2016-07-22Resolves: tdf#101011 atk needs a value for accessible-table-column-headerCaolán McNamara1-1/+15
This presumably became a problem after... commit 76c549eb01dcb7b5bf28a271ce00e386f3d388ba Author: Steve Yin <steve_y@apache.org> Date: Fri Nov 29 13:03:27 2013 +0000 Integrate branch of IAccessible2 added a TABLE_COLUMN_HEADER_CHANGED usage which triggered it. Change-Id: If54b7a39a170566cf7def3548ba385fa5d99bb1c (cherry picked from commit 9b47a8b21f87fa77d2d61ac4a2c2bbc7c0d67a19) Reviewed-on: https://gerrit.libreoffice.org/27369 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit a768e5b7ff3a4788bbe6d23e427e34e9e81442c1)
2016-07-22Resolves: tdf#101054 crash on options->path with non-native file pickerCaolán McNamara1-1/+0
regression from... commit 3bbc0574d78d129359638b74612de2f93419eeb0 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Jul 5 10:16:51 2016 +0100 Resolves: rhbz#1352835 path options doesn't promptly destroy folder picker only clear the xFolderPicker immediately in the non-async case Change-Id: Id6a411424d41262a9379ad3eb7976c8dd666a5cf (cherry picked from commit c1bd3156cf66318023f36d81ce809a38072588e4) Reviewed-on: https://gerrit.libreoffice.org/27418 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 354c148edce5cafa1efb136630618f3063ce3c99)
2016-07-22Resolves: tdf#100558 last 'section' of date field not incrementedCaolán McNamara1-1/+1
presumably a regression from... commit 3cad6c806e5247ce20b78eb688551aa5d872b934 Author: Chr. Rossmanith <ChrRossmanith@gmx.de> Date: Fri Mar 1 21:47:10 2013 +0100 Replace (Xub)String with OUString in vcl(field) where UniString::Search returned a max short on not-found while OUString::indexOf returns a -1 Change-Id: Ia3ef80dd318375ccdb3bdcee9bed7b70bf67cae1 (cherry picked from commit 82913e694a4169f9ddeef399e659aec78cc9c8d6) Reviewed-on: https://gerrit.libreoffice.org/27375 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 836a7634b2042de4f08fcc2296fc33ca2d040a60)
2016-07-22Resolves: tdf#100847 also external svEmptyCell is 0 in numeric contextEike Rathke1-1/+1
Regression of 243f19a1878d52a4074b59041dc3bc57ab84e417 that now differentiates between numeric and string content of external references' cells. Change-Id: I7a9635357cc7651353067a38f9ac8bc295f88546 (cherry picked from commit 89a5464a21046821648ec77f03db8316ceb4e6f8) Reviewed-on: https://gerrit.libreoffice.org/27111 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 9c30e2aab23e34ba91dbe80b7dd5e5c352bbaeb0) Reviewed-on: https://gerrit.libreoffice.org/27372 Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 38aceeda9df7a04bff344c82c4bc077217b1178d)
2016-07-22Resolves: tdf#98778 fix parsing of exponentsCaolán McNamara1-0/+7
regression from... commit 9e9f39d171cafa035d7b8e74187e25c3581cb89d Date: Tue Mar 19 23:23:16 2013 +0100 resolved rhbz#919020 Basic CDbl() and CSng() scan localized number Change-Id: I96535fd9bc9ec59d6e07739a3118c96eb2d8bd05 Reviewed-on: https://gerrit.libreoffice.org/27342 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 2aed0d49d7891b9360916b65771222810aeeac96) Reviewed-on: https://gerrit.libreoffice.org/27350 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 43d1f9bfd4300e8bf5bcb631dcc2d849b4490d3a)
2016-07-22gtktiledviewer: align to top/left for CalcMiklos Vajna1-1/+11
Otherwise when zooming out enough that not all available space is used, the default horizontal/vertical centering happens, and the row/column headers and the tiles become out of sync. Also revert to the previous default window size, I'm not sure why that was necessary. Currently checking the mentioned situation (empty Writer document with comments only) does not require this larger size, and testing two views is easier with the smaller size. Change-Id: Ia92a591387f62655a671e2d09f5053827fde5045 Reviewed-on: https://gerrit.libreoffice.org/27427 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 672b7411637f92acd30622ec2aaee840cbbbd0a9)
2016-07-22sc: provide size in the payload of LOK_CALLBACK_DOCUMENT_SIZE_CHANGEDMiklos Vajna4-7/+46
The sw implementation does so, and the API documentation also says clients can depend on this. Change-Id: Ib4d25d7207fd8358de2ec1186d4ca2306e996497 Reviewed-on: https://gerrit.libreoffice.org/27379 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 27aac319ca9f2d580aea45542c5d0428616f7e0b)
2016-07-21sd lok: fix hard to select a full tableHenry Castro3-9/+9
It requires a precise mouse down button in the rectangle border bounds to select a full table, so it has added a tolerance value. Reviewed-on: https://gerrit.libreoffice.org/27356 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com> Conflicts: include/svx/svdotable.hxx svx/source/svdraw/svdview.cxx svx/source/table/svdotable.cxx Change-Id: Ia8213ae452f93cd2faa957a50246638d1eb2198e
2016-07-21CppunitTest_sd_tiledrendering: fix undefined behavior, leading to crashMiklos Vajna1-2/+2
Execute() version that takes an std::initializer_list<> is named ExecuteList(). But that's not available in this branch, so make sure that the last argument is a nullptr. Change-Id: Iaa42ac417abec334b1c053fb7d357dce529c6956
2016-07-21sd lok: decouple vcl window focus from cursor visibilityMiklos Vajna8-17/+55
The problem was the the blinking cursor was hidden when another vcl window got its focus, so it wasn't possible to edit two shape text in parallel in two windows. The code path is like this: - show cursor, cursor is created: SdrObjEditView::SdrBeginTextEdit() -> OutlinerView::ShowCursor() - show cursor, focus case: sd::FuText::Activate() -> OutlinerView::ShowCursor() - hide cursor, cursor is deleted: SdrObjEditView::SdrEndTextEdit() -> OutlinerView::HideCursor() - hide cursor, focus case: sd::FuText::Deactivate() -> OutlinerView::HideCursor() So add a new optional bool parameter that allows not emitting the LOK_CALLBACK_CURSOR_VISIBLE callback in the focus change case. Also, if we're at it, make sure that painting emits no show/cursor LOK callbacks. Change-Id: I1068a1b1f5cd76fd09b5a79066834bfb0daebc77 Reviewed-on: https://gerrit.libreoffice.org/27335 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 6ea8084487411feea049f57712979fba4ad2fbce)
2016-07-21lokdocview: still allow view selections/cursors from other Writer viewsMiklos Vajna1-4/+10
Writer pages are exposed as parts, but it still makes sense showing selections/cursors from other parts in that case. Change-Id: Ic76d93291bde2d959c149cf2ef5eba7ed33a45e8 Reviewed-on: https://gerrit.libreoffice.org/27321 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 3c425926d48e513937ad727a56ab7744ca379e63)
2016-07-21sc lok: notify other views about selection changes of multiple cellsMiklos Vajna3-1/+54
A single cell is handled by the cell cursor, which was already handled. This one takes care of the situation when multiple cells are selected. Change-Id: I11b3045e4884ad9629655e2c05c16af83d21e7b2 Reviewed-on: https://gerrit.libreoffice.org/27318 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 495cfa27c173741caa233575438c18746272b4aa)
2016-07-21lokdocview: handle part number in view selections/cursorsMiklos Vajna1-23/+68
This way we show view selections/cursors from other views only in case the part number matches. Anything else looks buggy in Calc/Impress. Change-Id: If3ecbfc4b05350606730319b1a570afc15fd9d0a Reviewed-on: https://gerrit.libreoffice.org/27315 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 1ba00c2173938ed2ea2f25074e866ea51370d727)
2016-07-21sfx2 lok: expose part number in SfxLokHelper::notifyOtherViews()Miklos Vajna14-13/+104
This way a client can decide if the view cursor it gets is relevant (the views show the same part) or not. Change-Id: I7b274b28f0c4f0509df5071831acf50512eff640 Reviewed-on: https://gerrit.libreoffice.org/27311 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 299b9377469473abd8f58ba7f1054794491bdc56)
2016-07-21CppunitTest_sw_tiledrendering: blind stack-use-after-return fixMiklos Vajna1-0/+4
Change-Id: I23c0324979939955f94408a452020e9776358967 (cherry picked from commit 58b592a59122144d6c5446f200dd2f48108c8909)
2016-07-21lok::Document::destroyView: clean up view cursors/selectionsMiklos Vajna4-1/+72
(cherry picked from commit bc9b4fd4c83af3532204237157821d4884c42d8e) Conflicts: sd/source/ui/view/ViewShellBase.cxx sw/source/uibase/uiview/view.cxx Change-Id: Icd3f96a922e7d1aec0d52e90df87ec45790c9807
2016-07-21sfx2 lok: handle when SfxViewFrame::Current() returns nullptrMiklos Vajna1-15/+2
In these two cases no need to call it and dereference the result unconditionally, there are other ways to get the info. Change-Id: Idb5969e909dc2faed97a5a4ac79dfcc1aec8ddcd (cherry picked from commit 85c5a172953ac29d1fcab3f4c2f19fa897074e52)
2016-07-21lokdocview: ignore notifications on view shutdownMiklos Vajna1-0/+9
Callbacks are processed on idle on the main thread, so by the time we parse them, possibly the widget is already gone, avoid that problem. Change-Id: Ie8e16423d1ffe087e0dd21425026f7a5d644c27b (cherry picked from commit 8090b53e0e16e9aef95f2f5557985f7c2e7c69f3)
2016-07-21gtktiledviewer: allow testing of destroyView()Miklos Vajna2-7/+23
By calling it when we're not the last window. Change-Id: I6fd4763243fc088ccfe015b6c03b6b3f25146fac (cherry picked from commit 99f05d9947db2dd0676fafa66106d17e4d8eea6d)
2016-07-21sw lok: fix shape text editing with multiple viewsMiklos Vajna1-6/+3
When changing the active view shell, sw::DocumentLayoutManager::GetCurrentViewShell() is not instantly updated, only when e.g. the focus changes. This means that calling setView() + paintTile() pairs on random views typically did not use the matching view shell, but the last one. This has a visible effect when editing shape text, as the non-text-edit views had the outdated shape text visible, unlike on the desktop. Fix the problem by using SwDocShell::GetWrtShell() instead. Change-Id: Ia4b67d0a8931692ed4fc5c5e97cc1a09ef81e647 (cherry picked from commit 5a3653f87502e40cf00d8f1ed1c0ecf5a979e67d)
2016-07-21vcl headless: ignore visibility in GetClientSize()Miklos Vajna2-14/+2
This fixes the missing-invalidation problem outlined in commit 22023b104cd1e024aecc28a6161bea519a584407 (vcl lok: fix missing paints due to zero-sized windows, 2016-07-12) also in Writer, not only in Impress. Starting text edit, doing a change, and ending text edit now results in the expected invalidations. Ignoring visibility seems to be a better fix for the missing paints. This way the headless case doesn't hit the corner cases of 0x0-sized windows. Also, the gtk vclplug's GetClientSize() only returns 0x0 in case the underlying window is disposed or it's minimized, but it does hand out the size before Show() is called, so now the headless backend is in sync with that. Change-Id: I78698cbfce954c8c593d279ab057a87cfbe87260 Reviewed-on: https://gerrit.libreoffice.org/27224 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit ac0b3b05ab52d0ac06137cf93d71187c7957ec99)
2016-07-21vcl lok: fix missing paints due to zero-sized windowsMiklos Vajna1-0/+8
How to reproduce the problem: open an Impress presentation in gtktiledviewer, create two views. Start editing the text of a shape in one view -> nothing happens in the other view. There is no invalidation in the other view, as sdr::contact::ViewContact::AddViewObjectContact() is not called for either of the views. Editing with a single view only worked as when clicking into the shape, the ViewObjectContact is created. On the desktop, those ViewObjectContacts are created on the first paint of the slide, but in the LOK case the vcl::Window instances had a 0x0 size, so an invalidation didn't result in a paint -> no ViewObjectContact was created -> no LOK invalidation was sent. No testcase, as I didn't manage to write code that actually triggers the failure under cppunit with the fix reverted. Change-Id: If29fcea4258a45f3d6d9aab284445756609fa13c Reviewed-on: https://gerrit.libreoffice.org/27159 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 22023b104cd1e024aecc28a6161bea519a584407)
2016-07-21lokdocview: log the view id of the callback messagesMiklos Vajna1-1/+4
So that e.g. it's possible to see which invalidation affects which view. Change-Id: I6b6db2fa07eaecd1315ce8160c3b3b86e9e5a348 Reviewed-on: https://gerrit.libreoffice.org/27138 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 29089b562ea6d0137cf054d9710b7238e327aa4f)
2016-07-21tdf#100600 sfx2 classification: never replace the control with labelMiklos Vajna2-1/+9
Thanks to Caolán McNamara for pointing out where is the condition of the replacement in VCL. Change-Id: I7e1ef4a016a37b25e084c4c6467a42ca557069a4 Reviewed-on: https://gerrit.libreoffice.org/27133 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 8192da8e4de7a058ef95253f992f4143f83fa0f1)
2016-07-21sw lok: add LOK_CALLBACK_VIEW_CURSOR_VISIBLEMiklos Vajna5-4/+88
With this, in case a text cursor is turned into a graphic selection in view#0, then view#1 can also hide the text cursor of view#0. Change-Id: I7de89b8537ef8b0985336793b719d93733604bff Reviewed-on: https://gerrit.libreoffice.org/27044 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit af8419fa1d3cea57481e0e53518237eea2d9cdad)
2016-07-21svx lok: add LOK_CALLBACK_GRAPHIC_VIEW_SELECTIONMiklos Vajna6-4/+137
So a view can be aware where the graphic selections of other views are. Change-Id: I0cc420cfe4bf3824fbfa1a58da889cac5e9a7b60 Reviewed-on: https://gerrit.libreoffice.org/26863 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 3ebfc5b95559a9bcb2fc0508b51fd00e8eb20260)
2016-07-21lokdocview: replace handle_graphic.png with manual drawingMiklos Vajna3-28/+7
If we draw a black graphic handle manually, then it's possible to color it later, this isn't easy if a bitmap is painted. Reviewed-on: https://gerrit.libreoffice.org/26860 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit cca44fe22978c6c1c5f3ec500e5ac07becf53745) Conflicts: scp2/source/ooo/module_libreofficekit.scp Change-Id: Ib4456fd5155862d52e3ffa79ee49c7bfd16fb742
2016-07-21CppunitTest_sc_tiledrendering: clear reference to local var in timeMiklos Vajna1-0/+2
Should fix <http://ci.libreoffice.org/job/lo_callgrind_linux/2013/console>. Change-Id: I4ff4ddafbbb15ee360cb845afe8e8b4dbbf04460 (cherry picked from commit d77d81604d8604652772e0819e5cf5e472865c65)
2016-07-20sc: add LOK_CALLBACK_CELL_VIEW_CURSOR testcaseMiklos Vajna1-2/+64
Fails with the sc/source part of commit (sc lok: add LOK_CALLBACK_CELL_VIEW_CURSOR, 2016-07-01) reverted. Reviewed-on: https://gerrit.libreoffice.org/26856 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit e3c36c789f481b855c0fb556a09f4b81401ed3db) Conflicts: sc/qa/unit/tiledrendering/tiledrendering.cxx Change-Id: I4a1a7d97b744dd089fe15bd58af6cca5e0b79e8f
2016-07-20CppunitTest_sc_tiledrendering: replace ifdefs with a single makefile conditionMiklos Vajna2-16/+6
Reviewed-on: https://gerrit.libreoffice.org/26849 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 8e3451c096987e6fc7eaca409fd45a62e13ae4c5) Conflicts: sc/qa/unit/tiledrendering/tiledrendering.cxx Change-Id: I1dded11e0572dee7cd917a1aa8c2e2ca53b81d84
2016-07-20sc lok: add LOK_CALLBACK_CELL_VIEW_CURSORMiklos Vajna4-1/+64
So a view can be aware where the cell cursors of other views are. Change-Id: Ifcf06c0019c6af8b859e2e92222e4f3fd18da74f Reviewed-on: https://gerrit.libreoffice.org/26844 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 68c5c0bb7eed007bbfbb2e51107fc0196825e85a)
2016-07-20sw lok: mix missing invalidation due to page calc in visible cursor changeMiklos Vajna2-2/+51
Steps to reproduce in gtktiledviewer: - two windows, then enable edit in both - view #0: go inside a word - view #1: select the same word - press Del in view #1 -> no invalidation Fix the problem by changing the LOK-specific GetPageNum() call in SwVisibleCursor::SetPosAndShow(), so that it doesn't re-calculate the frame, that way later when SwLayAction::TurboAction_() attempts to re-calculate the layout, then the frame will be still invalid, and that re-calculation then triggers the necessary invalidations. Change-Id: I8c4472b9809537fcbd4a20c73f39be7ebca16b1f Reviewed-on: https://gerrit.libreoffice.org/26802 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 6168f10b6280b2d60de44a333f3f1dc23cbb9bcf)
2016-07-20lokdocview: avoid pointless setView() before getView()Miklos Vajna1-4/+0
This fixes the following use-case: 1) Start gtktiledviewer, click New View 2) Click Edit in the first view 3) Click somewhere in the document in the first view -> nothing happens Change-Id: I79d63538607f03b78851a639adf158d918745276 Reviewed-on: https://gerrit.libreoffice.org/26789 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit bfd4234fd863ee75f4f07d9bded061063bbde3d4)
2016-07-20LOK: change back type of view ids to intMiklos Vajna6-35/+53
Commit 45c2410041c48c22bd860efb42d4daadad7869b0 (LOK: change type of view ids to uintptr_t, 2016-06-17) fixed the problem of view IDs being reused for the price of random IDs, which makes debugging harder. Implement a simple shellToView() function that makes sure view IDs are not reused, and stop exposing view shell pointer addresses, which allows reverting the LOK API change. Change-Id: I63089e6de08ee7e1c7706757d43a11f6cf4d6e06 Reviewed-on: https://gerrit.libreoffice.org/26773 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 615c37503cffa92a663245d7cb140f316ace0506)
2016-07-20framework: fix typo in dispatchdisablerMiklos Vajna1-1/+1
maDisabledURLs is a set, aDisabledURLs is a sequence, the intention is to copy the set into the sequence, not to copy the (empty) set into itself. Change-Id: Ib262e863b1f1aa4c455bd7552df3dc2c3f73a400 Reviewed-on: https://gerrit.libreoffice.org/26765 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit f4f580f4a4683ab09c94cfd2dfa9d203881e3eb5)
2016-07-20Remove unused SfxObjectShell::libreOfficeKitCallback()Miklos Vajna9-31/+0
All clients have been converted to use SfxViewShell::libreOfficeKitViewCallback() instead. Change-Id: I793dad5194769f331037b12a1b1afba96ddea4ba Reviewed-on: https://gerrit.libreoffice.org/26584 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit ed2d342e97e43ff25f450ab6a5752baded6813e4)
2016-07-20Remove no longer needed ImpEditView::mpLibreOfficeKitSearchableMiklos Vajna8-61/+2
All clients has been ported to use ImpEditView::mpLibreOfficeKitViewCallable instead. Change-Id: I3a2513ac5900f801a2e7aec79807f4e333dfba3d Reviewed-on: https://gerrit.libreoffice.org/26561 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 03e83de83bcc640cf359fe7997edcdadb5067b36)
2016-07-20lokdocview: ensure setView() + doSomethingElse is atomicMiklos Vajna1-0/+23
Otherwise it's possible that a keystroke is sent in for a different view, when that other view reacts to an invalidation (invoking paintTile()) caused by a previous keystroke. I.e. open two views, place the cursor at different positions, type fast, and some of the characters appeared at the incorrect view. Change-Id: Ie5e471f1b9c2d69adaa87111fba74d4abe184ef8 Reviewed-on: https://gerrit.libreoffice.org/26562 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 380a646b957052f96b3f9440d20dc63fc72e1d46)
2016-07-20sw: add LOK_CALLBACK_TEXT_VIEW_SELECTION testcaseMiklos Vajna2-4/+38
Fails with 9f66db9c474f71f43d7a3667230241fd4fa4183f (sw lok: add LOK_CALLBACK_TEXT_VIEW_SELECTION, 2016-06-21) reverted. Change-Id: Ide21167ce2dc4287b1860b5f03a6975dc9edd4c6 Reviewed-on: https://gerrit.libreoffice.org/26550 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 45182f36ef263d6fd94cc79bb242fbfb5a471c22)
2016-07-20lokdocview: handle LOK_CALLBACK_TEXT_VIEW_SELECTIONMiklos Vajna1-2/+28
It's similar to the normal selection, but it's colored and has no handles. Change-Id: Ibd9594b4834ff4f9b1cfd85912ed5cee3c8b8c71 Reviewed-on: https://gerrit.libreoffice.org/26543 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 6b9053d371fc8b8543faf7add5fb6d61aab26605)
2016-07-20sw lok: add LOK_CALLBACK_TEXT_VIEW_SELECTIONMiklos Vajna6-22/+55
So a view can be aware where selections of other views are. Change-Id: I5026b1ff2b99a4eedfd0bde32a05ceb8e2f424bc Reviewed-on: https://gerrit.libreoffice.org/26542 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 9f66db9c474f71f43d7a3667230241fd4fa4183f)
2016-07-20Remove no longer needed vcl::ITiledRenderable::registerCallback()Miklos Vajna7-28/+0
All clients has been changed to use SfxViewShell::registerLibreOfficeKitViewCallback() instead. Reviewed-on: https://gerrit.libreoffice.org/26540 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit e65b5c19985d725779d8381cc3bd75c441c0ff2e) Conflicts: include/vcl/ITiledRenderable.hxx Change-Id: I2538268dc9c4b449f68b5d2b05a72de584c29fd0
2016-07-20sfx2 lok: fix missing view cursors in a new viewMiklos Vajna4-2/+71
When a new view was created, the old views got the position of the new view, but not the other way around. Make sure that the old views notify the new one right after registering the callback. Reviewed-on: https://gerrit.libreoffice.org/26523 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 4d211384f048b689f20e46d4d586f342b110cb5c) Conflicts: sfx2/source/view/viewsh.cxx Change-Id: If26edbd57aa939e453d95f4907a0e5722329dd65
2016-07-20lokdocview: handle LOK_CALLBACK_INVALIDATE_VIEW_CURSORMiklos Vajna1-1/+58
It's similar to the normal cursor, but it's colored and does not blink. Change-Id: I6a869a98f46979946f320905426e016fe011cbc6 Reviewed-on: https://gerrit.libreoffice.org/26522 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit ada901d2c412f8a1b1ae668e883114ccb9c69277)
2016-07-20sfx2: implement per-view LOK_CALLBACK_CONTEXT_MENUMiklos Vajna2-121/+6
Reviewed-on: https://gerrit.libreoffice.org/26293 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commits b8a1d072ff8e686fad4a507b85d163d699ed59e0 and 5b5706f41f97998785e1e7ad356580772da80c42) This fixes the failing CppunitTest_desktop_lib in this branch. Conflicts: sfx2/source/control/dispatch.cxx Change-Id: Ia321d2f03bf77eba87b1135799b3cb0409f23ebf
2016-07-20Bump version to 5.1-2Andras Timar1-1/+1
Change-Id: I44c7803c5dde10e70d1a6d98c48d0abf0c0edc8f
2016-07-20update creditsChristian Lohmaier1-1083/+1110
Change-Id: Ie49cfb83d86e85b593958fc4048022f71c351267 (cherry picked from commit bd894e5a7b9a9d6a3d3e4ea668bfea050ef39bae) (cherry picked from commit 8a22eab3b59d7188bf40f0fa3b25c2893cd06f85)
2016-07-20vcl: This seems a missing returnTakeshi Abe2-2/+2
Change-Id: I99c3be904e9ee2ad8f76d09d1d8998a6898fb81e Reviewed-on: https://gerrit.libreoffice.org/27283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 0789b66353f75f4791754727629f553aa717be67) (cherry picked from commit fbb6ec09e9e9c6afcce24a5fae1996d14d5866bf) (cherry picked from commit 4fe7a96d25791d40a3a56c836ba03931e30131e4)
2016-07-20protect against empty m_aTableManagers stackCaolán McNamara3-10/+19
Change-Id: I29fecc5e0efb3b3d907f0c6505d42818fa464ffc (cherry picked from commit 9d76d9d9abb08788f2882612cfe6d0df6e19af39) Reviewed-on: https://gerrit.libreoffice.org/27281 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 808d72592aa6e9a9f9a8eddd4dada0fa9f14749c)