summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2019-07-09android: Allow specification of the API level.cp-android-20coas-0.1.0Jan Holesovsky1-1/+14
Change-Id: Icf33e2703f42a7866ce895437cf5f276066eeebe
2019-07-09android: Allow using SDK and NDK directly from the Android Studio.Jan Holesovsky4-12/+18
Just specify: --with-android-ndk=$HOME/Android/Sdk/ndk-bundle --with-android-sdk=$HOME/Android/Sdk in your autogen.input, install the appropriate components via Android Studio and you are done. Includes support for NDK 19 and bumps the minSdkVersion to 16, because that's the lowest that the NDK 19 still supports. Change-Id: Ic99790b781b9017eb4e642380e230d6f7b49e9b7
2019-07-09Show who has locked the document when reopening a read-only documentMike Kaganski4-36/+84
Pass the locking data from SfxMedium::LockOrigFileOnDemand, to allow clients to show it themselves when required. Change-Id: I6afe46a1896e1b60771c080efa2f58794dbed8a6 Reviewed-on: https://gerrit.libreoffice.org/75113 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/75137 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/75285 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2019-07-08sw: fix gcc-4.8 buildMiklos Vajna1-1/+1
Change-Id: Ic912a3760ab0faa2db647a74a9290edd04a1de0e Reviewed-on: https://gerrit.libreoffice.org/75221 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-08sw lok: hide UI to set Word-incompatible anchor typesMiklos Vajna4-1/+39
Let's make it a bit harder for users to hurt themselves, at least in Online. Affects the context/popup menu and the dialog of frames. This is similar to how certain border types are hidden on the UI, depending on if MSO supports them. Though that goes a bit further and disables those types even on the desktop. (cherry picked from commit 4154d281fbecaadf6cd118c00cc6cff929e339a4) Conflicts: sw/source/ui/frmdlg/frmpage.cxx Change-Id: I6b9205ef3df8a7bc15fbcf787d134743c09e98da Reviewed-on: https://gerrit.libreoffice.org/75196 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-08sw comments on frames: fix comment insert for as-char frame at para startMiklos Vajna2-21/+30
This adapts SwWrtShell::InsertPostIt() to behave similar to commit 86fd893e32ef7a737b2c4b60e0938146b102fc07 (sw comments on frames: delete comment of frame when deleting frame, 2019-07-03), i.e. instead of hoping that the cursor will be at the end of paragraph and traveling back, just set the cursor to the remembered anchor position. This is cleaner, and as a side-effect also fixes the scenario when creating a comment on an as-char image, which happens to be at the start of the paragraph. Change-Id: Iedca0feb62242677b6e8b69ef7b813d6da72c8eb Reviewed-on: https://gerrit.libreoffice.org/75093 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit b382025abcd05ff75dd2cbe46df76213d4913f00) Reviewed-on: https://gerrit.libreoffice.org/75123 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-08sw: insert image: set anchor to as-char by defaultMiklos Vajna1-0/+5
See the mailing list thread at https://www.mail-archive.com/search?l=mid&q=999e55c8-5d15-1014-e6f9-9f3d19d003af@collabora.com (minutes of ESC call ..., 2019-05-09) for motivation, this is meant to improve Word compatibility, by not defaulting to the at-paragraph anchor type, which is unavailable in Word. See tdf#45778 and tdf#87720 for related bugs. (cherry picked from commit 4f40bf6a79de6d60da0a5090cdfeda6242e889f0) [ Testcase not backported, testPasteListener is missing on cp-6.2 and we would extend that. ] Conflicts: sw/qa/extras/unowriter/unowriter.cxx Change-Id: I2699ce04dce02e8436dc3af3b2cc8778f8dc476c Reviewed-on: https://gerrit.libreoffice.org/75122 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-08sw comments on frames: delete comment of as-char frame when deleting frameMiklos Vajna2-3/+20
Also make sure that we only recognize postit fields as comments, not other fields. Change-Id: I31c8e5d46bb7681710734c5a0b8a26c3a70f417e Reviewed-on: https://gerrit.libreoffice.org/75072 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit dcfe6eaee16cac0aff4a66efbe19c69431579485) Reviewed-on: https://gerrit.libreoffice.org/75121 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-08sw comments on frames: delete comment of frame when deleting frameMiklos Vajna2-0/+53
Also group the two actions together, so only 1 undo action is visible to the user, not 2. (cherry picked from commit 86fd893e32ef7a737b2c4b60e0938146b102fc07) Conflicts: sw/qa/extras/uiwriter/uiwriter2.cxx sw/source/uibase/wrtsh/delete.cxx Change-Id: Idba5a63b1653e96db4f9567a38b3f4ca740eb1df Reviewed-on: https://gerrit.libreoffice.org/75120 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-08sw comments on frames: fix DOC handlingMiklos Vajna6-8/+55
The export part didn't use HasFlysAt() to decide what to do with empty annotation marks. Regarding the import side, the only problem was that the start of the annotation range wasn't adjusted to cover the comment anchor, similar to what the UI and the UNO API already does. (cherry picked from commit 132803f99818bffbdc260918ad7a304f228f2843) Conflicts: sw/qa/extras/ww8export/ww8export3.cxx Change-Id: Ibcbaafa9f3f70de95a70b424aca31ebdc9df099d Reviewed-on: https://gerrit.libreoffice.org/75119 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-08tdf#125655 disbale quick edit mode for iOS and AndroidTomaž Vajngerl1-0/+11
When clicking (tapping) on text in text based objects (shape with text or a text frame), it automatically enters editing mode, which is not a desired behaviour in a touch based environment. This behaviour comes from a quick edit mode, which is enabled by default on the desktop. For Andorid and iOS this is now disabled when LOK is initialized. For online this change might also make sense (if the user would use a mobile device), however this is not implemented now as this would require more than just changing the global configuration, as it needs to behave differently depending on the view/user. Change-Id: Ib4a71cba0aeb4238a5d5b708801a07b39fb5f316 Reviewed-on: https://gerrit.libreoffice.org/74986 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 7d32994ad9dc45c7846664ec5ccb03bb796bb071) Reviewed-on: https://gerrit.libreoffice.org/74987 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2019-07-05Center spsupp_helper dialog on screen; make it topmostMike Kaganski1-2/+2
Change-Id: I99cf333a24ddf99407b406e42930d58dc7b5fb96 Reviewed-on: https://gerrit.libreoffice.org/75076 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 64376d29b4f02440544a1dc71118c2cf19b8df94) Reviewed-on: https://gerrit.libreoffice.org/75088 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/75090 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2019-07-04tdf#126114 - Form fields are displayed twice (double)Tamás Zolnai3-1/+8
We need to make sure that IsFieldResultAsString() returns true for drop-down field, to ignore the placeholder string. Reviewed-on: https://gerrit.libreoffice.org/74752 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 8e5982d799e23bee86404f3ccb3aaed524ae9675) Change-Id: I127800bdff78eb68e000fdbfe433bc88181ac2c3 Reviewed-on: https://gerrit.libreoffice.org/74800 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-07-04vcl lok: pre-load graphic librariesMiklos Vajna3-0/+31
This is needed to be able to load e.g. TIFF files in Online, which does not have code in the chroot since online.git commit ad21717498cc214d5d5d5c0ff378238552137e2f (Avoid copying most code into the chroot jail., 2018-03-10). Conflicts: vcl/source/filter/graphicfilter.cxx Change-Id: Ib095191ee690d9da6269878a82b1c6995df50dfa Reviewed-on: https://gerrit.libreoffice.org/75078 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-07-04sw: fix missing registration of CppunitTest_sw_unowriterMiklos Vajna2-0/+2
Mistake I introduced in commit 5ceee417fef834cd6b033603d72eaf4708970a1d (svtools: expose document position in DocumentToGraphicRenderer, 2019-01-04), which was a backport from master. The original master commit didn't have this problem. Change-Id: I55d4dc7482e8fbea9bcfb8c33f7c1c490c167b67
2019-07-04sw comments on frames: fix DOCX handlingMiklos Vajna10-20/+88
We used to ignore annotation marks which just cover the comment anchor since commit fff019debf14a0bf8cd358591a686191347f1542 (MSWordExportBase: ignore empty annotation marks, 2014-09-17), but this means comments on images are lost. Pass around SwWW8AttrIter, so we can decide if we have a relevant at-char anchored frame in MSWordExportBase::GetAnnotationMarks(), without iterating over all frames in the document, which would be slow for large documents. Regarding the import side, the only problem was that the empty comment range resulted in a loss of annotation marks; fix that by using a marker while inserting. (cherry picked from commit 7fa96a3e4bdd384ad411e0bdc4e7c3f2ab920279) Conflicts: sw/qa/extras/ooxmlexport/ooxmlexport13.cxx sw/source/filter/ww8/docxexport.cxx sw/source/filter/ww8/docxexport.hxx sw/source/filter/ww8/rtfexport.cxx sw/source/filter/ww8/rtfexport.hxx sw/source/filter/ww8/wrtw8nds.cxx sw/source/filter/ww8/wrtww8.cxx sw/source/filter/ww8/wrtww8.hxx writerfilter/source/dmapper/DomainMapper_Impl.cxx Change-Id: I385677d74423bc05824dac4a12d1a991bb3983c4 Reviewed-on: https://gerrit.libreoffice.org/75039 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-04sw comments on frames: fix UI to be able to annotate with at-char anchorsMiklos Vajna7-3/+69
We used to just comment the doc model position at the end of the paragraph of the image anchor. Change this, so that in case an at-char anchored image is commented, first we insert the comment (which creates a placeholder character), and then we set the annotation range to cover exactly that placeholder character. This results in a layout that shows a commented image. (cherry picked from commit 5cb34f1c38be72047be1c4ed8357c5e87134c6a2) Conflicts: sw/qa/extras/uiwriter/uiwriter2.cxx sw/source/uibase/inc/fldmgr.hxx Change-Id: Ie21d62ddb9f55f3e06ee39d9eccfaa0446ce7845 Reviewed-on: https://gerrit.libreoffice.org/75038 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-04sw comments on frames: fix layout to place anchor next to the imageMiklos Vajna4-7/+102
With this, if you load sw/qa/extras/unowriter/data/image-comment-at-char.odt, the comment anchor leads to the commented image, not to the anchor of the image (between "aaa" and "bbb"). (cherry picked from commit ac246d6ea1bc43bfc82c9b4c69c9c0f1fd678129) Conflicts: sw/qa/extras/unowriter/unowriter.cxx sw/source/core/fields/postithelper.cxx Also squash in: Adapt new test to actual values observed on macOS The test against 5892 was introduced with ac246d6ea1bc43bfc82c9b4c69c9c0f1fd678129 "sw comments on frames: fix layout to place anchor next to the image", causing various macOS builds (<https://ci.libreoffice.org//job/lo_tb_master_mac/30338/> and <https://ci.libreoffice.org//job/lo_tb_master_mac_dbg/26914/> as well as my own local build) to consistently fail with 6283 instead, for whatever reason. So, at least for now, adapt the test to check for >= 5892. (cherry picked from commit cf5a3cb687a502e7f71cefb5f7001a73925bee56) Change-Id: I99389c9fc849269eb20d0266f8f604db89faec12 Reviewed-on: https://gerrit.libreoffice.org/75037 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-04sw comments on frames: fix annotation start order in UNO portion enumMiklos Vajna2-7/+51
The problem was similar to commit 76a4305d1e90b6617054dd33036e64f005dbcf04 (sw: fix inconsistent bookmark behavior around at-char/as-char anchored frames, 2017-12-21), except here we have an (annotation) mark which does have a range, but still around at-char anchored frames, similar to the bookmark situation in that commit. Fix the problem similarly, by first adding comment-start portions to the enumeration, then frames, and finally the rest of the comment portions (as before). With this, an ODF <office:annotation/><draw:frame text:anchor-type="char"/><office:annotation-end/> sequence (commented at-char image) is roundtripped correctly. Reviewed-on: https://gerrit.libreoffice.org/74503 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit bf4b40f720146e7f76dab4deb72e85ea158e2d17) Conflicts: sw/source/core/unocore/unoportenum.cxx Change-Id: I8790d9efae625de48c689ca4180fe75f15b4833c Reviewed-on: https://gerrit.libreoffice.org/75036 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-04sw comments: allow ranges to be created which cover only the placeholder charMiklos Vajna3-3/+19
First, the old condition was a bit tricky: it wanted to avoid the case when only the placeholder character is covered, but given that start and end can be the same for collapsed ranges, this was true for comments without a range, too. In practice what remains blacklisted is just the case when the PaM has a mark, but it's the same as the point. The change has two motivations: 1) ODF can have '<office:annotation/>...<office:annotation-end/>', where '...' may be content which has no document position itself in the Writer implementation, like at-char anchored images. This change avoids loosing the range of such annotations during ODF roundtrip. 2) This starts adding support for comments on objects which don't have an own document position, though UI for that is still missing. (cherry picked from commit 34c008380b9c17a78b9fde8cfa2102ab14c2392b) Conflicts: sw/qa/extras/unowriter/unowriter.cxx Change-Id: If151b8e00e37e07830c0582b8f0920a91a787363 Reviewed-on: https://gerrit.libreoffice.org/75035 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-01Bump version to 6.0-33co-6.0-33Andras Timar1-1/+1
Change-Id: I7914a51dcd976e8685c761e6151000502148e311
2019-07-01sw: implement inserting comments when an as-char image is selectedMiklos Vajna6-0/+76
Only the UI was missing in this case: creating a text selection around the placeholder character does what the user expects. (cherry picked from commit 351b9aefe3de7c68e907fdc7926d9b508560320e) Conflicts: sw/qa/extras/uiwriter/uiwriter2.cxx sw/sdi/_frmsh.sdi sw/source/uibase/inc/frmsh.hxx sw/source/uibase/shells/frmsh.cxx sw/source/uibase/wrtsh/wrtsh1.cxx Change-Id: I1068fcee3e3b6d0a6fa47b37beb1bd1b918a82df Reviewed-on: https://gerrit.libreoffice.org/74424 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-01sw: extract postit insert code from SwTextShell::ExecField()Miklos Vajna3-64/+79
Into a new SwWrtShell::InsertPostIt(), so I can reuse it in SwFrameShell. (cherry picked from commit 485e048c391da38f883adfbef920069bd7af2305) Conflicts: sw/source/uibase/inc/wrtsh.hxx sw/source/uibase/wrtsh/wrtsh1.cxx Change-Id: Ib327aed033067250f021f3857f4ba3adb8e6c597 Reviewed-on: https://gerrit.libreoffice.org/74423 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-29Fix build error [-Werror=shadow]Muhammet Kara1-11/+11
Change-Id: Ie698f2aff96f60856bd4e8ed7125db9ddc0a3e74 Reviewed-on: https://gerrit.libreoffice.org/74884 Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-06-29lokdialog: Convert the Format -> Position and Size... to async exec for scMuhammet Kara1-51/+65
Change-Id: I715ed025d97de8eb69b6e9ba227b955b49add855 Reviewed-on: https://gerrit.libreoffice.org/74883 Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-06-29lokdialog: Convert the Format -> Position and Size... to async exec for swMuhammet Kara1-84/+94
Change-Id: Ie3383ebe7a712d711e28c626be9e0aaeed5379bb Reviewed-on: https://gerrit.libreoffice.org/74882 Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-06-29lokdialog: Convert the Format -> ... -> Line... to async execMuhammet Kara2-35/+48
For sw and sc Change-Id: If89bff982d16ba8d4e4524445e56ee2fe23d7876 Reviewed-on: https://gerrit.libreoffice.org/74880 Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-06-29lokdialog: Convert the Format -> ... -> Area... to async exec.Muhammet Kara3-39/+53
For sw and sc. Change-Id: I83ad76658545d8df135e1a08abff4d0b5a81b46a Reviewed-on: https://gerrit.libreoffice.org/74879 Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-06-29Give a parent to the AreaTabDialogMuhammet Kara1-1/+1
So that it can be used on lool side Change-Id: Ieb307c4625c29c366c2d84d6170b3e8c78e202d2 Reviewed-on: https://gerrit.libreoffice.org/74864 Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-06-29Give a parent to the Position and Size (Transform) dialogMuhammet Kara1-2/+2
So that it can be used on lool side Change-Id: If4b4e286f2f21ed8a5e9907f182878690c65bf5a Reviewed-on: https://gerrit.libreoffice.org/74881 Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-06-28tdf#126121: WebDAV redirection detectionMike Kaganski5-14/+41
This rewrites URI of a document opened from a WebDAV mapped UNC path on Windows (like "file://server/DavWWWRoot/Dir/Doc.odt") into HTTP URI (like "http://server/Dir/Doc.odt"). This allows using WebDAV protocol for these files, and e.g. get information about other user who locked the document to show when asking if open read-only or a copy. Change-Id: I643fa8df30d4b163783b279b1b973304fcafff37 Reviewed-on: https://gerrit.libreoffice.org/71746 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/74831
2019-06-28Register versions from 1 to 5 for SharePoint OpenDocuments objectMike Kaganski3-28/+64
This is required fro two reasons: 1. For our custom LOSPSupport.OpenDocuments, it allows SharePoint site's js code to properly find out the supported methods of the object. Previously we only registered v.1 for it, and that made SharePoint to assume that only older subset of methods is supported. 2. For SharePoint.OpenDocuments, which is used to register MS component to point to our implementation, leaving out v.4 and v.5 made problems on systems with co-existing MS Office; leftover registration of v.4 and v.5 resulted in mixed results: when opened from web view, documents used MS ActiveX, while for documents opened from list view in SharePoint, our ActiveX was used. Registering all versions produces consistent results. Change-Id: I7e8d4216cce1708e676c834a465654751f079c89 Reviewed-on: https://gerrit.libreoffice.org/74776 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit b8ecabc07a04537a1d1f317c83556e9d58abd318) Reviewed-on: https://gerrit.libreoffice.org/74780 Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-06-24fix iOS build for simulator definitionTomaž Vajngerl1-1/+0
--disable-kde5 is not recognised in cp-6.0 as it doesn't exist Change-Id: I463a09775c115c30c48b871a7499673dd7c956e0 Reviewed-on: https://gerrit.libreoffice.org/74619 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-06-24don't compile MediaPlaybackPanel if we don't have avmediaTomaž Vajngerl2-1/+7
This sidebar panel causes missing symbols when compiling for ios, where we disable avmedia support. Change-Id: Ib79a6debc27e5d5be4b4c388077ac1a3bf8c97b4 Reviewed-on: https://gerrit.libreoffice.org/74617 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-06-19android: Fix type of a C string to be const char[].cp-android-19Jan Holesovsky1-4/+6
With the wrong type, we were measusing the sizeof() wrongly, leading to a hard to catch crash at start that appeared only from time to time. Improve the concatenation too when at that. Change-Id: I4a4ab2909124281aac99118d66c62d669294d5f7 Reviewed-on: https://gerrit.libreoffice.org/74375 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-06-19sfx2 character map dialog: avoid double insert of glyphMiklos Vajna1-1/+0
The problem was that both the special character widget in SvxCharView::InsertCharToDoc() and the special character dialog in SvxCharacterMap::insertCharToDoc() reacted to KEY_RETURN, resulting in a double insertion. master has this resolved in commit 374599f8c26713905a310673d2b429083321186a (weld SvxCharacterMap dialog, 2018-03-22) already, do the minimal fix on this branch by reacting to KEY_RETURN only in the dialog. This is consistent with how the non-recent/favorite characters are handled, where also the dialog does the insertion, not the widget. Leaving the KEY_SPACE part unchanged, since that doesn't close the dialog, so no double insertion happens in that case. Change-Id: I9f75eb1d1b46cbbfe8dd4e160d245b5744acc8e0 Reviewed-on: https://gerrit.libreoffice.org/74360 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-06-18[cp] android: Default to colibre.Jan Holesovsky1-0/+7
Not ideal to use an ifdef, but I don't want to affect anything other than Android; and there is no need to up-stream this either, colibre is the default in master already. Change-Id: I3b1a29b69cfda89c8615586a5afc78fd1eca8c3e Reviewed-on: https://gerrit.libreoffice.org/74266 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-06-18android: Add the sidebar-related constructors to liblo-native-code.so.Jan Holesovsky1-0/+6
Change-Id: I25acb8965d190fc443d75357352e4d02c9b03cc2 Reviewed-on: https://gerrit.libreoffice.org/74265 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-06-18android: Define the icon theme in distro-configs and switch to colibre.Jan Holesovsky4-1/+3
No need to reinvent the wheel and hardcode it in configure.ac. Change-Id: Idb08ea0e5ce228bb0758dbdf023f3aee44da76eb Reviewed-on: https://gerrit.libreoffice.org/74247 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-06-18android: Fix non-debug build.Jan Holesovsky1-1/+1
Change-Id: If8bb944417da9a0aa6343d7dc87e7a1931689f1f Reviewed-on: https://gerrit.libreoffice.org/74147 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-06-17tdf#124907 vcl: react to pan gesture for listbox and other widgetsTomaž Vajngerl3-9/+19
Reviewed-on: https://gerrit.libreoffice.org/74087 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 08f485c6e92bd56c8c26171316b842cd213a8a09) Change-Id: I4579f8edd2bf24506b1d55a7291cd86e276f30a4 Reviewed-on: https://gerrit.libreoffice.org/74164 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-06-17lok: send message when in place editingSzymon Kłos1-1/+6
Change-Id: I96d22cabeda1eb851116d556a5302394a0dd7f93 Reviewed-on: https://gerrit.libreoffice.org/73162 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-06-17lok: remove ext text event re-entrancy hazard.Michael Meeks1-0/+6
Change-Id: I7566c158330bab77589d422c61c64210727ab835 Reviewed-on: https://gerrit.libreoffice.org/73625 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/73756 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-06-17Introduce --enable-android-editingStephan Bergmann4-3/+14
...to select the experimental ...Editing... Android build variant. (Ignored for non-Android builds, but using libo_FUZZ_ARG_ENABLE anyway, just in case.) Change-Id: I670925ff358039e38edc29db69f48a78d484f133 Reviewed-on: https://gerrit.libreoffice.org/65077 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/74148 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-06-17Compile also the palette_neon_intrinsics file for ARMTor Lillqvist1-0/+1
Change-Id: I26deeefc8cf335f53aa55c8523cd08687f27b63b
2019-06-17android: Unregistering in runLoop() is important even on Android.Jan Holesovsky1-2/+2
Otherwise we get crashes in online Kit when attempting to shutdown reasonably cleanly and the poll kicks in. Change-Id: I9a1744b42fec9f8ffddc6094773bda943caedf2a Reviewed-on: https://gerrit.libreoffice.org/74056 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-06-12Add some more SAL_INFOsTor Lillqvist1-0/+4
Change-Id: I5b50df5ea6b99164d150f99ae4fd36cddde22a60
2019-06-11explictly exclude LibreLogo from XScript usageCaolán McNamara1-0/+13
Change-Id: I567647f0e2f8b82e4ef2995c673abe82f4564228 Reviewed-on: https://gerrit.libreoffice.org/73659 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-11sanitize LibreLogo callsLászló Németh1-1/+50
Change-Id: Ie4d9858e5b4b3e55ab08416fb9338d2df34ee5e1 Reviewed-on: https://gerrit.libreoffice.org/73627 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-06-11It is not a good idea to allocate a UNO object staticallyTor Lillqvist1-4/+12
I should have known that. But sometimes you subconsciously just want things to be easy for change. But no. This fixes a problem that showed up in CppunitTest_services. Change-Id: Iaefcbe4a07716f4d1b2c269627a99d43e3738af3
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-26 14:41:09 +0000