summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2020-01-06Bump version to 6.0-36co-6.0-36Andras Timar1-1/+1
Change-Id: I8a6a66b47d5fc6aaf774b948f06678bc870a1503 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86276 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-12-31Remove broken MergeDataHashMap optimizationStephan Bergmann2-160/+13
...which apparently didn't take into account that inserting into a std::unordered_map may invalidate iterators, which now started to cause build failures like > [PRP] dictionaries/hu_HU/dialog/hu_HU_de > warn:sal.osl:25175:25175:sal/osl/unx/thread.cxx:1026: RTL_TEXTENCODING_DONTKNOW -> _ASCII_US > .../gcc/trunk/inst/include/c++/9.0.1/debug/safe_iterator.h:307: > In function: > __gnu_debug::_Safe_iterator<_Iterator, _Sequence, _Category>::pointer > __gnu_debug::_Safe_iterator<_Iterator, _Sequence, > _Category>::operator->() const [with _Iterator = > std::__detail::_Node_iterator<std::pair<const rtl::OString, > std::unique_ptr<MergeData> >, false, true>; _Sequence = > std::__debug::unordered_map<rtl::OString, std::unique_ptr<MergeData> >; > _Category = std::forward_iterator_tag; > __gnu_debug::_Safe_iterator<_Iterator, _Sequence, _Category>::pointer = > std::pair<const rtl::OString, std::unique_ptr<MergeData> >*] > > Error: attempt to dereference a singular iterator. > > Objects involved in the operation: > iterator "this" @ 0x0x5a8228 { > type = std::__detail::_Node_iterator<std::pair<rtl::OString const, std::unique_ptr<MergeData, std::default_delete<MergeData> > >, false, true> (mutable iterator); > state = singular; > references sequence with type 'std::__debug::unordered_map<rtl::OString, std::unique_ptr<MergeData, std::default_delete<MergeData> >, std::hash<rtl::OString>, std::equal_to<rtl::OString>, std::allocator<std::pair<rtl::OString const, std::unique_ptr<MergeData, std::default_delete<MergeData> > > > >' @ 0x0x5a81c8 > } > /bin/sh: line 1: 25175 Aborted (core dumped) LD_LIBRARY_PATH=${LD_LIBRARY_PATH:+$LD_LIBRARY_PATH:}"$I/program:$I/program" $W/LinkTarget/Executable/propex -i $S/dictionaries/hu_HU/dialog/hu_HU_en_US.properties -l de -m ${MERGEINPUT} -o $W/PropertiesTranslateTarget/dictionaries/hu_HU/dialog/hu_HU_de.properties > make[1]: *** [.../solenv/gbuild/Dictionary.mk:88: .../workdir/PropertiesTranslateTarget/dictionaries/hu_HU/dialog/hu_HU_de.properties] Error 134 with trunk libstdc++ in debug mode. Both classes MergeData and MergeDataHashMap became redundant. Reviewed-on: https://gerrit.libreoffice.org/69395 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit dc2329fb66dc38f62a21b1afaca38529d7e40fa9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85866 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com> (cherry picked from commit 0df20a65441cacb58cddfa6e5451691088bfcf8f) Change-Id: I771548a6155e14037d84acfd74cd13566a26a8d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85962 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-12-22tdf#128449 Set graphic when setting background in ImpressAron Budea1-6/+3
Regression from 905e6bd3ae0ca5c5ac7083430d7aa126c6526fd7 Change-Id: If0510967a339b6b46da2b7f798f478a46bd10b48 Reviewed-on: https://gerrit.libreoffice.org/85688 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 8304c671b19365e61d88a9133631775846a172a5) Reviewed-on: https://gerrit.libreoffice.org/85705 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2019-12-14tdf#129176: clear "TablePosition" grab bag when unfloating tableMike Kaganski1-0/+22
The operation explicitly changes the table to be not floating; this will change its position; yet when saving back to DOCX, saved values from the grab bag were used, incorrectly restoring table floating state. Change-Id: I19c185849443dc1a8b5ac974e09349c206b0506b Reviewed-on: https://gerrit.libreoffice.org/84446 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/84680 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2019-12-05tdf#128468: The RulerTab::nPos is in twipsTor Lillqvist1-1/+4
Do pass that as actual mm100 then. Change-Id: Ifc9608aeee838172a18cc07aa1dbe0d7f3f5fb6a Reviewed-on: https://gerrit.libreoffice.org/84473 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-12-04tdf#128468: Add tab stop information to LOK_CALLBACK_RULER_UPDATETor Lillqvist1-0/+12
Change-Id: I7872cdc3aabf66bb6d1df09f503274c698b64a4e Reviewed-on: https://gerrit.libreoffice.org/84420 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-12-04tdf#128468: Add Ruler::GetTabs()Tor Lillqvist2-0/+7
Change-Id: I785f8af1eec54f36721a354c4d3f82d8b86ceb86 Reviewed-on: https://gerrit.libreoffice.org/84419 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-12-04Add comment about confusion in SwCommentRuler::CreateJsonNotification()Tor Lillqvist1-1/+19
No code changes. Change-Id: Ibc46b3e55038e84f2ad80ff12b277b2e2c77a4ce
2019-12-03Add a comment telling what "frame margin" means hereTor Lillqvist1-0/+1
Change-Id: Ie6d088217c066ec3091fb28925947175cf62634f
2019-11-27tdf#128894: unit test for the bugfixDennis Francis2-0/+31
Reviewed-on: https://gerrit.libreoffice.org/83362 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com> (cherry picked from commit 626d1527267ab856e516f2424173104f781b8f09) Change-Id: Ic6d3910f12409f5af541c887760caefcb78b30f9 (cherry picked from commit b53374e26c1aa95461bbcdaf4a985ff4847b6e28) Reviewed-on: https://gerrit.libreoffice.org/83882 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-11-27tdf#128894: xlsx-import : Do not share tokens between cells...Dennis Francis3-7/+54
which are part of a xlsx-shared-formula along a *row*. If we do, any reference-updates on these cells while editing will mess things up. For example a shared formula "=A30+1" used for a few cells in the first row (say, A1, B1, C1 and D1) and on deleting a row, say row#5, the reference update operation will decrement the row index of all tokens in A1, B1, C1 and D1. But if they share tokens, they all end up pointing to row#26 instead of row#29 as each cell is updated which amounts to decrementing 4 times instead of once. However shared formulas along columns are not affected by this bug, when tokens are shared since we use formula-groups which only keeps one copy of token array for the entire group and reference-update code is designed to correctly work with formula-groups. Reviewed-on: https://gerrit.libreoffice.org/83361 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit b30251ca0d102ced36799ee18d4bbcd9e8530fa0) (cherry picked from commit 5a1cb68d574e0788a0bad4859acdd5005babb860) Change-Id: Ic0fe84d12fef18fbf21658664e2b2b86409bca27 Reviewed-on: https://gerrit.libreoffice.org/83881 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-11-26[cp] attempt to fix DMG background imageAndras Timar1-0/+0
It was pointing to /Users/timar/Dropbox/osxdndinstall.png so only I saw it, and nobody else told me, that the background was missing. Change-Id: I86da1618e21686817638d83ae7deeb9c7ecf51d1 Reviewed-on: https://gerrit.libreoffice.org/83764 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-11-20sw: insert image: set anchor to at-char by defaultMiklos Vajna1-4/+0
This changes the default set in commit 4f40bf6a79de6d60da0a5090cdfeda6242e889f0 (sw: insert image: set anchor to as-char by default, 2019-07-04), to have a better compromise, taking both Word defaults compatibility and usability into account. The problem is that users are used to just inserting an image and being able to drag it to its final location, which is broken with as-char anchoring. So default to at-char anchoring, this is still something that is fully interoperable to Word (unlike the old to-para anchoring), but allows the easier image move again. [ Testcase not backported, would depend on the original testcase from the above commit. ] (cherry picked from commit a7528cd6f17ea5c5b29e7d607e54c62de0d9e7db) Conflicts: sw/qa/extras/unowriter/unowriter.cxx sw/source/uibase/frmdlg/frmmgr.cxx Change-Id: Ibc61ae167fc9e5cc31b04c83e854556309e27fd4 Reviewed-on: https://gerrit.libreoffice.org/83263 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-18Resolves: tdf#120343 show pdf in async pdf export dialog callbackCaolán McNamara1-12/+23
not after dialog async exec begins, but defer to during that response callback Change-Id: I316022c01a87cf251d57b1007ae93fefddada776 Reviewed-on: https://gerrit.libreoffice.org/73717 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit d3655c22aa393dd70459f42bee547c39306e4bf0)
2019-11-13tdf#128466: Accept also JPEGTor Lillqvist1-1/+1
Change-Id: If8499cde875e03cb6c56259badd64ba6aee08a66 Reviewed-on: https://gerrit.libreoffice.org/82584 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-11-13tdf#128465: Enable pasting also JPEG images in presentation documentsTor Lillqvist1-1/+10
Change-Id: I0f3254ad536c26c975452f800a464f5498e66a78 Reviewed-on: https://gerrit.libreoffice.org/82507 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-11-11Fix copy/paste error that probably has had no ill effectTor Lillqvist1-1/+1
Change-Id: I062fef5f2316a3aa7560ecb42799496cd38362e9
2019-11-07Partially revert commit 7f0ef81cec7e4f64c7fbfce04372d84871244b11Mike Kaganski4-4/+4
... specifically the bits that disabled installation of components which must have crept into the patch by mistake from another change. Change-Id: Ie67767699a61fd9bced5b7a0595e10e84731bc59 Reviewed-on: https://gerrit.libreoffice.org/82163 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-01Don't bother with iOS earlier than 12.2Tor Lillqvist1-3/+3
Change-Id: I63d5dfcbda4c33c58757693d628de1bef84ac245
2019-11-01Accept iOS SDK 13.2Tor Lillqvist1-2/+2
Change-Id: I5d42a60a257661f39d1c9af6299ca3278f783d2b Reviewed-on: https://gerrit.libreoffice.org/81870 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-10-30tdf#128454: Make it possible to delete a table's single row or columnTor Lillqvist1-2/+2
It is already possible to delete all rows or all columns when there are multiple ones. So why it should be impossible to delete the single row or column when there is just one I can't understand. (This change is just one way to provide a workaround for the bug; the ideal would be if it was possible to specifically delete a whole table also in Impress documents, not just Writer ones.) Change-Id: If9221d248d59e515a110ff94cfb96fdd76aecafb Reviewed-on: https://gerrit.libreoffice.org/81789 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-10-23tdf#127939: Make slideshow touch input work properly again on iOS 13Tor Lillqvist1-24/+22
For some reason, navigator.userAgent in WebKit on iOS 13 claims it to be a Macintosh, so our old code to recognise iOS did not work any longer. Also the Hammer.js included in this file looked at navigator.userAgent and its decision what to do based on that did not work properly either. Simplify our code by handling swipe gestures all the time, even when such won't be generated (on mouse-only devices). Also, Hammer.JS was too eager to think it detected a pointer-only device based on the presense of window.PointerEvent. That sems to be present now in iOS 13. Let's not blindly think that means it is a pointer-only device. If the device supports touch events, don't bother with PointerEvents. Change-Id: I57d972415798967e871c6e262f16043561ed6af5 Reviewed-on: https://gerrit.libreoffice.org/81404 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-10-23tdf#128302: Use separate REALSVX_DLLIMPLEMENTATION for SvxRulerTor Lillqvist3-2/+37
We need to know that it really is in the svx library. Using the messed-up SVX_DLLIMPLEMENTATION means that code in the svxcore library thinks it is in the same svxcore library. Change-Id: I38baed3a26ecbd9d02037e60e44424e2235f9f20 Reviewed-on: https://gerrit.libreoffice.org/81281 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-10-23Add ooo.vba.word.XDocument.Close() method and implementTor Lillqvist3-0/+8
Will be needed in COLEAT. And seems like a fairly obviously missing API otherwise, too. Change-Id: I990c605a7e3f9cff3b72f20a626477d010da9852 Reviewed-on: https://gerrit.libreoffice.org/81369 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-10-23Add note that SwVbaDocuments::Close() does nothingTor Lillqvist1-0/+1
Change-Id: Ibf4d175b4b4a0b9f168401e52af6b0459aacd046 Reviewed-on: https://gerrit.libreoffice.org/81368 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-10-23tdf#127878: Use a larger "morebutton" image on iOSTor Lillqvist3-0/+7
Change-Id: Ifbd1b92a6921f7a283c3a7e288fbf05fbc2453eb Reviewed-on: https://gerrit.libreoffice.org/81379 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-10-21No bad macros from windows.h in external/pdfium (Windows --disable-pch)Stephan Bergmann1-0/+4
Change-Id: I036b6b8974481a59b6869115f216949a455451d0 Reviewed-on: https://gerrit.libreoffice.org/58003 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 81f06a142d3228a97341d0728d2aff761b5fd5a2) Reviewed-on: https://gerrit.libreoffice.org/81264 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-10-21Bump version to 6.0-35co-6.0-35Andras Timar1-1/+1
Change-Id: I96c82c3082989afe8ff256f2ce9e504012f54ecb Reviewed-on: https://gerrit.libreoffice.org/81209 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-10-19Improve checkStephan Bergmann1-1/+1
Change-Id: I8280a81eef2ced0ff0ace51ea9f094421abafe13 Reviewed-on: https://gerrit.libreoffice.org/78108 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 761e6dd25782420bf06e4a2ff3205a79b6cbb136) Reviewed-on: https://gerrit.libreoffice.org/78129 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-10-19Improve check for absolute URIStephan Bergmann1-1/+1
Change-Id: I4dee44832107f72f8f3fb68554428dc1e646c346 Reviewed-on: https://gerrit.libreoffice.org/77706 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit c79efeb66f7951305d0334bc288aee1c571a8728) Reviewed-on: https://gerrit.libreoffice.org/77724 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-19an absolute uri is invalid inputCaolán McNamara1-0/+5
Change-Id: I392be4282be8ed67e3451b28d2c9f22acd4c87fc Reviewed-on: https://gerrit.libreoffice.org/77564 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 3c076e54f736980e208f5c27ecf179aa90aea103) Reviewed-on: https://gerrit.libreoffice.org/77572 Tested-by: Jenkins
2019-10-17tdf#128021 Make "Anchor to character" the default for inserted images on iOSTor Lillqvist1-0/+4
Apparently this matches Word on iOS, even if Word on Windows has it the other way? Change-Id: I9949585e1d4e70627d47056dd92abffea24f0b28 Reviewed-on: https://gerrit.libreoffice.org/80986 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-10-14tdf#128139: add missing nullptr checkMike Kaganski1-1/+1
Regression after ef2ec07b4113fdadf863352c832af657b5ae205c Change-Id: I5eed95e8136a812813145283e6b533a808324380 Reviewed-on: https://gerrit.libreoffice.org/80782 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 8a69d0212fa7e3f7f8f2ccf29f9393b9414282a2) Reviewed-on: https://gerrit.libreoffice.org/80796 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2019-10-13tdf#125566 Add arrangement functions to position & size sidebarTomaž Vajngerl5-0/+142
Adds arrangement actions to position & size sidebar so it is possible to move the object up/down in the stack. As Draw/Impress uses it's own action names for the same UNO action (Forward/Back in Draw and ObjectForwardOne and ObjectBackOne in Writer/Calc) also add the global ones to Draw/Impress and connect them to the same function as Forward/Back. This commit does not unify them however (Forward/Back are still used in menus/toolbars) but this could be done in the future. Change-Id: Ibb152f29dbe11dfb1b6a057e6ea60b21029912e2 Reviewed-on: https://gerrit.libreoffice.org/80729 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit b2e5f9ead2bb7f2979afe4ba13e3950e8a3cc278) Reviewed-on: https://gerrit.libreoffice.org/80734 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2019-10-10Set RTL_OS to "iOS" for iOSTor Lillqvist1-0/+1
We accidentally had left it as "MacOSX". Affects at least the "generator" metadata stored in documents. Change-Id: I72eeefdbe192409084f7ab7a24adbc39dcafb624
2019-10-09tdf#128009: Allow spaces in AutoText suggestionsMike Kaganski8-118/+254
Currently autotext entries with long names starting with spaces, or containing spaces after first or second character, would never be suggested when SvxAutoCorrCfg::IsAutoTextTip() gives true (set in Tools -> AutoCorrect -> [x] Display remainder of name as suggestion while typing), because only a single word no less than 3 chars long left to cursor is considered a candidate for the name matching. This change allows to consider multiple chunks of text left to the cursor as the candidates for name matching. The chunks are 3-9 characters long, may start only between words, and have spaces, including leading. Thus, AutoText entries with long names like " Dr Foo" will now be suggested for an entry like "lorem dr f". Change-Id: If91c957341a4f4b281acb0e4ada558706ea2f8c1 Reviewed-on: https://gerrit.libreoffice.org/80392 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/80495 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/80530
2019-10-09tdf#126589: only consider text to the left of cursor as AutoText short nameMike Kaganski1-2/+3
Given a text "This is a dtfoo bar", and cursor inside "dtfoo" between "t" and "f", invoking AutoText function (F3) currently considers the whole word "dtfoo" as autotext short name. This changes it to only consider the part of the word to the left of cursor, i.e. only "dt" in the example. This removes the requirement to have a word boundary after the autotext short name. Change-Id: I6ba28e63fe25664131b7e03dda39ae997dffa464 Reviewed-on: https://gerrit.libreoffice.org/80419 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 810cddee6d2ef0f4057337d699a1a55323faa1ba) Reviewed-on: https://gerrit.libreoffice.org/80420 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 9b264707ec9da318da9344a139b810755020aa69) Reviewed-on: https://gerrit.libreoffice.org/80525
2019-10-09make impress sidebar work on iOS - missing PanelFactoryTomaž Vajngerl2-0/+5
add org_openoffice_comp_Draw_framework_PanelFactory_get_implementation make it build Change-Id: I738fe4c2d08437986976eaa29483c30a5ba42e62 Reviewed-on: https://gerrit.libreoffice.org/80514 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-10-09Accept iOS SDK 13.1Tor Lillqvist1-2/+2
Change-Id: I02870b35f67dd9ca47061311186d74dfec823aa7
2019-10-08tdf#107487 fix font fallback for non-BMP characters.Mark Hung1-3/+5
Non-BMP characters use two sal_Unicodes. It is necessary to advnace with OUString::iterateCodePoints safely instead of nCharPos + 1. Change-Id: Iea1005f05421b1021a9b3ff611439357d4dcba9e Reviewed-on: https://gerrit.libreoffice.org/73326 Tested-by: Jenkins Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> (cherry picked from commit 16faad3657fad114aa984f92a14a5f212a2f8ff5) Reviewed-on: https://gerrit.libreoffice.org/80467 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-10-07openssl 1.0.2tCaolán McNamara1-2/+2
Change-Id: Ideb980a07632e75e2bc7fffa851b8419e727c13b Reviewed-on: https://gerrit.libreoffice.org/80359 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-10-04lok preload: Some symbols are in-process when we need them.Jan Holesovsky1-5/+20
But OTOH in the preload case, the libraries we'd otherwise load are not there. An example was libcuilo.so where the instantiation of the spell checking dialog was failing, because it was impossible to find the makeSentenceEditWindow symbol. Change-Id: Ifc0bc5d8b295912728505fe3ce11fa4a0d198124 Reviewed-on: https://gerrit.libreoffice.org/80223 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-10-04tdf#127941: Don't be _that_ eager to assert(!IsTextEdit());Jan Holesovsky1-1/+4
Turns out that this is still a condition that can happen regularly: * open Impress * click an object with a spelling mistake * press F7 to activate the spelling dialog (don't choose it from the menu) => assert() It is unclear how to sort this out correctly without refactoring, and also unclear how many other cases fail this condition, so let's change to SAL_WARN_IF for the moment. Change-Id: I97730cc93c86c279973702bbf4ddc922f1616c0b Reviewed-on: https://gerrit.libreoffice.org/80169 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-10-03tdf#127766: Avoid ODR violation for class/struct FieldEntryTor Lillqvist1-0/+2
We had a class FieldEntry in registry/source/reflwrit.cxx and a struct FieldEntry in sd/source/filter/eppt/text.hxx. That causes problems when code from both is linked into one binary, as in the iOS and Android apps. The wrong FieldEntry destructor got called from the code in sd which of course lead to a crash. Fix by putting the one in registry into an unnamed namespace. (I put a large chunk of the source file in it while at it.) Change-Id: I1b32075f7aba256129b36ceb38eba605c882b9ff Reviewed-on: https://gerrit.libreoffice.org/80143 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-10-03tdf#127798: ios: change the default page height of the chart wizard dialogHenry Castro1-0/+4
The constant CHART_WIZARD_PAGEHEIGHT value determines the wizard dialog size, however for a custom theme for IOS those values have to be adjusted. After reading the WizardDialog implementation, there is no code related about chart wizard dialog auto-size. Change-Id: I6219d777bcc51f278ee10d834e8d0fe6c12f7918 Reviewed-on: https://gerrit.libreoffice.org/80087 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-10-03tdf#125565 always send the graphic selection for the tableTomaž Vajngerl2-16/+3
Reviewed-on: https://gerrit.libreoffice.org/80034 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit c9336bfb6bbf6d73d3f23c124262ade30133448d) Change-Id: I7085b2f1ddcfd83eccbbcaba4892cde95b6bd85c Reviewed-on: https://gerrit.libreoffice.org/80091 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-10-02lok: Enable sidebar also in Impress.Jan Holesovsky2-2/+2
The enabling in Impress caused a unit test (CppunitTest_sd_tiledrendering) breakage, so this commit also contains a partial revert of "sfx2: Re-enable the sidebars for LOK" It seems that all still works (the sidebar is showing), and the unit test passes with this. Unfortunately I failed to find the real root cause, and the problem is not present in master or in cp-6.2, so let's live with this for the moment I think. Change-Id: I6c5c7c82a3ad81e590a891f1a8cc76a873823acf Reviewed-on: https://gerrit.libreoffice.org/79839 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-10-02tdf#126959 fix mistake in table row/column resizingTomaž Vajngerl1-1/+1
A mistake when merging from master. Change-Id: Ia0b06523b6055c99d08a20a5c9a01eaae628ea3e Reviewed-on: https://gerrit.libreoffice.org/80013 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-09-30tdf#124377: enable anti-aliasing metafile during redactionAron Budea1-1/+2
Change-Id: I6c8a0f6ceaad5d9ec47cce1b00b8ccdd77530aaf Reviewed-on: https://gerrit.libreoffice.org/79266 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> (cherry picked from commit cd6780aae1392d4c1af0b15b311a4966834a9602) Reviewed-on: https://gerrit.libreoffice.org/79481 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-09-28sc lok: Optimize invalidation triggered by ScTabView::TabChanged() methodTamás Zolnai2-3/+16
We don't need to invalidate all parts of the document. It's enough to invalidate only that sheet which we changed to. Reviewed-on: https://gerrit.libreoffice.org/79500 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 96bd7504165f89ec5485d00a487e54634af347ce) Change-Id: I2c3aeb226c83bef473b0b33444b625e93d111b01 Reviewed-on: https://gerrit.libreoffice.org/79626 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/79769 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>