diff options
| -rw-r--r-- | compilerplugins/clang/literaltoboolconversion.cxx | 140 |
1 files changed, 140 insertions, 0 deletions
diff --git a/compilerplugins/clang/literaltoboolconversion.cxx b/compilerplugins/clang/literaltoboolconversion.cxx new file mode 100644 index 000000000000..a3779e24c38b --- /dev/null +++ b/compilerplugins/clang/literaltoboolconversion.cxx @@ -0,0 +1,140 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#include "clang/Lex/Lexer.h" + +#include "plugin.hxx" + +namespace { + +class LiteralToBoolConversion: + public RecursiveASTVisitor<LiteralToBoolConversion>, + public loplugin::RewritePlugin +{ +public: + explicit LiteralToBoolConversion(InstantiationData const & data): + RewritePlugin(data) {} + + virtual void run() override + { TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); } + + bool VisitImplicitCastExpr(ImplicitCastExpr const * expr); +}; + +bool LiteralToBoolConversion::VisitImplicitCastExpr( + ImplicitCastExpr const * expr) +{ + if (ignoreLocation(expr)) { + return true; + } + if (!expr->getType()->isBooleanType()) { + return true; + } + Expr const * sub = expr->getSubExpr()->IgnoreParenCasts(); + if (sub->getType()->isBooleanType()) { + return true; + } + IntegerLiteral const * lit = dyn_cast<IntegerLiteral>(sub); + if (lit != nullptr && lit->getValue().getLimitedValue() <= 1) { + SourceLocation loc { sub->getLocStart() }; + while (compiler.getSourceManager().isMacroArgExpansion(loc)) { + loc = compiler.getSourceManager().getImmediateMacroCallerLoc(loc); + } + if (compiler.getSourceManager().isMacroBodyExpansion(loc)) { + StringRef name { Lexer::getImmediateMacroName( + loc, compiler.getSourceManager(), compiler.getLangOpts()) }; + if (name == "sal_False" || name == "sal_True") { + loc = compiler.getSourceManager().getImmediateExpansionRange( + loc).first; + } + SourceLocation spl { compiler.getSourceManager().getSpellingLoc( + loc) }; + if (!compiler.getSourceManager().isInMainFile(spl) + && compiler.getSourceManager().getFilename(spl).endswith(".h")) + { + return true; + } + } + + } + if (isa<StringLiteral>(sub)) { + SourceLocation loc { sub->getLocStart() }; + if (compiler.getSourceManager().isMacroArgExpansion(loc) + && (Lexer::getImmediateMacroName( + loc, compiler.getSourceManager(), compiler.getLangOpts()) + == "assert")) + { + return true; + } + } + if (isa<IntegerLiteral>(sub) || isa<CharacterLiteral>(sub) + || isa<FloatingLiteral>(sub) || isa<ImaginaryLiteral>(sub) + || isa<StringLiteral>(sub)) + { + bool rewritten = false; + if (rewriter != nullptr) { + SourceLocation loc { compiler.getSourceManager().getExpansionLoc( + expr->getLocStart()) }; + if (compiler.getSourceManager().getExpansionLoc(expr->getLocEnd()) + == loc) + { + char const * s = compiler.getSourceManager().getCharacterData( + loc); + unsigned n = Lexer::MeasureTokenLength( + expr->getLocEnd(), compiler.getSourceManager(), + compiler.getLangOpts()); + std::string tok { s, n }; + if (tok == "sal_False" || tok == "0") { + rewritten = replaceText( + compiler.getSourceManager().getExpansionLoc( + expr->getLocStart()), + n, "false"); + } else if (tok == "sal_True" || tok == "1") { + rewritten = replaceText( + compiler.getSourceManager().getExpansionLoc( + expr->getLocStart()), + n, "true"); + } + } + } + if (!rewritten) { + report( + DiagnosticsEngine::Warning, + "implicit conversion (%0) of literal of type %1 to %2", + expr->getLocStart()) + << expr->getCastKindName() << expr->getSubExpr()->getType() + << expr->getType() << expr->getSourceRange(); + } + } else if (sub->isNullPointerConstant( + compiler.getASTContext(), Expr::NPC_ValueDependentIsNull) + != Expr::NPCK_NotNull) + { + report( + DiagnosticsEngine::Warning, + ("implicit conversion (%0) of null pointer constant of type %1 to" + " %2"), + expr->getLocStart()) + << expr->getCastKindName() << expr->getSubExpr()->getType() + << expr->getType() << expr->getSourceRange(); + } else if (sub->isIntegerConstantExpr(compiler.getASTContext())) { + report( + DiagnosticsEngine::Warning, + ("implicit conversion (%0) of integer constant expression of type" + " %1 to %2"), + expr->getLocStart()) + << expr->getCastKindName() << expr->getSubExpr()->getType() + << expr->getType() << expr->getSourceRange(); + } + return true; +} + +loplugin::Plugin::Registration<LiteralToBoolConversion> X( + "literaltoboolconversion", true); + +} |