diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-05-24 15:47:30 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-05-25 21:46:49 +0200 |
| commit | 3a51daeace695ead38cfd82b3a0f1e6f25a32e0f (patch) | |
| tree | af3ef1144aef6ed62f4ab99b88d13b41bd3b3694 /xmlscript | |
| parent | ff3bdde2527123fc9e011ff0d93e958174632186 (diff) | |
Improve re-throwing of UNO exceptions
(*) if we are already throwing a Wrapped*Exception, get the
exception using cppu::getCaughtexception.
(*) when catching and then immediately throwing UNO exceptions,
use cppu::getCaughtException to prevent exception slicing
(*) if we are going to catch an exception and then
immediately throw a RuntimeException, rather throw a
WrappedTargetRuntimeException and preserve the original exception information.
Change-Id: Ia7a501a50ae0e6f4d05186333c8517fdcb17d558
Reviewed-on: https://gerrit.libreoffice.org/54692
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'xmlscript')
| -rw-r--r-- | xmlscript/source/xmldlg_imexp/xmldlg_impmodels.cxx | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/xmlscript/source/xmldlg_imexp/xmldlg_impmodels.cxx b/xmlscript/source/xmldlg_imexp/xmldlg_impmodels.cxx index d78e9a55579e..344591d566ae 100644 --- a/xmlscript/source/xmldlg_imexp/xmldlg_impmodels.cxx +++ b/xmlscript/source/xmldlg_imexp/xmldlg_impmodels.cxx @@ -29,6 +29,7 @@ #include <com/sun/star/document/XStorageBasedDocument.hpp> #include <com/sun/star/xml/sax/SAXException.hpp> +#include <cppuhelper/exc_hlp.hxx> #include <sal/log.hxx> #include <i18nlangtag/languagetag.hxx> @@ -539,9 +540,10 @@ void FormattedFieldElement::endElement() } catch (const util::MalformedNumberFormatException & exc) { - SAL_WARN( "xmlscript.xmldlg", "### util::MalformedNumberFormatException occurred!" ); + css::uno::Any anyEx = cppu::getCaughtException(); + SAL_WARN( "xmlscript.xmldlg", exc ); // rethrow - throw xml::sax::SAXException( exc.Message, Reference< XInterface >(), Any() ); + throw xml::sax::SAXException( exc.Message, Reference< XInterface >(), anyEx ); } } ctx.importBooleanProperty("TreatAsNumber", "treat-as-number" , _xAttributes ); |