diff options
| author | Eike Rathke <erack@redhat.com> | 2016-11-17 19:52:10 +0100 |
|---|---|---|
| committer | Andras Timar <andras.timar@collabora.com> | 2017-02-08 11:56:05 +0100 |
| commit | d1d4b36c77324659dbd7139b4dcdc21464293dbc (patch) | |
| tree | 98138c1c2282f078ddc65f09b95a7e0f8869bce0 /xmloff | |
| parent | c25ee4e41f4ecb9af970453eb0bba34835e5d1d9 (diff) | |
ODF: do not write an empty style:text-position="" attribute for CharEscapement
... and CharEscapementHeight if the Any is void.
This was a real error complained about in the officeotron validation
https://bugs.documentfoundation.org/attachment.cgi?id=128411
https://bugs.documentfoundation.org/show_bug.cgi?id=103493
Also showed up as console warning
warn:legacy.osl:3269:1:xmloff/source/core/xmlerror.cxx:178: An error or a warning has occurred during XML import/export!
Error-Id: 0x20040003
Flags: 2 ERROR
Class: 4 API
Number: 3
Parameters:
0: CharEscapement
Exception-Message: UNKNOWN_PROPERTY
Position:
Public Identifier:
System Identifier: file:///.../103493-LotroPlan%203.8.ods
Row, Column: 2,1850164
Change-Id: Ifc634cc6b3d5d6dfa43741005ef0c9a1f7ff71fe
(cherry picked from commit 8aec9057a169acfda6f2d986af93edca54677fd2)
Reviewed-on: https://gerrit.libreoffice.org/30939
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit 775b75a696deb0ea1cc758aee8250663ddfc1d3a)
Diffstat (limited to 'xmloff')
| -rw-r--r-- | xmloff/source/style/escphdl.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/xmloff/source/style/escphdl.cxx b/xmloff/source/style/escphdl.cxx index 957370688dc6..9528f3b932e3 100644 --- a/xmloff/source/style/escphdl.cxx +++ b/xmloff/source/style/escphdl.cxx @@ -95,7 +95,7 @@ bool XMLEscapementPropHdl::exportXML( OUString& rStrExpValue, const uno::Any& rV } rStrExpValue = aOut.makeStringAndClear(); - return true; + return !rStrExpValue.isEmpty(); } |