diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-10-28 10:35:49 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-10-28 12:07:54 +0100 |
| commit | bc539bd3c04964471af6b5ca54264215c8995696 (patch) | |
| tree | c37af5b9fb3dc0b8677fc8dd535fb8e93ad6039d /xmloff/source | |
| parent | 9f78a4174e5099ad3af65a23e158a51c1afca54d (diff) | |
loplugin:stringadd improve detection
if one side of the expression is a compile-time-constant, we don't need
to worry about side-effects on the other side
Change-Id: Iee71ea51b327ef244bf39f128f921ac325d74e2b
Reviewed-on: https://gerrit.libreoffice.org/81589
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'xmloff/source')
| -rw-r--r-- | xmloff/source/core/unointerfacetouniqueidentifiermapper.cxx | 3 | ||||
| -rw-r--r-- | xmloff/source/draw/sdxmlexp.cxx | 4 |
2 files changed, 3 insertions, 4 deletions
diff --git a/xmloff/source/core/unointerfacetouniqueidentifiermapper.cxx b/xmloff/source/core/unointerfacetouniqueidentifiermapper.cxx index 6a7f4c7cac73..82159e0175fc 100644 --- a/xmloff/source/core/unointerfacetouniqueidentifiermapper.cxx +++ b/xmloff/source/core/unointerfacetouniqueidentifiermapper.cxx @@ -44,8 +44,7 @@ const OUString& UnoInterfaceToUniqueIdentifierMapper::registerReference( const R } else { - OUString aId( "id" ); - aId += OUString::number( mnNextId++ ); + OUString aId = "id" + OUString::number( mnNextId++ ); return (*maEntries.emplace( aId, xRef ).first).first; } } diff --git a/xmloff/source/draw/sdxmlexp.cxx b/xmloff/source/draw/sdxmlexp.cxx index 930539053467..212f6060edae 100644 --- a/xmloff/source/draw/sdxmlexp.cxx +++ b/xmloff/source/draw/sdxmlexp.cxx @@ -689,8 +689,8 @@ bool SdXMLExport::ImpPrepAutoLayoutInfo(const Reference<XDrawPage>& xPage, OUStr { pNew = new ImpXMLAutoLayoutInfo(nType, pInfo); mvAutoLayoutInfoList.emplace_back( pNew ); - OUString sNewName = "AL"; - sNewName += OUString::number(mvAutoLayoutInfoList.size() - 1); + OUString sNewName = + "AL" + OUString::number(mvAutoLayoutInfoList.size() - 1); sNewName += "T" + OUString::number(nType); pNew->SetLayoutName(sNewName); } |