summaryrefslogtreecommitdiff
path: root/writerfilter
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2018-02-26 12:30:57 +0000
committerCaolán McNamara <caolanm@redhat.com>2018-02-26 18:33:16 +0100
commitbefd67bcd0607bf2f0116a5418f3c7278e471631 (patch)
tree09ce7a0af1e393b5a260f1cfaacf975268d58622 /writerfilter
parent71a99a730229fac391822fb164661017c9409b56 (diff)
forcepoint #10 pop empty stack
Change-Id: I96452a86187a6b03251614625445d1b18a5ee218 Reviewed-on: https://gerrit.libreoffice.org/50359 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'writerfilter')
-rw-r--r--writerfilter/source/dmapper/DomainMapperTableManager.cxx6
-rw-r--r--writerfilter/source/dmapper/TableManager.cxx2
-rw-r--r--writerfilter/source/rtftok/rtfdispatchvalue.cxx2
3 files changed, 7 insertions, 3 deletions
diff --git a/writerfilter/source/dmapper/DomainMapperTableManager.cxx b/writerfilter/source/dmapper/DomainMapperTableManager.cxx
index 7b2d188346f6..e7a93f6c2192 100644
--- a/writerfilter/source/dmapper/DomainMapperTableManager.cxx
+++ b/writerfilter/source/dmapper/DomainMapperTableManager.cxx
@@ -463,6 +463,12 @@ void DomainMapperTableManager::startLevel( )
void DomainMapperTableManager::endLevel( )
{
+ if (m_aTableGrid.empty())
+ {
+ SAL_WARN("writerfilter.dmapper", "Table stack is empty");
+ return;
+ }
+
m_aTableGrid.pop_back( );
m_aGridSpans.pop_back( );
diff --git a/writerfilter/source/dmapper/TableManager.cxx b/writerfilter/source/dmapper/TableManager.cxx
index 381111f7d0fa..697d109136d0 100644
--- a/writerfilter/source/dmapper/TableManager.cxx
+++ b/writerfilter/source/dmapper/TableManager.cxx
@@ -255,8 +255,6 @@ void TableManager::endParagraphGroup()
if (mnTableDepth > 0)
{
- TableData::Pointer_t pTableData = mTableDataStack.top();
-
if (isRowEnd())
{
endOfRowAction();
diff --git a/writerfilter/source/rtftok/rtfdispatchvalue.cxx b/writerfilter/source/rtftok/rtfdispatchvalue.cxx
index 3125cab27b70..20379b4ef45f 100644
--- a/writerfilter/source/rtftok/rtfdispatchvalue.cxx
+++ b/writerfilter/source/rtftok/rtfdispatchvalue.cxx
@@ -215,7 +215,7 @@ RTFError RTFDocumentImpl::dispatchValue(RTFKeyword nKeyword, int nParam)
}
if (nSprm > 0)
{
- LanguageTag aTag((LanguageType(nParam)));
+ LanguageTag aTag((LanguageType(static_cast<sal_uInt16>(nParam))));
auto pValue = std::make_shared<RTFValue>(aTag.getBcp47());
putNestedAttribute(m_aStates.top().aCharacterSprms, NS_ooxml::LN_EG_RPrBase_lang, nSprm, pValue);
// Language is a character property, but we should store it at a paragraph level as well for fields.