summaryrefslogtreecommitdiff
path: root/writerfilter
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2016-08-18 12:27:49 +0100
committerCaolán McNamara <caolanm@redhat.com>2016-08-18 14:24:11 +0100
commit4630157e29f565c110f4fa11223a2d2358508c26 (patch)
treef27b9b6e953ec3ae433172229a596ab0bdc9d934 /writerfilter
parent8a6eb111609fbb1e0270ef5ba475b027635c9749 (diff)
cppcheck: passedByValue
Change-Id: I3ffcfe1294a1cbb06aadd3a1a79e9259876e38cc
Diffstat (limited to 'writerfilter')
-rw-r--r--writerfilter/source/ooxml/OOXMLPropertySet.cxx11
-rw-r--r--writerfilter/source/ooxml/OOXMLPropertySet.hxx4
2 files changed, 7 insertions, 8 deletions
diff --git a/writerfilter/source/ooxml/OOXMLPropertySet.cxx b/writerfilter/source/ooxml/OOXMLPropertySet.cxx
index 535421da31e0..8dde53290eef 100644
--- a/writerfilter/source/ooxml/OOXMLPropertySet.cxx
+++ b/writerfilter/source/ooxml/OOXMLPropertySet.cxx
@@ -30,9 +30,9 @@ namespace ooxml
using namespace ::std;
using namespace com::sun::star;
-OOXMLProperty::OOXMLProperty(Id id, OOXMLValue::Pointer_t pValue,
- OOXMLProperty::Type_t eType)
-: mId(id), mpValue(pValue), meType(eType)
+OOXMLProperty::OOXMLProperty(Id id, const OOXMLValue::Pointer_t& pValue,
+ OOXMLProperty::Type_t eType)
+ : mId(id), mpValue(pValue), meType(eType)
{
}
@@ -447,9 +447,8 @@ string OOXMLPropertySet::toString()
class OOXMLPropertySetValue
*/
-OOXMLPropertySetValue::OOXMLPropertySetValue
-(OOXMLPropertySet::Pointer_t pPropertySet)
-: mpPropertySet(pPropertySet)
+OOXMLPropertySetValue::OOXMLPropertySetValue(const OOXMLPropertySet::Pointer_t& pPropertySet)
+ : mpPropertySet(pPropertySet)
{
}
diff --git a/writerfilter/source/ooxml/OOXMLPropertySet.hxx b/writerfilter/source/ooxml/OOXMLPropertySet.hxx
index f37d22966e2b..f79cb680ff3c 100644
--- a/writerfilter/source/ooxml/OOXMLPropertySet.hxx
+++ b/writerfilter/source/ooxml/OOXMLPropertySet.hxx
@@ -58,7 +58,7 @@ private:
Type_t meType;
public:
- OOXMLProperty(Id id, OOXMLValue::Pointer_t pValue, Type_t eType);
+ OOXMLProperty(Id id, const OOXMLValue::Pointer_t& pValue, Type_t eType);
OOXMLProperty(const OOXMLProperty & rSprm);
virtual ~OOXMLProperty();
@@ -186,7 +186,7 @@ class OOXMLPropertySetValue : public OOXMLValue
{
OOXMLPropertySet::Pointer_t mpPropertySet;
public:
- explicit OOXMLPropertySetValue(OOXMLPropertySet::Pointer_t pPropertySet);
+ explicit OOXMLPropertySetValue(const OOXMLPropertySet::Pointer_t& pPropertySet);
virtual ~OOXMLPropertySetValue();
virtual writerfilter::Reference<Properties>::Pointer_t getProperties() override;