summaryrefslogtreecommitdiff
path: root/wizards
diff options
context:
space:
mode:
authorLuboš Luňák <l.lunak@suse.cz>2013-04-17 18:52:28 +0200
committerLuboš Luňák <l.lunak@suse.cz>2013-04-17 18:57:22 +0200
commitf22006dc6ac34a35a060e15466cf6b2d2058617d (patch)
tree6f23fa01b4249dec65598c0a4adab8fba541bcba /wizards
parenta43cc9ec8dde4f311bcf8ff96e6a26d56b2abdcf (diff)
fix stupid over-optimization
There's so little to be gained by storing pointers to simple or refcounted types instead of using an instance. At least SwTxtNode::GetMinMaxSize() and SwTxtNode::GetScalingOfSelectedText() pass string temporaries to SwDrawTextInfo, so keeping a pointer is clearly broken, and MSVC manages to optimize the code enough to crash because of this. As all the pointers point to const references and are accesses using const references as well, there shouldn't be any harm in making a copy. This fixes smoketest crash on Windows. Change-Id: I7d7cb42e175a2e64fe9c84c98c0d0204a0c25c13
Diffstat (limited to 'wizards')
0 files changed, 0 insertions, 0 deletions